Re: [netsniff-ng] Re: [PATCH] netsniff-ng: Show packet number

2015-04-27 Thread Vadim Kochan
> > Why pass the count as as pointer in the first place? I'd rather pass it > by value and do the increment at the calling site (even if it means a > bit of code duplication). I will re-work this, thanks. -- You received this message because you are subscribed to the Google Groups "netsniff-ng

Re: [netsniff-ng] Re: [PATCH] netsniff-ng: Show packet number

2015-04-27 Thread Tobias Klauser
On 2015-04-25 at 09:07:35 +0200, Vadim Kochan wrote: > On Thu, Apr 23, 2015 at 02:24:16PM +0300, Vadim Kochan wrote: > > static inline void __show_frame_hdr(uint8_t *packet, size_t len, int > > linktype, > > struct sockaddr_ll *s_ll, void *raw_hdr, > > -

[netsniff-ng] Re: [PATCH] netsniff-ng: Show packet number

2015-04-25 Thread Vadim Kochan
On Thu, Apr 23, 2015 at 02:24:16PM +0300, Vadim Kochan wrote: > static inline void __show_frame_hdr(uint8_t *packet, size_t len, int > linktype, > struct sockaddr_ll *s_ll, void *raw_hdr, > - int mode, bool v3) > +