[PATCH] HTTP/2: add debug logging of control frames

2017-06-19 Thread Piotr Sikora via nginx-devel
# HG changeset patch # User Piotr Sikora # Date 1490516711 25200 # Sun Mar 26 01:25:11 2017 -0700 # Node ID 1f1549823fba355a0dd1af49108be4b4898bf331 # Parent d1816a2696de8c2faa1cd913a151e5f62a8620f3 HTTP/2: add debug logging of control frames. Signed-off-by: Piotr Sikora diff -r d1816a269

Re: [PATCH] HTTP/2: add debug logging of control frames

2017-06-19 Thread Piotr Sikora via nginx-devel
Hey Valentin, > Ok, I've already resigned myself to multiline output, but don't let it > look like an another SETTINGS frame. > > IMHO, something like that will be good enough: > >http2 send SETTINGS frame >http2 SETTINGS param MAX_CONCURRENT_STREAMS: 100 >http2 SETTINGS param INITIAL_

Re: [PATCH] HTTP/2: add debug logging of control frames

2017-06-08 Thread Valentin V. Bartenev
On Tuesday 30 May 2017 14:21:05 Piotr Sikora via nginx-devel wrote: > Hey Valentin, > > > What do you suggest instead? All 3 params in the same line? > > > >http2 send SETTINGS frame MAX_CONCURRENT_STREAMS:%ui > > INITIAL_WINDOW_SIZE:%uz MAX_FRAME_SIZE:%ud > > > > What about receiving part, th

Re: [PATCH] HTTP/2: add debug logging of control frames

2017-05-30 Thread Piotr Sikora via nginx-devel
Hey Valentin, > What do you suggest instead? All 3 params in the same line? > >http2 send SETTINGS frame MAX_CONCURRENT_STREAMS:%ui > INITIAL_WINDOW_SIZE:%uz MAX_FRAME_SIZE:%ud > > What about receiving part, then? Do you want to put all 6 params in > the same line? > >http2 recv SETTINGS f

Re: [PATCH] HTTP/2: add debug logging of control frames

2017-04-24 Thread Piotr Sikora via nginx-devel
Hey Valentin, > I actually agree with that, but let's try to reduce the size of printing. > > http2 send SETTINGS frame MAX_CONCURRENT_STREAMS > http2 send SETTINGS frame INITIAL_WINDOW_SIZE > http2 send SETTINGS frame MAX_FRAME_SIZE > > This looks like too verbose for just one SETTINGS fram

Re: [PATCH] HTTP/2: add debug logging of control frames

2017-04-17 Thread Valentin V. Bartenev
On Friday 07 April 2017 14:42:07 Piotr Sikora via nginx-devel wrote: > Hey Valentin, > > > You can always find these values in configuration, and I can't remember a > > case where > > I've ever needed them. On the contrary, there's always a problem with the > > huge size > > of typical http/2 d

[PATCH] HTTP/2: add debug logging of control frames

2017-04-07 Thread Piotr Sikora via nginx-devel
# HG changeset patch # User Piotr Sikora # Date 1490516711 25200 # Sun Mar 26 01:25:11 2017 -0700 # Node ID 7414a1467d0684a73d091c508834973b944890cd # Parent 22be63bf21edaa1b8ea916c7d8cd4e5fe4892061 HTTP/2: add debug logging of control frames. Signed-off-by: Piotr Sikora diff -r 22be63bf2

Re: [PATCH] HTTP/2: add debug logging of control frames

2017-04-07 Thread Piotr Sikora via nginx-devel
Hey Valentin, > You can always find these values in configuration, and I can't remember a > case where > I've ever needed them. On the contrary, there's always a problem with the > huge size > of typical http/2 debug log. So it's not a good idea to add something just > because > we can. As s

Re: [PATCH] HTTP/2: add debug logging of control frames

2017-04-06 Thread Valentin V. Bartenev
On Monday 03 April 2017 20:13:40 Piotr Sikora via nginx-devel wrote: > # HG changeset patch > # User Piotr Sikora > # Date 1490516711 25200 > # Sun Mar 26 01:25:11 2017 -0700 > # Node ID 06d6418afe6e73604aea707ef9c5802f5bf27bf4 > # Parent 22be63bf21edaa1b8ea916c7d8cd4e5fe4892061 > HTTP/2: ad

[PATCH] HTTP/2: add debug logging of control frames

2017-04-03 Thread Piotr Sikora via nginx-devel
# HG changeset patch # User Piotr Sikora # Date 1490516711 25200 # Sun Mar 26 01:25:11 2017 -0700 # Node ID 06d6418afe6e73604aea707ef9c5802f5bf27bf4 # Parent 22be63bf21edaa1b8ea916c7d8cd4e5fe4892061 HTTP/2: add debug logging of control frames. Signed-off-by: Piotr Sikora diff -r 22be63bf2