[GitHub] [incubator-shardingsphere] kimmking commented on a change in pull request #4922: Test case of OrchestrationProperties and NacosProperties

kimmking commented on a change in pull request #4922: Test case of OrchestrationProperties and NacosProperties URL: https://github.com/apache/incubator-shardingsphere/pull/4922#discussion_r397642508 ## File path: sharding-orchestration/sharding-orchestration-core/sharding-orchestr

[GitHub] [incubator-shardingsphere] kimmking commented on a change in pull request #4922: Test case of OrchestrationProperties and NacosProperties

kimmking commented on a change in pull request #4922: Test case of OrchestrationProperties and NacosProperties URL: https://github.com/apache/incubator-shardingsphere/pull/4922#discussion_r397642595 ## File path: sharding-orchestration/sharding-orchestration-center/sharding-orches

[GitHub] [incubator-shardingsphere] kimmking commented on a change in pull request #4922: Test case of OrchestrationProperties and NacosProperties

kimmking commented on a change in pull request #4922: Test case of OrchestrationProperties and NacosProperties URL: https://github.com/apache/incubator-shardingsphere/pull/4922#discussion_r397642375 ## File path: sharding-orchestration/sharding-orchestration-center/sharding-orches

[GitHub] [incubator-shardingsphere] kimmking commented on a change in pull request #4923: translate examples README.md document to chinese

kimmking commented on a change in pull request #4923: translate examples README.md document to chinese URL: https://github.com/apache/incubator-shardingsphere/pull/4923#discussion_r397643188 ## File path: examples/README_ZH.md ## @@ -0,0 +1,120 @@ +# ShardingSphere示例 + +1

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4916: add tableReferences in selectStatement

coveralls edited a comment on issue #4916: add tableReferences in selectStatement URL: https://github.com/apache/incubator-shardingsphere/pull/4916#issuecomment-603160941 ## Pull Request Test Coverage Report for [Build 10548](https://coveralls.io/builds/29599766) * **0** of **69**

[GitHub] [incubator-shardingsphere] kimmking commented on issue #4911: translatedocker-compos.md document to chinese

kimmking commented on issue #4911: translatedocker-compos.md document to chinese URL: https://github.com/apache/incubator-shardingsphere/pull/4911#issuecomment-603679011 @edidada we should modify the request changes. This

[GitHub] [incubator-shardingsphere] wangjing112 commented on issue #4835: interface PreciseShardingAlgorithm.doSharding this param PreciseShardingValue type error

wangjing112 commented on issue #4835: interface PreciseShardingAlgorithm.doSharding this param PreciseShardingValue type error URL: https://github.com/apache/incubator-shardingsphere/issues/4835#issuecomment-603680619 > Another way from zhangliang: > > > Long.parseLong(id) % 4

[GitHub] [incubator-shardingsphere] wangjing112 closed issue #4835: interface PreciseShardingAlgorithm.doSharding this param PreciseShardingValue type error

wangjing112 closed issue #4835: interface PreciseShardingAlgorithm.doSharding this param PreciseShardingValue type error URL: https://github.com/apache/incubator-shardingsphere/issues/4835 This is an automated message from t

[GitHub] [incubator-shardingsphere] ruanjiehui commented on issue #4922: Test case of OrchestrationProperties and NacosProperties

ruanjiehui commented on issue #4922: Test case of OrchestrationProperties and NacosProperties URL: https://github.com/apache/incubator-shardingsphere/pull/4922#issuecomment-603681910 @kimmking Thank you for pointing it out,I fix them. --

[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4929: optimize schema

codecov-io commented on issue #4929: optimize schema URL: https://github.com/apache/incubator-shardingsphere/pull/4929#issuecomment-603683240 # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4929?src=pr&el=h1) Report > Merging [#4929](https://codecov.io/gh/apache

[GitHub] [incubator-shardingsphere] coveralls commented on issue #4929: optimize schema

coveralls commented on issue #4929: optimize schema URL: https://github.com/apache/incubator-shardingsphere/pull/4929#issuecomment-603683464 ## Pull Request Test Coverage Report for [Build 2227](https://coveralls.io/builds/29599968) * **0** of **9** **(0.0%)** changed or added re

[GitHub] [incubator-shardingsphere] wuguowei19880907 opened a new issue #4930: why sharding has many unsupported operation

wuguowei19880907 opened a new issue #4930: why sharding has many unsupported operation URL: https://github.com/apache/incubator-shardingsphere/issues/4930 ## Question I know that the sharding has many unsupported operation like - AbstractUnsupportedOperationDataSource.setLoginTim

[GitHub] [incubator-shardingsphere] terrymanu closed issue #3873: Modify UI module for new orchestration.

terrymanu closed issue #3873: Modify UI module for new orchestration. URL: https://github.com/apache/incubator-shardingsphere/issues/3873 This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4915: Refactor UI for orchestration

terrymanu merged pull request #4915: Refactor UI for orchestration URL: https://github.com/apache/incubator-shardingsphere/pull/4915 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4929: optimize schema

coveralls edited a comment on issue #4929: optimize schema URL: https://github.com/apache/incubator-shardingsphere/pull/4929#issuecomment-603683464 ## Pull Request Test Coverage Report for [Build 10549](https://coveralls.io/builds/29600021) * **0** of **9** **(0.0%)** changed or

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4927: sync config-shadow.yaml to sharding-distribution

terrymanu merged pull request #4927: sync config-shadow.yaml to sharding-distribution URL: https://github.com/apache/incubator-shardingsphere/pull/4927 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #4930: why sharding has many unsupported operation

terrymanu commented on issue #4930: why sharding has many unsupported operation URL: https://github.com/apache/incubator-shardingsphere/issues/4930#issuecomment-603687046 ShardingSphere is an open source project. The project is not a final status, it still in dev mode. Please join and

[GitHub] [incubator-shardingsphere] terrymanu edited a comment on issue #4930: why sharding has many unsupported operation

terrymanu edited a comment on issue #4930: why sharding has many unsupported operation URL: https://github.com/apache/incubator-shardingsphere/issues/4930#issuecomment-603687046 ShardingSphere is an open source project. The project is not in final status, it still in dev mode. Please

[GitHub] [incubator-shardingsphere] menghaoranss commented on issue #3873: Modify UI module for new orchestration.

menghaoranss commented on issue #3873: Modify UI module for new orchestration. URL: https://github.com/apache/incubator-shardingsphere/issues/3873#issuecomment-603689039 The current menu has been adjusted to : ``` / ├─Config Center ├─Config Server ├─Rule Config ├

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4911: translatedocker-compos.md document to chinese

coveralls edited a comment on issue #4911: translatedocker-compos.md document to chinese URL: https://github.com/apache/incubator-shardingsphere/pull/4911#issuecomment-603074085 ## Pull Request Test Coverage Report for [Build 2228](https://coveralls.io/builds/29600160) * **0** of *

[GitHub] [incubator-shardingsphere] hailinmo commented on issue #4928: Make official website prominent in Apache way.

hailinmo commented on issue #4928: Make official website prominent in Apache way. URL: https://github.com/apache/incubator-shardingsphere/issues/4928#issuecomment-603689800 Please assign to me, thx. This is an automated mess

[GitHub] [incubator-shardingsphere] codecov-io edited a comment on issue #4922: Test case of OrchestrationProperties and NacosProperties

codecov-io edited a comment on issue #4922: Test case of OrchestrationProperties and NacosProperties URL: https://github.com/apache/incubator-shardingsphere/pull/4922#issuecomment-603669858 # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4922?src=pr&el=h1) Report

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4922: Test case of OrchestrationProperties and NacosProperties

coveralls edited a comment on issue #4922: Test case of OrchestrationProperties and NacosProperties URL: https://github.com/apache/incubator-shardingsphere/pull/4922#issuecomment-603671090 ## Pull Request Test Coverage Report for [Build 10552](https://coveralls.io/builds/29600275)

[GitHub] [incubator-shardingsphere] wuguowei19880907 commented on issue #4930: why sharding has many unsupported operation

wuguowei19880907 commented on issue #4930: why sharding has many unsupported operation URL: https://github.com/apache/incubator-shardingsphere/issues/4930#issuecomment-603694859 I will do that,but i wonder why just throw exception？ -

[GitHub] [incubator-shardingsphere] kimmking commented on a change in pull request #4922: Test case of OrchestrationProperties and NacosProperties

kimmking commented on a change in pull request #4922: Test case of OrchestrationProperties and NacosProperties URL: https://github.com/apache/incubator-shardingsphere/pull/4922#discussion_r397669264 ## File path: sharding-orchestration/sharding-orchestration-core/sharding-orchestr

[GitHub] [incubator-shardingsphere] menghaoranss commented on issue #4921: Is this UI module available ?

menghaoranss commented on issue #4921: Is this UI module available ? URL: https://github.com/apache/incubator-shardingsphere/issues/4921#issuecomment-603699654 @pkwenda you can refer to reply from @SanmuWangZJU , and we will add configuration examples on the UI in subsequent versions. -

[GitHub] [incubator-shardingsphere] kimmking commented on issue #4922: Test case of OrchestrationProperties and NacosProperties

kimmking commented on issue #4922: Test case of OrchestrationProperties and NacosProperties URL: https://github.com/apache/incubator-shardingsphere/pull/4922#issuecomment-60374 @ruanjiehui we should let an empty line at tail. ---

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4923: translate examples README.md document to chinese

coveralls edited a comment on issue #4923: translate examples README.md document to chinese URL: https://github.com/apache/incubator-shardingsphere/pull/4923#issuecomment-603358653 ## Pull Request Test Coverage Report for [Build 10553](https://coveralls.io/builds/29600588) * **0**

[GitHub] [incubator-shardingsphere] kimmking closed pull request #4929: optimize schema

kimmking closed pull request #4929: optimize schema URL: https://github.com/apache/incubator-shardingsphere/pull/4929 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #4930: why sharding has many unsupported operation

terrymanu commented on issue #4930: why sharding has many unsupported operation URL: https://github.com/apache/incubator-shardingsphere/issues/4930#issuecomment-603701254 You may know which do you want to do, what is your expected and design, how the current codes works. -

[GitHub] [incubator-shardingsphere] terrymanu edited a comment on issue #4930: why sharding has many unsupported operation

terrymanu edited a comment on issue #4930: why sharding has many unsupported operation URL: https://github.com/apache/incubator-shardingsphere/issues/4930#issuecomment-603701254 You may know which do you want to do, what is your expected and design, how the current code works. --

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4923: translate examples README.md document to chinese

terrymanu merged pull request #4923: translate examples README.md document to chinese URL: https://github.com/apache/incubator-shardingsphere/pull/4923 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-shardingsphere] ruanjiehui commented on issue #4922: Test case of OrchestrationProperties and NacosProperties

ruanjiehui commented on issue #4922: Test case of OrchestrationProperties and NacosProperties URL: https://github.com/apache/incubator-shardingsphere/pull/4922#issuecomment-603709965 > @ruanjiehui we should let an empty line at tail. @kimmking I try to edit file on github website,bu

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #4862: using "" will route to all datanode

terrymanu commented on issue #4862: using "" will route to all datanode URL: https://github.com/apache/incubator-shardingsphere/issues/4862#issuecomment-603712234 What is content in the class `org.apache.shardingsphere.sharding.rules.standard.SimpleHashShardingAlgorithm`?

[GitHub] [incubator-shardingsphere] liuhonglin opened a new issue #4931: Is there apm-sharding-sphere-4.x-plugin-7.0.0.jar for skywalking7.0

liuhonglin opened a new issue #4931: Is there apm-sharding-sphere-4.x-plugin-7.0.0.jar for skywalking7.0 URL: https://github.com/apache/incubator-shardingsphere/issues/4931 ShardingExecuteDataMap class path is org.apache.shardingsphere.core.execute.ShardingExecuteDataMap at version 4.0.0-

[GitHub] [incubator-shardingsphere] terrymanu edited a comment on issue #4862: using "" will route to all datanode

terrymanu edited a comment on issue #4862: using "" will route to all datanode URL: https://github.com/apache/incubator-shardingsphere/issues/4862#issuecomment-603712234 What is content in the class `org.apache.shardingsphere.sharding.rules.standard.SimpleHashShardingAlgorithm`? @ne

[GitHub] [incubator-shardingsphere] terrymanu edited a comment on issue #4862: using "" will route to all datanode

terrymanu edited a comment on issue #4862: using "" will route to all datanode URL: https://github.com/apache/incubator-shardingsphere/issues/4862#issuecomment-603712234 What is content in the class `org.apache.shardingsphere.sharding.rules.standard.SimpleHashShardingAlgorithm`? @ne

[GitHub] [incubator-shardingsphere] pkwenda commented on issue #4921: Is this UI module available ?

pkwenda commented on issue #4921: Is this UI module available ? URL: https://github.com/apache/incubator-shardingsphere/issues/4921#issuecomment-603714874 I have a question. Why YamlTableRuleConfiguration.java not have `defaultKeyGenerator` and `defaultDatabaseStrategy` field ？

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #4861: two tables left join with different routing rules are not supported

terrymanu commented on issue #4861: two tables left join with different routing rules are not supported URL: https://github.com/apache/incubator-shardingsphere/issues/4861#issuecomment-603715978 What is your sharding rule configuration?

[GitHub] [incubator-shardingsphere] pkwenda commented on issue #4921: Is this UI module available ?

pkwenda commented on issue #4921: Is this UI module available ? URL: https://github.com/apache/incubator-shardingsphere/issues/4921#issuecomment-603716428 I can run, and i can find info at zookeeper now ! thank you very much @SanmuWangZJU ![image](https://user-images.githubus

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #4660: can sharding-integration-test cover sharding-proxy ?

terrymanu commented on issue #4660: can sharding-integration-test cover sharding-proxy ? URL: https://github.com/apache/incubator-shardingsphere/issues/4660#issuecomment-603717305 Closed because nobody interest with it for now. ---

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #4760: Setting SQL timeout time in mybatis does not take effect after sharding- JDBC 4.0.0-RC2 is used

terrymanu commented on issue #4760: Setting SQL timeout time in mybatis does not take effect after sharding- JDBC 4.0.0-RC2 is used URL: https://github.com/apache/incubator-shardingsphere/issues/4760#issuecomment-603716903 @ma1562013338 Can you provide a design? Then we can discuss further

[GitHub] [incubator-shardingsphere] ruanjiehui commented on issue #4922: Test case of OrchestrationProperties and NacosProperties

ruanjiehui commented on issue #4922: Test case of OrchestrationProperties and NacosProperties URL: https://github.com/apache/incubator-shardingsphere/pull/4922#issuecomment-603717123 When edit on github website,if I need add an empty line at tail of file,I should add two empty lines. ---

[GitHub] [incubator-shardingsphere] terrymanu closed issue #4660: can sharding-integration-test cover sharding-proxy ?

terrymanu closed issue #4660: can sharding-integration-test cover sharding-proxy ? URL: https://github.com/apache/incubator-shardingsphere/issues/4660 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-shardingsphere] wuguowei19880907 commented on issue #4930: why sharding has many unsupported operation

wuguowei19880907 commented on issue #4930: why sharding has many unsupported operation URL: https://github.com/apache/incubator-shardingsphere/issues/4930#issuecomment-603717708 I actually want to know why these unsupported APIs throw exceptions instead of calling native APIs to support t

[GitHub] [incubator-shardingsphere] KomachiSion opened a new pull request #4932: Add sharding scaling english documents

KomachiSion opened a new pull request #4932: Add sharding scaling english documents URL: https://github.com/apache/incubator-shardingsphere/pull/4932 This is an automated message from the Apache Git Service. To respond to th

[GitHub] [incubator-shardingsphere] menghaoranss opened a new issue #4933: Update UI documents

menghaoranss opened a new issue #4933: Update UI documents URL: https://github.com/apache/incubator-shardingsphere/issues/4933 - [ ] 1. Add `Config Center` menu below `4.1 Sharding-UI/4.4.1 Manual` after `Build` - [ ] 2. Add `Config Center` page and add some descriptions about `Config

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4924: Test case of EtcdProperties

coveralls edited a comment on issue #4924: Test case of EtcdProperties URL: https://github.com/apache/incubator-shardingsphere/pull/4924#issuecomment-603372219 ## Pull Request Test Coverage Report for [Build 10556](https://coveralls.io/builds/29601480) * **0** of **0** changed or

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4922: Test case of OrchestrationProperties and NacosProperties

coveralls edited a comment on issue #4922: Test case of OrchestrationProperties and NacosProperties URL: https://github.com/apache/incubator-shardingsphere/pull/4922#issuecomment-603671090 ## Pull Request Test Coverage Report for [Build 2229](https://coveralls.io/builds/29601629) *

[GitHub] [incubator-shardingsphere] coveralls commented on issue #4932: Add sharding scaling english documents

coveralls commented on issue #4932: Add sharding scaling english documents URL: https://github.com/apache/incubator-shardingsphere/pull/4932#issuecomment-603737119 ## Pull Request Test Coverage Report for [Build 2230](https://coveralls.io/builds/29601907) * **0** of **0** changed

[GitHub] [incubator-shardingsphere] edidada commented on issue #4911: translatedocker-compos.md document to chinese

edidada commented on issue #4911: translatedocker-compos.md document to chinese URL: https://github.com/apache/incubator-shardingsphere/pull/4911#issuecomment-603737780 > @edidada we should modify the request changes. @kimmking I have modify it --

[GitHub] [incubator-shardingsphere] minli04g opened a new pull request #4934: Remove Chinese in the English document. (#4913)

minli04g opened a new pull request #4934: Remove Chinese in the English document. (#4913) URL: https://github.com/apache/incubator-shardingsphere/pull/4934 Fixes #4913. Changes proposed in this pull request: - Remove Chinese in the English document. -

[GitHub] [incubator-shardingsphere] codecov-io edited a comment on issue #4922: Test case of OrchestrationProperties and NacosProperties

codecov-io edited a comment on issue #4922: Test case of OrchestrationProperties and NacosProperties URL: https://github.com/apache/incubator-shardingsphere/pull/4922#issuecomment-603669858 # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4922?src=pr&el=h1) Report

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4922: Test case of OrchestrationProperties and NacosProperties

coveralls edited a comment on issue #4922: Test case of OrchestrationProperties and NacosProperties URL: https://github.com/apache/incubator-shardingsphere/pull/4922#issuecomment-603671090 ## Pull Request Test Coverage Report for [Build 10559](https://coveralls.io/builds/29602216)

[GitHub] [incubator-shardingsphere] tristaZero closed issue #4913: The diagram in English document contains Chinese characters.

tristaZero closed issue #4913: The diagram in English document contains Chinese characters. URL: https://github.com/apache/incubator-shardingsphere/issues/4913 This is an automated message from the Apache Git Service. To res

[GitHub] [incubator-shardingsphere] tristaZero merged pull request #4934: Remove Chinese in the English document. (#4913)

tristaZero merged pull request #4934: Remove Chinese in the English document. (#4913) URL: https://github.com/apache/incubator-shardingsphere/pull/4934 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-shardingsphere] tristaZero commented on issue #4934: Remove Chinese in the English document. (#4913)

tristaZero commented on issue #4934: Remove Chinese in the English document. (#4913) URL: https://github.com/apache/incubator-shardingsphere/pull/4934#issuecomment-603745190 @minli04g Thanks for your contribution to the community. :-） --

[GitHub] [incubator-shardingsphere] tristaZero commented on issue #4913: The diagram in English document contains Chinese characters.

tristaZero commented on issue #4913: The diagram in English document contains Chinese characters. URL: https://github.com/apache/incubator-shardingsphere/issues/4913#issuecomment-603745729 The doc was updated by #4934, and the remaining one is to update the image.

[GitHub] [incubator-shardingsphere] minli04g opened a new issue #4913: The diagram in English document contains Chinese characters.

minli04g opened a new issue #4913: The diagram in English document contains Chinese characters. URL: https://github.com/apache/incubator-shardingsphere/issues/4913 ## Bug Report https://shardingsphere.apache.org/document/current/en/features/sharding/principle/rewrite/

[GitHub] [incubator-shardingsphere] terrymanu opened a new issue #4935: Pluggable for rewrite module

terrymanu opened a new issue #4935: Pluggable for rewrite module URL: https://github.com/apache/incubator-shardingsphere/issues/4935 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-shardingsphere] terrymanu closed issue #4868: Pluggable for route module

terrymanu closed issue #4868: Pluggable for route module URL: https://github.com/apache/incubator-shardingsphere/issues/4868 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4932: Add sharding scaling english documents

coveralls edited a comment on issue #4932: Add sharding scaling english documents URL: https://github.com/apache/incubator-shardingsphere/pull/4932#issuecomment-603737119 ## Pull Request Test Coverage Report for [Build 10560](https://coveralls.io/builds/29602596) * **0** of **0**

[GitHub] [incubator-shardingsphere] tristaZero commented on a change in pull request #4916: add tableReferences in selectStatement

tristaZero commented on a change in pull request #4916: add tableReferences in selectStatement URL: https://github.com/apache/incubator-shardingsphere/pull/4916#discussion_r397740522 ## File path: shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/test/java/org/apache/sh

[GitHub] [incubator-shardingsphere] tristaZero commented on a change in pull request #4916: add tableReferences in selectStatement

tristaZero commented on a change in pull request #4916: add tableReferences in selectStatement URL: https://github.com/apache/incubator-shardingsphere/pull/4916#discussion_r397733820 ## File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parse

[GitHub] [incubator-shardingsphere] tristaZero commented on a change in pull request #4916: add tableReferences in selectStatement

tristaZero commented on a change in pull request #4916: add tableReferences in selectStatement URL: https://github.com/apache/incubator-shardingsphere/pull/4916#discussion_r397740777 ## File path: shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apac

[GitHub] [incubator-shardingsphere] tristaZero commented on a change in pull request #4916: add tableReferences in selectStatement

tristaZero commented on a change in pull request #4916: add tableReferences in selectStatement URL: https://github.com/apache/incubator-shardingsphere/pull/4916#discussion_r397740349 ## File path: shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/test/resources/sql/dml/

[GitHub] [incubator-shardingsphere] tristaZero commented on a change in pull request #4916: add tableReferences in selectStatement

tristaZero commented on a change in pull request #4916: add tableReferences in selectStatement URL: https://github.com/apache/incubator-shardingsphere/pull/4916#discussion_r397739095 ## File path: shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apac

[GitHub] [incubator-shardingsphere] tristaZero commented on a change in pull request #4916: add tableReferences in selectStatement

tristaZero commented on a change in pull request #4916: add tableReferences in selectStatement URL: https://github.com/apache/incubator-shardingsphere/pull/4916#discussion_r397728755 ## File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parse

[GitHub] [incubator-shardingsphere] tristaZero commented on a change in pull request #4916: add tableReferences in selectStatement

tristaZero commented on a change in pull request #4916: add tableReferences in selectStatement URL: https://github.com/apache/incubator-shardingsphere/pull/4916#discussion_r397741574 ## File path: shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apac

[GitHub] [incubator-shardingsphere] codecov-io edited a comment on issue #4911: translatedocker-compos.md document to chinese

codecov-io edited a comment on issue #4911: translatedocker-compos.md document to chinese URL: https://github.com/apache/incubator-shardingsphere/pull/4911#issuecomment-603071834 # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4911?src=pr&el=h1) Report > Merging

[GitHub] [incubator-shardingsphere] waterMeteors opened a new issue #4936: execute statement what is "create database testName" error in sharding-proxy module

waterMeteors opened a new issue #4936: execute statement what is "create database testName" error in sharding-proxy module URL: https://github.com/apache/incubator-shardingsphere/issues/4936 execute statement what is "create database testName" error in sharding-proxy module the error in

[GitHub] [incubator-shardingsphere] cherrylzhao opened a new issue #4937: add sharding-transaction-spring module

cherrylzhao opened a new issue #4937: add sharding-transaction-spring module URL: https://github.com/apache/incubator-shardingsphere/issues/4937 we have developed a sharding-transaction-spring before in open-sharding repo, but it was coupled with aspectJ and hibernate library, which will m

[GitHub] [incubator-shardingsphere] waterMeteors commented on issue #4936: execute statement what is "create database testName" error in sharding-proxy module

waterMeteors commented on issue #4936: execute statement what is "create database testName" error in sharding-proxy module URL: https://github.com/apache/incubator-shardingsphere/issues/4936#issuecomment-603763935 the error information is : Exception occur: org.apache.shardingsphere

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4911: translatedocker-compos.md document to chinese

coveralls edited a comment on issue #4911: translatedocker-compos.md document to chinese URL: https://github.com/apache/incubator-shardingsphere/pull/4911#issuecomment-603074085 ## Pull Request Test Coverage Report for [Build 10561](https://coveralls.io/builds/29603064) * **0** of

[GitHub] [incubator-shardingsphere] yu199195 opened a new pull request #4938: code optimize for TableRule.

yu199195 opened a new pull request #4938: code optimize for TableRule. URL: https://github.com/apache/incubator-shardingsphere/pull/4938 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #4930: why sharding has many unsupported operation

terrymanu commented on issue #4930: why sharding has many unsupported operation URL: https://github.com/apache/incubator-shardingsphere/issues/4930#issuecomment-603772523 Just waiting for contribution This is an automated mes

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4938: code optimize for TableRule.

terrymanu merged pull request #4938: code optimize for TableRule. URL: https://github.com/apache/incubator-shardingsphere/pull/4938 This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [incubator-shardingsphere] terrymanu opened a new pull request #4939: Add SQLRouteRewriteEngine to provide a unified interface to process rewrite

terrymanu opened a new pull request #4939: Add SQLRouteRewriteEngine to provide a unified interface to process rewrite URL: https://github.com/apache/incubator-shardingsphere/pull/4939 Fixes #4935. This is an automated messag

[GitHub] [incubator-shardingsphere] tristaZero merged pull request #4939: Add SQLRouteRewriteEngine to provide a unified interface to process rewrite

tristaZero merged pull request #4939: Add SQLRouteRewriteEngine to provide a unified interface to process rewrite URL: https://github.com/apache/incubator-shardingsphere/pull/4939 This is an automated message from the Apache

[GitHub] [incubator-shardingsphere] tristaZero closed issue #4935: Pluggable for rewrite module

tristaZero closed issue #4935: Pluggable for rewrite module URL: https://github.com/apache/incubator-shardingsphere/issues/4935 This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #4922: Test case of OrchestrationProperties and NacosProperties

terrymanu commented on a change in pull request #4922: Test case of OrchestrationProperties and NacosProperties URL: https://github.com/apache/incubator-shardingsphere/pull/4922#discussion_r397766672 ## File path: sharding-orchestration/sharding-orchestration-center/sharding-orche

[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #4922: Test case of OrchestrationProperties and NacosProperties

terrymanu commented on a change in pull request #4922: Test case of OrchestrationProperties and NacosProperties URL: https://github.com/apache/incubator-shardingsphere/pull/4922#discussion_r397766749 ## File path: sharding-orchestration/sharding-orchestration-core/sharding-orchest

[GitHub] [incubator-shardingsphere] terrymanu closed issue #4820: Add test cases for TypedProperties implementation

terrymanu closed issue #4820: Add test cases for TypedProperties implementation URL: https://github.com/apache/incubator-shardingsphere/issues/4820 This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4924: Test case of EtcdProperties

terrymanu merged pull request #4924: Test case of EtcdProperties URL: https://github.com/apache/incubator-shardingsphere/pull/4924 This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [incubator-shardingsphere] terrymanu opened a new issue #4820: Add test cases for TypedProperties implementation

terrymanu opened a new issue #4820: Add test cases for TypedProperties implementation URL: https://github.com/apache/incubator-shardingsphere/issues/4820 Please add test cases for TypedProperties implementation. The example is `org.apache.shardingsphere.underlying.common.config.properties.

[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #4932: Add sharding scaling english documents

terrymanu commented on a change in pull request #4932: Add sharding scaling english documents URL: https://github.com/apache/incubator-shardingsphere/pull/4932#discussion_r397768280 ## File path: sharding-scaling/README.md ## @@ -8,7 +8,7 @@ The following figure may clear

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4922: Test case of OrchestrationProperties and NacosProperties

terrymanu merged pull request #4922: Test case of OrchestrationProperties and NacosProperties URL: https://github.com/apache/incubator-shardingsphere/pull/4922 This is an automated message from the Apache Git Service. To res

[GitHub] [incubator-shardingsphere] terrymanu closed issue #4820: Add test cases for TypedProperties implementation

terrymanu closed issue #4820: Add test cases for TypedProperties implementation URL: https://github.com/apache/incubator-shardingsphere/issues/4820 This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [incubator-shardingsphere] cherrylzhao opened a new pull request #4940: release cached transaction for BASE transaction type in proxy

cherrylzhao opened a new pull request #4940: release cached transaction for BASE transaction type in proxy URL: https://github.com/apache/incubator-shardingsphere/pull/4940 BASE transaction should not hold connections in transaction -

[GitHub] [incubator-shardingsphere] terrymanu opened a new pull request #4941: Code format for #4820

terrymanu opened a new pull request #4941: Code format for #4820 URL: https://github.com/apache/incubator-shardingsphere/pull/4941 Fixes #4820. This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [incubator-shardingsphere] tristaZero merged pull request #4941: Code format for #4820

tristaZero merged pull request #4941: Code format for #4820 URL: https://github.com/apache/incubator-shardingsphere/pull/4941 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-shardingsphere] coveralls commented on issue #4938: code optimize for TableRule.

coveralls commented on issue #4938: code optimize for TableRule. URL: https://github.com/apache/incubator-shardingsphere/pull/4938#issuecomment-603782730 ## Pull Request Test Coverage Report for [Build 10564](https://coveralls.io/builds/29603905) * **2** of **2** **(100.0%)** cha

[GitHub] [incubator-shardingsphere] jingshanglu commented on issue #4916: add tableReferences in selectStatement

jingshanglu commented on issue #4916: add tableReferences in selectStatement URL: https://github.com/apache/incubator-shardingsphere/pull/4916#issuecomment-603784997 @tristaZero I have changed base comment,please review. Thi

[GitHub] [incubator-shardingsphere] coveralls commented on issue #4939: Add SQLRouteRewriteEngine to provide a unified interface to process rewrite

coveralls commented on issue #4939: Add SQLRouteRewriteEngine to provide a unified interface to process rewrite URL: https://github.com/apache/incubator-shardingsphere/pull/4939#issuecomment-603786726 ## Pull Request Test Coverage Report for [Build 2231](https://coveralls.io/builds/296041

[GitHub] [incubator-shardingsphere] codecov-io edited a comment on issue #4916: add tableReferences in selectStatement

codecov-io edited a comment on issue #4916: add tableReferences in selectStatement URL: https://github.com/apache/incubator-shardingsphere/pull/4916#issuecomment-603157625 # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4916?src=pr&el=h1) Report > Merging [#491

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4932: Add sharding scaling english documents

coveralls edited a comment on issue #4932: Add sharding scaling english documents URL: https://github.com/apache/incubator-shardingsphere/pull/4932#issuecomment-603737119 ## Pull Request Test Coverage Report for [Build 2232](https://coveralls.io/builds/29604386) * **0** of **0**

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4916: add tableReferences in selectStatement

coveralls edited a comment on issue #4916: add tableReferences in selectStatement URL: https://github.com/apache/incubator-shardingsphere/pull/4916#issuecomment-603160941 ## Pull Request Test Coverage Report for [Build 10568](https://coveralls.io/builds/29604377) * **0** of **72**

[GitHub] [incubator-shardingsphere] kimmking opened a new pull request #4942: revise documents for orchestrationrefactoring

kimmking opened a new pull request #4942: revise documents for orchestrationrefactoring URL: https://github.com/apache/incubator-shardingsphere/pull/4942 Changes proposed in this pull request: - revise documents for orchestration refactoring -

[GitHub] [incubator-shardingsphere] coveralls commented on issue #4941: Code format for #4820

coveralls commented on issue #4941: Code format for #4820 URL: https://github.com/apache/incubator-shardingsphere/pull/4941#issuecomment-603793044 ## Pull Request Test Coverage Report for [Build 2234](https://coveralls.io/builds/29604533) * **0** of **0** changed or added relevant

[GitHub] [incubator-shardingsphere] jingshanglu commented on a change in pull request #4916: add tableReferences in selectStatement

jingshanglu commented on a change in pull request #4916: add tableReferences in selectStatement URL: https://github.com/apache/incubator-shardingsphere/pull/4916#discussion_r397790533 ## File path: shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apa

  1   2   >