Re: [PATCH] after gzgets(), Z_STREAM_END means EOF, not error

2020-04-14 Thread Olivier Taïbi
On Tue, Apr 14, 2020 at 05:38:32PM -0300, David Bremner wrote: > Olivier Taïbi writes: > > PS: out of curiosity, why bother with the --gzip feature in notmuch dump > > and restore when the user can simply pipe to/from a gzip/bzip2/xz/... > > command? > > I believe the original motivation (in

Re: timezone in notmuch

2020-04-14 Thread David Bremner
David Bremner writes: > > There's no user customizable variable for this. The code in this part of > notmuch show is fairly simple, so someone could probably figure out how > to pass (notmuch-show-get-timestamp) to the appropriate emacs function > to format the date in the local timezone. I

Re: timezone in notmuch

2020-04-14 Thread David Bremner
di...@santanas.co.za writes: > Greetings :) > > In notmuch-show-mode, some emails have a date like this: Date: Thu, 09 > Apr 2020 14:34:42 + while others like this Date: Sun, 12 Apr 2020 > 21:04:01 +0200 > > Is this something I can change in notmuch to always show the date/time > in my local

Re: [PATCH] gzerror() after gzclose_r() is a use after free

2020-04-14 Thread David Bremner
Olivier Taïbi writes: > As suggested by David Bremner in > https://notmuchmail.org/pipermail/notmuch/2020/029288.html > here is a separate patch for bug #2: calling gzerror() (indirectly via > gzerror_str()) after gzclose_r is a use after free, according to zlib's > manual. > Looks OK. The

Re: [PATCH] after gzgets(), Z_STREAM_END means EOF, not error

2020-04-14 Thread David Bremner
Olivier Taïbi writes: > As suggested by David Bremner in > https://notmuchmail.org/pipermail/notmuch/2020/029288.html > here is the patch for bug #3: after gzgets() returns NULL (meaning EOF > or error), the error code Z_STREAM_END means EOF and not error. > PS: out of curiosity, why bother

[PATCH] after gzgets(), Z_STREAM_END means EOF, not error

2020-04-14 Thread Olivier Taïbi
As suggested by David Bremner in https://notmuchmail.org/pipermail/notmuch/2020/029288.html here is the patch for bug #3: after gzgets() returns NULL (meaning EOF or error), the error code Z_STREAM_END means EOF and not error. Context: I am compiling notmuch on OpenBSD which has a rather old zlib

[PATCH] gzerror() after gzclose_r() is a use after free

2020-04-14 Thread Olivier Taïbi
As suggested by David Bremner in https://notmuchmail.org/pipermail/notmuch/2020/029288.html here is a separate patch for bug #2: calling gzerror() (indirectly via gzerror_str()) after gzclose_r is a use after free, according to zlib's manual. diff --git a/notmuch-restore.c b/notmuch-restore.c

Re: easy (?) elisp project for notmuch [it's mostly DONE]

2020-04-14 Thread Kyle Meyer
Jonas Bernoulli writes: > (I cannot actually reply to "easy (?) elisp project for notmuch" > because I wasn't subscribed yet when that was send.) [ in case it's useful in the future ] I've recently set up a public-inbox archive of notmuch here: https://yhetil.org/notmuch/ >From there,

Re: easy (?) elisp project for notmuch [it's mostly DONE]

2020-04-14 Thread David Bremner
Jonas Bernoulli writes: > I have already done this (and then some) a while ago. I want to have > another look before I submit it, but will try to get that done today. > > (I cannot actually reply to "easy (?) elisp project for notmuch" > because I wasn't subscribed yet when that was send.) >

Re: easy (?) elisp project for notmuch [it's mostly DONE]

2020-04-14 Thread Jonas Bernoulli
> As of Emacs 27, Emacs will start issuing deprecation warnings for > packages that load cl.el. I _think_ it's just a matter of replacing > functions and macros from cl.el with cl- prefixed ones, but I > haven't really investigated. > If someone is looking for an easy way to contribute, this

easy (?) elisp project for notmuch

2020-04-14 Thread David Bremner
As of Emacs 27, Emacs will start issuing deprecation warnings for packages that load cl.el. I _think_ it's just a matter of replacing functions and macros from cl.el with cl- prefixed ones, but I haven't really investigated. If someone is looking for an easy way to contribute, this cleanup

timezone in notmuch

2020-04-14 Thread divan
Greetings :) In notmuch-show-mode, some emails have a date like this: Date: Thu, 09 Apr 2020 14:34:42 + while others like this Date: Sun, 12 Apr 2020 21:04:01 +0200 Is this something I can change in notmuch to always show the date/time in my local timezone (SAST/+0200)?

Re: [PATCH] emacs: introduce notmuch-search-by-tag

2020-04-14 Thread David Edmondson
On Monday, 2020-04-13 at 22:10:50 +02, Keegan Carruthers-Smith wrote: > This is like notmuch-search-filter-by-tag, but creates a new search > rather than filtering the current search. We add this to > notmuch-common-keymap since this can be used by many contexts. We bind > to the key "t", which

Re: [PATCH] emacs: use def instead of initial-input for notmuch-show-browse-urls

2020-04-14 Thread David Edmondson
On Monday, 2020-04-13 at 21:58:19 +02, Keegan Carruthers-Smith wrote: > This is the non-deprecated way to use completing-read. Additionally > the old use was broken when using ivy for completing-read. For user's > using completing-read-default they won't see the default URL now, but > if they hit