this probably needs a more verbose commit message.
___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch
Daniel Kahn Gillmor writes:
> Signed-off-by: Daniel Kahn Gillmor
> ---
I wouldn't mind a remark about the code movement in the commit message
___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch
Daniel Kahn Gillmor writes:
> Note that we do keep ignoring the gpg_path configuration option,
> though, to avoid breakage of existing installations.
This remark confused me a bit, since it doesn't seem to reference
anything in the patch. It's a consequence of our ignoring any unknown
configurat
Daniel Kahn Gillmor writes:
> signed-off-by: Daniel Kahn Gillmor
> ---
> lib/index.cc | 3 +--
it seemed like there is more than GMimeCryptoContext arguments being
dropped.
Maybe a more fulsome commit message?
d
___
notmuch mailing list
notmu
Because of the order of the diff, this looks a bit mysterious. Should
probably mention dropping the compat API
___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch
Daniel Kahn Gillmor writes:
> Signed-off-by: Daniel Kahn Gillmor
> ---
> configure | 4
> 1 file changed, 4 deletions(-)
I think I'll squash this, and probably the next two into my initial
patch. Any objections?
d
___
notmuch mailing list
notmu
On Thu 2019-05-02 07:10:10 -0300, David Bremner wrote:
> Daniel Kahn Gillmor writes:
>
>> Signed-off-by: Daniel Kahn Gillmor
>> ---
>> configure | 4
>> 1 file changed, 4 deletions(-)
>
> I think I'll squash this, and probably the next two into my initial
> patch. Any objections?
squashing
On Thu 2019-05-02 06:50:41 -0300, David Bremner wrote:
> Daniel Kahn Gillmor writes:
>
>> Note that we do keep ignoring the gpg_path configuration option,
>> though, to avoid breakage of existing installations.
>
> This remark confused me a bit, since it doesn't seem to reference
> anything in the
Signed-off-by: Daniel Kahn Gillmor
---
configure | 4
1 file changed, 4 deletions(-)
diff --git a/configure b/configure
index 16bb0863..9140026a 100755
--- a/configure
+++ b/configure
@@ -497,7 +497,6 @@ if pkg-config --exists "gmime-3.0 > $GMIME_MINVER"; then
have_gmime=1
gmime_c
Several of these #defines were not actually used in the notmuch
codebase any longer. And as of GMime 3.0, g_mime_init takes no
arguments, so we can also drop the bogus RFC2047 argument that we were
passing and then #defining away.
signed-off-by: Daniel Kahn Gillmor
---
lib/database.cc| 2 +-
This means dropping GMimeCryptoContext and notmuch_config arguments.
All the argument changes are to internal functions, so this is not an
API or ABI break.
We also get to drop the #define for g_mime_3_unused.
signed-off-by: Daniel Kahn Gillmor
---
lib/index.cc | 3 +--
mime-node.c
This is a functional change, not a straight translation, because we
are no longer directly invoking g_mime_parser_options_get_default(),
but the GMime source has indicated that the options parameter for
g_mime_parser_construct_message() is "nullable" since upstream commit
d0ebdd2ea3e6fa635a2a551c84
From: David Bremner
GMime 3.0 is over 2 years old now, and 2.6 has been deprecated in
notmuch for about 1.5 years.
Comments and documentation no longer need to refer to GMime 2.6, so
clean them all up.
Signed-off-by: Daniel Kahn Gillmor
---
INSTALL | 2 +-
configure | 24 +-
note that "notmuch-show for message with invalid From" is still broken
in T310-emacs.sh. It would be good to debug what's going on there and
try to get it fixed!
signed-off-by: Daniel Kahn Gillmor
---
test/T190-multipart.sh | 2 --
test/T310-emacs.sh | 2 +-
test/T350-crypto.sh| 2 --
In _index_mime_part, we don't need to extract the content-type from
the part until just before we use it, so we also defer it lazily.
Signed-off-by: Daniel Kahn Gillmor
---
lib/index.cc | 22 +-
1 file changed, 1 insertion(+), 21 deletions(-)
diff --git a/lib/index.cc b/lib/
Signed-off-by: Daniel Kahn Gillmor
---
lib/index.cc | 4 ++--
notmuch-reply.c| 8
notmuch-show.c | 16
util/gmime-extra.h | 4
4 files changed, 14 insertions(+), 18 deletions(-)
diff --git a/lib/index.cc b/lib/index.cc
index f21761d0..41822488 1006
Several GMime 2.6 functions sprouted a change in the argument order in
GMime 3.0. We had a compatibility layer here to be able to handle
compiling against both GMime 2.6 and 3.0. Now that we're using 3.0
only, rip out the compatibility layer for those functions with changed
argument lists, and ex
GMime 3.0 and later can handle User ID as expected.
signed-off-by: Daniel Kahn Gillmor
---
test/T355-smime.sh | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/test/T355-smime.sh b/test/T355-smime.sh
index be45e3b1..e410286b 100755
--- a/test/T355-smime.sh
+++ b/test/T
Signed-off-by: Daniel Kahn Gillmor
---
notmuch-reply.c| 4 ++--
notmuch-show.c | 8
util/gmime-extra.h | 11 +++
3 files changed, 9 insertions(+), 14 deletions(-)
diff --git a/notmuch-reply.c b/notmuch-reply.c
index fa91c5de..48fdbc92 100644
--- a/notmuch-reply.c
+++ b
signed-off-by: Daniel Kahn Gillmor
---
lib/index.cc | 1 -
notmuch-reply.c| 2 --
util/gmime-extra.h | 1 -
3 files changed, 4 deletions(-)
diff --git a/lib/index.cc b/lib/index.cc
index 6b6fbb8f..76830921 100644
--- a/lib/index.cc
+++ b/lib/index.cc
@@ -591,7 +591,6 @@ _notmuch_messag
signed-off-by: Daniel Kahn Gillmor
---
lib/message-file.c | 42 -
notmuch-show.c | 21 ---
util/gmime-extra.c | 93 --
util/gmime-extra.h | 12 --
4 files changed, 168 deletions(-)
diff --git a/lib/message-file.c b/l
Note that we do keep ignoring the gpg_path configuration option,
though, to avoid breakage of existing installations. It is ignored
like any other unknown configuration option, but we at least document
that it is ignored so that people who find it in their legacy configs
can know that it's safe to
Our minimum version of GMime 3.0 always supports good session key
handling.
signed-off-by: Daniel Kahn Gillmor
---
configure | 9 -
lib/built-with.c | 2 +-
lib/index.cc | 4 +---
mime-node.c | 2 --
notmuch-show.c
I just realised that https://notmuchmail.org/releases/ holds both
LATEST-notmuch-0.28.2.tar.gz and LATEST-notmuch-0.28.3.tar.gz, which
seems to be one "latest" too many?
-Ralph
___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mail
Ralph Seichter writes:
> I just realised that https://notmuchmail.org/releases/ holds both
> LATEST-notmuch-0.28.2.tar.gz and LATEST-notmuch-0.28.3.tar.gz, which
> seems to be one "latest" too many?
fixed, thanks.
d
___
notmuch mailing list
notmuch@no
>>> I was thinking of a minimal change now, so it isn't blocking other
>>> things, and then a gradual cleanup.
>>
>> just go for it.
>
> You mean this patch, or the other more extensive patch that someone (TM)
> has to write?
Go for the full cleanup all at once.
___
On Wed, May 01 2019, David Bremner wrote:
> I was thinking of a minimal change now, so it isn't blocking other
> things, and then a gradual cleanup.
just go for it.
___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinf
27 matches
Mail list logo