Re: [OpenBabel-Devel] Proposal to require test cases

2018-04-16 Thread David van der Spoel
Den 2018-04-17 kl. 07:51, skrev Noel O'Boyle: To avoid digressing, absolutely we would like to do this and have the technical means to enforce...once we reduce the warnings. I did a certain amount already this year. Once a particular type of warning is eliminated we can add it as a requirement

Re: [OpenBabel-Devel] Proposal to require test cases

2018-04-16 Thread Noel O'Boyle
To avoid digressing, absolutely we would like to do this and have the technical means to enforce...once we reduce the warnings. I did a certain amount already this year. Once a particular type of warning is eliminated we can add it as a requirement using gcc's treat warnings as errors. But we're no

Re: [OpenBabel-Devel] Proposal to require test cases

2018-04-16 Thread David van der Spoel
Den 2018-04-16 kl. 22:46, skrev Dominik 'Rathann' Mierzejewski: On Monday, 16 April 2018 at 20:20, David van der Spoel wrote: Den 2018-04-16 kl. 17:36, skrev David Koes: I didn't chime in since I thought it was obviously a good idea. However, I strongly agree that the process of creating a test

Re: [OpenBabel-Devel] Proposal to require test cases

2018-04-16 Thread Dominik 'Rathann' Mierzejewski
On Monday, 16 April 2018 at 20:20, David van der Spoel wrote: > Den 2018-04-16 kl. 17:36, skrev David Koes: > > I didn't chime in since I thought it was obviously a good idea. > > However, I strongly agree that the process of creating a test case needs > > to be as simple and documented as possible

Re: [OpenBabel-Devel] Proposal to require test cases

2018-04-16 Thread Dominik 'Rathann' Mierzejewski
On Monday, 16 April 2018 at 21:59, Geoffrey Hutchison wrote: [...] > Keep in mind many (most?) of the warnings are from the InChI code > - which isn't something we want to mess with. Fixes for warnings in InChI should be sent upstream, to inchi-disc...@lists.sourceforge.net . Regards, Dominik --

Re: [OpenBabel-Devel] Proposal to require test cases

2018-04-16 Thread Geoffrey Hutchison
> How about making warning-free code a must? > Whenever I compile OB I get tons of warnings of potentially serious character. Patches that reduce/fix warnings are always accepted. :-) Julien Nabet (serval2412) has contributed *many* such patches. Keep in mind many (most?) of the warnings are fro

Re: [OpenBabel-Devel] Proposal to require test cases

2018-04-16 Thread David van der Spoel
Den 2018-04-16 kl. 17:36, skrev David Koes: I didn't chime in since I thought it was obviously a good idea. However, I strongly agree that the process of creating a test case needs to be as simple and documented as possible.  I had a test case with my last pull request, but it required a fair

Re: [OpenBabel-Devel] Proposal to require test cases

2018-04-16 Thread David Koes
I didn't chime in since I thought it was obviously a good idea. However, I strongly agree that the process of creating a test case needs to be as simple and documented as possible. I had a test case with my last pull request, but it required a fair amount of poking around to figure out how to b