Re: [devel] [PATCH 1 of 1] amfnd: add logs for HC start failures [#340]

2016-12-01 Thread Anders Widell
Yes, we can consider syslog messages with severity error (and critical) in the same way as core dumps - they indicate a bug /in the program that dumped core or produced the syslog message/. If I find a core dump of an OpenSAF service, I can write a defect ticket on that service. In the same way

Re: [devel] [PATCH 1 of 1] amfnd: add logs for HC start failures [#340]

2016-11-30 Thread Hans Nordebäck
HI Nagu, One strategy is in case if an error code is returned to the application, it is the application to select (or not) to log this as an error/notify etc. /Thanks HansN -Original Message- From: Nagendra Kumar [mailto:nagendr...@oracle.com] Sent: den 1 december 2016 07:38 To: Hans

Re: [devel] [PATCH 1 of 1] amfnd: add logs for HC start failures [#340]

2016-11-30 Thread Nagendra Kumar
Hi Hans, I had proposed this long time back in the ticket: " Nagendra Kumar - 2015-08-07 As part of ticket cleanup, evaluated and decided to keep it as enhancement. The logging should not be heavy and should only stick to state to the level of providing hints to the user. Perhaps, the lo

Re: [devel] [PATCH 1 of 1] amfnd: add logs for HC start failures [#340]

2016-11-30 Thread Hans Nordebäck
Hi Nagu, Not sure, but if these errors are not OpenSAF errors, i.e. not depending on application configuration, use etc. should they really be logged as errors? After running various OpenSAF tests there should be no errors in the syslog and there may be test case that will fail now, even thoug

Re: [devel] [PATCH 1 of 1] amfnd: add logs for HC start failures [#340]

2016-11-30 Thread Nagendra Kumar
Hi Hans, I find it more appropriate here as we are returning Error codes so log the information as Error :) Thanks -Nagu > -Original Message- > From: Hans Nordeback [mailto:hans.nordeb...@ericsson.com] > Sent: 29 November 2016 14:20 > To: Nagendra Kumar; Praveen Malviya; m

Re: [devel] [PATCH 1 of 1] amfnd: add logs for HC start failures [#340]

2016-11-29 Thread Nagendra Kumar
.net > Subject: Re: [devel] [PATCH 1 of 1] amfnd: add logs for HC start failures > [#340] > > Ack with minor comment > > There seems to be another place returning error code that's not logged > in hc start? > > || > (*o_comp)->pxy_comp-&g

Re: [devel] [PATCH 1 of 1] amfnd: add logs for HC start failures [#340]

2016-11-29 Thread Hans Nordeback
Hi Nagu, a question, why use LOG_ER and not LOG_WA below? /Thanks HansN On 11/04/2016 09:32 AM, nagendr...@oracle.com wrote: > osaf/services/saf/amf/amfnd/chc.cc | 7 +++ > 1 files changed, 7 insertions(+), 0 deletions(-) > > > diff --git a/osaf/services/saf/amf/amfnd/chc.cc > b/osaf/se

Re: [devel] [PATCH 1 of 1] amfnd: add logs for HC start failures [#340]

2016-11-29 Thread minh chau
gt;> minh.c...@dektech.com.au; gary@dektech.com.au >> Cc: opensaf-devel@lists.sourceforge.net >> Subject: [devel] [PATCH 1 of 1] amfnd: add logs for HC start failures [#340] >> >> osaf/services/saf/amf/amfnd/chc.cc | 7 +++ >> 1 files changed, 7 insertions(+

Re: [devel] [PATCH 1 of 1] amfnd: add logs for HC start failures [#340]

2016-11-28 Thread Nagendra Kumar
ts.sourceforge.net > Subject: [devel] [PATCH 1 of 1] amfnd: add logs for HC start failures [#340] > > osaf/services/saf/amf/amfnd/chc.cc | 7 +++ > 1 files changed, 7 insertions(+), 0 deletions(-) > > > diff --git a/osaf/services/saf/amf/amfnd/chc.cc > b/osaf/services/saf/

[devel] [PATCH 1 of 1] amfnd: add logs for HC start failures [#340]

2016-11-04 Thread nagendra . k
osaf/services/saf/amf/amfnd/chc.cc | 7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/osaf/services/saf/amf/amfnd/chc.cc b/osaf/services/saf/amf/amfnd/chc.cc --- a/osaf/services/saf/amf/amfnd/chc.cc +++ b/osaf/services/saf/amf/amfnd/chc.cc @@ -315,6 +315,7 @@ void avnd_