On 11 Jan 2024, at 13:01, Simon Horman wrote:
> On Wed, Jan 10, 2024 at 11:22:24AM +0100, Eelco Chaudron wrote:
>> This patch adds ASAN and UBSAN GitHub action tests for both
>> the userspace and kernel datapaths.
>>
>> Signed-off-by: Eelco Chaudron
>
> Acked-by: Simon Horman
Thanks, I’ve app
On 12 Jan 2024, at 11:19, Simon Horman wrote:
> On Thu, Jan 11, 2024 at 12:08:53AM +0100, Eelco Chaudron wrote:
>> This patch identifies new static analysis issues during a GitHub action
>> run and reports them. The process involves analyzing the changes introduced
>> in the current commit and
Replace and remove the ovn_smap_get_uint as smap_get_uint is avaiable in OvS
library since 7b2e999fd759 ("smap: Add smap_get_uint() helper function.").
Signed-off-by: Ales Musil
---
lib/ovn-util.c | 20
lib/ovn-util.h | 4
northd/northd.c | 6 +++---
3 files changed
There is no need to hold data in separate bitmap and simap as all the
zones that are already assigned are in the inc-engine sctructures.
Signed-off-by: Ales Musil
---
controller/ovn-controller.c | 22 +-
1 file changed, 5 insertions(+), 17 deletions(-)
diff --git a/controlle
Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: The subject summary should end with a dot.
Subject: util: Replace and remove ovn_smap_ge
From: Jakob Meng
For monitoring systems such as Prometheus it would be beneficial if
OVS would expose statistics in a machine-readable format.
This patch introduces support for different output formats to ovs-xxx
tools. They gain a global option '-f,--format' which allows users to
request JSON i
From: Jakob Meng
Compared to the previous patch series v5 [0] this v6 fixes missing command
callbacks in third patch only, i.e. in ipsec/ovs-monitor-ipsec.in and
vtep/ovs-vtep.in.
[0]
https://patchwork.ozlabs.org/project/openvswitch/list/?series=390829&archive=both&state=*
Jakob Meng (6):
From: Jakob Meng
Signed-off-by: Jakob Meng
---
NEWS | 3 +++
lib/unixctl.c | 4 ++--
lib/unixctl.h | 1 +
tests/pmd.at | 29 +++--
utilities/ovs-appctl.c | 22 +++---
5 files changed, 52 insertions(+), 7 de
From: Jakob Meng
Signed-off-by: Jakob Meng
---
tests/pmd.at| 5 +
tests/unixctl-py.at | 7 +++
2 files changed, 12 insertions(+)
diff --git a/tests/pmd.at b/tests/pmd.at
index cff80da15..82a514f36 100644
--- a/tests/pmd.at
+++ b/tests/pmd.at
@@ -105,6 +105,11 @@ pmd thread numa
From: Jakob Meng
This patch introduces support for different output formats to the
Python code, as did the previous commit for ovs-xxx tools like
'ovs-appctl --format json dpif/show'.
In particular, tests/appctl.py gains a global option '-f,--format'
which allows users to request JSON instead of
From: Jakob Meng
The 'dpif/show' command now supports machine-readable JSON output in
addition to the plain-text output for humans. An example would be:
ovs-appctl --format json dpif/show
Reported-at: https://bugzilla.redhat.com/1824861
Signed-off-by: Jakob Meng
---
ofproto/ofproto-dpif.c |
On 17.01.24 20:50, Simon Horman wrote:
> On Wed, Jan 17, 2024 at 06:56:31PM +, Simon Horman wrote:
>> On Wed, Jan 17, 2024 at 01:55:36PM +0100, jm...@redhat.com wrote:
>>> From: Jakob Meng
>>>
>>> Previous commits introduced support different output formats to
>>> ovs-xxx tools and its Pytho
Bleep bloop. Greetings Jakob Meng, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
#59
Bleep bloop. Greetings Jakob Meng, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
git-am:
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed
Bleep bloop. Greetings Jakob Meng, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
Patch skipped due to previous failure.
Please check this out. If you feel there has been an error, please e
Bleep bloop. Greetings Jakob Meng, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
Patch skipped due to previous failure.
Please check this out. If you feel there has been an error, please e
Bleep bloop. Greetings Jakob Meng, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
Patch skipped due to previous failure.
Please check this out. If you feel there has been an error, please e
Seen in GHA recently.
Unit tests are checking conntracks relating to a destination ip address
but the FORMAT_CT macro is not strict enough and would match unrelated
conntracks too.
Example:
148. system-traffic.at:6432: testing conntrack - DNAT with
additional SNAT ...
[...]
./system-traffi
When OVS (main thread) configures a DPDK netdev, it holds a netdev_dpdk
mutex lock.
As part of this configure operation, the net/iavf driver (used with i40e
VF devices) triggers a queue count change. The PF entity (serviced by a
kernel PF driver for example) handles this change and requests back th
On 1/18/24 14:16, David Marchand wrote:
> When OVS (main thread) configures a DPDK netdev, it holds a netdev_dpdk
> mutex lock.
> As part of this configure operation, the net/iavf driver (used with i40e
> VF devices) triggers a queue count change. The PF entity (serviced by a
> kernel PF driver for
On Thu, Jan 18, 2024 at 2:23 PM Ilya Maximets wrote:
>
> On 1/18/24 14:16, David Marchand wrote:
> > When OVS (main thread) configures a DPDK netdev, it holds a netdev_dpdk
> > mutex lock.
> > As part of this configure operation, the net/iavf driver (used with i40e
> > VF devices) triggers a queue
On 1/18/24 14:30, David Marchand wrote:
> On Thu, Jan 18, 2024 at 2:23 PM Ilya Maximets wrote:
>>
>> On 1/18/24 14:16, David Marchand wrote:
>>> When OVS (main thread) configures a DPDK netdev, it holds a netdev_dpdk
>>> mutex lock.
>>> As part of this configure operation, the net/iavf driver (use
On 18.01.24 11:17, 0-day Robot wrote:
> Bleep bloop. Greetings Jakob Meng, I am a robot and I have tried out your
> patch.
> Thanks for your contribution.
>
> I encountered some error that I wasn't expecting. See the details below.
>
>
> git-am:
> error: Failed to merge in the changes.
> hint: U
When OVS (main thread) configures a DPDK netdev, it holds a netdev_dpdk
mutex lock.
As part of this configure operation, the net/iavf driver (used with i40e
VF devices) triggers a queue count change. The PF entity (serviced by a
kernel PF driver for example) handles this change and requests back th
We are intentionally skipping ND NA with LLA as source.
However, this doesn't work when the ND NA has LLA source,
but the target address is global one. In that case we
would skip update of already existing entry when
always_learn_from_arp_request is set to false.
Use ND target address in the check
GCC 14 started to advertise c_atomic extension, older versions didn't
do that. Add check for __clang__, so GCC doesn't include headers
designed for Clang.
Another option would be to prefer stdatomic implementation instead,
but some older versions of Clang are not able to use stdatomic.h
supplied
Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: The subject summary should end with a dot.
Subject: northd: Use proper field for lookup_
On 18.01.24 15:59, Ilya Maximets wrote:
> GCC 14 started to advertise c_atomic extension, older versions didn't
> do that. Add check for __clang__, so GCC doesn't include headers
> designed for Clang.
>
> Another option would be to prefer stdatomic implementation instead,
> but some older versions
From: Jakob Meng
Same as v6 [0] but rebased to latest master.
[0]
https://patchwork.ozlabs.org/project/openvswitch/list/?series=390996&archive=both&state=*
Jakob Meng (6):
Add global option for JSON output to ovs-appctl.
python: Add global option for JSON output to Python tools.
Migrate
From: Jakob Meng
This patch introduces support for different output formats to the
Python code, as did the previous commit for ovs-xxx tools like
'ovs-appctl --format json dpif/show'.
In particular, tests/appctl.py gains a global option '-f,--format'
which allows users to request JSON instead of
From: Jakob Meng
For monitoring systems such as Prometheus it would be beneficial if
OVS would expose statistics in a machine-readable format.
This patch introduces support for different output formats to ovs-xxx
tools. They gain a global option '-f,--format' which allows users to
request JSON i
From: Jakob Meng
The 'dpif/show' command now supports machine-readable JSON output in
addition to the plain-text output for humans. An example would be:
ovs-appctl --format json dpif/show
Reported-at: https://bugzilla.redhat.com/1824861
Signed-off-by: Jakob Meng
---
ofproto/ofproto-dpif.c |
From: Jakob Meng
Signed-off-by: Jakob Meng
---
tests/pmd.at| 5 +
tests/unixctl-py.at | 7 +++
2 files changed, 12 insertions(+)
diff --git a/tests/pmd.at b/tests/pmd.at
index cff80da15..82a514f36 100644
--- a/tests/pmd.at
+++ b/tests/pmd.at
@@ -105,6 +105,11 @@ pmd thread numa
From: Jakob Meng
Signed-off-by: Jakob Meng
---
NEWS | 3 +++
lib/unixctl.c | 4 ++--
lib/unixctl.h | 1 +
tests/pmd.at | 29 +++--
utilities/ovs-appctl.c | 22 +++---
5 files changed, 52 insertions(+), 7 de
On Thu, Jan 18, 2024 at 3:41 PM David Marchand
wrote:
> Changes since v1:
> - converted to atomic accesses on netdev_dpdk_pending_reset[],
I did not wait for the clang results during my tests... cooking v3.
--
David Marchand
___
dev mailing list
d..
On 18 Jan 2024, at 15:59, Ilya Maximets wrote:
> GCC 14 started to advertise c_atomic extension, older versions didn't
> do that. Add check for __clang__, so GCC doesn't include headers
> designed for Clang.
>
> Another option would be to prefer stdatomic implementation instead,
> but some old
On 1/18/24 15:41, David Marchand wrote:
> When OVS (main thread) configures a DPDK netdev, it holds a netdev_dpdk
> mutex lock.
> As part of this configure operation, the net/iavf driver (used with i40e
> VF devices) triggers a queue count change. The PF entity (serviced by a
> kernel PF driver for
Bleep bloop. Greetings Jakob Meng, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
#59
On Thu, Jan 18, 2024 at 4:43 PM Ilya Maximets wrote:
>
> On 1/18/24 15:41, David Marchand wrote:
> > When OVS (main thread) configures a DPDK netdev, it holds a netdev_dpdk
> > mutex lock.
> > As part of this configure operation, the net/iavf driver (used with i40e
> > VF devices) triggers a queue
When OVS (main thread) configures a DPDK netdev, it holds a netdev_dpdk
mutex lock.
As part of this configure operation, the net/iavf driver (used with i40e
VF devices) triggers a queue count change. The PF entity (serviced by a
kernel PF driver for example) handles this change and requests back th
On 1/18/24 15:59, Ilya Maximets wrote:
> GCC 14 started to advertise c_atomic extension, older versions didn't
> do that. Add check for __clang__, so GCC doesn't include headers
> designed for Clang.
>
> Another option would be to prefer stdatomic implementation instead,
> but some older versions
On Thu, Jan 18, 2024 at 03:59:05PM +0100, Ilya Maximets wrote:
> GCC 14 started to advertise c_atomic extension, older versions didn't
> do that. Add check for __clang__, so GCC doesn't include headers
> designed for Clang.
>
> Another option would be to prefer stdatomic implementation instead,
>
On Thu, Jan 18, 2024 at 04:26:52PM +0100, jm...@redhat.com wrote:
> From: Jakob Meng
>
> For monitoring systems such as Prometheus it would be beneficial if
> OVS would expose statistics in a machine-readable format.
...
Recheck-request: github-robot
Currently, dp_packet_ol_send_prepare() performs multiple checks for
each offloading flag separately. That takes a noticeable amount of
extra cycles for packets that do not have any offloading flags set.
Skip most of the work if no checksumming flags are set.
The change improves performance of di
On Thu, Jan 18, 2024 at 04:26:54PM +0100, jm...@redhat.com wrote:
> From: Jakob Meng
>
> Previous commits introduced support different output formats to
> ovs-xxx tools and its Python equivalents. However, the commands
> were not yet migrated to the updated {unixctl_}command_register()
> function
On 1/17/24 16:48, Numan Siddique wrote:
On Wed, Jan 17, 2024 at 4:33 PM Dumitru Ceara wrote:
On 1/17/24 21:40, Mark Michelson wrote:
On 1/16/24 11:23, Numan Siddique wrote:
On Tue, Jan 16, 2024 at 8:09 AM Dumitru Ceara wrote:
This picks up the following OVS changes:
00d3d4a7d375 ("che
Thanks:
fix:
https://patchwork.ozlabs.org/project/ovn/patch/20240117201258.4033-1-amgin...@gmail.com/
.
Ali
On Tue, Jan 9, 2024 at 7:14 PM Numan Siddique wrote:
>
>
> On Tue, Jan 9, 2024, 9:46 PM aginwala wrote:
>
>> So it seems it would be ok to use STREAM_SSL_OPTION_HANDLERS for multiple
On Tue, Jan 16, 2024 at 5:45 AM Mark Michelson wrote:
>
> Hi everyone,
>
> The soft freeze for OVN 24.03 is this Friday, 19 January, 2024. Please
> ensure that any patches that introduce new features are posted to the
> mailing list by that date if you wish to have them included in OVN 24.03.
>
>
On Thu, Jan 18, 2024 at 11:40 AM Ilya Maximets wrote:
>
> Currently, dp_packet_ol_send_prepare() performs multiple checks for
> each offloading flag separately. That takes a noticeable amount of
> extra cycles for packets that do not have any offloading flags set.
>
> Skip most of the work if no
Otherwise, it randomly fails due to age not being zero under load:
tests/mcast-snooping.at:645: ovs-appctl mdb/show br0
--- -
+++ /at-groups/2592/stdout
@@ -1,5 +1,5 @@
port VLAN protocol GROUPAge
-1 0 IGMPv1224.1.1.1 0
+1 0 IGMPv1
On 18 Jan 2024, at 20:25, Ilya Maximets wrote:
> Otherwise, it randomly fails due to age not being zero under load:
>
> tests/mcast-snooping.at:645: ovs-appctl mdb/show br0
> --- -
Thanks for finding and fixing this. Tests pass fine in my not too busy system.
Acked-by: Eelco Chaudron
__
51 matches
Mail list logo
