Re: [pgAdmin4][Patch] - RM #3309 - Backup does not work with --format=d

2018-07-17 Thread Akshay Joshi
Hi Hackers, Attached is the patch to fix the issue on Windows operating system with "--format=d". On Fri, Jun 29, 2018 at 7:46 PM, Dave Page wrote: > Thanks, applied. > > On Fri, Jun 29, 2018 at 10:24 AM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> Please find the

pgAdmin 4 commit: Support running on systems without a system tray. Fix

2018-07-17 Thread Dave Page
Support running on systems without a system tray. Fixes #3316 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=765a88addfdf469dfb311aa6310e9c8aefbef223 Author: Akshay Joshi Modified Files -- docs/en_US/release_notes_3_2.rst | 1 +

Re: Regarding RM #3316 Pgadmin4 No Tray Crash

2018-07-17 Thread Dave Page
Thanks, patch applied. On Fri, Jul 13, 2018 at 7:10 AM, Akshay Joshi wrote: > Attached is the refactored patch. > > On Fri, Jul 13, 2018 at 11:19 AM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> >> >> On Thu, Jul 12, 2018 at 9:38 PM, Dave Page wrote: >> >>> >>> >>> On Thu, Jul 12

pgAdmin 4 commit: Add hints for the config options.

2018-07-17 Thread Dave Page
Add hints for the config options. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a49923dba2123bdd1c3eb8098056ac38386fc542 Modified Files -- runtime/ConfigWindow.ui | 18 +++--- 1 file changed, 15 insertions(+), 3 deleti

Re: [pgAdmin4][Patch]: RM #3446 plpgsql keyword should displayed in SQL pane for EPAS-11

2018-07-17 Thread Dave Page
Thanks, applied. On Fri, Jul 13, 2018 at 2:16 PM, Akshay Joshi wrote: > Hi Hackers, > > Attached is the patch to fix the RM #3446 "plpgsql keyword should > displayed in SQL pane for EPAS-11". While fixing it, I have found below > issues in function/procedure: > >1. Procedures for EPAS 11 alw

pgAdmin 4 commit: Various procedure/function related fixes for EPAS/PG

2018-07-17 Thread Dave Page
Various procedure/function related fixes for EPAS/PG 11. Fixes #3446 - Fix the RM #3446 "plpgsql keyword should displayed in SQL pane for EPAS-11". - Procedures for EPAS 11 always created as 'edbspl', even though language is sql or plpgsql. - Not able to create Function/Procedure/Trigger function

Re: [pgAdmin4][Patch]: Fix RM #3191 : Debug option is not working

2018-07-17 Thread Dave Page
Thanks, patch applied. On Mon, Jul 16, 2018 at 10:26 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached updated patch. > > On Thu, Jul 12, 2018 at 2:55 PM, Dave Page wrote: > >> Hi >> >> On Thu, Jul 12, 2018 at 6:13 AM, Khushboo Vashi < >> khushboo.va

pgAdmin 4 commit: Fix a number of debugger execution issues. Fixes #319

2018-07-17 Thread Dave Page
Fix a number of debugger execution issues. Fixes #3191 1. EPAS packages' function/procedure does not honour INOUT arguments, it converts INOUT to OUT. 2. Packages' functions and procedures are not getting listed in their respected nodes in some scenarios like procedure having INOUT argument an

pgAdmin 4 commit: Exclude system columns in Import/Export. Fixes #3448

2018-07-17 Thread Dave Page
Exclude system columns in Import/Export. Fixes #3448 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ba8f745f7051df43e0c89df589ca7eabc51b16c4 Author: Akshay Joshi Modified Files -- docs/en_US/release_notes_3_2.rst

Re: [pgAdmin4][Patch]: RM #3448 copy command failure issue in pgAdmin

2018-07-17 Thread Dave Page
Thanks, applied. On Mon, Jul 16, 2018 at 12:50 PM, Akshay Joshi < akshay.jo...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to fix RM #3448 copy command failure issue in > pgAdmin. Please review it. > > -- > *Akshay Joshi* > > *Sr. Software Architect * > > > > *Phone: +91 20-3

Re: [pgAdmin4][Patch] - RM #3309 - Backup does not work with --format=d

2018-07-17 Thread Dave Page
Thanks, applied. On Tue, Jul 17, 2018 at 9:01 AM, Akshay Joshi wrote: > Hi Hackers, > > Attached is the patch to fix the issue on Windows operating system with > "--format=d". > > On Fri, Jun 29, 2018 at 7:46 PM, Dave Page wrote: > >> Thanks, applied. >> >> On Fri, Jun 29, 2018 at 10:24 AM, Khu

pgAdmin 4 commit: Fix backup in directory format on Windows.

2018-07-17 Thread Dave Page
Fix backup in directory format on Windows. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1fc82d328c974d743f8591633afce6717d5a8d88 Author: Akshay Joshi Modified Files -- web/pgadmin/tools/backup/__init__.py | 12 +++- web/

Re: Regarding RM #3316 Pgadmin4 No Tray Crash

2018-07-17 Thread Akshay Joshi
Hi Dave, I have changed the background colour on mouse hover for "pgAdmin4" menu. Attached is the screenshot, please review it and let me know which colour looks good or any other suggestion. I'll send the patch accordingly. On Tue, Jul 17, 2018 at 4:42 PM, Dave Page wrote: > Thanks, patch appl

Re: Regarding RM #3316 Pgadmin4 No Tray Crash

2018-07-17 Thread Dave Page
On Tue, Jul 17, 2018 at 2:06 PM, Akshay Joshi wrote: > Hi Dave, > > I have changed the background colour on mouse hover for "pgAdmin4" menu. > Attached is the screenshot, please review it and let me know which colour > looks good or any other suggestion. I'll send the patch accordingly. > I thin

Re: Regarding RM #3316 Pgadmin4 No Tray Crash

2018-07-17 Thread Akshay Joshi
On Tue, Jul 17, 2018 at 6:37 PM, Dave Page wrote: > > > On Tue, Jul 17, 2018 at 2:06 PM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Dave, >> >> I have changed the background colour on mouse hover for "pgAdmin4" menu. >> Attached is the screenshot, please review it and let me k

Re: Regarding RM #3316 Pgadmin4 No Tray Crash

2018-07-17 Thread Dave Page
On Tue, Jul 17, 2018 at 2:11 PM, Akshay Joshi wrote: > > > On Tue, Jul 17, 2018 at 6:37 PM, Dave Page wrote: > >> >> >> On Tue, Jul 17, 2018 at 2:06 PM, Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi Dave, >>> >>> I have changed the background colour on mouse hover for "pgAdmi

pgAdmin 4 commit: Added keyboard shortcut for 'pgAdmin4' menu.

2018-07-17 Thread Akshay Joshi
Added keyboard shortcut for 'pgAdmin4' menu. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7f7feee8c1afb28ceb0a8d39273f2da4eb276a6a Modified Files -- runtime/FloatingWindow.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)