Re: [pgadmin-hackers] [pgadmin4] Edb package support.

2016-08-17 Thread Dave Page
Hi, I did some quick testing, and found the following issues: - Package ACL is not shown in properties - Package header and body are not shown in properties - System package? is not shown in properties - The header for the RE SQL on a package procedure should read: -- Package Procedure (not

[pgadmin-hackers] pgAdmin 4 commit: Allow customisation of the CodeMirror font size. Fixe

2016-08-17 Thread Dave Page
Allow customisation of the CodeMirror font size. Fixes #1565 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b3f25cb4bb5027eaba483eceb4e425fdadb63910 Modified Files -- web/pgadmin/browser/__init__.py | 18 ++ 1 file c

[pgadmin-hackers] pgAdmin 4 commit: On reflection, don't allow the user to specify the un

2016-08-17 Thread Dave Page
On reflection, don't allow the user to specify the unit when setting the SQL font size. Always use em's. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=91e3d3267f1d8a006436f22381ef6aa70b92c849 Modified Files -- web/pgadmin/browser

[pgadmin-hackers] pgAdmin 4 commit: Show default database privileges in properties mode.

2016-08-17 Thread Dave Page
Show default database privileges in properties mode. Fixes #1538 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1056e9553f983fb83b0fc145c5e6b19f752670a5 Author: Harshal Dhumal Modified Files -- .../servers/databases/templates/data

Re: [pgadmin-hackers] patch for RM1538: show db default acls [pgadmin4]

2016-08-17 Thread Dave Page
Thanks, patch applied. On Tue, Aug 16, 2016 at 3:13 PM, Harshal Dhumal wrote: > Hi, > > PFA patch for rm 1538 to show default database privileges in properties > mode. > > > -- > Harshal Dhumal > Software Engineer > > EnterpriseDB India: http://www.enterprisedb.com > The Enterprise PostgreSQL Com

Re: [pgadmin-hackers] PATCH: To fix the issue where message panel was showing incomplete info (pgAdmin4)

2016-08-17 Thread Dave Page
Hi On Tue, Aug 16, 2016 at 3:56 PM, Murtuza Zabuawala wrote: > Hi Dave, > > PFA updated patch. I just tested this, and found a number of issues: - For a query like VACUUM FULL ANALYZE VERBOSE, the query runtime is not displayed at the end of the messages. It is for SELECT queries (note: pgAdmin

[pgadmin-hackers] pgAdmin 4 commit: String fix.

2016-08-17 Thread Dave Page
String fix. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6701bb191d817bc9fd640f202f8947f4df046529 Modified Files -- web/pgadmin/misc/file_manager/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pga

[pgadmin-hackers] pgAdmin 4 commit: Give more useful error messages when unable to debug

2016-08-17 Thread Dave Page
Give more useful error messages when unable to debug functions. Fixes #1224 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=48a50ce20be3e6ebdacd0a9632b76ca6aba7cc1d Author: Neel Patel Modified Files -- web/pgadmin/tools/debugger/__

Re: [pgadmin-hackers] [pgAdmin4][Debugger]: Fix RM-1224

2016-08-17 Thread Dave Page
Thanks, patch applied. On Wed, Aug 17, 2016 at 7:29 AM, Neel Patel wrote: > Hi, > > Please find attached patch file for fix of RM-1224. > > Issue:- > Previously, error message was generic for any error. > > Solution:- > Instead of showing generic message, now we will display error specific > mess

Re: [pgadmin-hackers] [pgadmin4] Edb package support.

2016-08-17 Thread Khushboo Vashi
On Wed, Aug 17, 2016 at 4:35 PM, Dave Page wrote: > Hi, > > I did some quick testing, and found the following issues: > > - Package ACL is not shown in properties > > - Package header and body are not shown in properties > > - System package? is not shown in properties > > - The header for the RE

[pgadmin-hackers] PATCH: To fix the issue in configuration error message (pgAdmin4)

2016-08-17 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue where user was getting same error message for PG & PPAS bin path configuration. RM#1563 Issue: The condition to check server type was not working as expected in Backup/Restore/Maintenance/Import-Export tools otherwise we already had two septate error messages. -- R