pgsql: Fix fd leak in pg_verifybackup

2020-12-06 Thread Michael Paquier
Fix fd leak in pg_verifybackup An error code path newly-introduced by 87ae969 forgot to close a file descriptor when verifying a file's checksum. Per report from Coverity, via Tom Lane. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/51c388987734cb318c8fa875f382ca7

pgsql: pg_dump: Reorganize dumpBaseType()

2020-12-06 Thread Tom Lane
pg_dump: Reorganize dumpBaseType() Along the same lines as ed2c7f65b and daa9fe8a5, reduce code duplication by having just one copy of the parts of the query that are the same across all server versions; and make the conditionals control the smallest possible amount of code. This is in preparatio