pgsql: Fix perl warning from commit 9b4eafcaf4

2022-11-23 Thread Andrew Dunstan
Fix perl warning from commit 9b4eafcaf4 per gripe from Andres Freund and Tom Lane Backpatch to all live branches. Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commitdiff/c93254424f288557eeef13343be8f72536cb9ffe Modified Files -- src/test/perl/PostgresNo

pgsql: Fix perl warning from commit 9b4eafcaf4

2022-11-23 Thread Andrew Dunstan
Fix perl warning from commit 9b4eafcaf4 per gripe from Andres Freund and Tom Lane Backpatch to all live branches. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/b425bf0081386a544e1faf872a75da69a971e173 Modified Files -- src/test/perl/PostgreSQL/Test/C

pgsql: Fix perl warning from commit 9b4eafcaf4

2022-11-23 Thread Andrew Dunstan
Fix perl warning from commit 9b4eafcaf4 per gripe from Andres Freund and Tom Lane Backpatch to all live branches. Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/f4b777e77dbc46b657bd3ea331ba9f14fe4d34c9 Modified Files -- src/test/perl/PostgresNo

pgsql: Fix perl warning from commit 9b4eafcaf4

2022-11-23 Thread Andrew Dunstan
Fix perl warning from commit 9b4eafcaf4 per gripe from Andres Freund and Tom Lane Backpatch to all live branches. Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/2f92b8ad3121d9f23c48afbd3a60a2592cf90ba0 Modified Files -- src/test/perl/PostgresNo

pgsql: Fix perl warning from commit 9b4eafcaf4

2022-11-23 Thread Andrew Dunstan
Fix perl warning from commit 9b4eafcaf4 per gripe from Andres Freund and Tom Lane Backpatch to all live branches. Branch -- REL_15_STABLE Details --- https://git.postgresql.org/pg/commitdiff/2c0d0ee761551582c9cd3727d444b7408aa82db7 Modified Files -- src/test/perl/PostgreSQL

pgsql: Fix perl warning from commit 9b4eafcaf4

2022-11-23 Thread Andrew Dunstan
Fix perl warning from commit 9b4eafcaf4 per gripe from Andres Freund and Tom Lane Backpatch to all live branches. Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/3a2807528e712a261ea3db713db4db39b7704288 Modified Files -- src/test/perl/PostgresNo

pgsql: Don't test HEAP_XMAX_INVALID when freezing xmax.

2022-11-23 Thread Peter Geoghegan
Don't test HEAP_XMAX_INVALID when freezing xmax. We shouldn't ever need to rely on whether HEAP_XMAX_INVALID is set in t_infomask when considering whether or not an xmax should be deemed already frozen, since that status flag is just a hint. The only acceptable representation for an "xmax_already

pgsql: Simplify vacuum_set_xid_limits() signature.

2022-11-23 Thread Peter Geoghegan
Simplify vacuum_set_xid_limits() signature. Pass VACUUM parameters (VacuumParams state) to vacuum_set_xid_limits() directly, rather than passing most individual VacuumParams fields as separate arguments. Also make vacuum_set_xid_limits() output parameter symbol names match those used by its vacuu

pgsql: Simplify WARNING messages from skipped vacuum/analyze on a table

2022-11-23 Thread Andrew Dunstan
Simplify WARNING messages from skipped vacuum/analyze on a table This will more easily accomodate adding new permissions for vacuum and analyze. Nathan Bossart following a suggestion from Kyotaro Horiguchi Discussion: https://postgr.es/m/20220726.104712.912995710251150228.horikyota@gmail.co

pgsql: Expand AclMode to 64 bits

2022-11-23 Thread Andrew Dunstan
Expand AclMode to 64 bits We're running out of bits for new permissions. This change doubles the number of permissions we can accomodate from 16 to 32, so the forthcoming new ones for vacuum/analyze don't exhaust the pool. Nathan Bossart Reviewed by: Bharath Rupireddy, Kyotaro Horiguchi, Stephen

pgsql: Support for custom slots in the custom executor nodes

2022-11-23 Thread Alexander Korotkov
Support for custom slots in the custom executor nodes Some custom table access method may have their tuple format and use custom executor nodes for their custom scan types. The ability to set a custom slot would save them from tuple format conversion. Other users of custom executor nodes may also

pgsql: Rework memory contexts in charge of HBA/ident tokenization

2022-11-23 Thread Michael Paquier
Rework memory contexts in charge of HBA/ident tokenization The list of TokenizedAuthLines generated at parsing for the HBA and ident files is now stored in a static context called tokenize_context, where only all the parsed tokens are stored. This context is created when opening the first authent

Re: pgsql: Expand AclMode to 64 bits

2022-11-23 Thread Michael Paquier
Hi Andrew, On Wed, Nov 23, 2022 at 07:44:04PM +, Andrew Dunstan wrote: > Expand AclMode to 64 bits > > We're running out of bits for new permissions. This change doubles the > number of permissions we can accomodate from 16 to 32, so the > forthcoming new ones for vacuum/analyze don't exhaust

pgsql: Add missing initialization in tokenize_expand_file() for output

2022-11-23 Thread Michael Paquier
Add missing initialization in tokenize_expand_file() for output list This should have been added in efc9816, but it looks like I have found a way to mess up a bit a patch split. This should have no consequence in practice, but let's be clean. Discussion: https://postgr.es/m/y324hvgkiwxw2...@paqu

Re: pgsql: Expand AclMode to 64 bits

2022-11-23 Thread Andrew Dunstan
On 2022-11-23 We 19:40, Michael Paquier wrote: > Hi Andrew, > > On Wed, Nov 23, 2022 at 07:44:04PM +, Andrew Dunstan wrote: >> Expand AclMode to 64 bits >> >> We're running out of bits for new permissions. This change doubles the >> number of permissions we can accomodate from 16 to 32, so th

pgsql: Create memory context for tokenization after opening top-level f

2022-11-23 Thread Michael Paquier
Create memory context for tokenization after opening top-level file in hba.c The memory context was created before attempting to open the first HBA or ident file, which would cause it to leak. This had no consequences for the system views for HBA and ident files, but this would cause memory leaks

pgsql: Speedup hash index builds by skipping needless binary searches

2022-11-23 Thread David Rowley
Speedup hash index builds by skipping needless binary searches When building hash indexes using the spool method, tuples are added to the index page in hashkey order. Because of this, we can safely skip performing the binary search on the existing tuples on the page to find the location to insert

pgsql: Add support for file inclusions in HBA and ident configuration f

2022-11-23 Thread Michael Paquier
Add support for file inclusions in HBA and ident configuration files pg_hba.conf and pg_ident.conf gain support for three record keywords: - "include", to include a file. - "include_if_exists", to include a file, ignoring it if missing. - "include_dir", to include a directory of files. These are

pgsql: Add the database name to the ps display of logical WAL senders

2022-11-23 Thread Michael Paquier
Add the database name to the ps display of logical WAL senders Logical WAL senders display now as follows, gaining a database name: postgres: walsender USER DATABASE HOST(PORT) STATE Physical WAL senders show up the same, as of: postgres: walsender USER HOST(PORT) STATE This information was miss