pgsql: Add more LOG messages when starting and ending recovery from a b

2024-01-25 Thread Michael Paquier
Add more LOG messages when starting and ending recovery from a backup Three LOG messages are added in the recovery code paths, providing information that can be useful to track corruption issues depending on the state of the cluster, telling that: - Recovery has started from a backup_label. - Reco

pgsql: Silence compiler warning introduced in 1edb3b491b

2024-01-25 Thread Amit Langote
Silence compiler warning introduced in 1edb3b491b Reported-by: Richard Guo Discussion: https://postgr.es/m/cambws48qeoe9du5tuuxrkgq6vc9oy+tqoorq6jpob14-e1z...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/fba2112b1569fd001a9e54dfdd73fd3cb8f16140

pgsql: Fix s_lock_test compile

2024-01-25 Thread Alvaro Herrera
Fix s_lock_test compile This is a mostly unused tool, but I discovered while nosing around the Makefile that it hasn't been kept in line with other changes. Fix it. Backpatching doesn't appear to be necessary. Discussion: https://postgr.es/m/202401241114.ied53jcich72@alvherre.pgsql Branch

pgsql: MergeAttributes: convert pg_attribute back to ColumnDef before c

2024-01-25 Thread Peter Eisentraut
MergeAttributes: convert pg_attribute back to ColumnDef before comparing MergeAttributes() has a loop to merge multiple inheritance parents into a column column definition. The merged-so-far definition is stored in a ColumnDef node. If we have to merge columns from multiple inheritance parents (

pgsql: Remove dummy_spinlock

2024-01-25 Thread Alvaro Herrera
Remove dummy_spinlock It's been unused since 1b468a131bd2 (2015). Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/55627ba2d334ce98e1f5916354c46472d414bda6 Modified Files -- src/backend/main/main.c | 6 -- src/backend/storage/lmgr/s_lock.c |

pgsql: Remove redundant HandleWalWriterInterrupts().

2024-01-25 Thread Fujii Masao
Remove redundant HandleWalWriterInterrupts(). Because of commit 1bdd54e662, the code of HandleWalWriterInterrupts() became the same as HandleMainLoopInterrupts(). So this commit removes HandleWalWriterInterrupts() and makes walwriter use HandleMainLoopInterrupts() for improved code simplicity. Au

pgsql: Add a const decoration

2024-01-25 Thread Peter Eisentraut
Add a const decoration Useful for a subsequent patch. Discussion: https://www.postgresql.org/message-id/flat/52a125e4-ff9a-95f5-9f61-b87cf447e...@eisentraut.org Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/924d046dcf55887c98a1628675a30f4b0eebe556 Modified File

pgsql: Implement various jsonpath methods

2024-01-25 Thread Andrew Dunstan
Implement various jsonpath methods This commit implements ithe jsonpath .bigint(), .boolean(), .date(), .decimal([precision [, scale]]), .integer(), .number(), .string(), .time(), .time_tz(), .timestamp(), and .timestamp_tz() methods. .bigint() converts the given JSON string or a numeric value to

pgsql: Doc: improve documentation for jsonpath behavior.

2024-01-25 Thread Tom Lane
Doc: improve documentation for jsonpath behavior. Clarify the behavior of jsonpath operators and functions by describing their two different modes of operation explicitly. In addition to the SQL-spec behavior, where a path returns a list of matching items, we have a "predicate check" form that alw

pgsql: Clean up a bug in sql/json items commit 66ea94e8e6

2024-01-25 Thread Andrew Dunstan
Clean up a bug in sql/json items commit 66ea94e8e6 Remove a buggy and unnecessary test, along with an unnecessary pstrdup() and a line of dead code. Per report, diagnosis and fix from Tom Lane Discussion: https://postgr.es/m/439811.1706211...@sss.pgh.pa.us Branch -- master Details ---

pgsql: Support TZ and OF format codes in to_timestamp().

2024-01-25 Thread Tom Lane
Support TZ and OF format codes in to_timestamp(). Formerly, these were only supported in to_char(), but there seems little reason for that restriction. We should at least have enough support to permit round-tripping the output of to_char(). In that spirit, TZ accepts either zone abbreviations or

pgsql: Update comment, generation mem contexts have a "keeper" block

2024-01-25 Thread Heikki Linnakangas
Update comment, generation mem contexts have a "keeper" block The keeper block was introduced in commit 1b0d9aa4f7, but it forgot to update this comment. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/376c216138c75e161d39767650ea30536f23b482 Modified Files ---

pgsql: Revert "Add support for parsing of large XML data (>= 10MB)"

2024-01-25 Thread Michael Paquier
Revert "Add support for parsing of large XML data (>= 10MB)" This reverts commit 2197d06224a1, following a discussion over a Coverity report where issues like the "Billion laugh attack" could cause the backend to waste CPU and memory even if a client applied checks on the size of the data given in

pgsql: Improve NestLoopParam generation for lateral subqueries

2024-01-25 Thread David Rowley
Improve NestLoopParam generation for lateral subqueries It was possible in cases where we had a LATERAL joined subquery that when the same Var is mentioned in both the lateral references and in the outer Vars of the scan clauses that the given Var wouldn't be assigned to the same NestLoopParam. T

pgsql: Fix comment in index.c

2024-01-25 Thread Michael Paquier
Fix comment in index.c Extracted from a larger patch by the same author. Author: Gurjeet Singh Discussion: https://postgr.es/m/CABwTF4WX=m5pQvKXvLFJoEH=hSd6O=iZSqxVqHKjFm+iL-AO=w...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/bd5760df38c0032bb94

pgsql: De-dupicate Memoize cache keys

2024-01-25 Thread David Rowley
De-dupicate Memoize cache keys It was possible when determining the cache keys for a Memoize path that if the same expr appeared twice in the parameterized path's ppi_clauses and/or in the Nested Loop's inner relation's lateral_vars.  If this happened the Memoize node's cache keys would contain du