[COMMITTERS] pgsql: Count locked pages that don't need vacuuming as scanned.

2013-11-18 Thread Heikki Linnakangas
Count locked pages that don't need vacuuming as scanned. Previously, if VACUUM skipped vacuuming a page because it's pinned, it didn't count that page as scanned. However, that meant that relfrozenxid was not bumped up either, which prevented anti-wraparound vacuum from doing its job. Report by М

[COMMITTERS] pgsql: Count locked pages that don't need vacuuming as scanned.

2013-11-18 Thread Heikki Linnakangas
Count locked pages that don't need vacuuming as scanned. Previously, if VACUUM skipped vacuuming a page because it's pinned, it didn't count that page as scanned. However, that meant that relfrozenxid was not bumped up either, which prevented anti-wraparound vacuum from doing its job. Report by М

[COMMITTERS] pgsql: Count locked pages that don't need vacuuming as scanned.

2013-11-18 Thread Heikki Linnakangas
Count locked pages that don't need vacuuming as scanned. Previously, if VACUUM skipped vacuuming a page because it's pinned, it didn't count that page as scanned. However, that meant that relfrozenxid was not bumped up either, which prevented anti-wraparound vacuum from doing its job. Report by М

[COMMITTERS] pgsql: Use cstring_to_text_with_len when length is known.

2013-11-18 Thread Robert Haas
Use cstring_to_text_with_len when length is known. This avoids a potentially-expensive extra call to strlen(). David Rowley Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/f1df4731eea6bc05e0769e9cc789e7304722efe4 Modified Files -- contrib/pageinspect/fs

[COMMITTERS] pgsql: Replace appendPQExpBuffer(..., ) with appendPQExpBuffe

2013-11-18 Thread Heikki Linnakangas
Replace appendPQExpBuffer(..., ) with appendPQExpBufferStr Arguably makes the code a bit more readable, and might give a small performance gain. David Rowley Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/32ceba3ea730b6b1bd3eca786f72d61945ad42b7 Modified Files ---

[COMMITTERS] pgsql: Spell SQL keywords in uppercase in pg_dump's query.

2013-11-18 Thread Heikki Linnakangas
Spell SQL keywords in uppercase in pg_dump's query. The server won't care, but let's be consistent. David Rowley. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/fea437681d68a0027091c2d534c69c0965cf06f1 Modified Files -- src/bin/pg_dump/pg_dump.c | 48

[COMMITTERS] pgsql: unaccent: Revert patch 9299f6179838cef8aa1123f6fb76f0d3d6f2decc

2013-11-18 Thread Bruce Momjian
unaccent: Revert patch 9299f6179838cef8aa1123f6fb76f0d3d6f2decc The reverted patch to change functions from strict to immutable was incorrect and needs additional research. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/0dbf9a6a91675b99a5097528729c38e7f3015646 Mod

Re: [COMMITTERS] pgsql: Ensure that XLOG_HEAP2_VISIBLE always targets an initialized pag

2013-11-18 Thread Bruce Momjian
On Sun, Nov 10, 2013 at 11:51:06PM +0100, Andres Freund wrote: > Hi, > > On 2013-06-06 14:22:12 +, Robert Haas wrote: > > Ensure that XLOG_HEAP2_VISIBLE always targets an initialized page. > > This didn't make it to the release notes for 9.2.5. Since there have > been several people asking fo

Re: [COMMITTERS] pgsql: Ensure that XLOG_HEAP2_VISIBLE always targets an initialized pag

2013-11-18 Thread Andres Freund
On 2013-11-18 16:33:25 -0500, Bruce Momjian wrote: > On Sun, Nov 10, 2013 at 11:51:06PM +0100, Andres Freund wrote: > > Hi, > > > > On 2013-06-06 14:22:12 +, Robert Haas wrote: > > > Ensure that XLOG_HEAP2_VISIBLE always targets an initialized page. > > > > This didn't make it to the release

[COMMITTERS] pgsql: pg_upgrade: Report full disk better

2013-11-18 Thread Peter Eisentraut
pg_upgrade: Report full disk better Previously, pg_upgrade would abort copy_file() on a short write without setting errno, which the caller would report as an error with the message "Success". We assume ENOSPC in that case, as we do elsewhere in the code. Also set errno in some other error cases

[COMMITTERS] pgsql: pg_upgrade: Report full disk better

2013-11-18 Thread Peter Eisentraut
pg_upgrade: Report full disk better Previously, pg_upgrade would abort copy_file() on a short write without setting errno, which the caller would report as an error with the message "Success". We assume ENOSPC in that case, as we do elsewhere in the code. Also set errno in some other error cases