[COMMITTERS] pgsql: Fix example on creating a trigger with a transition table.

2017-04-18 Thread Heikki Linnakangas
Fix example on creating a trigger with a transition table. Yugo Nagata Discussion: https://www.postgresql.org/message-id/20170417180921.3047f3b0.nag...@sraoss.co.jp Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/b2188575c59462c0fd23b63c92fb802206162e49 Modified

[COMMITTERS] pgsql: Allow COMMENT ON COLUMN with partitioned tables

2017-04-18 Thread Simon Riggs
Allow COMMENT ON COLUMN with partitioned tables Amit Langote Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/51175f3638524231405e674e40bde159b0b76727 Modified Files -- src/backend/commands/comment.c | 3 ++- src/test/regress/expected/create_

[COMMITTERS] pgsql: Don’t push nextid too far forwards in recovery

2017-04-18 Thread Simon Riggs
Don’t push nextid too far forwards in recovery Doing so allows various crash possibilities. Fix by avoiding having PrescanPreparedTransactions() increment ShmemVariableCache->nextXid when it has no 2PC files Bug found by Jeff Janes, diagnosis and patch by Pavan Deolasee, then patch re-designed fo

[COMMITTERS] pgsql: Exit correctly from PrepareRedoRemove() when not found

2017-04-18 Thread Simon Riggs
Exit correctly from PrepareRedoRemove() when not found Complex crash bug all started with this failure. Diagnosed and fixed by Nikhil Sontakke, reviewed by me. Reported-by: Jeff Janes Author: Nikhil Sontakke Discussion: https://postgr.es/m/CAMkU=1xBP8cqdS5eK8APHL=x6rhmmm2vg5g+qamduutsycw...@mail

[COMMITTERS] pgsql: Fix minor typo in comment

2017-04-18 Thread Simon Riggs
Fix minor typo in comment Reported-by: Amit Langote Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/123aaffb5b881f3dadaac676877a90b50233a847 Modified Files -- src/backend/catalog/partition.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sen

[COMMITTERS] pgsql: Rename "scram" to "scram-sha-256" in pg_hba.conf and password_en

2017-04-18 Thread Heikki Linnakangas
Rename "scram" to "scram-sha-256" in pg_hba.conf and password_encryption. Per discussion, plain "scram" is confusing because we actually implement SCRAM-SHA-256 rather than the original SCRAM that uses SHA-1 as the hash algorithm. If we add support for SCRAM-SHA-512 or some other mechanism in the

[COMMITTERS] pgsql: Simplify docs on creating a self-signed SSL certificate

2017-04-18 Thread Andrew Dunstan
Simplify docs on creating a self-signed SSL certificate Discussion: Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/2b67c9d207d428c2476af0dd39043d83469d70c2 Modified Files -- do

Re: [COMMITTERS] pgsql: Update copyright for 2017

2017-04-18 Thread Masahiko Sawada
On Sat, Jan 7, 2017 at 1:14 AM, Bruce Momjian wrote: > On Wed, Jan 4, 2017 at 10:05:10AM -0500, Tom Lane wrote: >> Andres Freund writes: >> > On 2017-01-03 13:02:28 -0500, Bruce Momjian wrote: >> >> Yeah, I was doing parallel pulls of different branches in git via shell >> >> script, and it seem

[COMMITTERS] pgsql: Also fix comment in sample postgresql.conf file, for "scram-sha-

2017-04-18 Thread Heikki Linnakangas
Also fix comment in sample postgresql.conf file, for "scram-sha-256". Reported offlist by hubert depesz lubaczewski. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/b977780a9b2c546f8e2bf19fa3232b3e3d334916 Modified Files -- src/backend/utils/misc/postgr

[COMMITTERS] pgsql: Use DatumGetInt32() to extract 32-bit integer value from a datum

2017-04-18 Thread Fujii Masao
Use DatumGetInt32() to extract 32-bit integer value from a datum. Previously DatumGetObjectId() was wrongly used for that. Author: Masahiko Sawada Reviewed-by: Kyotaro Horiguchi Reported-by: Fujii Masao Discussion: http://postgr.es/m/CAHGQGwFDWh_Qr-q_GEMpD+qH=vYPMdVqw=zosy3kx_pna9r...@mail.gmail

[COMMITTERS] pgsql: A collection of small fixes for logical replication.

2017-04-18 Thread Fujii Masao
A collection of small fixes for logical replication. * Be sure to reset the launcher's pid (LogicalRepCtx->launcher_pid) to 0 even when the launcher emits an error. * Declare ApplyLauncherWakeup() as a static function because it's called only in launcher.c. * Previously IsBackendPId() was us

[COMMITTERS] pgsql: Provide an error cursor for "can't call an SRF here" errors.

2017-04-18 Thread Tom Lane
Provide an error cursor for "can't call an SRF here" errors. Since it appears that v10 is going to move the goalposts by some amount in terms of where you can and can't invoke set-returning functions, arrange for the executor's "set-valued function called in context that cannot accept a set" error

[COMMITTERS] pgsql: Improve documentation and comment for quorum-based sync replicat

2017-04-18 Thread Fujii Masao
Improve documentation and comment for quorum-based sync replication. Author: Masahiko Sawada, heavily modified by me Discussion: http://postgr.es/m/CAHGQGwEKOw=smplxjzkbsh6wwdbgonvz46qjhbtsiz-d-2r...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/a7

[COMMITTERS] pgsql: Doc: improve markup in self-signed certificate example.

2017-04-18 Thread Tom Lane
Doc: improve markup in self-signed certificate example. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/539f67012ec978e931054e413a4ab3c4c68bb737 Modified Files -- doc/src/sgml/runtime.sgml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --

[COMMITTERS] pgsql: Fix testing of parallel-safety of SubPlans.

2017-04-18 Thread Tom Lane
Fix testing of parallel-safety of SubPlans. is_parallel_safe() supposed that the only relevant property of a SubPlan was the parallel safety of the referenced subplan tree. This is wrong: the testexpr or args subtrees might contain parallel-unsafe stuff, as demonstrated by the test case added her