Re: [COMMITTERS] pgsql: hash: Immediately after a bucket split, try to clean the old buc

2017-08-07 Thread Ashutosh Sharma
Hi, I could see some diff getting generated after running pgindent script on 'src/backend/access/hash/hashpage.c' file and from the diff it looks like it got introduced as a part of this commit. Below is the diff observed, /* * If possible, clean up the old bucket. We might not

[COMMITTERS] pgsql: Downgrade subscription refresh messages to DEBUG1

2017-08-07 Thread Peter Eisentraut
Downgrade subscription refresh messages to DEBUG1 The NOTICE messages about tables being added or removed during subscription refresh would be incorrect and possibly confusing if the transaction rolls back, so silence them but keep them available for debugging. Discussion: https://www.postgresql

[COMMITTERS] pgsql: Improve wording of subscription refresh debug messages

2017-08-07 Thread Peter Eisentraut
Improve wording of subscription refresh debug messages Reported-by: Yugo Nagata Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/ad2ca3cba6e14dbd7b9f388b1e101cd5e2a2c210 Modified Files -- src/backend/commands/subscriptioncmds.c | 15 ++- 1 fi

[COMMITTERS] pgsql: Fix function name in code comment

2017-08-07 Thread Peter Eisentraut
Fix function name in code comment Reported-by: Peter Geoghegan Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/86524f038799db9e18c86df0ea6fb40c8102c0ab Modified Files -- src/backend/commands/collationcmds.c | 2 +- 1 file changed, 1 insertion(+), 1 dele

Re: [COMMITTERS] pgsql: Add support for ICU 4.2

2017-08-07 Thread Peter Eisentraut
On 8/6/17 20:40, Peter Geoghegan wrote: > On Sat, Aug 5, 2017 at 6:36 AM, Peter Eisentraut wrote: >> In ICU 4.2, ucol_getKeywordsForLocale() sometimes returns values that >> will not be accepted by uloc_toLanguageTag(). Skip loading keyword >> variants in that version. > > This should be spelled

[COMMITTERS] pgsql: Fix handling of dropped columns in logical replication

2017-08-07 Thread Peter Eisentraut
Fix handling of dropped columns in logical replication The relation attribute map was not initialized for dropped columns, leading to errors later on. Author: Petr Jelinek Reported-by: Scott Milliken Bug: #14769 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/0e5

[COMMITTERS] pgsql: Fix local/remote attribute mix-up in logical replication

2017-08-07 Thread Peter Eisentraut
Fix local/remote attribute mix-up in logical replication This would lead to failures if local and remote tables have a different column order. The tests previously didn't catch that because they only tested the initial data copy. So add another test that exercises the apply worker. Author: Petr

[COMMITTERS] pgsql: Translation updates

2017-08-07 Thread Peter Eisentraut
Translation updates Source-Git-URL: git://git.postgresql.org/git/pgtranslation/messages.git Source-Git-Hash: 1a0b5e655d7871506c2b1c7ba562c2de6b6a55de Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/f7668b2b3532b627ec951e1f0a28944f30cc4a1b Modified Files ---

[COMMITTERS] pgsql: Translation updates

2017-08-07 Thread Peter Eisentraut
Translation updates Source-Git-URL: git://git.postgresql.org/git/pgtranslation/messages.git Source-Git-Hash: 6535410ecbfd22426b13c2ddb1302145d66c1b4d Branch -- REL9_2_STABLE Details --- https://git.postgresql.org/pg/commitdiff/5fa4515a6a8536684285bc4837ec352fe2afe012 Modified Files

[COMMITTERS] pgsql: Translation updates

2017-08-07 Thread Peter Eisentraut
Translation updates Source-Git-URL: git://git.postgresql.org/git/pgtranslation/messages.git Source-Git-Hash: d81b8e4ab322171b7ea691c01513ede1cf398404 Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/aa0f366d557c32aa29a1cae9d13d6d078b514abd Modified Files

[COMMITTERS] pgsql: Translation updates

2017-08-07 Thread Peter Eisentraut
Translation updates Source-Git-URL: git://git.postgresql.org/git/pgtranslation/messages.git Source-Git-Hash: 0858deb5ec238f269d1311ff1299f003fc168cab Branch -- REL9_3_STABLE Details --- https://git.postgresql.org/pg/commitdiff/61f52850f5809ff62b8d2605ded0503f6a822ec9 Modified Files

[COMMITTERS] pgsql: Translation updates

2017-08-07 Thread Peter Eisentraut
Translation updates Source-Git-URL: git://git.postgresql.org/git/pgtranslation/messages.git Source-Git-Hash: d316c7f205275603a833ab9758ce51a76846ec58 Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/caada7c9bdbc41f4204516a099e25b85cd846004 Modified Files

[COMMITTERS] pgsql: Translation updates

2017-08-07 Thread Peter Eisentraut
Translation updates Source-Git-URL: git://git.postgresql.org/git/pgtranslation/messages.git Source-Git-Hash: b2b00a01f84ab4de02d4a4c954ca664bcb67becc Branch -- REL9_4_STABLE Details --- https://git.postgresql.org/pg/commitdiff/7ba2831555e71a5c8ad63bdca9f8006684772a16 Modified Files

Re: [COMMITTERS] pgsql: Record full paths of programs sought by "configure".

2017-08-07 Thread Andrew Dunstan
On 07/31/2017 01:02 PM, Tom Lane wrote: > Record full paths of programs sought by "configure". > > Previously we had a mix of uses of AC_CHECK_PROG[S] and AC_PATH_PROG[S]. > The only difference between those macros is that the latter emits the > full path to the program it finds, eg "/usr/bin/pro

[COMMITTERS] pgsql: Update SQL features list

2017-08-07 Thread Peter Eisentraut
Update SQL features list Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/cdc47d1f3942451952e2d8409069a5d1fa741fa8 Modified Files -- src/backend/catalog/sql_features.txt | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) -- Sent vi

Re: [COMMITTERS] pgsql: Record full paths of programs sought by "configure".

2017-08-07 Thread Tom Lane
Andrew Dunstan writes: > On 07/31/2017 01:02 PM, Tom Lane wrote: >> Record full paths of programs sought by "configure". > The problem with this commit, as jacana is demonstrating, is that on > Msys it finds the wrong prove. configure needs to run against the perl > we build against, i.e. a nativ

Re: [COMMITTERS] pgsql: Record full paths of programs sought by "configure".

2017-08-07 Thread Andrew Dunstan
On 08/07/2017 03:21 PM, Tom Lane wrote: > Andrew Dunstan writes: >> On 07/31/2017 01:02 PM, Tom Lane wrote: >>> Record full paths of programs sought by "configure". >> The problem with this commit, as jacana is demonstrating, is that on >> Msys it finds the wrong prove. configure needs to run ag

Re: [COMMITTERS] pgsql: Record full paths of programs sought by "configure".

2017-08-07 Thread Tom Lane
Andrew Dunstan writes: > On 08/07/2017 03:21 PM, Tom Lane wrote: >> I'm confused. AFAIK, that commit did not change which "prove" would >> be used --- at least not unless you change PATH between configure and >> make. It only changed how specifically that program would be named in >> Makefile.gl

Re: [COMMITTERS] pgsql: Record full paths of programs sought by "configure".

2017-08-07 Thread Andrew Dunstan
On 08/07/2017 03:36 PM, Tom Lane wrote: > Andrew Dunstan writes: >> On 08/07/2017 03:21 PM, Tom Lane wrote: >>> I'm confused. AFAIK, that commit did not change which "prove" would >>> be used --- at least not unless you change PATH between configure and >>> make. It only changed how specifical

Re: [COMMITTERS] pgsql: Record full paths of programs sought by "configure".

2017-08-07 Thread Tom Lane
Andrew Dunstan writes: > On 08/07/2017 03:36 PM, Tom Lane wrote: >> My goodness, that's ugly. Is it really better than injecting >> "PROVE=prove"? (I'd suggest saying that to configure, not make, >> so that the configure log bears some resemblance to what you >> want done.) > This is what we ha

Re: [COMMITTERS] pgsql: Record full paths of programs sought by "configure".

2017-08-07 Thread Andrew Dunstan
On 08/07/2017 04:07 PM, Tom Lane wrote: > Andrew Dunstan writes: >> On 08/07/2017 03:36 PM, Tom Lane wrote: >>> My goodness, that's ugly. Is it really better than injecting >>> "PROVE=prove"? (I'd suggest saying that to configure, not make, >>> so that the configure log bears some resemblance

Re: [COMMITTERS] pgsql: Record full paths of programs sought by "configure".

2017-08-07 Thread Tom Lane
Andrew Dunstan writes: > On 08/07/2017 04:07 PM, Tom Lane wrote: >> Sorry, I was imprecise. What I'm suggesting is that you drop the >> runtime PATH-foolery and instead put this in configure's environment: >> >> PROVE=$perlpathdir/prove >> >> Otherwise you're basically lying to configure about

Re: [COMMITTERS] pgsql: Record full paths of programs sought by "configure".

2017-08-07 Thread Andrew Dunstan
On 08/07/2017 04:20 PM, Tom Lane wrote: > Andrew Dunstan writes: >> On 08/07/2017 04:07 PM, Tom Lane wrote: >>> Sorry, I was imprecise. What I'm suggesting is that you drop the >>> runtime PATH-foolery and instead put this in configure's environment: >>> >>> PROVE=$perlpathdir/prove >>> >>> Oth

[COMMITTERS] pgsql: Skip test for IPC::Run if user is overriding our search for PROV

2017-08-07 Thread Tom Lane
Skip test for IPC::Run if user is overriding our search for PROVE. The check for IPC::Run we added in commit c254970ad is useful in simple cases, but there are real use-cases where "prove" is coming from a different Perl installation than the "perl" we want to use to build. In such cases asking wh

[COMMITTERS] pgsql: Stamp 10beta3.

2017-08-07 Thread Tom Lane
Stamp 10beta3. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/8d6442377df5451a8db598788847e6a70b3b49ef Modified Files -- configure | 18 +- configure.in | 2 +- doc/bug.template | 2 +- sr

[COMMITTERS] pgsql: Stamp 9.6.4.

2017-08-07 Thread Tom Lane
Stamp 9.6.4. Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/eca2f8a7dd9bda862a25fcc57ddf77f7c0dc3afe Modified Files -- configure| 18 +- configure.in | 2 +- doc/bug.template

[COMMITTERS] pgsql: Stamp 9.5.8.

2017-08-07 Thread Tom Lane
Stamp 9.5.8. Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/029386ccbddd0a33d481b94e511f5219b03e6636 Modified Files -- configure| 18 +- configure.in | 2 +- doc/bug.template

[COMMITTERS] pgsql: Stamp 9.4.13.

2017-08-07 Thread Tom Lane
Stamp 9.4.13. Branch -- REL9_4_STABLE Details --- https://git.postgresql.org/pg/commitdiff/6d81d0a215a5b843bf003b0a1c4b43f6d278 Modified Files -- configure| 18 +- configure.in | 2 +- doc/bug.template

[COMMITTERS] pgsql: Stamp 9.3.18.

2017-08-07 Thread Tom Lane
Stamp 9.3.18. Branch -- REL9_3_STABLE Details --- https://git.postgresql.org/pg/commitdiff/a5915db2fab1fbe555b6410440df5177a247a2f2 Modified Files -- configure| 18 +- configure.in | 2 +- doc/bug.template

[COMMITTERS] pgsql: Stamp 9.2.22.

2017-08-07 Thread Tom Lane
Stamp 9.2.22. Branch -- REL9_2_STABLE Details --- https://git.postgresql.org/pg/commitdiff/56fc4f7c9c8168b93b45ccf48781d77073d271dc Modified Files -- configure| 18 +- configure.in | 2 +- doc/bug.template

[COMMITTERS] pgsql: Disclaim xmltable() support for non-UTF8 databases.

2017-08-07 Thread Noah Misch
Disclaim xmltable() support for non-UTF8 databases. The xmltable() implementation mirrors xpath(), including its lack of character encoding awareness. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/b4a2eea030ba74ea84335c7d5bc999f693ffd9a4 Modified Files --