Re: [DOCS] Partitioning documentation example

2008-01-04 Thread Simon Riggs
On Fri, 2008-01-04 at 10:27 -0500, Bruce Momjian wrote: > It seems to me it would be much clearer if we added a second example > that used to_char() to create the INSERT statement dynamically based on > NEW.logdate: > > CREATE OR REPLACE FUNCTION measurement_insert_trigger() > RETURN

[DOCS] Partitioning documentation example

2008-01-04 Thread Bruce Momjian
Simon, I was looking at the new table partitioning documentation that recommends triggers: http://developer.postgresql.org/pgdocs/postgres/ddl-partitioning.html#DDL-PARTITIONING-IMPLEMENTATION and came upon this trigger function example: CREATE OR REPLACE FUNCTION measurement_in

Re: [DOCS] Partitioning documentation example

2008-01-04 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > EXECUTE 'INSERT INTO measurement_y' || > to_char(NEW.logdate,'_mMM') || ' VALUES (NEW.*)'; That won't actually work. Even if it did, I don't think we should be recommending use of EXECUTE here; the performance implications are bad.

Re: [DOCS] Partitioning documentation example

2008-01-04 Thread Bruce Momjian
Simon Riggs wrote: > On Fri, 2008-01-04 at 10:27 -0500, Bruce Momjian wrote: > > > It seems to me it would be much clearer if we added a second example > > that used to_char() to create the INSERT statement dynamically based on > > NEW.logdate: > > > > CREATE OR REPLACE FUNCTION measurement_i

Re: [DOCS] Partitioning documentation example

2008-01-04 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > >EXECUTE 'INSERT INTO measurement_y' || > > to_char(NEW.logdate,'_mMM') || ' VALUES (NEW.*)'; > > That won't actually work. Even if it did, I don't think we should be > recommending use of EXECUTE here; the performance imp