[HACKERS] addRangeTableEntry() relies on pstate, contrary to its documentation

2015-01-04 Thread Andres Freund
Hi, Since at least 61e532820824504aa92ad93c427722d3fa9c1632 from 2009, addRangeTableEntry() relies pstate being != NULL via its call to isLockedRefname() even though its documentation says: * If pstate is NULL, we just build an RTE and return it without adding it * to an rtable list. I think

Re: [HACKERS] addRangeTableEntry() relies on pstate, contrary to its documentation

2015-01-04 Thread Tom Lane
Andres Freund and...@2ndquadrant.com writes: Off list Tom commented that suggestion with: An easy alternative fix, of course, is to not call isLockedRefname if we don't have a pstate (or else put the pstate==NULL test inside it). I'm not a big fan of that - won't that essentially cause the