Re: [HACKERS] Sloppy SSPI error reporting code

2015-04-08 Thread Bruce Momjian
On Fri, Apr 3, 2015 at 08:32:08PM -0400, Noah Misch wrote: > On Thu, Apr 02, 2015 at 07:31:52AM -0400, Bruce Momjian wrote: > > On Thu, Apr 2, 2015 at 01:44:59AM -0400, Noah Misch wrote: > > > On Wed, Apr 01, 2015 at 10:49:01PM -0400, Bruce Momjian wrote: > > > > On Sat, Jan 10, 2015 at 02:53:13P

Re: [HACKERS] Sloppy SSPI error reporting code

2015-04-03 Thread Noah Misch
On Thu, Apr 02, 2015 at 07:31:52AM -0400, Bruce Momjian wrote: > On Thu, Apr 2, 2015 at 01:44:59AM -0400, Noah Misch wrote: > > On Wed, Apr 01, 2015 at 10:49:01PM -0400, Bruce Momjian wrote: > > > On Sat, Jan 10, 2015 at 02:53:13PM -0500, Tom Lane wrote: > > > > While looking at fe-auth.c I notice

Re: [HACKERS] Sloppy SSPI error reporting code

2015-04-02 Thread Bruce Momjian
On Thu, Apr 2, 2015 at 01:44:59AM -0400, Noah Misch wrote: > On Wed, Apr 01, 2015 at 10:49:01PM -0400, Bruce Momjian wrote: > > On Sat, Jan 10, 2015 at 02:53:13PM -0500, Tom Lane wrote: > > > While looking at fe-auth.c I noticed quite a few places that weren't > > > bothering to make error message

Re: [HACKERS] Sloppy SSPI error reporting code

2015-04-01 Thread Noah Misch
On Wed, Apr 01, 2015 at 10:49:01PM -0400, Bruce Momjian wrote: > On Sat, Jan 10, 2015 at 02:53:13PM -0500, Tom Lane wrote: > > While looking at fe-auth.c I noticed quite a few places that weren't > > bothering to make error messages localizable (ie, missing libpq_gettext > > calls), and/or were fai

Re: [HACKERS] Sloppy SSPI error reporting code

2015-04-01 Thread Bruce Momjian
On Sat, Jan 10, 2015 at 02:53:13PM -0500, Tom Lane wrote: > While looking at fe-auth.c I noticed quite a few places that weren't > bothering to make error messages localizable (ie, missing libpq_gettext > calls), and/or were failing to add a trailing newline as expected in > libpq error messages.