Re: [PATCHES] [HACKERS] Cannot initdb in cvs tip

2004-06-20 Thread Andrew Dunstan
John Hansen said: > On Sun, 2004-06-20 at 08:04, Dave Page wrote: >> > > although it says it's clearing the contents of the directory, in >> > > actual fact it leaves the directory structure in place, thus a >> > > subsequent initdb will not run without a manual clearup. >> > >> > Hm. The rmtree()

Re: [PATCHES] [HACKERS] Cannot initdb in cvs tip

2004-06-20 Thread Dave Page
-Original Message- From: John Hansen [mailto:[EMAIL PROTECTED] Sent: Sun 6/20/2004 2:27 AM To: Dave Page Cc: Tom Lane; PostgreSQL-development; [EMAIL PROTECTED] Subject: Re: [HACKERS] Cannot initdb in cvs tip > you could of course rmdir /s /q $PGDATA && mkdir $PGDATA if the purpose > i

Re: [PATCHES] Compiling libpq with VisualC

2004-06-20 Thread Andreas Pflug
Tom wrote: It's there to declare struct timeval, and I'm fairly certain that diking it out of the header would break things on some platforms. Where does Windows define struct timeval? struct timeval is defined in winsock.h under vc6. I'm checking for _MSC_VER now. Agreed. We define FRONTEND

Re: [PATCHES] eventlog fix

2004-06-20 Thread Laurent Ballester
Hello, I downloaded and compiled all files you store in CVS pgevent directory and it works. Following the discusion posted yesterday, I made a test with SimpleMC a alternative MC compiler ( http://www.volny.cz/xnavara/SimpleMC.zip) but unfortunatelly it doesn't works MSG0001.bin file generated ar

Re: [PATCHES] ALTER TABLE ... SET TABLESPACE

2004-06-20 Thread Tatsuo Ishii
> Attached is a patch implementing this functionality. > > I've modified make_new_heap() as well as swap_relfilenodes() to not assume > that tablespaces remain the same from old to new heap. I thought it better > to go down this road than introduce a lot of duplicate code. I have tried your patch

Re: [PATCHES] ALTER TABLE ... SET TABLESPACE

2004-06-20 Thread Tatsuo Ishii
> > Attached is a patch implementing this functionality. > > > > I've modified make_new_heap() as well as swap_relfilenodes() to not assume > > that tablespaces remain the same from old to new heap. I thought it better > > to go down this road than introduce a lot of duplicate code. > > I have tr

Re: [PATCHES] pg_ctl service integration for WIN32

2004-06-20 Thread Magnus Hagander
> >Amended patch attached. >Claudio Hi! Been testing this, and found a couple of small issues. Attached is a patch that fixes these. (Note - Claudios patch is included in this one, since it hasn't been applied yet..) The issues: 1) When something goes bad, output went to stderr. No way to see t

Re: [PATCHES] stderr & win32 admin check

2004-06-20 Thread Magnus Hagander
Attached is the updated version of this patch, which now includes proper testing for win32 service running. This is tested and verified with Claudios service wrapper pg_ctl patch (including the parts I added and sent in a short while ago). security.c goes in backend/port/win32/ //Magnus >-O

[PATCHES] initdb initial password from file

2004-06-20 Thread Magnus Hagander
Attached is a patch that adds the option --pwfile= to initdb. The first line of this file is used to set the new superuser password (the same way --pwprompt asks for one). This feature is needed for the win32 GUI installer (possibly other installers?), which need a way to specify the password to b

Re: [PATCHES] Cancel/Kill backend functions -- docs

2004-06-20 Thread Magnus Hagander
Here's at least some documentation about these. Not sure if we want to refer to these somewhere else as well, but this gives them entries in "misc functions". I don't have a working SGML build environment, so I'm not sure if this will turn out the way it's supposed (or even work at all). I tried

Re: [PATCHES] stderr & win32 admin check

2004-06-20 Thread Bruce Momjian
I am confused. There are no hooks to call this function right now. Is it called by Claudio's patch? --- Magnus Hagander wrote: > Attached is the updated version of this patch, which now includes proper > testing for win32

Re: [PATCHES] stderr & win32 admin check

2004-06-20 Thread Magnus Hagander
You probably would've been a lot less confused if I had actually included the *patch* along with the C file.. Sorry! //Magnus >-Original Message- >From: Bruce Momjian [mailto:[EMAIL PROTECTED] >Sent: den 20 juni 2004 20:27 >To: Magnus Hagander >Cc: Tom Lane; [EMAIL PROTECTED] >Subject

Re: [PATCHES] nested xacts and phantom Xids

2004-06-20 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: > Here I present the nested transactions patch and the phantom Xids patch > that goes with it. I looked at the phantom XIDs stuff a bit. I still have little confidence that the concept is correct :-( but here are some comments on the code level. > + *

Re: [PATCHES] [HACKERS] Compile failure with SSL

2004-06-20 Thread Dave Page
OK, looks like the error below is a Win32 thing. The patch attached #ifdef'd out the permissions check on the private key file as it won't work under Windows anyway (a similar check in postmaster.c has has already been ifdef'd out for the same reason). Incidently, the consts are also used in initd

Re: [PATCHES] Tablespaces

2004-06-20 Thread Simon Riggs
On Thu, 2004-05-27 at 07:59, Gavin Sherry wrote: > Attached is my latest patch implementing tablespaces. This has all the > functionality I was planning for 7.5. > > Most of the information about the patch is contained in the > patch/documentation, previous submissions and the archives. > > Testi

Re: [PATCHES] nested xacts and phantom Xids

2004-06-20 Thread Bruce Momjian
Tom Lane wrote: > Alvaro Herrera <[EMAIL PROTECTED]> writes: > > Here I present the nested transactions patch and the phantom Xids patch > > that goes with it. > > I looked at the phantom XIDs stuff a bit. I still have little confidence > that the concept is correct :-( but here are some comments

Re: [PATCHES] Tablespaces

2004-06-20 Thread Gavin Sherry
On Sun, 20 Jun 2004, Simon Riggs wrote: > On Thu, 2004-05-27 at 07:59, Gavin Sherry wrote: > > Attached is my latest patch implementing tablespaces. This has all the > > functionality I was planning for 7.5. > > > > Most of the information about the patch is contained in the > > patch/documentatio

Re: [PATCHES] nested xacts and phantom Xids

2004-06-20 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > I don't feel too bad about the runtime cost if only subtransactions are > paying that cost. That's exactly why I'm so exercised about what's been done to the HeapTupleSet/Get macros. That's significant cost that's paid even when you're not using *any* o

Re: [PATCHES] Tablespaces

2004-06-20 Thread Tom Lane
Simon Riggs <[EMAIL PROTECTED]> writes: > I've reviewed your patch by eye, but can't see anything in your patch > about relocating the pg_xlog directory. I see no reasonable way to move pg_xlog while the postmaster is up. So this is something that will always require outside-the-database activity.

Re: [PATCHES] nested xacts and phantom Xids

2004-06-20 Thread Bruce Momjian
Bruce Momjian wrote: > Tom Lane wrote: > > Alvaro Herrera <[EMAIL PROTECTED]> writes: > > > Here I present the nested transactions patch and the phantom Xids patch > > > that goes with it. > > > > I looked at the phantom XIDs stuff a bit. I still have little confidence > > that the concept is cor

Re: [PATCHES] nested xacts and phantom Xids

2004-06-20 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > Let me add that outside transactions read those phantom xid only when > they are doing dirty reads. What I don't understand is when do outside > transactions see tuples created inside a transaction? INSERT into a > table with a unique key? > Once the m

Re: [PATCHES] Tablespaces

2004-06-20 Thread Simon Riggs
On Sun, 2004-06-20 at 22:28, Tom Lane wrote: > Simon Riggs <[EMAIL PROTECTED]> writes: > > There was/is a TODO item: > > - Allow xlog directory location to be specified during initdb, perhaps > > using symlinks > > Note this says "during initdb", which is a whole different ballgame. > We could ce

Re: [PATCHES] nested xacts and phantom Xids

2004-06-20 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > Let me add that outside transactions read those phantom xid only when > > they are doing dirty reads. What I don't understand is when do outside > > transactions see tuples created inside a transaction? INSERT into a > > table with a

Re: [PATCHES] [pgsql-hackers-win32] Data directory with trailing [back]slash

2004-06-20 Thread Andrew Dunstan
Tom Lane wrote: "Magnus Hagander" <[EMAIL PROTECTED]> writes: It's not possible to start the postmaster on win32 with: postmaster -D d:\pgdata\ or postmaster -D d:/pgdata/ Sounds like canonicalize_path() needs to be applied a bit sooner than it is. BTW I think canonicalize_path() is a few

Re: [PATCHES] nested xacts and phantom Xids

2004-06-20 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: > Here I present the nested transactions patch and the phantom Xids patch > that goes with it. I took a very preliminary look through the nested-xacts patch, too. > Missing: rollback of SET CONSTRAINTS and GUC vars. There's a good deal more than that mi

Re: [PATCHES] nested xacts and phantom Xids

2004-06-20 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > What ideas do you have to help him? Eat the four-byte overhead. Quite frankly, given the other functionality and performance issues he has to solve in the next ten days (see my other message just now), I think he'd be a fool to spend one more minute on

Re: [PATCHES] nested xacts and phantom Xids

2004-06-20 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > What ideas do you have to help him? > > Eat the four-byte overhead. > > Quite frankly, given the other functionality and performance issues > he has to solve in the next ten days (see my other message just now), > I think he'd be a f

Re: [PATCHES] Admin guide tablespace docs

2004-06-20 Thread Tom Lane
Gavin Sherry <[EMAIL PROTECTED]> writes: > Attached. Applied with minor editorialization. Thanks. regards, tom lane ---(end of broadcast)--- TIP 3: if posting/reading through Usenet, please send an appropriate subscri

[PATCHES] pg_get_serial_sequence

2004-06-20 Thread Christopher Kings-Lynne
Hi, Attached is a new backend function, pg_get_serial_sequence. It allows you get a sequence name in a format suitable for use with the sequence functions. Has docs and regression. I updated pg_dump to use it as well. Tested against 7.5 and 7.4 backends, with independent and dependent sequence

[PATCHES] Show encoding in initdb messages

2004-06-20 Thread Christopher Kings-Lynne
Does this: The files belonging to this database system will be owned by user "chriskl". This user must also own the server process. The database cluster will be initialized with locale C. The database cluster will be initialized with default encoding UNICODE. creating directory /home/chriskl/local/