iliaa Mon Feb 4 21:31:52 2008 UTC
Modified files: (Branch: PHP_5_2)
/php-src/ext/gmpgmp.c
/php-srcNEWS
Log:
Revert fix for bug #43981, not yet ready for 5.2
I talk about PHP_5_2 (I thought it was clear from the email subject).
PHP_5_3 works fine on the same system.
Thanks. Dmitry.
Ilia Alshanetsky wrote:
Ok, i'll take a peak at the code, I am really surprised certain tests
pass here and fail for you... Are you testing on a 32bit platform in 5.3
On 02.02.2008 13:49, Dmitry Stogov wrote:
I talk about PHP_5_2 (I thought it was clear from the email subject).
PHP_5_3 works fine on the same system.
These two tests fail for ages, AFAIK the reason is that GMP produces
different results on different architectures.
5_2/ext/gmp/tests/021.phpt
It's very strange, because I still have the test failed.
ext/gmp/tests/021.php
The exactly broken thing is gmp_gcd(-1,0) that now returns -1 instead of
1. However you can see that return value of gmp_gcd(-2,2) now is not
equal to gmp_gcd(2,-2). :(
Thanks. Dmitry.
Ilia Alshanetsky wrote:
Ok, i'll take a peak at the code, I am really surprised certain tests
pass here and fail for you... Are you testing on a 32bit platform in
5.3 branch?
On 1-Feb-08, at 4:19 AM, Dmitry Stogov wrote:
It's very strange, because I still have the test failed.
ext/gmp/tests/021.php
The exactly
On 01.02.2008 18:36, Rasmus Lerdorf wrote:
All the gmp tests pass for me as well here with gmp-4.2.2 on an ancient
FreeBSD 4.10 box.
Same here on Linux 64bit (gmp-4.2.1, 5_3-CVS).
--
Wbr,
Antony Dovgal
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit:
All the gmp tests pass for me as well here with gmp-4.2.2 on an ancient
FreeBSD 4.10 box.
-Rasmus
Ilia Alshanetsky wrote:
Ok, i'll take a peak at the code, I am really surprised certain tests
pass here and fail for you... Are you testing on a 32bit platform in
5.3 branch?
On
Hi Ilia,
Probably your fix is not accurate, because it breaks
ext/gmp/tests/021.phpt, however it shouldn't from my point of view.
BTW my math knowledge is not excellent.
Could you please take a look.
May be the fix should be done only for gmp_div_r() and shouldn't affect
other functions.
When I ran the tests on my machine here all the tests had passed. I'll
take a look again.
On 31-Jan-08, at 3:50 AM, Dmitry Stogov wrote:
Hi Ilia,
Probably your fix is not accurate, because it breaks ext/gmp/tests/
021.phpt, however it shouldn't from my point of view.
BTW my math
Dmitry,
I've just tried to run the test on a patched 5.3 system and the test
passes without any problems. Why is the test failing on your machine?
On 31-Jan-08, at 3:50 AM, Dmitry Stogov wrote:
Hi Ilia,
Probably your fix is not accurate, because it breaks ext/gmp/tests/
021.phpt,
iliaa Wed Jan 30 18:27:04 2008 UTC
Modified files: (Branch: PHP_5_2)
/php-src/ext/gmpgmp.c
/php-srcNEWS
Log:
MFB: Fixed bug #43981 (gmp_div_r() does not preserve the sign of 1st
argument)
tony2001Thu Apr 26 13:44:02 2007 UTC
Added files: (Branch: PHP_5_2)
/php-src/ext/gmp/tests 011.phpt
Modified files:
/php-srcNEWS
/php-src/ext/gmpgmp.c
Log:
MFH: add test GMP_VERSION constant
do not allow zero
12 matches
Mail list logo
