Hi Ilia,
Would you please revert this change?
Saving one malloc/free in a function that has to query DB server anyway is not
going to give you much performance improvement, while other methods are not
portable across different PostgreSQL versions.
Edin
On Thursday 07 July 2005 02:52, Ilia Als
sniper Thu Jul 7 04:42:57 2005 EDT
Modified files:
/php-srcNEWS
Log:
reorder. Also: Documentation belongs elsewhere :)
http://cvs.php.net/diff.php/php-src/NEWS?r1=1.1983&r2=1.1984&ty=u
Index: php-src/NEWS
diff -u php-src/NEWS:1.1983 php-src/NEWS:1.1984
---
rrichards Thu Jul 7 06:36:09 2005 EDT
Modified files:
/php-src/ext/domelement.c
Log:
Allow NULL namespaceURI for getAttributeNodeNS
http://cvs.php.net/diff.php/php-src/ext/dom/element.c?r1=1.34&r2=1.35&ty=u
Index: php-src/ext/dom/element.c
diff -u php
dmitry Thu Jul 7 07:19:57 2005 EDT
Modified files:
/php-src/ext/pdopdo_dbh.c pdo_stmt.c
Log:
Fixed memory leaks
http://cvs.php.net/diff.php/php-src/ext/pdo/pdo_dbh.c?r1=1.76&r2=1.77&ty=u
Index: php-src/ext/pdo/pdo_dbh.c
diff -u php-src/ext/pdo/pdo_dbh.c
wez Thu Jul 7 08:42:53 2005 EDT
Modified files:
/php-src/ext/pdo/tests pdo_021.phpt
Log:
It's not portable to expect any consistency between drivers in the return
value
of an exec() when running DDL; revise test.
http://cvs.php.net/diff.php/ph
wez Thu Jul 7 08:44:45 2005 EDT
Modified files:
/php-src/ext/pdo/tests pdo_016.phpt
Log:
pedantic WS
http://cvs.php.net/diff.php/php-src/ext/pdo/tests/pdo_016.phpt?r1=1.3&r2=1.4&ty=u
Index: php-src/ext/pdo/tests/pdo_016.phpt
diff -u php-src/ext/pdo/
wez Thu Jul 7 08:45:41 2005 EDT
Modified files:
/php-src/ext/pdopdo_stmt.c
Log:
Fix bug in bindColumn() for drivers that implement native prepared statements
and that use the PDO rewriter to handle non-native parameter syntax.
http://cvs.php.net
wez Thu Jul 7 08:49:23 2005 EDT
Modified files:
/php-src/ext/pdo_odbc odbc_driver.c odbc_stmt.c pdo_odbc.c
php_pdo_odbc.h php_pdo_odbc_int.h
Log:
Fix handling of parameter binding.
We need to guess at parameter sizing i
wez Thu Jul 7 08:58:49 2005 EDT
Modified files:
/php-srcrun-tests.php
Log:
Fix 2 bugs:
- summary is only displayed if 2 or more tests were detected
- error out of a bogus test name is passed in
http://cvs.php.net/diff.php/php-src/run-tests.php?r1
wez Thu Jul 7 09:04:26 2005 EDT
Added files:
/php-src/ext/sqlite/tests/pdo common.phpt
Removed files:
/php-src/ext/sqlite/tests/pdo connection.inc pdo_001.phpt
pdo_002.phpt pdo_003.phpt
Edink,
It is malloc + PQescapeString + free, which in most cases are completely
unnecessary. While as Christopher demonstrates sequence name could
contain special chars, I'd wager that is a VERY uncommon situation.
Ilia
Edin Kadribasic wrote:
Hi Ilia,
Would you please revert this change?
wez Thu Jul 7 09:22:39 2005 EDT
Modified files:
/php-src/win32/buildconfutils.js
Log:
If asked to populate a set of cflags for a header check, only populate the
flags and don't fill in an entry into config.w32.h, UNLESS explicitly told
what to do.
How about using a stack variable for this temporary allocation?
On 7/7/05, Ilia Alshanetsky <[EMAIL PROTECTED]> wrote:
> Edink,
>
> It is malloc + PQescapeString + free, which in most cases are completely
> unnecessary. While as Christopher demonstrates sequence name could
> contain special chars
iliaa Thu Jul 7 09:35:41 2005 EDT
Modified files:
/php-src/ext/pdo_pgsql config.m4 pgsql_driver.c
Log:
Use PQexecParams() when available, use original case in all other instances.
http://cvs.php.net/diff.php/php-src/ext/pdo_pgsql/config.m4?r1=1.10&r2=
wez Thu Jul 7 09:42:13 2005 EDT
Modified files:
/php-src/ext/pdo_odbc config.m4
Log:
Hmm, these ldflags went AWOL.
http://cvs.php.net/diff.php/php-src/ext/pdo_odbc/config.m4?r1=1.20&r2=1.21&ty=u
Index: php-src/ext/pdo_odbc/config.m4
diff -u php-src
wez Thu Jul 7 09:56:11 2005 EDT
Modified files:
/php-src/ext/pdo/tests pdo_test.inc
Log:
extra paranoia about the attribute param
http://cvs.php.net/diff.php/php-src/ext/pdo/tests/pdo_test.inc?r1=1.1&r2=1.2&ty=u
Index: php-src/ext/pdo/tests/pdo_test
wez Thu Jul 7 09:56:40 2005 EDT
Modified files:
/php-src/ext/pdo_odbc/tests common.phpt
Log:
more paranoia about the attribute param here too
http://cvs.php.net/diff.php/php-src/ext/pdo_odbc/tests/common.phpt?r1=1.1&r2=1.2&ty=u
Index: php-src/ext/pdo_odb
wez Thu Jul 7 09:58:03 2005 EDT
Modified files:
/php-srcrun-tests.php
Log:
sort redirected tests
http://cvs.php.net/diff.php/php-src/run-tests.php?r1=1.218&r2=1.219&ty=u
Index: php-src/run-tests.php
diff -u php-src/run-tests.php:1.218 php-src/run-tes
wez Thu Jul 7 09:58:35 2005 EDT
Added files:
/php-src/ext/pdo_oci/tests common.phpt
Removed files:
/php-src/ext/pdo_oci/tests connection.inc pdo_001.phpt pdo_002.phpt
pdo_003.phpt pdo_004.phpt pdo_005.php
wez Thu Jul 7 09:59:34 2005 EDT
Modified files:
/php-src/ext/pdo/tests pdo_test.inc
Log:
make column names lower case
http://cvs.php.net/diff.php/php-src/ext/pdo/tests/pdo_test.inc?r1=1.2&r2=1.3&ty=u
Index: php-src/ext/pdo/tests/pdo_test.inc
diff -u
wez Thu Jul 7 10:10:00 2005 EDT
Modified files:
/php-src/ext/pdo/tests pdo_009.phpt pdo_010.phpt pdo_018.phpt
Log:
Need to state NOT NULL here, as DB2 won't allow the UNIQUE constraint without
it.
http://cvs.php.net/diff.php/php-src/ext/pdo/tests/p
wez Thu Jul 7 10:20:05 2005 EDT
Modified files:
/php-src/ext/pdo_odbc odbc_stmt.c
Log:
DB2 wants us to use the proper ODBC 3 function for closing a cursor.
http://cvs.php.net/diff.php/php-src/ext/pdo_odbc/odbc_stmt.c?r1=1.21&r2=1.22&ty=u
Index: php
wez Thu Jul 7 11:04:47 2005 EDT
Added files:
/php-src/ext/pdo_mysql/testscommon.phpt
Removed files:
/php-src/ext/pdo_mysql/testsconnection.inc pdo_001.phpt
pdo_002.phpt pdo_003.phpt
iliaa Thu Jul 7 11:13:29 2005 EDT
Modified files:
/php-src/ext/pdo_sqlite sqlite_statement.c
Log:
Fixed memory leak, after SQLITE_DONE sqlite3_data_count() always returns 0.
http://cvs.php.net/diff.php/php-src/ext/pdo_sqlite/sqlite_statement.c?r1=1.14&
iliaa Thu Jul 7 11:14:12 2005 EDT
Modified files:
/php-src/ext/pdopdo_stmt.c
Log:
Return an empty array rather then FALSE in fetchAll() on no results.
http://cvs.php.net/diff.php/php-src/ext/pdo/pdo_stmt.c?r1=1.103&r2=1.104&ty=u
Index: php-src/ext/p
wez Thu Jul 7 11:15:02 2005 EDT
Modified files:
/php-src/ext/pdo/tests pdo_001.phpt pdo_002.phpt pdo_003.phpt
pdo_004.phpt pdo_005.phpt pdo_006.phpt
pdo_007.phpt pdo_008.phpt pdo_009.phpt
tony2001Thu Jul 7 11:19:41 2005 EDT
Modified files:
/php-srcNEWS
/php-src/ext/standard string.c
Log:
fix #33605 (substr_compare() crashes with negative offset & length)
http://cvs.php.net/diff.php/php-src/NEWS?r1=1.1985&r2=1.1986&ty=u
wez Thu Jul 7 11:20:06 2005 EDT
Added files:
/php-src/ext/pdo_pgsql/testscommon.phpt
Log:
adopt new tests
http://cvs.php.net/co.php/php-src/ext/pdo_pgsql/tests/common.phpt?r=1.1&p=1
Index: php-src/ext/pdo_pgsql/tests/common.phpt
+++ php-src/e
iliaa Thu Jul 7 11:32:33 2005 EDT
Modified files:
/php-src/ext/pdo/tests pdo_001.phpt pdo_002.phpt pdo_003.phpt
pdo_004.phpt pdo_005.phpt pdo_006.phpt
pdo_007.phpt pdo_008.phpt pdo_009.phpt
wez Thu Jul 7 11:33:07 2005 EDT
Added files:
/php-src/ext/pdo_firebird/tests common.phpt
Removed files:
/php-src/ext/pdo_firebird/tests connection.inc pdo_001.phpt
pdo_002.phpt pdo_003.phpt
wez Thu Jul 7 11:34:46 2005 EDT
Removed files:
/php-src/ext/pdo_pgsql/testsconnection.inc pdo_001.phpt
pdo_002.phpt pdo_003.phpt pdo_004.phpt
pdo_005.phpt pdo_006.phpt pdo_00
wez Thu Jul 7 11:36:00 2005 EDT
Removed files:
/php-src/ext/pdo/tests pdo_001.inc pdo_002.inc pdo_003.inc
pdo_004.inc pdo_005.inc pdo_006.inc
pdo_007.inc pdo_008.inc pdo_009.inc
wez Thu Jul 7 11:47:35 2005 EDT
Modified files:
/CVSROOTavail
Log:
Karma for fastcgi
http://cvs.php.net/diff.php/CVSROOT/avail?r1=1.992&r2=1.993&ty=u
Index: CVSROOT/avail
diff -u CVSROOT/avail:1.992 CVSROOT/avail:1.993
--- CVSROOT/avail:1.992 Wed Jul
wez Thu Jul 7 11:49:15 2005 EDT
Modified files:
/CVSROOTloginfo
Log:
commit messages to people that are most interested right now.
Can explore setting up a mailing list later.
http://cvs.php.net/diff.php/CVSROOT/loginfo?r1=1.114&r2=1.115&ty=u
Index
iliaa Thu Jul 7 11:54:00 2005 EDT
Modified files:
/php-src/ext/pdo_mysql mysql_statement.c
Log:
Fixed memory leak.
http://cvs.php.net/diff.php/php-src/ext/pdo_mysql/mysql_statement.c?r1=1.28&r2=1.29&ty=u
Index: php-src/ext/pdo_mysql/mysql_statement.c
dmitry Thu Jul 7 12:09:57 2005 EDT
Modified files:
/php-src/tests/classes array_access_001.phpt array_access_002.phpt
Log:
Fixed bug #33512 (Add missing support for isset()/unset() overloading to
complement the property get/set methods). Now empty($obj[...]
20050702
+#define PDO_DRIVER_API 20050707
enum pdo_param_type {
PDO_PARAM_NULL,
@@ -126,6 +126,7 @@
PDO_ATTR_STATEMENT_CLASS, /* array(classname, array(ctor_args))
to specify the class of the constructed statement */
PDO_ATTR_FETCH_TABLE_NAMES, /* include table names in th
iliaa Thu Jul 7 12:27:47 2005 EDT
Modified files:
/php-src/ext/pdo_mysql mysql_driver.c
Log:
Fixed memory leak
http://cvs.php.net/diff.php/php-src/ext/pdo_mysql/mysql_driver.c?r1=1.51&r2=1.52&ty=u
Index: php-src/ext/pdo_mysql/mysql_driver.c
diff -u ph
wez Thu Jul 7 13:08:03 2005 EDT
Modified files:
/php-src/ext/pdopdo.c pdo_dbh.c
Log:
populate the new dbh->driver field.
Implement PDO_ATTR_DRIVER_NAME.
http://cvs.php.net/diff.php/php-src/ext/pdo/pdo.c?r1=1.52&r2=1.53&ty=u
Index: php-src/ext/pdo/p
dmitry Thu Jul 7 13:29:26 2005 EDT
Modified files:
/php-src/ext/soap php_encoding.c
Log:
Fixed SIGSEGV on decoding elements
http://cvs.php.net/diff.php/php-src/ext/soap/php_encoding.c?r1=1.98&r2=1.99&ty=u
Index: php-src/ext/soap/php_encoding.c
diff -u ph
dmitry Thu Jul 7 13:29:39 2005 EDT
Modified files: (Branch: PHP_5_0)
/php-src/ext/soap php_encoding.c
Log:
Fixed SIGSEGV on decoding elements
http://cvs.php.net/diff.php/php-src/ext/soap/php_encoding.c?r1=1.71.2.22&r2=1.71.2.23&ty=u
Index: php-src/ext/soa
iliaa Thu Jul 7 13:53:39 2005 EDT
Modified files:
/php-src/ext/pdo_mysql mysql_statement.c
Log:
Make prepared statements obey buffering flag in MySQL.
http://cvs.php.net/diff.php/php-src/ext/pdo_mysql/mysql_statement.c?r1=1.29&r2=1.30&ty=u
Index: php-
Oh, that's a different story then...
At 01:54 PM 7/7/2005 +0800, Christopher Kings-Lynne wrote:
It does impose a v7.4 and above libpq requirement, however.
Chris
Andi Gutmans wrote:
Yeah, definitely seems like PQexecParams is the safest and easiest way of
doing so.
In general, I'm always in f
iliaa Thu Jul 7 14:50:01 2005 EDT
Modified files:
/php-src/ext/pdo/tests pdo_012.phpt pdo_013.phpt pdo_016.phpt
pdo_017.phpt pdo_018.phpt pdo_021.phpt
pdo_026.phpt
Log:
1st set of fixes to ma
Hello Jani,
consistency is good. So if ever we run into a related problem we'd only
need to care for that single typedef. Thanks Jani.
marcus
Wednesday, July 6, 2005, 2:58:25 PM, you wrote:
> What difference does it make as long as it works? GCC 4 it is. =)
> Anyways, the other fun
Did you get a specific problem without those?
Or did you just blindly add those and didn't notice
the line with PHP_EVAL_LIBLINE() just before those tests?
--Jani
On Thu, 7 Jul 2005, Wez Furlong wrote:
wez Thu Jul 7 09:42:13 2005 EDT
Modified files:
/php-src/
yes, no, yes.
configure was generated without the required -L path to the libs.
This was a shared build from under HEAD.
--Wez.
Jani Taskinen wrote:
Did you get a specific problem without those?
Or did you just blindly add those and didn't notice
the line with PHP_EVAL_LIBLINE()
tony2001Thu Jul 7 19:02:23 2005 EDT
Modified files:
/php-src/ext/pdo_ocioci_statement.c
Log:
free parameter when requested to do so
http://cvs.php.net/diff.php/php-src/ext/pdo_oci/oci_statement.c?r1=1.14&r2=1.15&ty=u
Index: php-src/ext/pdo_oc
tony2001Thu Jul 7 19:03:22 2005 EDT
Modified files:
/php-src/ext/pdo_ocioci_driver.c
Log:
do not set error_code to HY000 when there was NO error
reset both handle & statement error codes to 0
http://cvs.php.net/diff.php/php-src/ext/pdo_oci/
sniper Thu Jul 7 19:18:22 2005 EDT
Modified files:
/php-srcacinclude.m4
/php-src/ext/date config.m4
Log:
- Fixed stupid bug in PHP_INSTALL_HEADERS() macro: "foo bar" != foo bar
- ext/date/lib/timelib_config.h is also installed now
http://cvs.ph
iliaa Thu Jul 7 20:40:33 2005 EDT
Modified files:
/php-srcNEWS
/php-src/ext/pgsql pgsql.c php_pgsql.h
Log:
Added pg_fetch_all_columns() function to fetch all values of a column from
a result cursor.
http://cvs.php.net/diff.php/php-src/NEWS?r1=1
It is malloc + PQescapeString + free, which in most cases are completely
unnecessary. While as Christopher demonstrates sequence name could
contain special chars, I'd wager that is a VERY uncommon situation.
Uncommon is totally irrelevant. Stable, robust code is what is. What
is this - the "
Thanks - I think that's the best solution.
Chris
Ilia Alshanetsky wrote:
iliaa Thu Jul 7 09:35:41 2005 EDT
Modified files:
/php-src/ext/pdo_pgsql config.m4 pgsql_driver.c
Log:
Use PQexecParams() when available, use original case in all other instances.
Uncommon is totally irrelevant. Stable, robust code is what is. What
is this - the "Cross your fingers and hope it works programming language"??
Nah, it's more along the lines of "works for me" :-)
Ilia
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/u
Wez Furlong wrote:
wez Thu Jul 7 08:45:41 2005 EDT
Modified files:
/php-src/ext/pdo pdo_stmt.c
Log:
Fix bug in bindColumn() for drivers that implement native prepared statements
and that use the PDO rewriter to handle non-native parameter syntax.
Is t
Pointing me at some good documentation for it would help; I find the
postgres site really difficult to extract information from. I've looked
on two occasions but got fed up with lack of info.
If you can show me some C code that does it, I'll install postgres and
hack up something to make it w
Pointing me at some good documentation for it would help; I find the
postgres site really difficult to extract information from. I've looked
on two occasions but got fed up with lack of info.
Interesting. I find the PostgreSQL manual elegant, simple and
orthogonal and I find the MySQL one a
:24:51 wez Exp $ */
+/* $Id: php_pdo_driver.h,v 1.61 2005/07/08 04:12:58 wez Exp $ */
#ifndef PHP_PDO_DRIVER_H
#define PHP_PDO_DRIVER_H
@@ -44,7 +44,7 @@
# define FALSE 0
#endif
-#define PDO_DRIVER_API 20050707
+#define PDO_DRIVER_API 20050708
enum pdo_param_type {
PDO_PARAM_
58 matches
Mail list logo
