D25873: [KCMs/Workspace] Add explanatory labels for click-related settings

Fuchs added a comment. Sidenote, maybe an upstream bug / wish can be added about > Oh darn, so it does. I checked the docs and tried setting SH_ScrollBar_MiddleClickAbsolutePosition explicitly, but it looks like there's actually no option to do page-by-page navigation for clicking

D25873: [KCMs/Workspace] Add explanatory labels for click-related settings

ngraham updated this revision to Diff 71328. ngraham added a comment. Only show the message when left-click-navigates-by-page mode is in use REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25873?vs=71250=71328 BRANCH explanatory-text (branched

D25873: [KCMs/Workspace] Add explanatory labels for click-related settings

ngraham added inline comments. INLINE COMMENTS > ndavis wrote in main.qml:164 > This is incorrect. Middle clicking still jumps to the clicked location. Oh darn, so it does. I checked the docs and tried setting `SH_ScrollBar_MiddleClickAbsolutePosition` explicitly, but it looks like there's

D25908: Lock screen by default, on mobile

nicolasfella accepted this revision. nicolasfella added a comment. This revision is now accepted and ready to land. Works fine for me REPOSITORY R122 Powerdevil BRANCH master REVISION DETAIL https://phabricator.kde.org/D25908 To: apol, #plasma, broulik, nicolasfella Cc: nicolasfella,

D25910: [Notifications] Add support for global do not disturb toggle shortcut

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY It enables do not disturb until turned off and allows disabling it. TEST PLAN It doesn't

D25908: Lock screen by default, on mobile

nicolasfella added a comment. Oh yes please +1 REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D25908 To: apol, #plasma, broulik Cc: nicolasfella, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin,

D25908: Lock screen by default, on mobile

apol created this revision. apol added reviewers: Plasma, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY At the moment it will do the same thing as the desktop: show the logout dialog countdown, which

[Breeze] [Bug 369158] Breeze sddm theme broken on dual monitor setup (no cursor)

https://bugs.kde.org/show_bug.cgi?id=369158 --- Comment #6 from AE --- Hi! Unfortunately I'm not using a dual screen setup these days, so I cannot confirm or deny. -- You are receiving this mail because: You are the assignee for the bug.

D25873: [KCMs/Workspace] Add explanatory labels for click-related settings

ndavis added inline comments. INLINE COMMENTS > main.qml:164 > +QQC2.Label { > +text: scrollbarLeftClickNavigatesByPage.checked ? > i18n("Middle-click to scroll to clicked location") : i18n("Middle-click to > scroll by page") > +font.pointSize:

D25884: Find qdbus command correctly

This revision was automatically updated to reflect the committed changes. Closed by commit R120:1657457702a4: Find qdbus command correctly (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25884?vs=71273=71294 REVISION DETAIL

D24238: Port the pager applet away from QtWidgets

dfaure added a comment. Oh I see. Is there a non-deprecated method to get the overall geometry of all screens combined, or do we need to iterate over the list of screens? Surprising that this doesn't seem to be anywhere in the API !? REPOSITORY R119 Plasma Desktop REVISION

D25889: Polish the "review this review" UI and presentation

ngraham updated this revision to Diff 71290. ngraham added a comment. Fix the rebase REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25889?vs=71287=71290 BRANCH polish-review-reviewing (branched from master) REVISION DETAIL

D25889: Polish the "review this review" UI and presentation

ngraham updated this revision to Diff 71287. ngraham added a comment. Rebase REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25889?vs=71284=71287 BRANCH polish-review-reviewing (branched from master) REVISION DETAIL

D25886: Add support for sub-comments to the Reviews backend

This revision was automatically updated to reflect the committed changes. Closed by commit R134:a4b6d2d5c25e: Add support for sub-comments to the Reviews backend (authored by leinir). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE

D25886: Add support for sub-comments to the Reviews backend

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Nice! REPOSITORY R134 Discover Software Store BRANCH add-support-for-subcomments (branched from master) REVISION DETAIL https://phabricator.kde.org/D25886 To: leinir,

D25889: Polish the "review this review" UI and presentation

ngraham created this revision. ngraham added reviewers: VDG, apol, Discover Software Store. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Now with 100% more Emojis! And the UI doesn't blend into the actual

D25846: [Cuttlefish] Use the same actions in all menus

This revision was automatically updated to reflect the committed changes. Closed by commit R118:6e3f467ad266: [Cuttlefish] Use the same actions in all menus (authored by davidre). REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25846?vs=71255=71282

D25886: Add support for sub-comments to the Reviews backend

leinir created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. leinir requested review of this revision. REVISION SUMMARY Using a similar style to the comments delegate in KNewStuffQuick, this adds the functionality for having subcomments in the Reviews

D22359: Revert "[showdesktop][minimizeall] Reduce the maximum panel icon size"

ngraham added a comment. Fixed in D25885 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D22359 To: ndavis, #vdg, #plasma, davidedmundson Cc: mart, KonqiDragon, ngraham, davidedmundson, filipf, plasma-devel, LeGast00n,

D24238: Port the pager applet away from QtWidgets

ognarb added a comment. This patch maybe created this bug: https://bugs.kde.org/show_bug.cgi?id=414849 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24238 To: dfaure, hein, apol Cc: ognarb, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D25884: Find qdbus command correctly

ngraham created this revision. ngraham added reviewers: davidedmundson, fvogt, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY The wallpeper knsrc file file assumes that `qdbus` is in $PATH. However

D25882: Remove dynamic item creation in DefaultListItemBackground

ahiemstra created this revision. ahiemstra added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY For some unknown reason, DefaultListItemBackground uses dynamic item creation instead

D25879: Add an option to enable QML profiling

This revision was automatically updated to reflect the committed changes. ahiemstra marked an inline comment as done. Closed by commit R1014:693c491bc577: Add an option to enable QML profiling (authored by ahiemstra). REPOSITORY R1014 Kirigami Gallery CHANGES SINCE LAST UPDATE

D25879: Add an option to enable QML profiling

ahiemstra marked an inline comment as done. ahiemstra added inline comments. INLINE COMMENTS > bshah wrote in CMakeLists.txt:33 > Commit description and code doesn't match :) D'oh. REPOSITORY R1014 Kirigami Gallery REVISION DETAIL https://phabricator.kde.org/D25879 To: ahiemstra,

D25879: Add an option to enable QML profiling

ahiemstra updated this revision to Diff 71264. ahiemstra added a comment. - Actually set qml profiling to ON by default REPOSITORY R1014 Kirigami Gallery CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25879?vs=71263=71264 BRANCH qmlprofiling REVISION DETAIL

D25879: Add an option to enable QML profiling

ahiemstra created this revision. ahiemstra added a reviewer: Kirigami. Herald added projects: Plasma, Kirigami. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY This adds a CMake option to enable QML profiler and debugger integration. This

D25879: Add an option to enable QML profiling

bshah requested changes to this revision. bshah added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > CMakeLists.txt:33 > > +option(ENABLE_QML_PROFILING "Enable QML profiler support" OFF) > + Commit description and code doesn't match :) REPOSITORY R1014

D23241: Show application window icon on AboutPage

This revision was automatically updated to reflect the committed changes. Closed by commit R169:59a9b92fc6c7: Show application window icon on AboutPage (authored by caspermeijn, committed by ngraham). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D23241: Show application window icon on AboutPage

mart accepted this revision. mart added a comment. It looks quite weird to have it in something called "Settings", tough.. i' fine (in kf6 should really be renamed to something more sensible) I agree with Eike that it would be better for it to be in Qt.Application, but i'm fine with it

D25846: [Cuttlefish] Use the same actions in all menus

davidre added inline comments. INLINE COMMENTS > Menu.qml:24 > > -import QtQuick 2.5 > -import Qt.labs.platform 1.0 > +import QtQuick 2.3 > +import QtQuick.Controls 2.5 as QQC2 Sorry that came from the copy-pasting from Kirigami > Menu.qml:47 > +property Component

D25846: [Cuttlefish] Use the same actions in all menus

davidre updated this revision to Diff 71255. davidre marked 2 inline comments as done. davidre added a comment. Comments REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25846?vs=71193=71255 BRANCH actions (branched from master) REVISION DETAIL

D13175: List the Activity Pager also as an alternative to e.g. the Activity Bar

This revision was automatically updated to reflect the committed changes. Closed by commit R114:d9109808cd16: List the Activity Pager also as an alternative to e.g. the Activity Bar (authored by hein, committed by ngraham). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE

D25874: [Task Manager] Consider parent PID for audio stream

broulik created this revision. broulik added reviewers: Plasma, hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY For modern web browsers, the audio stream isn't owned by the same process as the window,

D25873: [KCMs/Workspace] Add explanatory labels for click-related settings

ngraham created this revision. ngraham added reviewers: VDG, Plasma, Fuchs. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This way the behavior of the related action is clear no matter which setting is

D25872: Refactor GTK KCM code

gikari created this revision. gikari added a reviewer: apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gikari requested review of this revision. REVISION SUMMARY This diff introduces purely cosmetic changes. 1. KCM now compiled with no signals/slot keywords