D27100: [GTK Config] Parameterise GTK config editing

This revision was automatically updated to reflect the committed changes. Closed by commit R99:0580098ab4cd: [GTK Config] Parameterise GTK config editing (authored by gikari). REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE

D27100: [GTK Config] Parameterise GTK config editing

gikari updated this revision to Diff 79089. gikari marked 2 inline comments as done. gikari added a comment. - Remove `explicit` QVariant wrappers REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27100?vs=77909=79089 BRANCH

D27100: [GTK Config] Parameterise GTK config editing

cblack accepted this revision. cblack added a comment. This revision is now accepted and ready to land. Besides one minor over-verbosity issue, this looks like shipit material to me. Drop the QVariant() wrappers (but don't drop the `#include`) before landing, please. INLINE COMMENTS >

D27100: [GTK Config] Parameterise GTK config editing

gikari added a comment. Ping REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D27100 To: gikari, #plasma, cblack Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf,

D27100: [GTK Config] Parameterise GTK config editing

gikari updated this revision to Diff 77909. gikari added a comment. Rebase on master REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27100?vs=77185=77909 BRANCH parameterise-gtk-config-io (branched from master) REVISION DETAIL

D27100: [GTK Config] Parameterise GTK config editing

gikari added a comment. Ping REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D27100 To: gikari, #plasma, cblack Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf,

D27100: [GTK Config] Parameterise GTK config editing

gikari updated this revision to Diff 77185. gikari added a comment. Use `arg` instead of + + + + + + REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27100?vs=74855=77185 BRANCH parameterise-gtk-config-io (branched from master) REVISION

D27100: [GTK Config] Parameterise GTK config editing

gikari added a comment. In D27100#617732 , @cblack wrote: > There's a lot of string concatenation going on. I would replace a lot of the instances where you concat more than 2 strings with QString's arg function for readability purposes.

D27100: [GTK Config] Parameterise GTK config editing

cblack requested changes to this revision. cblack added a comment. This revision now requires changes to proceed. There's a lot of string concatenation going on. I would replace a lot of the instances where you concat more than 2 strings with QString's arg function for readability purposes.