Re: Review Request 114260: Port mouse dataengine

2014-12-13 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114260/#review71914 --- plasma/generic/dataengines/mouse/CMakeLists.txt

Re: Review Request 114260: Port mouse dataengine

2014-12-13 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114260/ --- (Updated Dec. 13, 2014, 10:30 a.m.) Status -- This change has been d

Re: Review Request 114260: Port mouse dataengine

2014-07-29 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114260/#review63416 --- Ship it! fine to go - Marco Martin On Feb. 21, 2014, 6:54

Re: Review Request 114260: Port mouse dataengine

2014-02-21 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114260/#review50470 --- Ship it! Removing the scheduleSourcesUpdated calls is fine. T

Re: Review Request 114260: Port mouse dataengine

2014-02-20 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114260/ --- (Updated Feb. 21, 2014, 6:54 a.m.) Review request for Plasma. Changes -

Re: Review Request 114260: Port mouse dataengine

2014-02-19 Thread Alex Merry
> On Feb. 2, 2014, 11:42 a.m., Bhushan Shah wrote: > > Please test it with plasmaengineexplorer in my testing it shows no sources. Any progress on this? - Alex --- This is an automatically generated e-mail. To reply, visit: https://git.

Re: Review Request 114260: Port mouse dataengine

2014-02-02 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114260/#review48763 --- Please test it with plasmaengineexplorer in my testing it show

Re: Review Request 114260: Port mouse dataengine

2014-02-02 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114260/ --- (Updated Feb. 2, 2014, 12:26 p.m.) Review request for KDE Frameworks and

Re: Review Request 114260: Port mouse dataengine

2014-02-01 Thread Andrea Scarpino
> On Dec. 8, 2013, 1:08 p.m., Bhushan Shah wrote: > > plasma/generic/dataengines/mouse/mouseengine.cpp, line 34 > > > > > > You should call init() here. Have a look at > > http://community.kde.org/Plasma/PortingT

Re: Review Request 114260: Port mouse dataengine

2014-01-31 Thread Alex Merry
> On Dec. 8, 2013, 12:08 p.m., Bhushan Shah wrote: > > plasma/generic/dataengines/mouse/mouseengine.cpp, line 34 > > > > > > You should call init() here. Have a look at > > http://community.kde.org/Plasma/Porting

Re: Review Request 114260: Port mouse dataengine

2013-12-08 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114260/#review45349 --- plasma/generic/dataengines/mouse/mouseengine.cpp

Re: Review Request 114260: Port mouse dataengine

2013-12-03 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114260/#review45021 --- There is similar review request for it.. https://git.reviewboa

Review Request 114260: Port mouse dataengine

2013-12-02 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114260/ --- Review request for KDE Frameworks and Plasma. Repository: kde-workspace