Am 26/06/2024 um 14:15 schrieb Stefan Hanreich:
> The current series generates all those ipsets in the datacenter scope. My
> initial approach was to introduce an separate scope (sdn/), but I changed my
> mind during the development because that would require non-trivial changes in
> pve-firewall,
Am 23/09/2024 um 13:27 schrieb Lukas Wagner:
> pve-manager has been bumped in the meanwhile, I guess we could now merge the
> remaining patches for pve-docs and proxmox-widget-toolkit?
> They still apply cleanly and a quick test also showed that everything still
> works as expected.
thanks for the
Am 20/09/2024 um 11:05 schrieb Fabian Grünbichler:
> and put it into PVE::VZDump because there is a cycle between
>
> PVE::Jobs::VZDump, PVE::API2::VZDump and PVE::API2::Backups
>
> that prevents any of those containing it for now.
>
> Signed-off-by: Fabian Grünbichler
> ---
> PVE/API2/Backup.
Am 20/09/2024 um 08:09 schrieb Dominik Csapak:
>> For example, all VMIDs on a node. all VMIDs except the selected. VMIDs in
>> resource pools, ...
> Fair, as that would "really" fix the bug. Just for the record, I did decide
> for a 'front-end' only approach because,
>
> * less api calls/paramete
Am 19/09/2024 um 14:45 schrieb Dominik Csapak:
> On 9/19/24 14:01, Thomas Lamprecht wrote:
>> Am 19/09/2024 um 11:52 schrieb Dominik Csapak:
>>> by default libfuse2 limits writes to 4k size, which means that on writes
>>> bigger than that, we do a whole write cycle f
Am 19/09/2024 um 11:52 schrieb Dominik Csapak:
> by default libfuse2 limits writes to 4k size, which means that on writes
> bigger than that, we do a whole write cycle for each 4k block that comes
> in. To avoid that, add the option 'big_writes' to allow writes bigger
> than 4k at once.
>
> This s
Am 12/09/2024 um 14:43 schrieb Fabian Grünbichler:
> I do wonder whether we want to support the Borg and Example plugins
> though? if not, it might make sense to not ship them (but maybe just
> test them?)..
FWIW, we could move them to a separate repository named something like
"pve-storage-plugin
Hello everyone,
For a few weeks now, we have been running https://lore.proxmox.com/
See the new section in our developer docs wiki for a little bit of
additional details:
https://pve.proxmox.com/wiki/Developer_Documentation#Public_Inbox
Best regards,
Thomas
___
Am 29/07/2024 um 16:29 schrieb Fiona Ebner:
> It's not enough to check whether $! is set. From "perldoc perlvar":
>
>> Many system or library calls set "errno" if they fail, to
>> indicate the cause of failure. They usually do not set "errno"
>> to zero if they succeed and may set "errno" to a non
Am 10/09/2024 um 13:23 schrieb Daniel Kral:
> Adds a helper subroutine for enumerating storages that are enabled and
> have the content type `rootdir` set, therefore supporting container
> directories.
>
> The autocompletion is added to the clone command and changed for the
> create and move-volum
Am 31/05/2024 um 12:07 schrieb Fiona Ebner:
> As reported in the community forum [0], for tar, an exclusion pattern
> with a trailing slash will not match a folder with that name. For
> rsync and proxmox-backup-client however, such a pattern will exclude
> a directory with that name, but not a file
Am 09/09/2024 um 14:50 schrieb Filip Schauer:
> Add the deny-write options for device passthrough, to restrict container
> access to devices.
>
> Signed-off-by: Filip Schauer
> ---
> src/PVE/LXC.pm| 7 ++-
> src/PVE/LXC/Config.pm | 6 ++
> 2 files changed, 12 insertions(+), 1 del
Am 09/09/2024 um 09:52 schrieb Fiona Ebner:
> Am 09.09.24 um 09:48 schrieb Fabian Grünbichler:
>> given that I also use `apt upgrade` from time to time (habit from being an
>> unstable user ;)), and that it might alienate power users coming from
>> Debian, I'd prefer this to be a non-interactive
Am 25/07/2024 um 10:29 schrieb Maximiliano Sandoval:
> Signed-off-by: Maximiliano Sandoval
> ---
> Differences from v1:
> - Remove fixes in automatically generated files
>
> ha-manager.adoc| 2 +-
> notifications.adoc | 12 ++--
> pve-faq.adoc | 2 +-
> pve-firewall.adoc |
Am 27/08/2024 um 15:15 schrieb Dominik Csapak:
> by not using the password input at all, but pass the password
> to the connect function manually
>
> this changes the first patch instead of adding another one, since
> it only touches code from that.
>
> Signed-off-by: Dominik Csapak
> ---
> ...
Hi,
Am 26/08/2024 um 22:46 schrieb Joshua Huber:
> Say you've just kicked off a long-running "qm disk import ..." command and
> notice that an incorrect flag was specified. Ok, cancel the operation with
> control-C, fix the flag and re-execute the import command...
>
> However, when using shared
Am 27/08/2024 um 13:46 schrieb Filip Schauer:
> This commit fixes a regression introduced by
> commit ce1976b85361 ("Add device passthrough")
>
> Prior to the addition of device passthrough, the `lxc-pve-autodev-hook`
> would invoke `PVE::LXC::Tools::for_current_devices` only once. If the
> device
Am 02/09/2024 um 14:25 schrieb Fabian Grünbichler:
> else this API endpoint would only work when connected to the node where the
> container is currently running.
>
> Signed-off-by: Fabian Grünbichler
> ---
> src/PVE/API2/LXC.pm | 1 +
> 1 file changed, 1 insertion(+)
>
>
applied, thanks!
__
Am 02/09/2024 um 14:47 schrieb Maximiliano Sandoval:
> If the json was empty, for example if the qemu-img command times out, a
> message
>
> warn "could not parse qemu-img info command output for '$filename' -
> $err\n";
>
> would have been printed.
>
> This message could lead one to think
Am 05/07/2024 um 15:10 schrieb Maximiliano Sandoval:
> Adds the ability to change the owner of a guest image.
>
> Btrfs does not need special commands to rename a subvolume and this can
> be achieved the same as in Storage/plugin.pm's rename_volume taking
> special care of how the directory struct
Am 04/09/2024 um 13:12 schrieb Fiona Ebner:
> As reported in the community forum [0], when a remote migration
> request comes in via an API client, the -T flag for Perl is set, so an
> insecure dependency in a call like unlink() in forward_unix_socket()
> will fail with:
>
>> failed to write forwa
Am 06/09/2024 um 14:14 schrieb Fiona Ebner:
> Am 24.07.24 um 19:18 schrieb Filip Schauer:
>> Add the deny_read and deny_write options for device passthrough, to
>> restrict container access to devices.
>>
>> This allows for passing through a device in read-only mode without
>> giving the container
Am 06/09/2024 um 12:40 schrieb Fiona Ebner:
> Many people will use 'upgrade' instead of 'full-upgrade' or
> 'dist-upgrade' (e.g. [0][1]) despite the documentation explicitly
> mentioning 'dist-upgrade' [3]. Proxmox VE uses different packaging
> guarantees than Debian and using 'upgrade' can lead to
Am 06/09/2024 um 14:16 schrieb Alexander Zeidler:
> On Fri Sep 6, 2024 at 12:40 PM CEST, Fiona Ebner wrote:
>> (DPkg::Pre-Invoke is also too late). Since this is just an additional
>> safety warning to guide new users, it should still be good enough.
>
>> + if ($line && $line =~ m/^CommandLine::A
Am 06/09/2024 um 13:01 schrieb Dominik Csapak:
> just to mention it (i think it's not widely known):
>
> 'apt upgrade' behaves slightly different than 'apt-get upgrade'
>
> while the former also installs new packages if necessary, the latter
> doesn't, so an 'apt upgrade' will maybe work ok in mo
Am 29/08/2024 um 16:26 schrieb Daniel Kral:
> Adds a check if the target storage of a VM disk move between two
> different storages supports the content type 'images'. Without the
> check, it will move the disk image to storages which do not support VM
> images, which causes the VM to fail at start
Am 26/08/2024 um 17:11 schrieb Daniel Kral:
> Fixes a minor error in the documentation about syncing a medium, where
> the id for a medium is falsely provided with a `--id ` argument.
>
> Signed-off-by: Daniel Kral
> ---
> docs/offline-media.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deleti
Am 21/08/2024 um 15:57 schrieb Daniel Kral:
> Compatibility for an older naming convention of the "fileName" property
> of mounted storage device images in vmx configuration files was
> requested at [1].
>
> Previously, it was only possible to import ESXi VMs, where the mentioned
> property name w
Am 05/09/2024 um 11:49 schrieb Fiona Ebner:
> Commit f06b222 ("fixes for QEMU 9.0") included a revert for the QEMU
> commit 2ce6cff94d ("virtio-pci: fix use of a released vector"). That
> commit caused some regressions which sounded just as bad as the fix.
> Those regressions have now been addresse
Am 05/09/2024 um 11:44 schrieb Stoiko Ivanov:
> This patchset updates ZFS to 2.2.6, which was released last night.
> It supersedes the update to 2.2.5:
> https://lore.proxmox.com/pve-devel/20240820164512.1532793-1-s.iva...@proxmox.com/
>
> The usrmerge part of the above series will be resent indep
Am 26/07/2024 um 11:06 schrieb Fiona Ebner:
> The issue was reported in the enterprise support. The customer
> contacted the ledmon maintainer, who found that it is not an issue
> with ledmon, bisected the kernel and came up with this fix.
>
> Signed-off-by: Fiona Ebner
> ---
> ...n-Power-Indica
On 05/08/2024 12:31, Fiona Ebner wrote:
> Reported in the community forum:
> https://forum.proxmox.com/threads/145760/post-690328
>
> Signed-off-by: Fiona Ebner
> ---
> ...ix-possible-NULL-pointer-dereference.patch | 101 ++
> 1 file changed, 101 insertions(+)
> create mode 1006
Am 31/07/2024 um 14:14 schrieb Igor Thaller:
> The issue is related to the 'Summary' tab under 'Datacenter' inside a
> cluster. To get a steady reading of the storage size data, the frontend
> requests the '/api2/json/cluster/resources' every three seconds to
> retrieve the necessary data to calcul
Am 31/07/2024 um 15:40 schrieb Aaron Lauterer:
> From: Oguz Bektas
>
> now we can add nvme drives;
>
> nvme0: local-lvm:vm-103-disk-0,size=32G
>
> or
>
> qm set VMID --nvme0 local-lvm:32
>
> max number is 8 for now, as most real hardware has 1-3 nvme slots and
> can have a few more with pcie.
Am 04/07/2024 um 11:32 schrieb Fiona Ebner:
> There is a possibility that the drive-mirror job is not yet done when
> the migration wants to inactivate the source's blockdrives:
>
>> bdrv_co_write_req_prepare: Assertion `!(bs->open_flags & BDRV_O_INACTIVE)'
>> failed.
>
> This can be prevented b
Am 23/07/2024 um 14:07 schrieb Fiona Ebner:
> Currently, when completing a drive mirror job, only errors matching
> "cannot be completed" will be handled. Other errors are ignored and
> a wrong message that the job was completed successfully will be
> printed to the log. An instance of this popped
Am 30/07/2024 um 17:15 schrieb Mira Limbeck:
> Signed-off-by: Mira Limbeck
> ---
> v3:
> - fixed list continuity/indentation
> v2:
> - added metadata_services config option
> - added Sysprep section
> - fixed typos and clarified some parts
>
> qm-cloud-init.adoc | 154 +++
Am 30/07/2024 um 17:15 schrieb Mira Limbeck:
> Cloudbase-Init, a cloud-init reimplementation for Windows, supports only
> a subset of the configuration options of cloud-init. Some features
> depend on support by the Metadata Service (ConfigDrive2 here) and have
> further limitations [0].
>
> To su
Am 22/12/2023 um 11:43 schrieb Stefan Hanreich:
> Not all fields in the VnetEdit dialog are necessary for every zone
> type. This lead to confusion for some users. Hide fields in the
> VNetEdit dialog depending on which kind of zone is selected in order
> to prevent potential confusion.
>
> Signed
Am 26/06/2024 um 09:00 schrieb Christian Ebner:
> Currently, the whole mode selector is labeled as experimental, this
> does however give the impression that also the default legacy mode is
> an experimental mode.
> To clarify that only the `data` and `metadata` change detection modes
> are experim
Am 30/07/2024 um 16:27 schrieb Mira Limbeck:
> URI is used in multiple files:
> PVE/API2/Qemu.pm
> PVE/CLI/qm.pm
> PVE/QemuServer.pm
> PVE/QemuServer/Cloudinit.pm
>
> Dependencies of qemu-server already have it as dependency, but there's
> no explicit dependency in qemu-server yet.
>
> Signed-off
Am 29/07/2024 um 17:19 schrieb Mira Limbeck:
> cloudbase-init, a cloud-init reimplementation for Windows, supports only
> a subset of the configuration options of cloud-init. Some features
> depend on support by the Metadata Service (ConfigDrive2 here) and have
> further limitations [0].
>
> To su
Am 25/07/2024 um 14:32 schrieb Fiona Ebner:
> As reported in the community forum [0], after migration, the VM might
> not immediately be able to respond to QMP commands, which means the VM
> could fail to resume and stay in paused state on the target.
>
> The reason is that activating the block dr
Am 25/07/2024 um 11:45 schrieb Fiona Ebner:
> Most relevant are some fixes for VirtIO and for ARM and i386
> emulation. There also is a fix for VGA display to fix screen blanking,
> which fixes: https://bugzilla.proxmox.com/show_bug.cgi?id=4786
>
> Signed-off-by: Fiona Ebner
> ---
> ...d-support
Am 29/07/2024 um 16:29 schrieb Fiona Ebner:
> It's not enough to check whether $! is set. From "perldoc perlvar":
>
>> Many system or library calls set "errno" if they fail, to
>> indicate the cause of failure. They usually do not set "errno"
>> to zero if they succeed and may set "errno" to a non
Am 29/07/2024 um 13:43 schrieb Theodor Fumics:
> Split the "Add Virtual Machine" menu into separate options
> for Virtual Machines and Containers to reduce confusion.
> This change follows feedback from a user in [1], who had difficulty
> finding the container option.
>
> [1]
> https://forum.prox
On 24/07/2024 13:33, Dietmar Maurer wrote:
> Remove ureq, because it does not support unix sockets.
>
> Signed-off-by: Dietmar Maurer
> ---
>
> Changes sinve v2:
> split out the command line help text change into patch:
> [PATCH pve-xtermjs] termproxy: fix the command line help text
>
> Cha
On 25/07/2024 10:58, Wolfgang Bumiller wrote:
> applied, thanks
>
this was a good stop-gap but as it wasn't much work I followed this up with
fixing the implementation. As while it's just a internal tool, it's still
nicer to have it behave as all CLI tools:
https://git.proxmox.com/?p=pve-xtermjs
For the record, we talked about this in person for a bit with the following
outcome:
- there was a bit of a misunderstanding w.r.t. my heavy exaggeration for the
point's sake, I really did not mean that as accusation at all, but that's
now talked out
- it's a good point that the package that
Am 09/07/2024 um 11:10 schrieb Wolfgang Bumiller:
> Systemd reapplies its known values on reload, so we cannot simply call
> into PVE::CGroup. Call systemd's SetUnitProperties method via dbus
> instead.
>
> The hotplug and startup code also calculated different values, as one
> operated within sys
Am 23/07/2024 um 16:24 schrieb Stefan Hanreich:
> When detaching and attaching the network device on update, the
> link_down setting is not considered and the network device always gets
> attached to the guest - even if link_down is set.
>
> Fixes: 3f14f206 ("nic online bridge/vlan change: link di
Am 23/07/2024 um 16:57 schrieb Aaron Lauterer:
> There are quite a few preparation changes in other sub-crates
> (auto-installer, installer-common).
> I've only gotten through them for now and haven't looked at the actual
> post-hook crate stuff.
>
> Wouldn't it be nicer to split the preparation
Am 23/07/2024 um 13:37 schrieb Christoph Heiss:
> On Tue, Jul 23, 2024 at 01:04:06PM GMT, Aaron Lauterer wrote:
>> Instead of hacking or own pretty print, we could maybe think about using
>> https://crates.io/crates/pretty_assertions
>
> As discussed offline, I think that this is definitely the wa
Am 23/07/2024 um 09:50 schrieb Aaron Lauterer:
>
>
> On 2024-07-22 19:02, Thomas Lamprecht wrote:
>>
>> applied, thanks, one question still inline though.
>>
>>
>>> + if (defined($current_properties->{$setting}) && $value eq
>>&g
Am 08/07/2024 um 11:37 schrieb Lukas Wagner:
> This patch series attempts to improve the user experience when creating
> notification matchers.
>
> Some of the noteworthy changes:
> - Allow setting a custom backup job ID, similar how we handle it for
> sync/prune jobs in PBS (to allow recogniz
Am 08/07/2024 um 13:56 schrieb Dominik Csapak:
> With the last change in the permission check, I accidentally broke the
> check for 'spice' host value, since in the if/elsif/else this will fall
> through to the else case which was only intended for when neither 'host'
> nor 'mapping' was set.
>
>
Am 08/07/2024 um 11:38 schrieb Lukas Wagner:
> This allows us to access the backup job id in the send_notification
> function, where we can set it as metadata for the notification.
> The 'job-id' parameter can only be used by 'root@pam' to prevent
> abuse. This has the side effect that manually tri
Am 08/07/2024 um 11:38 schrieb Lukas Wagner:
> 'job-id' is passed when a backup as started as a job and will be
> passed to the notification system as matchable metadata. It
> can be considered 'internal'.
>
> Signed-off-by: Lukas Wagner
> Reviewed-by: Max Carrara
> ---
> src/PVE/VZDump/Common.
Am 09/07/2024 um 11:09 schrieb Wolfgang Bumiller:
> The function can be called with
> - neither quota nor period
> - only a period (quota will be 'max')
> - both
>
> $quota was therefore defaulted to 'max' and the check for whether
> values were provided should use $period instead of $quota.
> Als
Am 09/07/2024 um 13:49 schrieb Maximiliano Sandoval:
> Having the complete command printed out makes debuging easier.
>
> Signed-off-by: Maximiliano Sandoval
> ---
> src/PVE/Storage/BTRFSPlugin.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied, thanks!
__
Am 10/07/2024 um 13:57 schrieb Fabian Grünbichler:
> for package builds to ensure all common flags are actually set.
>
> Signed-off-by: Fabian Grünbichler
> ---
>
> Notes:
> v2: symlink wrapper config in place
>
> Makefile | 9 +++--
> debian/rules | 11 ---
> docs/Makef
Am 09/07/2024 um 13:41 schrieb Aaron Lauterer:
> By only setting propterties that have changed, we can avoid potential
> errors in the task.
>
> For example, if one configures the "nosizechange" property on a pool, to
> prevent accidential size changes, the task will now only error if the
> user i
Am 10/07/2024 um 14:42 schrieb Aaron Lauterer:
> The ID for the MDS cannot start with a number [0]. The first patch adds
> a check for this.
>
> The second patch is the actual fix, by reworking the edit window when
> adding new MDS'.
>
> By allowing the users to set the name of the MDS directly,
Am 15/07/2024 um 09:56 schrieb Christoph Heiss:
> This series adds a new answer option `global.root_password_hashed`
> for the auto-installer, enabling administrators to specify the root
> password of the new installation in a hashed format - as generated by
> e.g. mkpasswd(1) - instead of plain-te
Am 17/07/2024 um 15:06 schrieb Stefan Hanreich:
> Currently custom mappings cannot be edited, due to them having no VMID
> value. The VMID parameter was always sent by the frontend to the
> update call - even if it was empty - leading to validation failure on
> the backend. Fix this by only sending
Am 17/07/2024 um 15:06 schrieb Stefan Hanreich:
> Updating the NIC of a VM when the following conditions were met:
> * VM is turned off
> * NIC is on a bridge that uses automatic dhcp
> * Leave bridge unchanged
>
> led to duplicate IPAM entries for the same network device.
>
> This is due to the
Am 17/07/2024 um 14:49 schrieb Christoph Heiss:
> Comparing with Proxmox.Utils.render_cpu() seems just a slight oversight
> in the condition. Fix it by aligning it with how it is done in
> Proxmox.Utils.render_cpu() for consistency.
>
> Signed-off-by: Christoph Heiss
> ---
> www/manager6/Utils.j
Am 17/07/2024 um 14:16 schrieb Maximiliano Sandoval:
> Signed-off-by: Maximiliano Sandoval
> ---
> PVE/API2/Nodes.pm | 2 +-
> PVE/APLInfo.pm | 2 +-
> PVE/CLI/pveceph.pm | 2 +-
> PVE/Service/pvestatd.pm | 2 +-
>
Am 03/07/2024 um 11:17 schrieb Stefan Hanreich:
> Signed-off-by: Stefan Hanreich
> ---
> proxmox-ve-config/Cargo.toml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>
applied series with some merge conflict in the context addressed for the
second patch and updated the dependencie
Am 05/07/2023 um 16:38 schrieb Christoph Heiss:
> While working on this code, I noticed that the `firewall` argument is
> never used (nor even declared) [0] in both
> PVE::Network::{add,del}_bridge_fdb().
>
> Thus drop it everywhere and avoid needlessly passing around things which
> are never used
Am 17/07/2024 um 15:16 schrieb Stefan Hanreich:
> When disabling the nftables firewall again, there is a race condition
> where the nftables ruleset never gets flushed and persists after
> disabling.
>
> The nftables firewall update loop does a noop when the force disable
> file exists. It only fl
Am 01/07/2024 um 16:10 schrieb Max Carrara:
> Ceph Build Commit in UI - Version 2
> ===
>
> Notable Changes since v1
>
>
> * Use camelCase instead of snake_case for new functions / variables
> as per our style guide [0] (thanks Lukas!
Am 01/07/2024 um 16:10 schrieb Max Carrara:
> This commit adds `PVE.Utils.parseCephBuildCommit`, which can be used
> to get the full hash "eccf199d..." in parentheses from a string like
> the following:
>
> ceph version 17.2.7 (eccf199d63457659c09677399928203b7903c888) quincy
> (stable)
>
> Th
just chiming in on the perl dereference style
Am 22/07/2024 um 11:50 schrieb Max Carrara:
+ %$webhook_properties,
>>> Would prefer `$webhook_properties->%*` here (postfix dereferencing) -
>>> even though not explicitly stated in our style guide, we use that kind
>>> of syntax for cal
Am 18/07/2024 um 11:32 schrieb Maximiliano Sandoval:
> Signed-off-by: Maximiliano Sandoval
> ---
> es.po | 98 +++
> 1 file changed, 38 insertions(+), 60 deletions(-)
>
>
applied, thanks!
___
p
Am 17/07/2024 um 11:39 schrieb Max Carrara:
> These have been around since 2012 - suffice to say they're not needed
> anymore.
That's really not a good argument though? Just because nobody checked
those closely for a long time it does not mean that they became
magically irrelevant.
Look, it can b
Am 11/07/2024 um 13:44 schrieb Fabian Grünbichler:
> with 8.x, the scope of non-"Permissions.Modify"-based ACL update privileges
> were reduced (so that users with for example, VM.Allocate on a VM could only
> delegate their own privileges, but not arbitrary other ones). that additional
> logic had
Am 15/07/2024 um 16:31 schrieb Christoph Heiss:
> With that in mind it definitely could come in handy. Or maybe a separate
> object "disks"/"other-disks"/etc. entirely? So as not have to filter out
> the (non-)bootdisks again on the receiving end.
Could be fine too, albeit I'd slightly prefer a si
Am 16/07/2024 um 11:31 schrieb Christoph Heiss:
> Between the number of CPUs and the actual label, a space was missing -
> resulting in an inconsistency vs. the "CPU usage" column.
>
> Also, fix a rather nonsensical check for `maxcpu` above - noticed that
> while comparing the implementation to th
Am 27/06/2024 um 12:41 schrieb Gabriel Goller:
> On 26.06.2024 14:15, Stefan Hanreich wrote:
>> Since we now have a standalone repository for Proxmox VE related
>> crates, add the required files for packaging the crates contained in
>> this repository.
>
> I know we don't really do this, but could
Am 16/07/2024 um 10:18 schrieb Christoph Heiss:
> Pretty straight forward overall, implements a check for an existing
> `rpool` on the system and ask the user whether they would like to rename
> it, much in the same way as it works for VGs already.
>
> Without this, the installer would silently cr
Am 10/07/2024 um 15:27 schrieb Christoph Heiss:
> This implements a mechanism for post-installation "notifications" via a
> POST request [0] when using the auto-installer.
>
> It's implemented as a separate, small utility to facilitate separation
> of concerns and make the information gathering ea
On 10/07/2024 13:37, Fiona Ebner wrote:
> As reported in the community forum [0], there currently is a memory
> leak in the CIFS client code. Reproduced by running a backup with CIFS
> target storage:
>
>> while true; do vzdump 101 --storage cifs --prune-backups keep-last=1; echo 3
>> > /proc/sys
Am 06/06/2024 um 11:21 schrieb Dominik Csapak:
> guest-common 1-4; qemu-server 1-6; pve-manager 1,2
> are preparations/cleanups mostly and could be applied independently
Well, yes and no, they have some interdependency between themselves, so
not full independent.
It would be great if you would no
Am 06/06/2024 um 11:22 schrieb Dominik Csapak:
> tpmstate0 is already included in `get_vm_volumes`, and our only storage
> plugin that has unmap_volume implemented is the RBDPlugin, where we call
> unmap in `deactivate_volume`. So it's already ummapped by the
> `deactivate_volumes` calls above.
>
Am 06/06/2024 um 11:21 schrieb Dominik Csapak:
> but that lives int he 'global' part of the mapping config, not in a
> specific mapping. To check that, add it to the relevant hashes here.
>
> Signed-off-by: Dominik Csapak
> ---
> changes from v3:
> * leave $cfg optional
>
> src/PVE/Mapping/PCI.
Am 06/06/2024 um 11:21 schrieb Dominik Csapak:
> by placing all expected properties from the hardware into an 'expected_props'
> and those fromt he config into 'configured_props'
>
> the names makes clearer what's what, and we can easily extend it, even
> if the data does not come from the mapping
Am 06/06/2024 um 11:21 schrieb Dominik Csapak:
> to make it clearer what it actually is. Also we want to add the
> 'real' config as parameter too, and so it's less confusing.
>
> Signed-off-by: Dominik Csapak
> ---
> split out in v4
> src/PVE/Mapping/PCI.pm | 12 ++--
> 1 file changed, 6
Am 06/06/2024 um 11:21 schrieb Dominik Csapak:
> makes them a bit clearer
>
> Signed-off-by: Dominik Csapak
> ---
> split out in v4
> src/PVE/Mapping/PCI.pm | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>
applied, thanks!
___
pve-de
Am 26/04/2024 um 10:12 schrieb Fabian Grünbichler:
> 'utf-' is a typo, and can trip up some servers that do strict
> checking/matching.
>
> Signed-off-by: Fabian Grünbichler
> ---
>
> Notes:
> see
> https://forum.proxmox.com/threads/invalid-charset-on-automated-install-answer-http-fetch.145
Am 19/09/2023 um 16:10 schrieb Alexandre Derumier:
> Requested by a customer using setup with single vxlan devices.
> ---
> debian/patches/series | 3 ++-
> .../upstream/0001-vxlan-fix-vni-filter.patch | 27 +++
> 2 files changed, 29 insertions(+), 1 delet
Am 04/07/2024 um 14:11 schrieb Fiona Ebner:
> Yes, next time we introduce an apiinfo call, we can just have it fail
> hard upon errors.
Oh, and just to avoid potential future error potential here:
For a new topic-specific API version call that might not work, as the fallback
and (lacking) error ha
Am 04/07/2024 um 14:11 schrieb Fiona Ebner:
> There is no apiinfo call required anymore. No code is the cleanest kind
Yeah, by the assumption you self choose to use and that I question, so
not really a useful argument.
In practice, users can upgrade a from one major release to the next one,
nothi
either way)
Looks OK to me otherwise.
> Signed-off-by: Dominik Csapak
With commit meta stuff addressed consider this:
Reviewed-by: Thomas Lamprecht
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Am 04/07/2024 um 12:28 schrieb Fiona Ebner:
> Am 04.07.24 um 11:52 schrieb Thomas Lamprecht:
>> Am 10/06/2024 um 11:04 schrieb Fiona Ebner:
>>> The storage API version has been bumped to at least 9 since
>>> libpve-storage = 7.0-4. If the source node is on Proxmox VE 8,
Am 06/06/2024 um 11:22 schrieb Dominik Csapak:
> this was the only user, and it's easy enough
>
> Signed-off-by: Dominik Csapak
> ---
> no changes
> PVE/QemuServer/USB.pm | 5 -
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/PVE/QemuServer/USB.pm b/PVE/QemuServer/USB.pm
>
CC'ing pve-devel again.
Am 04/07/2024 um 11:42 schrieb Maximiliano Sandoval:
> Thomas Lamprecht writes:
>> Am 03/07/2024 um 14:41 schrieb Maximiliano Sandoval:
>>> Adds the ability to change the owner of a guest image.
>>>
>>> Btrfs does not need specia
Am 10/06/2024 um 11:04 schrieb Fiona Ebner:
> The storage API version has been bumped to at least 9 since
> libpve-storage = 7.0-4. If the source node is on Proxmox VE 8, where
> this change will come in, then the target node can be assumed to be
> running either Proxmox VE 8 or, during upgrade, th
Am 03/07/2024 um 14:41 schrieb Maximiliano Sandoval:
> Adds the ability to change the owner of a guest image.
>
> Btrfs does not need special commands to rename a subvolume and this can
> be achieved the same as in Storage/plugin.pm's rename_volume taking
> special care of how the directory struct
Am 03/07/2024 um 14:56 schrieb Stefan Hanreich:
> This can lead to issue when upgrading from ifupdown to ifupdown2. The
> particular issue this fixes occurs in the following scenario:
>
> * Suppose there is a legacy Debian host with ifupdown and ifenslave
> installed that has a bond configured i
1 - 100 of 1178 matches
Mail list logo
