New submission from Gregory P. Smith :
On POSIX platforms that support the fdwalk() API, use it within the
os.closerange() implementation.
--
components: Demos and Tools
messages: 351875
nosy: gregory.p.smith
priority: normal
severity: normal
stage: patch review
status: open
title
Gregory P. Smith added the comment:
New changeset c37447481ec8f6d0e49d0587ec0de3f9e7d56b28 by Gregory P. Smith in
branch 'master':
bpo-28494: install ziptestdata to fix install bot (GH-15902)
https://github.com/python/cpython/commit/c37447481ec8f6d0e49d0587ec0de3
Gregory P. Smith added the comment:
New changeset 7a0023e8d17566eb32c836b65c33663303a2224f by Gregory P. Smith
(smokephil) in branch 'master':
bpo-25810: Clarify eval() docs, it does not keywords (GH-15173)
https://github.com/python/cpython/commit/7a0023e8d17566eb32c836b65c3366
Change by Gregory P. Smith :
--
pull_requests: +15543
pull_request: https://github.com/python/cpython/pull/15902
___
Python tracker
<https://bugs.python.org/issue28
Gregory P. Smith added the comment:
For some context here, the pathlib scandir code was written by Serhiy in
https://bugs.python.org/issue26032 and related commit
https://github.com/python/cpython/commit/680cb152c5d220a74321fa905d4fc91bdec40fbb.
> Any optimization can be accepted only w
Gregory P. Smith added the comment:
The new ziptestdata/ subdir appears to not be part of the install that make
install does. :/
--
___
Python tracker
<https://bugs.python.org/issue28
Gregory P. Smith added the comment:
Shai, please open the 'Your Details' link in the bugs.python.org sidebar and
make sure you have your github username filled in. it needs to say ShaiAvr for
our CLA automation to understand.
Avoiding calling list() on the output of scandir()
New submission from Gregory P. Smith :
https://github.com/python/cpython/pull/15274
--
assignee: gregory.p.smith
messages: 351700
nosy: gregory.p.smith
priority: normal
severity: normal
status: open
title: unneeded assignment to wb.len in PyBytes_Concat using buffer protocol
versions
Change by Gregory P. Smith :
--
versions: +Python 3.9
___
Python tracker
<https://bugs.python.org/issue38047>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Gregory P. Smith :
--
pull_requests: +15502
pull_request: https://github.com/python/cpython/pull/15853
___
Python tracker
<https://bugs.python.org/issue28
Change by Gregory P. Smith :
--
nosy: +benjamin.peterson
___
Python tracker
<https://bugs.python.org/issue1652>
___
___
Python-bugs-list mailing list
Unsub
Gregory P. Smith added the comment:
I believe this has been addressed.
--
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/i
Change by Gregory P. Smith :
--
versions: +Python 3.8 -Python 3.4
___
Python tracker
<https://bugs.python.org/issue13788>
___
___
Python-bugs-list mailin
Gregory P. Smith added the comment:
oh well, no pony for us this decade. :)
--
___
Python tracker
<https://bugs.python.org/issue37055>
___
___
Python-bugs-list m
Gregory P. Smith added the comment:
META: Do we still have platforms we support that we do not also require a
modern enough OpenSSL version in order for CPython to build that'd provide
blake2 for us?
I'd love to ditch maintenance of our own copies of the various secure hash
Gregory P. Smith added the comment:
FWIW, _posixsubprocess.fork_exec() should be safe to allow.
The only thing within it to disallow, if you're going to bother to check this
at all, is any use of the legacy preexec_fn support.
--
nosy: +gregory.p.
Gregory P. Smith added the comment:
The signal handler in this case is CPython's internal signal handling system
thus any such onus falls on us...
The great signal handling hack of "set a flag that the interpreter loop checks
on occasion" trick lasted a long time, but o
Change by Gregory P. Smith :
--
versions: +Python 3.9 -Python 3.7
___
Python tracker
<https://bugs.python.org/issue29988>
___
___
Python-bugs-list mailin
Change by Gregory P. Smith :
--
versions: +Python 3.9 -Python 3.8
___
Python tracker
<https://bugs.python.org/issue32949>
___
___
Python-bugs-list mailin
New submission from Gregory P. Smith :
21 tests failed:
test_asynchat test_asyncore test_docxmlrpc test_eintr test_epoll
test_ftplib test_httplib test_imaplib
test_multiprocessing_forkserver test_multiprocessing_spawn
test_nntplib test_os test_poplib test_robotparser
New submission from Gregory P. Smith :
test_404 (test.test_xmlrpc.SimpleServerTestCase) ... Exception in thread
Thread-1:
Traceback (most recent call last):
File "/home/greg/oss/cpython/Lib/threading.py", line 938, in _bootstrap_inner
self.run()
File "/home/greg/
New submission from Gregory P. Smith :
test_err (test.test_httpservers.RequestHandlerLoggingTestCase) ... Exception in
thread Thread-1:
Traceback (most recent call last):
File "/home/greg/oss/cpython/Lib/threading.py", line 938, in _bootstrap_inner
self.run()
File "
New submission from Gregory P. Smith :
test_drain_raises (test.test_asyncio.test_streams.StreamTests) ... Exception in
thread Thread-20:
Traceback (most recent call last):
File "/home/greg/oss/cpython/Lib/threading.py", line 938, in _bootstrap_inner
self.run()
File "
New submission from Gregory P. Smith :
It winds up stuck on a leftover process:
test_import (test.test_multiprocessing_fork._TestImportStar) ... ok
Warning -- Dangling processes: {}
Which is likely related to one of the other numerous failure ERRORs further up
in the log.
I'm prepari
New submission from Gregory P. Smith :
test_logging hangs when run on an IPv6-only host. (127.0.0.1 isn't even
available)
test_listen_config_10_ok (test.test_logging.ConfigDictTest) ... Exception in
thread Thread-3:
Traceback (most recent call last):
File "/home/greg/oss/c
Gregory P. Smith added the comment:
I'm not a fan of CVE numbers in general, people have been creating too many of
those. But that also means I just don't care if someone does. Having a CVE
entry is not a way to claim something is important.
This issue is still open and can
Gregory P. Smith added the comment:
Nope, work remains to be done. I've got an msan buildbot system waiting but
haven't had time to follow up on figuring out what remains in a while.
(getting a functioning memory sanitizer build is... finnicky to say
Gregory P. Smith added the comment:
I haven't looked, so not that i'm aware of. I suggest filing one for each of
those.
The warning not pointing to the right line in a multiline literal sounds like a
bug to me so that one, if fixed, seems reasonable for 3.8. The release manage
Gregory P. Smith added the comment:
I'm leaving this open, as we may still want to do it in 3.9+, just in a less
disruptive manner. (That, and how, hasn't been decided yet)
Follow the thread(s) on python-dev for the latest on that.
--
resolution: fixed ->
st
Change by Gregory P. Smith :
--
pull_requests: +14927
pull_request: https://github.com/python/cpython/pull/15195
___
Python tracker
<https://bugs.python.org/issue32
Gregory P. Smith added the comment:
New changeset 4c5b6bac2408f879231c7cd38d67657dd4804e7c by Gregory P. Smith
(Serhiy Storchaka) in branch '3.8':
[3.8] bpo-32912: Revert SyntaxWarning on invalid escape sequences (GH-15142)
https://github.com/python/cpyt
Gregory P. Smith added the comment:
Can the pyc compilation step done by our normal package installers be made to
treat this warning as an error so that it is forced into the package owners
faces instead of overlooked because it was just something on stderr?
This syntax warning is
Gregory P. Smith added the comment:
os.fork() cannot be safely used in an application that uses threads in any
manner. This is not something Python can fix. This is a POSIX limitation.
The "sh" module on PyPI is incompatible with threaded applications on POSIX
platforms due to
Gregory P. Smith added the comment:
i doubt test_lzma test_bz2 and test_sqlite matter. What matters there is
compiling the underlying lzma, bz2, and sqlite3 libraries with PGO. that isn't
done as part of our build system.
regardless, those tests are fast enough so i've approved
Gregory P. Smith added the comment:
New changeset e95ac20103437d8099fb91cd4468ab030852f3b7 by Gregory P. Smith in
branch 'master':
bpo-37667: Add regression test for regrtest. (GH-14929)
https://github.com/python/cpython/commit/e95ac20103437d8099fb91cd4468ab
Gregory P. Smith added the comment:
A regression test for this type of situation is in the works in the open PR.
--
stage: patch review -> commit review
status: open -> closed
versions: +Python 3.9
___
Python tracker
<https://bugs.p
Change by Gregory P. Smith :
--
pull_requests: +14700
stage: commit review -> patch review
pull_request: https://github.com/python/cpython/pull/14929
___
Python tracker
<https://bugs.python.org/issu
Gregory P. Smith added the comment:
fixed, but not marking closed until the 3.8 automerge happens.
--
resolution: -> fixed
stage: patch review -> commit review
versions: -Python 3.9
___
Python tracker
<https://bugs.python.org/i
Change by Gregory P. Smith :
--
keywords: +patch
pull_requests: +14698
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/14927
___
Python tracker
<https://bugs.python.org/issu
Change by Gregory P. Smith :
--
assignee: -> gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue37667>
___
___
Python-bugs-list mailing list
Un
Gregory P. Smith added the comment:
tracking that as a release blocker in https://bugs.python.org/issue37667
--
___
Python tracker
<https://bugs.python.org/issue36
New submission from Gregory P. Smith :
After the PR for https://bugs.python.org/issue36044 when in, see the comment in
the issue.
test.regrtest is now only running 40 tests.
that means all of our CI is failing to run most of the test suites.
--
components: Tests
messages: 348365
Gregory P. Smith added the comment:
Probably nevermind on implementing this:
ssl_context = ssl.create_default_context(cadata=...)
urllib.request.urlopen(..., context=ssl_context)
Works fine. It might be worth a note in the urlopen() docs if anything
New submission from Gregory P. Smith :
The underlying
https://docs.python.org/3/library/ssl.html#ssl.SSLContext.load_verify_locations
API supports cafile, capath and cadata.
urlopen() only offers up cafile and capath. It should also support cadata for
completeness.
This matters for
Gregory P. Smith added the comment:
While test hangs shouldn't happen, I recommend working around such odd
situations you are finding on your system by supplying your own modified
PROFILE_TASK setting at make time that avoids whatever test(s) are causing you
problems. The link
Gregory P. Smith added the comment:
As far as where to put the lists of tests, you're probably right. putting it
within test.regrtest itself under the --pgo banner makes sense. (though we
should keep logic to accept a list of explicit tests to add or exclude if the
user has also pro
Gregory P. Smith added the comment:
yeah I pulled a similar looking list of tests for the PROFILE_TASK to suggest
to the Docker Python image maintainers - see
https://github.com/docker-library/python/pull/404 and
https://github.com/docker-library/python/issues/160.
I haven'
Gregory P. Smith added the comment:
I suggest:
(1) turning one of the patches (probably the last BFS one?) into a PR against
the github master branch (3.9) and,
(2) if none of the existing pyperformance workloads already demonstrates the
problems with the existing GIL implementation, adopt
Gregory P. Smith added the comment:
(unassigning as it doesn't make sense to assign to anyone unless they're
actually working on it)
--
assignee: pitrou ->
___
Python tracker
<https://bugs.pyth
Change by Gregory P. Smith :
--
priority: low -> normal
versions: +Python 3.9 -Python 3.3
___
Python tracker
<https://bugs.python.org/issue7946>
___
___
Py
Gregory P. Smith added the comment:
In my experience, people overthink what needs to go into a CPython profiling
run. Sure, our default PROFILE_TASK is rather unfortunate because it takes a
very long time by including runs of super slow tests that won't meaningfully
contribute profile
Change by Gregory P. Smith :
--
assignee: -> gregory.p.smith
resolution: duplicate ->
status: closed -> open
___
Python tracker
<https://bugs.python.or
Change by Gregory P. Smith :
--
stage: resolved ->
___
Python tracker
<https://bugs.python.org/issue37424>
___
___
Python-bugs-list mailing list
Unsubscrib
Gregory P. Smith added the comment:
Issue 30154 that I've marked as a duplicate demonstrates this problem without
using shell=True. The solution I proposed handles that via the additional
small timeout on the cleanup side, but still has the caveat that the grandchild
processes keep ru
Change by Gregory P. Smith :
--
resolution: -> duplicate
stage: -> resolved
status: open -> closed
superseder: -> subprocess.run timeout does not function if shell=True and
capture_output=True
___
Python tracker
<https://
Change by Gregory P. Smith :
--
resolution: -> duplicate
stage: patch review -> resolved
status: open -> closed
superseder: -> subprocess.run timeout does not function if shell=True and
capture_output=True
___
Python tra
Gregory P. Smith added the comment:
this is part of a chain of other related issues. the interesting thing in the
patch in here is the potential feature to have send_signal/terminate/kill be
able to optionally kill a process group.
the logic as is in the patch in this issue is dangerous as
Change by Gregory P. Smith :
--
resolution: -> duplicate
superseder: -> subprocess.run timeout does not function if shell=True and
capture_output=True
___
Python tracker
<https://bugs.python.org/
Change by Gregory P. Smith :
--
pull_requests: +14307
pull_request: https://github.com/python/cpython/pull/14490
___
Python tracker
<https://bugs.python.org/issue37
Change by Gregory P. Smith :
--
pull_requests: -7893
___
Python tracker
<https://bugs.python.org/issue5115>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
New changeset 5cbbbd73a6acb6f96f5d6646aa7498d3dfb1706d by Gregory P. Smith
(Ammar Askar) in branch 'master':
bpo-29505: Add more fuzzing for re.compile, re.load and csv.reader (GH-14255)
https://github.com/python/cpyt
Change by Gregory P. Smith :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Gregory P. Smith added the comment:
New changeset eb97b9211e7c99841d6cae8c63893b3525d5a401 by Gregory P. Smith
(tmblweed) in branch 'master':
bpo-30754: Document textwrap.dedent blank line behavior. (GH-14469)
https://github.com/python/cpython/commit/eb97b9211e7c99841d6cae8c63893b
Gregory P. Smith added the comment:
possibly related to https://bugs.python.org/issue32696 and
https://bugs.python.org/issue1692335.
--
nosy: +gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue37
Gregory P. Smith added the comment:
New changeset a6e190e94b47324f14e22a09200c68b722d55699 by Gregory P. Smith
(Ammar Askar) in branch 'master':
bpo-29505: Fuzz json module, enforce size limit on int(x) fuzz (GH-13991)
https://github.com/python/cpyt
Gregory P. Smith added the comment:
This is just adding a missing constant (when defined at CPython compile time)
to the os module. I suggest landing this in 3.8 as well assuming we're still
in the beta cycles when the PR is ready. It isn't a functional change.
-
Gregory P. Smith added the comment:
oh that is likely it, the stacktrace i got in a pydebug build was a gc time
refcount != 0 assertion.
--
superseder: -> Refcounting mistake in _ssl.c
___
Python tracker
<https://bugs.python.org/issu
Gregory P. Smith added the comment:
FWIW, I could reproduce this on early 3.5 versions but it appears to have been
fixed between 3.5.3 and 3.5.4.
I'm leaving this open in case anyone can tie it back to a particular change.
--
components: +Extension Modules -ctypes
Gregory P. Smith added the comment:
"needs patch" doesn't mean it has been accepted, it's just a common state for
issues where nobody has written any code even as a proof of concept.
Christian - is this still desired?
--
no
Gregory P. Smith added the comment:
thanks!
--
assignee: -> gregory.p.smith
resolution: -> fixed
stage: patch review -> commit review
status: open -> closed
versions: +Python 3.8, Python 3.9
___
Python tracker
<https://bugs.python
Change by Gregory P. Smith :
--
nosy: -gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue34850>
___
___
Python-bugs-list mailing list
Unsub
Gregory P. Smith added the comment:
(message from a code of conduct violating troll deleted)
--
___
Python tracker
<https://bugs.python.org/issue34850>
___
___
Change by Gregory P. Smith :
--
Removed message: https://bugs.python.org/msg345086
___
Python tracker
<https://bugs.python.org/issue34850>
___
___
Python-bug
Gregory P. Smith added the comment:
even with that initially proposed patch, the subprocess.run code is going to
hang if the .kill() fails without raising an exception:
The run() TimeoutExpired path calls communicate() after the kill to consume all
remaining output:
https://github.com
Gregory P. Smith added the comment:
New changeset 8cc605acdda5aff250ab4c9b524a7560f90ca9f3 by Gregory P. Smith
(RĂ©mi Lapeyre) in branch 'master':
bpo-34886: Fix subprocess.run handling of exclusive arguments (GH-11727)
https://github.com/python/cpyt
Gregory P. Smith added the comment:
New changeset a15a7bcaea54e1845ab2abe27e6f583294cd715b by Gregory P. Smith
(Ammar Askar) in branch 'master':
bpo-29505: Fix interpreter in fuzzing targets to be relocatable (GH-13907)
https://github.com/python/cpyt
Gregory P. Smith added the comment:
Thanks Jeroen!
--
resolution: -> fixed
stage: patch review -> commit review
status: open -> closed
___
Python tracker
<https://bugs.python.or
Gregory P. Smith added the comment:
In PR it you refer to -ledit and to editline. libedit and libeditline appear
to be two different libraries.
I was under the impression that libedit is the desirable one (it's what *BSD
uses - coming originally from NetBSD if I understand corr
Change by Gregory P. Smith :
--
nosy: +gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue13501>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
New changeset 1f9531764cc0f8dbca1d8f429d162dc28282f4b4 by Gregory P. Smith
(Jeroen Demeyer) in branch 'master':
bpo-37138: fix undefined behaviour with memcpy() on NULL array (GH-13867)
https://github.com/python/cpyt
Change by Gregory P. Smith :
--
nosy: -gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue37134>
___
___
Python-bugs-list mailing list
Unsub
Gregory P. Smith added the comment:
I agree with Brett and Carol here. This is part of the language syntax. We
can educate people to that effect more if desired (I like the blog post idea).
People will figure it out.
We've already got high ranked stackoverflow answers related to
New submission from Gregory P. Smith :
The undefined behavior sanitizer buildbot is flagging a bunch of issues in
master (3.8) of late:
AssertionError: 'Objects/classobject.c:74:29: runtime erro[139 chars]re\n' != ''
- Objects/classobject.c:74:29: runtime error: nu
Gregory P. Smith added the comment:
New changeset 8766cb74e186d3820db0a855ccd780d6d84461f7 by Gregory P. Smith
(Inada Naoki) in branch '3.7':
[3.7] bpo-27987: align PyGC_Head to alignof(long double) (GH-13335) (GH-13581)
https://github.com/python/cpyt
Gregory P. Smith added the comment:
I spent a while looking at this and what it'd take to wind up with a
TestCase.maxReprLength style implementation to limit the length of unittest
assertion failure reprs. I don't see a nice path forward via safe_repr as is
(as the PR started with
Change by Gregory P. Smith :
--
assignee: gregory.p.smith ->
stage: patch review -> needs patch
___
Python tracker
<https://bugs.python.org/issue27432>
___
__
Gregory P. Smith added the comment:
Clarifying: The problem is that the TimeoutExpired exception that is desired
was replaced with a PermissionError that the caller isn't expecting to catch
and handle.
--
___
Python tracker
&
Change by Gregory P. Smith :
--
versions: +Python 3.8
___
Python tracker
<https://bugs.python.org/issue37091>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Gregory P. Smith :
--
assignee: -> gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue37091>
___
___
Python-bugs-list mailing list
Un
Gregory P. Smith added the comment:
I think dedenting docstring content by default would be a great thing to do.
But that's a separate issue, it isn't quite the same as .dedent() due to the
first line. I filed https://bugs.python.org/issue37102 to
New submission from Gregory P. Smith :
I'm spawning this issue of as a separate feature from
https://bugs.python.org/issue36906 (adding string dedent method and an
optimization to do it at compile timer on constants).
It'd be great if docstrings were given a similar treatment. Ri
Gregory P. Smith added the comment:
The current behavior is desired. We just need to document it better in
https://docs.python.org/3/library/textwrap.html#textwrap.dedent
--
assignee: -> docs@python
components: +Documentation -Library (Lib)
keywords: +easy
nosy: +docs@pyt
Gregory P. Smith added the comment:
thanks, i'll take care of them.
--
___
Python tracker
<https://bugs.python.org/issue22385>
___
___
Python-bugs-list m
Gregory P. Smith added the comment:
New changeset 0c2f9305640f7655ba0cd5f478948b2763b376b3 by Gregory P. Smith in
branch 'master':
bpo-22385: Support output separators in hex methods. (#13578)
https://github.com/python/cpython/commit/0c2f9305640f7655ba0cd5f478948b
Gregory P. Smith added the comment:
Documentation of the issue for sure!
A RuntimeWarning is a maybe if it can be made conditional on the OS version
(10.13 and higher?)... when the "fork" method would be used. BUT be very
cautious about warnings as they tend to crop up in fron
Gregory P. Smith added the comment:
FWIW I am in favor of "spawn" being the default on _all_ platforms in 3.8. The
safest option being the default just seems like the right thing to do.
--
___
Python tracker
<https://bugs.python.o
Gregory P. Smith added the comment:
There is a multiprocessing spawn method on Python 2.7. And we should never do
such a crazy huge feature backport.
IMNSHO - We should not change the default in 3.7 either. That is a notable
behavior change. That decision is entirely up to Ned (RM). If
Gregory P. Smith added the comment:
Given that we have f-strings, I don't think a format mini language makes as
much sense. My PR adds support for separators to the .hex() methods (and to
binascii.hexlify) via a parameter. Extending beyond what MicroPython already
does in its bin
Change by Gregory P. Smith :
--
keywords: +patch
pull_requests: +13486
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/13578
___
Python tracker
<https://bugs.python.org/issu
Change by Gregory P. Smith :
--
versions: -Python 2.7, Python 3.8, Python 3.9
___
Python tracker
<https://bugs.python.org/issue27987>
___
___
Python-bugs-list m
901 - 1000 of 3274 matches
Mail list logo