[issue24347] unchecked return value in C OrderedDict

Changes by Eric Snow : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___ Pyth

[issue24347] unchecked return value in C OrderedDict

Roundup Robot added the comment: New changeset 1a7c34e23ec9 by Eric Snow in branch '3.5': Issue #24347: Set KeyError if PyDict_GetItemWithError returns NULL. https://hg.python.org/cpython/rev/1a7c34e23ec9 -- nosy: +python-dev ___ Python tracker

[issue24347] unchecked return value in C OrderedDict

Eric Snow added the comment: Using PyDict_GetItemWithError() is a good idea. Also, raising KeyError when the value is NULL (and no errors set) eliminates the crash. Here's a patch that fixes the problem. Unless there are any objections, I'll commit it in a couple hours. -- stage: t

[issue24347] unchecked return value in C OrderedDict

Changes by Arfrever Frehtes Taifersar Arahesis : -- nosy: +Arfrever ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue24347] unchecked return value in C OrderedDict

Eric Snow added the comment: Regarding the macros, my intent was to limit leaking the details of the linked list implementation and make it easier to change the linked list implementation later. However, if that results in problems then I'm open to changing it. What would you recommend? ---

[issue24347] unchecked return value in C OrderedDict

Changes by Yury Selivanov : -- nosy: +yselivanov ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue24347] unchecked return value in C OrderedDict

New submission from Eric Snow: (from msg244574 in issue16991) crash-1.py is due to an unchecked return value from _odictnode_VALUE(). We should probably use PyDict_GetItemWithError(), also in other places. I normally try to steer clear of stylistic remarks, but the _odictnode* macros are hidin