[issue26076] redundant checks in tok_get in Parser\tokenizer.c

Roundup Robot added the comment: New changeset f0acce8022d1 by Benjamin Peterson in branch 'default': remove duplicated check for fractions and complex numbers (closes #26076) https://hg.python.org/cpython/rev/f0acce8022d1 -- nosy: +python-dev resolution: -> fixed stage: patch review ->

[issue26076] redundant checks in tok_get in Parser\tokenizer.c

Martin Panter added the comment: The change looks pretty good to me. I guess some test cases could be added to Lib/test/test_grammar.py, unless there is somewhere else that already tests this sort of stuff. -- nosy: +martin.panter ___ Python tracker

[issue26076] redundant checks in tok_get in Parser\tokenizer.c

SilentGhost added the comment: Could any one of the core developers have a look? Seems like a rather straightforward change. -- ___ Python tracker ___ __

[issue26076] redundant checks in tok_get in Parser\tokenizer.c

Stéphane Wirtel added the comment: Thank you for your patch, it's easier for the review. -- ___ Python tracker ___ ___ Python-bugs-lis

[issue26076] redundant checks in tok_get in Parser\tokenizer.c

Changes by Stéphane Wirtel : -- nosy: +serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:/

[issue26076] redundant checks in tok_get in Parser\tokenizer.c

Changes by SilentGhost : -- versions: -Python 2.7, Python 3.2, Python 3.3, Python 3.4, Python 3.5 ___ Python tracker ___ ___ Python-b

[issue26076] redundant checks in tok_get in Parser\tokenizer.c

Oren Milman added the comment: Sorry for being so clueless. The diff is attached. I manually did some checks to verify that relevant stuff work correctly (the imaginary number 0j, and fractions starting with '0.'). I run 'python -m test', and got the following output: 352 tests OK. 1 test alter

[issue26076] redundant checks in tok_get in Parser\tokenizer.c

Stéphane Wirtel added the comment: Totally agree with you, 1. Create a patch 2. Remove the commented lines in the patch -- ___ Python tracker ___ __

[issue26076] redundant checks in tok_get in Parser\tokenizer.c

SilentGhost added the comment: The patch indeed would be more useful, though I'd suggest to actually delete the lines you think should be deleted, rather than just leave the commented out. -- nosy: +SilentGhost ___ Python tracker

[issue26076] redundant checks in tok_get in Parser\tokenizer.c

Stéphane Wirtel added the comment: Hi SilentGhost and Oren, There is a problem with this patch. This is not a patch, but the complete file. 1. Could you provide a real patch, with the real diff. Use hg diff > /tmp/issue26076.diff 2. Please, could you provide a small test to be sure that every

[issue26076] redundant checks in tok_get in Parser\tokenizer.c

Changes by SilentGhost : -- keywords: +patch nosy: +benjamin.peterson stage: -> patch review versions: -Python 2.7, Python 3.2, Python 3.3, Python 3.4, Python 3.5 ___ Python tracker __

[issue26076] redundant checks in tok_get in Parser\tokenizer.c

New submission from Oren Milman: In Parser\tokenizer.c, in tok_get, in the identification of a potential NUMBER token, in case the token starts with a '0', the next char of the token is retrieved, followed by two redundant checks: if (c == '.') goto fraction; if (c == 'j' || c == 'J') g