[issue34240] Convert test_mmap to use tempfile

Tim Golden added the comment: Closing as no longer reproducible in the current codebase on my current laptop -- resolution: -> not a bug stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue34240] Convert test_mmap to use tempfile

TJG added the comment: That last should clearly have said: Thanks for doing the housekeeping work here :) -- ___ Python tracker ___

[issue34240] Convert test_mmap to use tempfile

TJG added the comment: Thanks, Cheryl. It was getting pretty stale. If I think it's worthwhile I'll resurrect it. I suspect what happened was that my cpython fork got borked somehow between then and now. I probably ditched the repo and re-forked. That's for doing the housekeeping work

[issue34240] Convert test_mmap to use tempfile

Cheryl Sabella added the comment: @tim.golden, I closed this pull request as it was from an unknown repository and new pull request would need to be created with the changes in order to move it forward. -- nosy: +cheryl.sabella ___ Python tracker

[issue34240] Convert test_mmap to use tempfile

Tim Golden added the comment: Thanks for the information, eryksun. For the moment, I can only say with a fair degree of certainty that using the tempfile functions as I have in test_bz2 & test_mmap appears to solve the issue which is repeatably if intermittently present without that change.

[issue34240] Convert test_mmap to use tempfile

Eryk Sun added the comment: To clarify, TEMPDIR in this case is from the following code in Lib/test/libregrtest/main.py: # When tests are run from the Python build directory, it is best practice # to keep the test files in a subfolder. This eases the cleanup of leftover # files

[issue34240] Convert test_mmap to use tempfile

Eryk Sun added the comment: > tests are competing with each other to delete and recreate the file When is this an issue? Each parallel test process should have its own working directory under "{TEMPDIR}/test_python_{pid}". -- nosy: +eryksun ___

[issue34240] Convert test_mmap to use tempfile

Change by Tim Golden : -- keywords: +patch pull_requests: +8008 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list

[issue34240] Convert test_mmap to use tempfile

New submission from Tim Golden : test_mmap currently uses the test.support.TESTFN functionality which creates a temporary file local to the test directory named around the pid. This can give rise to race conditions where tests are competing with each other to delete and recreate the file.