Re: [python-committers] Promote Xiang Zhang as a core developer

2016-11-18 Thread Victor Stinner
2016-11-15 16:46 GMT+01:00 Senthil Kumaran : >> Maybe Xiang needs a longer mentoring period than 1 month, but I want >> to keep him motivated. Active contributors (even inside core >> developers) are rare, so we always need fresh blood :-) > > I agree with this statement. I did a review of his cont

Re: [python-committers] Promote Xiang Zhang as a core developer

2016-11-18 Thread Victor Stinner
2016-11-15 19:32 GMT+01:00 : > Since the first commit 8 months ago I counted about 50 Xiang's committed > patches, and most of them were committed by me (other 10 core developers > committed form 1 to 4 Xiang's patches). He helped with reviewing patches and > discussing issues. His C skills was g

Re: [python-committers] Promote Xiang Zhang as a core developer

2016-11-18 Thread Serhiy Storchaka
2016-11-18 18:16 GMT+02:00 Victor Stinner : > Berker, Serhiy: Do you prefer that I mentor Xiang first during one > month, then give him the commit bit, but continue to mentor him? Or > are you ok to give him the commit bit right now, and as I wrote, > request him to ask me before pushing anything?

Re: [python-committers] Promote Xiang Zhang as a core developer

2016-11-18 Thread Berker Peksağ
On Tue, Nov 15, 2016 at 11:17 AM, Victor Stinner wrote: > Hi, > > 2016-11-15 1:10 GMT+01:00 Berker Peksağ : >> Xiang tends to fix things that are not broken, > > This sentence sounds strange. What do you mean? :-) > >> (...) and when you point out that the thing they are >> trying to fix is not b

Re: [python-committers] Promote Xiang Zhang as a core developer

2016-11-18 Thread Nick Coghlan
On 19 November 2016 at 13:07, Berker Peksağ wrote: > I agree that we should look for people who wrote high quality patches, > but I think we also should look for people who help other members of > the community by doing *boring* tasks (e.g. review patches submitted > by other contributors, triage