Re: [Python-Dev] Using more specific methods in Python unit tests

2014-02-16 Thread Jeff Allen
On 16/02/2014 00:22, Nick Coghlan wrote: On 16 February 2014 09:20, Ned Deily n...@acm.org wrote: In article 1392492250.26338.83831085.39a5e...@webmail.messagingengine.com, Benjamin Peterson benja...@python.org wrote: On Sat, Feb 15, 2014, at 10:12 AM, Serhiy Storchaka wrote: Although

Re: [Python-Dev] Using more specific methods in Python unit tests

2014-02-16 Thread Antoine Pitrou
On Sat, 15 Feb 2014 20:12:33 +0200 Serhiy Storchaka storch...@gmail.com wrote: I wrote a large patch which modifies the tests to use more specific methods [1]. Because it is too large, it was divided into many smaller patches, and separate issues were opened for them. At the moment the

Re: [Python-Dev] Using more specific methods in Python unit tests

2014-02-16 Thread Mark Dickinson
On Sun, Feb 16, 2014 at 12:22 AM, Nick Coghlan ncogh...@gmail.com wrote: The practical benefits of this kind of change in the test suite are also highly dubious, because they *only help if the test fails at some point in the future*. At that point, whoever caused the test to fail will switch

Re: [Python-Dev] Using more specific methods in Python unit tests

2014-02-16 Thread Stefan Behnel
Jeff Allen, 16.02.2014 11:23: I spend a *lot* of time working with the Python test suite on behalf of Jython, so I appreciate the care CPython puts into its testing. To a large extent, tests written for CPython drive Jython development: I suspect I work with a lot more failing tests than

[Python-Dev] Using more specific methods in Python unit tests

2014-02-15 Thread Serhiy Storchaka
Many Python tests were written a very long time before the unittest, using simple asserts. Then, when they have been ported to the unittest, asserts were replaced with the assert_ method and then with assertTrue. The unittest has a number of other methods to check for and report failure, from

Re: [Python-Dev] Using more specific methods in Python unit tests

2014-02-15 Thread Benjamin Peterson
On Sat, Feb 15, 2014, at 10:12 AM, Serhiy Storchaka wrote: Many Python tests were written a very long time before the unittest, using simple asserts. Then, when they have been ported to the unittest, asserts were replaced with the assert_ method and then with assertTrue. The unittest has a

Re: [Python-Dev] Using more specific methods in Python unit tests

2014-02-15 Thread Terry Reedy
On 2/15/2014 1:12 PM, Serhiy Storchaka wrote: Many Python tests were written a very long time before the unittest, using simple asserts. Then, when they have been ported to the unittest, asserts were replaced with the assert_ method and then with assertTrue. The unittest has a number of other

Re: [Python-Dev] Using more specific methods in Python unit tests

2014-02-15 Thread Ned Deily
In article 1392492250.26338.83831085.39a5e...@webmail.messagingengine.com, Benjamin Peterson benja...@python.org wrote: On Sat, Feb 15, 2014, at 10:12 AM, Serhiy Storchaka wrote: Although Raymond approved a patch for test_bigmem [2], his expressed the insistent recommendation not to do

Re: [Python-Dev] Using more specific methods in Python unit tests

2014-02-15 Thread Nick Coghlan
On 16 February 2014 09:20, Ned Deily n...@acm.org wrote: In article 1392492250.26338.83831085.39a5e...@webmail.messagingengine.com, Benjamin Peterson benja...@python.org wrote: On Sat, Feb 15, 2014, at 10:12 AM, Serhiy Storchaka wrote: Although Raymond approved a patch for test_bigmem [2],