Re: [PULL 00/30] Next patches

2023-06-22 Thread Richard Henderson
On 6/22/23 18:54, Juan Quintela wrote: The following changes since commit b455ce4c2f300c8ba47cba7232dd03261368a4cb: Merge tag 'q800-for-8.1-pull-request' ofhttps://github.com/vivier/qemu-m68k into staging (2023-06-22 10:18:32 +0200) are available in the Git repository at: https://gitla

Re: [PATCH RFC 0/6] Switch iotests to pyvenv

2023-06-22 Thread Paolo Bonzini
Il gio 22 giu 2023, 23:18 John Snow ha scritto: > Possibly I could teach mkvenv a new trick, like "mkvenv init iotests" > and have the mkvenv script DTRT at that point, whatever that is -- > ideally exiting very quickly without doing anything. > Or maybe check itself should do the bootstrap if i

Re: [PATCH RFC 0/6] Switch iotests to pyvenv

2023-06-22 Thread John Snow
On Thu, Jun 22, 2023 at 5:12 PM Paolo Bonzini wrote: > > On Thu, Jun 22, 2023 at 11:08 PM John Snow wrote: > > > > On Thu, Jun 22, 2023 at 5:05 PM Paolo Bonzini wrote: > > > > > > On Thu, Jun 22, 2023 at 11:03 PM John Snow wrote: > > > > If we always install it in editable mode, and the path wh

Re: [PATCH RFC 0/6] Switch iotests to pyvenv

2023-06-22 Thread Paolo Bonzini
On Thu, Jun 22, 2023 at 11:08 PM John Snow wrote: > > On Thu, Jun 22, 2023 at 5:05 PM Paolo Bonzini wrote: > > > > On Thu, Jun 22, 2023 at 11:03 PM John Snow wrote: > > > If we always install it in editable mode, and the path where it is > > > "installed" is what we expect it to be, it shouldn't

Re: [PATCH RFC 0/6] Switch iotests to pyvenv

2023-06-22 Thread John Snow
On Thu, Jun 22, 2023 at 5:05 PM Paolo Bonzini wrote: > > On Thu, Jun 22, 2023 at 11:03 PM John Snow wrote: > > If we always install it in editable mode, and the path where it is > > "installed" is what we expect it to be, it shouldn't have any problems > > with being out of date I think. We c

Re: [PATCH RFC 0/6] Switch iotests to pyvenv

2023-06-22 Thread Paolo Bonzini
On Thu, Jun 22, 2023 at 11:03 PM John Snow wrote: > If we always install it in editable mode, and the path where it is > "installed" is what we expect it to be, it shouldn't have any problems > with being out of date I think. We could conceivably use the > "faux" package version the internal p

Re: [PATCH RFC 0/6] Switch iotests to pyvenv

2023-06-22 Thread John Snow
On Thu, Jun 22, 2023 at 5:24 AM Paolo Bonzini wrote: > > On Wed, Jun 21, 2023 at 9:08 AM Paolo Bonzini wrote: > > Maybe patch 4 can use distlib.scripts as well to create the check script in > > the build directory? (Yes that's another mkvenv functionality...) On a > > phone and don't have the d

[PATCH v2 3/5] migration: migrate 'blk' command option is deprecated.

2023-06-22 Thread Juan Quintela
Set the 'block' migration capability to 'true' instead. Signed-off-by: Juan Quintela --- docs/about/deprecated.rst | 7 +++ qapi/migration.json | 10 +++--- migration/migration.c | 5 + 3 files changed, 19 insertions(+), 3 deletions(-) diff --git a/docs/about/deprecated.

[PATCH v2 5/5] migration: Deprecate old compression method

2023-06-22 Thread Juan Quintela
Signed-off-by: Juan Quintela --- docs/about/deprecated.rst | 8 +++ qapi/migration.json | 102 -- migration/options.c | 13 + 3 files changed, 86 insertions(+), 37 deletions(-) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.r

[PATCH v2 2/5] migration: migrate 'inc' command option is deprecated.

2023-06-22 Thread Juan Quintela
Set the 'block_incremental' migration parameter to 'true' instead. Signed-off-by: Juan Quintela --- docs/about/deprecated.rst | 7 +++ qapi/migration.json | 12 ++-- migration/migration.c | 6 ++ 3 files changed, 23 insertions(+), 2 deletions(-) diff --git a/docs/abo

[PATCH v2 4/5] migration: Deprecate block migration

2023-06-22 Thread Juan Quintela
It is obsolete. It is better to use driver-mirror with NBD instead. CC: Kevin Wolf CC: Eric Blake CC: Stefan Hajnoczi CC: Hanna Czenczek Signed-off-by: Juan Quintela --- docs/about/deprecated.rst | 10 ++ qapi/migration.json | 30 +- migration/bloc

[PATCH v2 1/5] migration: Use proper indentation for migration.json

2023-06-22 Thread Juan Quintela
We broke it with dirtyrate limit patches. Signed-off-by: Juan Quintela --- qapi/migration.json | 67 ++--- 1 file changed, 33 insertions(+), 34 deletions(-) diff --git a/qapi/migration.json b/qapi/migration.json index 6ff39157ba..ad8cc57071 100644 --- a/q

[PATCH v2 0/5] Migration deprecated parts

2023-06-22 Thread Juan Quintela
On this v2: - dropped -incoming deprecation Paolo came with a better solution using keyvalues. - skipped field is already ready for next pull request, so dropped. - dropped the RFC bits, nermal PATCH. - Assessed all the review comments. - Added indentation of migration.json. - Used the doc

Re: [RFC 4/6] migration: Deprecate -incoming

2023-06-22 Thread Juan Quintela
Peter Xu wrote: > On Thu, Jun 22, 2023 at 11:22:56AM +0200, Thomas Huth wrote: >> Then simply forbid "migrate_set_parameter multifd-channels ..." if the uri >> has been specified on the command line? > > Yeah, actually already in a pull (even though the pr may need a new one..): > > https://lore.k

Re: [RFC 4/6] migration: Deprecate -incoming

2023-06-22 Thread Juan Quintela
Peter Xu wrote: > On Mon, Jun 12, 2023 at 10:51:08PM +0200, Juan Quintela wrote: >> Peter Xu wrote: >> > On Mon, Jun 12, 2023 at 09:33:42PM +0200, Juan Quintela wrote: >> >> Only "defer" is recommended. After setting all migation parameters, >> >> start incoming migration with "migrate-incoming

Re: [RFC 6/6] migration: Deprecated old compression method

2023-06-22 Thread Juan Quintela
Daniel P. Berrangé wrote: > On Mon, Jun 12, 2023 at 09:33:44PM +0200, Juan Quintela wrote: >> Signed-off-by: Juan Quintela >> --- >> docs/about/deprecated.rst | 8 >> qapi/migration.json | 92 --- >> migration/options.c | 13 ++ >> 3 file

Re: [RFC 6/6] migration: Deprecated old compression method

2023-06-22 Thread Juan Quintela
Thomas Huth wrote: > On 12/06/2023 21.33, Juan Quintela wrote: >> Signed-off-by: Juan Quintela >> --- >> docs/about/deprecated.rst | 8 >> qapi/migration.json | 92 --- >> migration/options.c | 13 ++ >> 3 files changed, 79 insertions

Re: [RFC 4/6] migration: Deprecate -incoming

2023-06-22 Thread Peter Xu
On Thu, Jun 22, 2023 at 05:33:29PM +0100, Daniel P. Berrangé wrote: > On Thu, Jun 22, 2023 at 11:54:43AM -0400, Peter Xu wrote: > > I can try to move the todo even higher. Trying to list the initial goals > > here: > > > > - One extra phase of handshake between src/dst (maybe the time to boost >

Re: [RFC 5/6] migration: Deprecate block migration

2023-06-22 Thread Juan Quintela
Stefan Hajnoczi wrote: > On Mon, Jun 12, 2023 at 09:33:43PM +0200, Juan Quintela wrote: >> It is obsolete. It is better to use driver_mirror+NBD instead. >> >> CC: Kevin Wolf >> CC: Eric Blake >> CC: Stefan Hajnoczi >> CC: Hanna Czenczek >> >> Signed-off-by: Juan Quintela >> >> --- >> >>

Re: [RFC 4/6] migration: Deprecate -incoming

2023-06-22 Thread Juan Quintela
Juan Quintela wrote: > Only "defer" is recommended. After setting all migation parameters, > start incoming migration with "migrate-incoming uri" command. > > Signed-off-by: Juan Quintela Nack myself. Dropped on next submissiong. keyfile properties suggested by paolo is a much better suggesti

Re: [RFC 3/6] migration: migrate 'blk' command option is deprecated.

2023-06-22 Thread Juan Quintela
Daniel P. Berrangé wrote: > On Mon, Jun 12, 2023 at 09:33:41PM +0200, Juan Quintela wrote: >> Use 'migrate_set_capability block true' instead. >> >> Signed-off-by: Juan Quintela >> --- >> docs/about/deprecated.rst | 7 +++ >> qapi/migration.json | 11 +++ >> migration/migrati

Re: [RFC 2/6] migration: migrate 'inc' command option is deprecated.

2023-06-22 Thread Juan Quintela
Daniel P. Berrangé wrote: > On Mon, Jun 12, 2023 at 09:33:40PM +0200, Juan Quintela wrote: >> Use 'migrate_set_parameter block_incremental true' instead. >> >> Signed-off-by: Juan Quintela >> --- >> docs/about/deprecated.rst | 7 +++ >> qapi/migration.json | 11 +-- >> migrat

Re: [RFC 1/6] migration: skipped field is really obsolete.

2023-06-22 Thread Juan Quintela
Daniel P. Berrangé wrote: > On Mon, Jun 12, 2023 at 09:33:39PM +0200, Juan Quintela wrote: >> Has return zero for more than 10 years. Just mark it deprecated. > > Specifically we introduced the field in 1.5.0 > > commit f1c72795af573b24a7da5eb52375c9aba8a37972 > Author: Peter Lieven > Date: Tu

[PULL 13/30] migration-test: Create arch_opts

2023-06-22 Thread Juan Quintela
This will contain the options needed for both source and target. Reviewed-by: Peter Xu Message-ID: <20230608224943.3877-6-quint...@redhat.com> Signed-off-by: Juan Quintela --- tests/qtest/migration-test.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) di

[PULL 19/30] migration-test: simplify shmem_opts handling

2023-06-22 Thread Juan Quintela
Reviewed-by: Peter Xu Message-ID: <20230608224943.3877-4-quint...@redhat.com> Signed-off-by: Juan Quintela --- tests/qtest/migration-test.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c index fbe9db23cf..e3e

[PULL 21/30] migration: Refactor repeated call of yank_unregister_instance

2023-06-22 Thread Juan Quintela
From: Tejus GK In the function qmp_migrate(), yank_unregister_instance() gets called twice which isn't required. Hence, refactoring it so that it gets called during the local_error cleanup. Reviewed-by: Daniel P. Berrangé Reviewed-by: Juan Quintela Acked-by: Peter Xu Signed-off-by: Tejus GK

[PULL 23/30] qtest/migration-tests.c: use "-incoming defer" for postcopy tests

2023-06-22 Thread Juan Quintela
From: Wei Wang The Postcopy preempt capability is expected to be set before incoming starts, so change the postcopy tests to start with deferred incoming and call migrate-incoming after the cap has been set. Why the existing tests (without this patch) didn't fail? There could be two reasons: 1)

[PULL 14/30] migration-test: machine_opts is really arch specific

2023-06-22 Thread Juan Quintela
And it needs to be in both source and target, so put it on arch_opts. Reviewed-by: Peter Xu Message-ID: <20230608224943.3877-7-quint...@redhat.com> Signed-off-by: Juan Quintela --- tests/qtest/migration-test.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/te

[PULL 10/30] migration: Extend query-migrate to provide dirty page limit info

2023-06-22 Thread Juan Quintela
From: Hyman Huang(黄勇) Extend query-migrate to provide throttle time and estimated ring full time with dirty-limit capability enabled, through which we can observe if dirty limit take effect during live migration. Signed-off-by: Hyman Huang(黄勇) Reviewed-by: Markus Armbruster Reviewed-by: Juan Q

[PULL 25/30] migration: Change qemu_file_transferred to noflush

2023-06-22 Thread Juan Quintela
We do a qemu_fclose() just after that, that also does a qemu_fflush(), so remove one qemu_fflush(). Reviewed-by: Philippe Mathieu-Daudé Message-ID: <20230530183941.7223-3-quint...@redhat.com> Signed-off-by: Juan Quintela --- migration/savevm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(

[PULL 17/30] migration-test: Add bootfile_create/delete() functions

2023-06-22 Thread Juan Quintela
The bootsector code is read only from the guest (otherwise we are going to have problems with it being read from both source and destination). Create a single copy for all the tests. Reviewed-by: Peter Xu Message-ID: <20230608224943.3877-10-quint...@redhat.com> Signed-off-by: Juan Quintela ---

[PULL 07/30] migration: Refactor auto-converge capability logic

2023-06-22 Thread Juan Quintela
From: Hyman Huang(黄勇) Check if block migration is running before throttling guest down in auto-converge way. Note that this modification is kind of like code clean, because block migration does not depend on auto-converge capability, so the order of checks can be adjusted. Signed-off-by: Hyman

[PULL 26/30] migration: Use qemu_file_transferred_noflush() for block migration.

2023-06-22 Thread Juan Quintela
We only care about the amount of bytes transferred. Flushing is done by the system somewhere else. Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela Message-ID: <20230530183941.7223-4-quint...@redhat.com> Signed-off-by: Juan Quintela --- migration/block.c | 4 ++-- 1 file changed, 2 ins

[PULL 22/30] migration: enforce multifd and postcopy preempt to be set before incoming

2023-06-22 Thread Juan Quintela
From: Wei Wang qemu_start_incoming_migration needs to check the number of multifd channels or postcopy ram channels to configure the backlog parameter (i.e. the maximum length to which the queue of pending connections for sockfd may grow) of listen(). So enforce the usage of postcopy-preempt and

[PULL 16/30] migration-test: bootpath is the same for all tests and for all archs

2023-06-22 Thread Juan Quintela
So just make it a global variable. Reviewed-by: Peter Xu Message-ID: <20230608224943.3877-9-quint...@redhat.com> Signed-off-by: Juan Quintela --- tests/qtest/migration-test.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/tests/qtest/migration-test.c b

[PULL 01/30] migration/multifd: Rename threadinfo.c functions

2023-06-22 Thread Juan Quintela
From: Fabiano Rosas We're about to add more functions to this file so make it use the same coding style as the rest of the code. Signed-off-by: Fabiano Rosas Reviewed-by: Juan Quintela Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Peter Xu Message-Id: <20230607161306.31425-2-faro...@suse.

[PULL 24/30] qemu-file: Rename qemu_file_transferred_ fast -> noflush

2023-06-22 Thread Juan Quintela
Fast don't say much. Noflush indicates more clearly that it is like qemu_file_transferred but without the flush. Reviewed-by: Philippe Mathieu-Daudé Message-ID: <20230530183941.7223-2-quint...@redhat.com> Signed-off-by: Juan Quintela --- migration/qemu-file.h | 11 +-- migration/qemu-f

[PULL 09/30] migration: Implement dirty-limit convergence algo

2023-06-22 Thread Juan Quintela
From: Hyman Huang(黄勇) Implement dirty-limit convergence algo for live migration, which is kind of like auto-converge algo but using dirty-limit instead of cpu throttle to make migration convergent. Enable dirty page limit if dirty_rate_high_cnt greater than 2 when dirty-limit capability enabled,

[PULL 15/30] migration-test: Create kvm_opts

2023-06-22 Thread Juan Quintela
So arch_dirty_ring option becomes one option like the others. Reviewed-by: Peter Xu Message-ID: <20230608224943.3877-8-quint...@redhat.com> Signed-off-by: Juan Quintela --- tests/qtest/migration-test.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/tests/qtest/m

[PULL 27/30] qemu_file: Make qemu_file_is_writable() static

2023-06-22 Thread Juan Quintela
It is not used outside of qemu_file, and it shouldn't. Signed-off-by: Juan Quintela Message-ID: <20230530183941.7223-19-quint...@redhat.com> Signed-off-by: Juan Quintela --- migration/qemu-file.h | 1 - migration/qemu-file.c | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/

[PULL 12/30] migration-test: Make machine_opts regular with other options

2023-06-22 Thread Juan Quintela
Reviewed-by: Peter Xu Signed-off-by: Juan Quintela Message-ID: <20230608224943.3877-5-quint...@redhat.com> --- tests/qtest/migration-test.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c index c5e0c69c6b.

[PULL 18/30] migration-test: dirtylimit checks for x86_64 arch before

2023-06-22 Thread Juan Quintela
So no need to assert we are in x86_64. Once there, refactor the function to remove useless variables. Reviewed-by: Peter Xu Message-ID: <20230608224943.3877-11-quint...@redhat.com> Signed-off-by: Juan Quintela --- tests/qtest/migration-test.c | 5 + 1 file changed, 1 insertion(+), 4 deletio

[PULL 30/30] migration/rdma: Split qemu_fopen_rdma() into input/output functions

2023-06-22 Thread Juan Quintela
This is how everything else in QEMUFile is structured. As a bonus they are three less lines of code. Reviewed-by: Peter Xu Message-ID: <20230530183941.7223-17-quint...@redhat.com> Signed-off-by: Juan Quintela --- migration/qemu-file.h | 1 - migration/qemu-file.c | 12 migration/r

[PULL 02/30] migration/multifd: Protect accesses to migration_threads

2023-06-22 Thread Juan Quintela
From: Fabiano Rosas This doubly linked list is common for all the multifd and migration threads so we need to avoid concurrent access. Add a mutex to protect the data from concurrent access. This fixes a crash when removing two MigrationThread objects from the list at the same time during cleanu

[PULL 28/30] qemu-file: Simplify qemu_file_shutdown()

2023-06-22 Thread Juan Quintela
Reviewed-by: Peter Xu Message-ID: <20230530183941.7223-20-quint...@redhat.com> Signed-off-by: Juan Quintela --- migration/qemu-file.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/migration/qemu-file.c b/migration/qemu-file.c index 9a89e17924..4c577bdff8 100644 --- a/

[PULL 20/30] migration: Update error description whenever migration fails

2023-06-22 Thread Juan Quintela
From: Tejus GK There are places in migration.c where the migration is marked failed with MIGRATION_STATUS_FAILED, but the failure reason is never updated. Hence libvirt doesn't know why the migration failed when it queries for it. Reviewed-by: Daniel P. Berrangé Signed-off-by: Tejus GK Message

[PULL 29/30] qemu-file: Make qemu_file_get_error_obj() static

2023-06-22 Thread Juan Quintela
It was not used outside of qemu_file.c anyways. Reviewed-by: Peter Xu Message-ID: <20230530183941.7223-21-quint...@redhat.com> Signed-off-by: Juan Quintela --- migration/qemu-file.h | 1 - migration/qemu-file.c | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/migration/qemu

[PULL 11/30] migration-test: Be consistent for ppc

2023-06-22 Thread Juan Quintela
It makes no sense that we don't have the same configuration on both sides. Reviewed-by: Laurent Vivier Message-ID: <20230608224943.3877-2-quint...@redhat.com> Signed-off-by: Juan Quintela --- tests/qtest/migration-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/

[PULL 04/30] qapi/migration: Introduce x-vcpu-dirty-limit-period parameter

2023-06-22 Thread Juan Quintela
From: Hyman Huang(黄勇) Introduce "x-vcpu-dirty-limit-period" migration experimental parameter, which is in the range of 1 to 1000ms and used to make dirtyrate calculation period configurable. Currently with the "x-vcpu-dirty-limit-period" varies, the total time of live migration changes, test res

[PULL 03/30] softmmu/dirtylimit: Add parameter check for hmp "set_vcpu_dirty_limit"

2023-06-22 Thread Juan Quintela
From: Hyman Huang(黄勇) dirty_rate paraemter of hmp command "set_vcpu_dirty_limit" is invalid if less than 0, so add parameter check for it. Note that this patch also delete the unsolicited help message and clean up the code. Signed-off-by: Hyman Huang(黄勇) Reviewed-by: Markus Armbruster Reviewe

[PULL 05/30] qapi/migration: Introduce vcpu-dirty-limit parameters

2023-06-22 Thread Juan Quintela
From: Hyman Huang(黄勇) Introduce "vcpu-dirty-limit" migration parameter used to limit dirty page rate during live migration. "vcpu-dirty-limit" and "x-vcpu-dirty-limit-period" are two dirty-limit-related migration parameters, which can be set before and during live migration by qmp migrate-set-pa

[PULL 08/30] migration: Put the detection logic before auto-converge checking

2023-06-22 Thread Juan Quintela
From: Hyman Huang(黄勇) This commit is prepared for the implementation of dirty-limit convergence algo. The detection logic of throttling condition can apply to both auto-converge and dirty-limit algo, putting it's position before the checking logic for auto-converge feature. Signed-off-by: Hyman

[PULL 06/30] migration: Introduce dirty-limit capability

2023-06-22 Thread Juan Quintela
From: Hyman Huang(黄勇) Introduce migration dirty-limit capability, which can be turned on before live migration and limit dirty page rate durty live migration. Introduce migrate_dirty_limit function to help check if dirty-limit capability enabled during live migration. Meanwhile, refactor vcpu_d

[PULL 00/30] Next patches

2023-06-22 Thread Juan Quintela
The following changes since commit b455ce4c2f300c8ba47cba7232dd03261368a4cb: Merge tag 'q800-for-8.1-pull-request' of https://github.com/vivier/qemu-m68k into staging (2023-06-22 10:18:32 +0200) are available in the Git repository at: https://gitlab.com/juan.quintela/qemu.git tags/next-pull

Re: [RFC 4/6] migration: Deprecate -incoming

2023-06-22 Thread Daniel P . Berrangé
On Thu, Jun 22, 2023 at 11:54:43AM -0400, Peter Xu wrote: > I can try to move the todo even higher. Trying to list the initial goals > here: > > - One extra phase of handshake between src/dst (maybe the time to boost > QEMU_VM_FILE_VERSION) before anything else happens. > > - Dest shouldn't ne

Re: [RFC 4/6] migration: Deprecate -incoming

2023-06-22 Thread Paolo Bonzini
On Thu, Jun 22, 2023 at 5:26 PM Peter Xu wrote: > PS: we may want to postpone this to be later than migration_object_init(), > when/if there's a real patch. Yes, that's true. > > > The only incompatibility is for people who are using "," in an URI, > > > which is rare and only an issue for the "

Re: [RFC 4/6] migration: Deprecate -incoming

2023-06-22 Thread Peter Xu
On Thu, Jun 22, 2023 at 10:59:58AM +0100, Daniel P. Berrangé wrote: > On Thu, Jun 22, 2023 at 10:52:12AM +0200, Juan Quintela wrote: > > Paolo Bonzini wrote: > > > On 6/12/23 22:51, Juan Quintela wrote: > > >>> Shall we just leave it there? Or is deprecating it helps us in any > > >>> form? > >

Re: [RFC 4/6] migration: Deprecate -incoming

2023-06-22 Thread Peter Xu
On Thu, Jun 22, 2023 at 11:22:56AM +0200, Thomas Huth wrote: > Then simply forbid "migrate_set_parameter multifd-channels ..." if the uri > has been specified on the command line? Yeah, actually already in a pull (even though the pr may need a new one..): https://lore.kernel.org/r/20230622021320.

Re: [RFC 4/6] migration: Deprecate -incoming

2023-06-22 Thread Peter Xu
On Thu, Jun 22, 2023 at 12:01:55PM +0200, Juan Quintela wrote: > Paolo Bonzini wrote: > > On 6/22/23 10:52, Juan Quintela wrote: > >> User friendliness. > >> The problem is that if you use more than two channels with multifd, on > >> the incoming side, you need to do: > > > > You're sacrificing us

Re: [PATCH v2 06/20] qemu_file: total_transferred is not used anymore

2023-06-22 Thread Peter Xu
On Thu, Jun 22, 2023 at 01:05:49AM +0200, Juan Quintela wrote: > Peter Xu wrote: > > On Tue, May 30, 2023 at 08:39:27PM +0200, Juan Quintela wrote: > >> Signed-off-by: Juan Quintela > >> --- > >> migration/qemu-file.c | 4 > >> 1 file changed, 4 deletions(-) > >> > >> diff --git a/migratio

Re: [PULL 20/30] migration: Update error description whenever migration fails

2023-06-22 Thread Tejus GK
On 22/06/23 7:43 am, Juan Quintela wrote: > From: Tejus GK > > There are places in migration.c where the migration is marked failed with > MIGRATION_STATUS_FAILED, but the failure reason is never updated. Hence > libvirt doesn't know why the migration failed when it queries for it. > > Reviewed-

[PATCH 2/2] ide: Explicitly poll for BHs on cancel

2023-06-22 Thread Lukas Straub
When we still have an AIOCB registered for DMA operations, we try to settle the respective operation by draining the BlockBackend associated with the IDE device. However, this assumes that every DMA operation is associated with some I/O operation on the BlockBackend, and so settling the latter wil

[PATCH 1/2] ide: Fix a rare hang during block draining

2023-06-22 Thread Lukas Straub
If the guest issues a discard during a block drain section, the blk_aio_pdiscard() may not be processed, but queued instead. And so the callback will never be called to issue the bh and decrease the BB in-flight number again. This causes a hang in the drain code, since it will wait forever for the

Re: [RFC 4/6] migration: Deprecate -incoming

2023-06-22 Thread Juan Quintela
Paolo Bonzini wrote: > On 6/22/23 10:52, Juan Quintela wrote: >> User friendliness. >> The problem is that if you use more than two channels with multifd, on >> the incoming side, you need to do: > > You're sacrificing user-friendliness for the 99.99% that don't use > multifd, for an error (i.e. i

Re: [RFC 4/6] migration: Deprecate -incoming

2023-06-22 Thread Daniel P . Berrangé
On Thu, Jun 22, 2023 at 10:52:12AM +0200, Juan Quintela wrote: > Paolo Bonzini wrote: > > On 6/12/23 22:51, Juan Quintela wrote: > >>> Shall we just leave it there? Or is deprecating it helps us in any form? > >> See the patches two weeks ago when people complained that lisen(.., num) > >> was to

Re: [RFC 4/6] migration: Deprecate -incoming

2023-06-22 Thread Paolo Bonzini
On 6/22/23 10:52, Juan Quintela wrote: User friendliness. The problem is that if you use more than two channels with multifd, on the incoming side, you need to do: You're sacrificing user-friendliness for the 99.99% that don't use multifd, for an error (i.e. it's not even fixing the issue) f

Re: [PATCH RFC 0/6] Switch iotests to pyvenv

2023-06-22 Thread Paolo Bonzini
On Wed, Jun 21, 2023 at 9:08 AM Paolo Bonzini wrote: > Maybe patch 4 can use distlib.scripts as well to create the check script in > the build directory? (Yes that's another mkvenv functionality...) On a phone > and don't have the docs at hand, so I am not sure. If not, your solution is > good

Re: [RFC 4/6] migration: Deprecate -incoming

2023-06-22 Thread Thomas Huth
On 22/06/2023 10.52, Juan Quintela wrote: Paolo Bonzini wrote: On 6/12/23 22:51, Juan Quintela wrote: Shall we just leave it there? Or is deprecating it helps us in any form? See the patches two weeks ago when people complained that lisen(.., num) was too low. And there are other parameters

Re: [RFC 4/6] migration: Deprecate -incoming

2023-06-22 Thread Juan Quintela
Paolo Bonzini wrote: > On 6/12/23 22:51, Juan Quintela wrote: >>> Shall we just leave it there? Or is deprecating it helps us in any form? >> See the patches two weeks ago when people complained that lisen(.., num) >> was too low. And there are other parameters that work the same way >> (that I

Re: [RFC 4/6] migration: Deprecate -incoming

2023-06-22 Thread Paolo Bonzini
On 6/21/23 09:08, Thomas Huth wrote:   if (strcmp(incoming, "defer") != 0) { +    warn_report("-incoming %s is deprecated, use -incoming defer and " +    " set the uri with migrate-incoming.", incoming);   qmp_migrate_incoming(incoming, &local_e

Re: [RFC 4/6] migration: Deprecate -incoming

2023-06-22 Thread Paolo Bonzini
On 6/12/23 22:51, Juan Quintela wrote: Shall we just leave it there? Or is deprecating it helps us in any form? See the patches two weeks ago when people complained that lisen(.., num) was too low. And there are other parameters that work the same way (that I convenientely had forgotten). So

Re: [PULL 00/30] Next patches

2023-06-22 Thread Juan Quintela
Richard Henderson wrote: > On 6/22/23 04:12, Juan Quintela wrote: >> The following changes since commit 67fe6ae41da64368bc4936b196fee2bf61f8c720: >>Merge tag 'pull-tricore-20230621-1' >> ofhttps://github.com/bkoppelmann/qemu into staging (2023-06-21 >> 20:08:48 +0200) >> are available in the