Re: [Qemu-devel] -net interface association behavior change in current -git.

2011-05-12 Thread Markus Armbruster
Rob Landley writes: > On 05/12/2011 09:10 AM, Markus Armbruster wrote: >> Rob Landley writes: >> >>> In 1.14.0, if I did this: >>> >>> qemu -net nic,blah -net user -net nic,blah -net tun,blah >>> >>> Then the first nic would be -net user, and the second nic would be -net >>> tun.In curren

Re: [Qemu-devel] -net interface association behavior change in current -git.

2011-05-12 Thread Jan Kiszka
On 2011-05-13 03:49, Rob Landley wrote: > On 05/12/2011 08:19 PM, Vincent Palatin wrote: First of all, as you have 2 totally separated subnets in your setup, I think your command-line should use "vlan=" parameter to isolate them, else you will end up with some random routing/broadcas

Re: [Qemu-devel] [PATCH 0/4] introduce cpu_physical_memory_map_fast

2011-05-12 Thread Paolo Bonzini
On 05/12/2011 05:32 PM, Avi Kivity wrote: Out of curiosity, what performance benefit do you see? Zero. :) Also because the only real change is in patch 4/4 (milkymist) which I only compile-tested. In all other instances, using cpu_physical_memory_map_fast is just to make it clear that we do

Re: [Qemu-devel] [PATCH 02/25] [virtio-9p] Change all pdu handlers to coroutines.

2011-05-12 Thread Stefan Hajnoczi
On Thu, May 12, 2011 at 9:57 PM, Venkateswararao Jujjuri (JV) wrote: > +typedef struct V9fsCoPdu { > +    V9fsPDU *pdu; > +    V9fsState *s; > +    Coroutine *coroutine; > +} V9fsCoPdu; How about adding the V9fsState *s field to V9fsPDU? Then you do not need this new V9fsCoPdu struct and all the

Re: [Qemu-devel] -net interface association behavior change in current -git.

2011-05-12 Thread Brad Hards
On Fri, 13 May 2011 03:19:42 AM Vincent Palatin wrote: > > Does the kernel need some sort of vlan support compiled into it for this > > to work, or can the kernel not care? > > You don't need anything in your kernel, this is for Qemu network layer > configuration. Just to explain a bit further: qe

[Qemu-devel] [Bug 584121] Re: migration always fails on 32bit qemu-kvm-0.12+ (sigsegv)

2011-05-12 Thread Michael Tokarev
This is fixed by two commits. The second half is here: http://git.kernel.org/?p=virt/kvm/qemu-kvm.git;a=commit;h=51b0c6065aa6e47a47094d73e24be298a4a7f3a1 which fixes mixed 32/63 user/kernel host environment part of the problem, and the first half belongs to the time between 0.13 and 0.14 when d

Re: [Qemu-devel] [PATCH 01/25] [virtio-9p] Add infrastructure to support glib threads and coroutines.

2011-05-12 Thread Stefan Hajnoczi
On Thu, May 12, 2011 at 9:57 PM, Venkateswararao Jujjuri (JV) wrote: > +/* v9fs glib thread pool */ > +V9fsThPool v9fs_pool; This should be static and an init function in this file could perform initialization. Right now the initialization is inlined in virtio-9p-device.c. > +void v9fs_qemu_sub

Re: [Qemu-devel] [RFC] live snapshot, live merge, live block migration

2011-05-12 Thread Jagane Sundar
On 5/12/2011 8:33 AM, Jes Sorensen wrote: On 05/09/11 15:40, Dor Laor wrote: Summary: * We need Marcelo's new (to come) block copy implementation * should work in parallel to migration and hotplug * General copy on read is desirable * Live snapshot merge to be implemented using blo

Re: [Qemu-devel] [PATCH] Add warmup phase for live migration of large memory apps

2011-05-12 Thread Yoshiaki Tamura
2011/5/12 Isaku Yamahata : > On Thu, May 12, 2011 at 12:39:22PM +0200, Juan Quintela wrote: >> "Shribman, Aidan" wrote: >> >> On Wed, May 11, 2011 at 8:58 AM, Shribman, Aidan >> >> wrote: >> >> > From: Aidan Shribman >> >> > >> >> > [PATCH] Add warmup phase for live migration of large memory app

Re: [Qemu-devel] -net interface association behavior change in current -git.

2011-05-12 Thread Rob Landley
On 05/12/2011 08:19 PM, Vincent Palatin wrote: >>> First of all, as you have 2 totally separated subnets in your setup, I >>> think your command-line should use "vlan=" parameter to isolate them, >>> else you will end up with some random routing/broadcasting (and random >>> tends to change over tim

Re: [Qemu-devel] -net interface association behavior change in current -git.

2011-05-12 Thread Rob Landley
On 05/12/2011 09:10 AM, Markus Armbruster wrote: > Rob Landley writes: > >> In 1.14.0, if I did this: >> >> qemu -net nic,blah -net user -net nic,blah -net tun,blah >> >> Then the first nic would be -net user, and the second nic would be -net >> tun.In current -git, -net user attaches to th

Re: [Qemu-devel] -net interface association behavior change in current -git.

2011-05-12 Thread Vincent Palatin
>> First of all, as you have 2 totally separated subnets in your setup, I >> think your command-line should use "vlan=" parameter to isolate them, >> else you will end up with some random routing/broadcasting (and random >> tends to change over time). > > Does the kernel need some sort of vlan supp

Re: [Qemu-devel] -net interface association behavior change in current -git.

2011-05-12 Thread Rob Landley
On 05/12/2011 08:20 AM, Vincent Palatin wrote: > Hi, > > On Wed, May 11, 2011 at 22:39, Rob Landley wrote: >> In 1.14.0, if I did this: >> >> qemu -net nic,blah -net user -net nic,blah -net tun,blah >> >> Then the first nic would be -net user, and the second nic would be -net >> tun.In curre

[Qemu-devel] [PATCH 24/25] [virtio-9p] clean up v9fs_remove.

2011-05-12 Thread Venkateswararao Jujjuri (JV)
Rearrange the code so that we can avoid V9fsRemoveState and additional malloc()s. Signed-off-by: Venkateswararao Jujjuri " --- hw/9pfs/virtio-9p.c | 24 +--- hw/9pfs/virtio-9p.h |6 -- 2 files changed, 9 insertions(+), 21 deletions(-) diff --git a/hw/9pfs/virtio-9p.

Re: [Qemu-devel] [PATCH] Add AACI audio playback support to the ARM Versatile/PB platform

2011-05-12 Thread Mathieu Sonet
Paul Brook wrote: On the other hand the current ac97.c implementation is a closely coupled combination of a PCI/ACLink bridge (Intel 82801AA) with a generic AC97 codec. This has prevent me to easily reuse this code. The milkymist-ac97 implementation is another case. It looks like a basic impleme

[Qemu-devel] [PATCH 21/25] hw/9pfs: Update v9fs_mknod to use coroutines

2011-05-12 Thread Venkateswararao Jujjuri (JV)
From: Aneesh Kumar K.V Signed-off-by: Aneesh Kumar K.V Signed-off-by: Venkateswararao Jujjuri " --- hw/9pfs/virtio-9p.c | 89 +- 1 files changed, 30 insertions(+), 59 deletions(-) diff --git a/hw/9pfs/virtio-9p.c b/hw/9pfs/virtio-9p.c index 764

[Qemu-devel] [PATCH 17/25] hw/9pfs: Add yield support to xattr related coroutine

2011-05-12 Thread Venkateswararao Jujjuri (JV)
From: Aneesh Kumar K.V This include llistxattr and lgetxattr. Signed-off-by: Aneesh Kumar K.V Signed-off-by: Venkateswararao Jujjuri " --- Makefile.objs|1 + hw/9pfs/coxattr.c| 92 ++ hw/9pfs/virtio-9p-coth.h |3 + 3 fil

[Qemu-devel] [PATCH 08/25] [virtio-9p] clean up v9fs_mkdir.

2011-05-12 Thread Venkateswararao Jujjuri (JV)
Rearrange the code so that we can avoid V9fsMkState and additional malloc()s. Signed-off-by: Venkateswararao Jujjuri " --- hw/9pfs/virtio-9p.c | 39 +-- 1 files changed, 17 insertions(+), 22 deletions(-) diff --git a/hw/9pfs/virtio-9p.c b/hw/9pfs/virtio-9p.c

[Qemu-devel] [PATCH 23/25] [virtio-9p] Remove post functions for v9fs_remove

2011-05-12 Thread Venkateswararao Jujjuri (JV)
Signed-off-by: Venkateswararao Jujjuri " --- hw/9pfs/virtio-9p.c | 26 +++--- 1 files changed, 7 insertions(+), 19 deletions(-) diff --git a/hw/9pfs/virtio-9p.c b/hw/9pfs/virtio-9p.c index e5112fe..dcce864 100644 --- a/hw/9pfs/virtio-9p.c +++ b/hw/9pfs/virtio-9p.c @@ -2612,2

[Qemu-devel] [PATCH 19/25] hw/9pfs: Update v9fs_xattrcreate to use coroutines

2011-05-12 Thread Venkateswararao Jujjuri (JV)
From: Aneesh Kumar K.V Signed-off-by: Aneesh Kumar K.V Signed-off-by: Venkateswararao Jujjuri " --- hw/9pfs/virtio-9p.c | 55 +-- hw/9pfs/virtio-9p.h | 11 -- 2 files changed, 27 insertions(+), 39 deletions(-) diff --git a/hw/9pfs/vir

[Qemu-devel] [PATCH 25/25] [virtio-9p] coroutine and threading for remove/unlink

2011-05-12 Thread Venkateswararao Jujjuri (JV)
Signed-off-by: Venkateswararao Jujjuri " --- hw/9pfs/cofs.c | 28 hw/9pfs/virtio-9p-coth.h |1 + hw/9pfs/virtio-9p.c | 11 ++- 3 files changed, 31 insertions(+), 9 deletions(-) diff --git a/hw/9pfs/cofs.c b/hw/9pfs/cofs.c index 06127f7..

[Qemu-devel] [PATCH 11/25] hw/9pfs: Add yield support to statfs coroutine

2011-05-12 Thread Venkateswararao Jujjuri (JV)
From: Aneesh Kumar K.V Signed-off-by: Aneesh Kumar K.V Signed-off-by: Venkateswararao Jujjuri " --- hw/9pfs/cofs.c | 31 +++ hw/9pfs/virtio-9p-coth.h |1 + 2 files changed, 32 insertions(+), 0 deletions(-) diff --git a/hw/9pfs/cofs.c b/hw/9pfs/cofs.c

[Qemu-devel] [PATCH 15/25] hw/9pfs: Add yield support to setattr related coroutines

2011-05-12 Thread Venkateswararao Jujjuri (JV)
From: Aneesh Kumar K.V This include chmod, utimensat, chown and truncate. Signed-off-by: Aneesh Kumar K.V Signed-off-by: Venkateswararao Jujjuri " --- hw/9pfs/cofs.c | 135 ++ hw/9pfs/virtio-9p-coth.h |4 ++ 2 files changed, 139 insert

[Qemu-devel] [PATCH 09/25] hw/9pfs: Add yield support for readdir related coroutines

2011-05-12 Thread Venkateswararao Jujjuri (JV)
From: Aneesh Kumar K.V This include readdir, telldir, seekdir, rewinddir. Signed-off-by: Aneesh Kumar K.V Signed-off-by: Venkateswararao Jujjuri " --- Makefile.objs|2 +- hw/9pfs/codir.c | 135 ++ hw/9pfs/virtio-9p-coth.h |

[Qemu-devel] [PATCH 13/25] hw/9pfs: Add yield support to lstat coroutine

2011-05-12 Thread Venkateswararao Jujjuri (JV)
From: Aneesh Kumar K.V Signed-off-by: Aneesh Kumar K.V Signed-off-by: Venkateswararao Jujjuri " --- Makefile.objs|2 +- hw/9pfs/cofile.c | 50 ++ hw/9pfs/virtio-9p-coth.h |1 + 3 files changed, 52 insertions(+), 1 deletio

[Qemu-devel] [PATCH 22/25] [virtio-9p] coroutine and threading for mkdir

2011-05-12 Thread Venkateswararao Jujjuri (JV)
Signed-off-by: Venkateswararao Jujjuri " --- hw/9pfs/codir.c | 34 ++ hw/9pfs/virtio-9p-coth.h |1 + hw/9pfs/virtio-9p.c | 28 ++-- 3 files changed, 41 insertions(+), 22 deletions(-) diff --git a/hw/9pfs/codir.c b/hw/9p

[Qemu-devel] [PATCH 20/25] hw/9pfs: Add yield support to mknod coroutine

2011-05-12 Thread Venkateswararao Jujjuri (JV)
From: Aneesh Kumar K.V Signed-off-by: Aneesh Kumar K.V Signed-off-by: Venkateswararao Jujjuri " --- hw/9pfs/cofs.c | 45 + hw/9pfs/virtio-9p-coth.h |2 ++ 2 files changed, 47 insertions(+), 0 deletions(-) diff --git a/hw/9pfs/cofs.c b

[Qemu-devel] [PATCH 10/25] hw/9pfs: Update v9fs_readdir to use coroutines

2011-05-12 Thread Venkateswararao Jujjuri (JV)
From: Aneesh Kumar K.V Signed-off-by: Aneesh Kumar K.V Signed-off-by: Venkateswararao Jujjuri " --- hw/9pfs/virtio-9p.c | 170 +-- 1 files changed, 69 insertions(+), 101 deletions(-) diff --git a/hw/9pfs/virtio-9p.c b/hw/9pfs/virtio-9p.c index 8

[Qemu-devel] [PATCH 18/25] hw/9pfs: Update v9fs_xattrwalk to coroutines

2011-05-12 Thread Venkateswararao Jujjuri (JV)
From: Aneesh Kumar K.V Signed-off-by: Aneesh Kumar K.V Signed-off-by: Venkateswararao Jujjuri " --- hw/9pfs/virtio-9p.c | 198 --- 1 files changed, 63 insertions(+), 135 deletions(-) diff --git a/hw/9pfs/virtio-9p.c b/hw/9pfs/virtio-9p.c index 8

[Qemu-devel] [PATCH 01/25] [virtio-9p] Add infrastructure to support glib threads and coroutines.

2011-05-12 Thread Venkateswararao Jujjuri (JV)
This patch is originally made by Arun Bharadwaj for glib support. Later Harsh Prateek Bora added coroutines support. Signed-off-by: Arun R Bharadwaj Signed-off-by: Harsh Prateek Bora Signed-off-by: Venkateswararao Jujjuri " --- Makefile.objs |2 + hw/9pfs/virtio-9p-coth.c |

[Qemu-devel] [PATCH 12/25] hw/9pfs: Update v9fs_statfs to use coroutines

2011-05-12 Thread Venkateswararao Jujjuri (JV)
From: Aneesh Kumar K.V Signed-off-by: Aneesh Kumar K.V Signed-off-by: Venkateswararao Jujjuri " --- hw/9pfs/virtio-9p.c | 92 -- hw/9pfs/virtio-9p.h | 22 2 files changed, 44 insertions(+), 70 deletions(-) diff --git a/hw/9pfs/vi

[Qemu-devel] [PATCH 16/25] hw/9pfs: Update v9fs_setattr to use coroutines

2011-05-12 Thread Venkateswararao Jujjuri (JV)
From: Aneesh Kumar K.V Signed-off-by: Aneesh Kumar K.V Signed-off-by: Venkateswararao Jujjuri " --- hw/9pfs/virtio-9p.c | 165 +-- hw/9pfs/virtio-9p.h |8 --- 2 files changed, 55 insertions(+), 118 deletions(-) diff --git a/hw/9pfs/virtio-9p

[Qemu-devel] [PATCH 07/25] [virtio-9p] Remove post functions for v9fs_mkdir.

2011-05-12 Thread Venkateswararao Jujjuri (JV)
Signed-off-by: Venkateswararao Jujjuri " --- hw/9pfs/virtio-9p.c | 52 -- 1 files changed, 13 insertions(+), 39 deletions(-) diff --git a/hw/9pfs/virtio-9p.c b/hw/9pfs/virtio-9p.c index 7ef6ad8..af0143d 100644 --- a/hw/9pfs/virtio-9p.c +++ b/hw/9p

[Qemu-devel] [PATCH 06/25] [virtio-9p] coroutines for readlink

2011-05-12 Thread Venkateswararao Jujjuri (JV)
Signed-off-by: Venkateswararao Jujjuri " --- Makefile.objs|2 +- hw/9pfs/cofs.c | 60 ++ hw/9pfs/virtio-9p-coth.h |3 +- hw/9pfs/virtio-9p.c | 22 ++-- 4 files changed, 66 insertions(+), 21 deletions(-)

[Qemu-devel] [PATCH 14/25] hw/9pfs: Update v9fs_getattr to use coroutines

2011-05-12 Thread Venkateswararao Jujjuri (JV)
From: Aneesh Kumar K.V Signed-off-by: Aneesh Kumar K.V Signed-off-by: Venkateswararao Jujjuri " --- hw/9pfs/virtio-9p.c | 59 +- hw/9pfs/virtio-9p.h |8 --- 2 files changed, 20 insertions(+), 47 deletions(-) diff --git a/hw/9pfs/virtio-

[Qemu-devel] [0/25] Async threading for VirtFS using glib threads & coroutines.

2011-05-12 Thread Venkateswararao Jujjuri (JV)
VirtFS (fileserver base on 9P) performs many blocking system calls in the vCPU context. This effort is to move the blocking calls out of vCPU/IO thread context, into asynchronous threads. Anthony's " Add hard build dependency on glib" patch and Kevin/Stefan's coroutine effort is a prerequisite.

[Qemu-devel] [PATCH 02/25] [virtio-9p] Change all pdu handlers to coroutines.

2011-05-12 Thread Venkateswararao Jujjuri (JV)
This patch changes the top level handlers to coroutines and sets the base. It will be followed up with series of patches to convert all filesystem calls to threaded coroutines pushing all blocking clals in VirtFS out of vcpu threads. Signed-off-by: Venkateswararao Jujjuri " --- hw/9pfs/virtio-9p-

[Qemu-devel] [PATCH 04/25] [virtio-9p] clean up v9fs_readlink.

2011-05-12 Thread Venkateswararao Jujjuri (JV)
Rearrange the code so that we can avoid V9fsReadLinkState. Signed-off-by: Venkateswararao Jujjuri " --- hw/9pfs/virtio-9p.c | 26 ++ hw/9pfs/virtio-9p.h |7 --- 2 files changed, 10 insertions(+), 23 deletions(-) diff --git a/hw/9pfs/virtio-9p.c b/hw/9pfs/virtio-

[Qemu-devel] [PATCH 03/25] [virtio-9p] Remove post functions for v9fs_readlink.

2011-05-12 Thread Venkateswararao Jujjuri (JV)
In the process of preparation for coroutine threads, remove all post functions and make the function more readable. Signed-off-by: Venkateswararao Jujjuri " --- hw/9pfs/virtio-9p.c | 25 +++-- 1 files changed, 7 insertions(+), 18 deletions(-) diff --git a/hw/9pfs/virtio-9p.

[Qemu-devel] [PATCH 05/25] [virtio-9p] Move errno into v9fs_do_readlink

2011-05-12 Thread Venkateswararao Jujjuri (JV)
Signed-off-by: Venkateswararao Jujjuri " --- hw/9pfs/virtio-9p.c | 32 1 files changed, 16 insertions(+), 16 deletions(-) diff --git a/hw/9pfs/virtio-9p.c b/hw/9pfs/virtio-9p.c index c4d903a..a748c34 100644 --- a/hw/9pfs/virtio-9p.c +++ b/hw/9pfs/virtio-9p.c @@

Re: [Qemu-devel] qdev device documentation (Re: [PATCH 0/2] usb-linux: physical port handling.)

2011-05-12 Thread Anthony Liguori
On 05/12/2011 02:32 PM, Alon Levy wrote: We could have a (just picking up the Spice example) spice-docs file that was checked in and updated periodically by generation by the maintainer. It's error prone, you could still update the source but forget to checkin the spice-docs and get an old versi

Re: [Qemu-devel] qdev device documentation (Re: [PATCH 0/2] usb-linux: physical port handling.)

2011-05-12 Thread Alon Levy
On Thu, May 12, 2011 at 08:15:43PM +0200, Peter Maydell wrote: > On 12 May 2011 19:58, Markus Armbruster wrote: > > Anthony Liguori writes: > >> But for things like Spice where the lack of libspice influences > >> whether the device is available, how do I extract formal documentation > >> to publ

Re: [Qemu-devel] [PATCH v2 1/4] coroutine: introduce coroutines

2011-05-12 Thread Stefan Hajnoczi
On Thu, May 12, 2011 at 7:12 PM, Blue Swirl wrote: > On Thu, May 12, 2011 at 12:54 PM, Stefan Hajnoczi > wrote: >> diff --git a/coroutine-ucontext.c b/coroutine-ucontext.c >> new file mode 100644 >> index 000..3b14ebf >> --- /dev/null >> +++ b/coroutine-ucontext.c >> @@ -0,0 +1,73 @@ >> +/* >

Re: [Qemu-devel] [PATCH v3 3/6] block QMP: Drop query-block member "type" (type= in info block)

2011-05-12 Thread Luiz Capitulino
On Thu, 12 May 2011 19:54:40 +0200 Markus Armbruster wrote: > Luiz Capitulino writes: > > > On Thu, 12 May 2011 19:12:56 +0200 > > Markus Armbruster wrote: > > > >> Luiz Capitulino writes: > >> > >> > On Thu, 12 May 2011 17:05:12 +0200 > >> > Markus Armbruster wrote: > >> > > >> >> Its valu

Re: [Qemu-devel] qdev device documentation (Re: [PATCH 0/2] usb-linux: physical port handling.)

2011-05-12 Thread Markus Armbruster
Anthony Liguori writes: > On 05/12/2011 11:18 AM, Markus Armbruster wrote: >> Anthony Liguori writes: >> >>> On 05/12/2011 10:25 AM, Gerd Hoffmann wrote: Hi, >> What is the status of the qdev documentation patches btw.? > > http://lists.gnu.org/archive/html/qemu-devel/2011-

Re: [Qemu-devel] qdev device documentation (Re: [PATCH 0/2] usb-linux: physical port handling.)

2011-05-12 Thread Peter Maydell
On 12 May 2011 19:58, Markus Armbruster wrote: > Anthony Liguori writes: >> But for things like Spice where the lack of libspice influences >> whether the device is available, how do I extract formal documentation >> to publish on qemu.org reliably? > > If no maintainer of QEMU can build with Spi

Re: [Qemu-devel] [PATCH v2 1/4] coroutine: introduce coroutines

2011-05-12 Thread Blue Swirl
On Thu, May 12, 2011 at 12:54 PM, Stefan Hajnoczi wrote: > From: Kevin Wolf > > Asynchronous code is becoming very complex.  At the same time > synchronous code is growing because it is convenient to write. > Sometimes duplicate code paths are even added, one synchronous and the > other asynchron

Re: [Qemu-devel] qdev device documentation (Re: [PATCH 0/2] usb-linux: physical port handling.)

2011-05-12 Thread Anthony Liguori
On 05/12/2011 12:58 PM, Markus Armbruster wrote: Anthony Liguori writes: On 05/12/2011 11:08 AM, Markus Armbruster wrote: Anthony Liguori writes: On 05/12/2011 10:25 AM, Gerd Hoffmann wrote: Hi, What is the status of the qdev documentation patches btw.? http://lists.gnu.org/archive/h

Re: [Qemu-devel] qdev device documentation (Re: [PATCH 0/2] usb-linux: physical port handling.)

2011-05-12 Thread Markus Armbruster
Anthony Liguori writes: > On 05/12/2011 11:08 AM, Markus Armbruster wrote: >> Anthony Liguori writes: >> >>> On 05/12/2011 10:25 AM, Gerd Hoffmann wrote: Hi, >> What is the status of the qdev documentation patches btw.? > > http://lists.gnu.org/archive/html/qemu-devel/2011-

Re: [Qemu-devel] [PATCH v3 3/6] block QMP: Drop query-block member "type" (type= in info block)

2011-05-12 Thread Markus Armbruster
Luiz Capitulino writes: > On Thu, 12 May 2011 19:12:56 +0200 > Markus Armbruster wrote: > >> Luiz Capitulino writes: >> >> > On Thu, 12 May 2011 17:05:12 +0200 >> > Markus Armbruster wrote: >> > >> >> Its value is unreliable: a block device used as floppy has type >> >> "floppy" if created wi

Re: [Qemu-devel] [PATCH] Add AACI audio playback support to the ARM Versatile/PB platform

2011-05-12 Thread Paul Brook
> On the other hand the current ac97.c implementation is a closely coupled > combination of a PCI/ACLink bridge (Intel 82801AA) with a generic AC97 > codec. This has prevent me to easily reuse this code. > > The milkymist-ac97 implementation is another case. It looks like a basic > implementation

Re: [Qemu-devel] [PATCH v3 3/6] block QMP: Drop query-block member "type" (type= in info block)

2011-05-12 Thread Luiz Capitulino
On Thu, 12 May 2011 19:12:56 +0200 Markus Armbruster wrote: > Luiz Capitulino writes: > > > On Thu, 12 May 2011 17:05:12 +0200 > > Markus Armbruster wrote: > > > >> Its value is unreliable: a block device used as floppy has type > >> "floppy" if created with if=floppy, but type "hd" if created

Re: [Qemu-devel] qdev device documentation (Re: [PATCH 0/2] usb-linux: physical port handling.)

2011-05-12 Thread Anthony Liguori
On 05/12/2011 11:18 AM, Markus Armbruster wrote: Anthony Liguori writes: On 05/12/2011 10:25 AM, Gerd Hoffmann wrote: Hi, What is the status of the qdev documentation patches btw.? http://lists.gnu.org/archive/html/qemu-devel/2011-02/msg02169.html What is the problem with the empty stri

Re: [Qemu-devel] [PATCH v3 3/6] block QMP: Drop query-block member "type" (type= in info block)

2011-05-12 Thread Markus Armbruster
Luiz Capitulino writes: > On Thu, 12 May 2011 17:05:12 +0200 > Markus Armbruster wrote: > >> Its value is unreliable: a block device used as floppy has type >> "floppy" if created with if=floppy, but type "hd" if created with >> if=none. >> >> That's because with if=none, the type is at best a

Re: [Qemu-devel] [PATCH v3 3/6] block QMP: Drop query-block member "type" (type= in info block)

2011-05-12 Thread Luiz Capitulino
On Thu, 12 May 2011 17:05:12 +0200 Markus Armbruster wrote: > Its value is unreliable: a block device used as floppy has type > "floppy" if created with if=floppy, but type "hd" if created with > if=none. > > That's because with if=none, the type is at best a declaration of > intent: the drive c

Re: [Qemu-devel] qdev device documentation (Re: [PATCH 0/2] usb-linux: physical port handling.)

2011-05-12 Thread Anthony Liguori
On 05/12/2011 11:18 AM, Markus Armbruster wrote: Anthony Liguori writes: On 05/12/2011 10:25 AM, Gerd Hoffmann wrote: Hi, What is the status of the qdev documentation patches btw.? http://lists.gnu.org/archive/html/qemu-devel/2011-02/msg02169.html What is the problem with the empty stri

Re: [Qemu-devel] qdev device documentation (Re: [PATCH 0/2] usb-linux: physical port handling.)

2011-05-12 Thread Anthony Liguori
On 05/12/2011 11:08 AM, Markus Armbruster wrote: Anthony Liguori writes: On 05/12/2011 10:25 AM, Gerd Hoffmann wrote: Hi, What is the status of the qdev documentation patches btw.? http://lists.gnu.org/archive/html/qemu-devel/2011-02/msg02169.html What is the problem with the empty stri

Re: [Qemu-devel] qdev device documentation (Re: [PATCH 0/2] usb-linux: physical port handling.)

2011-05-12 Thread Markus Armbruster
Anthony Liguori writes: > On 05/12/2011 10:25 AM, Gerd Hoffmann wrote: >> Hi, >> What is the status of the qdev documentation patches btw.? >>> >>> http://lists.gnu.org/archive/html/qemu-devel/2011-02/msg02169.html >> >> What is the problem with the empty strings btw? >> >> The only way arou

Re: [Qemu-devel] qdev device documentation (Re: [PATCH 0/2] usb-linux: physical port handling.)

2011-05-12 Thread Markus Armbruster
Anthony Liguori writes: > On 05/12/2011 10:25 AM, Gerd Hoffmann wrote: >> Hi, >> What is the status of the qdev documentation patches btw.? >>> >>> http://lists.gnu.org/archive/html/qemu-devel/2011-02/msg02169.html >> >> What is the problem with the empty strings btw? >> >> The only way arou

Re: [Qemu-devel] qdev device documentation (Re: [PATCH 0/2] usb-linux: physical port handling.)

2011-05-12 Thread Anthony Liguori
On 05/12/2011 10:56 AM, Markus Armbruster wrote: Gerd Hoffmann writes: Hi, What is the status of the qdev documentation patches btw.? http://lists.gnu.org/archive/html/qemu-devel/2011-02/msg02169.html What is the problem with the empty strings btw? Anthony ;) 1) It doesn't help us

[Qemu-devel] [Bug 723871] Re: qemu-kvm-0.14.0 Aborts with -vga qxl

2011-05-12 Thread Serge Hallyn
@Boris, The failure (in https://launchpadlibrarian.net/71569256/buildlog_ubuntu- natty-i386.qemu-kvm_0.14.0%2Bspice-v35-0ubuntu1_FAILEDTOBUILD.txt.gz) is: /build/buildd/qemu-kvm-0.14.0+spice-v35/hw/qxl.c: In function 'interface_release_resource': /build/buildd/qemu-kvm-0.14.0+spice-v35/hw/qxl.c:

Re: [Qemu-devel] qdev device documentation (Re: [PATCH 0/2] usb-linux: physical port handling.)

2011-05-12 Thread Anthony Liguori
On 05/12/2011 10:25 AM, Gerd Hoffmann wrote: Hi, What is the status of the qdev documentation patches btw.? http://lists.gnu.org/archive/html/qemu-devel/2011-02/msg02169.html What is the problem with the empty strings btw? The only way around I can see is having _DOC and _NODOC versions fo

Re: [Qemu-devel] qdev device documentation (Re: [PATCH 0/2] usb-linux: physical port handling.)

2011-05-12 Thread Markus Armbruster
Gerd Hoffmann writes: > Hi, > >>> What is the status of the qdev documentation patches btw.? >> >> http://lists.gnu.org/archive/html/qemu-devel/2011-02/msg02169.html > > What is the problem with the empty strings btw? Anthony ;) [...]

Re: [Qemu-devel] [PATCH v2 0/5] Split ide-drive and scsi-disk qdevs, and more

2011-05-12 Thread Markus Armbruster
Pasto: this is PATCH v3. Sorry.

Re: [Qemu-devel] [RFC] live snapshot, live merge, live block migration

2011-05-12 Thread Jes Sorensen
On 05/09/11 17:23, Anthony Liguori wrote: >> >> * Live snapshots and live snapshot merge >> >> Live snapshot is already incorporated (by Jes) in qemu (still need >> qemu-agent work to freeze the guest FS). > > Live snapshot is unfortunately not really "live". It runs a lot of > operations synchro

Re: [Qemu-devel] qdev device documentation (Re: [PATCH 0/2] usb-linux: physical port handling.)

2011-05-12 Thread Anthony Liguori
On 05/12/2011 10:25 AM, Gerd Hoffmann wrote: Hi, What is the status of the qdev documentation patches btw.? http://lists.gnu.org/archive/html/qemu-devel/2011-02/msg02169.html What is the problem with the empty strings btw? The only way around I can see is having _DOC and _NODOC versions fo

Re: [Qemu-devel] [RFC] live snapshot, live merge, live block migration

2011-05-12 Thread Jes Sorensen
On 05/09/11 15:40, Dor Laor wrote: > Summary: > * We need Marcelo's new (to come) block copy implementation > * should work in parallel to migration and hotplug > * General copy on read is desirable > * Live snapshot merge to be implemented using block copy > * Need to utilize a remote

Re: [Qemu-devel] [PATCH 0/4] introduce cpu_physical_memory_map_fast

2011-05-12 Thread Avi Kivity
On 05/03/2011 07:49 PM, Paolo Bonzini wrote: Paravirtualized devices (and also some real devices) can assume they are going to access RAM. For this reason, provide a fast-path function with the following properties: 1) it will never allocate a bounce buffer 2) it can be used for read-modify-wr

[Qemu-devel] [PATCH] v5 revamp acpitable parsing and allow to specify complete (headerful) table

2011-05-12 Thread Michael Tokarev
This patch almost rewrites acpi_table_add() function (but still leaves it using old get_param_value() interface). The result is that it's now possible to specify whole table (together with a header) in an external file, instead of just data portion, with a new file= parameter, but at the same time

Re: [Qemu-devel] qdev device documentation (Re: [PATCH 0/2] usb-linux: physical port handling.)

2011-05-12 Thread Gerd Hoffmann
Hi, What is the status of the qdev documentation patches btw.? http://lists.gnu.org/archive/html/qemu-devel/2011-02/msg02169.html What is the problem with the empty strings btw? The only way around I can see is having _DOC and _NODOC versions for all the property macros, but I'd prefer t

[Qemu-devel] [PATCH v3 1/6] ide: Split qdev "ide-drive" into "ide-hd" and "ide-cd"

2011-05-12 Thread Markus Armbruster
An "ide-drive" is either a hard disk or a CD-ROM, depending on the associated BlockDriverState's type hint. Unclean; disk vs. CD belongs to the guest part, not the host part. Have separate qdevs "ide-hd" and "ide-cd" to model disk vs. CD in the guest part. Keep ide-drive for backward compatibili

[Qemu-devel] [PATCH v2 0/5] Split ide-drive and scsi-disk qdevs, and more

2011-05-12 Thread Markus Armbruster
This patch series is about purging the "type hint" from the block layer. My previous series cleaned up improper uses it. Remaining uses are info block and qdevs ide-drive, scsi-disk. ide-drive and scsi-disk can either act as disk or as CD drive. They use their drive's type hint to decide betwee

Re: [Qemu-devel] [PATCH v2 0/5] Split ide-drive and scsi-disk qdevs, and more

2011-05-12 Thread Markus Armbruster
Kevin Wolf writes: > Am 09.05.2011 11:51, schrieb Markus Armbruster: >> This patch series is about purging the "type hint" from the block >> layer. My previous series cleaned up improper uses it. Remaining >> uses are info block and qdevs ide-drive, scsi-disk. >> >> ide-drive and scsi-disk can

[Qemu-devel] [PATCH v3 2/6] scsi: Split qdev "scsi-disk" into "scsi-hd" and "scsi-cd"

2011-05-12 Thread Markus Armbruster
A "scsi-disk" is either a hard disk or a CD-ROM, depending on the associated BlockDriverState's type hint. Unclean; disk vs. CD belongs to the guest part, not the host part. Have separate qdevs "scsi-hd" and "scsi-cd" to model disk vs. CD in the guest part. Keep scsi-disk for backward compatibil

[Qemu-devel] [PATCH v3 3/6] block QMP: Drop query-block member "type" (type= in info block)

2011-05-12 Thread Markus Armbruster
Its value is unreliable: a block device used as floppy has type "floppy" if created with if=floppy, but type "hd" if created with if=none. That's because with if=none, the type is at best a declaration of intent: the drive can be connected to any guest device. Its type is really the guest device'

[Qemu-devel] [PATCH v3 6/6] defaults: ide-cd and scsi-cd devices suppress default CD-ROM

2011-05-12 Thread Markus Armbruster
ide-hd does *not* suppress the default CD-ROM, unlike legacy ide-drive. scsi-cd *does* suppress it, unlike legacy scsi-disk. Signed-off-by: Markus Armbruster --- vl.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/vl.c b/vl.c index 6b9a2f6..8bd7cc6 100644 --- a/vl.c +

[Qemu-devel] [PATCH v3 5/6] block: Remove type hint, it's guest matter, doesn't belong here

2011-05-12 Thread Markus Armbruster
No users of bdrv_get_type_hint() left. bdrv_set_type_hint() can make the media removable by side effect. Make that explicit. Signed-off-by: Markus Armbruster --- block.c | 12 block.h |5 - block_int.h |1 - blockdev.c |4 ++-- 4 files changed, 2 inserti

[Qemu-devel] [PATCH v3 4/6] blockdev: Store -drive option media in DriveInfo

2011-05-12 Thread Markus Armbruster
DriveInfo is closely tied to -drive, and like -drive, it mixes information about host and guest part of the block device. Unlike DriveInfo, BlockDriverState should be about the host part only. One of the remaining guest bits there is the "type hint". -drive option media sets it, and qdevs "ide-d

Re: [Qemu-devel] [PATCH 1/2] Add documentation for qemu_progres_print()

2011-05-12 Thread Avi Kivity
On 05/06/2011 06:10 PM, Markus Armbruster wrote: Here's my try: /* * Report progress. * @percent is how much progress we made. * If @max is zero, @percent is how much of the job is done. * Else, @percent is a progress delta since the last call, as a fraction * of @max. I.e. delta is @

Re: [Qemu-devel] TCG: AREG0 removal planning

2011-05-12 Thread Avi Kivity
On 05/11/2011 08:25 PM, Blue Swirl wrote: > > I think a useful, and incremental goal is elimination of global cpu_env state > in C code (i.e eliminate HELPER_CFLAGS and dyngen-exec.h). > We already have much of the infrastructure for this - op_helper v.s. helper.c > and code_gen_prologue for

Re: [Qemu-devel] [PATCH 0/4] introduce cpu_physical_memory_map_fast

2011-05-12 Thread Paolo Bonzini
On 05/03/2011 06:49 PM, Paolo Bonzini wrote: Paravirtualized devices (and also some real devices) can assume they are going to access RAM. For this reason, provide a fast-path function with the following properties: 1) it will never allocate a bounce buffer 2) it can be used for read-modify-wr

Re: [Qemu-devel] [PATCH] Add an isa device for SGA

2011-05-12 Thread Gerd Hoffmann
On 05/11/11 19:11, Glauber Costa wrote: This patch adds a dummy legacy ISA device whose responsibility is to deploy sgabios, an option rom for a serial graphics adapter. The proposal is that this device is always-on when -nographics, but can otherwise be enable in any setup when -device sga is us

[Qemu-devel] [PATCH] set $SDL_VIDEODRIVER=x11 on Linux to prevent sudo kvm from fighting for video card

2011-05-12 Thread Michael Tokarev
This is a resend of email sent 08.05.2011 01:18. On Linux, SDL may use fbcon|directfb|svgalib when run without accessible $DISPLAY to open X11 window. This is often the case when qemu is run using sudo. But in this case, and when actually run in X11 environment, SDL fights with X11 for the video

Re: [Qemu-devel] [RFC] live snapshot, live merge, live block migration

2011-05-12 Thread Marcelo Tosatti
On Mon, May 09, 2011 at 10:23:03AM -0500, Anthony Liguori wrote: > On 05/09/2011 08:40 AM, Dor Laor wrote: > >No patch here (sorry) but collection of thoughts about these features > >and their potential building blocks. Please review (also on > >http://wiki.qemu.org/Features/LiveBlockMigration) > >

Re: [Qemu-devel] -net interface association behavior change in current -git.

2011-05-12 Thread Markus Armbruster
Rob Landley writes: > In 1.14.0, if I did this: > > qemu -net nic,blah -net user -net nic,blah -net tun,blah > > Then the first nic would be -net user, and the second nic would be -net > tun.In current -git, -net user attaches to the second interface and > -net tun attaches to the first, I.

Re: [Qemu-devel] [PULL] Xen HVM support

2011-05-12 Thread Alexander Graf
Am 12.05.2011 um 15:39 schrieb Stefano Stabellini : > On Thu, 12 May 2011, Anthony Liguori wrote: >> On 05/09/2011 12:39 PM, Alexander Graf wrote: >>> Hi Anthony, >>> >>> These are Anthony's patches for Xen HVM support, nicely signed off, >>> rebased to fit today's HEAD and compile tested. >>>

Re: [Qemu-devel] [PULL] Xen HVM support

2011-05-12 Thread Stefano Stabellini
On Thu, 12 May 2011, Anthony Liguori wrote: > On 05/09/2011 12:39 PM, Alexander Graf wrote: > > Hi Anthony, > > > > These are Anthony's patches for Xen HVM support, nicely signed off, > > rebased to fit today's HEAD and compile tested. > > > > Please pull. > > Pulled. Thanks. popping champagne o

Re: [Qemu-devel] [PULL] Trivial patches for April 26 to May 8 2011

2011-05-12 Thread Anthony Liguori
On 05/08/2011 11:04 AM, Stefan Hajnoczi wrote: The following changes since commit 3964f535c35c08470ac69bd553282af500bc8bb0: Merge remote-tracking branch 'mst/for_anthony' into staging (2011-05-05 13:05:32 -0500) are available in the git repository at: git://repo.or.cz/qemu/stefanha.git

Re: [Qemu-devel] [PULL] Xen HVM support

2011-05-12 Thread Anthony Liguori
On 05/09/2011 12:39 PM, Alexander Graf wrote: Hi Anthony, These are Anthony's patches for Xen HVM support, nicely signed off, rebased to fit today's HEAD and compile tested. Please pull. Pulled. Thanks. Regards, Anthony Liguori Alex The following changes since commit 85097db6956bc86e2

Re: [Qemu-devel] -net interface association behavior change in current -git.

2011-05-12 Thread Vincent Palatin
Hi, On Wed, May 11, 2011 at 22:39, Rob Landley wrote: > In 1.14.0, if I did this: > >  qemu -net nic,blah -net user -net nic,blah -net tun,blah > > Then the first nic would be -net user, and the second nic would be -net > tun.    In current -git, -net user attaches to the second interface and > -

Re: [Qemu-devel] [PATCH] Add warmup phase for live migration of large memory apps

2011-05-12 Thread Anthony Liguori
On 05/12/2011 06:23 AM, Shribman, Aidan wrote: From: Juan Quintela [mailto:quint...@redhat.com] If there are no additional dirty pages to be sent i.e. ram_save_remaining() == 0 then the migration *will* converge (even though we don't want it to) see: This should be a really idle guest to have

Re: [Qemu-devel] [PULL] Trivial patches for April 26 to May 8 2011

2011-05-12 Thread Paolo Bonzini
On 05/08/2011 06:04 PM, Stefan Hajnoczi wrote: The following changes since commit 3964f535c35c08470ac69bd553282af500bc8bb0: Merge remote-tracking branch 'mst/for_anthony' into staging (2011-05-05 13:05:32 -0500) are available in the git repository at: git://repo.or.cz/qemu/stefanha.git

[Qemu-devel] [PATCH v2] Add an isa device for SGA

2011-05-12 Thread Glauber Costa
This patch adds a dummy legacy ISA device whose responsibility is to deploy sgabios, an option rom for a serial graphics adapter. The proposal is that this device is always-on when -nographics, but can otherwise be enable in any setup when -device sga is used. [v2: suggestions on qdev by Markus ]

[Qemu-devel] [PATCH] Avoid segmentation fault for qdev device not found

2011-05-12 Thread Glauber Costa
qdev_try_create will cope well with a NULL bus, since it will assume the main system bus by default. qdev_create, however, wants to print a message, in which it instantiates the bus name. That simple and at first inoffensive message will generate a segmentation found if the reason for failure is a

[Qemu-devel] [Bug 723871] Re: qemu-kvm-0.14.0 Aborts with -vga qxl

2011-05-12 Thread Boris Derzhavets
** Attachment added: "qemu-kvm_0.14.0+spice-v35-0ubuntu1_amd64.deb" https://bugs.launchpad.net/qemu/+bug/723871/+attachment/2125647/+files/qemu-kvm_0.14.0%2Bspice-v35-0ubuntu1_amd64.deb -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QE

[Qemu-devel] [Bug 723871] Re: qemu-kvm-0.14.0 Aborts with -vga qxl

2011-05-12 Thread Boris Derzhavets
** Attachment added: "qemu_0.14.0+spice-v35-0ubuntu1_amd64.deb" https://bugs.launchpad.net/qemu/+bug/723871/+attachment/2125645/+files/qemu_0.14.0%2Bspice-v35-0ubuntu1_amd64.deb -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. http

[Qemu-devel] [Bug 723871] Re: qemu-kvm-0.14.0 Aborts with -vga qxl

2011-05-12 Thread Boris Derzhavets
** Attachment added: "qemu-common_0.14.0+spice-v35-0ubuntu1_all.deb" https://bugs.launchpad.net/qemu/+bug/723871/+attachment/2125646/+files/qemu-common_0.14.0%2Bspice-v35-0ubuntu1_all.deb -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to

[Qemu-devel] [Bug 723871] Re: qemu-kvm-0.14.0 Aborts with -vga qxl

2011-05-12 Thread Boris Derzhavets
I386 build constantly fails in my PPA https://launchpad.net/~bderzhavets/+archive/git-spice. Build on local box ( Q9550,8 GB ) Ubuntu 11.04 (64-bit) debuild -rfakeroot -b -k930900E6 | tee build-v35.log doesn't have any problems with ./hw/qxl.c. I attached log and packages ** Attachment added:

Re: [Qemu-devel] [PATCH v2 4/4] coroutine: pool coroutines to speed up creation

2011-05-12 Thread Stefan Hajnoczi
On Thu, May 12, 2011 at 12:18 PM, Paolo Bonzini wrote: > On 05/12/2011 01:15 PM, Stefan Hajnoczi wrote: >> >> It's just for completeness to make tools like valgrind happy.  Sure, >> the kernel will reclaim memory and we're just burning CPU by freeing >> this stuff;). > > But valgrind will not comp

Re: [Qemu-devel] [PATCH] Add warmup phase for live migration of large memory apps

2011-05-12 Thread Shribman, Aidan
> From: Juan Quintela [mailto:quint...@redhat.com] > > > If there are no additional dirty pages to be sent > > i.e. ram_save_remaining() == 0 then the migration *will* converge > > (even though we don't want it to) see: > > This should be a really idle guest to have that O:-) > > But if that is

  1   2   >