[Qemu-devel] [Bug 524447] Re: virsh save is very slow

2011-07-27 Thread Michael Tokarev
I see activity around this bug is going on and on, but I don't understand -- is the talk about this patch -- http://anonscm.debian.org/gitweb/?p=collab-maint/qemu-kvm.git;a=commit;h=7e32b4ca0ea280a2e8f4d9ace1a15d5e633d9a95 ? -- You received this bug notification because you are a member of qemu

[Qemu-devel] [PATCH v2 1/5] balloon: Don't allow multiple balloon handler registrations

2011-07-27 Thread Amit Shah
Multiple balloon devices don't make sense; disallow more than one registration attempt to register handlers. Signed-off-by: Amit Shah --- balloon.c | 12 ++-- balloon.h |4 ++-- 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/balloon.c b/balloon.c index a938475..520

[Qemu-devel] [PATCH v2 4/5] virtio-balloon: Add exit handler, fix memleaks

2011-07-27 Thread Amit Shah
Add an exit handler that will free up RAM and unregister the savevm section after a virtio-balloon device is unplugged. Signed-off-by: Amit Shah --- hw/virtio-balloon.c |5 + hw/virtio-pci.c | 11 ++- hw/virtio.h |1 + 3 files changed, 16 insertions(+), 1 deleti

[Qemu-devel] [PATCH v2 3/5] balloon: Ignore negative balloon values

2011-07-27 Thread Amit Shah
Negative balloon values don't make sense, ignore them. Reported-by: Mike Cao Signed-off-by: Amit Shah --- balloon.c |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/balloon.c b/balloon.c index 5200565..f56fdc1 100644 --- a/balloon.c +++ b/balloon.c @@ -140,6 +140,

[Qemu-devel] [PATCH v2 5/5] virtio-balloon: Unregister savevm section on device unplug

2011-07-27 Thread Amit Shah
Migrating after unplugging a virtio-balloon device resulted in an error message on the destination: Unknown savevm section or instance ':00:04.0/virtio-balloon' 0 load of migration failed Fix this by unregistering the section on device unplug. Signed-off-by: Amit Shah --- hw/virtio-balloon

Re: [Qemu-devel] [PATCH v2 4/5] virtio-balloon: Add exit handler, fix memleaks

2011-07-27 Thread Amit Shah
On (Thu) 28 Jul 2011 [11:47:15], Amit Shah wrote: > Add an exit handler that will free up RAM and unregister the savevm > section after a virtio-balloon device is unplugged. This commit message should be changed; I'll do that in the pull request I send out. Amit

[Qemu-devel] [PATCH v2 2/5] virtio-balloon: Check if balloon registration failed

2011-07-27 Thread Amit Shah
Multiple balloon registrations are not allowed; check if the registration with the qemu balloon api succeeded. If not, fail the device init. Signed-off-by: Amit Shah --- hw/virtio-balloon.c |9 - hw/virtio-pci.c |3 +++ 2 files changed, 11 insertions(+), 1 deletions(-) diff

[Qemu-devel] [PATCH v2 0/5] balloon: fix memleaks, invalid arguments, unplug

2011-07-27 Thread Amit Shah
Hello, This series is on top of the other balloon series for which I sent a pull request on Tuesday. This series fixes memleak on exit, unregisters the savevm section on unplug, disallows negative values as ballooning targets and doesn't allow multiple balloon device registrations. v2 contains s

Re: [Qemu-devel] [PATCH v2 1/1] The codes V2 for QEMU disk I/O limits.

2011-07-27 Thread Zhi Yong Wu
On Wed, Jul 27, 2011 at 8:58 PM, Stefan Hajnoczi wrote: > On Wed, Jul 27, 2011 at 11:17 AM, Zhi Yong Wu wrote: >> On Wed, Jul 27, 2011 at 3:26 AM, Marcelo Tosatti wrote: >>> On Tue, Jul 26, 2011 at 04:59:06PM +0800, Zhi Yong Wu wrote: Welcome to give me your comments, thanks. Sign

[Qemu-devel] [Bug 524447] Re: virsh save is very slow

2011-07-27 Thread Chris Halse Rogers
Serge - why do you think this can't be SRU'd? It's already been accepted into lucid-proposed once, then verified, and the only reason it's not in lucid-updates is that it got superseded by a security upload before the 7-day testing period had elapsed. If you made a new upload to lucid-proposed ba

Re: [Qemu-devel] [PATCH 1/1] balloon: Ignore negative balloon values

2011-07-27 Thread Amit Shah
On (Wed) 27 Jul 2011 [15:49:18], Markus Armbruster wrote: > Amit Shah writes: > > > Negative balloon values don't make sense, ignore them. > > > > Reported-by: Mike Cao > > Signed-off-by: Amit Shah > > --- > > I'm not sure if error_report is the right thing to use or should a new > > qerror_rep

Re: [Qemu-devel] [PATCH v2 1/1] The codes V2 for QEMU disk I/O limits.

2011-07-27 Thread Zhi Yong Wu
On Wed, Jul 27, 2011 at 11:49 PM, Marcelo Tosatti wrote: > On Wed, Jul 27, 2011 at 06:17:15PM +0800, Zhi Yong Wu wrote: >> >> +        wait_time = 1; >> >> +    } >> >> + >> >> +    wait_time = wait_time + (slice_time - elapsed_time); >> >> +    if (wait) { >> >> +        *wait = wait_time * BLOCK

Re: [Qemu-devel] RFC: moving fsfreeze support from the userland guest agent to the guest kernel

2011-07-27 Thread Fernando Luis Vázquez Cao
On Wed, 2011-07-27 at 17:24 +0200, Andrea Arcangeli wrote: > making > sure no lib is calling any I/O function to be able to defreeze the > filesystems later, making sure the oom killer or a wrong kill -9 > $RANDOM isn't killing the agent by mistake while the I/O is blocked > and the copy is going.

Re: [Qemu-devel] [PATCH v2 1/1] The codes V2 for QEMU disk I/O limits.

2011-07-27 Thread Zhi Yong Wu
On Wed, Jul 27, 2011 at 8:58 PM, Stefan Hajnoczi wrote: > On Wed, Jul 27, 2011 at 11:17 AM, Zhi Yong Wu wrote: >> On Wed, Jul 27, 2011 at 3:26 AM, Marcelo Tosatti wrote: >>> On Tue, Jul 26, 2011 at 04:59:06PM +0800, Zhi Yong Wu wrote: Welcome to give me your comments, thanks. Sign

Re: [Qemu-devel] 0.15.0 Testing volunteers

2011-07-27 Thread Zhi Yong Wu
OK. i will do it. thanks. On Wed, Jul 27, 2011 at 10:45 PM, Stefan Hajnoczi wrote: > On Wed, Jul 27, 2011 at 3:37 AM, Zhi Yong Wu wrote: >> For networking and migration areas, is there any new feature to be >> tested? If yes, can i be their testing volunteer? >> >> If QMP has not a voluntter, i

Re: [Qemu-devel] [RFC][PATCH 0/21] QEMU Object Model

2011-07-27 Thread Anthony Liguori
On 07/27/2011 04:33 PM, Peter Maydell wrote: On 26 July 2011 15:02, Anthony Liguori wrote: In my attempt at PCI modelling, I had something like: struct I440FX { Device parent; PciDevice slots[32]; }; Which means that to attach to bus 0, slot 3, fn 0, you do: i440fx->slots[3] = mydevic

Re: [Qemu-devel] [RFC] Introduce vm_stop_permanent()

2011-07-27 Thread Blue Swirl
On Wed, Jul 27, 2011 at 9:42 PM, Luiz Capitulino wrote: > This function should be used when the VM is not supposed to resume > execution (eg. by issuing 'cont' monitor command). > > Today, we allow the user to resume execution even when: > >  o the guest shuts down and -no-shutdown is used >  o th

Re: [Qemu-devel] MinGW compilation shouldn't include -lglib-2.0 etc.

2011-07-27 Thread Jernej Simončič
On Wednesday, July 27, 2011, 22:46:41, Kenneth Salerno wrote: > c:/devel/target/ea4ef54bcf881bcdd4139385601018a2/lib/glib-2.0/include: No > such file or directory This happens if you're not using mingw's pkg-config (which automatically adjusts prefix) - you'll have to edit your .pc files. -- <

Re: [Qemu-devel] [PATCH v3] Add support for fd: protocol

2011-07-27 Thread Blue Swirl
On Tue, Jul 26, 2011 at 3:51 PM, Corey Bryant wrote: > sVirt provides SELinux MAC isolation for Qemu guest processes and their > corresponding resources (image files). sVirt provides this support > by labeling guests and resources with security labels that are stored > in file system extended attr

Re: [Qemu-devel] [RFC][PATCH 0/21] QEMU Object Model

2011-07-27 Thread Peter Maydell
On 26 July 2011 15:02, Anthony Liguori wrote: > In my attempt at PCI modelling, I had something like: > > struct I440FX > { >   Device parent; > >   PciDevice slots[32]; > }; > > Which means that to attach to bus 0, slot 3, fn 0, you do: > > i440fx->slots[3] = mydevice So what I don't really unde

Re: [Qemu-devel] [PATCH] [RFC] Add glib support to main loop

2011-07-27 Thread Anthony Liguori
On 07/27/2011 04:21 PM, Stefan Weil wrote: NDEBUG is normally set automatically for production code, and it disables assertions which is not always good. Assertions are useful even in production code unless you are sure that the code is bug free or the assertions cost to much resources - either

Re: [Qemu-devel] [PATCH] MinGW compilation shouldn't include -lglib-2.0 etc.

2011-07-27 Thread Kenneth Salerno
--- On Wed, 7/27/11, Stefan Weil wrote: > From: Stefan Weil > Subject: Re: [Qemu-devel] [PATCH] MinGW compilation shouldn't include > -lglib-2.0 etc. > To: "Kenneth Salerno" > Cc: qemu-devel@nongnu.org > Date: Wednesday, July 27, 2011, 5:13 PM > Am 27.07.2011 22:46, schrieb Kenneth > Salerno:

Re: [Qemu-devel] [PATCH] [RFC] Add glib support to main loop

2011-07-27 Thread Anthony Liguori
On 07/27/2011 04:12 PM, Blue Swirl wrote: On Wed, Jul 27, 2011 at 11:48 PM, Anthony Liguori wrote: On 07/27/2011 03:43 PM, Blue Swirl wrote: On Wed, Jul 27, 2011 at 3:06 AM, Anthony Liguori wrote: This allows GSources to be used to register callback events in QEMU. This is useful as it

Re: [Qemu-devel] [PATCH] [RFC] Add glib support to main loop

2011-07-27 Thread Stefan Weil
Am 27.07.2011 23:12, schrieb Blue Swirl: On Wed, Jul 27, 2011 at 11:48 PM, Anthony Liguori wrote: On 07/27/2011 03:43 PM, Blue Swirl wrote: On Wed, Jul 27, 2011 at 3:06 AM, Anthony Liguori wrote: This allows GSources to be used to register callback events in QEMU. This i

Re: [Qemu-devel] [PATCH] MinGW compilation shouldn't include -lglib-2.0 etc.

2011-07-27 Thread Stefan Weil
Am 27.07.2011 22:46, schrieb Kenneth Salerno: I'll have to fall back to my old plan of compiling glib2 and gettext myself to install into prefix /usr/i686-pc-mingw32/sys-root/mingw (Cygwin doesn't distribute a MinGW version of glib2, and the one available on gtk.org gives me this error "cc1: w

Re: [Qemu-devel] [PATCH] [RFC] Add glib support to main loop

2011-07-27 Thread Blue Swirl
On Wed, Jul 27, 2011 at 11:48 PM, Anthony Liguori wrote: > On 07/27/2011 03:43 PM, Blue Swirl wrote: >> >> On Wed, Jul 27, 2011 at 3:06 AM, Anthony Liguori >>  wrote: >>> >>> This allows GSources to be used to register callback events in QEMU. >>>  This is >>> useful as it allows us to take greate

Re: [Qemu-devel] [PATCH] MinGW compilation shouldn't include -lglib-2.0 etc.

2011-07-27 Thread Anthony Liguori
On 07/27/2011 03:46 PM, Kenneth Salerno wrote: -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -

Re: [Qemu-devel] [PATCH] [RFC] Add glib support to main loop

2011-07-27 Thread Anthony Liguori
On 07/27/2011 03:43 PM, Blue Swirl wrote: On Wed, Jul 27, 2011 at 3:06 AM, Anthony Liguori wrote: This allows GSources to be used to register callback events in QEMU. This is useful as it allows us to take greater advantage of glib and also because it allows us to write code that is more easil

Re: [Qemu-devel] [PATCH] MinGW compilation shouldn't include -lglib-2.0 etc.

2011-07-27 Thread Kenneth Salerno
--- On Wed, 7/27/11, Daniel P. Berrange wrote: > From: Daniel P. Berrange > Subject: Re: [Qemu-devel] [PATCH] MinGW compilation shouldn't include > -lglib-2.0 etc. > To: "Kenneth Salerno" > Cc: qemu-devel@nongnu.org > Date: Wednesday, July 27, 2011, 11:56 AM > On Wed, Jul 27, 2011 at 08:50:23A

Re: [Qemu-devel] [PATCH] [RFC] Add glib support to main loop

2011-07-27 Thread Blue Swirl
On Wed, Jul 27, 2011 at 3:06 AM, Anthony Liguori wrote: > This allows GSources to be used to register callback events in QEMU.  This is > useful as it allows us to take greater advantage of glib and also because it > allows us to write code that is more easily testable outside of QEMU since we > c

Re: [Qemu-devel] [RFC][PATCH 0/21] QEMU Object Model

2011-07-27 Thread Anthony Liguori
On 07/27/2011 01:51 PM, Paolo Bonzini wrote: On 07/27/2011 06:28 PM, Anthony Liguori wrote: On 07/27/2011 10:33 AM, Paolo Bonzini wrote: On 07/27/2011 02:48 PM, Anthony Liguori wrote: So the idea here is that the PIC will multiplex a bunch of interrupts into a single line? Yes, but the devi

Re: [Qemu-devel] [PATCH 1/2] linux aio: support flush operation

2011-07-27 Thread Christoph Hellwig
On Wed, Jul 27, 2011 at 09:52:51PM +0200, Frediano Ziglio wrote: > > > > Yes! Not at kernel level :-) In that case we have a bad error handling problem somewhere in qemu. the IOCB_CMD_FDSYNC aio opcode will always return EINVAL currently, and we really should have cought that somewhere in qemu.

Re: [Qemu-devel] [PATCH 1/2] linux aio: support flush operation

2011-07-27 Thread Frediano Ziglio
Il giorno 27/lug/2011, alle ore 20:31, Christoph Hellwig ha scritto: > Did you test this at all? > Yes! Not at kernel level :-) Usually I trust documentation and man pages. > On Wed, Jul 27, 2011 at 08:25:25PM +0200, Frediano Ziglio wrote: >> +case QEMU_AIO_FLUSH: >> +io_prep_fds

Re: [Qemu-devel] RFC: moving fsfreeze support from the userland guest agent to the guest kernel

2011-07-27 Thread Andrea Arcangeli
On Wed, Jul 27, 2011 at 08:36:10PM +0200, Christoph Hellwig wrote: > Initiating the freeze from kernelspace doesn't make much sense. With > virtio we could add in-band freeze request to the protocol, and although > that would be a major change in that way virtio-blk works right now it's > at least

Re: [Qemu-devel] [RFC][PATCH 0/21] QEMU Object Model

2011-07-27 Thread Paolo Bonzini
On 07/27/2011 06:28 PM, Anthony Liguori wrote: On 07/27/2011 10:33 AM, Paolo Bonzini wrote: On 07/27/2011 02:48 PM, Anthony Liguori wrote: So the idea here is that the PIC will multiplex a bunch of interrupts into a single line? Yes, but the device needs to know the interrupt number so it ca

[Qemu-devel] [RFC] Introduce vm_stop_permanent()

2011-07-27 Thread Luiz Capitulino
This function should be used when the VM is not supposed to resume execution (eg. by issuing 'cont' monitor command). Today, we allow the user to resume execution even when: o the guest shuts down and -no-shutdown is used o there's a kvm internal error o loading the VM state with -loadvm or "l

Re: [Qemu-devel] RFC: moving fsfreeze support from the userland guest agent to the guest kernel

2011-07-27 Thread Christoph Hellwig
Initiating the freeze from kernelspace doesn't make much sense. With virtio we could add in-band freeze request to the protocol, and although that would be a major change in that way virtio-blk works right now it's at least doable. But all other "real" storage targets only communicate with their

Re: [Qemu-devel] [PATCH 2/2] aio: use Linux AIO even if nocache is not specified

2011-07-27 Thread Christoph Hellwig
On Wed, Jul 27, 2011 at 08:25:26PM +0200, Frediano Ziglio wrote: > Currently Linux AIO are used only if nocache is specified. > Linux AIO works in all cases. The only problem is that currently Linux AIO > does not align data so I add a test that use POSIX AIO in this case. The kernel will accept b

Re: [Qemu-devel] [PATCH 1/2] linux aio: support flush operation

2011-07-27 Thread Christoph Hellwig
Did you test this at all? On Wed, Jul 27, 2011 at 08:25:25PM +0200, Frediano Ziglio wrote: > +case QEMU_AIO_FLUSH: > +io_prep_fdsync(iocbs, fd); > +break; Looks great, but doesn't work as expected. Hint: grep for aio_fsync in the linux kernel.

[Qemu-devel] [PATCH 2/2] aio: use Linux AIO even if nocache is not specified

2011-07-27 Thread Frediano Ziglio
Currently Linux AIO are used only if nocache is specified. Linux AIO works in all cases. The only problem is that currently Linux AIO does not align data so I add a test that use POSIX AIO in this case. Signed-off-by: Frediano Ziglio --- block/raw-posix.c | 23 ++- 1 files

[Qemu-devel] [PATCH 1/2] linux aio: support flush operation

2011-07-27 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- block/raw-posix.c |7 +++ linux-aio.c |3 +++ 2 files changed, 10 insertions(+), 0 deletions(-) diff --git a/block/raw-posix.c b/block/raw-posix.c index 3c6bd4b..27ae81e 100644 --- a/block/raw-posix.c +++ b/block/raw-posix.c @@ -628,6 +628,13

[Qemu-devel] [PATCH 0/2] improve Linux AIO support

2011-07-27 Thread Frediano Ziglio
These patches avoid many fallbacks to POSIX AIO and enable Linux AIO even if nocache is not specified. Also add flush support with Linux AIO. Frediano Ziglio (2): linux aio: support flush operation aio: use Linux AIO even if nocache is not specified block/raw-posix.c | 30 +

[Qemu-devel] [Bug 524447] Re: virsh save is very slow

2011-07-27 Thread Jeff Snider
The page you referenced doesn't include anything that I can find about the ticket priority level. It states that "Stable release updates will, in general, only be issued in order to fix high-impact bugs" and provides several examples. Among them is "Bugs which do not fit under above categories, [

[Qemu-devel] [PATCH 3/3] aio: always check paio_init result

2011-07-27 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- block/raw-posix.c | 11 +-- 1 files changed, 5 insertions(+), 6 deletions(-) diff --git a/block/raw-posix.c b/block/raw-posix.c index 275b41e..3c6bd4b 100644 --- a/block/raw-posix.c +++ b/block/raw-posix.c @@ -230,13 +230,15 @@ static int raw_open_co

[Qemu-devel] [PATCH 2/3] block: typo fix

2011-07-27 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- block/raw-posix.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/block/raw-posix.c b/block/raw-posix.c index cd89c83..275b41e 100644 --- a/block/raw-posix.c +++ b/block/raw-posix.c @@ -587,7 +587,7 @@ static BlockDriverAIOCB *raw_aio_

[Qemu-devel] [PATCH 1/3] block: removed unused function

2011-07-27 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- block.c | 13 - block.h |2 -- 2 files changed, 0 insertions(+), 15 deletions(-) diff --git a/block.c b/block.c index 9549b9e..b2d3983 100644 --- a/block.c +++ b/block.c @@ -1108,19 +1108,6 @@ int bdrv_pwrite_sync(BlockDriverState *bs, int64_

[Qemu-devel] [PATCH 0/3] small trivial patches

2011-07-27 Thread Frediano Ziglio
Minor fixes and improves Frediano Ziglio (3): block: removed unused function block: typo fix aio: always check paio_init result block.c | 13 - block.h |2 -- block/raw-posix.c | 13 ++--- 3 files changed, 6 insertions(+), 22 deletions(-)

[Qemu-devel] [PATCH] virtio-pci: use generic logic for command access

2011-07-27 Thread Michael S. Tsirkin
In practice, guests don't generate config requests that cross a word boundary, so the logic to detect command word access is correct because PCI_COMMAND is 0x4. But depending on this is tricky, further, it will break with guests that do try to generate a misaligned access as we pass it to devices w

Re: [Qemu-devel] RFC: moving fsfreeze support from the userland guest agent to the guest kernel

2011-07-27 Thread Andrea Arcangeli
On Wed, Jul 27, 2011 at 11:34:44AM -0500, Anthony Liguori wrote: > Currently, QEMU doesn't know about fsfreeze. I don't think it ever will > either. Ah, sorry thanks for the correction, it's some other repo that you were modifying (qga). > One challenge though is that it's highly desirable to h

Re: [Qemu-devel] RFC: moving fsfreeze support from the userland guest agent to the guest kernel

2011-07-27 Thread Andrea Arcangeli
Hello Michael, On Wed, Jul 27, 2011 at 11:07:13AM -0500, Michael Roth wrote: > One thing worth mentioning is that the current host-side interface to > the guest agent is not what we're hoping to build libvirt interfaces > around. It's a standalone, out-of-band tool for now, but when QMP is > co

Re: [Qemu-devel] RFC: moving fsfreeze support from the userland guest agent to the guest kernel

2011-07-27 Thread Anthony Liguori
On 07/27/2011 10:24 AM, Andrea Arcangeli wrote: Hello everyone, I've been thinking at the current design of the fsfreeze feature used by libvirt. It currently relays on an userland agent in the guest talking to qemu with some vmchannel communication. The guest agent would walk the filesystems i

Re: [Qemu-devel] [RFC][PATCH 0/21] QEMU Object Model

2011-07-27 Thread Anthony Liguori
On 07/27/2011 10:33 AM, Paolo Bonzini wrote: On 07/27/2011 02:48 PM, Anthony Liguori wrote: So the idea here is that the PIC will multiplex a bunch of interrupts into a single line? Yes, but the device needs to know the interrupt number so it can expose it through the enumerator interface. So

[Qemu-devel] Defaulting SD_OPTS to cache=writeback

2011-07-27 Thread David Gilbert
Hi, Write performance on the SD emulation on ARM is rather painful with the default empty SD_OPTS; it's getting something like 130KB/s on the vexpress model With cache=writeback this goes up to a sensible 8MB/s. (This is with the file on an LUKS encrypted lvm partition that is my home directory

[Qemu-devel] [Bug 524447] Re: virsh save is very slow

2011-07-27 Thread Serge Hallyn
I'm sorry - per the rules listed in https://wiki.ubuntu.com/StableReleaseUpdates, only bugs which are >= high priority are eligible for SRU. If you feel this bug should be high priority, please say so (with rationale) here. An updated package for lucid through natty will be placed in the ubuntu- v

[Qemu-devel] [PATCH -V2] coroutine: Add CoRwlock support

2011-07-27 Thread Aneesh Kumar K.V
Signed-off-by: Aneesh Kumar K.V --- qemu-coroutine-lock.c | 44 qemu-coroutine.h | 12 2 files changed, 56 insertions(+), 0 deletions(-) diff --git a/qemu-coroutine-lock.c b/qemu-coroutine-lock.c index 5071fb8..b7d01d1 100644 ---

Re: [Qemu-devel] [RFC][PATCH 0/21] QEMU Object Model

2011-07-27 Thread Anthony Liguori
On 07/27/2011 10:33 AM, Paolo Bonzini wrote: On 07/27/2011 02:48 PM, Anthony Liguori wrote: So the idea here is that the PIC will multiplex a bunch of interrupts into a single line? Yes, but the device needs to know the interrupt number so it can expose it through the enumerator interface. So

Re: [Qemu-devel] [PATCH 21/28] PPC: E500: Add PV spinning code

2011-07-27 Thread Scott Wood
On Wed, 27 Jul 2011 15:34:31 +0200 Alexander Graf wrote: > On 07/25/2011 10:40 PM, Scott Wood wrote: > > On Sat, 23 Jul 2011 12:50:05 +0200 > > Alexander Graf wrote: > > > >> +typedef struct spin_info { > >> +uint64_t addr; > >> +uint64_t r3; > >> +uint32_t resv; > >> +uint32_t p

Re: [Qemu-devel] RFC: moving fsfreeze support from the userland guest agent to the guest kernel

2011-07-27 Thread Michael Roth
On 07/27/2011 10:24 AM, Andrea Arcangeli wrote: Hello everyone, I've been thinking at the current design of the fsfreeze feature used by libvirt. It currently relays on an userland agent in the guest talking to qemu with some vmchannel communication. The guest agent would walk the filesystems i

Re: [Qemu-devel] [PATCH 15/21] qom: add Device class

2011-07-27 Thread Anthony Liguori
On 07/27/2011 10:10 AM, Peter Maydell wrote: On 25 July 2011 02:44, Anthony Liguori wrote: Device is meant to replace DeviceState as the root class for the device model. This is included here merely as a RFC. Device adds a couple of useful features. 1) Default hard reset. Device will literal

Re: [Qemu-devel] [V5 Patch 3/4]Qemu: Command "block_set" for dynamic block params change

2011-07-27 Thread Anthony Liguori
On 07/27/2011 09:31 AM, Stefan Hajnoczi wrote: On Wed, Jul 27, 2011 at 1:58 PM, Anthony Liguori wrote: Index: qemu/hmp-commands.hx === --- qemu.orig/hmp-commands.hx +++ qemu/hmp-commands.hx @@ -70,6 +70,20 @@ but should be used wit

Re: [Qemu-devel] [PATCH] MinGW compilation shouldn't include -lglib-2.0 etc.

2011-07-27 Thread Daniel P. Berrange
On Wed, Jul 27, 2011 at 08:50:23AM -0700, Kenneth Salerno wrote: > Should check first if using a mingw compiler before forcing the addition of > -lglib-2.0, -liconv, and -lintl to $LIBS of config-target.mak. > > > Signed-off-by: Kenneth Salerno > --- configure.ORIG 2011-07-27 11:28:16.8593

[Qemu-devel] [Bug 524447] Re: virsh save is very slow

2011-07-27 Thread Jamie Strandboge
I'm sorry, the lucid qemu-kvm update has been superseded by a security update in 0.12.3+noroms-0ubuntu9.15. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/524447 Title: virsh save is very slow Stat

[Qemu-devel] [Bug 816860] Re: Guest machine freezes when NFS mount goes offline

2011-07-27 Thread Stefan Hajnoczi
** Changed in: qemu Status: New => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/816860 Title: Guest machine freezes when NFS mount goes offline Status in QEMU: Confirmed Bug d

[Qemu-devel] [PATCH] MinGW compilation shouldn't include -lglib-2.0 etc.

2011-07-27 Thread Kenneth Salerno
Should check first if using a mingw compiler before forcing the addition of -lglib-2.0, -liconv, and -lintl to $LIBS of config-target.mak. Signed-off-by: Kenneth Salerno --- configure.ORIG 2011-07-27 11:28:16.859375000 -0400 +++ configure 2011-07-27 11:43:59.859375000 -0400 @@ -1824,9 +1

Re: [Qemu-devel] [PATCH v2 1/1] The codes V2 for QEMU disk I/O limits.

2011-07-27 Thread Marcelo Tosatti
On Wed, Jul 27, 2011 at 06:17:15PM +0800, Zhi Yong Wu wrote: > >> +        wait_time = 1; > >> +    } > >> + > >> +    wait_time = wait_time + (slice_time - elapsed_time); > >> +    if (wait) { > >> +        *wait = wait_time * BLOCK_IO_SLICE_TIME * 10 + 1; > >> +    } > > > > The guest can keep su

Re: [Qemu-devel] [PATCH 1/2] pflash: Support read-only mode

2011-07-27 Thread Jordan Justen
On Wed, Jul 27, 2011 at 02:30, Jan Kiszka wrote: > On 2011-07-25 23:34, Jordan Justen wrote: >> Read-only mode is indicated by bdrv_is_read_only >> >> When read-only mode is enabled, no changes will be made >> to the flash image in memory, and no bdrv_write calls will be >> made. >> >> Signed-off-

Re: [Qemu-devel] [RFC][PATCH 0/21] QEMU Object Model

2011-07-27 Thread Paolo Bonzini
On 07/27/2011 02:48 PM, Anthony Liguori wrote: So the idea here is that the PIC will multiplex a bunch of interrupts into a single line? Yes, but the device needs to know the interrupt number so it can expose it through the enumerator interface. So the configuration cannot be simply pic-

Re: [Qemu-devel] [PATCH] virtio-serial-bus: replay guest_open on migration

2011-07-27 Thread Alon Levy
On Wed, Jul 27, 2011 at 10:01:57AM -0500, Anthony Liguori wrote: > On 07/27/2011 09:49 AM, Alon Levy wrote: > >On Wed, Jul 27, 2011 at 09:16:33AM -0500, Anthony Liguori wrote: > >>On 07/27/2011 02:07 AM, Alon Levy wrote: > >>>On Wed, Jul 27, 2011 at 07:45:25AM +0200, Markus Armbruster wrote: >

[Qemu-devel] RFC: moving fsfreeze support from the userland guest agent to the guest kernel

2011-07-27 Thread Andrea Arcangeli
Hello everyone, I've been thinking at the current design of the fsfreeze feature used by libvirt. It currently relays on an userland agent in the guest talking to qemu with some vmchannel communication. The guest agent would walk the filesystems in the guest and call fsfreeze ioctl on them. The

[Qemu-devel] [PATCH 02/15] qed: replace is_write with flags field

2011-07-27 Thread Stefan Hajnoczi
Per-request attributes like read/write are currently implemented as bool fields in the QEDAIOCB struct. This becomes unwiedly as the number of attributes grows. For example, the qed_aio_setup() function would have to take multiple bool arguments and at call sites it would be hard to distinguish t

Re: [Qemu-devel] [PATCH 1/1] block/vpc.c: Detect too-large vpc file

2011-07-27 Thread Serge E. Hallyn
Quoting Kevin Wolf (kw...@redhat.com): > > The footer->size appears to be double the 'real' size. So I'm actually > > doing > > the blow. Does this seem sensible? > > Double size sounds really weird. 'qemu-img create' uses the size in > bytes for it. Is that wrong? > > > Doing it this way, try

[Qemu-devel] [PULL v2] Trivial patches for June 25 to July 27 2011

2011-07-27 Thread Stefan Hajnoczi
Quick update: I have dropped the superfluous "Makefile: fix out-of-tree builds" patch. The following changes since commit c886edfb851c0c590d4e77f058f2ec8ed95ad1b5: Let users select their pythons (2011-07-25 16:50:12 +) are available in the git repository at: ssh://repo.or.cz/srv/git/qemu

[Qemu-devel] [PATCH 07/15] block: add bdrv_aio_copy_backing()

2011-07-27 Thread Stefan Hajnoczi
From: Anthony Liguori Add the bdrv_aio_copy_backing() function to the BlockDriver interface. This function copies unallocated sectors from the backing file and can be used to implement image streaming. Signed-off-by: Anthony Liguori Signed-off-by: Stefan Hajnoczi --- block.c | 37 ++

Re: [Qemu-devel] [PATCH 15/21] qom: add Device class

2011-07-27 Thread Peter Maydell
On 25 July 2011 02:44, Anthony Liguori wrote: > Device is meant to replace DeviceState as the root class for the device model. > This is included here merely as a RFC.  Device adds a couple of useful > features. > > 1) Default hard reset.  Device will literally call finalize on the object and >  

[Qemu-devel] [Bug 816370] Re: compile error in QEMU 0.15.0-rc0

2011-07-27 Thread rowa
See also https://bugs.launchpad.net/qemu/+bug/817012 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/816370 Title: compile error in QEMU 0.15.0-rc0 Status in QEMU: New Bug description: I've try

[Qemu-devel] [PATCH 3/7] target-arm: Mark 1136r1 as a v6K core

2011-07-27 Thread Peter Maydell
The 1136r1 is actually a v6K core (unlike the 1136r0); mark it as such, thus enabling the TLS registers, NOP hints, CLREX, half and byte wide exclusive load/stores, etc. The VA-to-PA translation registers are not present on 1136r1, so introduce a new feature flag for them, which is enabled on 1176

Re: [Qemu-devel] [PATCH] virtio-serial-bus: replay guest_open on migration

2011-07-27 Thread Anthony Liguori
On 07/27/2011 09:49 AM, Alon Levy wrote: On Wed, Jul 27, 2011 at 09:16:33AM -0500, Anthony Liguori wrote: On 07/27/2011 02:07 AM, Alon Levy wrote: On Wed, Jul 27, 2011 at 07:45:25AM +0200, Markus Armbruster wrote: Alon Levy writes: Signed-off-by: Alon Levy --- hw/virtio-serial-bus.c |

Re: [Qemu-devel] [PATCH 4/7] Makefile: fix out-of-tree builds

2011-07-27 Thread Stefan Hajnoczi
On Wed, Jul 27, 2011 at 10:17 AM, Stefan Hajnoczi wrote: > From: Alexandre Raymond > > This patch fixes a minor bugs which prevented QEMU from being built > out of tree. > > Signed-off-by: Alexandre Raymond > Signed-off-by: Stefan Hajnoczi > --- >  Makefile |    2 +- >  1 files changed, 1 inser

[Qemu-devel] [PATCH 11/15] qmp: add block_job_set_speed command

2011-07-27 Thread Stefan Hajnoczi
The block_job_set_speed command sets a throughput limit on an active image streaming operation. This can be used to isolate the streaming operation and control the amount of I/O bandwidth it consumes. The command synopsis is as follows: block_job_set_speed --- Set maximum speed

[Qemu-devel] [PATCH 4/7] target-arm: Support v6 barriers in linux-user mode

2011-07-27 Thread Peter Maydell
ARMv6 implemented various operations as special cases of cp15 accesses which are true instructions in v7; this includes barriers (DMB, DSB, ISB). Catch this special case at translate time, so that it works in linux-user mode (which doesn't provide a functional get_cp15 helper) as well as system mod

Re: [Qemu-devel] [PATCH v3] Add support for fd: protocol

2011-07-27 Thread Kevin Wolf
Am 27.07.2011 15:09, schrieb Corey Bryant: > Kevin/Daniel, thanks a lot for your input. > > In terms of the support that libvirt requires, I just want to make sure > all bases are covered. > > In order for this support to be useful to libvirt, the following are > required (sorry if this is repe

[Qemu-devel] [PATCH 08/15] qmp: add block_stream command

2011-07-27 Thread Stefan Hajnoczi
For leaf images with copy-on-read semantics, the stream command allows the user to populate the image file by copying data from the backing file while the guest is running. Once all blocks have been streamed, the dependency on the original backing file is removed. Therefore, stream commands can b

Re: [Qemu-devel] [V5 Patch 3/4]Qemu: Command "block_set" for dynamic block params change

2011-07-27 Thread Stefan Hajnoczi
2011/7/27 Michael Tokarev : > 27.07.2011 15:30, Supriya Kannery wrote: >> New command "block_set" added for dynamically changing any of the block >> device parameters. For now, dynamic setting of hostcache params using this >> command is implemented. Other block device parameter changes, can be >>

[Qemu-devel] [PATCH 09/15] qmp: add block_job_cancel command

2011-07-27 Thread Stefan Hajnoczi
Image streaming operations can be stopped using the block_job_cancel command. In the future other types of background operations on block devices can be cancelled using this command. The command synopsis is: block_job_cancel Stop an active block streaming operation. This comma

Re: [Qemu-devel] [PATCH] virtio-serial-bus: replay guest_open on migration

2011-07-27 Thread Alon Levy
On Wed, Jul 27, 2011 at 09:16:33AM -0500, Anthony Liguori wrote: > On 07/27/2011 02:07 AM, Alon Levy wrote: > >On Wed, Jul 27, 2011 at 07:45:25AM +0200, Markus Armbruster wrote: > >>Alon Levy writes: > >> > >>>Signed-off-by: Alon Levy > >>>--- > >>> hw/virtio-serial-bus.c |8 +++- > >>> 1

Re: [Qemu-devel] 0.15.0 Testing volunteers

2011-07-27 Thread Stefan Hajnoczi
On Wed, Jul 27, 2011 at 3:37 AM, Zhi Yong Wu wrote: > For networking and migration areas, is there any new feature to be > tested? If yes, can i be their testing volunteer? > > If QMP has not a voluntter, i would like also to do some testings for it. You could check that qemu-nbd, which we recent

[Qemu-devel] [PATCH 9/9] xen: implement unplug protocol in xen_platform

2011-07-27 Thread Alexander Graf
From: Stefano Stabellini The unplug protocol is necessary to support PV drivers in the guest: the drivers expect to be able to "unplug" emulated disks and nics before initializing the Xen PV interfaces. It is responsibility of the guest to make sure that the unplug is done before the emulated dev

[Qemu-devel] [PATCH 14/15] trace: trace bdrv_aio_readv/writev error paths

2011-07-27 Thread Stefan Hajnoczi
It is useful to understand why an I/O request was failed. Add trace events for the error paths in bdrv_aio_readv() and bdrv_aio_writev(). Signed-off-by: Stefan Hajnoczi --- block.c | 24 +++- trace-events |7 +++ 2 files changed, 26 insertions(+), 5 deletions(

Re: [Qemu-devel] [Qemu-trivial] [PATCH 1/2] Makefile: distclean should clean all possible targets

2011-07-27 Thread Michael Roth
On 07/27/2011 08:55 AM, Alexandre Raymond wrote: There are many more object files that are built conditionally. Why is it okay not to delete them? Perhaps they should be deleted too... The GNU Make manual says the following about "distclean": http://www.gnu.org/s/hello/manual/make/Standard-Ta

[Qemu-devel] [PATCH 4/9] xen: remove CONFIG_XEN_MAPCACHE

2011-07-27 Thread Alexander Graf
We were still exporting CONFIG_XEN_MAPCACHE, even though it's completely unused by now. Remove it. Signed-off-by: Alexander Graf --- configure |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/configure b/configure index 38e3724..cd399dc 100755 --- a/configure +++ b/conf

[Qemu-devel] [PATCH 3/4] target-arm: Handle UNDEF and UNPREDICTABLE cases for VLDM, VSTM

2011-07-27 Thread Peter Maydell
Handle the UNDEF and UNPREDICTABLE cases for VLDM and VSTM. In particular, we now generate an undef exception for overlarge imm8 values rather than generating 1000+ TCG ops and hitting an assertion. Signed-off-by: Peter Maydell --- target-arm/translate.c | 38 +++---

[Qemu-devel] [Bug 817012] [NEW] compile error in QEMU 0.15.0-rc0

2011-07-27 Thread rowa
Public bug reported: QEMU 0.15.0-rc0: Cross compiling on Fedora 14 for Windows is not possible: mkdir -p ~/source/mingw cd ~/source/mingw wget http://download-mirror.savannah.gnu.org/releases/qemu/qemu-0.15.0-rc0.tar.gz tar xzvf qemu-0.15.0-rc0.tar.gz cd qemu-0.15.0-rc0 export PATH=/usr/i686-pc-

[Qemu-devel] [PATCH 7/9] xen: Fix the memory registration to reflect of what is done by Xen.

2011-07-27 Thread Alexander Graf
From: Anthony PERARD A Xen guest memory is allocated by libxc. But this memory is not allocated continuously, instead, it leaves the VGA IO memory space not allocated, same for the MMIO space (at HVM_BELOW_4G_MMIO_START of size HVM_BELOW_4G_MMIO_LENGTH). So to reflect that, we do not register th

Re: [Qemu-devel] [V5 Patch 3/4]Qemu: Command "block_set" for dynamic block params change

2011-07-27 Thread Stefan Hajnoczi
On Wed, Jul 27, 2011 at 1:58 PM, Anthony Liguori wrote: >> Index: qemu/hmp-commands.hx >> === >> --- qemu.orig/hmp-commands.hx >> +++ qemu/hmp-commands.hx >> @@ -70,6 +70,20 @@ but should be used with extreme caution. >>  resizes imag

[Qemu-devel] [PATCH 2/4] target-arm: Support v6 barriers in linux-user mode

2011-07-27 Thread Peter Maydell
ARMv6 implemented various operations as special cases of cp15 accesses which are true instructions in v7; this includes barriers (DMB, DSB, ISB). Catch this special case at translate time, so that it works in linux-user mode (which doesn't provide a functional get_cp15 helper) as well as system mod

[Qemu-devel] [PATCH 2/7] target-arm: support for ARM1176JZF-s cores

2011-07-27 Thread Peter Maydell
From: Jamie Iles Add support for v6K ARM1176JZF-S. This core includes the VA<->PA translation capability and security extensions. Signed-off-by: Jamie Iles Signed-off-by: Peter Maydell --- target-arm/cpu.h|1 + target-arm/helper.c | 23 +++ 2 files changed, 24 i

Re: [Qemu-devel] [V5 Patch 1/4]Qemu: Enhance "info block" to display host cache setting

2011-07-27 Thread Stefan Hajnoczi
On Wed, Jul 27, 2011 at 12:30 PM, Supriya Kannery wrote: > Enhance "info block" to display hostcache setting for each > block device. > > Example: > (qemu) info block > ide0-hd0: type=hd removable=0 file=../rhel6-32.qcow2 ro=0 drv=qcow2 > encrypted=0 > > Enhanced to display "hostcache" setting: >

Re: [Qemu-devel] [PATCH 4/7] Makefile: fix out-of-tree builds

2011-07-27 Thread Alexandre Raymond
Hi Stefan, You may drop this patch, it doesn't do anything after all... Sorry about that. Alexandre On Wed, Jul 27, 2011 at 5:17 AM, Stefan Hajnoczi wrote: > From: Alexandre Raymond > > This patch fixes a minor bugs which prevented QEMU from being built > out of tree. > > Signed-off-by: Alexa

[Qemu-devel] [PATCH 04/15] qed: make qed_aio_write_alloc() reusable

2011-07-27 Thread Stefan Hajnoczi
Copy-on-read requests will share the allocating write code path. This requires making qed_aio_write_alloc() reusable outside of a write request. This patch ensures that iovec setup is performed in a common place before qed_aio_write_alloc() is called. Signed-off-by: Stefan Hajnoczi --- block/q

Re: [Qemu-devel] [PATCH] virtio-serial-bus: replay guest_open on migration

2011-07-27 Thread Anthony Liguori
On 07/27/2011 02:07 AM, Alon Levy wrote: On Wed, Jul 27, 2011 at 07:45:25AM +0200, Markus Armbruster wrote: Alon Levy writes: Signed-off-by: Alon Levy --- hw/virtio-serial-bus.c |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/hw/virtio-serial-bus.c b/hw/virt

  1   2   3   >