Re: [Qemu-devel] [v1 Patch 4/10]Qemu: Framework for reopening image files safely

2012-07-09 Thread Kevin Wolf
Am 15.06.2012 22:47, schrieb Supriya Kannery: > Struct BDRVReopenState along with three reopen related functions > introduced for handling reopening of images safely. This can be > extended by each of the block drivers to reopen respective > image files. > > Signed-off-by: Supriya Kannery > > In

Re: [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-07-09 Thread Corey Bryant
On 07/09/2012 10:05 AM, Luiz Capitulino wrote: On Thu, 05 Jul 2012 11:06:56 -0400 Corey Bryant wrote: On 07/04/2012 04:09 AM, Kevin Wolf wrote: Am 03.07.2012 20:21, schrieb Corey Bryant: On 07/03/2012 02:00 PM, Eric Blake wrote: On 07/03/2012 11:46 AM, Corey Bryant wrote: Yes, I thin

[Qemu-devel] [PATCH 20/25] fdc_test: update media_change test

2012-07-09 Thread Kevin Wolf
From: Pavel Hrdina After rewrite DSKCHG bit handling the test has to be updated. Now is needed to seek to different track to clear DSKCHG bit. Signed-off-by: Pavel Hrdina Signed-off-by: Kevin Wolf --- tests/fdc-test.c | 25 + 1 files changed, 17 insertions(+), 8 dele

Re: [Qemu-devel] [PATCH 23/25] fdc: Move floppy geometry guessing back from block.c

2012-07-09 Thread Anthony Liguori
On 07/09/2012 09:16 AM, Kevin Wolf wrote: From: Markus Armbruster Commit 5bbdbb46 moved it to block.c because "other geometry guessing functions already reside in block.c". Device-specific functionality should be kept in device code, not the block layer. Move it back. Disk geometry guessing i

[Qemu-devel] [PATCH 08/25] sheepdog: split outstanding list into inflight and pending

2012-07-09 Thread Kevin Wolf
From: MORITA Kazutaka outstanding_list_head is used for both pending and inflight requests. This patch splits it and improves readability. Signed-off-by: MORITA Kazutaka Signed-off-by: Kevin Wolf --- block/sheepdog.c | 49 - 1 files changed, 2

[Qemu-devel] [PATCH 07/25] sheepdog: make sure we don't free aiocb before sending all requests

2012-07-09 Thread Kevin Wolf
From: MORITA Kazutaka This patch increments the pending counter before sending requests, and make sures that aiocb is not freed while sending them. Signed-off-by: MORITA Kazutaka Signed-off-by: Kevin Wolf --- block/sheepdog.c | 29 - 1 files changed, 16 insertion

[Qemu-devel] [PATCH 24/25] qtest: Tidy up temporary files properly

2012-07-09 Thread Kevin Wolf
From: Markus Armbruster Each test litters /tmp with several files: a pid file and two sockets. Tidy up. Signed-off-by: Markus Armbruster Signed-off-by: Kevin Wolf --- tests/libqtest.c | 29 - 1 files changed, 16 insertions(+), 13 deletions(-) diff --git a/tests

[Qemu-devel] [PATCH v2] console: Implementing blinking of cursor

2012-07-09 Thread Jan Kiszka
Let the text console cursor blink at 2 HZ. Signed-off-by: Jan Kiszka --- Changes in v2: - fixed semantic of CONSOLE_CURSOR_PERIOD and reduced frequency I know there was a concern regarding the approach in general, but I still consider it useful and visually more attractive than the static curs

Re: [Qemu-devel] [v1 Patch 3/10]Qemu: Cmd "block_set_hostcache" for dynamic cache change

2012-07-09 Thread Kevin Wolf
Am 15.06.2012 22:47, schrieb Supriya Kannery: > New command "block_set_hostcache" added for dynamically changing > host pagecache setting of a block device. > > Usage: > block_set_hostcache > = block device > = on/off > > Example: > (qemu) block_set_hostcache ide0-hd0 off > > Sign

Re: [Qemu-devel] [v1 Patch 2/10]Qemu: Error classes for hostcache setting and data sync failures

2012-07-09 Thread Kevin Wolf
Am 15.06.2012 22:47, schrieb Supriya Kannery: > New error classes defined for hostcache setting and data > sync error > > Signed-off-by: Supriya Kannery > > --- > qerror.c |8 > qerror.h |6 ++ > 2 files changed, 14 insertions(+) > > Index: qemu/qerror.c > ===

[Qemu-devel] [PATCH 23/25] fdc: Move floppy geometry guessing back from block.c

2012-07-09 Thread Kevin Wolf
From: Markus Armbruster Commit 5bbdbb46 moved it to block.c because "other geometry guessing functions already reside in block.c". Device-specific functionality should be kept in device code, not the block layer. Move it back. Disk geometry guessing is still in block.c. To be moved out in a l

Re: [Qemu-devel] [v1 Patch 1/10]Qemu: Enhance "info block" to display host cache setting

2012-07-09 Thread Kevin Wolf
Am 15.06.2012 23:07, schrieb Eric Blake: > On 06/15/2012 02:47 PM, Supriya Kannery wrote: >> Enhance "info block" to display hostcache setting for each >> block device. >> > >> ## >> { 'type': 'BlockInfo', >>'data': {'device': 'str', 'type': 'str', 'removable': 'bool', >> - 'locked

[Qemu-devel] [PATCH 17/25] block: introduce bdrv_swap, implement bdrv_append on top of it

2012-07-09 Thread Kevin Wolf
From: Paolo Bonzini The new function can be made a bit nicer than bdrv_append. It swaps the whole contents, and then swaps back (using the usual t=a;a=b;b=t idiom) the fields that need to stay on top. Thus, it does not need explicit bdrv_detach_dev, bdrv_iostatus_disable, etc. Signed-off-by: P

[Qemu-devel] [PATCH 3/3] apic: Defer interrupt updates to VCPU thread

2012-07-09 Thread Jan Kiszka
KVM performs TPR raising asynchronously to QEMU, specifically outside QEMU's global lock. When an interrupt is injected into the APIC and TPR is checked to decide if this can be delivered, a stale TPR value may be used, causing spurious interrupts in the end. Fix this by deferring apic_update_irq

[Qemu-devel] [PATCH 2/3] apic: Reevaluate pending interrupts on LVT_LINT0 changes

2012-07-09 Thread Jan Kiszka
When the guest modifies the LVT_LINT0 register, we need to check if some pending PIC interrupt can now be delivered. Signed-off-by: Jan Kiszka --- hw/apic.c | 18 ++ 1 files changed, 14 insertions(+), 4 deletions(-) diff --git a/hw/apic.c b/hw/apic.c index e65a35f..5b8f3e8 100

[Qemu-devel] [PATCH 1/3] apic: Resolve potential endless loop around apic_update_irq

2012-07-09 Thread Jan Kiszka
Commit d96e173769 refactored the reinjection of pending PIC interrupts. However, it missed the potential loop of apic_update_irq -> apic_deliver_pic_intr -> apic_local_deliver -> apic_set_irq -> apic_update_irq that /could/ occur if LINT0 is injected as APIC_DM_FIXED and that vector is currently bl

[Qemu-devel] [PATCH 0/3] apic: Fixes for userspace model

2012-07-09 Thread Jan Kiszka
As Avi noted recently, there is a problem in way we inject interrupts into the userspace APIC under KVM: The TRP check over the iothread may race with the VCPU raising the TPR value while in KVM mode. Patch 3 addresses this issue. The other two patches fix problems I came across while thinking abo

[Qemu-devel] [PATCH 12/25] blkdebug: pass getlength to underlying file

2012-07-09 Thread Kevin Wolf
From: Paolo Bonzini This is required when using blkdebug with raw format. Unlike qcow2/QED, raw asks blkdebug for the length of the file, it doesn't get it from a header. Signed-off-by: Paolo Bonzini Signed-off-by: Kevin Wolf --- block/blkdebug.c |6 ++ 1 files changed, 6 insertions(

Re: [Qemu-devel] [PATCH] disas: Fix printing of addresses in disassembly

2012-07-09 Thread Andreas Färber
Am 09.07.2012 15:26, schrieb Peter Maydell: > On 9 July 2012 14:19, Andreas Färber wrote: >> Am 25.06.2012 16:55, schrieb Peter Maydell: >>> In our disassembly code, the bfd_vma type is always 64 bits, >>> even if the target's virtual address width is only 32 bits. This >>> means that when we prin

Re: [Qemu-devel] [PATCH] PPC: e500: reconditionalize on CONFIG_FDT

2012-07-09 Thread Alexander Graf
On 09.07.2012, at 16:36, Scott Wood wrote: > On 07/09/2012 09:07 AM, Andreas Färber wrote: >> Am 09.07.2012 16:04, schrieb Scott Wood: >>> Recent patches "PPC: e500: rename mpc8544ds into generic file", "PPC: >>> e500: split mpc8544ds machine from generic e500 code", and "PPC: e500: >>> add gener

Re: [Qemu-devel] CVE-2011-2212: has it been actually fixed?

2012-07-09 Thread Anthony Liguori
On 07/07/2012 08:37 AM, Michael Tokarev wrote: I come across a patch in ububtu qemu-kvm package, this: From: Nelson Elhage Date: Thu, 19 May 2011 13:23:17 -0400 Subject: [PATCH] virtqueue: Sanity-check the length of indirect descriptors. We were previously allowing arbitrarily-long descriptors,

Re: [Qemu-devel] [RFC] introduce a dynamic library to expose qemu block API

2012-07-09 Thread Christoph Hellwig
On Mon, Jul 09, 2012 at 04:54:08PM +0800, Wenchao Xia wrote: > Hi, Paolo and folks, > qemu have good capabilities to access different virtual disks, I want > to expose its block layer API to let 3rd party program linked in, such > as management stack or block tools, to access images data directly

[Qemu-devel] [PATCH 15/25] raw: hook into blkdebug

2012-07-09 Thread Kevin Wolf
From: Paolo Bonzini Signed-off-by: Paolo Bonzini Signed-off-by: Kevin Wolf --- block/raw.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/block/raw.c b/block/raw.c index 09d9b48..ff34ea4 100644 --- a/block/raw.c +++ b/block/raw.c @@ -12,12 +12,14 @@ static int raw_op

[Qemu-devel] [PATCH v3] sheepdog: do not blindly memset all read buffers

2012-07-09 Thread Christoph Hellwig
Only buffers that map to unallocated blocks need to be zeroed. Signed-off-by: Christoph Hellwig --- block/sheepdog.c | 37 ++--- 1 file changed, 18 insertions(+), 19 deletions(-) Index: qemu/block/sheepdog.c

[Qemu-devel] [PATCH 19/25] fdc: fix interrupt handling

2012-07-09 Thread Kevin Wolf
From: Pavel Hrdina If you call the SENSE INTERRUPT STATUS command while there is no interrupt waiting you get as result unknown command. Fixed status0 register handling for read/write/format commands. Signed-off-by: Pavel Hrdina Signed-off-by: Kevin Wolf --- hw/fdc.c | 34 +

[Qemu-devel] [PATCH] vl.c: Don't print errno after failed qemu_chr_new()

2012-07-09 Thread Peter Maydell
The qemu_chr_new() function doesn't set errno on failure, so don't print strerror(errno) on the error handling path when dealing with the -serial, -parallel and -virtioconsole arguments. This avoids nonsensical error messages like: $ ./arm-softmmu/qemu-system-arm -serial wombat qemu: could not

[Qemu-devel] [PATCH] hw/pl011.c: Avoid crash on read when no chr backend present

2012-07-09 Thread Peter Maydell
Add a missing guard that meant we would segfault if the guest read UARTDR on a PL011 serial device which had no chr backend connected. (This didn't happen for Linux guests because Linux reads the flags register and doesn't try to read the UART if it's empty.) Reported-by: Christian Müller Signed-

Re: [Qemu-devel] [PATCH] sheepdog: always use coroutine-based network functions

2012-07-09 Thread Kevin Wolf
Am 04.07.2012 18:41, schrieb MORITA Kazutaka: > This reduces some code duplication. > > Signed-off-by: MORITA Kazutaka Thanks, applied to the block branch. Kevin

[Qemu-devel] [PATCH 18/25] fdc: rewrite seek and DSKCHG bit handling

2012-07-09 Thread Kevin Wolf
From: Pavel Hrdina This bit is cleared on every successful seek to a different track (cylinder). The seek is also called on revalidate or on read/write/format commands which also clear the DSKCHG bit. Signed-off-by: Pavel Hrdina Signed-off-by: Kevin Wolf --- hw/fdc.c | 79 ++

[Qemu-devel] [PATCH 05/25] sheepdog: restart I/O when socket becomes ready in do_co_req()

2012-07-09 Thread Kevin Wolf
From: MORITA Kazutaka Currently, no one reenters the yielded coroutine. This fixes it. Signed-off-by: MORITA Kazutaka Signed-off-by: Kevin Wolf --- block/sheepdog.c | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/block/sheepdog.c b/block/sheepdog.c inde

[Qemu-devel] [PATCH 04/25] sheepdog: fix dprintf format strings

2012-07-09 Thread Kevin Wolf
From: MORITA Kazutaka This fixes warnings about dprintf format in debug mode. Signed-off-by: MORITA Kazutaka Signed-off-by: Kevin Wolf --- block/sheepdog.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/block/sheepdog.c b/block/sheepdog.c index 8877f45..afd06a

[Qemu-devel] [PULL 00/25] Block patches

2012-07-09 Thread Kevin Wolf
The following changes since commit 84988cf910a6881f2180fdcec516b60f8f0dc8c4: bitops.h: Add functions to extract and deposit bitfields (2012-07-07 09:07:01 +) are available in the git repository at: git://repo.or.cz/qemu/kevin.git for-anthony MORITA Kazutaka (6): sheepdog: fix dpr

Re: [Qemu-devel] [PATCH] PPC: e500: reconditionalize on CONFIG_FDT

2012-07-09 Thread Andreas Färber
Am 09.07.2012 16:04, schrieb Scott Wood: > Recent patches "PPC: e500: rename mpc8544ds into generic file", "PPC: > e500: split mpc8544ds machine from generic e500 code", and "PPC: e500: > add generic e500 platform" moved certain e500-related files to the bottom > of the makefile because they're now

[Qemu-devel] [PATCH v3 0/3] Add -cpu best support

2012-07-09 Thread Alexander Graf
[resend, forgot the v3, sorry] This patch set implements support for a sane default CPU type, that plays the middle ground between -cpu host (unmanagable test matrix) and -cpu qemu64 (breaks assumptions wrt family/model numbers). It also makes it the default for -M pc, so that users who don't spe

Re: [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-07-09 Thread Kevin Wolf
Am 06.07.2012 19:40, schrieb Corey Bryant: > > > On 07/06/2012 05:11 AM, Kevin Wolf wrote: >> Am 05.07.2012 19:00, schrieb Eric Blake: >>> On 07/05/2012 10:35 AM, Corey Bryant wrote: 1. client calls 'add-fd', qemu is now tracking fd=4 in fdset1 with refcount of 0; fd=4's in-use flag is

Re: [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-07-09 Thread Luiz Capitulino
On Thu, 05 Jul 2012 11:06:56 -0400 Corey Bryant wrote: > > > On 07/04/2012 04:09 AM, Kevin Wolf wrote: > > Am 03.07.2012 20:21, schrieb Corey Bryant: > >> On 07/03/2012 02:00 PM, Eric Blake wrote: > >>> On 07/03/2012 11:46 AM, Corey Bryant wrote: > >>> > > Yes, I think adding a +1 to

[Qemu-devel] [PATCH] PPC: e500: reconditionalize on CONFIG_FDT

2012-07-09 Thread Scott Wood
Recent patches "PPC: e500: rename mpc8544ds into generic file", "PPC: e500: split mpc8544ds machine from generic e500 code", and "PPC: e500: add generic e500 platform" moved certain e500-related files to the bottom of the makefile because they're now in ppc/, but the dependency on CONFIG_FDT was ac

[Qemu-devel] [PATCH v2] configure: add -Werror to QEMU_CFLAGS early

2012-07-09 Thread Alexander Graf
We want all configure tests pass with -Werror if it is enabled. So we need to update QEMU_CFLAGS early on to make sure we also pass it in to all the compile test jobs. This fixes a warning-became-error bug in nss for me with the default configuration: In file included from /usr/include/nss3/pkcs1

Re: [Qemu-devel] [PATCH 2/3] KVM: Use -cpu best as default on x86

2012-07-09 Thread Eric Blake
On 07/09/2012 07:48 AM, Alexander Graf wrote: > > On 09.07.2012, at 15:47, Eric Blake wrote: > >> On 07/09/2012 06:10 AM, Alexander Graf wrote: >> >>> >>> This fixes a lot of subtle breakage in the GNU toolchain (libgmp) which >>> hicks up on QEMU's non-existent CPU models. >> >> s/hicks up/hiccu

Re: [Qemu-devel] [PATCH 2/3] KVM: Use -cpu best as default on x86

2012-07-09 Thread Alexander Graf
On 09.07.2012, at 15:47, Eric Blake wrote: > On 07/09/2012 06:10 AM, Alexander Graf wrote: > >> >> This fixes a lot of subtle breakage in the GNU toolchain (libgmp) which >> hicks up on QEMU's non-existent CPU models. > > s/hicks up/hiccups/ > > >> >> v2 -> v3: >> >> - fix typo in commit

Re: [Qemu-devel] [PATCH 2/3] KVM: Use -cpu best as default on x86

2012-07-09 Thread Eric Blake
On 07/09/2012 06:10 AM, Alexander Graf wrote: > > This fixes a lot of subtle breakage in the GNU toolchain (libgmp) which > hicks up on QEMU's non-existent CPU models. s/hicks up/hiccups/ > > v2 -> v3: > > - fix typo in commit message but not all of them :) -- Eric Blake ebl...@redhat

[Qemu-devel] [PATCH v3 1/3] KVM: Add new -cpu best

2012-07-09 Thread Alexander Graf
During discussions on whether to support -cpu host in SLE, I found myself disagreeing to the thought, because it potentially opens a big can of worms for potential bugs. But if I already am so opposed to it for SLE, how can it possibly be reasonable to default to -cpu host in upstream QEMU? And wha

Re: [Qemu-devel] [PATCH] configure: add -Werror to QEMU_CFLAGS early

2012-07-09 Thread Gerd Hoffmann
On 07/09/12 14:23, Alexander Graf wrote: > We want all configure tests pass with -Werror if it is enabled. So we > need to update QEMU_CFLAGS early on to make sure we also pass it in to > all the compile test jobs. Much better than v1 Acked-by: Gerd Hoffmann cheers, Gerd

[Qemu-devel] [PATCH] configure: add -Werror to QEMU_CFLAGS early

2012-07-09 Thread Alexander Graf
We want all configure tests pass with -Werror if it is enabled. So we need to update QEMU_CFLAGS early on to make sure we also pass it in to all the compile test jobs. This fixes a warning-became-error bug in nss for me with the default configuration: In file included from /usr/include/nss3/pkcs1

[Qemu-devel] [PATCH 1/3] KVM: Add new -cpu best

2012-07-09 Thread Alexander Graf
During discussions on whether to support -cpu host in SLE, I found myself disagreeing to the thought, because it potentially opens a big can of worms for potential bugs. But if I already am so opposed to it for SLE, how can it possibly be reasonable to default to -cpu host in upstream QEMU? And wha

[Qemu-devel] [PATCH v3 2/3] KVM: Use -cpu best as default on x86

2012-07-09 Thread Alexander Graf
When running QEMU without -cpu parameter, the user usually wants a sane default. So far, we're using the qemu64/qemu32 CPU type, which basically means "the maximum TCG can emulate". That's a really good default when using TCG, but when running with KVM we much rather want a default saying "the max

Re: [Qemu-devel] [PATCH] configure: fix libsmartcard_nss compile check

2012-07-09 Thread Alexander Graf
On 09.07.2012, at 15:29, Gerd Hoffmann wrote: > On 07/09/12 14:06, Alexander Graf wrote: >> When just calling ./configure on my box, I always ran into the same issue: >> >> In file included from /usr/include/nss3/pkcs11t.h:1780, >> from /usr/include/nss3/keythi.h:41, >>

Re: [Qemu-devel] [PATCH] configure: fix libsmartcard_nss compile check

2012-07-09 Thread Gerd Hoffmann
On 07/09/12 14:06, Alexander Graf wrote: > When just calling ./configure on my box, I always ran into the same issue: > > In file included from /usr/include/nss3/pkcs11t.h:1780, > from /usr/include/nss3/keythi.h:41, > from /usr/include/nss3/keyt.h:41, >

[Qemu-devel] [PATCH v3 3/3] i386: KVM: List -cpu host and best in -cpu ?

2012-07-09 Thread Alexander Graf
The kvm_enabled() helper doesn't work in a function as early as -cpu ? yet. It also doesn't make sense to list the -cpu ? output conditional on the -enable-kvm parameter. So let's always mention -cpu host in the CPU list when KVM is supported on that configuration. In addition, this patch also add

Re: [Qemu-devel] [PATCH] configure: fix libsmartcard_nss compile check

2012-07-09 Thread Andreas Färber
Am 09.07.2012 14:06, schrieb Alexander Graf: > When just calling ./configure on my box, I always ran into the same issue: > > In file included from /usr/include/nss3/pkcs11t.h:1780, > from /usr/include/nss3/keythi.h:41, > from /usr/include/nss3/keyt.h:41, >

[Qemu-devel] [PATCH 0/3] Add -cpu best support

2012-07-09 Thread Alexander Graf
This patch set implements support for a sane default CPU type, that plays the middle ground between -cpu host (unmanagable test matrix) and -cpu qemu64 (breaks assumptions wrt family/model numbers). It also makes it the default for -M pc, so that users who don't specify a specific CPU type on the

[Qemu-devel] [PATCH 2/3] KVM: Use -cpu best as default on x86

2012-07-09 Thread Alexander Graf
When running QEMU without -cpu parameter, the user usually wants a sane default. So far, we're using the qemu64/qemu32 CPU type, which basically means "the maximum TCG can emulate". That's a really good default when using TCG, but when running with KVM we much rather want a default saying "the max

Re: [Qemu-devel] [PATCH] disas: Fix printing of addresses in disassembly

2012-07-09 Thread Peter Maydell
On 9 July 2012 14:19, Andreas Färber wrote: > Am 25.06.2012 16:55, schrieb Peter Maydell: >> In our disassembly code, the bfd_vma type is always 64 bits, >> even if the target's virtual address width is only 32 bits. This >> means that when we print out addresses we need to truncate them >> to 32

[Qemu-devel] [PATCH] configure: fix libsmartcard_nss compile check

2012-07-09 Thread Alexander Graf
When just calling ./configure on my box, I always ran into the same issue: In file included from /usr/include/nss3/pkcs11t.h:1780, from /usr/include/nss3/keythi.h:41, from /usr/include/nss3/keyt.h:41, from /usr/include/nss3/pk11pub.h:43,

Re: [Qemu-devel] [PATCH] flatload: fix bss clearing

2012-07-09 Thread Andreas Färber
Hi Mike, Am 09.07.2012 15:04, schrieb Mike Frysinger: > The current bss clear logic assumes the target mmap address and host > address are the same. Use g2h to translate from the target address > space to the host so we can call memset on it. > > Signed-off-by: Mike Frysinger > --- > linux-use

Re: [Qemu-devel] [PATCH] disas: Fix printing of addresses in disassembly

2012-07-09 Thread Andreas Färber
Am 25.06.2012 16:55, schrieb Peter Maydell: > In our disassembly code, the bfd_vma type is always 64 bits, > even if the target's virtual address width is only 32 bits. This > means that when we print out addresses we need to truncate them > to 32 bits, to avoid odd output which has incorrectly sig

Re: [Qemu-devel] [PATCH] flatload: fix bss clearing

2012-07-09 Thread Peter Maydell
On 9 July 2012 14:04, Mike Frysinger wrote: > The current bss clear logic assumes the target mmap address and host > address are the same. Use g2h to translate from the target address > space to the host so we can call memset on it. > > Signed-off-by: Mike Frysinger Reviewed-by: Peter Maydell

[Qemu-devel] [PATCH] flatload: fix bss clearing

2012-07-09 Thread Mike Frysinger
The current bss clear logic assumes the target mmap address and host address are the same. Use g2h to translate from the target address space to the host so we can call memset on it. Signed-off-by: Mike Frysinger --- linux-user/flatload.c |2 +- 1 files changed, 1 insertions(+), 1 deletions

Re: [Qemu-devel] [PATCH] disas: Fix printing of addresses in disassembly

2012-07-09 Thread Peter Maydell
On 9 July 2012 13:45, Andreas Färber wrote: > Am 09.07.2012 12:27, schrieb Peter Maydell: >> On 25 June 2012 15:55, Peter Maydell wrote: >>> In our disassembly code, the bfd_vma type is always 64 bits, >>> even if the target's virtual address width is only 32 bits. This >>> means that when we pri

Re: [Qemu-devel] [PATCH] Support 'help' as a synonym for '?' in command line options

2012-07-09 Thread Markus Armbruster
Eric Blake writes: > On 07/09/2012 06:10 AM, Peter Maydell wrote: >> On 9 July 2012 13:07, Eric Blake wrote: >>> That is, we are filtering based on the explicit presence of a literal >>> '?' in the help output to determine whether we can further filter based >>> on '-device device,?' queries wit

Re: [Qemu-devel] [PATCH 3/5] target-i386: call x86_cpu_realize() after APIC is initialized.

2012-07-09 Thread Andreas Färber
Am 09.07.2012 12:59, schrieb igor: > On 06/20/2012 03:35 PM, Andreas Färber wrote: >> Am 20.06.2012 14:59, schrieb Igor Mammedov: >>> It's not correct to make CPU runnable (i.e. calling x86_cpu_realize()) >>> when not all properties are set (APIC in this case). >>> >>> Fix it by calling x86_cpu_rea

[Qemu-devel] [Bug 989225] Re: windows XP Standard PC HAL does not work with qemu-kvm >= 0.15

2012-07-09 Thread Michael Chudobiak
This seems to be fixed in Fedora rawhide packages. Works for me now with: This issue seems to be fixed in current rawhide packages: qemu-common.x86_64 2:1.1.0-4.fc18 qemu-img.x86_64 2:1.1.0-4.fc18 qemu-kv

Re: [Qemu-devel] [PATCH] disas: Fix printing of addresses in disassembly

2012-07-09 Thread Andreas Färber
Am 09.07.2012 12:27, schrieb Peter Maydell: > Ping? [patchwork url http://patchwork.ozlabs.org/patch/167132/] > > -- PMM > > On 25 June 2012 15:55, Peter Maydell wrote: >> In our disassembly code, the bfd_vma type is always 64 bits, >> even if the target's virtual address width is only 32 bits.

[Qemu-devel] [Bug 1022331] Re: -cpu ? causes confusion when directory has 1-character length filenames

2012-07-09 Thread Peter Maydell
Proposed patch that would allow '-cpu help' &co: http://patchwork.ozlabs.org/patch/169798/ -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1022331 Title: -cpu ? causes confusion when directory has 1-

Re: [Qemu-devel] [PATCH] Support 'help' as a synonym for '?' in command line options

2012-07-09 Thread Daniel P. Berrange
On Mon, Jul 09, 2012 at 06:07:48AM -0600, Eric Blake wrote: > On 07/09/2012 05:52 AM, Peter Maydell wrote: > > For command line options which permit '?' meaning 'please list the > > permitted values', add support for 'help' as a synonym, by abstracting > > the check out into a helper function. > >

Re: [Qemu-devel] [PATCH 0/2] usb/scsi: usb attached scsi emulation

2012-07-09 Thread Gerd Hoffmann
On 07/09/12 12:45, Paolo Bonzini wrote: > Il 09/07/2012 12:39, Gerd Hoffmann ha scritto: >> On 07/09/12 12:33, Gerd Hoffmann wrote: >>> Hi, >>> >>> v2 of the usb attached scsi emulation patches. Patch #1 is almost >>> unmodified compared to v1. Patch #2 is new and makes UAS emulation >>> use th

Re: [Qemu-devel] [PATCH] Support 'help' as a synonym for '?' in command line options

2012-07-09 Thread Eric Blake
On 07/09/2012 06:10 AM, Peter Maydell wrote: > On 9 July 2012 13:07, Eric Blake wrote: >> That is, we are filtering based on the explicit presence of a literal >> '?' in the help output to determine whether we can further filter based >> on '-device device,?' queries without confusing qemu or libv

Re: [Qemu-devel] [PATCH V2] Use clean shutdown request for ctrl-a x

2012-07-09 Thread Andreas Färber
Am 09.07.2012 12:19, schrieb Fabien Chouteau: > Any comment? > > On 07/04/2012 01:04 PM, Fabien Chouteau wrote: >> The goal is to make ctrl-a x to close Qemu in a clean way. The current >> exit(0) skips a lot of cleanup/close functions, for example in block >> drivers. >> >> Signed-off-by: Fabien

Re: [Qemu-devel] [PATCH] Support 'help' as a synonym for '?' in command line options

2012-07-09 Thread Peter Maydell
On 9 July 2012 13:07, Eric Blake wrote: > That is, we are filtering based on the explicit presence of a literal > '?' in the help output to determine whether we can further filter based > on '-device device,?' queries without confusing qemu or libvirt; > changing the 'help' output means that old l

Re: [Qemu-devel] [PATCH] Support 'help' as a synonym for '?' in command line options

2012-07-09 Thread Eric Blake
On 07/09/2012 05:52 AM, Peter Maydell wrote: > For command line options which permit '?' meaning 'please list the > permitted values', add support for 'help' as a synonym, by abstracting > the check out into a helper function. > > Update the documentation to use 'help' rather than '?', since '?' >

Re: [Qemu-devel] [PATCH v2 1/3] KVM: Add new -cpu best

2012-07-09 Thread Alexander Graf
On 02.07.2012, at 16:25, Avi Kivity wrote: > On 06/26/2012 07:39 PM, Alexander Graf wrote: >> During discussions on whether to make -cpu host the default in SLE, I found >> myself disagreeing to the thought, because it potentially opens a big can >> of worms for potential bugs. But if I already a

[Qemu-devel] [PATCH] Support 'help' as a synonym for '?' in command line options

2012-07-09 Thread Peter Maydell
For command line options which permit '?' meaning 'please list the permitted values', add support for 'help' as a synonym, by abstracting the check out into a helper function. Update the documentation to use 'help' rather than '?', since '?' is a shell metacharacter and thus prone to fail confusin

[Qemu-devel] [PATCH 9/9] usb-host: add trace events for iso xfers

2012-07-09 Thread Gerd Hoffmann
Replace iso transfer fprintf's with trace points. Also rename existing tracepoints so they all match usb_host_iso_*. Signed-off-by: Gerd Hoffmann --- hw/usb/host-linux.c | 10 ++ trace-events|6 -- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/hw/usb/

[Qemu-devel] [PULL 0/9] usb patch queue

2012-07-09 Thread Gerd Hoffmann
Hi, Here comes the most recent usb patch queue, featuring a collection of little bug fixes all over the place. See individual patches for details. please pull, Gerd The following changes since commit 84988cf910a6881f2180fdcec516b60f8f0dc8c4: bitops.h: Add functions to extract and deposit

Re: [Qemu-devel] [PATCH V2] Use clean shutdown request for ctrl-a x

2012-07-09 Thread Paolo Bonzini
Il 09/07/2012 12:19, Fabien Chouteau ha scritto: > Any comment? Looks good to me. Blue, can you apply it while Anthony is on holiday? Paolo > On 07/04/2012 01:04 PM, Fabien Chouteau wrote: >> The goal is to make ctrl-a x to close Qemu in a clean way. The current >> exit(0) skips a lot of cleanu

[Qemu-devel] [PATCH 1/9] ehci: fix ehci_qh_do_overlay

2012-07-09 Thread Gerd Hoffmann
Use ehci_flush_qh to make sure we touch inly the fields the hc is allowed to touch. Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ehci.c | 37 ++--- 1 files changed, 18 insertions(+), 19 deletions(-) diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index 1582c2

[Qemu-devel] [PATCH v3 03/10] esp: implement Disable selection command

2012-07-09 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/esp.c |6 ++ trace-events |1 + 2 files changed, 7 insertions(+) diff --git a/hw/esp.c b/hw/esp.c index ac91f00..985a2ee 100644 --- a/hw/esp.c +++ b/hw/esp.c @@ -117,6 +117,7 @@ struct ESPState { #define CMD_SELATN 0x42 #define CMD_SELA

[Qemu-devel] [PATCH 7/9] usb: split endpoint init and reset

2012-07-09 Thread Gerd Hoffmann
Create a new usb_ep_reset() function to reset endpoint state, without re-initialiting the queues, so we don't unlink in-flight packets just because usb-host has to re-parse the descriptor tables. Signed-off-by: Gerd Hoffmann --- hw/usb.h|1 + hw/usb/core.c | 13 ++

Re: [Qemu-devel] [PATCH v2] ahci: add -drive support

2012-07-09 Thread Alexander Graf
On 09.07.2012, at 13:19, Markus Armbruster wrote: > Alexander Graf writes: > >> On 09.07.2012, at 13:06, Markus Armbruster wrote: >> >>> Kevin Wolf writes: >>> Am 09.07.2012 10:50, schrieb Markus Armbruster: > Alexander Graf writes: > >> We've had support for creating AHCI

[Qemu-devel] [PATCH v3 05/10] esp: support future change of chip_id

2012-07-09 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/esp.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/esp.c b/hw/esp.c index 85078e0..a1f5b8a 100644 --- a/hw/esp.c +++ b/hw/esp.c @@ -50,6 +50,7 @@ struct ESPState { uint8_t wregs[ESP_REGS]; qemu_irq irq; uint32_

Re: [Qemu-devel] [PATCH v2] ahci: add -drive support

2012-07-09 Thread Markus Armbruster
Alexander Graf writes: > On 09.07.2012, at 13:06, Markus Armbruster wrote: > >> Kevin Wolf writes: >> >>> Am 09.07.2012 10:50, schrieb Markus Armbruster: Alexander Graf writes: > We've had support for creating AHCI devices using -device for a while now, > but it's cumbersome

[Qemu-devel] [PATCH 6/9] usb-redir: Correctly handle the usb_redir_babble usbredir status

2012-07-09 Thread Gerd Hoffmann
From: Hans de Goede Signed-off-by: Hans de Goede Signed-off-by: Gerd Hoffmann --- hw/usb/redirect.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c index d949f04..10b4fbb 100644 --- a/hw/usb/redirect.c +++ b/hw/usb/redirect.c @@ -

[Qemu-devel] [PATCH v3 06/10] esp: use hba_private field instead of a complex cast

2012-07-09 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/esp.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/esp.c b/hw/esp.c index a1f5b8a..d9dd2aa 100644 --- a/hw/esp.c +++ b/hw/esp.c @@ -186,7 +186,7 @@ static void esp_dma_enable(void *opaque, int irq, int level) static v

Re: [Qemu-devel] [PATCH v2] ahci: add -drive support

2012-07-09 Thread Alexander Graf
On 09.07.2012, at 13:06, Markus Armbruster wrote: > Kevin Wolf writes: > >> Am 09.07.2012 10:50, schrieb Markus Armbruster: >>> Alexander Graf writes: >>> We've had support for creating AHCI devices using -device for a while now, but it's cumbersome to users. We really should provid

Re: [Qemu-devel] [PATCH v2] ahci: add -drive support

2012-07-09 Thread Markus Armbruster
Kevin Wolf writes: > Am 09.07.2012 10:50, schrieb Markus Armbruster: >> Alexander Graf writes: >> >>> We've had support for creating AHCI devices using -device for a while now, >>> but it's cumbersome to users. We really should provide an easier way for >>> them to leverage the power of AHCI! >

Re: [Qemu-devel] [PATCH v2] ahci: add -drive support

2012-07-09 Thread Markus Armbruster
Gerd Hoffmann writes: > Hi, > >>> If -hda has the semantics of "create an IDE device", then no, we can't >>> change it. It doesn't however. IIRC on -M pseries -hda creates SCSI >>> devices. On s390 -hda creates virtio devices. So if on -M q35 -hda would >>> create if=ahci, I don't see how th

[Qemu-devel] [PATCH 5/9] ehci: Kick async schedule on wakeup in the non companion case

2012-07-09 Thread Gerd Hoffmann
From: Hans de Goede Commit 0f588df8b3688b00e77aabaa32e26ece5f19bd39, added code to ehci_wakeup to kick the async schedule on wakeup, but the else was positioned wrong making it trigger for devices which are routed to the companion rather then to the ehci controller itself. This patch fixes this.

[Qemu-devel] [PATCH v3 04/10] esp: implement Reset ATN command

2012-07-09 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/esp.c |4 trace-events |1 + 2 files changed, 5 insertions(+) diff --git a/hw/esp.c b/hw/esp.c index 985a2ee..85078e0 100644 --- a/hw/esp.c +++ b/hw/esp.c @@ -113,6 +113,7 @@ struct ESPState { #define CMD_MSGACC 0x12 #define CMD_PAD

Re: [Qemu-devel] [PATCH 3/5] target-i386: call x86_cpu_realize() after APIC is initialized.

2012-07-09 Thread igor
On 06/20/2012 03:35 PM, Andreas Färber wrote: Am 20.06.2012 14:59, schrieb Igor Mammedov: It's not correct to make CPU runnable (i.e. calling x86_cpu_realize()) when not all properties are set (APIC in this case). Fix it by calling x86_cpu_realize() at board level after APIC is initialized, rig

[Qemu-devel] [PATCH v3 07/10] esp: split esp code into generic chip emulation and sysbus layer

2012-07-09 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/esp.c | 162 -- 1 file changed, 95 insertions(+), 67 deletions(-) diff --git a/hw/esp.c b/hw/esp.c index d9dd2aa..796cdc1 100644 --- a/hw/esp.c +++ b/hw/esp.c @@ -44,12 +44,9 @@ typedef struct E

[Qemu-devel] [PATCH 2/9] ehci: fix td writeback

2012-07-09 Thread Gerd Hoffmann
Only write back the dwords the hc is supposed to update. Should not make a difference in theory as the guest must not touch the td while it is active to avoid races. But it is still more correct. Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ehci.c |6 -- 1 files changed, 4 insertions(+)

[Qemu-devel] [PATCH 4/9] usb-ehci: Fix an assert whenever isoc transfers are used

2012-07-09 Thread Gerd Hoffmann
From: Hans de Goede hcd-ehci.c is missing an usb_packet_init() call for the ipacket UsbPacket it uses for isoc transfers, triggering an assert (taking the entire vm down) in usb_packet_setup as soon as any isoc transfers are done by a high speed USB device. Signed-off-by: Hans de Goede Signed-o

[Qemu-devel] [PATCH v3 01/10] esp: execute select commands immediately when it is a non-dma command

2012-07-09 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/esp.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/esp.c b/hw/esp.c index 8d73e56..aff8de6 100644 --- a/hw/esp.c +++ b/hw/esp.c @@ -270,7 +270,7 @@ static void handle_satn(ESPState *s) uint8_t buf[32]; int len;

Re: [Qemu-devel] [PATCH 0/2] usb/scsi: usb attached scsi emulation

2012-07-09 Thread Paolo Bonzini
Il 09/07/2012 12:39, Gerd Hoffmann ha scritto: > On 07/09/12 12:33, Gerd Hoffmann wrote: >> Hi, >> >> v2 of the usb attached scsi emulation patches. Patch #1 is almost >> unmodified compared to v1. Patch #2 is new and makes UAS emulation >> use the new free_request callback (patch just posted b

Re: [Qemu-devel] [PATCH 7/7 v6] deal with panicked event accoring to '-machine panic_action=action'

2012-07-09 Thread Wen Congyang
At 07/06/2012 07:09 PM, Jan Kiszka Wrote: > On 2012-07-06 11:41, Wen Congyang wrote: >> The action is the same as -onpanic parameter. > > As explained in patch 5, now that we have a related device, this no > longer needs to be a machine property. > > Would could be a machine property is enabling/

Re: [Qemu-devel] [PATCH 0/2] usb/scsi: usb attached scsi emulation

2012-07-09 Thread Gerd Hoffmann
On 07/09/12 12:33, Gerd Hoffmann wrote: > Hi, > > v2 of the usb attached scsi emulation patches. Patch #1 is almost > unmodified compared to v1. Patch #2 is new and makes UAS emulation > use the new free_request callback (patch just posted by paolo) and > obviously depends on that patch to com

[Qemu-devel] [PATCH 8/9] usb: fix interface initialization

2012-07-09 Thread Gerd Hoffmann
zero is a valid interface number, so don't use it when resetting the endpoints. Signed-off-by: Gerd Hoffmann --- hw/usb.h |2 ++ hw/usb/core.c |4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/usb.h b/hw/usb.h index 9cd2f89..7ed8fb8 100644 --- a/hw/usb.h +++

[Qemu-devel] [PATCH 2/2] uas: use scsi req refcounting + free_request callback

2012-07-09 Thread Gerd Hoffmann
With the new free_request callback for SCSIBusInfo we can use scsi request refcounting instead of our own for the uas request lifecycle. Signed-off-by: Gerd Hoffmann --- hw/usb/dev-uas.c | 33 ++--- 1 files changed, 10 insertions(+), 23 deletions(-) diff --git a/hw

[Qemu-devel] [PATCH 1/2] usb: add usb attached scsi emulation

2012-07-09 Thread Gerd Hoffmann
$subject says all. First cut. It's a pure UAS (usb attached scsi) emulation, without BOT (bulk-only transport) compatibility. If your guest can't handle it use usb-storage instead. The emulation works like any other scsi hba emulation (eps, lsi, virtio, megasas, ...). It provides just the HBA

[Qemu-devel] [PATCH 0/2] usb/scsi: usb attached scsi emulation

2012-07-09 Thread Gerd Hoffmann
Hi, v2 of the usb attached scsi emulation patches. Patch #1 is almost unmodified compared to v1. Patch #2 is new and makes UAS emulation use the new free_request callback (patch just posted by paolo) and obviously depends on that patch to compile. cheers, Gerd Gerd Hoffmann (2): usb: add

<    1   2   3   >