Re: [Qemu-devel] [PATCH v2] vl.c: disallow command line fw cfg without opt/

2016-03-18 Thread Laszlo Ersek
On 03/16/16 19:43, Michael S. Tsirkin wrote: > On Wed, Mar 16, 2016 at 07:35:09PM +0100, Laszlo Ersek wrote: >> On 03/16/16 19:15, Gabriel L. Somlo wrote: >>> On Wed, 16 Mar 2016 at 18:50:57 +0200, Michael S. Tsirkin wrote: On Wed, Mar 16, 2016 at 05:29:45PM +0100, Markus Armbruster wrote: >>>

[Qemu-devel] [PULL v2 11/13] crypto: wire up XTS mode for cipher APIs

2016-03-18 Thread Daniel P. Berrange
Introduce 'XTS' as a permitted mode for the cipher APIs. With XTS the key provided must be twice the size of the key normally required for any given algorithm. This is because the key will be split into two pieces for use in XTS mode. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrange ---

Re: [Qemu-devel] [PATCH 2/3] hw/net/spapr_llan: Fix receive buffer handling for better performance

2016-03-18 Thread David Gibson
On Thu, Mar 17, 2016 at 08:30:15AM +0100, Thomas Huth wrote: > On 17.03.2016 07:23, David Gibson wrote: > > On Wed, Mar 16, 2016 at 01:16:50PM +0100, Thomas Huth wrote: > >> > >> This patch introduces an alternate way of handling the receive > >> buffers of the spapr-vlan device, resulting in much

Re: [Qemu-devel] [PATCH v4 07/11] block: m25p80: Dummy cycles for N25Q256/512

2016-03-18 Thread Peter Crosthwaite
On Mon, Feb 22, 2016 at 12:03 AM, wrote: > From: Marcin Krzeminski > > This patch handles dummy cycles. > More commit message needed: "Use the setting in the volatile cfg register to correctly set the number of dummy bytes" > Signed-off-by: Marcin Krzeminski > --- > hw/block/m25p80.c | 8 ++

[Qemu-devel] [PATCH 21/49] arm: include cpu-qom.h in files that require ARMCPU

2016-03-18 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/arm/stm32f205_soc.c | 1 - hw/arm/strongarm.h | 1 + include/hw/arm/arm.h| 2 +- include/hw/arm/exynos4210.h | 1 + include/hw/arm/omap.h | 1 + include/hw/arm/pxa.h| 1 + 6 files changed, 5 insertions(+), 2 deletions(-) dif

Re: [Qemu-devel] [PATCH v12 8/9] hw/ptimer: Perform delayed tick instead of immediate if delta = 0

2016-03-18 Thread Dmitry Osipenko
09.03.2016 00:08, Peter Crosthwaite пишет: On Sat, Jan 30, 2016 at 8:43 AM, Dmitry Osipenko wrote: It might be necessary by some emulated HW to perform the tick after one period if delta = 0. Given that it is much less churny to implement immediate tick by the ptimer user itself, let's make pti

Re: [Qemu-devel] [PATCH 2/3] hw/net/spapr_llan: Fix receive buffer handling for better performance

2016-03-18 Thread Thomas Huth
On 17.03.2016 23:33, David Gibson wrote: > On Thu, Mar 17, 2016 at 04:15:38PM +0100, Thomas Huth wrote: >> On 17.03.2016 08:30, Thomas Huth wrote: >>> On 17.03.2016 07:23, David Gibson wrote: On Wed, Mar 16, 2016 at 01:16:50PM +0100, Thomas Huth wrote: > > This patch introduces an alte

[Qemu-devel] [PATCH] block/sheepdog: add error handling to sd_snapshot_delete()

2016-03-18 Thread Takashi Menjo
Errors have been ignored in some code paths in sd_snapshot_delete(). This patch adds error handling. Signed-off-by: Takashi Menjo --- block/sheepdog.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/block/sheepdog.c b/block/sheepdog.c index a3aeae4..6492405 100644 --- a/block/sheepdog.c +

[Qemu-devel] [PULL v3 09/13] crypto: import an implementation of the XTS cipher mode

2016-03-18 Thread Daniel P. Berrange
The XTS (XEX with tweaked-codebook and ciphertext stealing) cipher mode is commonly used in full disk encryption. There is unfortunately no implementation of it in either libgcrypt or nettle, so we need to provide our own. The libtomcrypt project provides a repository of crypto algorithms under a

[Qemu-devel] [PULL 03/21] target-arm: Fix translation level on early translation faults

2016-03-18 Thread Peter Maydell
From: Sergey Sorokin Qemu reports translation fault on 1st level instead of 0th level in case of AArch64 address translation if the translation table walk is disabled or the address is in the gap between the two regions. Signed-off-by: Sergey Sorokin Message-id: 1457527503-25958-1-git-send-emai

[Qemu-devel] [PULL v3 00/13] Merge crypto code for LUKS encryption

2016-03-18 Thread Daniel P. Berrange
The following changes since commit 8c4575472494a5dfedfe05e7b58ca9ce3872ad56: Merge remote-tracking branch 'remotes/ehabkost/tags/machine-pull-request' into staging (2016-03-17 08:52:58 +) are available in the git repository at: git://github.com/berrange/qemu tags/pull-qcrypto-2016-03-17

Re: [Qemu-devel] Our use of #include is undisciplined, and what to do about it

2016-03-18 Thread Richard Henderson
On 03/15/2016 02:29 AM, Markus Armbruster wrote: > Headers can > be read multiple times, which can only hurt compilation time. You need > to make an effort to avoid cyclic dependencies and excessive inclusion. I just want to point out that the preprocessor understands the #ifndef FOO #define FOO

[Qemu-devel] [PATCH v5 11/28] migration: convert post-copy to use QIOChannelBuffer

2016-03-18 Thread Daniel P. Berrange
The post-copy code does some I/O to/from an intermediate in-memory buffer rather than direct to the underlying I/O channel. Switch this code to use QIOChannelBuffer instead of QEMUSizedBuffer. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrange --- docs/migration.txt | 4

[Qemu-devel] [PULL v1 11/13] crypto: wire up XTS mode for cipher APIs

2016-03-18 Thread Daniel P. Berrange
Introduce 'XTS' as a permitted mode for the cipher APIs. With XTS the key provided must be twice the size of the key normally required for any given algorithm. This is because the key will be split into two pieces for use in XTS mode. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrange ---

[Qemu-devel] ODP: [PATCH v4 02/11] block: m25p80: RESET_ENABLE and RESET_MEMORY commnads

2016-03-18 Thread Krzeminski, Marcin (Nokia - PL/Wroclaw)
W dniu 17.03.2016 o 18:42, Peter Crosthwaite pisze: > "commands" in commit msg > > On Mon, Feb 22, 2016 at 12:03 AM, wrote: >> From: Marcin Krzeminski >> >> Signed-off-by: Marcin Krzeminski >> --- >> hw/block/m25p80.c | 35 ++- >> 1 file changed, 34 insertions

[Qemu-devel] [PATCH 27/49] arm: remove useless cpu.h inclusion

2016-03-18 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- include/hw/arm/digic.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/hw/arm/digic.h b/include/hw/arm/digic.h index a739d6a..aaefe0b 100644 --- a/include/hw/arm/digic.h +++ b/include/hw/arm/digic.h @@ -18,8 +18,6 @@ #ifndef HW_ARM_DIGIC_H #define H

[Qemu-devel] [PATCH RFC 5/6] virtio-mmio: convert to ioeventfd callbacks

2016-03-18 Thread Cornelia Huck
Convert to the new interface. Signed-off-by: Cornelia Huck --- hw/virtio/virtio-mmio.c | 128 1 file changed, 41 insertions(+), 87 deletions(-) diff --git a/hw/virtio/virtio-mmio.c b/hw/virtio/virtio-mmio.c index d4cd91f..d2accbc 100644 --- a/hw/

[Qemu-devel] [PATCH v5 17/28] migration: convert RDMA to use QIOChannel interface

2016-03-18 Thread Daniel P. Berrange
This converts the RDMA code to provide a subclass of QIOChannel that uses RDMA for the data transport. This implementation of RDMA does not correctly handle non-blocking mode. Reads might block if there was not already some pending data and writes will block until all data is sent. This flawed beh

[Qemu-devel] [PATCH 08/15] nvdimm acpi: save arg3 of _DSM method

2016-03-18 Thread Xiao Guangrong
Check if the input Arg3 is valid then store it into ARG3 if it is needed Signed-off-by: Xiao Guangrong --- hw/acpi/nvdimm.c | 20 1 file changed, 20 insertions(+) diff --git a/hw/acpi/nvdimm.c b/hw/acpi/nvdimm.c index 586c02a..38aba3d 100644 --- a/hw/acpi/nvdimm.c +++ b/hw/

Re: [Qemu-devel] [PATCH v3 00/13] tests: Introducing docker tests

2016-03-18 Thread Daniel P. Berrange
On Fri, Mar 11, 2016 at 04:16:58PM +, Alex Bennée wrote: > > Fam Zheng writes: > > > v3 changes: > > I think we are almost there. There a just a few tweaks to be made to > help text and prompts. Can you ensure that all examples in commit > messages and help text actually do run as expected?

[Qemu-devel] [PULL v2 08/13] crypto: add support for the twofish cipher algorithm

2016-03-18 Thread Daniel P. Berrange
New cipher algorithms 'twofish-128', 'twofish-192' and 'twofish-256' are defined for the Twofish algorithm. The gcrypt backend does not support 'twofish-192'. The nettle and gcrypt cipher backends are updated to support the new cipher and a test vector added to the cipher test suite. The new algor

[Qemu-devel] [PULL 16/40] ivshmem: Fix harmless misuse of Error

2016-03-18 Thread Markus Armbruster
We reuse errp after passing it host_memory_backend_get_memory(). If both host_memory_backend_get_memory() and the reuse set an error, the reuse will fail the assertion in error_setv(). Fortunately, host_memory_backend_get_memory() can't fail. Pass it &error_abort to make our assumption explicit,

Re: [Qemu-devel] [PULL v3 00/13] Merge crypto code for LUKS encryption

2016-03-18 Thread Peter Maydell
On 17 March 2016 at 16:53, Daniel P. Berrange wrote: > The following changes since commit 8c4575472494a5dfedfe05e7b58ca9ce3872ad56: > > Merge remote-tracking branch 'remotes/ehabkost/tags/machine-pull-request' > into staging (2016-03-17 08:52:58 +) > > are available in the git repository at

[Qemu-devel] [PULL v2 06/13] crypto: add support for the cast5-128 cipher algorithm

2016-03-18 Thread Daniel P. Berrange
A new cipher algorithm 'cast-5-128' is defined for the Cast-5 algorithm with 128 bit key size. Smaller key sizes are supported by Cast-5, but nothing in QEMU should use them, so only 128 bit keys are permitted. The nettle and gcrypt cipher backends are updated to support the new cipher and a test

[Qemu-devel] [PATCH v4 06/17] block: Drop BB name from bad option error

2016-03-18 Thread Max Reitz
The information which BB is concerned does not seem useful enough to justify its existence in most other place (which may be related to qemu printing the -drive parameter in question anyway, and for blockdev-add the attribution is naturally unambiguous). Furthermore, as of a future patch, bdrv_get_

[Qemu-devel] [PATCH v2 12/16] aio: introduce aio_context_in_iothread

2016-03-18 Thread Paolo Bonzini
This will be used by bdrv_drain (and indirectly by the synchronous I/O helpers), to choose between aio_poll or QemuEvent. Reviewed-by: Fam Zheng Signed-off-by: Paolo Bonzini --- include/block/aio.h | 7 +++ iothread.c | 9 + stubs/Makefile.objs | 1 + stubs/iothread.c|

[Qemu-devel] [PULL 15/15] qapi: Use anonymous bases in QMP flat unions

2016-03-18 Thread Markus Armbruster
From: Eric Blake Now that the generator supports it, we might as well use an anonymous base rather than breaking out a single-use Base structure, for all three of our current QMP flat unions. Oddly enough, this change does not affect the resulting introspection output (because we already inline

Re: [Qemu-devel] [PATCH 0/4] Tweaks around virtio-blk start/stop

2016-03-18 Thread Cornelia Huck
On Wed, 16 Mar 2016 12:09:02 +0100 Paolo Bonzini wrote: > On 16/03/2016 11:49, Christian Borntraeger wrote: > > #3 0x800b713e in virtio_blk_data_plane_start (s=0xba232d80) at > > /home/cborntra/REPOS/qemu/hw/block/dataplane/virtio-blk.c:224 > > #4 0x800b4ea0 in virtio_blk_hand

Re: [Qemu-devel] Our use of #include is undisciplined, and what to do about it

2016-03-18 Thread Peter Maydell
On 17 March 2016 at 20:14, Richard Henderson wrote: > That works for all of the hosts we care about (ELF and MachO). ...Windows is something other than both of those, right? Or does it use ELF these days? thanks -- PMM

[Qemu-devel] [PULL 02/40] ivshmem-server: Fix and clean up command line help

2016-03-18 Thread Markus Armbruster
Burying error messages in ~20 lines of usage help is bad form. Print a single line pointing to -h instead. Print -h help to stdout rather than stderr. Fix default of -p. Clean up the help text a bit. Signed-off-by: Markus Armbruster Reviewed-by: Marc-André Lureau Message-Id: <1458066895-2063

Re: [Qemu-devel] [PATCH 0/4] Tweaks around virtio-blk start/stop

2016-03-18 Thread Cornelia Huck
On Wed, 16 Mar 2016 13:32:59 +0100 Paolo Bonzini wrote: > On 16/03/2016 13:22, Cornelia Huck wrote: > >> > Yeah, it doesn't help that the functions are underdocumented (as in the > >> > "assign" parameter above). > > My understanding is: > > > > - 'assign': set up a new notifier (true) or disabl

[Qemu-devel] [PULL 14/29] block: Move some bdrv_*_all() functions to BB

2016-03-18 Thread Kevin Wolf
From: Max Reitz Move bdrv_commit_all() and bdrv_flush_all() to the BlockBackend level. Signed-off-by: Max Reitz Signed-off-by: Kevin Wolf --- block.c | 20 block/block-backend.c | 44 ++-- block/io.c |

[Qemu-devel] [PULL 18/40] ivshmem: Clean up register callbacks

2016-03-18 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Marc-André Lureau Message-Id: <1458066895-20632-19-git-send-email-arm...@redhat.com> --- hw/misc/ivshmem.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index 51ad255..1debce3 10

Re: [Qemu-devel] [PATCH v12 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-03-18 Thread Wen Congyang
On 03/17/2016 06:07 PM, Alberto Garcia wrote: > On Thu 17 Mar 2016 10:56:09 AM CET, Wen Congyang wrote: >>> We should have the failure modes documented, and how you'll use it >>> after failover etc Without that it's really difficult to tell if this >>> naming is right. >> >> For COLO, children.0 is

Re: [Qemu-devel] [PATCH v3 19/40] ivshmem: Clean up MSI-X conditions

2016-03-18 Thread Marc-André Lureau
On Tue, Mar 15, 2016 at 7:34 PM, Markus Armbruster wrote: > There are three predicates related to MSI-X: > > * ivshmem_has_feature(s, IVSHMEM_MSI) is true unless the non-MSI-X > variant of the device is selected with msi=off. > > * msix_present() is true when the device has the PCI capability MS

[Qemu-devel] [PULL 20/40] ivshmem: Leave INTx alone when using MSI-X

2016-03-18 Thread Markus Armbruster
The ivshmem device can either use MSI-X or legacy INTx for interrupts. With MSI-X enabled, peer interrupt events trigger an MSI as they should. But software can still raise INTx via interrupt status and mask register in BAR 0. This is explicitly prohibited by PCI Local Bus Specification Revision

Re: [Qemu-devel] [PATCH 0/4] Tweaks around virtio-blk start/stop

2016-03-18 Thread Paolo Bonzini
On 17/03/2016 17:08, Christian Borntraeger wrote: > Good (or bad?) news is the assert also triggers on F23, it just seems > to take longer. I guess good news, because we can rule out the kernel (not that I believed it was a kernel problem, but the thought is always there in the background...).

Re: [Qemu-devel] [PATCH 6/9] log: log QMP commands and replies

2016-03-18 Thread Paolo Bonzini
On 16/03/2016 14:09, Denis V. Lunev wrote: > really interesting approach with a good place to get in. > But we will need to modify this a infrastructure a bit. > Af far as I can see only data from VM to outside world > is logged. Data being 'read' should be logged too as far > as I could understa

[Qemu-devel] [PATCH v2 01/10] ppc: Update SPR definitions

2016-03-18 Thread Cédric Le Goater
From: Benjamin Herrenschmidt Add definitions for additional SPR numbers and SPR bit definitions that will be relevant for subsequent improvements to POWER8 emulation Also fix the definition of LPIDR which was incorrect (and is different for server and embedded). Signed-off-by: Benjamin Herrensc

Re: [Qemu-devel] [PATCH 3/5] tcg: always keep jump target and tb->jmp_next consistent

2016-03-18 Thread Sergey Fedorov
On 17/03/16 22:31, Paolo Bonzini wrote: On 17/03/2016 18:57, Richard Henderson wrote: @@ -951,18 +959,10 @@ static inline void tb_jmp_remove(TranslationBlock *tb, int n) } /* now we can suppress tb(n) from the list */ *ptb = tb->jmp_next[n]; - -tb->jmp_nex

Re: [Qemu-devel] [PATCH 1/4] hw/audio: QOM'ify cs4231.c

2016-03-18 Thread Paolo Bonzini
On 16/03/2016 10:24, xiaoqiang zhao wrote: > Drop the old SysBus init function and use instance_init > > Signed-off-by: xiaoqiang zhao > --- > hw/audio/cs4231.c | 12 +--- > 1 file changed, 5 insertions(+), 7 deletions(-) > > diff --git a/hw/audio/cs4231.c b/hw/audio/cs4231.c > index

Re: [Qemu-devel] [PATCH] spice: Disallow use of gl + TCP port

2016-03-18 Thread Christophe Fergeau
On Fri, Mar 18, 2016 at 09:17:53AM +0100, Gerd Hoffmann wrote: > On Mo, 2016-03-14 at 12:41 +0100, Christophe Fergeau wrote: > > Currently, virgl support has to go through a local unix socket, trying > > to connect to a VM using -spice gl through spice://localhost:5900 will > > only result in a bla

Re: [Qemu-devel] [RFC PATCH V2 00/10] Qemu: Add live migration support for SRIOV NIC

2016-03-18 Thread Wei Yang
Hi, Tianyu, I am testing your V2 patch set in our environment, while facing two issues now. Have a workaround for the first one and hope you could share some light on the second one :-) 1. Mismatch for ram_block (Have a workaround) -

[Qemu-devel] [PATCH v6 12/16] qapi: Don't special-case simple union wrappers

2016-03-18 Thread Eric Blake
Simple unions were carrying a special case that hid their 'data' QMP member from the resulting C struct, via the hack method QAPISchemaObjectTypeVariant.simple_union_type(). But by using the work we started by unboxing flat union and alternate branches, coupled with the ability to visit the member

Re: [Qemu-devel] [PATCH v3] Sort the fw_cfg file list

2016-03-18 Thread Michael S. Tsirkin
On Wed, Mar 16, 2016 at 01:47:08PM -0500, miny...@acm.org wrote: > From: Gerd Hoffmann > > Entries are inserted in filename order instead of being > appended to the end in case sorting is enabled. > > This will avoid any future issues of moving the file creation > around, it doesn't matter what

Re: [Qemu-devel] [PATCH v2 02/10] ppc: Add macros to register hypervisor mode SPRs

2016-03-18 Thread Thomas Huth
On 16.03.2016 14:13, Cédric Le Goater wrote: > From: Benjamin Herrenschmidt > > The current set of spr_register_* macros only take the user and > supervisor function pointers. To make the transition easy, we > don't change that but we add "_hv" variants that can be used to > register all 3 sets.

Re: [Qemu-devel] [PULL 00/21] target-arm queue

2016-03-18 Thread Peter Maydell
On 16 March 2016 at 17:18, Peter Maydell wrote: > Here's the target-arm queue; I'm a bit hesitant about the late-landing > various new board/SoC patches, but they won't affect anybody who isn't > trying to use those boards, so I think it's OK. > > (There are a few other patches on list which I def

[Qemu-devel] [PATCH v5 0/7] Add new LUKS block driver (for 2.6)

2016-03-18 Thread Daniel P. Berrange
This series is just the block layer parts needed to add a LUKS driver to QEMU. It was previously posted as part of the larger series v1: https://lists.gnu.org/archive/html/qemu-devel/2015-11/msg04748.html v2: https://lists.gnu.org/archive/html/qemu-block/2016-01/msg00534.html v3: https://lis

[Qemu-devel] [PULL 29/40] ivshmem: Simplify how we cope with short reads from server

2016-03-18 Thread Markus Armbruster
Short reads from a UNIX domain sockets are exceedingly unlikely when the other side always sends eight bytes and we always read eight bytes. We cope with them anyway. However, the code doing that is rather convoluted. Dumb it down radically. Signed-off-by: Markus Armbruster Reviewed-by: Marc-A

[Qemu-devel] [PULL v1 13/13] crypto: implement the LUKS block encryption format

2016-03-18 Thread Daniel P. Berrange
Provide a block encryption implementation that follows the LUKS/dm-crypt specification. This supports all combinations of hash, cipher algorithm, cipher mode and iv generator that are implemented by the current crypto layer. There is support for opening existing volumes formatted by dm-crypt, and

Re: [Qemu-devel] [PATCH] exec: fix error handling in file_ram_alloc

2016-03-18 Thread Laszlo Ersek
On 03/17/16 23:51, Paolo Bonzini wrote: > One instance of double closing, and invalid close(-1) in some cases > of "goto error". > > Signed-off-by: Paolo Bonzini > --- > exec.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/exec.c b/exec.c > index f398d21..5c16f

Re: [Qemu-devel] [PATCH v1 0/2] Fix build problems with nettle < 3.0.0

2016-03-18 Thread Eduardo Habkost
On Fri, Mar 18, 2016 at 01:21:54PM +, Daniel P. Berrange wrote: > This series fixes two build problems identified by people using > 2.x series of nettle > > https://lists.gnu.org/archive/html/qemu-devel/2016-03/msg04420.html > > > Daniel P. Berrange (2): > crypto: add compat cast5_set_ke

Re: [Qemu-devel] Our use of #include is undisciplined, and what to do about it

2016-03-18 Thread Stefan Hajnoczi
On Tue, Mar 15, 2016 at 01:56:47PM +, Dr. David Alan Gilbert wrote: > > This would put trace_foo() in generated-tracers-virtio-blk.h and > > trace_bar() in generated-tracers-memory.h. Source files using tracing > > would need to include headers for relevant sections. > > > > This way we can n

[Qemu-devel] [PATCH for-2.6 05/14] pc-bios/s390-ccw: update virtio implementation to allow up to 3 vrings

2016-03-18 Thread Cornelia Huck
From: "Eugene (jno) Dvurechenski" Add ability to work with up to 3 vrings, which is required for virtio-scsi implementation. Implement the optional cookie to speed up processing of virtio notifications. Reviewed-by: Cornelia Huck Signed-off-by: Eugene (jno) Dvurechenski Signed-off-by: Cornelia

Re: [Qemu-devel] [PATCH 00/15] Clean up around osdep.h and qemu-common.h

2016-03-18 Thread Paolo Bonzini
On 18/03/2016 10:05, Peter Maydell wrote: > If Paolo wants to provide an R-by I'm happy to take them for > 2.6 -- the possible failure modes are basically just "something > stops compiling" which should be an easy fix if it happens. > You could make my life easier by sticking them in a pullreq.

Re: [Qemu-devel] [PATCH 4/5] tcg: reorder removal from lists in tb_phys_invalidate

2016-03-18 Thread Sergey Fedorov
On 17/03/16 18:09, Paolo Bonzini wrote: On 17/03/2016 14:46, sergey.fedo...@linaro.org wrote: void tb_phys_invalidate(TranslationBlock *tb, tb_page_addr_t page_addr) { -CPUState *cpu; PageDesc *p; unsigned int h, n1; +tb_page_addr_t pc; tb_page_addr_t phys_pc;

[Qemu-devel] [PULL 33/40] ivshmem: Inline check_shm_size() into its only caller

2016-03-18 Thread Markus Armbruster
Improve the error messages while there. Signed-off-by: Markus Armbruster Message-Id: <1458066895-20632-34-git-send-email-arm...@redhat.com> Reviewed-by: Marc-André Lureau --- hw/misc/ivshmem.c | 37 +++-- 1 file changed, 11 insertions(+), 26 deletions(-) diff --

[Qemu-devel] [PULL 13/21] hw/intc: Add (new) ASPEED VIC device model

2016-03-18 Thread Peter Maydell
From: Andrew Jeffery Implement a basic ASPEED VIC device model for the AST2400 SoC[1], with enough functionality to boot an aspeed_defconfig Linux kernel. The model implements the 'new' (revised) register set: While the hardware exposes both the new and legacy register sets, accesses to the model

[Qemu-devel] [PATCH v5 1/7] block: add flag to indicate that no I/O will be performed

2016-03-18 Thread Daniel P. Berrange
When opening an image it is useful to know whether the caller intends to perform I/O on the image or not. In the case of encrypted images this will allow the block driver to avoid having to prompt for decryption keys when we merely want to query header metadata about the image. eg qemu-img info Th

Re: [Qemu-devel] [PATCH] qemu-ga: drop unused local err variable

2016-03-18 Thread Michael Roth
Quoting Stefan Hajnoczi (2016-03-16 10:16:02) > Commit 125b310e1d62e3a1dc1e7758563e598957ca7ae4 ("qemu-ga: move > channel/transport functionality into wrapper class") stopped using the > local err variable in channel_event_cb(). > > This patch deletes the unused variable. > > Signed-off-by: Stefa

[Qemu-devel] [PULL 10/40] ivshmem: Rewrite specification document

2016-03-18 Thread Markus Armbruster
This started as an attempt to update ivshmem_device_spec.txt for clarity, accuracy and completeness while working on its code, and quickly became a full rewrite. Since the diff would be useless anyway, I'm using the opportunity to rename the file to ivshmem-spec.txt. I tried hard to ensure the ne

[Qemu-devel] [PULL v2 07/13] crypto: add support for the serpent cipher algorithm

2016-03-18 Thread Daniel P. Berrange
New cipher algorithms 'serpent-128', 'serpent-192' and 'serpent-256' are defined for the Serpent algorithm. The nettle and gcrypt cipher backends are updated to support the new cipher and a test vector added to the cipher test suite. The new algorithm is enabled in the LUKS block encryption driver

[Qemu-devel] [PATCH v2 10/16] nfs: replace aio_poll with bdrv_drain

2016-03-18 Thread Paolo Bonzini
Reviewed-by: Fam Zheng Signed-off-by: Paolo Bonzini --- block/nfs.c | 50 ++ 1 file changed, 30 insertions(+), 20 deletions(-) diff --git a/block/nfs.c b/block/nfs.c index 7220e89..5cebb83 100644 --- a/block/nfs.c +++ b/block/nfs.c @@ -48,6 +48,7

[Qemu-devel] [PATCH v4 00/17] blockdev: Further BlockBackend work

2016-03-18 Thread Max Reitz
This series appears to reinvent itself with every revision. This time, its main implication is that BBs are no longer automatically treated as monitor-owned, and that a BB's name is tightly tied to the monitor reference (it is considered equivalent to that reference). v4: - Tightly tied a BB's na

Re: [Qemu-devel] [PATCH 0/2] e1000: Introducing an upper bound of interrupts

2016-03-18 Thread Denis V. Lunev
On 03/17/2016 10:37 AM, Sameeh Jubran wrote: This patch series introduces an upper bound for the number of interrupts per second. This feature is supported by the real hardware, however up until now it wasn't implemented in e1000. This feature is very significant, it can prevent an interrupt stor

Re: [Qemu-devel] [PATCH v4 6/9] hw/timer: QOM'ify milkymist_sysctl

2016-03-18 Thread michael
[I had some problems with my mailserver and the v5 version didn't make it through. I know there is a v5 version of this patch series and I've tested with the v5 version] Am 2016-02-22 04:15, schrieb xiaoqiang zhao: * split the old SysBus init function into an instance_init and a Device reali

[Qemu-devel] [PULL 08/29] block: Drop BB name from bad option error

2016-03-18 Thread Kevin Wolf
From: Max Reitz The information which BB is concerned does not seem useful enough to justify its existence in most other place (which may be related to qemu printing the -drive parameter in question anyway, and for blockdev-add the attribution is naturally unambiguous). Furthermore, as of a futur

[Qemu-devel] [PATCH for-2.6 08/14] pc-bios/s390-ccw: add simplified virtio call

2016-03-18 Thread Cornelia Huck
From: "Eugene (jno) Dvurechenski" Add virtio_run(VirtioCmd) call to use simple declarative approach. Signed-off-by: Eugene (jno) Dvurechenski Signed-off-by: Cornelia Huck --- pc-bios/s390-ccw/virtio.c | 17 + pc-bios/s390-ccw/virtio.h | 9 + 2 files changed, 26 insert

Re: [Qemu-devel] [PATCH v4] net: Allocating Large sized arrays to heap

2016-03-18 Thread Stefan Hajnoczi
On Thu, Mar 17, 2016 at 09:17:40PM +0530, Pooja Dhannawat wrote: > nc_sendv_compat has a huge stack usage of 69680 bytes approx. > Moving large arrays to heap to reduce stack usage. > > Signed-off-by: Pooja Dhannawat > --- > net/net.c | 13 + > 1 file changed, 9 insertions(+), 4 dele

[Qemu-devel] [PULL 06/21] i.MX: Allow GPT timer to rollover.

2016-03-18 Thread Peter Maydell
From: Jean-Christophe Dubois GPT timer need to rollover when it reaches 0x. It also need to reset to 0 when in "restart mode" and crossing the compare 1 register. Reviewed-by: Peter Maydell Signed-off-by: Jean-Christophe Dubois Message-id: 6e2b36117a249a78bf822dd59a390368f407136e.145

[Qemu-devel] [RFC v1 00/11] Base enabling patches for MTTCG

2016-03-18 Thread Alex Bennée
Hi, This RFC patch set aims to provide the basic framework for MTTCG. I've tried to pull together the non-contentious bits that other trees can then build on. This is because we have multiple potential solutions for things like deferring work and handling atomics. The idea being that those bits co

[Qemu-devel] [PULL 07/40] ivshmem-test: Improve test case /ivshmem/single

2016-03-18 Thread Markus Armbruster
Test state of registers after reset. Test reading Interrupt Status clears it. Test (invalid) read of Doorbell. Add more comments. Signed-off-by: Markus Armbruster Reviewed-by: Marc-André Lureau Message-Id: <1458066895-20632-8-git-send-email-arm...@redhat.com> --- tests/ivshmem-test.c | 23 ++

[Qemu-devel] [PULL 19/21] bcm2835_property: implement framebuffer control/configuration properties

2016-03-18 Thread Peter Maydell
From: Grégory ESTRADE The property channel driver now interfaces with the framebuffer device to query and set framebuffer parameters. As a result of this, the "get ARM RAM size" query now correctly returns the video RAM base address (not total RAM size), and the ram-size property is no longer rel

Re: [Qemu-devel] [PATCH 2/5] trace: [all] Add "guest_vmem" event

2016-03-18 Thread Lluís Vilanova
Peter Maydell writes: > On 23 February 2016 at 18:22, Lluís Vilanova wrote: >> Signed-off-by: Lluís Vilanova >> +### Guest events, keep at bottom >> + >> +# @vaddr: Access' virtual address. >> +# @size : Access' size (bytes). >> +# @store: Whether the access is a store. >> +# >> +# Start virtua

Re: [Qemu-devel] [PATCH v5 6/7] block: add generic full disk encryption driver

2016-03-18 Thread Daniel P. Berrange
On Fri, Mar 18, 2016 at 01:09:35PM +0100, Kevin Wolf wrote: > Am 17.03.2016 um 18:51 hat Daniel P. Berrange geschrieben: > > Add a block driver that is capable of supporting any full disk > > encryption format. This utilizes the previously added block > > encryption code, and at this time supports

Re: [Qemu-devel] [PATCH v2] firmware: qemu_fw_cfg.c: hold ACPI global lock during device access

2016-03-18 Thread Gabriel L. Somlo
On Wed, Mar 16, 2016 at 06:57:01PM +0200, Michael S. Tsirkin wrote: > On Tue, Mar 08, 2016 at 01:30:50PM -0500, Gabriel Somlo wrote: > > Allowing for the future possibility of implementing AML-based > > (i.e., firmware-triggered) access to the QEMU fw_cfg device, > > acquire the global ACPI lock wh

Re: [Qemu-devel] Timer interrupts for -M raspi2

2016-03-18 Thread Antonio Huete Jiménez
Hi Andrew, Yeah, that's what I think. I believe I must be overlooking something but I just can't find what. With regards to the ARM Generic timer, I have set the enable bit[0] for CNTP_CTL and also I've set CNTP_TVAL, that's why I think the interrupt is triggered on the real hardware. I

[Qemu-devel] [PULL 21/40] ivshmem: Assert interrupts are set up once

2016-03-18 Thread Markus Armbruster
An interrupt is set up when the interrupt's file descriptor is received. Each message applies to the next interrupt vector. Therefore, each vector cannot be set up more than once. ivshmem_add_kvm_msi_virq() half-heartedly tries not to rely on this by doing nothing then, but that's not going to re

[Qemu-devel] [PULL 21/29] block: Use blk_co_preadv() for blk_read()

2016-03-18 Thread Kevin Wolf
This patch introduces blk_co_preadv() as a central function on the BlockBackend level that is supposed to handle all read requests from the BB to its root BDS eventually. Signed-off-by: Kevin Wolf --- block/block-backend.c | 64 --- block/io.c

Re: [Qemu-devel] [PATCH] qdev_try_create(): Assert that devices we put onto the system bus are SysBusDevices

2016-03-18 Thread Peter Maydell
On 16 March 2016 at 14:14, Andreas Färber wrote: > Am 16.03.2016 um 15:11 schrieb Peter Maydell: >> If qdev_try_create() is passed NULL for the bus, it will automatically >> put the newly created device onto the default system bus. However >> if the device is not actually a SysBusDevice then this

Re: [Qemu-devel] [PATCH v2] vl.c: disallow command line fw cfg without opt/

2016-03-18 Thread Paolo Bonzini
I frankly think it's overengineered, but it's already much better and if it helps converging to a compromise why not. Alternatives to your proposals follow: On 17/03/2016 14:13, Michael S. Tsirkin wrote: > > QEMU command line: > A. -fw-cfg RFQDN/PATH prepends usr/. So users will not get co

[Qemu-devel] [PATCH 2/2] ARM: Virt: Use gpio_key for power button

2016-03-18 Thread Shannon Zhao
From: Shannon Zhao There is a problem for power button that it will not work if an early system_powerdown request happens before guest gpio driver loads. Fix this problem by using gpio_key. Signed-off-by: Shannon Zhao --- hw/arm/virt.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions

Re: [Qemu-devel] [PATCH][RFC] IOMMU: Add Support to VFIO devices with vIOMMU present

2016-03-18 Thread Aviv B.D.
On Tue, Mar 15, 2016 at 12:53 PM, Michael S. Tsirkin wrote: > On Sat, Mar 12, 2016 at 06:13:17PM +0200, Aviv B.D. wrote: > > From: "Aviv B.D." > > > > * Fix bug that prevent qemu from starting up when vIOMMU and VFIO > > device are present. > > * Advertise Cache Mode capability in iommu ca

Re: [Qemu-devel] [PATCH 4/4] hw/audio: QOM'ify milkymist-ac97.c

2016-03-18 Thread xiaoqiang zhao
在 2016年03月17日 00:30, Paolo Bonzini 写道: On 16/03/2016 10:24, xiaoqiang zhao wrote: s->voice_out = AUD_open_out(&s->card, s->voice_out, "mm_ac97.out", s, ac97_out_cb, &as); AUD_open_out should not be done before realize. Paolo I wil move it to DeviceClasss::realize in

Re: [Qemu-devel] [PATCH v6 16/16] qapi: Consolidate object visitors

2016-03-18 Thread Markus Armbruster
Eric Blake writes: > Rather than having two separate visitor callbacks with items > already broken out, pass the actual QAPISchemaObjectType object > to the visitor. This lets the visitor access things like > type.is_implicit() without needing another parameter, resolving > a TODO from previous

[Qemu-devel] [PULL 13/15] qapi: Make BlockdevOptions doc example closer to reality

2016-03-18 Thread Markus Armbruster
From: Eric Blake Although we don't want to repeat the entire BlockdevOptions QMP command in the example, it helps if we aren't needlessly diverging (the initial example was written before we had committed the actual QMP interface). Use names that match what is found in qapi/block-core.json, such

Re: [Qemu-devel] [PATCH v3 0/2] spapr: QMP: add query-hotpluggable-cpus

2016-03-18 Thread Igor Mammedov
On Wed, 16 Mar 2016 20:29:59 +0100 Christian Borntraeger wrote: > On 03/15/2016 02:24 PM, Igor Mammedov wrote: > > Changes since v2: > > - rebase on top of hte lates spapr cpu hotpug series > > - add 'vcpus-count' field, pkre...@redhat.com > > - s/CpuInstanceProps/CpuInstanceProperties/ > > -

[Qemu-devel] [PATCH 1/2] e1000: Fixing interrupts pace.

2016-03-18 Thread Sameeh Jubran
This patch introduces an upper bound for number of interrupts per second. Without this bound an interrupt storm can occur as it has been observed on Windows 10 when disabling the device. According to the SPEC - Intel PCI/PCI-X Family of Gigabit Ethernet Controllers Software Developer's Manual, sec

Re: [Qemu-devel] [PATCH V4] hw/pxb: add chassis_nr property

2016-03-18 Thread Cao jin
hi On 03/15/2016 07:44 PM, Marcel Apfelbaum wrote: On 03/15/2016 10:00 AM, Cao jin wrote: And I have another personal question: In qemu design, it seems every pci bridge reside in a separate chassis, what`s benefit? why don`t put them all in the main chassis? Please have a look on pci-to-

Re: [Qemu-devel] [PATCH 1/3] hw/net/spapr_llan: Extract rx buffer code into separate functions

2016-03-18 Thread Laurent Vivier
On 16/03/2016 13:16, Thomas Huth wrote: > Refactor the code a little bit by extracting the code that reads > and writes the receive buffer list page into separate functions. > There should be no functional change in this patch, this is just > a preparation for the upcoming extensions that introdu

[Qemu-devel] [PULL 14/21] hw/arm: Add ASPEED AST2400 SoC model

2016-03-18 Thread Peter Maydell
From: Andrew Jeffery While the ASPEED AST2400 SoC[1] has a broad range of capabilities this implementation is minimal, comprising an ARM926 processor, ASPEED VIC and timer devices, and a 8250 UART. [1] http://www.aspeedtech.com/products.php?fPath=20&rId=376 Signed-off-by: Andrew Jeffery Messag

[Qemu-devel] [PATCH v2 1/4] hw/audio: QOM'ify cs4231.c

2016-03-18 Thread xiaoqiang zhao
Drop the old SysBus init function and use instance_init Signed-off-by: xiaoqiang zhao --- hw/audio/cs4231.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/hw/audio/cs4231.c b/hw/audio/cs4231.c index caf97c1..30690f9 100644 --- a/hw/audio/cs4231.c +++ b/hw/audio/

Re: [Qemu-devel] [RFC PATCH v2 0/9] Core based CPU hotplug for PowerPC sPAPR

2016-03-18 Thread Igor Mammedov
On Wed, 16 Mar 2016 09:18:03 +0530 Bharata B Rao wrote: > On Mon, Mar 14, 2016 at 10:47:28AM +0100, Igor Mammedov wrote: > > On Fri, 11 Mar 2016 10:24:29 +0530 > > Bharata B Rao wrote: > > > > > Hi, > > > > > > This is the next version of "Core based CPU hotplug for PowerPC sPAPR" > > > tha

Re: [Qemu-devel] [PATCH v2] vl.c: disallow command line fw cfg without opt/

2016-03-18 Thread Michael S. Tsirkin
On Wed, Mar 16, 2016 at 07:35:09PM +0100, Laszlo Ersek wrote: > OVMF uses this feature for a few flags. They are all called > "opt/ovmf/...". I followed the advice in "docs/specs/fw_cfg.txt" (which > shouldn't be surprising since I seem to have reviewed every patch for > that file): Wait a second.

Re: [Qemu-devel] [PATCH 0/4] Tweaks around virtio-blk start/stop

2016-03-18 Thread Paolo Bonzini
On 16/03/2016 13:42, Cornelia Huck wrote: > On Wed, 16 Mar 2016 13:32:59 +0100 > Paolo Bonzini wrote: > >> On 16/03/2016 13:22, Cornelia Huck wrote: > Yeah, it doesn't help that the functions are underdocumented (as in the > "assign" parameter above). >>> My understanding is: >>> >>> -

Re: [Qemu-devel] basic block tracing question

2016-03-18 Thread Tim Newsham
On Wed, Mar 16, 2016 at 10:52 AM, Peter Maydell wrote: > > If you only emit tracing information after the TB has executed and > returned then you will miss the case where we execute half a TB > and take an exception (eg load/store that page faulted, or system call), > because in that case we'll l

[Qemu-devel] [PATCH v6 07/16] qapi-event: Utilize implicit struct visits

2016-03-18 Thread Eric Blake
Rather than generate inline per-member visits, take advantage of the 'visit_type_FOO_members()' function for emitting events. This is possible now that implicit structs can be visited like any other. Generated code shrinks accordingly; by initializing a struct based on parameters, through a new ge

[Qemu-devel] [PATCH 03/20] qemu-io: Call blk_set_enable_write_cache() explicitly

2016-03-18 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- qemu-io.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/qemu-io.c b/qemu-io.c index d7c2f26..260b024 100644 --- a/qemu-io.c +++ b/qemu-io.c @@ -50,7 +50,7 @@ static const cmdinfo_t close_cmd = { .oneline= "close t

Re: [Qemu-devel] [PATCH v4 3/9] hw/timer: QOM'ify lm32_timer

2016-03-18 Thread Peter Maydell
On 17 March 2016 at 14:59, wrote: > [I had some problems with my mailserver and the v5 version didn't make it > through. I know there is a v5 version of this patch series and I've tested > with the v5 version] > > > Am 2016-02-22 04:15, schrieb xiaoqiang zhao: >> >> * split the old SysBus init fu

[Qemu-devel] [PATCH v5 18/28] migration: convert savevm to use QIOChannel for writing to files

2016-03-18 Thread Daniel P. Berrange
Convert the exec savevm code to use QIOChannel and QEMUFileChannel, instead of the stdio APIs. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrange --- migration/savevm.c | 8 +--- tests/Makefile | 4 ++-- tests/test-vmstate.c | 11 ++- 3 files changed, 17

  1   2   >