Re: [Qemu-devel] [PATCH] migration: allow clearing migration string parameters

2017-03-14 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Markus Armbruster (arm...@redhat.com) wrote: >> "Daniel P. Berrange" writes: >> >> > On Wed, Mar 01, 2017 at 08:36:03AM -0600, Eric Blake wrote: >> >> On 03/01/2017 06:32 AM, Daniel P. Berrange wrote: >> >> > } >> >> > if (params->has_tls_creds) {

Re: [Qemu-devel] [PATCH v2 0/2] hw/i386: Update FADT to Revision 3 (ACPI 2.0)

2017-03-14 Thread Phil Dennis-Jordan
On 15 March 2017 at 08:29, Michael S. Tsirkin wrote: > > On Sat, Mar 11, 2017 at 10:06:22PM -0800, no-re...@patchew.org wrote: > > Hi, > > > > This series failed automatic build test. Please find the testing commands > > and > > their output below. If you have docker installed, you can probably

[Qemu-devel] [PATCH v3 2/2] hw/i386: Build-time assertion on pc/q35 reset register being identical.

2017-03-14 Thread Phil Dennis-Jordan
This adds a clarifying comment and build time assert to the FADT reset register field initialisation: the reset register is the same on both machine types. Signed-off-by: Phil Dennis-Jordan --- hw/i386/acpi-build.c | 3 +++ hw/pci-host/piix.c | 6 -- include/hw/i386/pc.h | 6 ++ 3 fil

[Qemu-devel] [PATCH v3 1/2] hw/i386: Use Rev3 FADT (ACPI 2.0) instead of Rev1 to improve guest OS support.

2017-03-14 Thread Phil Dennis-Jordan
This updates the FADT generated for x86/64 machine types from Revision 1 to 3. (Based on ACPI standard 2.0 instead of 1.0) The intention is to expose the reset register information to guest operating systems which require it, specifically OS X/macOS. Revision 1 FADTs do not contain the fields re

[Qemu-devel] [PATCH v3 0/2] hw/i386: Update FADT to Revision 3 (ACPI 2.0)

2017-03-14 Thread Phil Dennis-Jordan
This updates the FADT generated for x86/64 machine types from Revision 1 to 3. (Based on ACPI standard 2.0 instead of 1.0) As previously, the goal is to make running macOS/OS X guests smoother. With a Rev1 FADT, rebooting such a guest doesn't work, as the OS uses the reset register information f

Re: [Qemu-devel] [PATCH for-2.10 6/8] ppc/pnv: Add cut down PSI bridge model and hookup external interrupt

2017-03-14 Thread David Gibson
On Wed, Mar 08, 2017 at 11:52:49AM +0100, Cédric Le Goater wrote: > From: Benjamin Herrenschmidt > > The PSI (Processor Service Interface) Controller is one of the engines > of the "Bridge" unit which connects the different interfaces to the > Power Processor. > > This adds just enough of the PS

[Qemu-devel] [PATCH v3] memory: reduce heap Rss size around 3M

2017-03-14 Thread Yang Zhong
Since cpu-memory and memory have same address space,one malloced memory is enough. This patch will skip memory malloc for memory address space,which will reduce around 3M physical memory in heap. Signed-off-by: Yang Zhong --- memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

Re: [Qemu-devel] [PATCH for-2.10 1/8] ppc/xics: add a xics_get_cpu_index_by_pir() helper

2017-03-14 Thread David Gibson
On Tue, Mar 14, 2017 at 06:00:43PM +0100, Cédric Le Goater wrote: > On 03/14/2017 06:38 AM, David Gibson wrote: > > On Wed, Mar 08, 2017 at 11:52:44AM +0100, Cédric Le Goater wrote: > >> This helper will be used to translate the server number of the XIVE > >> (which is a PIR) into an ICPState index

Re: [Qemu-devel] [PULL for-2.9 0/1] Block patches

2017-03-14 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PULL for-2.9 0/1] Block patches Message-id: 20170315050602.7750-1-stefa...@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --onelin

[Qemu-devel] [PULL for-2.9 1/1] os: don't corrupt pre-existing memory-backend data with prealloc

2017-03-14 Thread Stefan Hajnoczi
From: "Daniel P. Berrange" When using a memory-backend object with prealloc turned on, QEMU will memset() the first byte in every memory page to zero. While this might have been acceptable for memory backends associated with RAM, this corrupts application data for NVDIMMs. Instead of setting eve

[Qemu-devel] [PULL for-2.9 0/1] Block patches

2017-03-14 Thread Stefan Hajnoczi
The following changes since commit d84f714eafedd8bb9d4aaec8b76417bef8e3535e: Update version for v2.9.0-rc0 release (2017-03-14 19:18:23 +) are available in the git repository at: git://github.com/stefanha/qemu.git tags/block-pull-request for you to fetch changes up to 9dc44aa5829eb3131a

[Qemu-devel] [Bug 893068] Re: Spanish keys { and [ did not work

2017-03-14 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/893068 Title: Spanish keys

[Qemu-devel] [Bug 886621] Re: Mac OS X Lion: segmentation fault

2017-03-14 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/886621 Title: Mac OS X Lio

Re: [Qemu-devel] [PATCH] memory: info mtree check mr range overflow

2017-03-14 Thread Michael S. Tsirkin
On Wed, Mar 15, 2017 at 12:04:27PM +0800, Peter Xu wrote: > On Wed, Mar 15, 2017 at 05:30:56AM +0200, Michael S. Tsirkin wrote: > > On Wed, Mar 15, 2017 at 11:15:50AM +0800, Peter Xu wrote: > > > On Wed, Mar 15, 2017 at 03:24:04AM +0200, Michael S. Tsirkin wrote: > > > > On Tue, Mar 14, 2017 at 08:

Re: [Qemu-devel] [PATCH] Output dirty-bytes-rate instead of dirty-pages-rate

2017-03-14 Thread Chao Fan
On Tue, Mar 14, 2017 at 12:37:30PM +, Daniel P. Berrange wrote: >On Tue, Mar 14, 2017 at 01:29:43PM +0100, Juan Quintela wrote: >> Chao Fan wrote: >> > In hmp, dirty-bytes-rate is more friendly than dirty-pages-rate. >> > It's also better for other tools to determine the cpu throttle >> > valu

Re: [Qemu-devel] [PATCH] memory: info mtree check mr range overflow

2017-03-14 Thread Peter Xu
On Wed, Mar 15, 2017 at 05:30:56AM +0200, Michael S. Tsirkin wrote: > On Wed, Mar 15, 2017 at 11:15:50AM +0800, Peter Xu wrote: > > On Wed, Mar 15, 2017 at 03:24:04AM +0200, Michael S. Tsirkin wrote: > > > On Tue, Mar 14, 2017 at 08:56:27PM +0800, Peter Xu wrote: > > > > The address of memory regio

[Qemu-devel] [PATCH v2] migration/block: Avoid invoking blk_drain too frequently

2017-03-14 Thread Lidong Chen
Increase bmds->cur_dirty after submit io, so reduce the frequency involve into blk_drain, and improve the performance obviously when block migration. The performance test result of this patch: During the block dirty save phase, this patch improve guest os IOPS from 4.0K to 9.5K. and improve the m

Re: [Qemu-devel] [PATCH v1] Provided python3 support for qmp.py

2017-03-14 Thread Stefan Hajnoczi
On Mon, Mar 06, 2017 at 02:43:50PM +0300, Joannah Nanjekye wrote: > From: Joannah Najekye > > Signed-off-by: Joannah Nanjekye > --- > > The patch provides python 3 support for one of the scripts in scripts/qmp > that is to say qmp.py. This is not a port to python 3 but rather the patch > ens

Re: [Qemu-devel] [PATCH] memory: info mtree check mr range overflow

2017-03-14 Thread Michael S. Tsirkin
On Wed, Mar 15, 2017 at 11:15:50AM +0800, Peter Xu wrote: > On Wed, Mar 15, 2017 at 03:24:04AM +0200, Michael S. Tsirkin wrote: > > On Tue, Mar 14, 2017 at 08:56:27PM +0800, Peter Xu wrote: > > > The address of memory regions might overflow when something wrong > > > happened, like reported in: > >

Re: [Qemu-devel] [PATCH v1] Provided python3 support for qmp.py

2017-03-14 Thread Stefan Hajnoczi
On Mon, Mar 06, 2017 at 02:43:50PM +0300, Joannah Nanjekye wrote: > From: Joannah Najekye > > Signed-off-by: Joannah Nanjekye > --- Text below '---' is not included as part of the commit description. I think the following lines should be included, they describe the purpose of the patch. Pleas

Re: [Qemu-devel] [PATCH V3 2/3] virtio: destroy region cache during reset

2017-03-14 Thread Michael S. Tsirkin
On Wed, Mar 15, 2017 at 10:14:48AM +0800, Jason Wang wrote: > > > On 2017年03月14日 17:29, Cornelia Huck wrote: > > On Tue, 14 Mar 2017 11:01:41 +0800 > > Jason Wang wrote: > > > > > We don't destroy region cache during reset which can make the maps > > > of previous driver leaked to a buggy or ma

Re: [Qemu-devel] [PATCH] memory: info mtree check mr range overflow

2017-03-14 Thread Peter Xu
On Wed, Mar 15, 2017 at 03:24:04AM +0200, Michael S. Tsirkin wrote: > On Tue, Mar 14, 2017 at 08:56:27PM +0800, Peter Xu wrote: > > The address of memory regions might overflow when something wrong > > happened, like reported in: > > > > https://lists.gnu.org/archive/html/qemu-devel/2017-03/msg020

Re: [Qemu-devel] [PATCH] migration/block: Avoid involve into blk_drain too frequently

2017-03-14 Thread 858585 jemmy
On Wed, Mar 15, 2017 at 10:57 AM, Fam Zheng wrote: > On Wed, 03/15 10:28, 858585 jemmy wrote: >> On Tue, Mar 14, 2017 at 11:12 PM, Eric Blake wrote: >> > On 03/14/2017 02:57 AM, jemmy858...@gmail.com wrote: >> >> From: Lidong Chen >> >> >> >> Increase bmds->cur_dirty after submit io, so reduce t

Re: [Qemu-devel] [PATCH] block: Always call bdrv_child_check_perm first

2017-03-14 Thread Fam Zheng
On Tue, 03/14 08:28, Eric Blake wrote: > On 03/13/2017 09:30 PM, Fam Zheng wrote: > > bdrv_child_set_perm alone is not very usable because the caller must > > call bdrv_child_check_perm first. This is already encapsulated > > conveniently in bdrv_child_try_set_perm, so remove the other prototypes >

Re: [Qemu-devel] [PATCH] migration/block: Avoid involve into blk_drain too frequently

2017-03-14 Thread Fam Zheng
On Wed, 03/15 10:28, 858585 jemmy wrote: > On Tue, Mar 14, 2017 at 11:12 PM, Eric Blake wrote: > > On 03/14/2017 02:57 AM, jemmy858...@gmail.com wrote: > >> From: Lidong Chen > >> > >> Increase bmds->cur_dirty after submit io, so reduce the frequency involve > >> into blk_drain, and improve the

Re: [Qemu-devel] [PATCH] migration/block: Avoid involve into blk_drain too frequently

2017-03-14 Thread 858585 jemmy
On Tue, Mar 14, 2017 at 11:15 PM, Eric Blake wrote: > > On 03/14/2017 10:12 AM, Eric Blake wrote: > > On 03/14/2017 02:57 AM, jemmy858...@gmail.com wrote: > >> From: Lidong Chen > >> > >> Increase bmds->cur_dirty after submit io, so reduce the frequency involve > >> into blk_drain, and improve t

Re: [Qemu-devel] [PATCH] migration/block: Avoid involve into blk_drain too frequently

2017-03-14 Thread 858585 jemmy
On Tue, Mar 14, 2017 at 11:12 PM, Eric Blake wrote: > On 03/14/2017 02:57 AM, jemmy858...@gmail.com wrote: >> From: Lidong Chen >> >> Increase bmds->cur_dirty after submit io, so reduce the frequency involve >> into blk_drain, and improve the performance obviously when block migration. > > Long

Re: [Qemu-devel] [PATCH V3 2/3] virtio: destroy region cache during reset

2017-03-14 Thread Jason Wang
On 2017年03月14日 17:29, Cornelia Huck wrote: On Tue, 14 Mar 2017 11:01:41 +0800 Jason Wang wrote: We don't destroy region cache during reset which can make the maps of previous driver leaked to a buggy or malicious driver that don't set vring address before starting to use the device. Fix this

Re: [Qemu-devel] [PATCH V3 0/3] Several fixes for virito region caches

2017-03-14 Thread Jason Wang
On 2017年03月14日 16:35, Zhang Chen wrote: On 03/14/2017 11:01 AM, Jason Wang wrote: Hi: This series contains several fixes for virito region caches, please review. Title and comments typo: S/virito/virtio Thanks Zhang Chen Right. Thanks

Re: [Qemu-devel] [PATCH for-2.9 47/47] qapi: Fix a misleading parser error message

2017-03-14 Thread Eric Blake
On 03/13/2017 01:18 AM, Markus Armbruster wrote: > When choking on a token where an expression is expected, we report > 'Expected "{", "[" or string'. Close, but no cigar. Fix it to > Expected '"{", "[", string, boolean or "null"'. > > Missed in commit e53188a. Will need adjustment again if we

Re: [Qemu-devel] [PATCH for-2.9 46/47] qapi: Make pylint a bit happier

2017-03-14 Thread Eric Blake
On 03/13/2017 01:18 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > scripts/qapi-commands.py | 6 +++--- > scripts/qapi-visit.py| 1 - > scripts/qapi.py | 8 > 3 files changed, 7 insertions(+), 8 deletions(-) > Reviewed-by: Eric Blake -- Eric Bla

Re: [Qemu-devel] [PATCH for-2.9 45/47] qapi: Drop unused .check_clash() parameter schema

2017-03-14 Thread Eric Blake
On 03/13/2017 01:18 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > scripts/qapi.py | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) I'm not sure now why the 'schema' parameter was introduced; looks like it was in commit b807a1e and unused there. I think

Re: [Qemu-devel] [PATCH for-2.9 34/47] qapi: Move empty doc section checking to doc parser

2017-03-14 Thread Eric Blake
On 03/13/2017 01:23 AM, Markus Armbruster wrote: > Markus Armbruster writes: > >> Results in a more precise error location, but the real reason is >> emptying out check_docs() step by step. >> >> Signed-off-by: Markus Armbruster > > Perhaps we should simply drop this error condition. Are empty

Re: [Qemu-devel] [PATCH for-2.9 34/47] qapi: Move empty doc section checking to doc parser

2017-03-14 Thread Eric Blake
On 03/13/2017 01:18 AM, Markus Armbruster wrote: > Results in a more precise error location, but the real reason is > emptying out check_docs() step by step. > > Signed-off-by: Markus Armbruster > --- > scripts/qapi.py | 20 ++-- > tests/qapi-schema/doc-em

Re: [Qemu-devel] [PATCH for-2.9 44/47] qapi: union_types is a list used like a dict, make it one

2017-03-14 Thread Eric Blake
On 03/13/2017 01:18 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > scripts/qapi.py | 19 +++ > 1 file changed, 3 insertions(+), 16 deletions(-) > Reviewed-by: Eric Blake -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization libra

Re: [Qemu-devel] [PATCH for-2.9 43/47] qapi: struct_types is a list used like a dict, make it one

2017-03-14 Thread Eric Blake
On 03/13/2017 01:18 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > scripts/qapi.py | 21 - > 1 file changed, 4 insertions(+), 17 deletions(-) > Reviewed-by: Eric Blake -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization lib

Re: [Qemu-devel] [PATCH] memory: info mtree check mr range overflow

2017-03-14 Thread Michael S. Tsirkin
On Tue, Mar 14, 2017 at 08:56:27PM +0800, Peter Xu wrote: > The address of memory regions might overflow when something wrong > happened, like reported in: > > https://lists.gnu.org/archive/html/qemu-devel/2017-03/msg02043.html > > For easier debugging, let's try to detect it. > > Reported-by: M

[Qemu-devel] [RFC][PATCH 3/6] Add support for "bootonceindex" property.

2017-03-14 Thread Janne Huttunen
The property works just like the "bootindex" property does, but uses a separate list. When the list of boot devices is queried, the boot once list is consulted first. The normal list is returned only if the boot once list is empty. Signed-off-by: Janne Huttunen --- bootdevice.c| 11 +

Re: [Qemu-devel] [PATCH v1 1/1] vmstate: fix failed iotests case 68 and 91

2017-03-14 Thread QingFeng Hao
在 2017/3/14 22:13, Dr. David Alan Gilbert 写道: * QingFeng Hao (ha...@linux.vnet.ibm.com) wrote: This problem affects s390x only if we are running without KVM. Basically, S390CPU.irqstate is unused if we do not use KVM, and thus no buffer is allocated. This causes size=0, first_elem=NULL and n_e

Re: [Qemu-devel] [PATCH v2 1/9] configure: change CONFIG_XEN_BACKEND to be a target property

2017-03-14 Thread Greg Kurz
On Tue, 14 Mar 2017 13:23:09 -0700 (PDT) Stefano Stabellini wrote: > On Tue, 14 Mar 2017, Stefano Stabellini wrote: > > On Tue, 14 Mar 2017, Paolo Bonzini wrote: > > > On 14/03/2017 00:55, Stefano Stabellini wrote: > > > > CONFIG_XEN_BACKEND is currently set when the host supports Xen, > > >

Re: [Qemu-devel] [PATCH for-2.9 42/47] qapi: enum_types is a list used like a dict, make it one

2017-03-14 Thread Eric Blake
On 03/13/2017 01:18 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > scripts/qapi.py | 29 ++--- > 1 file changed, 6 insertions(+), 23 deletions(-) > Reviewed-by: Eric Blake No idea if python actually behaves more efficiently, but this is a nice

Re: [Qemu-devel] [PATCH for-2.9 41/47] qapi: Factor add_name() calls out of the meta conditional

2017-03-14 Thread Eric Blake
On 03/13/2017 01:18 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > scripts/qapi.py | 24 +--- > 1 file changed, 9 insertions(+), 15 deletions(-) > Reviewed-by: Eric Blake > def add_enum(definition, info): > global enum_types > -name = def

Re: [Qemu-devel] [PATCH for-2.9 40/47] qapi: Simplify what gets stored in enum_types

2017-03-14 Thread Eric Blake
On 03/13/2017 01:18 AM, Markus Armbruster wrote: > Don't invent a new dictionary structure just for enum_types, simply > store the defining expression, like we do for struct_types and > union_types. > > Signed-off-by: Markus Armbruster > --- > scripts/qapi.py | 29 +++-- >

[Qemu-devel] [ANNOUNCE] QEMU 2.9.0-rc0 is now available

2017-03-14 Thread Michael Roth
Hello, On behalf of the QEMU Team, I'd like to announce the availability of the first release candidate for the QEMU 2.9 release. This release is meant for testing purposes and should not be used in a production environment. http://download.qemu-project.org/qemu-2.9.0-rc0.tar.xz http://downl

Re: [Qemu-devel] [PATCH v3 1/2] X86: Move rdmsr/wrmsr functionality to standalone functions

2017-03-14 Thread Eduardo Habkost
Found something else that confused me: On Tue, Mar 14, 2017 at 02:16:32PM -0300, Eduardo Habkost wrote: [...] > +#if defined CONFIG_KVM && defined TARGET_X86_64 Why exactly are you making the hyperv MSRs x86_64-specific? I don't see anything at the QEMU code or kernel-side KVM code that makes it

Re: [Qemu-devel] [PATCH v2] use _Static_assert in QEMU_BUILD_BUG_ON

2017-03-14 Thread Richard Henderson
On 03/15/2017 02:59 AM, Andreas Grapentin wrote: QEMU_BUILD_BUG_ON should use C11's _Static_assert, if the compiler supports it, to provide more readable messages on failure. We check for _Static_assert in configure, and set CONFIG_STATIC_ASSERT accordingly. QEMU_BUILD_BUG_ON invokes _Static_ass

[Qemu-devel] [RFC][PATCH 6/6] Support "bootonceindex" property for SCSI disks.

2017-03-14 Thread Janne Huttunen
Signed-off-by: Janne Huttunen --- hw/scsi/scsi-bus.c | 3 +++ include/hw/block/block.h | 1 + 2 files changed, 4 insertions(+) diff --git a/hw/scsi/scsi-bus.c b/hw/scsi/scsi-bus.c index 5940cb1..26e38ab 100644 --- a/hw/scsi/scsi-bus.c +++ b/hw/scsi/scsi-bus.c @@ -2084,6 +2084,9 @@ static v

Re: [Qemu-devel] [PATCH v1 2/2] reduce qemu's heap Rss size from 12252kB to 2752KB

2017-03-14 Thread Xu, Anthony
> -Original Message- > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Tuesday, March 14, 2017 3:15 AM > To: Xu, Anthony > Cc: Zhong, Yang ; qemu-devel@nongnu.org; Peng, > Chao P > Subject: Re: [Qemu-devel] [PATCH v1 2/2] reduce qemu's heap Rss size from > 12252kB to 2752KB > >

Re: [Qemu-devel] Obsolete QEMU host environments

2017-03-14 Thread Richard Henderson
On 03/15/2017 03:07 AM, Peter Maydell wrote: On 14 March 2017 at 17:54, Thomas Huth wrote: Our ia64 host backend in QEMU (tcg/ia64) is still marked as maintained ... so it's maybe not as dead as you think? Or should we rather get rid of that soon, too? I don't actually mind whether we keep tc

Re: [Qemu-devel] [PATCH for-2.9 39/47] qapi: Drop unused variable events

2017-03-14 Thread Eric Blake
On 03/13/2017 01:18 AM, Markus Armbruster wrote: > Missed in commit e98859a > > Signed-off-by: Markus Armbruster > --- > scripts/qapi.py | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/scripts/qapi.py b/scripts/qapi.py > index 0da426a..12b1bda 100644 > --- a/scripts/qapi.py > +++ b/s

Re: [Qemu-devel] [PATCH for-2.9 38/47] qapi: Eliminate check_docs() and drop QAPIDoc.expr

2017-03-14 Thread Eric Blake
On 03/13/2017 01:18 AM, Markus Armbruster wrote: > Move what's left in check_docs() to check_expr(). Delegate the actual > checking to new QAPIDoc.check_expr(). > > QAPIDoc.expr is now unused; drop it. > > Signed-off-by: Markus Armbruster > --- > scripts/qapi.py | 27 ++

Re: [Qemu-devel] [PATCH for-2.9 37/47] qapi: Fix detection of bogus member documentation

2017-03-14 Thread Eric Blake
On 03/13/2017 01:18 AM, Markus Armbruster wrote: > check_definition_doc() checks for member documentation without a > matching member. It laboriously second-guesses what members > QAPISchema._def_exprs() will create. That's a stupid game. > > Move the check into QAPISchema.check(), where the mem

Re: [Qemu-devel] [PATCH for-2.9 36/47] tests/qapi-schema: Improve coverage of bogus member docs

2017-03-14 Thread Eric Blake
On 03/13/2017 01:18 AM, Markus Armbruster wrote: > New test doc-bad-union-member.json shows we can fail to reject > documentation for nonexistent members. > > Signed-off-by: Markus Armbruster > --- Reviewed-by: Eric Blake -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualiza

Re: [Qemu-devel] [PATCH for-2.9 35/47] tests/qapi-schema: Rename doc-bad-args to doc-bad-command-arg

2017-03-14 Thread Eric Blake
On 03/13/2017 01:18 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > tests/Makefile.include| 2 +- > tests/qapi-schema/doc-bad-args.err| 1 - > tests/qapi-schema/doc-bad-command-arg.err

Re: [Qemu-devel] [PATCH for-2.9 33/47] qapi: Improve error message on @NAME: in free-form doc

2017-03-14 Thread Eric Blake
On 03/13/2017 01:18 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > scripts/qapi.py | 17 ++--- > tests/qapi-schema/doc-invalid-section.err | 2 +- > 2 files changed, 7 insertions(+), 12 deletions(-) > Reviewed-by: Eric Blake --

Re: [Qemu-devel] [PATCH for-2.9 32/47] qapi: Move detection of doc / expression name mismatch

2017-03-14 Thread Eric Blake
On 03/13/2017 01:18 AM, Markus Armbruster wrote: > Move the check whether the doc matches the expression name from > check_definition_doc() to check_exprs(). This changes the error > location from the comment to the expression. Makes sense as the > message talks about the expresion: "Definition o

Re: [Qemu-devel] [PATCH for-2.9 30/47] tests/qapi-schema: Improve doc / expression mismatch coverage

2017-03-14 Thread Eric Blake
On 03/13/2017 01:18 AM, Markus Armbruster wrote: > New test doc-bad-expr.json shows we fail to reject a misplaced > expression comment. > > New test doc-no-symbol.json shows a bad error message. > > Signed-off-by: Markus Armbruster > --- > +++ b/tests/qapi-schema/doc-bad-expr.json > @@ -0,0 +1,

Re: [Qemu-devel] [PATCH for-2.9 31/47] qapi: Fix detection of doc / expression mismatch

2017-03-14 Thread Eric Blake
On 03/13/2017 01:18 AM, Markus Armbruster wrote: > This fixes the errors uncovered by the previous commit. > > Signed-off-by: Markus Armbruster > --- > > expr = self.get_expr(False) > if 'include' in expr: > +self.reject_expr_doc() > i

Re: [Qemu-devel] [PATCH Risu v2 2/3] configure: Add initial support to PPC64 (big endian)

2017-03-14 Thread joserz
On Mon, Mar 13, 2017 at 12:10:10PM +0100, Peter Maydell wrote: > On 9 March 2017 at 19:38, Jose Ricardo Ziviani > wrote: > > This commit set Makefile to point to ppc64le source for both archs > > (ppc64 and ppc64le) because they do the exact same thing. The > > difference is in risugen and how the

Re: [Qemu-devel] [PATCH v2 1/9] configure: change CONFIG_XEN_BACKEND to be a target property

2017-03-14 Thread Stefano Stabellini
On Tue, 14 Mar 2017, Stefano Stabellini wrote: > On Tue, 14 Mar 2017, Paolo Bonzini wrote: > > On 14/03/2017 00:55, Stefano Stabellini wrote: > > > CONFIG_XEN_BACKEND is currently set when the host supports Xen, > > > regardless of the chosen targets. As a consequence, Xen backends can be > > > ena

Re: [Qemu-devel] [PATCH v3 1/2] X86: Move rdmsr/wrmsr functionality to standalone functions

2017-03-14 Thread Eduardo Habkost
On Tue, Mar 14, 2017 at 02:16:32PM -0300, Eduardo Habkost wrote: > On Tue, Mar 14, 2017 at 03:08:06PM +0100, Julian Kirsch wrote: > > Add two new functions to provide read/write access to model specific > > registers > > (MSRs) on x86. Move original functionality to new functions > > x86_cpu_[rd|w

Re: [Qemu-devel] [PATCH for-2.9 17/47] qapi: The #optional tag is redundant, drop

2017-03-14 Thread Eric Blake
On 03/13/2017 01:18 AM, Markus Armbruster wrote: > We traditionally mark optional members #optional in the doc comment. > Before commit 3313b61, this was entirely manual. > > Commit 3313b61 added some automation because its qapi2texi.py relied > on #optional to determine whether a member is option

Re: [Qemu-devel] [PATCH v2 5/9] xen/9pfs: connect to the frontend

2017-03-14 Thread Stefano Stabellini
On Tue, 14 Mar 2017, Juergen Gross wrote: > On 14/03/17 00:55, Stefano Stabellini wrote: > > Write the limits of the backend to xenstore. Connect to the frontend. > > Upon connection, allocate the rings according to the protocol > > specification. > > > > Initialize a QEMUBH to schedule work upon

Re: [Qemu-devel] [PATCH v2 4/9] xen/9pfs: introduce Xen 9pfs backend

2017-03-14 Thread Stefano Stabellini
On Tue, 14 Mar 2017, Juergen Gross wrote: > On 14/03/17 00:55, Stefano Stabellini wrote: > > Introduce the Xen 9pfs backend: add struct XenDevOps to register as a > > Xen backend and add struct V9fsTransport to register as v9fs transport. > > > > All functions are empty stubs for now. > > > > Sig

[Qemu-devel] [PULL 0/1] Fix global property and -cpu handling bug

2017-03-14 Thread Eduardo Habkost
The following changes since commit d84f714eafedd8bb9d4aaec8b76417bef8e3535e: Update version for v2.9.0-rc0 release (2017-03-14 19:18:23 +) are available in the git repository at: git://github.com/ehabkost/qemu.git tags/machine-pull-request for you to fetch changes up to 0bcba41fe379e4c6

[Qemu-devel] [PULL 1/1] machine: Convert abstract typename on compat_props to subclass names

2017-03-14 Thread Eduardo Habkost
Original problem description by Greg Kurz: > Since commit "9a4c0e220d8a hw/virtio-pci: fix virtio > behaviour", passing -device virtio-blk-pci.disable-modern=off > has no effect on 2.6 machine types because the internal > virtio-pci.disable-modern=on compat property always prevail. The same bug a

Re: [Qemu-devel] [PATCH for-2.9 30/47] tests/qapi-schema: Improve doc / expression mismatch coverage

2017-03-14 Thread Eric Blake
On 03/13/2017 01:18 AM, Markus Armbruster wrote: > New test doc-bad-expr.json shows we fail to reject a misplaced > expression comment. > > New test doc-no-symbol.json shows a bad error message. > > Signed-off-by: Markus Armbruster > --- > +++ b/tests/qapi-schema/doc-no-symbol.err > @@ -0,0 +1

Re: [Qemu-devel] [PATCH for-2.9 29/47] qapi2texi: Use category "Object" for all object types

2017-03-14 Thread Eric Blake
On 03/13/2017 01:18 AM, Markus Armbruster wrote: > At the protocol level, the distinction between struct, flat union and > simple union is meaningless, they are all JSON objects. Document them > that way. > > Example change (qemu-qmp-ref.txt): > > - -- Simple Union: InputEvent > + -- Object: Inp

Re: [Qemu-devel] [PATCH for-2.9 28/47] qapi2texi: Generate descriptions for simple union tags

2017-03-14 Thread Eric Blake
On 03/13/2017 01:18 AM, Markus Armbruster wrote: > Simple union tags carry no type information, because their type is > implicit. Their description should make up for it, but many have > none. Generate one automatically then. > > Example change (qemu-qmp-ref.txt): > > -- Simple Union: ImageIn

Re: [Qemu-devel] [PATCH for-2.9 27/47] qapi2texi: Generate documentation for variant members

2017-03-14 Thread Eric Blake
On 03/13/2017 01:18 AM, Markus Armbruster wrote: > A flat union's branch brings in the members of another type. Generate > a suitable reference to that type. > > Example change (qemu-qmp-ref.txt): > > -- Flat Union: QCryptoBlockOpenOptions > > The options that are available for all encr

Re: [Qemu-devel] [PATCH] dma: rc4030: limit interval timer reload value

2017-03-14 Thread Peter Maydell
On 14 March 2017 at 19:17, Cole Robinson wrote: > I'm coming to this thread from the Fedora bug for this CVE, > https://bugzilla.redhat.com/show_bug.cgi?id=1384876 FWIW this isn't a CVE issue from the point of view of upstream QEMU, because it only affects the MIPS Jazz board, which (if I'm readi

Re: [Qemu-devel] [PATCH v2 0/2] hw/i386: Update FADT to Revision 3 (ACPI 2.0)

2017-03-14 Thread Michael S. Tsirkin
On Sat, Mar 11, 2017 at 10:06:22PM -0800, no-re...@patchew.org wrote: > Hi, > > This series failed automatic build test. Please find the testing commands and > their output below. If you have docker installed, you can probably reproduce > it > locally. > > Type: series > Subject: [Qemu-devel] [P

Re: [Qemu-devel] [PATCH for-2.9 26/47] qapi2texi: Generate reference to base type members

2017-03-14 Thread Eric Blake
On 03/13/2017 01:18 AM, Markus Armbruster wrote: > The generated documentation doesn't mention object type members > inherited from a base type. Fix that. > > Example change (qemu-qmp-ref.txt): > > -- Struct: VncServerInfo > > The network connection information for server > > Mem

Re: [Qemu-devel] [PATCH] dma: rc4030: limit interval timer reload value

2017-03-14 Thread Cole Robinson
On 11/16/2016 12:50 AM, Hervé Poussineau wrote: > Hi, > > Le 10/11/2016 à 15:50, Paolo Bonzini a écrit : >> >> >> On 10/11/2016 06:56, Gonglei (Arei) wrote: >>> Any ideas about this fix? >> >> It seems sensible, but perhaps the field is even smaller. Let's CC >> Hervé and Aurelien as I don't have

Re: [Qemu-devel] [PULL 00/18] Misc patches for QEMU 2.9 hard freeze

2017-03-14 Thread Peter Maydell
On 14 March 2017 at 16:18, Paolo Bonzini wrote: > The following changes since commit 94b5d57d2f5a3c849cecd65e424bb6f50b998df9: > > Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-2.9-20170314' > into staging (2017-03-14 10:13:19 +) > > are availa

Re: [Qemu-devel] [PATCH for-2.9 25/47] qapi2texi: Include member type in generated documentation

2017-03-14 Thread Eric Blake
On 03/13/2017 01:18 AM, Markus Armbruster wrote: > The recent merge of docs/qmp-commands.txt and docs/qmp-events.txt into > the schema lost type information. Fix this documentation regression. > > Example change (qemu-qmp-ref.txt): > > -- Struct: InputKeyEvent > > Keyboard input event.

Re: [Qemu-devel] [PATCH for-2.9 24/47] qapi2texi: Implement boxed argument documentation

2017-03-14 Thread Eric Blake
On 03/13/2017 01:18 AM, Markus Armbruster wrote: > This replaces manual references like "For the arguments, see the > documentation of ..." by a generated reference "Arguments: the members > of ...". > > Signed-off-by: Markus Armbruster > --- > qapi-schema.json | 2 +- > qapi/block-core.jso

Re: [Qemu-devel] [PATCH v2 1/9] configure: change CONFIG_XEN_BACKEND to be a target property

2017-03-14 Thread Stefano Stabellini
On Tue, 14 Mar 2017, Paolo Bonzini wrote: > On 14/03/2017 00:55, Stefano Stabellini wrote: > > CONFIG_XEN_BACKEND is currently set when the host supports Xen, > > regardless of the chosen targets. As a consequence, Xen backends can be > > enabled even on targets that don't support Xen. > > > > Fix

Re: [Qemu-devel] [PATCH 0/3] ide: ahci: fix memory leak in device unit

2017-03-14 Thread John Snow
On 03/13/2017 10:41 PM, Li Qiang wrote: > Hello John, > > Does this patch go to upstream? > > Thanks. > Yes, it will be included for 2.9. I usually send my PRs on Friday, but I was out of town so it got delayed. It qualifies as a bugfix though, so it can still go in. --js > 2017-03-04 6:48 GM

Re: [Qemu-devel] [PATCH for-2.9 23/47] qapi2texi: Don't hide undocumented members and arguments

2017-03-14 Thread Eric Blake
On 03/13/2017 01:18 AM, Markus Armbruster wrote: > Show undocumented object, alternate type members and command, event > arguments exactly like undocumented enumeration type values. > > Example change (qemu-qmp-ref.txt): > > -- Command: query-rocker > > Return rocker switch information.

Re: [Qemu-devel] [PATCH for-2.9 22/47] qapi2texi: Explain enum value undocumentedness more clearly

2017-03-14 Thread Eric Blake
On 03/13/2017 01:18 AM, Markus Armbruster wrote: > Instead of not saying anything when we have no documentation, say "Not > documented". > > Example change (qemu-qmp-ref.txt): > > -- Enum: GuestPanicAction > > An enumeration of the actions taken when guest OS panic is detected > >

Re: [Qemu-devel] [Qemu-arm] [PATCH v2 0/5] hw: arm: exynos: Bring up secondary CPU + CPUIDLE issue

2017-03-14 Thread Krzysztof Kozlowski
On Tue, Mar 14, 2017 at 06:24:33PM +, Alex Bennée wrote: > That means you're on a pre-mttcg tree so that's not the reason. I managed to build it on current master (v2.8.0-2182-g5e2fb7c598c6). It behaves the same (with "-accel tcg,thread=single": cannot reach switching to init). Best regards,

Re: [Qemu-devel] [PATCH] migration: allow clearing migration string parameters

2017-03-14 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > "Daniel P. Berrange" writes: > > > On Wed, Mar 01, 2017 at 08:36:03AM -0600, Eric Blake wrote: > >> On 03/01/2017 06:32 AM, Daniel P. Berrange wrote: > >> > } > >> > if (params->has_tls_creds) { > >> > g_free(s->parameters.tls_cr

Re: [Qemu-devel] [PATCH v4] xen: don't save/restore the physmap on VM save/restore

2017-03-14 Thread Stefano Stabellini
On Tue, 14 Mar 2017, Igor Druzhinin wrote: > Saving/restoring the physmap to/from xenstore was introduced to > QEMU majorly in order to cover up the VRAM region restore issue. > The sequence of restore operations implies that we should know > the effective guest VRAM address *before* we have the VR

Re: [Qemu-devel] [PATCH v2] use _Static_assert in QEMU_BUILD_BUG_ON

2017-03-14 Thread Andreas Grapentin
The missing ! is because I generated the error messages by inverting the condition and then forgot to change it back. I can send a v3 if you like. Thanks for being patient with me. -A On Tue, Mar 14, 2017 at 12:43:56PM -0500, Eric Blake wrote: > On 03/14/2017 11:59 AM, Andreas Grapentin wrote:

Re: [Qemu-devel] [LSF/MM TOPIC][LSF/MM, ATTEND] shared TLB, hugetlb reservations

2017-03-14 Thread Andrea Arcangeli
Hello, On Wed, Mar 08, 2017 at 05:30:55PM -0800, Mike Kravetz wrote: > On 01/10/2017 03:02 PM, Mike Kravetz wrote: > > Another more concrete topic is hugetlb reservations. Michal Hocko > > proposed the topic "mm patches review bandwidth", and brought up the > > related subject of areas in need of

Re: [Qemu-devel] [PATCH v3] xen: don't save/restore the physmap on VM save/restore

2017-03-14 Thread Stefano Stabellini
On Tue, 14 Mar 2017, Igor Druzhinin wrote: > On 13/03/17 21:15, Stefano Stabellini wrote: > > On Mon, 13 Mar 2017, Igor Druzhinin wrote: > >> Saving/restoring the physmap to/from xenstore was introduced to > >> QEMU majorly in order to cover up the VRAM region restore issue. > >> The sequence of re

Re: [Qemu-devel] [Qemu-arm] [PATCH v2 0/5] hw: arm: exynos: Bring up secondary CPU + CPUIDLE issue

2017-03-14 Thread Alex Bennée
That means you're on a pre-mttcg tree so that's not the reason. On 14 Mar 2017 5:35 pm, "Krzysztof Kozlowski" wrote: > On Tue, Mar 14, 2017 at 04:55:34PM +, Alex Bennée wrote: > > > > Krzysztof Kozlowski writes: > > > > > Hi, > > > > > > > > > > > Overview of the problem > > >

Re: [Qemu-devel] [PATCH for-2.9 21/47] qapi2texi: Present the table of members more clearly

2017-03-14 Thread Eric Blake
On 03/13/2017 01:18 AM, Markus Armbruster wrote: > The table of members follows the main descriptive text immediately. > Makes it hard to see what it is about. Start a new paragraph, and > lead with a line "Members:" for object and alternate types, "Values:" > for enumeration types, and "Arguments

Re: [Qemu-devel] [PATCH for-2.9 20/47] qapi2texi: Plainer enum value and member name formatting

2017-03-14 Thread Eric Blake
On 03/13/2017 01:18 AM, Markus Armbruster wrote: > Use @code{%s} instead of @code{'%s'}. Impact, using @id as example: > > * Texinfo > -@item @code{'id'} > +@item @code{id} > > * HTML > -'id' > +id > > * POD (for manual pages): > -=item C<'id'> > +=item C > > * Formatted manual pag

Re: [Qemu-devel] [PATCH for-2.9 19/47] qapi: Prefer single-quoted strings more consistently

2017-03-14 Thread Eric Blake
On 03/13/2017 01:18 AM, Markus Armbruster wrote: > PEP 8 advises: > > In Python, single-quoted strings and double-quoted strings are the > same. This PEP does not make a recommendation for this. Pick a > rule and stick to it. When a string contains single or double > quote chara

Re: [Qemu-devel] [PATCH for 2.9?] hmp: gpa2hva and gpa2hpa hostaddr command

2017-03-14 Thread Paolo Bonzini
On 14/03/2017 18:57, Dr. David Alan Gilbert wrote: > * Paolo Bonzini (pbonz...@redhat.com) wrote: >> These commands are useful when testing machine-check passthrough. >> gpa2hva is useful to inject a MADV_HWPOISON madvise from gdb, while >> gpa2hpa is useful to inject an error with the mce-inject

Re: [Qemu-devel] [PATCH for-2.9 18/47] qapi: Use raw strings for regular expressions consistently

2017-03-14 Thread Eric Blake
On 03/13/2017 01:18 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > scripts/qapi.py | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > Reviewed-by: Eric Blake -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://lib

Re: [Qemu-devel] [PATCH for-2.9 17/47] qapi: The #optional tag is redundant, drop

2017-03-14 Thread Eric Blake
On 03/13/2017 01:18 AM, Markus Armbruster wrote: > We traditionally mark optional members #optional in the doc comment. > Before commit 3313b61, this was entirely manual. > > Commit 3313b61 added some automation because its qapi2texi.py relied > on #optional to determine whether a member is option

Re: [Qemu-devel] [PATCH for 2.9?] hmp: gpa2hva and gpa2hpa hostaddr command

2017-03-14 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > These commands are useful when testing machine-check passthrough. > gpa2hva is useful to inject a MADV_HWPOISON madvise from gdb, while > gpa2hpa is useful to inject an error with the mce-inject kernel > module. > > Signed-off-by: Paolo Bonzini > ---

Re: [Qemu-devel] [PATCH] dma/rc4030: fix a mixed declarations and code warning

2017-03-14 Thread Hervé Poussineau
Le 14/03/2017 à 18:11, Yongbok Kim a écrit : Signed-off-by: Yongbok Kim Reviewed-by: Hervé Poussineau --- hw/dma/rc4030.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/dma/rc4030.c b/hw/dma/rc4030.c index 8ad97f1..4dbb4fd 100644 --- a/hw/dma/rc4030.c +++ b/hw/dma/r

Re: [Qemu-devel] [Qemu-ppc] qemu-system-ppc video artifacts since "tcg: drop global lock during TCG code execution"

2017-03-14 Thread luigi burdo
Zoltan, i tested on ppcel debian there isnt issue reported . i think is only a BE issue. Luigi Like from the display controller models that use memory_region_get_dirty() to check if the frambuffer needs to be updated? But all display adaptors seem to do this and the problem was only seem on

Re: [Qemu-devel] [PATCH v2] use _Static_assert in QEMU_BUILD_BUG_ON

2017-03-14 Thread Eric Blake
On 03/14/2017 11:59 AM, Andreas Grapentin wrote: > QEMU_BUILD_BUG_ON should use C11's _Static_assert, if the compiler supports > it, > to provide more readable messages on failure. > > with _Static_assert: > >> In file included from /qemu/include/qemu/osdep.h:36:0, >> from /qem

Re: [Qemu-devel] [Qemu-arm] [PATCH v2 0/5] hw: arm: exynos: Bring up secondary CPU + CPUIDLE issue

2017-03-14 Thread Krzysztof Kozlowski
On Tue, Mar 14, 2017 at 04:55:34PM +, Alex Bennée wrote: > > Krzysztof Kozlowski writes: > > > Hi, > > > > > > > Overview of the problem > > === > > On Exynos4210, by default Linux kernel uses cpuidle driver which tries > > to enter low power mode, called AFTR (Arm Off,

Re: [Qemu-devel] [Qemu-ppc] qemu-system-ppc video artifacts since "tcg: drop global lock during TCG code execution"

2017-03-14 Thread BALATON Zoltan
On Tue, 14 Mar 2017, Alex Bennée wrote: So from a single-threaded -smp guest case there should be no difference in behaviour. However cross-vCPU flushes are queued up using the async work queue and are dealt with in the target vCPU context. In the single threaded case it shouldn't matter as this

  1   2   3   4   >