Re: [Qemu-devel] Question: an IO hang problem

2018-03-14 Thread Fam Zheng
On Tue, 03/13 17:38, sochin.jiang wrote: > > Hi, guys, > > Recently, I encountered an IO hang problem in occasion which I cannot > reproduce it now. > > I analyzed this problem carefully, the critical stack is as following: > > > After reading the codes in linux-aio.c(see ioq_submit() func

[Qemu-devel] ARM64 Interrupt handling on QEMU

2018-03-14 Thread Brijen Raval
I am booting up a custom kernel on QEMU ARM64, upon completion of its initial boot up it looks like it enters the arch_idle() state I enabled the -d int logging to understand what is going on, I see the following repeated many times continuosly here after Taking exception 5 [IRQ] ...from EL1 to E

Re: [Qemu-devel] CVE-2018-7550 (was: multiboot: bss_end_addr can be zero / cleanup)

2018-03-14 Thread P J P
+-- On Wed, 14 Mar 2018, Kevin Wolf wrote --+ | Well, it seems to me that this patch was created for a different | purpose, but it happens to fix the bug for which this CVE was assigned | now. Right. I had sent another patch to fix it, there Jack mentioned about his series from before. | I th

Re: [Qemu-devel] regression in timer code?

2018-03-14 Thread Pavel Dovgalyuk
> From: Max Filippov [mailto:jcmvb...@gmail.com] > On Wed, Mar 14, 2018 at 2:53 AM, Pavel Dovgalyuk wrote: > > icount is adjusted by icount_warp_rt when CPU sleeps. > > These adjustments may be different in different runs. > > And the first adjustment is performed at the start of the machine. > >

Re: [Qemu-devel] Suggestion on 'virtio-pmem' implementation

2018-03-14 Thread Pankaj Gupta
Hi David, > > Hi Pankaj, > > I have a prototype (new one for virtio-mem I was working on over the last > weeks) for exactly what you need. I basically factored out the notion of a > memory device. So also virtio devices can be memory devices and get > recognized e.g. in formerly known pc_dimm_g

Re: [Qemu-devel] [PATCH] migration: Fix rate limiting issue on RDMA migration

2018-03-14 Thread 858585 jemmy
On Thu, Mar 15, 2018 at 4:19 AM, Dr. David Alan Gilbert wrote: > * Lidong Chen (jemmy858...@gmail.com) wrote: >> RDMA migration implement save_page function for QEMUFile, but >> ram_control_save_page do not increase bytes_xfer. So when doing >> RDMA migration, it will use whole bandwidth. > > Hi,

Re: [Qemu-devel] [PATCH 1/5] multiboot: Reject kernels exceeding the address space

2018-03-14 Thread Jack Schwartz
Hi Kevin. My comments are inline... On 2018-03-14 10:32, Kevin Wolf wrote: The code path with a manually set mh_load_addr in the Multiboot header checks that load_end_addr <= load_addr, but the path where load_end_addr is automatically detected if 0 is given in the header misses the correspondi

Re: [Qemu-devel] [PATCH 0/5] multiboot: Fix buffer overflow on invalid kernels

2018-03-14 Thread Jack Schwartz
Hi Kevin. I see an issue with the commit message of patch 1; please see my reply to that patch for details.  I fully understand patches 1,2,3, patch 4 except for some of the Makefile black magic, and patch 5 looks reasonable to me. So, for patches 2,3,4,5:     Reviewed-by: Jack Schwartz   

[Qemu-devel] [PULL 1/9] sii3112: Remove unneeded exit function

2018-03-14 Thread David Gibson
From: BALATON Zoltan An exit function was mistakenly left here but it's not needed because the PCI bars are organised differently in this device. Calling this exit function during device_del was causing an abort with memory_region_del_subregion: `Assertion subregion->container == mr' failed. Rep

[Qemu-devel] [PULL 4/9] hw/misc/macio: Mark the macio devices with user_creatable = false

2018-03-14 Thread David Gibson
From: Thomas Huth The macio devices currently cause a crash when the user tries to instantiate them on a different machine: $ ppc64-softmmu/qemu-system-ppc64 -device macio-newworld Unexpected error in qemu_chr_fe_init() at chardev/char-fe.c:222: qemu-system-ppc64: -device macio-newworld: Device

[Qemu-devel] [PULL 6/9] hw/ppc/spapr: Allow "spapr-vlan" as NIC model name beside "ibmveth"

2018-03-14 Thread David Gibson
From: Thomas Huth With the new "--nic" command line parameter option, the "old" way of specifying a NIC model via the nd_table[] is becoming more prominent again. But for the pseries "spapr-vlan" device, there is a confusing discrepancy between the model name that is used for "--device" (i.e. "sp

[Qemu-devel] [PULL 9/9] target/ppc: fix tlbsync to check privilege level depending on GTSE

2018-03-14 Thread David Gibson
From: Cédric Le Goater tlbsync also needs to check the Guest Translation Shootdown Enable (GTSE) bit in the Logical Partition Control Register (LPCR) to determine at which privilege level it is running. See commit c6fd28fd573d ("target/ppc: Update tlbie to check privilege level based on GTSE")

[Qemu-devel] [PULL 7/9] ppc440_pcix: Change some error_report to qemu_log_mask(LOG_UNIMP, ...)

2018-03-14 Thread David Gibson
From: BALATON Zoltan Using log unimp is more appropriate for these messages and this also silences them by default so they won't clobber make check output when tests are added for this board. Signed-off-by: BALATON Zoltan Reviewed-by: Thomas Huth Signed-off-by: David Gibson --- hw/ppc/ppc440

[Qemu-devel] [PULL 5/9] PPC e500: Fix gap between u-boot and kernel

2018-03-14 Thread David Gibson
From: David Engraf This patch moves the gap between u-boot and kernel at the correct location. Signed-off-by: David Engraf Signed-off-by: David Gibson --- hw/ppc/e500.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/hw/ppc/e500.c b/hw/ppc/e500.c index 43c15d18c4.

[Qemu-devel] [PULL 8/9] tests/boot-serial: Test the sam460ex board

2018-03-14 Thread David Gibson
From: Thomas Huth We've got a U-Boot firmware for this board in our repository, and the firmware prints some output to the serial console, so we can check this board in the boot-serial tester, too. Signed-off-by: Thomas Huth Signed-off-by: David Gibson --- tests/boot-serial-test.c | 2 ++ 1 f

[Qemu-devel] [PULL 0/9] ppc-for-2.12 queue 20180315

2018-03-14 Thread David Gibson
The following changes since commit 026aaf47c02b79036feb830206cfebb2a726510d: Merge remote-tracking branch 'remotes/ehabkost/tags/python-next-pull-request' into staging (2018-03-13 16:26:44 +) are available in the Git repository at: git://github.com/dgibson/qemu.git tags/ppc-for-2.12-201

[Qemu-devel] [PULL 3/9] hw/ppc/prep: Fix implicit creation of "-drive if=scsi" devices

2018-03-14 Thread David Gibson
From: Thomas Huth The global hack for creating SCSI devices has recently been removed, but this apparently broke SCSI devices on some boards that were not ready for this change yet. For the 40p machine you now get: $ ppc64-softmmu/qemu-system-ppc64 -M 40p -cdrom x.iso qemu-system-ppc64: -cdrom x

[Qemu-devel] [PULL 2/9] tests/boot-serial: Check the 40p machine, too

2018-03-14 Thread David Gibson
From: Thomas Huth The "40p" machine is using the Open Hack'Ware BIOS, just like the "prep" machine, so we can test it accordingly with the boot-serial tester, too. While we're at it, also change the strings that we are using for the "prep" machine, so that this test now also checks some CLI param

[Qemu-devel] [PATCH] block: Fix leak of ignore_children in error path

2018-03-14 Thread Fam Zheng
Reported-by: Max Reitz Signed-off-by: Fam Zheng --- block.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block.c b/block.c index 75a9fd49de..c1fda9fd57 100644 --- a/block.c +++ b/block.c @@ -3671,12 +3671,12 @@ int bdrv_drop_intermediate(BlockDriverState *top, BlockDriver

[Qemu-devel] [PATCH] vvfat: Fix inherit_options flags

2018-03-14 Thread Fam Zheng
Overriding flags violates the precedence rules of bdrv_reopen_queue_child. Just like the read-only option, no-flush should be put into the options. The same is done in bdrv_temp_snapshot_options. Reported-by: Stefan Hajnoczi --- block/vvfat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v4 3/4] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-03-14 Thread Michael S. Tsirkin
On Thu, Mar 15, 2018 at 09:15:48AM +0800, Wei Wang wrote: > On 03/14/2018 10:12 PM, Michael S. Tsirkin wrote: > > On Wed, Mar 14, 2018 at 02:03:19PM +0800, Wei Wang wrote: > > > On 03/14/2018 10:53 AM, Michael S. Tsirkin wrote: > > > > On Wed, Mar 14, 2018 at 10:43:01AM +0800, Wei Wang wrote: > > >

Re: [Qemu-devel] [PATCH qemu v7 2/4] vfio/pci: Relax DMA map errors for MMIO regions

2018-03-14 Thread Alex Williamson
On Wed, 14 Mar 2018 13:40:21 +1100 Alexey Kardashevskiy wrote: > On 14/3/18 3:56 am, Alex Williamson wrote: > > Actually making sure it compiles would have been nice: > > > > qemu.git/hw/vfio/common.c: In function ‘vfio_listener_region_add’: > > qemu.git/hw/vfio/common.c:550:40: error: invalid o

Re: [Qemu-devel] [PATCH] dump-guest-memory: more descriptive lookup_type failure

2018-03-14 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180314142133.14166-1-drjo...@redhat.com Subject: [Qemu-devel] [PATCH] dump-guest-memory: more descriptive lookup_type failure === TEST SCRIPT BEGIN === #!/bin/bash BASE=b

[Qemu-devel] [PATCH resend v2] qga: unset frozen state if no mount point is frozen

2018-03-14 Thread Chen Hanxiao
From: Chen Hanxiao If we set mountpoints to qmp_guest_fsfreeze_freeze_list, we may got nothing to freeze as all mountpoints are not valid. So call ga_unset_frozen in this senario. Also, if we return 0 frozen fs, there is no need to call guest-fsfreeze-thaw. Cc: Michael Roth Signed-off-by: Chen

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v4 3/4] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-03-14 Thread Wei Wang
On 03/14/2018 10:12 PM, Michael S. Tsirkin wrote: On Wed, Mar 14, 2018 at 02:03:19PM +0800, Wei Wang wrote: On 03/14/2018 10:53 AM, Michael S. Tsirkin wrote: On Wed, Mar 14, 2018 at 10:43:01AM +0800, Wei Wang wrote: On 03/14/2018 12:49 AM, Michael S. Tsirkin wrote: On Wed, Mar 07, 2018 at 08:

Re: [Qemu-devel] [PATCH] target/ppc: fix tlbsync to check privilege level depending on GTSE

2018-03-14 Thread David Gibson
On Wed, Mar 14, 2018 at 06:33:36PM +0100, Cédric Le Goater wrote: > tlbsync also needs to check the Guest Translation Shootdown Enable > (GTSE) bit in the Logical Partition Control Register (LPCR) to > determine at which privilege level it is running. > > See commit c6fd28fd573d ("target/ppc: Upda

Re: [Qemu-devel] [Qemu-ppc] [PATCH] target/ppc: fix tlbsync to check privilege level depending on GTSE

2018-03-14 Thread Suraj Jitindar Singh
On Wed, 2018-03-14 at 18:33 +0100, Cédric Le Goater wrote: > tlbsync also needs to check the Guest Translation Shootdown Enable > (GTSE) bit in the Logical Partition Control Register (LPCR) to > determine at which privilege level it is running. > > See commit c6fd28fd573d ("target/ppc: Update tlbi

Re: [Qemu-devel] [PATCH v4 2/4] migration: API to clear bits of guest free pages from the dirty bitmap

2018-03-14 Thread Michael S. Tsirkin
On Wed, Mar 14, 2018 at 07:42:59PM +, Dr. David Alan Gilbert wrote: > * Michael S. Tsirkin (m...@redhat.com) wrote: > > On Wed, Mar 14, 2018 at 06:11:37PM +, Dr. David Alan Gilbert wrote: > > > > +used_len = block->used_length - offset; > > > > +addr += used_len; > >

Re: [Qemu-devel] [PULL 18/41] blockjobs: add block-job-finalize

2018-03-14 Thread John Snow
On 03/13/2018 02:47 PM, Eric Blake wrote: > On 03/13/2018 11:17 AM, Kevin Wolf wrote: >> From: John Snow >> >> Instead of automatically transitioning from PENDING to CONCLUDED, gate >> the .prepare() and .commit() phases behind an explicit acknowledgement >> provided by the QMP monitor if auto_f

Re: [Qemu-devel] [PATCH] migration: Fix rate limiting issue on RDMA migration

2018-03-14 Thread Dr. David Alan Gilbert
* Lidong Chen (jemmy858...@gmail.com) wrote: > RDMA migration implement save_page function for QEMUFile, but > ram_control_save_page do not increase bytes_xfer. So when doing > RDMA migration, it will use whole bandwidth. Hi, Thanks for this, > Signed-off-by: Lidong Chen > --- > migration/qem

Re: [Qemu-devel] [PATCH v4 4/4] migration: use the free page hint feature from balloon

2018-03-14 Thread Dr. David Alan Gilbert
* Wei Wang (wei.w.w...@intel.com) wrote: > Start the free page optimization after the migration bitmap is > synchronized. This can't be used in the stop© phase since the guest > is paused. Make sure the guest reporting has stopped before > synchronizing the migration dirty bitmap. Currently, the op

Re: [Qemu-devel] [PATCH v4 2/4] migration: API to clear bits of guest free pages from the dirty bitmap

2018-03-14 Thread Dr. David Alan Gilbert
* Michael S. Tsirkin (m...@redhat.com) wrote: > On Wed, Mar 14, 2018 at 06:11:37PM +, Dr. David Alan Gilbert wrote: > > > +used_len = block->used_length - offset; > > > +addr += used_len; > > > +} > > > + > > > +start = offset >> TARGET_PAGE_BITS; > > > +

Re: [Qemu-devel] [PATCH v4 2/4] migration: API to clear bits of guest free pages from the dirty bitmap

2018-03-14 Thread Michael S. Tsirkin
On Wed, Mar 14, 2018 at 06:11:37PM +, Dr. David Alan Gilbert wrote: > > +used_len = block->used_length - offset; > > +addr += used_len; > > +} > > + > > +start = offset >> TARGET_PAGE_BITS; > > +npages = used_len >> TARGET_PAGE_BITS; > > +

[Qemu-devel] [PATCH 2/2 v3] slirp: Add classless static routes support to DHCP server

2018-03-14 Thread Benjamin Drung
This patch will allow the user to specify classless static routes for the replies from the built-in DHCP server, for example: qemu --net user,route=10.0.2.0/24,route=192.168.0.0/16 [...] The QMP schema for the "route" option is ['str'], because the opts visitor code only supports lists with a s

Re: [Qemu-devel] [PATCH 2/2 v2] slirp: Add classless static routes support to DHCP server

2018-03-14 Thread Benjamin Drung
Am Donnerstag, den 08.03.2018, 14:21 -0600 schrieb Eric Blake: > On 03/08/2018 02:07 PM, Benjamin Drung wrote: > > Am Donnerstag, den 08.03.2018, 13:46 -0600 schrieb Eric Blake: > > > On 03/08/2018 12:57 PM, Benjamin Drung wrote: > > > >'*dnssearch': ['String'], > > > >'*domainname'

Re: [Qemu-devel] [PATCH v4 3/4] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-03-14 Thread Dr. David Alan Gilbert
* Wei Wang (wei.w.w...@intel.com) wrote: > The new feature enables the virtio-balloon device to receive hints of > guest free pages from the free page vq. > > balloon_free_page_start - start guest free page hint reporting. > balloon_free_page_stop - stop guest free page hint reporting. > > Note:

Re: [Qemu-devel] [PATCH RFC] configure: shorthand for only enabling native softmmu target

2018-03-14 Thread Peter Maydell
On 14 March 2018 at 12:09, Daniel P. Berrangé wrote: > With the huge number of QEMU targets, a default configuration will take > a very long time to rebuild. When developing most code changes, it is > sufficient to test compilation with a single target - rebuilding all > targets just extends compi

Re: [Qemu-devel] [PATCH v4 2/4] migration: API to clear bits of guest free pages from the dirty bitmap

2018-03-14 Thread Dr. David Alan Gilbert
* Wei Wang (wei.w.w...@intel.com) wrote: > This patch adds an API to clear bits corresponding to guest free pages > from the dirty bitmap. Spilt the free page block if it crosses the QEMU > RAMBlock boundary. > > Signed-off-by: Wei Wang > CC: Dr. David Alan Gilbert > CC: Juan Quintela > CC: Mic

Re: [Qemu-devel] [PATCH RFC] configure: shorthand for only enabling native softmmu target

2018-03-14 Thread Alex Bennée
Daniel P. Berrangé writes: > With the huge number of QEMU targets, a default configuration will take > a very long time to rebuild. When developing most code changes, it is > sufficient to test compilation with a single target - rebuilding all > targets just extends compile times while not detec

Re: [Qemu-devel] CVE-2018-7550 (was: multiboot: bss_end_addr can be zero / cleanup)

2018-03-14 Thread Kevin Wolf
Am 14.03.2018 um 18:35 hat Konrad Rzeszutek Wilk geschrieben: > On March 14, 2018 1:23:51 PM EDT, Kevin Wolf wrote: > >Am 21.12.2017 um 18:25 hat Jack Schwartz geschrieben: > >> Properly account for the possibility of multiboot kernels with a zero > >> bss_end_addr. The Multiboot Specification, s

Re: [Qemu-devel] [PATCH 5/5] tests/multiboot: Add .gitignore

2018-03-14 Thread Eric Blake
On 03/14/2018 12:43 PM, Eric Blake wrote: On 03/14/2018 12:32 PM, Kevin Wolf wrote: Signed-off-by: Kevin Wolf ---   tests/multiboot/.gitignore | 3 +++   1 file changed, 3 insertions(+)   create mode 100644 tests/multiboot/.gitignore Reviewed-by: Eric Blake Huh - and I even proposed somethi

Re: [Qemu-devel] [PATCH 5/5] tests/multiboot: Add .gitignore

2018-03-14 Thread Eric Blake
On 03/14/2018 12:32 PM, Kevin Wolf wrote: Signed-off-by: Kevin Wolf --- tests/multiboot/.gitignore | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 tests/multiboot/.gitignore Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301

[Qemu-devel] [PATCH] target/ppc: fix tlbsync to check privilege level depending on GTSE

2018-03-14 Thread Cédric Le Goater
tlbsync also needs to check the Guest Translation Shootdown Enable (GTSE) bit in the Logical Partition Control Register (LPCR) to determine at which privilege level it is running. See commit c6fd28fd573d ("target/ppc: Update tlbie to check privilege level based on GTSE") Signed-off-by: Cédric Le

Re: [Qemu-devel] CVE-2018-7550 (was: multiboot: bss_end_addr can be zero / cleanup)

2018-03-14 Thread Konrad Rzeszutek Wilk
On March 14, 2018 1:23:51 PM EDT, Kevin Wolf wrote: >Am 21.12.2017 um 18:25 hat Jack Schwartz geschrieben: >> Properly account for the possibility of multiboot kernels with a zero >> bss_end_addr. The Multiboot Specification, section 3.1.3 allows for >> kernels without a bss section, by allowing

[Qemu-devel] [PATCH 5/5] tests/multiboot: Add .gitignore

2018-03-14 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- tests/multiboot/.gitignore | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 tests/multiboot/.gitignore diff --git a/tests/multiboot/.gitignore b/tests/multiboot/.gitignore new file mode 100644 index 00..93ef99800b --- /dev/null +++ b/tests/multib

[Qemu-devel] [PATCH 4/5] tests/multiboot: Add tests for the a.out kludge

2018-03-14 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- tests/multiboot/Makefile| 22 +-- tests/multiboot/aout_kludge.S | 138 tests/multiboot/aout_kludge.out | 42 tests/multiboot/run_test.sh | 10 ++- 4 files changed, 204 insertions(+), 8 deletio

[Qemu-devel] [PATCH 1/5] multiboot: Reject kernels exceeding the address space

2018-03-14 Thread Kevin Wolf
The code path with a manually set mh_load_addr in the Multiboot header checks that load_end_addr <= load_addr, but the path where load_end_addr is automatically detected if 0 is given in the header misses the corresponding check. If the kernel binary size is larger than can fit in the address space

[Qemu-devel] [PATCH 3/5] tests/multiboot: Test exit code for every qemu run

2018-03-14 Thread Kevin Wolf
Testing the exit code only once after a whole group of tests has completed is not enough, it catches errors only in the very last qemu invocation. We need to have the check after each qemu run. The logging and diff with the reference output is still done once per group to keep things more managabl

[Qemu-devel] [PATCH 0/5] multiboot: Fix buffer overflow on invalid kernels

2018-03-14 Thread Kevin Wolf
Patch 1 fixes another Multiboot kernel validation bug that could cause QEMU to load the kernel image file into a too small buffer. Patch 2 adds another check to harden the code. The rest of the series adds Multiboot test cases for kernels using the a.out kludge, which is where the recent bugs were

[Qemu-devel] [PATCH 2/5] multiboot: Check validity of mh_header_addr

2018-03-14 Thread Kevin Wolf
I couldn't find a case where this prevents something bad from happening that isn't already caught by other checks, but let's err on the safe side and check that mh_header_addr is as expected. Signed-off-by: Kevin Wolf --- hw/i386/multiboot.c | 4 1 file changed, 4 insertions(+) diff --git

[Qemu-devel] CVE-2018-7550 (was: multiboot: bss_end_addr can be zero / cleanup)

2018-03-14 Thread Kevin Wolf
Am 21.12.2017 um 18:25 hat Jack Schwartz geschrieben: > Properly account for the possibility of multiboot kernels with a zero > bss_end_addr. The Multiboot Specification, section 3.1.3 allows for > kernels without a bss section, by allowing a zeroed bss_end_addr multiboot > header field. > > Do s

Re: [Qemu-devel] [PATCH] linux-user: implement HWCAP bits on MIPS

2018-03-14 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180314142018.13612-1-james.cowg...@mips.com Subject: [Qemu-devel] [PATCH] linux-user: implement HWCAP bits on MIPS === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 tota

[Qemu-devel] [PATCH v6 8/8] [RFH] tests: Add migration compress threads tests

2018-03-14 Thread Juan Quintela
Yeap, it is still not working. trying to learn how to debug threads for guests running from the testt hardness. For some reason, compression is not working at the moment, test is disabled until I found why. Signed-off-by: Juan Quintela --- tests/migration-test.c | 52 +++

[Qemu-devel] [PATCH v6 1/8] qemu-sockets: Export SocketAddress_to_str

2018-03-14 Thread Juan Quintela
Migration code needs that function in hmp.c (so we need to export it), and it needs it on tests/migration-test.c, so we need to move it to a place where it is compiled into the test framework. Signed-off-by: Juan Quintela --- chardev/char-socket.c | 29 - include/qem

[Qemu-devel] [PATCH v6 7/8] migration: Add multifd test

2018-03-14 Thread Juan Quintela
We set the x-multifd-page-count and x-multifd-channels. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- tests/migration-test.c | 48 1 file changed, 48 insertions(+) diff --git a/tests/migration-test.c b/tests/migration-test

[Qemu-devel] [PATCH v6 6/8] tests: Add basic migration precopy tcp test

2018-03-14 Thread Juan Quintela
Not sharing code from precopy/unix because we have to read back the tcp parameter. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- tests/migration-test.c | 79 -- 1 file changed, 76 insertions(+), 3 dele

[Qemu-devel] [PATCH v6 5/8] tests: Migration ppc now inlines its program

2018-03-14 Thread Juan Quintela
No need to write it to a file. Just need a proper firmware O:-) Signed-off-by: Juan Quintela CC: Laurent Vivier --- tests/migration-test.c | 41 + 1 file changed, 5 insertions(+), 36 deletions(-) diff --git a/tests/migration-test.c b/tests/migration-tes

[Qemu-devel] [PATCH v6 3/8] tests: Add migration xbzrle test

2018-03-14 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Peter Xu --- tests/migration-test.c | 64 ++ 1 file changed, 64 insertions(+) diff --git a/tests/migration-test.c b/tests/migration-test.c index 834cdf50f2..fd885ba909 100644 --- a/tests/migration-test.c +

[Qemu-devel] [PATCH v6 0/8] Add make check tests for Migration

2018-03-14 Thread Juan Quintela
Hi This is v6, it differest from the patches that I sent with previous multifd post: - Rename x-tcp-port to x-socket-address This is more *complicated* that it looks as: * it is a pointer, so I need to use QAPI_CLONE() to make info migrate work * this is an union of structs. In QAPI.

[Qemu-devel] [PATCH v6 2/8] tests: Add migration precopy test

2018-03-14 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- tests/migration-test.c | 44 ++-- 1 file changed, 42 insertions(+), 2 deletions(-) diff --git a/tests/migration-test.c b/tests/migration-test.c index 422bf1afdf..8

[Qemu-devel] [PATCH v6 4/8] migration: Create x-socket-address parameter

2018-03-14 Thread Juan Quintela
It will be used to store the uri parameter. We want this only for tcp, so we don't set it for other uris. We need it to know what port is migration running. Signed-off-by: Juan Quintela -- This used to be uri parameter, but it has so many troubles to reproduce that it don't just make sense. T

Re: [Qemu-devel] [PATCH v4 1/4] bitmap: bitmap_count_one_with_offset

2018-03-14 Thread Dr. David Alan Gilbert
* Wei Wang (wei.w.w...@intel.com) wrote: > Count the number of 1s in a bitmap starting from an offset. > > Signed-off-by: Wei Wang > CC: Dr. David Alan Gilbert > CC: Juan Quintela > CC: Michael S. Tsirkin Reviewed-by: Dr. David Alan Gilbert > --- > include/qemu/bitmap.h | 13 +

Re: [Qemu-devel] [PATCH] linux-user: implement HWCAP bits on MIPS

2018-03-14 Thread Laurent Vivier
Le 14/03/2018 à 16:31, James Cowgill a écrit : > Add support for the two currently defined HWCAP bits on MIPS - R6 and > MSA. > > Buglink: https://bugs.launchpad.net/qemu/+bug/1754372 > Signed-off-by: James Cowgill > --- > This was resent because I think I messed up my email config. Apologies if

[Qemu-devel] [PATCH] target-mips: Add initrd support for the Boston board

2018-03-14 Thread Aleksandar Rikalo
From: Aleksandar Rikalo Add support for initial ramdisk loading for the Mips Boston board. Signed-off-by: Aleksandar Rikalo --- hw/mips/boston.c | 54 +- 1 file changed, 45 insertions(+), 9 deletions(-) diff --git a/hw/mips/boston.c b/hw/mip

[Qemu-devel] [Bug 1587065] Re: btrfs qemu-ga - multiple mounts block fsfreeze

2018-03-14 Thread Janåke Rönnblom
This affects Ubuntu 16.04 as in #4 ** Also affects: qemu (Ubuntu) Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1587065 Title: btrfs qemu-ga - multipl

Re: [Qemu-devel] [PATCH 0/3] WHPX introduce changes for Windows Insider SDK 17110

2018-03-14 Thread Paolo Bonzini
On 14/03/2018 15:52, Justin Terry (VM) wrote: > This change set fixes two breaking changes that were introduced in the > Windows Insider SDK 17110. First, a change to the WHvGetCapability function > decl to include the 'out' WrittenSizeInBytes. Second, changes to the > WHvSetPartitionProperty funct

[Qemu-devel] block-layer: questions on manipulation of internal nodes

2018-03-14 Thread Stefano Panella
Hi everybody, I am a relatively new user of qemu block layer. I am interested in it mainly because it looks very powerful and general and I am hoping to integrate it on our product and to contribute to it for new usecases. I have existing use cases where we work with a model of a disk process p

[Qemu-devel] [Bug 1754372] Re: Set MIPS MSA in ELF Auxiliary Vectors

2018-03-14 Thread James Cowgill
Patch: https://lists.nongnu.org/archive/html/qemu-devel/2018-03/msg04399.html ** Changed in: qemu Status: New => In Progress ** Changed in: qemu Assignee: (unassigned) => James Cowgill (jcowgill) -- You received this bug notification because you are a member of qemu- devel-ml, which

Re: [Qemu-devel] [PATCH] linux-user: implement HWCAP bits on MIPS

2018-03-14 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180314153121.23838-1-james.cowg...@mips.com Subject: [Qemu-devel] [PATCH] linux-user: implement HWCAP bits on MIPS === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 tota

[Qemu-devel] [PATCH v2] dump-guest-memory: more descriptive lookup_type failure

2018-03-14 Thread Andrew Jones
We've seen a few reports of (gdb) source /usr/share/qemu-kvm/dump-guest-memory.py Traceback (most recent call last): File "/usr/share/qemu-kvm/dump-guest-memory.py", line 19, in UINTPTR_T = gdb.lookup_type("uintptr_t") gdb.error: No type named uintptr_t. This occurs when symbols haven

[Qemu-devel] [PATCH] linux-user: implement HWCAP bits on MIPS

2018-03-14 Thread James Cowgill
Add support for the two currently defined HWCAP bits on MIPS - R6 and MSA. Buglink: https://bugs.launchpad.net/qemu/+bug/1754372 Signed-off-by: James Cowgill --- This was resent because I think I messed up my email config. Apologies if you receive this twice. linux-user/elfload.c | 24 +

[Qemu-devel] [PATCH] linux-user: implement HWCAP bits on MIPS

2018-03-14 Thread James Cowgill
Add support for the two currently defined HWCAP bits on MIPS - R6 and MSA. Buglink: https://bugs.launchpad.net/qemu/+bug/1754372 Signed-off-by: James Cowgill --- linux-user/elfload.c | 24 1 file changed, 24 insertions(+) diff --git a/linux-user/elfload.c b/linux-user/e

Re: [Qemu-devel] [Qemu-block] [PATCH v2 3/5] block/throttle: Remove protocol-related fields

2018-03-14 Thread Alberto Garcia
On Mon 12 Mar 2018 11:07:51 PM CET, Fabiano Rosas wrote: > The throttle driver is not a protocol so it should implement bdrv_open > instead of bdrv_file_open and not provide a protocol_name. > > Attempts to invoke this driver using protocol syntax > (i.e. throttle:) will now fail gracefully: > >

Re: [Qemu-devel] [PATCH v2 2/5] block/quorum: Remove protocol-related fields

2018-03-14 Thread Alberto Garcia
On Mon 12 Mar 2018 11:07:50 PM CET, Fabiano Rosas wrote: > The quorum driver is not a protocol so it should implement bdrv_open > instead of bdrv_file_open and not provide a protocol_name. > > Attempts to invoke this driver using protocol syntax > (i.e. quorum:) will now fail gracefully: > > $ qe

Re: [Qemu-devel] [PATCH] dump-guest-memory: more descriptive lookup_type failure

2018-03-14 Thread Janosch Frank
On 14.03.2018 15:21, Andrew Jones wrote: > We've seen a few reports of > > (gdb) source /usr/share/qemu-kvm/dump-guest-memory.py > Traceback (most recent call last): >File "/usr/share/qemu-kvm/dump-guest-memory.py", line 19, in > UINTPTR_T = gdb.lookup_type("uintptr_t") > gdb.error: N

Re: [Qemu-devel] [PATCH v10 08/24] migration: Add multifd test

2018-03-14 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert" wrote: > > * Juan Quintela (quint...@redhat.com) wrote: > >> We set the x-multifd-page-count and x-multifd-channels. > >> > >> Signed-off-by: Juan Quintela > > > > > > This should probably go nearer the end of the series; >

[Qemu-devel] [PATCH 2/3] WHPX fix WHvSetPartitionProperty in PropertyCode

2018-03-14 Thread Justin Terry (VM) via Qemu-devel
This fixes a breaking change to WHvSetPartitionProperty to pass the 'in' PropertyCode on function invocation introduced in Windows Insider SDK 17110. Usage of this indicates the PropertyCode of the opaque PropertyBuffer passed in on function invocation. Also fixes the removal of the PropertyCode p

[Qemu-devel] [PATCH 3/3] WHPX improve vcpu_post_run perf

2018-03-14 Thread Justin Terry (VM) via Qemu-devel
This removes the additional call to WHvGetVirtualProcessorRegisters in whpx_vcpu_post_run now that the WHV_VP_EXIT_CONTEXT is returned in all WHV_RUN_VP_EXIT_CONTEXT structures. Signed-off-by: Justin Terry (VM) --- target/i386/whpx-all.c | 41 +++-- 1 file cha

[Qemu-devel] [PATCH 1/3] WHPX fix WHvGetCapability out WrittenSizeInBytes

2018-03-14 Thread Justin Terry (VM) via Qemu-devel
This fixes a breaking change to WHvGetCapability to include the 'out' WrittenSizeInBytes introduced in Windows Insider SDK 17110. This specifies on return the safe length to read into the WHV_CAPABILITY structure passed to the call. Signed-off-by: Justin Terry (VM) --- configure |

[Qemu-devel] [PATCH 0/3] WHPX introduce changes for Windows Insider SDK 17110

2018-03-14 Thread Justin Terry (VM) via Qemu-devel
This change set fixes two breaking changes that were introduced in the Windows Insider SDK 17110. First, a change to the WHvGetCapability function decl to include the 'out' WrittenSizeInBytes. Second, changes to the WHvSetPartitionProperty function decl and WHV_PARTITION_PROPERTY structure to direc

Re: [Qemu-devel] [PATCH v10 08/24] migration: Add multifd test

2018-03-14 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> We set the x-multifd-page-count and x-multifd-channels. >> >> Signed-off-by: Juan Quintela > > > This should probably go nearer the end of the series; it is _much_ better here. It makes so much easier to test tha

Re: [Qemu-devel] [PATCH v10 04/24] migration: Set the migration tcp port

2018-03-14 Thread Juan Quintela
Daniel P. Berrange wrote: > On Wed, Mar 07, 2018 at 11:59:50AM +0100, Juan Quintela wrote: >> We can set the port parameter as zero. This patch lets us know what >> port the system was choosen for us. Now we can migrate to this place. >> >> Signed-off-by: Juan Quintela >> +void migrate_set_po

Re: [Qemu-devel] [PATCH for 2.12] iotests: Avoid realpath

2018-03-14 Thread Eric Blake
On 03/14/2018 09:38 AM, Eric Blake wrote: CentOS 6 lacks a realpath binary on the base install, which makes all iotests runs fail: 001 - output mismatch (see 001.out.bad) ./check: line 815: realpath: command not found diff: missing operand after `/home/dummy/qemu/tests/qemu-iotests/001.o

Re: [Qemu-devel] [PATCH v10 03/24] migration: Create tcp_port parameter

2018-03-14 Thread Juan Quintela
Daniel P. Berrange wrote: > On Wed, Mar 07, 2018 at 11:59:49AM +0100, Juan Quintela wrote: >> It will be used to store the uri tcp_port parameter. This is the only >> parameter than can change and we can need to be able to connect to it. >> >> Signed-off-by: Juan Quintela >> >> -- >> # TODO e

Re: [Qemu-devel] [PATCH v4 4/4] migration: use the free page hint feature from balloon

2018-03-14 Thread Michael S. Tsirkin
On Wed, Mar 14, 2018 at 02:50:44PM +0800, Wei Wang wrote: > On 03/14/2018 10:51 AM, Michael S. Tsirkin wrote: > > On Wed, Mar 14, 2018 at 10:41:36AM +0800, Wei Wang wrote: > > > On 03/14/2018 12:35 AM, Michael S. Tsirkin wrote: > > > > On Wed, Mar 07, 2018 at 08:34:25PM +0800, Wei Wang wrote: > > >

[Qemu-devel] [PATCH for 2.12] iotests: Avoid realpath

2018-03-14 Thread Eric Blake
CentOS 6 lacks a realpath binary on the base install, which makes all iotests runs fail: 001 - output mismatch (see 001.out.bad) ./check: line 815: realpath: command not found diff: missing operand after `/home/dummy/qemu/tests/qemu-iotests/001.out' diff: Try `diff --help' for more informa

Re: [Qemu-devel] [PULL 00/18] Linux user for 2.12 patches

2018-03-14 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180313173355.4468-1-laur...@vivier.eu Subject: [Qemu-devel] [PULL 00/18] Linux user for 2.12 patches === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --

[Qemu-devel] [PATCH] dump-guest-memory: more descriptive lookup_type failure

2018-03-14 Thread Andrew Jones
We've seen a few reports of (gdb) source /usr/share/qemu-kvm/dump-guest-memory.py Traceback (most recent call last): File "/usr/share/qemu-kvm/dump-guest-memory.py", line 19, in UINTPTR_T = gdb.lookup_type("uintptr_t") gdb.error: No type named uintptr_t. This occurs when symbols haven

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v4 3/4] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-03-14 Thread Michael S. Tsirkin
On Wed, Mar 14, 2018 at 02:03:19PM +0800, Wei Wang wrote: > On 03/14/2018 10:53 AM, Michael S. Tsirkin wrote: > > On Wed, Mar 14, 2018 at 10:43:01AM +0800, Wei Wang wrote: > > > On 03/14/2018 12:49 AM, Michael S. Tsirkin wrote: > > > > On Wed, Mar 07, 2018 at 08:34:24PM +0800, Wei Wang wrote: > > >

[Qemu-devel] [PATCH v5 2/3] target/arm: Add "_S" suffix to the secure version of a sysreg

2018-03-14 Thread Abdallah Bouassida
This is a preparation for the coming feature of creating dynamically an XML description for the ARM sysregs. Add "_S" suffix to the secure version of sysregs that have both S and NS views Replace (S) and (NS) by _S and _NS for the register that are manually defined, so all the registers follow the

[Qemu-devel] [PATCH v5 3/3] target/arm: Add the XML dynamic generation

2018-03-14 Thread Abdallah Bouassida
Generate an XML description for the cp-regs. Register these regs with the gdb_register_coprocessor(). Add arm_gdb_get_sysreg() to use it as a callback to read those regs. Add a dummy arm_gdb_set_sysreg(). Signed-off-by: Abdallah Bouassida --- gdbstub.c| 10 include/qom/cpu.h

[Qemu-devel] [PATCH v5 0/3] target/arm: Add a dynamic XML-description of the cp-registers to GDB

2018-03-14 Thread Abdallah Bouassida
The previous version: http://patchwork.ozlabs.org/project/qemu-devel/list/?series=33190 Abdallah Bouassida (3): target/arm: Add "ARM_CP_NO_GDB" as a new bit field for ARMCPRegInfo type target/arm: Add "_S" suffix to the secure version of a sysreg target/arm: Add the XML dynamic generatio

[Qemu-devel] [PATCH v5 1/3] target/arm: Add "ARM_CP_NO_GDB" as a new bit field for ARMCPRegInfo type

2018-03-14 Thread Abdallah Bouassida
This is a preparation for the coming feature of creating dynamically an XML description for the ARM sysregs. A register has ARM_CP_NO_GDB enabled will not be shown in the dynamic XML. This bit is enabled automatically when creating CP_ANY wildcard aliases. This bit could be enabled manually for any

Re: [Qemu-devel] Suggestion on 'virtio-pmem' implementation

2018-03-14 Thread David Hildenbrand
Hi Pankaj, I have a prototype (new one for virtio-mem I was working on over the last weeks) for exactly what you need. I basically factored out the notion of a memory device. So also virtio devices can be memory devices and get recognized e.g. in formerly known pc_dimm_get_free_address(), so it

Re: [Qemu-devel] [PATCH v5 0/2] qmp: 'wakeup-suspend-support' in query-target

2018-03-14 Thread Daniel Henrique Barboza
Ping On 02/19/2018 11:12 AM, Daniel Henrique Barboza wrote: v5: - removed a paragraph in the recently added qemu_register_wakeup_notifier comment that was added. That paragraph was adding too much in-depth information about the current design of the system_wakeup, making it harder to understand

Re: [Qemu-devel] [PATCH] i386: Disable Intel PT if packets IP payloads have LIP values

2018-03-14 Thread Eduardo Habkost
On Wed, Mar 14, 2018 at 03:26:31AM +0800, Luwei Kang wrote: > Intel processor trace should be disabled when > CPUID.(EAX=14H,ECX=0H).ECX.[bit31] is set. > Generated packets which contain IP payloads will have LIP > values when this bit is set, or IP payloads will have RIP > values. > Currently, The

Re: [Qemu-devel] [PATCH] i386: add KNM cpu model

2018-03-14 Thread Daniel P . Berrangé
On Wed, Mar 14, 2018 at 03:29:59PM +0800, Boqun Feng wrote: > A new cpu model called "KNM" is added to model Knights Mill processors. Why the obscure acryonym? Can't we just call it KnightsMill so it is obvious what it is to everyone, as we've done for all other Intel CPU model names in the past.

[Qemu-devel] [PATCH] i386: add KNM cpu model

2018-03-14 Thread Boqun Feng
A new cpu model called "KNM" is added to model Knights Mill processors. Compared to "Skylake-Server" cpu model, the following features are added: avx512_4vnniw avx512_4fmaps avx512pf avx512er avx512_vpopcntdq and the following features are removed: pcid invpcid clflushopt avx512d

Re: [Qemu-devel] [PULL 00/36] QAPI patches for 2018-03-12, 2.12 softfreeze

2018-03-14 Thread Peter Maydell
On 13 March 2018 at 21:55, Eric Blake wrote: > On 03/13/2018 09:17 AM, Eric Blake wrote: This builds and passes 'make check', so even though the OOB portion depends on chardev fixes that are still pending a pull request from Paolo, that dependence can only be observed at runtim

[Qemu-devel] [PATCH v6 28/29] libvhost-user: Claim support for postcopy

2018-03-14 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Tell QEMU we understand the protocol features needed for postcopy. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Marc-André Lureau --- contrib/libvhost-user/libvhost-user.c | 33 + 1 file changed, 33 insertions(+) diff --git

  1   2   >