Re: [Qemu-devel] [Qemu-block] [PATCH] nvme: add Get/Set Feature Timestamp support

2019-05-16 Thread Klaus Birkelund
On Fri, May 17, 2019 at 07:35:04AM +0200, Klaus Birkelund wrote: > Hi Kenneth, > > On Thu, May 16, 2019 at 05:24:47PM -0600, Heitke, Kenneth wrote: > > Hi Klaus, thank you for you review. I have one comment inline > > > > On 5/14/2019 12:02 AM, Klaus Birkelund wrote: > > > On Fri, Apr 05, 2019 at

Re: [Qemu-devel] [PATCH] spapr: Add forgotten capability to migration stream

2019-05-16 Thread Cédric Le Goater
On 5/17/19 6:18 AM, David Gibson wrote: > spapr machine capabilities are supposed to be sent in the migration stream > so that we can sanity check the source and destination have compatible > configuration. Unfortunately, when we added the hpt-max-page-size > capability, we forgot to add it to the

Re: [Qemu-devel] [PATCH v4] s390/css: handle CCW_FLAG_SKIP

2019-05-16 Thread Cornelia Huck
On Thu, 16 May 2019 15:33:27 +0200 Cornelia Huck wrote: > If a ccw has CCW_FLAG_SKIP set, and the command is of type > read, read backwards, or sense, no data should be written > to the guest for that command. > > Reviewed-by: Eric Farman > Signed-off-by: Cornelia Huck > --- > > Will queue th

[Qemu-devel] [Bug 1829459] [NEW] qemu: qemu_thread_create: Invalid argument

2019-05-16 Thread crocket
Public bug reported: # Version qemu-4.0.0 glibc-2.28 # commands used to launch qemu-aarch64 in user mode. : ${QEMU_BINFMT_FLAGS:=OC} printf '%s\n' ':qemu- aarch64:M::\x7fELF\x02\x01\x01\x00\x00\x00\x00\x00\x00\x00\x00\x00\x02\x00\xb7\x00:\xff\xff\xff\xff\xff\xff\xff\x00\xff\xff\xff\xff\xff\xff

Re: [Qemu-devel] [PATCH v9 2/7] virtio-pmem: Add virtio pmem driver

2019-05-16 Thread Pankaj Gupta
Hi Jakub, > > On 5/14/19 7:54 AM, Pankaj Gupta wrote: > > + if (!list_empty(&vpmem->req_list)) { > > + req_buf = list_first_entry(&vpmem->req_list, > > + struct virtio_pmem_request, list); > > + req_buf->wq_buf_ava

Re: [Qemu-devel] [Qemu-block] [PATCH] nvme: add Get/Set Feature Timestamp support

2019-05-16 Thread Klaus Birkelund
Hi Kenneth, On Thu, May 16, 2019 at 05:24:47PM -0600, Heitke, Kenneth wrote: > Hi Klaus, thank you for you review. I have one comment inline > > On 5/14/2019 12:02 AM, Klaus Birkelund wrote: > > On Fri, Apr 05, 2019 at 03:41:17PM -0600, Kenneth Heitke wrote: > > > Signed-off-by: Kenneth Heitke >

Re: [Qemu-devel] [PATCH v9 2/7] virtio-pmem: Add virtio pmem driver

2019-05-16 Thread Pankaj Gupta
> > On Wed, May 15, 2019 at 10:46:00PM +0200, David Hildenbrand wrote: > > > + vpmem->vdev = vdev; > > > + vdev->priv = vpmem; > > > + err = init_vq(vpmem); > > > + if (err) { > > > + dev_err(&vdev->dev, "failed to initialize virtio pmem vq's\n"); > > > + goto out_err; > > > + }

[Qemu-devel] [PATCH v14 12/13] Add rx-softmmu

2019-05-16 Thread Richard Henderson
From: Yoshinori Sato Tested-by: Philippe Mathieu-Daudé Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Yoshinori Sato Message-Id: <20190516055244.95559-10-ys...@users.sourceforge.jp> Signed-off-by: Richard Henderson --- include/sysemu/arch_init.h | 1 + arch_init.c

[Qemu-devel] [PATCH v14 08/13] hw/rx: RX Target hardware definition

2019-05-16 Thread Richard Henderson
From: Yoshinori Sato rx62n - RX62N cpu. rx-virt - RX QEMU virtual target. Signed-off-by: Yoshinori Sato Tested-by: Philippe Mathieu-Daudé Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20190516055244.95559-9-ys...@users.sourceforge.jp> Signed-off-by: Richard Henderson --- include/hw/rx/rx

[Qemu-devel] [PATCH v14 13/13] MAINTAINERS: Add RX

2019-05-16 Thread Richard Henderson
From: Yoshinori Sato Signed-off-by: Yoshinori Sato Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20190516055244.95559-13-ys...@users.sourceforge.jp> Signed-off-by: Richard Henderson --- MAINTAINERS | 19 +++ 1 file changed, 19 insertions(+)

[Qemu-devel] [PATCH v14 01/13] target/rx: TCG translation

2019-05-16 Thread Richard Henderson
From: Yoshinori Sato This part only supported RXv1 instructions. Instruction manual. https://www.renesas.com/us/en/doc/products/mpumcu/doc/rx_family/r01us0032ej0120_rxsm.pdf Signed-off-by: Yoshinori Sato Reviewed-by: Richard Henderson Tested-by: Philippe Mathieu-Daudé Message-Id: <20190516055

[Qemu-devel] [PATCH v14 07/13] hw/char: RX62N serial communication interface (SCI)

2019-05-16 Thread Richard Henderson
From: Yoshinori Sato This module supported only non FIFO type. Hardware manual. https://www.renesas.com/us/en/doc/products/mpumcu/doc/rx_family/r01uh0033ej0140_rx62n.pdf Signed-off-by: Yoshinori Sato Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20190516055244.9555

[Qemu-devel] [PATCH v14 09/13] qemu/bitops.h: Add extract8 and extract16

2019-05-16 Thread Richard Henderson
From: Yoshinori Sato Signed-off-by: Yoshinori Sato Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20190516055244.95559-12-ys...@users.sourceforge.jp> Signed-off-by: Richard Henderson --- include/qemu/bitops.h | 38 ++ 1 fil

[Qemu-devel] [PATCH v14 11/13] target/rx: Convert to CPUClass::tlb_fill

2019-05-16 Thread Richard Henderson
The interface for tlb_fill has changed very recently. Move the function into cpu.c so that it may be static while assigning to the CPUClass methods. Signed-off-by: Richard Henderson --- target/rx/cpu.c | 14 ++ target/rx/op_helper.c | 11 --- 2 files changed, 14 inserti

[Qemu-devel] [PATCH v14 10/13] hw/registerfields.h: Add 8bit and 16bit register macros

2019-05-16 Thread Richard Henderson
From: Yoshinori Sato Some RX peripheral using 8bit and 16bit registers. Added 8bit and 16bit APIs. Signed-off-by: Yoshinori Sato Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20190516055244.95559-11-ys...@users.sourceforge.jp> Signed-off-by: Richard Henderson

[Qemu-devel] [PATCH v14 06/13] hw/timer: RX62N internal timer modules

2019-05-16 Thread Richard Henderson
From: Yoshinori Sato renesas_tmr: 8bit timer modules. renesas_cmt: 16bit compare match timer modules. This part use many renesas's CPU. Hardware manual. https://www.renesas.com/us/en/doc/products/mpumcu/doc/rx_family/r01uh0033ej0140_rx62n.pdf Signed-off-by: Yoshinori Sato Reviewed-by: Alex Benn

[Qemu-devel] [PATCH v14 03/13] target/rx: CPU definition

2019-05-16 Thread Richard Henderson
From: Yoshinori Sato Signed-off-by: Yoshinori Sato Reviewed-by: Richard Henderson Message-Id: <20190516055244.95559-4-ys...@users.sourceforge.jp> Signed-off-by: Richard Henderson --- target/rx/cpu.h | 227 target/rx/cpu.c | 222

[Qemu-devel] [PATCH v14 04/13] target/rx: RX disassembler

2019-05-16 Thread Richard Henderson
From: Yoshinori Sato Signed-off-by: Yoshinori Sato Reviewed-by: Richard Henderson Tested-by: Philippe Mathieu-Daudé Message-Id: <20190516055244.95559-5-ys...@users.sourceforge.jp> Signed-off-by: Richard Henderson --- include/disas/dis-asm.h |5 + target/rx/disas.c | 1480 ++

[Qemu-devel] [PATCH v14 05/13] hw/intc: RX62N interrupt controller (ICUa)

2019-05-16 Thread Richard Henderson
From: Yoshinori Sato This implementation supported only ICUa. Hardware manual. https://www.renesas.com/us/en/doc/products/mpumcu/doc/rx_family/r01uh0033ej0140_rx62n.pdf Signed-off-by: Yoshinori Sato Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20190516055244.95559

[Qemu-devel] [PATCH v14 00/13] RX architecture support

2019-05-16 Thread Richard Henderson
This is Sato-san's v13, plus the typos that Phil noticed therein, plus the change to tlb_fill required by commit d8276573da58e8ce78dab8c46dd660efd664bcb7 Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20190510' Add CPUClass::tlb_fill. Improve tlb_vaddr_to_host for use by A

[Qemu-devel] [PATCH v14 02/13] target/rx: TCG helper

2019-05-16 Thread Richard Henderson
From: Yoshinori Sato Signed-off-by: Yoshinori Sato Reviewed-by: Richard Henderson Message-Id: <20190516055244.95559-3-ys...@users.sourceforge.jp> Signed-off-by: Richard Henderson --- target/rx/helper.h| 31 +++ target/rx/helper.c| 148 + target/rx/op_helper.c | 481 ++

Re: [Qemu-devel] [PATCH 1/6] qemu-bridge-helper: Fix misuse of isspace()

2019-05-16 Thread Jason Wang
On 2019/5/15 下午9:35, Paolo Bonzini wrote: On 15/05/19 08:34, Markus Armbruster wrote: qemu-bridge-helper should have a manual page, and its handling of errors in ACL include files needs work. There's probably more; I just glanced at it. I'm not volunteering, though. It lacks a maintainer.

[Qemu-devel] [PATCH] spapr: Add forgotten capability to migration stream

2019-05-16 Thread David Gibson
spapr machine capabilities are supposed to be sent in the migration stream so that we can sanity check the source and destination have compatible configuration. Unfortunately, when we added the hpt-max-page-size capability, we forgot to add it to the migration state. This means that we can genera

[Qemu-devel] [PULL v2 00/21] Misc patches for 2019-05-15

2019-05-16 Thread Paolo Bonzini
The following changes since commit e329ad2ab72c43b56df88b34954c2c7d839bb373: Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20190513' into staging (2019-05-14 10:08:47 +0100) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream for you to fe

Re: [Qemu-devel] [PULL 00/37] pci, pc, virtio: features, fixes

2019-05-16 Thread Wei Yang
On Fri, May 17, 2019 at 10:59:03AM +0800, Wei Yang wrote: >On Thu, May 16, 2019 at 08:53:04PM +0200, Philippe Mathieu-Daudé wrote: >>On Thu, May 16, 2019 at 8:33 PM Philippe Mathieu-Daudé >> wrote: >>> On 5/16/19 6:04 PM, Peter Maydell wrote: >>> > On Thu, 16 May 2019 at 13:17, Michael S. Tsirkin

Re: [Qemu-devel] Pentium Pro Feature Bugs

2019-05-16 Thread tedheadster
On Thu, May 16, 2019 at 10:57 PM Paolo Bonzini wrote: > > On 17/05/19 02:30, tedheadster wrote: > > Paolo, > > I am running the kvm32 machine and I see a problem. Here is the > > output of /proc/cpuinfo : > > > > flags : fpu vme de pse tsc msr pae mce cx8 apic mtrr pge mca > > cmov con

Re: [Qemu-devel] [PULL 00/37] pci, pc, virtio: features, fixes

2019-05-16 Thread Wei Yang
On Thu, May 16, 2019 at 08:53:04PM +0200, Philippe Mathieu-Daudé wrote: >On Thu, May 16, 2019 at 8:33 PM Philippe Mathieu-Daudé > wrote: >> On 5/16/19 6:04 PM, Peter Maydell wrote: >> > On Thu, 16 May 2019 at 13:17, Michael S. Tsirkin wrote: >> >> >> >> The following changes since commit >> >> ef

[Qemu-devel] [PATCH v8 21/25] target/arm: Put all PAC keys into a structure

2019-05-16 Thread Richard Henderson
This allows us to use a single syscall to initialize them all. Reviewed-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/arm/cpu.h | 12 +++- linux-user/aarch64/cpu_loop.c | 6 +- linux-user/syscall.c | 10 +++

[Qemu-devel] [PATCH v8 23/25] target/ppc: Use gen_io_start/end around DARN

2019-05-16 Thread Richard Henderson
Generating a random number counts as I/O, as it cannot be replayed and produce the same results. Acked-by: David Gibson Reviewed-by: Laurent Vivier Suggested-by: Peter Maydell Signed-off-by: Richard Henderson --- target/ppc/translate.c | 21 +++-- 1 file changed, 15 insertions

Re: [Qemu-devel] Pentium Pro Feature Bugs

2019-05-16 Thread Paolo Bonzini
On 17/05/19 02:30, tedheadster wrote: > Paolo, > I am running the kvm32 machine and I see a problem. Here is the > output of /proc/cpuinfo : > > flags : fpu vme de pse tsc msr pae mce cx8 apic mtrr pge mca > cmov constant_tsc > > I see something rather important missing: cpuid. > > A

[Qemu-devel] [PATCH v8 20/25] hw/misc/exynos4210_rng: Use qemu_guest_getrandom

2019-05-16 Thread Richard Henderson
The random number is intended for use by the guest. As such, we should honor the -seed argument for reproducibility. Reviewed-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- hw/misc/exynos4210_rng.c | 11 --- 1 file changed, 4 insertions(+),

[Qemu-devel] [PATCH v8 24/25] target/ppc: Use qemu_guest_getrandom for DARN

2019-05-16 Thread Richard Henderson
We now have an interface for guest visible random numbers. Acked-by: David Gibson Reviewed-by: Laurent Vivier Signed-off-by: Richard Henderson --- target/ppc/int_helper.c | 39 +++ 1 file changed, 27 insertions(+), 12 deletions(-) diff --git a/target/ppc/in

[Qemu-devel] [PATCH v8 16/25] linux-user: Remove srand call

2019-05-16 Thread Richard Henderson
We no longer use rand() within linux-user. Reviewed-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- linux-user/main.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/linux-user/main.c b/linux-user/main.c index 66c909a1a6..689bcf436d 1

[Qemu-devel] [PATCH v8 19/25] hw/misc/bcm2835_rng: Use qemu_guest_getrandom_nofail

2019-05-16 Thread Richard Henderson
The random number is intended for use by the guest. As such, we should honor the -seed argument for reproducibility. Use the *_nofail routine instead of rolling our own error handling locally. Reviewed-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson ---

[Qemu-devel] [PATCH v8 22/25] target/arm: Implement ARMv8.5-RNG

2019-05-16 Thread Richard Henderson
Use the newly introduced infrastructure for guest random numbers. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/arm/cpu.h| 5 + target/arm/cpu64.c | 1 + target/arm/helper.c | 44 3 files changed, 50 insertions(+)

[Qemu-devel] [PATCH v8 13/25] linux-user: Call qcrypto_init if not using -seed

2019-05-16 Thread Richard Henderson
When not using -seed, we will use the crypto subsystem for random numbers. Reviewed-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- linux-user/main.c | 28 +++- 1 file changed, 19 insertions(+), 9 deletions(-) diff --git a/li

[Qemu-devel] [PATCH v8 17/25] aspeed/scu: Use qemu_guest_getrandom_nofail

2019-05-16 Thread Richard Henderson
The random number is intended for use by the guest. As such, we should honor the -seed argument for reproducibility. Use the *_nofail routine instead of rolling our own error handling locally. Reviewed-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater Review

[Qemu-devel] [PATCH v8 18/25] hw/misc/nrf51_rng: Use qemu_guest_getrandom_nofail

2019-05-16 Thread Richard Henderson
The random number is intended for use by the guest. As such, we should honor the -seed argument for reproducibility. Use the *_nofail routine instead of error_abort directly. Reviewed-by: Laurent Vivier Reviewed-by: Joel Stanley Signed-off-by: Richard Henderson --- hw/misc/nrf51_rng.c | 4 ++

[Qemu-devel] [PATCH v8 10/25] util: Add qemu_guest_getrandom and associated routines

2019-05-16 Thread Richard Henderson
This routine is intended to produce high-quality random numbers to the guest. Normally, such numbers are crypto quality from the host, but a command-line option can force the use of a fully deterministic sequence for use while debugging. Reviewed-by: Laurent Vivier Reviewed-by: Philippe Mathieu-

[Qemu-devel] [PATCH v8 15/25] linux-user/aarch64: Use qemu_guest_getrandom for PAUTH keys

2019-05-16 Thread Richard Henderson
Use a better interface for random numbers than rand() * 3. Reviewed-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- linux-user/aarch64/target_syscall.h | 2 -- linux-user/aarch64/cpu_loop.c | 29 ++- linux-user/syscall.

[Qemu-devel] [PATCH v8 09/25] ui/vnc: Use gcrypto_random_bytes for start_auth_vnc

2019-05-16 Thread Richard Henderson
Use a better interface for random numbers than rand(). Fail gracefully if for some reason we cannot use the crypto system. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Gerd Hoffmann Reviewed-by: Daniel P. Berrangé Signed-off-by: Richard Henderson --- ui/vnc.c | 22 +++---

[Qemu-devel] [PATCH v8 11/25] cpus: Initialize pseudo-random seeds for all guest cpus

2019-05-16 Thread Richard Henderson
When the -seed option is given, call qemu_guest_random_seed_main, putting the subsystem into deterministic mode. Pass derived seeds to each cpu created; which is a no-op unless the subsystem is in deterministic mode. Reviewed-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: D

[Qemu-devel] [PATCH v8 25/25] target/i386: Implement CPUID_EXT_RDRAND

2019-05-16 Thread Richard Henderson
We now have an interface for guest visible random numbers. Reviewed-by: Eduardo Habkost Signed-off-by: Richard Henderson --- target/i386/helper.h | 2 ++ target/i386/cpu.c| 5 ++-- target/i386/int_helper.c | 21 ++ target/i386/translate.c | 62

[Qemu-devel] [PATCH v8 14/25] linux-user: Use qemu_guest_getrandom_nofail for AT_RANDOM

2019-05-16 Thread Richard Henderson
Use a better interface for random numbers than rand * 16. Reviewed-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- linux-user/elfload.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/linux-user/elfload.c b/linux-user/elfl

[Qemu-devel] [PATCH v8 04/25] crypto: Do not fail for EINTR during qcrypto_random_bytes

2019-05-16 Thread Richard Henderson
We can always get EINTR for read; /dev/urandom is no exception. Rearrange the order of tests for likelihood; allow degenerate buflen==0 case to perform a no-op zero-length read. This means that the normal success path is a straight line with a single test for success. Reviewed-by: Laurent Vivier

[Qemu-devel] [PATCH v8 06/25] crypto: Use getrandom for qcrypto_random_bytes

2019-05-16 Thread Richard Henderson
Prefer it to direct use of /dev/urandom. Reviewed-by: Laurent Vivier Reviewed-by: Daniel P. Berrangé Signed-off-by: Richard Henderson --- crypto/random-platform.c | 37 - configure| 18 +- 2 files changed, 49 insertions(+), 6

[Qemu-devel] [PATCH v8 12/25] linux-user: Initialize pseudo-random seeds for all guest cpus

2019-05-16 Thread Richard Henderson
When the -seed option is given, call qemu_guest_random_seed_main, putting the subsystem into deterministic mode. Pass derived seeds to each cpu created during clone; which is a no-op unless the subsystem is in deterministic mode. Reviewed-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé S

[Qemu-devel] [PATCH v8 05/25] crypto: Use O_CLOEXEC in qcrypto_random_init

2019-05-16 Thread Richard Henderson
Avoids leaking the /dev/urandom fd into any child processes. Reviewed-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Daniel P. Berrangé Signed-off-by: Richard Henderson --- crypto/random-platform.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cr

[Qemu-devel] [PATCH v8 07/25] crypto: Change the qcrypto_random_bytes buffer type to void*

2019-05-16 Thread Richard Henderson
Using uint8_t* merely requires useless casts for use with other types to be filled with randomness. Reviewed-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Daniel P. Berrangé Signed-off-by: Richard Henderson --- include/crypto/random.h | 2 +- crypto/random-gcrypt.c |

[Qemu-devel] [PATCH v8 02/25] build: Link user-only with crypto random number objects

2019-05-16 Thread Richard Henderson
For user-only, we require only the random number bits of the crypto subsystem. Rename crypto-aes-obj-y to crypto-user-obj-y, and add the random number objects, plus init.o to handle any extra stuff the crypto library requires. Move the crypto libraries from libs_softmmu and libs_tools to LIBS, so

[Qemu-devel] [PATCH v8 08/25] ui/vnc: Split out authentication_failed

2019-05-16 Thread Richard Henderson
There were 3 copies of this code, one of which used the wrong data size for the failure indicator. Reviewed-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Gerd Hoffmann Reviewed-by: Daniel P. Berrangé Signed-off-by: Richard Henderson --- ui/vnc.c | 37 +++

[Qemu-devel] [PATCH v8 03/25] crypto: Reverse code blocks in random-platform.c

2019-05-16 Thread Richard Henderson
Use #ifdef _WIN32 instead of #ifndef _WIN32. This will make other tests easier to sequence. Reviewed-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Daniel P. Berrangé Signed-off-by: Richard Henderson --- crypto/random-platform.c | 35 +-- 1

[Qemu-devel] [PATCH v8 01/25] configure: Link test before auto-enabling crypto libraries

2019-05-16 Thread Richard Henderson
At least ubuntu 18.04 does not package static gnutls libraries. At least Fedora 30 does not ship static nettle and gcrypt libraries. Reviewed-by: Daniel P. Berrangé Reviewed-by: Laurent Vivier Tested-by: Laurent Vivier Message-Id: <20190510012458.22706-2-richard.hender...@linaro.org> Signed-off

[Qemu-devel] [PATCH v8 00/25] Add qemu_getrandom and ARMv8.5-RNG etc

2019-05-16 Thread Richard Henderson
The change in v8 is to which objects are linked in to user-only from the crypto directory. Daniel asked for all of crypto-obj-y to be added, but I have been unable to find a solution that works. If I add crypto-obj-y, then authz-obj-y must be included to resolve dependencies. Daniel suggested sp

Re: [Qemu-devel] [PATCH v2 0/5] fw_cfg_test refactor and add two test cases

2019-05-16 Thread Li Qiang
Ping. Li Qiang 于2019年5月9日周四 下午5:57写道: > Ping this serials. > > Thanks, > Li Qiang > > Li Qiang 于2019年4月24日周三 下午10:07写道: > >> In the disscuss of adding reboot timeout test case: >> https://lists.gnu.org/archive/html/qemu-devel/2019-04/msg03304.html >> >> Philippe suggested we should uses

Re: [Qemu-devel] [PULL 00/37] pci, pc, virtio: features, fixes

2019-05-16 Thread Wei Yang
On Thu, May 16, 2019 at 08:53:04PM +0200, Philippe Mathieu-Daudé wrote: >On Thu, May 16, 2019 at 8:33 PM Philippe Mathieu-Daudé > wrote: >> On 5/16/19 6:04 PM, Peter Maydell wrote: >> > On Thu, 16 May 2019 at 13:17, Michael S. Tsirkin wrote: >> >> >> >> The following changes since commit >> >> ef

Re: [Qemu-devel] [PATCH] hw/acpi: ACPI_PCI should depends on both ACPI and PCI

2019-05-16 Thread Richard Henderson
On 5/16/19 5:51 PM, Wei Yang wrote: > Pointed out by Philippe Mathieu-Daudé . > > Signed-off-by: Wei Yang > --- > hw/acpi/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard Henderson r~

[Qemu-devel] QEMU on OpenBSD is broken? (was: Re: [PATCH v2 00/13] tests/vm: serial console autoinstall, misc fixes.)

2019-05-16 Thread Thomas Huth
On 10/05/2019 12.46, Gerd Hoffmann wrote: > This patch series changes the way virtual machines for test builds are > managed. They are created locally on the developer machine now. The > installer is booted on the serial console and the scripts walks through > the dialogs to install and configure

[Qemu-devel] [PATCH] hw/acpi: ACPI_PCI should depends on both ACPI and PCI

2019-05-16 Thread Wei Yang
Pointed out by Philippe Mathieu-Daudé . Signed-off-by: Wei Yang --- hw/acpi/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/acpi/Kconfig b/hw/acpi/Kconfig index 7265843cc3..7c59cf900b 100644 --- a/hw/acpi/Kconfig +++ b/hw/acpi/Kconfig @@ -25,7 +25,7 @@ config ACPI_

[Qemu-devel] [PATCH v2] acpi: pci: use build_append_foo() API to construct MCFG

2019-05-16 Thread Wei Yang
build_append_foo() API doesn't need explicit endianness conversions which eliminates a source of errors and it makes build_mcfg() look like declarative definition of MCFG table in ACPI spec, which makes it easy to review. Signed-off-by: Wei Yang Suggested-by: Igor Mammedov --- v2: * miss the

Re: [Qemu-devel] [PATCH v4 5/6] hw/acpi: Consolidate build_mcfg to pci.c

2019-05-16 Thread Wei Yang
On Thu, May 16, 2019 at 08:35:43PM +0200, Philippe Mathieu-Daudé wrote: >On 4/19/19 2:30 AM, Wei Yang wrote: >> Now we have two identical build_mcfg functions. >> >> Consolidate them in acpi/pci.c. >> >> Signed-off-by: Wei Yang >> Reviewed-by: Philippe Mathieu-Daudé >> Reviewed-by: Igor Mammedo

Re: [Qemu-devel] [PATCH 1/2] qapi: support external bitmaps in block-dirty-bitmap-merge

2019-05-16 Thread John Snow
On 5/16/19 8:27 AM, Vladimir Sementsov-Ogievskiy wrote: > Add new optional parameter making possible to merge bitmaps from > different nodes. It is needed to maintain external snapshots during > incremental backup chain history. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > qapi/blo

Re: [Qemu-devel] Pentium Pro Feature Bugs

2019-05-16 Thread tedheadster
Paolo, I am running the kvm32 machine and I see a problem. Here is the output of /proc/cpuinfo : flags : fpu vme de pse tsc msr pae mce cx8 apic mtrr pge mca cmov constant_tsc I see something rather important missing: cpuid. A lot of stuff breaks without cpuid, and I am fairly sure t

Re: [Qemu-devel] [PATCH v2 0/4] blockdev-backup: don't check aio_context too early

2019-05-16 Thread John Snow
Happy Friday: ping! Max: this series corrects some things that were causing some of the pitfalls that made me nervous about the context I wrote about in 219. On 5/10/19 3:03 PM, John Snow wrote: > See patch one's commit message for justification. > > v2: added patch 4, with iotest framework adju

Re: [Qemu-devel] [Qemu-block] [PATCH] iotests: Fix intermittent failure in 219

2019-05-16 Thread John Snow
On 5/16/19 12:11 PM, Max Reitz wrote: > In 219, we wait for the job to make progress before we emit its status. > This makes the output reliable. > > Unfortunately, there is a bug: We do not wait for any more progress if > the job has already reached its total-progress. Right after the job has

Re: [Qemu-devel] [PATCH v9 2/7] virtio-pmem: Add virtio pmem driver

2019-05-16 Thread Jakub Staroń via Qemu-devel
On 5/14/19 7:54 AM, Pankaj Gupta wrote: > + if (!list_empty(&vpmem->req_list)) { > + req_buf = list_first_entry(&vpmem->req_list, > + struct virtio_pmem_request, list); > + req_buf->wq_buf_avail = true; > +

Re: [Qemu-devel] [Qemu-block] [PATCH v1] [RFC] qcow2: add compression type feature

2019-05-16 Thread John Snow
On 5/16/19 9:48 AM, Denis Plotnikov wrote: > The patch adds some preparation parts for incompatible compression type > feature into QCOW2 header that indicates that *all* compressed clusters > must be (de)compressed using a certain compression type. > > It is implied that the compression type i

Re: [Qemu-devel] [Qemu-block] [PATCH] nvme: add Get/Set Feature Timestamp support

2019-05-16 Thread Heitke, Kenneth
Hi Klaus, thank you for you review. I have one comment inline On 5/14/2019 12:02 AM, Klaus Birkelund wrote: On Fri, Apr 05, 2019 at 03:41:17PM -0600, Kenneth Heitke wrote: Signed-off-by: Kenneth Heitke --- hw/block/nvme.c | 120 +- hw/block/nvme

[Qemu-devel] [PATCH] tcg/i386: Fix dupi/dupm for avx1 and 32-bit hosts

2019-05-16 Thread Richard Henderson
The VBROADCASTSD instruction only allows %ymm registers as destination. Rather than forcing VEX.L and writing to the entire 256-bit register, revert to using MOVDDUP with an %xmm register. This is sufficient for an avx1 host since we do not support TCG_TYPE_V256 for that case. Also fix the 32-bit

[Qemu-devel] [PULL 6/6] target/m68k: Optimize rotate_x() using extract_i32()

2019-05-16 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Optimize rotate_x() using tcg_gen_extract_i32(). We can now free the 'sz' tcg_temp earlier. Since it is allocated with tcg_const_i32(), free it with tcg_temp_free_i32(). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <2019031000342

[Qemu-devel] [PULL 4/6] target/m68k: Reduce the l1 TCGLabel scope

2019-05-16 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20190310003428.11723-2-f4...@amsat.org> Signed-off-by: Laurent Vivier --- target/m68k/translate.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/target/m68k/tr

[Qemu-devel] [PULL 5/6] target/m68k: Fix a tcg_temp leak

2019-05-16 Thread Laurent Vivier
From: Philippe Mathieu-Daudé The function gen_get_ccr() returns a tcg_temp created with tcg_temp_new(). Free it with tcg_temp_free(). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20190310003428.11723-4-f4...@amsat.org> Signed-off-by: Laurent Vivier --- ta

[Qemu-devel] [PULL 2/6] target/m68k: In get_physical_address() check for memory access failures

2019-05-16 Thread Laurent Vivier
From: Peter Maydell In get_physical_address(), use address_space_ldl() and address_space_stl() instead of ldl_phys() and stl_phys(). This allows us to check whether the memory access failed. For the moment, we simply return -1 in this case; add a TODO comment that we should ideally generate the a

[Qemu-devel] [PULL 1/6] target/m68k: In dump_address_map() check for memory access failures

2019-05-16 Thread Laurent Vivier
From: Peter Maydell In dump_address_map(), use address_space_ldl() instead of ldl_phys(). This allows us to check whether the memory access failed. Signed-off-by: Peter Maydell Message-Id: <20181210165636.28366-2-peter.mayd...@linaro.org> Signed-off-by: Laurent Vivier --- target/m68k/helper.c

[Qemu-devel] [PULL 0/6] M68k staging patches

2019-05-16 Thread Laurent Vivier
The following changes since commit c1497fba36465d0259d4d04f2bf09ea59ed42680: Merge remote-tracking branch 'remotes/dgilbert/tags/pull-migration-20190514b' into staging (2019-05-16 10:24:08 +0100) are available in the Git repository at: git://github.com/vivier/qemu-m68k.git tags/m68k-staging

[Qemu-devel] [PULL 3/6] target/m68k: Switch to transaction_failed hook

2019-05-16 Thread Laurent Vivier
From: Peter Maydell Switch the m68k target from the old unassigned_access hook to the transaction_failed hook. The notable difference is that rather than it being called for all physical memory accesses which fail (including those made by DMA devices or by the gdbstub), it is only called for tho

Re: [Qemu-devel] [PATCH v2] mips: Decide to map PAGE_EXEC in map_address

2019-05-16 Thread Aleksandar Markovic
On May 16, 2019 10:05 PM, "Philippe Mathieu-Daudé" wrote: > > On 5/16/19 8:04 PM, Aleksandar Markovic wrote: > > On May 16, 2019 6:31 PM, "Philippe Mathieu-Daudé" wrote: > >> > >> Hi Jakub, > >> > >> On 5/16/19 3:10 PM, Jakub Jermar wrote: > >>> Hi, > >>> > >>> On 5/3/19 12:02 PM, Jakub Jermar wr

Re: [Qemu-devel] [PATCH v2] mips: Decide to map PAGE_EXEC in map_address

2019-05-16 Thread Philippe Mathieu-Daudé
On 5/16/19 8:04 PM, Aleksandar Markovic wrote: > On May 16, 2019 6:31 PM, "Philippe Mathieu-Daudé" wrote: >> >> Hi Jakub, >> >> On 5/16/19 3:10 PM, Jakub Jermar wrote: >>> Hi, >>> >>> On 5/3/19 12:02 PM, Jakub Jermar wrote: Hi, On 4/23/19 4:58 PM, Jakub Jermar wrote: > Hi Philip

Re: [Qemu-devel] Maintainers, please tell us how to boot your machines!

2019-05-16 Thread Philippe Mathieu-Daudé
Hi Markus, On 3/12/19 6:36 PM, Markus Armbruster wrote: > Dear board code maintainers, > > This is a (rather late) follow-up to the last QEMU summit. Minutes[*]: > > * Deprecating unmaintained features (devices, targets, backends) in QEMU > >QEMU has a mechanism to deprecate features but

Re: [Qemu-devel] [PATCH v2] migration/dirty-bitmaps: change bitmap enumeration method

2019-05-16 Thread John Snow
On 5/16/19 6:12 AM, Vladimir Sementsov-Ogievskiy wrote: > 14.05.2019 23:19, John Snow wrote: >> Shift from looking at every root BDS to *every* BDS. This will migrate >> bitmaps that are attached to blockdev created nodes instead of just ones >> attached to emulated storage devices. >> >> Note t

[Qemu-devel] [PATCH] target/i386: add MDS-NO feature

2019-05-16 Thread Paolo Bonzini
Microarchitectural Data Sampling is a hardware vulnerability which allows unprivileged speculative access to data which is available in various CPU internal buffers. Some Intel processors use the ARCH_CAP_MDS_NO bit in the IA32_ARCH_CAPABILITIES MSR to report that they are not vulnerable, make it

Re: [Qemu-devel] [PULL 00/37] pci, pc, virtio: features, fixes

2019-05-16 Thread Philippe Mathieu-Daudé
On Thu, May 16, 2019 at 8:33 PM Philippe Mathieu-Daudé wrote: > On 5/16/19 6:04 PM, Peter Maydell wrote: > > On Thu, 16 May 2019 at 13:17, Michael S. Tsirkin wrote: > >> > >> The following changes since commit > >> efb4f3b62c69383a7308d7b739a3193e7c0ccae8: > >> > >> Merge remote-tracking branc

Re: [Qemu-devel] [PATCH v4 5/6] hw/acpi: Consolidate build_mcfg to pci.c

2019-05-16 Thread Philippe Mathieu-Daudé
On 4/19/19 2:30 AM, Wei Yang wrote: > Now we have two identical build_mcfg functions. > > Consolidate them in acpi/pci.c. > > Signed-off-by: Wei Yang > Reviewed-by: Philippe Mathieu-Daudé > Reviewed-by: Igor Mammedov > > --- > v3: > * adjust changelog based on Igor's suggestion > --- > def

Re: [Qemu-devel] [PULL 00/37] pci, pc, virtio: features, fixes

2019-05-16 Thread Philippe Mathieu-Daudé
On 5/16/19 6:04 PM, Peter Maydell wrote: > On Thu, 16 May 2019 at 13:17, Michael S. Tsirkin wrote: >> >> The following changes since commit efb4f3b62c69383a7308d7b739a3193e7c0ccae8: >> >> Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' >> into staging (2019-05-10 14:49:3

Re: [Qemu-devel] [PATCH 3/3] arm: Rename hw/arm/arm.h to hw/arm/boot.h

2019-05-16 Thread Peter Maydell
On Thu, 16 May 2019 at 19:16, Philippe Mathieu-Daudé wrote: > > On 5/16/19 6:38 PM, Peter Maydell wrote: > > The header file hw/arm/arm.h now includes only declarations > > relating to hw/arm/boot.c functionality. Rename it accordingly, > > and adjust its header comment. > > > > The bulk of this c

Re: [Qemu-devel] [PATCH 0/3] arm: Clean up and rename hw/arm/arm.h to hw/arm/boot.h

2019-05-16 Thread Philippe Mathieu-Daudé
On 5/16/19 6:38 PM, Peter Maydell wrote: > The header hw/arm/arm.h used to be a general bucket for > putting all kinds of arm-related declarations in. It now > has mostly kernel-boot related declarations, with one > exception: the declaration of the system_clock_scale global. > This patchset: > *

Re: [Qemu-devel] [PATCH 3/3] arm: Rename hw/arm/arm.h to hw/arm/boot.h

2019-05-16 Thread Philippe Mathieu-Daudé
On 5/16/19 6:38 PM, Peter Maydell wrote: > The header file hw/arm/arm.h now includes only declarations > relating to hw/arm/boot.c functionality. Rename it accordingly, > and adjust its header comment. > > The bulk of this commit was created via > perl -pi -e 's|hw/arm/arm.h|hw/arm/boot.h|' hw/ar

Re: [Qemu-devel] [PATCH v2] mips: Decide to map PAGE_EXEC in map_address

2019-05-16 Thread Aleksandar Markovic
On May 16, 2019 6:31 PM, "Philippe Mathieu-Daudé" wrote: > > Hi Jakub, > > On 5/16/19 3:10 PM, Jakub Jermar wrote: > > Hi, > > > > On 5/3/19 12:02 PM, Jakub Jermar wrote: > >> Hi, > >> > >> On 4/23/19 4:58 PM, Jakub Jermar wrote: > >>> Hi Philippe! > >>> > >>> On 4/23/19 3:48 PM, Philippe Mathieu-

Re: [Qemu-devel] [PULL 00/21] Misc patches for 2019-05-15

2019-05-16 Thread Paolo Bonzini
On 16/05/19 14:14, Peter Maydell wrote: >> Chen Zhang via Qemu-devel (1): >> hvf: Add missing break statement > Hi -- looks like this commit needs its author > email tidying up so it isn't attributed to the mailing list. Oops, it's the first time I see this. I'll fix and resend. Paolo

Re: [Qemu-devel] [PATCH v4 6/6] acpi: pci: use build_append_foo() API to construct MCFG

2019-05-16 Thread Igor Mammedov
On Thu, 16 May 2019 13:01:31 +0200 Philippe Mathieu-Daudé wrote: > On Thu, May 16, 2019 at 9:41 AM Wei Yang > wrote: > > > > On Wed, May 15, 2019 at 07:29:17AM +0200, Philippe Mathieu-Daudé wrote: > > > > > >Thanks Michael for testing... > > > > > >Wei, can you add a MCFG test in tests/bios-t

Re: [Qemu-devel] [PATCH v3 1/1] target/arm: Fix vector operation segfault

2019-05-16 Thread Peter Maydell
On Thu, 16 May 2019 at 16:56, Alistair Francis wrote: > > Commit 89e68b575 "target/arm: Use vector operations for saturation" > causes this abort() when booting QEMU ARM with a Cortex-A15: > > 0 0x74c2382f in raise () at /usr/lib/libc.so.6 > 1 0x74c0e672 in abort () at /usr/lib/l

[Qemu-devel] [PATCH 3/3] arm: Rename hw/arm/arm.h to hw/arm/boot.h

2019-05-16 Thread Peter Maydell
The header file hw/arm/arm.h now includes only declarations relating to hw/arm/boot.c functionality. Rename it accordingly, and adjust its header comment. The bulk of this commit was created via perl -pi -e 's|hw/arm/arm.h|hw/arm/boot.h|' hw/arm/*.c include/hw/arm/*.h Signed-off-by: Peter Maydel

[Qemu-devel] [PATCH 2/3] arm: Remove unnecessary includes of hw/arm/arm.h

2019-05-16 Thread Peter Maydell
The hw/arm/arm.h header now only includes declarations relating to boot.c code, so it is only needed by Arm board or SoC code. Remove some unnecessary inclusions of it from target/arm files and from hw/intc/armv7m_nvic.c. Signed-off-by: Peter Maydell --- hw/intc/armv7m_nvic.c | 1 - target/arm/a

[Qemu-devel] [PATCH 1/3] arm: Move system_clock_scale to armv7m_systick.h

2019-05-16 Thread Peter Maydell
The system_clock_scale global is used only by the armv7m systick device; move the extern declaration to the armv7m_systick.h header, and expand the comment to explain what it is and that it should ideally be replaced with a different approach. Signed-off-by: Peter Maydell --- include/hw/arm/arm.

[Qemu-devel] [PATCH 0/3] arm: Clean up and rename hw/arm/arm.h to hw/arm/boot.h

2019-05-16 Thread Peter Maydell
The header hw/arm/arm.h used to be a general bucket for putting all kinds of arm-related declarations in. It now has mostly kernel-boot related declarations, with one exception: the declaration of the system_clock_scale global. This patchset: * moves system_clock_scale to armv7m_systick.h (since t

Re: [Qemu-devel] [PATCH v3 1/1] target/arm: Fix vector operation segfault

2019-05-16 Thread Alex Bennée
Alistair Francis writes: > Commit 89e68b575 "target/arm: Use vector operations for saturation" > causes this abort() when booting QEMU ARM with a Cortex-A15: > > 0 0x74c2382f in raise () at /usr/lib/libc.so.6 > 1 0x74c0e672 in abort () at /usr/lib/libc.so.6 > 2 0x559c

Re: [Qemu-devel] [PATCH v2] mips: Decide to map PAGE_EXEC in map_address

2019-05-16 Thread Philippe Mathieu-Daudé
Hi Jakub, On 5/16/19 3:10 PM, Jakub Jermar wrote: > Hi, > > On 5/3/19 12:02 PM, Jakub Jermar wrote: >> Hi, >> >> On 4/23/19 4:58 PM, Jakub Jermar wrote: >>> Hi Philippe! >>> >>> On 4/23/19 3:48 PM, Philippe Mathieu-Daudé wrote: Hi Jakub, On 4/23/19 1:00 PM, Jakub Jermář wrote:

Re: [Qemu-devel] [PATCH] iotests: Fix intermittent failure in 219

2019-05-16 Thread Max Reitz
On 16.05.19 18:11, Max Reitz wrote: > In 219, we wait for the job to make progress before we emit its status. > This makes the output reliable. > > Unfortunately, there is a bug: We do not wait for any more progress if > the job has already reached its total-progress. Right after the job has > be

[Qemu-devel] [PATCH] iotests: Fix intermittent failure in 219

2019-05-16 Thread Max Reitz
In 219, we wait for the job to make progress before we emit its status. This makes the output reliable. Unfortunately, there is a bug: We do not wait for any more progress if the job has already reached its total-progress. Right after the job has been started, it is possible that total-progress i

Re: [Qemu-devel] [PULL 00/37] pci, pc, virtio: features, fixes

2019-05-16 Thread Peter Maydell
On Thu, 16 May 2019 at 13:17, Michael S. Tsirkin wrote: > > The following changes since commit efb4f3b62c69383a7308d7b739a3193e7c0ccae8: > > Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' > into staging (2019-05-10 14:49:36 +0100) > > are available in the Git repository

  1   2   3   >