Re: [PATCH] Fix `lxvdsx` (issue #212)

2021-05-17 Thread Mark Cave-Ayland
On 18/05/2021 02:34, David Gibson wrote: I'm having a hard time convincing myself this is correct in all cases. Have you tested it with all combinations of BE/LE host and BE/LE guest code? The description in the ISA is pretty inscrutable, since it's in terms of the confusing numbering if differ

RE: [RFC PATCH v3 4/4] hw/arm/virt: Parse -smp cluster parameter in virt_smp_parse

2021-05-17 Thread Salil Mehta
> From: wangyanan (Y) > > Hi Salil, > > On 2021/5/17 23:17, Salil Mehta wrote: > >> From: Qemu-devel > >> [mailto:qemu-devel-bounces+salil.mehta=huawei@nongnu.org] On Behalf Of > >> Yanan Wang > >> Sent: Sunday, May 16, 2021 11:32 AM > >> To: Peter Maydell ; Paolo Bonzini > >> ; Andrew Jones

RE: [RFC PATCH v3 6/9] hw/arm/virt-acpi-build: Use possible cpus in generation of MADT

2021-05-17 Thread Salil Mehta
> From: wangyanan (Y) > Sent: Tuesday, May 18, 2021 6:03 AM > > Hi Salil, > > On 2021/5/18 1:07, Salil Mehta wrote: > >> From: Qemu-arm > [mailto:qemu-arm-bounces+salil.mehta=huawei@nongnu.org] > >> On Behalf Of Yanan Wang > >> Sent: Sunday, May 16, 2021 11:29 AM > >> To: Peter Maydell ; Andr

Re: [PATCH] Fix `lxvdsx` (issue #212)

2021-05-17 Thread Giuseppe Musacchio
The ISA [1] specifies the load order to be the target one, hence the use of MO_TEQ in my patch (in both lxvwsx and lxvdsx). I believe the error is hidden in some of the .mak files: I could not reproduce this problem with Qemu's user-mode emulation in either BE nor LE mode, this lead me to discover

Re: [PATCH v2] target/riscv: Do not include 'pmp.h' in user emulation

2021-05-17 Thread Alistair Francis
On Mon, May 17, 2021 at 6:53 AM Philippe Mathieu-Daudé wrote: > > Physical Memory Protection is a system feature. > Avoid polluting the user-mode emulation by its definitions. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > target/riscv/cpu.h | 2 ++ >

Re: [RFC PATCH] block/io.c: Flush parent for quorum in generic code

2021-05-17 Thread Lukas Straub
On Wed, 12 May 2021 15:49:57 +0800 Zhang Chen wrote: > Fix the issue from this patch: > [PATCH] block: Flush all children in generic code > From 883833e29cb800b4d92b5d4736252f4004885191 > > Quorum driver do not have the primary child. > It will caused guest block flush issue when use quorum and

Re: [PATCH] target/riscv: Remove obsolete 'CPU unmigratable' comment

2021-05-17 Thread Alistair Francis
On Mon, May 17, 2021 at 5:09 PM Philippe Mathieu-Daudé wrote: > > The RISCV CPU is migratable since commit f7697f0e629 > ("target/riscv: Add basic vmstate description of CPU"), > so remove an obsolete comment which is now incorrect. > > Reported-by: Richard Henderson > Signed-off-by: Philippe Mat

[PULL 56/59] linux-user/alpha: Share code for TARGET_NR_sigaction

2021-05-17 Thread Laurent Vivier
From: Richard Henderson There's no longer a difference between the alpha code and the generic code. There is a type difference in target_old_sigaction.sa_flags, which can be resolved with a very much smaller ifdef, which allows us to finish sharing the target_sigaction definition. Signed-off-by

[Bug 1878057] Re: null-ptr dereference in megasas_command_complete

2021-05-17 Thread Thomas Huth
Can you still reproduce this issue with the current version of QEMU? For me, it does not crash anymore, so I assume this has been fixed already? ** Changed in: qemu Status: Confirmed => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is s

[PULL 53/59] linux-user: Pass ka_restorer to do_sigaction

2021-05-17 Thread Laurent Vivier
From: Richard Henderson The value of ka_restorer needs to be saved in sigact_table. At the moment, the attempt to save it in do_syscall is improperly clobbering user memory. Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée Message-Id: <20210422230227.314751-4-richard.hender...@linaro.

[PULL 57/59] linux-user: Tidy TARGET_NR_rt_sigaction

2021-05-17 Thread Laurent Vivier
From: Richard Henderson Initialize variables instead of elses. Use an else instead of a goto. Add braces. Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20210422230227.314751-8-richard.hender...@linaro.org> Signed-off-by: Laurent Viv

[PULL 55/59] linux-user/alpha: Define TARGET_ARCH_HAS_KA_RESTORER

2021-05-17 Thread Laurent Vivier
From: Richard Henderson This means that we can share the TARGET_NR_rt_sigaction code, and the target_rt_sigaction structure is unused. Untangling the ifdefs so that target_sigaction can be shared will wait until the next patch. Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée Message

[PULL 54/59] linux-user: Honor TARGET_ARCH_HAS_SA_RESTORER in do_syscall

2021-05-17 Thread Laurent Vivier
From: Richard Henderson Do not access a field that may not be present. This will become an issue when sharing more code in the next patch. Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20210422230227.314751-5-richard.hender...@lina

[PULL 52/59] linux-user/alpha: Rename the sigaction restorer field

2021-05-17 Thread Laurent Vivier
From: Richard Henderson Use ka_restorer, in line with TARGET_ARCH_HAS_KA_RESTORER vs TARGET_ARCH_HAS_SA_RESTORER, since Alpha passes this field as a syscall argument. Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée Message-Id: <20210422230227.314751-3-richard.hender...@linaro.org> Si

[PULL 48/59] linux-user: Add copy_file_range to strace.list

2021-05-17 Thread Laurent Vivier
From: Giuseppe Musacchio Signed-off-by: Giuseppe Musacchio Reviewed-by: Laurent Vivier Message-Id: <20210503174159.54302-2-thatle...@gmail.com> Signed-off-by: Laurent Vivier --- linux-user/strace.list | 3 +++ 1 file changed, 3 insertions(+) diff --git a/linux-user/strace.list b/linux-user/s

[PULL 43/59] linux-user/s390x: Add stub sigframe argument for last_break

2021-05-17 Thread Laurent Vivier
From: Richard Henderson In order to properly present these arguments, we need to add code to target/s390x to record LowCore parameters for user-only. But in the meantime, at least zero the missing last_break argument, and fixup the comment style in the vicinity. Signed-off-by: Richard Henderson

[PULL 44/59] linux-user/s390x: Fix frame_addr corruption in setup_frame

2021-05-17 Thread Laurent Vivier
From: Richard Henderson The original value of frame_addr is still required for its use in the call to unlock_user_struct below. Signed-off-by: Richard Henderson Reviewed-by: David Hildenbrand Message-Id: <20210428193408.233706-13-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier ---

[PULL 45/59] linux-user/s390x: Add build asserts for sigset sizes

2021-05-17 Thread Laurent Vivier
From: Richard Henderson At point of usage, it's not immediately obvious that we don't need a loop to copy these arrays. Signed-off-by: Richard Henderson Reviewed-by: David Hildenbrand Message-Id: <20210428193408.233706-14-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- linux-

[PULL 42/59] linux-user/s390x: Set psw.mask properly for the signal handler

2021-05-17 Thread Laurent Vivier
From: Richard Henderson Note that PSW_ADDR_{64,32} are called PSW_MASK_{EA,BA} in the kernel source. Signed-off-by: Richard Henderson Reviewed-by: David Hildenbrand Message-Id: <20210428193408.233706-11-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/s390x/signal.c

[PULL 39/59] linux-user/s390x: Use tswap_sigset in setup_rt_frame

2021-05-17 Thread Laurent Vivier
From: Richard Henderson Signed-off-by: Richard Henderson Reviewed-by: David Hildenbrand Message-Id: <20210428193408.233706-8-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/s390x/signal.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/linux

[PULL 36/59] linux-user/s390x: Remove restore_sigregs return value

2021-05-17 Thread Laurent Vivier
From: Richard Henderson The function cannot fail. Signed-off-by: Richard Henderson Reviewed-by: David Hildenbrand Message-Id: <20210428193408.233706-5-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/s390x/signal.c | 14 +++--- 1 file changed, 3 insertions(+

[PULL 37/59] linux-user/s390x: Fix trace in restore_regs

2021-05-17 Thread Laurent Vivier
From: Richard Henderson Directly reading sc->regs.psw.addr misses the bswap that may be performed by __get_user. Signed-off-by: Richard Henderson Reviewed-by: David Hildenbrand Message-Id: <20210428193408.233706-6-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/s39

[PULL 34/59] linux-user/s390x: Use uint16_t for signal retcode

2021-05-17 Thread Laurent Vivier
From: Richard Henderson Using the right type simplifies the frame setup. Signed-off-by: Richard Henderson Reviewed-by: David Hildenbrand Message-Id: <20210428193408.233706-3-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/s390x/signal.c | 9 - 1 file change

[PULL 38/59] linux-user/s390x: Fix sigcontext sregs value

2021-05-17 Thread Laurent Vivier
From: Richard Henderson Using the host address of &frame->sregs is incorrect. We need the guest address. Signed-off-by: Richard Henderson Reviewed-by: David Hildenbrand Message-Id: <20210428193408.233706-7-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/s390x/signa

[PULL 31/59] linux-user/sparc: Implement sparc64 rt signals

2021-05-17 Thread Laurent Vivier
From: Richard Henderson Signed-off-by: Richard Henderson Message-Id: <20210426025334.1168495-25-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/sparc/signal.c| 27 ++- linux-user/sparc/target_signal.h | 2 ++ 2 files changed, 28 inser

[PULL 32/59] tests/tcg/sparc64: Re-enable linux-test

2021-05-17 Thread Laurent Vivier
From: Richard Henderson It passes now that we support signals properly. Signed-off-by: Richard Henderson Message-Id: <20210426025334.1168495-26-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- tests/tcg/sparc64/Makefile.target | 7 +-- 1 file changed, 1 insertion(+), 6 dele

[PULL 51/59] linux-user/alpha: Fix rt sigframe return

2021-05-17 Thread Laurent Vivier
From: Richard Henderson We incorrectly used the offset of the non-rt sigframe. Reviewed-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée Message-Id: <20210422230227.314751-2-richard.hender...@linaro.org> Signed-off-by: Laurent V

[PULL 33/59] linux-user/s390x: Fix sigframe types

2021-05-17 Thread Laurent Vivier
From: Richard Henderson Noticed via gitlab clang-user job: TESTsignals on s390x ../linux-user/s390x/signal.c:258:9: runtime error: \ 1.84467e+19 is outside the range of representable values of \ type 'unsigned long' Which points to the fact that we were performing a double-to-uint64_t

[PULL 23/59] linux-user/sparc: Split out save_reg_win

2021-05-17 Thread Laurent Vivier
From: Richard Henderson Signed-off-by: Richard Henderson Message-Id: <20210426025334.1168495-17-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/sparc/signal.c | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/linux-user/sparc/si

Re: [PATCH v5 00/23] Base for adding PowerPC 64-bit instructions

2021-05-17 Thread David Gibson
On Mon, May 17, 2021 at 05:50:02PM -0300, matheus.fe...@eldorado.org.br wrote: > From: Matheus Ferst > > This series provides the basic infrastructure for adding the new 32/64-bit > instructions in Power ISA 3.1 to target/ppc. Well, I had applied them all, but I've now pulled patch 10 and onward

[PULL 26/59] linux-user/sparc: Add rwin_save to signal frame

2021-05-17 Thread Laurent Vivier
From: Richard Henderson Stub it out to zero, but at least include it. Signed-off-by: Richard Henderson Message-Id: <20210426025334.1168495-20-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/sparc/signal.c | 8 1 file changed, 8 insertions(+) diff --git a/l

[PULL 58/59] linux-user/elfload: fix filling psinfo->pr_psargs

2021-05-17 Thread Laurent Vivier
From: Ilya Leoshkevich The current code dumps the memory between arg_start and arg_end, which contains the argv pointers. This results in the Core was generated by `` message when opening the core file in GDB. This is because the code is supposed to dump the actual arg strings. Fix by using

[PULL 25/59] linux-user/sparc: Save and restore fpu in signal frame

2021-05-17 Thread Laurent Vivier
From: Richard Henderson Signed-off-by: Richard Henderson Message-Id: <20210426025334.1168495-19-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/sparc/signal.c | 84 --- 1 file changed, 51 insertions(+), 33 deletions(-) diff --git

[PULL 41/59] linux-user/s390x: Clean up single-use gotos in signal.c

2021-05-17 Thread Laurent Vivier
From: Richard Henderson Signed-off-by: Richard Henderson Reviewed-by: David Hildenbrand Message-Id: <20210428193408.233706-10-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/s390x/signal.c | 29 - 1 file changed, 8 insertions(+), 21 delet

[PULL 22/59] linux-user/sparc: Use target_pt_regs

2021-05-17 Thread Laurent Vivier
From: Richard Henderson Replace __siginfo_t with target_pt_regs, and move si_mask into target_signal_frame directly. Extract save/restore functions for target_pt_regs. Adjust for sparc64 tstate. Use proper get/put functions for psr. Turns out we were already writing to si_mask twice, so no nee

[PULL 24/59] linux-user/sparc: Clean up get_sigframe

2021-05-17 Thread Laurent Vivier
From: Richard Henderson Remove inline; fix spacing and comment format. Signed-off-by: Richard Henderson Message-Id: <20210426025334.1168495-18-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/sparc/signal.c | 13 +++-- 1 file changed, 7 insertions(+), 6 delet

[PULL 59/59] linux-user/elfload: add s390x core dumping support

2021-05-17 Thread Laurent Vivier
From: Ilya Leoshkevich Provide the following definitions required by the common code: * ELF_NREG: with the value of sizeof(s390_regs) / sizeof(long). * target_elf_gregset_t: define it like all the other arches do. * elf_core_copy_regs(): similar to kernel's s390_regs_get(). * USE_ELF_CORE_DUMP.

[PULL 18/59] linux-user/sparc: Merge sparc64/ into sparc/

2021-05-17 Thread Laurent Vivier
From: Richard Henderson All of the source and header files already defer to sparc via #include. The syscall.tbl and syscallhdr.sh files could not do the same, but are identical. Signed-off-by: Richard Henderson Message-Id: <20210426025334.1168495-12-richard.hender...@linaro.org> Signed-off-by:

[PULL 20/59] linux-user/sparc: Remove target_rt_signal_frame as unused

2021-05-17 Thread Laurent Vivier
From: Richard Henderson It's wrong anyway. Remove it for now. Signed-off-by: Richard Henderson Message-Id: <20210426025334.1168495-14-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/sparc/signal.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/linu

[PULL 40/59] linux-user/s390x: Tidy save_sigregs

2021-05-17 Thread Laurent Vivier
From: Richard Henderson The "save" routines copied from the kernel, which are currently commented out, are unnecessary in qemu. We can copy from env where the kernel needs special instructions. Fix comment style. Signed-off-by: Richard Henderson Reviewed-by: David Hildenbrand Message-Id: <20

[PULL 47/59] linux-user/s390x: Handle vector regs in signal stack

2021-05-17 Thread Laurent Vivier
From: Richard Henderson Signed-off-by: Richard Henderson Reviewed-by: David Hildenbrand Message-Id: <20210428193408.233706-16-richard.hender...@linaro.org> [lv: fix indentation] Signed-off-by: Laurent Vivier --- linux-user/s390x/signal.c | 62 +-- 1 file ch

[PULL 01/59] linux-user: Remove dead code

2021-05-17 Thread Laurent Vivier
From: Philippe Mathieu-Daudé We can not use watchpoints in user-mode emulation because we need the softmmu slow path to detect accesses to watchpointed memory. This code is expanded as empty stub in "hw/core/cpu.h" anyway, so we can drop it. Reviewed-by: Laurent Vivier Signed-off-by: Philippe M

[PULL 21/59] linux-user/sparc: Fix the stackframe structure

2021-05-17 Thread Laurent Vivier
From: Richard Henderson Move target_reg_window up and use it. Fold structptr and xxargs into xargs -- the use of a host pointer was incorrect anyway. Rename the structure to target_stackf for consistency. Signed-off-by: Richard Henderson Message-Id: <20210426025334.1168495-15-richard.hender...

[PULL 50/59] linux-user: use GDateTime for formatting timestamp for core file

2021-05-17 Thread Laurent Vivier
From: Daniel P. Berrangé The GDateTime APIs provided by GLib avoid portability pitfalls, such as some platforms where 'struct timeval.tv_sec' field is still 'long' instead of 'time_t'. When combined with automatic cleanup, GDateTime often results in simpler code too. Signed-off-by: Daniel P. Ber

[PULL 49/59] linux-user: Fix erroneous conversion in copy_file_range

2021-05-17 Thread Laurent Vivier
From: Giuseppe Musacchio The implicit cast from abi_long to size_t may introduce an intermediate unwanted sign-extension of the value for 32bit targets running on 64bit hosts. Signed-off-by: Giuseppe Musacchio Reviewed-by: Laurent Vivier Message-Id: <20210503174159.54302-3-thatle...@gmail.com>

[PULL 15/59] linux-user/sparc: Merge sparc64 target_elf.h

2021-05-17 Thread Laurent Vivier
From: Richard Henderson Signed-off-by: Richard Henderson Message-Id: <20210426025334.1168495-9-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/sparc64/target_elf.h | 15 +-- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/linux-user/sparc64/

[PULL 46/59] linux-user/s390x: Clean up signal.c

2021-05-17 Thread Laurent Vivier
From: Richard Henderson Reorder the function bodies to correspond to the kernel source. Signed-off-by: Richard Henderson Reviewed-by: David Hildenbrand Message-Id: <20210428193408.233706-15-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/s390x/signal.c | 63 +++

[PULL 12/59] linux-user/sparc: Include TARGET_STACK_BIAS in get_sp_from_cpustate

2021-05-17 Thread Laurent Vivier
From: Richard Henderson Move TARGET_STACK_BIAS from signal.c. Generic code cares about the logical stack pointer, not the physical one that has a bias applied for sparc64. Signed-off-by: Richard Henderson Message-Id: <20210426025334.1168495-6-richard.hender...@linaro.org> Signed-off-by: Lauren

[PULL 35/59] linux-user/s390x: Remove PSW_ADDR_AMODE

2021-05-17 Thread Laurent Vivier
From: Richard Henderson This is an unnecessary complication since we only support 64-bit mode. Signed-off-by: Richard Henderson Reviewed-by: David Hildenbrand Message-Id: <20210428193408.233706-4-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/s390x/signal.c | 17 +

[PULL 08/59] linux-user: Split out target_restore_altstack

2021-05-17 Thread Laurent Vivier
From: Richard Henderson Create a function to match target_save_altstack. Fix some style and unlock issues in do_sigaltstack. Signed-off-by: Richard Henderson Message-Id: <20210426025334.1168495-2-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/signal-common.h | 1

[PULL 30/59] linux-user/sparc: Implement sparc32 rt signals

2021-05-17 Thread Laurent Vivier
From: Richard Henderson Signed-off-by: Richard Henderson Message-Id: <20210426025334.1168495-24-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/sparc/signal.c | 126 -- 1 file changed, 122 insertions(+), 4 deletions(-) diff --git

[PULL 27/59] linux-user/sparc: Clean up setup_frame

2021-05-17 Thread Laurent Vivier
From: Richard Henderson Clean up a goto label with a single use. Remove #if 0. Remove useless parentheses. Fold constants into __put_user. Signed-off-by: Richard Henderson Message-Id: <20210426025334.1168495-21-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/sparc

[PULL 13/59] linux-user/sparc: Clean up init_thread

2021-05-17 Thread Laurent Vivier
From: Richard Henderson Share code between sparc32 and sparc64, removing a bit of pointless difference wrt psr/tstate. Use sizeof(abi_ulong) for allocating initial register window. Use TARGET_STACK_BIAS. Signed-off-by: Richard Henderson Message-Id: <20210426025334.1168495-7-richard.hender...@

[PULL 10/59] linux-user: Pass CPUArchState to do_sigaltstack

2021-05-17 Thread Laurent Vivier
From: Richard Henderson Now that we have exactly one call, it's easy to pass in env instead of passing in the sp value. Use target_save_altstack, which required env. Signed-off-by: Richard Henderson Message-Id: <20210426025334.1168495-4-richard.hender...@linaro.org> Signed-off-by: Laurent Vivie

[PULL 28/59] linux-user/sparc: Minor corrections to do_sigreturn

2021-05-17 Thread Laurent Vivier
From: Richard Henderson Check that the input sp is 16 byte aligned, not 4. Do that before the lock_user_struct check. Validate the saved sp is 8 byte aligned. Signed-off-by: Richard Henderson Message-Id: <20210426025334.1168495-22-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --

[PULL 11/59] linux-user: Pass CPUArchState to target_restore_altstack

2021-05-17 Thread Laurent Vivier
From: Richard Henderson In most cases we were already passing get_sp_from_cpustate directly to the function. In other cases, we were passing a local variable which already contained the same value. In the rest of the cases, we were passing the stack pointer out of env directly. Reviewed by: War

[PULL 19/59] linux-user/sparc: Remove target_sigcontext as unused

2021-05-17 Thread Laurent Vivier
From: Richard Henderson Signed-off-by: Richard Henderson Message-Id: <20210426025334.1168495-13-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/sparc/signal.c | 28 1 file changed, 28 deletions(-) diff --git a/linux-user/sparc/signal.c b

[PULL 06/59] linux-user/arm: Simplify accumulating and raising fpa11 exceptions

2021-05-17 Thread Laurent Vivier
From: Richard Henderson Use bit masking instead of an if tree. Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell Message-Id: <20210423165413.338259-5-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/arm/cpu_loop.c | 50 ++---

[PULL 02/59] linux-user: strace now handles unshare syscall args correctly

2021-05-17 Thread Laurent Vivier
From: Matus Kysel Syscall unshare did not have custom print function for strace, but it's argument is same as flags in clone syscall, so it can be easily implemented. Also updated missing flags from clone_flags. Signed-off-by: Matus Kysel Reviewed-by: Laurent Vivier Message-Id: <2021040614420

[PULL 17/59] linux-user/sparc: Merge sparc64 termbits.h

2021-05-17 Thread Laurent Vivier
From: Richard Henderson Signed-off-by: Richard Henderson Message-Id: <20210426025334.1168495-11-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/sparc64/termbits.h | 292 +- 1 file changed, 1 insertion(+), 291 deletions(-) diff --git a

[PULL 29/59] linux-user/sparc: Add 64-bit support to fpu save/restore

2021-05-17 Thread Laurent Vivier
From: Richard Henderson The shape of the kernel's __siginfo_fpu_t is dependent on the cpu type, not the abi. Which is weird, but there ya go. Signed-off-by: Richard Henderson Message-Id: <20210426025334.1168495-23-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/spa

[PULL 03/59] linux-user/arm: Split out emulate_arm_fpa11

2021-05-17 Thread Laurent Vivier
From: Richard Henderson Pull out the fpa11 emulation to a helper function. Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell Message-Id: <20210423165413.338259-2-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/arm/cpu_loop.c | 153 +++-

[PULL 16/59] linux-user/sparc: Merge sparc64 target_structs.h

2021-05-17 Thread Laurent Vivier
From: Richard Henderson Signed-off-by: Richard Henderson Message-Id: <20210426025334.1168495-10-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/sparc/target_structs.h | 34 +++-- linux-user/sparc64/target_structs.h | 59 + 2

[PULL 09/59] linux-user: Use target_restore_altstack in all sigreturn

2021-05-17 Thread Laurent Vivier
From: Richard Henderson Note that target_restore_altstack uses the host memory pointer that we have already verified, so TARGET_EFAULT is not a possible return value. Note that using -EFAULT was a bug. Signed-off-by: Richard Henderson Message-Id: <20210426025334.1168495-3-richard.hender...@lin

[PULL 14/59] linux-user/sparc: Merge sparc64 target_syscall.h

2021-05-17 Thread Laurent Vivier
From: Richard Henderson There are only a few differences in sparc32 vs sparc64. This fixes target_shmlba for sparc32plus, which is v9. Signed-off-by: Richard Henderson Message-Id: <20210426025334.1168495-8-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/sparc/target

[PULL 07/59] linux-user: Add strace support for printing arguments of llseek

2021-05-17 Thread Laurent Vivier
From: Kito Cheng Some target are using llseek instead of _llseek like riscv, nios2, hexagon, and openrisc. Signed-off-by: Kito Cheng Reviewed-by: Laurent Vivier Message-Id: <20210512101358.122781-1-kito.ch...@sifive.com> Signed-off-by: Laurent Vivier --- linux-user/strace.c| 3 ++- linux

[PULL 05/59] linux-user/arm: Do not fill in si_code for fpa11 exceptions

2021-05-17 Thread Laurent Vivier
From: Richard Henderson There is no such decoding in linux/arch/arm/nwfpe/fpmodule.c. Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell Message-Id: <20210423165413.338259-4-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/arm/cpu_loop.c | 26 ++

[PULL 04/59] linux-user/arm: Do not emulate fpa11 in thumb mode

2021-05-17 Thread Laurent Vivier
From: Richard Henderson These antiquated instructions are arm-mode only. Buglink: https://bugs.launchpad.net/bugs/1925512 Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell Message-Id: <20210423165413.338259-3-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- linux-use

[PULL 00/59] Linux user for 6.1 patches

2021-05-17 Thread Laurent Vivier
r-6.1-pull-request for you to fetch changes up to 4a1e8931eca05077afd0b7ed092ab0f10c5b457e: linux-user/elfload: add s390x core dumping support (2021-05-18 07:10:46 +0200) linux-user pull request 20210517 - alpha sigaction fixe

Re: Best approach for supporting snapshots for QEMU's gdbstub?

2021-05-17 Thread Pavel Dovgalyuk
On 17.05.2021 20:27, Alex Bennée wrote: Luis Machado writes: Hi, On 5/14/21 1:06 PM, Alex Bennée wrote: Hi, I've been playing around with QEMU's reverse debugging support which I have working with Pavel's latest patches for supporting virtio with record/replay. Once you get the right comman

Re: [PATCH qemu v19] spapr: Implement Open Firmware client interface

2021-05-17 Thread Alexey Kardashevskiy
On 18/05/2021 04:44, BALATON Zoltan wrote: On Mon, 17 May 2021, BALATON Zoltan wrote: On Mon, 17 May 2021, Alexey Kardashevskiy wrote: On 5/17/21 09:34, BALATON Zoltan wrote: On Sat, 15 May 2021, BALATON Zoltan wrote: On Sat, 15 May 2021, BALATON Zoltan wrote: On Thu, 22 Apr 2021, Alexey

Re: [PULL 00/59] Linux user for 6.1 patches

2021-05-17 Thread Laurent Vivier
Hi, I'm going to send an updated PR with fixes for problem reported by checkpatch. Thanks, Laurent Le 17/05/2021 à 21:15, no-re...@patchew.org a écrit : > Patchew URL: https://patchew.org/QEMU/20210517181424.8093-1-laur...@vivier.eu/ > > > > Hi, > > This series seems to have some coding styl

Re: [RFC PATCH v3 6/9] hw/arm/virt-acpi-build: Use possible cpus in generation of MADT

2021-05-17 Thread wangyanan (Y)
Hi Salil, On 2021/5/18 1:07, Salil Mehta wrote: From: Qemu-arm [mailto:qemu-arm-bounces+salil.mehta=huawei@nongnu.org] On Behalf Of Yanan Wang Sent: Sunday, May 16, 2021 11:29 AM To: Peter Maydell ; Andrew Jones ; Michael S . Tsirkin ; Igor Mammedov ; Shannon Zhao ; Alistair Francis ; David

Re: [PATCH qemu v19] spapr: Implement Open Firmware client interface

2021-05-17 Thread Alexey Kardashevskiy
On 17/05/2021 22:17, BALATON Zoltan wrote: On Mon, 17 May 2021, Alexey Kardashevskiy wrote: On 5/16/21 01:04, BALATON Zoltan wrote: On Thu, 22 Apr 2021, Alexey Kardashevskiy wrote: [snip] +/* Defined as Big Endian */ +struct prom_args { +    uint32_t service; +    uint32_t nargs; +    ui

[Bug 1912780] Re: QEMU: Null Pointer Failure in fdctrl_read() in hw/block/fdc.c

2021-05-17 Thread Thomas Huth
This is an automated cleanup. This bug report has been moved to QEMU's new bug tracker on gitlab.com and thus gets marked as 'expired' now. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/338 ** Changed in: qemu Status: In Progress => Expired ** B

Re: [RFC PATCH v3 4/9] hw/arm/virt: Initialize the present cpu members

2021-05-17 Thread wangyanan (Y)
Hi Salil, On 2021/5/18 4:48, Salil Mehta wrote: From: Qemu-arm [mailto:qemu-arm-bounces+salil.mehta=huawei@nongnu.org] On Behalf Of Yanan Wang Sent: Sunday, May 16, 2021 11:29 AM To: Peter Maydell ; Andrew Jones ; Michael S . Tsirkin ; Igor Mammedov ; Shannon Zhao ; Alistair Francis ; David

[Bug 1925496] Re: nvme disk cannot be hotplugged after removal

2021-05-17 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know how to transfer the bug to the new system if (if still necessary). Thus we're setting the status to "Incomplete" now. In the unlikely case that the bug has already been fixed in the latest upstream ve

[Bug 1914638] Re: [OSS-Fuzz] Issue 30219: Global-buffer-overflow in mode_sense_page

2021-05-17 Thread Thomas Huth
What happened to your patch, Philippe? Did it get stalled? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1914638 Title: [OSS-Fuzz] Issue 30219: Global-buffer-overflow in mode_sense_page Status in

[Bug 1914870] Re: libvixl compilation failure on Debian unstable

2021-05-17 Thread Thomas Huth
Suggested patch: https://lists.gnu.org/archive/html/qemu-devel/2021-05/msg04637.html ** Changed in: qemu Status: Confirmed => In Progress -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1914870

[Bug 1922102] Re: Broken tap networking on macOS host

2021-05-17 Thread Thomas Huth
Ticket has been moved here (thanks, Vladislav!): https://gitlab.com/qemu-project/qemu/-/issues/335 ... thus I'm closing this on Launchpad now. ** Bug watch added: gitlab.com/qemu-project/qemu/-/issues #335 https://gitlab.com/qemu-project/qemu/-/issues/335 ** Changed in: qemu Status: Inc

[Bug 1796520] Re: autogen crashes on qemu-sh4-user after 61dedf2af7

2021-05-17 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1796520 Title: autogen cra

Re: [PATCH v2 4/6] python/console_socket: Add a pylint ignore

2021-05-17 Thread Cleber Rosa
On Mon, May 17, 2021 at 02:48:06PM -0400, John Snow wrote: > We manage cleaning up this resource ourselves. Pylint should shush. > > Signed-off-by: John Snow > --- > python/qemu/console_socket.py | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by: Cleber Rosa signature.asc Description: PG

Re: [PATCH v2 6/6] python/machine: disable warning for Popen in _launch()

2021-05-17 Thread Cleber Rosa
On Mon, May 17, 2021 at 02:48:08PM -0400, John Snow wrote: > We handle this resource rather meticulously in > shutdown/kill/wait/__exit__ et al, through the laborious mechanisms in > _do_shutdown(). > > Quiet this pylint warning here. > > Signed-off-by: John Snow > --- > python/qemu/machine.py

Re: [PATCH v2 2/6] python/machine: use subprocess.DEVNULL instead of open(os.path.devnull)

2021-05-17 Thread Cleber Rosa
On Mon, May 17, 2021 at 02:48:04PM -0400, John Snow wrote: > One less file resource to manage, and it helps quiet some pylint >= > 2.8.0 warnings about not using a with-context manager for the open call. > > Signed-off-by: John Snow > Reviewed-by: Philippe Mathieu-Daudé > --- > python/qemu/mach

Re: [PATCH v2 3/6] python/machine: use subprocess.run instead of subprocess.Popen

2021-05-17 Thread Cleber Rosa
On Mon, May 17, 2021 at 02:48:05PM -0400, John Snow wrote: > use run() instead of Popen() -- to assert to pylint that we are not > forgetting to close a long-running program. > > Signed-off-by: John Snow > --- > python/qemu/machine.py | 15 +-- > 1 file changed, 9 insertions(+), 6 de

Re: [PATCH v2 5/6] python/machine: Disable pylint warning for open() in _pre_launch

2021-05-17 Thread Cleber Rosa
On Mon, May 17, 2021 at 02:48:07PM -0400, John Snow wrote: > Shift the open() call later so that the pylint pragma applies *only* to > that one open() call. Add a note that suggests why this is safe: the > resource is unconditionally cleaned up in _post_shutdown(). > > _post_shutdown is called aft

Re: [RFC PATCH v3 4/4] hw/arm/virt: Parse -smp cluster parameter in virt_smp_parse

2021-05-17 Thread wangyanan (Y)
Hi Salil, On 2021/5/17 23:17, Salil Mehta wrote: From: Qemu-devel [mailto:qemu-devel-bounces+salil.mehta=huawei@nongnu.org] On Behalf Of Yanan Wang Sent: Sunday, May 16, 2021 11:32 AM To: Peter Maydell ; Paolo Bonzini ; Andrew Jones ; Michael S . Tsirkin ; Igor Mammedov ; Shannon Zhao ; qemu

Re: [PATCH v4 2/2] target/i386: Correct implementation for FCS, FIP, FDS and FDP

2021-05-17 Thread Ziqiao Kong
On Tue, May 18, 2021 at 4:29 AM Eduardo Habkost wrote: > > Hi, > > Thanks for the patch, and apologies for not reviewing earlier > versions. > Nevermind, the earlier version is also hard to review without a proper split. > On Fri, May 07, 2021 at 04:00:58PM +0800, Ziqiao Kong wrote: > > Changes

Re: [PATCH v4 1/2] target/i386: Trivial code motion

2021-05-17 Thread Ziqiao Kong
On Tue, May 18, 2021 at 4:16 AM Eduardo Habkost wrote: > > On Fri, May 07, 2021 at 04:00:56PM +0800, Ziqiao Kong wrote: > > Move the float translation case to a new block by a new pair of braces. > > If you are just adding braces around the code, do you really need > to reindent all the code? I d

Re: [RFC PATCH v3 9/9] hw/arm/virt: Add separate -smp parsing function for ARM machines

2021-05-17 Thread wangyanan (Y)
Hi Drew, On 2021/5/17 16:24, Andrew Jones wrote: On Sun, May 16, 2021 at 06:29:00PM +0800, Yanan Wang wrote: The cpu hierarchy topology information parsed out from QEMU -smp command line will be exposed to guest kernel through ACPI and DT since machine type 6.1, so we will expect more detailed

Re: [PATCH v5 20/23] target/ppc: Implement cfuged instruction

2021-05-17 Thread David Gibson
On Mon, May 17, 2021 at 05:50:22PM -0300, matheus.fe...@eldorado.org.br wrote: > From: Matheus Ferst > > Signed-off-by: Matheus Ferst Applied to ppc-for-6.1, thanks. > --- > v5: > - Comments to explain helper_cfuged implementation. > --- > target/ppc/helper.h| 1 + >

RE: [PATCH v6 05/10] Add a function named packet_new_nocopy for COLO.

2021-05-17 Thread Zhang, Chen
> -Original Message- > From: Rao, Lei > Sent: Friday, April 9, 2021 11:21 AM > To: Zhang, Chen ; lizhij...@cn.fujitsu.com; > jasow...@redhat.com; quint...@redhat.com; dgilb...@redhat.com; > pbonz...@redhat.com; lukasstra...@web.de > Cc: qemu-devel@nongnu.org; Rao, Lei > Subject: [PATCH

Re: [PATCH v5 23/23] target/ppc: Move cmp/cmpi/cmpl/cmpli to decodetree

2021-05-17 Thread David Gibson
On Mon, May 17, 2021 at 05:50:25PM -0300, matheus.fe...@eldorado.org.br wrote: > From: Matheus Ferst > > Signed-off-by: Matheus Ferst Applied to ppc-for-6.1, thanks. > --- > target/ppc/insn32.decode | 14 ++ > target/ppc/translate.c | 52 -

Re: [PATCH v5 21/23] target/ppc: Implement vcfuged instruction

2021-05-17 Thread David Gibson
On Mon, May 17, 2021 at 05:50:23PM -0300, matheus.fe...@eldorado.org.br wrote: > From: Matheus Ferst > > Signed-off-by: Matheus Ferst Applied to ppc-for-6.1, thanks. > --- > v5: > - New REQUIRE_ALTIVEC macro; > - REQUIRE_INSNS_FLAGS2. > --- > target/ppc/insn32.decode | 7 >

Re: [PATCH v5 14/23] TCG: add tcg_constant_tl

2021-05-17 Thread David Gibson
On Mon, May 17, 2021 at 05:50:16PM -0300, matheus.fe...@eldorado.org.br wrote: > From: Matheus Ferst > > Used in D/DS/X-form load/store implementation. > > Signed-off-by: Matheus Ferst Applied to ppc-for-6.1, thanks. > --- > include/tcg/tcg-op.h | 2 ++ > 1 file changed, 2 insertions(+) > >

Re: [PATCH v5 22/23] target/ppc: Move addpcis to decodetree

2021-05-17 Thread David Gibson
On Mon, May 17, 2021 at 05:50:24PM -0300, matheus.fe...@eldorado.org.br wrote: > From: Matheus Ferst > > Reviewed-by: Richard Henderson > Signed-off-by: Matheus Ferst Applied to ppc-for-6.1, thanks. > --- > target/ppc/insn32.decode | 6 ++ > target/ppc/translate.c

Re: [PATCH v5 18/23] target/ppc: Implement prefixed integer store instructions

2021-05-17 Thread David Gibson
On Mon, May 17, 2021 at 05:50:20PM -0300, matheus.fe...@eldorado.org.br wrote: > From: Richard Henderson > > Signed-off-by: Richard Henderson > Signed-off-by: Matheus Ferst Applied to ppc-for-6.1, thanks. > --- > target/ppc/insn64.decode | 12 > target/ppc/tran

Re: [PATCH v5 15/23] target/ppc: Move D/DS/X-form integer loads to decodetree

2021-05-17 Thread David Gibson
On Mon, May 17, 2021 at 05:50:17PM -0300, matheus.fe...@eldorado.org.br wrote: > From: Richard Henderson > > These are all connected by macros in the legacy decoding. > > Signed-off-by: Richard Henderson > Signed-off-by: Matheus Ferst Applied to ppc-for-6.1, thanks. > --- > target/ppc/insn3

Re: [PATCH v5 17/23] target/ppc: Move D/DS/X-form integer stores to decodetree

2021-05-17 Thread David Gibson
On Mon, May 17, 2021 at 05:50:19PM -0300, matheus.fe...@eldorado.org.br wrote: > From: Richard Henderson > > These are all connected by macros in the legacy decoding. > > Signed-off-by: Richard Henderson > Signed-off-by: Matheus Ferst Applied to ppc-for-6.1, thanks. > --- > target/ppc/insn3

Re: [PATCH v5 12/23] target/ppc: Move ADDI, ADDIS to decodetree, implement PADDI

2021-05-17 Thread David Gibson
On Mon, May 17, 2021 at 05:50:14PM -0300, matheus.fe...@eldorado.org.br wrote: > From: Richard Henderson > > Signed-off-by: Richard Henderson > Signed-off-by: Matheus Ferst Applied to ppc-for-6.1, thanks. > --- > target/ppc/insn32.decode | 8 > target/ppc/insn64.decod

  1   2   3   4   5   6   7   >