[Qemu-devel] [PATCH] scsi-hd: fix property unset case

2015-03-04 Thread Ekaterina Tumanova
Reported-by: Max Reitz Reviewed-by: Stefan Hajnoczi Reviewed-by: Max Reitz Signed-off-by: Ekaterina Tumanova --- hw/scsi/scsi-disk.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c index 2921728..54d71f4 100644 --- a/hw/scsi/s

Re: [Qemu-devel] [PATCH 1/1] scsi-hd: fix property unset case

2015-03-02 Thread Ekaterina Tumanova
On 03/02/2015 11:46 AM, Markus Armbruster wrote: Ekaterina Tumanova writes: check conf.blk before calling blkconf_blocksizes Signed-off-by: Ekaterina Tumanova --- hw/scsi/scsi-disk.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi

[Qemu-devel] [PATCH 1/1] scsi-hd: fix property unset case

2015-02-27 Thread Ekaterina Tumanova
check conf.blk before calling blkconf_blocksizes Signed-off-by: Ekaterina Tumanova --- hw/scsi/scsi-disk.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c index 2921728..df5140e 100644 --- a/hw/scsi/scsi-disk.c +++ b/hw/scsi/scsi

[Qemu-devel] [PATCH 0/1]

2015-02-27 Thread Ekaterina Tumanova
for Max Reitz: Can you please apply this patch and re-test? Thanks! Kate p.s. This is supposed to be merged with patch 5/5 of "Geometry and blocksize detection for backing devices" Ekaterina Tumanova (1): scsi-hd: fix property unset case hw/scsi/scsi-disk.c | 4 +++- 1 file

[Qemu-devel] [PATCH v7 5/5] BlockConf: Call backend functions to detect geometry and blocksizes

2015-02-16 Thread Ekaterina Tumanova
se it will set default 512 value. The blkconf_blocksizes call was added to all users of BlkConf. Signed-off-by: Ekaterina Tumanova Reviewed-by: Markus Armbruster Reviewed-by: Stefan Hajnoczi --- hw/block/block.c | 24 hw/block/hd-geometry.c | 10 +

[Qemu-devel] [PATCH v7 3/5] block: Add driver methods to probe blocksizes and geometry

2015-02-16 Thread Ekaterina Tumanova
at a local check_for_dasd function was introduced. It calls BIODASDINFO2 ioctl and returns its rc. Blocksizes detection function will probe sizes for DASD devices. Signed-off-by: Ekaterina Tumanova Reviewed-by: Markus Armbruster Reviewed-by: Stefan Hajnoczi ---

[Qemu-devel] [PATCH v7 0/5] Geometry and blocksize detection for backing devices.

2015-02-16 Thread Ekaterina Tumanova
er to allow this logic, blocksize properties were initialized with 0. (driver will return 512 if backing device probing didn't succeed or if driver method is not defined). 2. hd_geometry guess was changed to firstly try to retrieve values via blk_probe_geometry and if it fails, fallback to the old logic.

[Qemu-devel] [PATCH v7 1/5] block: add bdrv functions for geometry and blocksize

2015-02-16 Thread Ekaterina Tumanova
Add driver functions for geometry and blocksize detection Signed-off-by: Ekaterina Tumanova Reviewed-by: Thomas Huth Reviewed-by: Markus Armbruster Reviewed-by: Stefan Hajnoczi --- block.c | 34 ++ include/block/block.h | 13

[Qemu-devel] [PATCH v7 4/5] block-backend: Add wrappers for blocksizes and geometry probing

2015-02-16 Thread Ekaterina Tumanova
Signed-off-by: Ekaterina Tumanova Reviewed-by: Markus Armbruster Reviewed-by: Stefan Hajnoczi --- block/block-backend.c | 10 ++ include/sysemu/block-backend.h | 2 ++ 2 files changed, 12 insertions(+) diff --git a/block/block-backend.c b/block/block-backend.c index c28e240

[Qemu-devel] [PATCH v7 2/5] raw-posix: Factor block size detection out of raw_probe_alignment()

2015-02-16 Thread Ekaterina Tumanova
Put it in new probe_logical_blocksize(). Signed-off-by: Ekaterina Tumanova Reviewed-by: Markus Armbruster Reviewed-by: Stefan Hajnoczi --- block/raw-posix.c | 51 +++ 1 file changed, 35 insertions(+), 16 deletions(-) diff --git a/block/raw

Re: [Qemu-devel] [PATCH v6 5/5] BlockConf: Call backend functions to detect geometry and blocksizes

2015-02-13 Thread Ekaterina Tumanova
On 02/13/2015 03:23 PM, Christian Borntraeger wrote: Am 19.01.2015 um 15:35 schrieb Ekaterina Tumanova: geometry: hd_geometry_guess function autodetects the drive geometry. This patch adds a block backend call, that probes the backing device geometry. If the inner driver method is implemented

Re: [Qemu-devel] [PATCH v6 0/5] Geometry and blocksize detection for backing devices.

2015-02-04 Thread Ekaterina Tumanova
On 01/19/2015 05:34 PM, Ekaterina Tumanova wrote: Updates v5 -> v6: Minor Updates according the last review from Stefan Hajnoczi: 1. Do not change the flow of code, factored out of raw_probe_alignment. 2. added #ifdef __linux__ in 2 places of raw-posix.c, mentioned by reviewer. 3. adjusted

[Qemu-devel] [PATCH v6 5/5] BlockConf: Call backend functions to detect geometry and blocksizes

2015-01-19 Thread Ekaterina Tumanova
r any backend but DASD). The blkconf_blocksizes call was added to all users of BlkConf. Signed-off-by: Ekaterina Tumanova Reviewed-by: Markus Armbruster --- hw/block/block.c | 20 hw/block/hd-geometry.c | 10 +- hw/block/nvme.c | 1

[Qemu-devel] [PATCH v6 1/5] block: add bdrv functions for geometry and blocksize

2015-01-19 Thread Ekaterina Tumanova
Add driver functions for geometry and blocksize detection Signed-off-by: Ekaterina Tumanova Reviewed-by: Thomas Huth Reviewed-by: Markus Armbruster --- block.c | 36 include/block/block.h | 13 + include/block/block_int.h

[Qemu-devel] [PATCH v6 2/5] raw-posix: Factor block size detection out of raw_probe_alignment()

2015-01-19 Thread Ekaterina Tumanova
Put it in new probe_logical_blocksize(). Signed-off-by: Ekaterina Tumanova Reviewed-by: Markus Armbruster --- block/raw-posix.c | 51 +++ 1 file changed, 35 insertions(+), 16 deletions(-) diff --git a/block/raw-posix.c b/block/raw-posix.c index

[Qemu-devel] [PATCH v6 0/5] Geometry and blocksize detection for backing devices.

2015-01-19 Thread Ekaterina Tumanova
changed to firstly try to retrieve values via blk_probe_geometry and if it fails, fallback to the old logic. Ekaterina Tumanova (5): block: add bdrv functions for geometry and blocksize raw-posix: Factor block size detection out of raw_probe_alignment() block: Add driver methods to probe blo

[Qemu-devel] [PATCH v6 3/5] block: Add driver methods to probe blocksizes and geometry

2015-01-19 Thread Ekaterina Tumanova
at a local check_for_dasd function was introduced. It calls BIODASDINFO2 ioctl and returns its rc. Blocksizes detection function will probe sizes for DASD devices and set default for other devices. Signed-off-by: Ekaterina Tumanova Reviewed-by: Markus Armbruster ---

[Qemu-devel] [PATCH v6 4/5] block-backend: Add wrappers for blocksizes and geometry probing

2015-01-19 Thread Ekaterina Tumanova
Signed-off-by: Ekaterina Tumanova Reviewed-by: Markus Armbruster Reviewed-by: Stefan Hajnoczi --- block/block-backend.c | 10 ++ include/sysemu/block-backend.h | 2 ++ 2 files changed, 12 insertions(+) diff --git a/block/block-backend.c b/block/block-backend.c index d00c129

Re: [Qemu-devel] [PATCH v5 2/5] raw-posix: Refactor logical block size detection.

2015-01-13 Thread Ekaterina Tumanova
On 01/02/2015 02:52 PM, Stefan Hajnoczi wrote: On Thu, Dec 18, 2014 at 12:18:01PM +0100, Ekaterina Tumanova wrote: +#if defined(BLKSSZGET) +# define SECTOR_SIZE BLKSSZGET +#elif defined(DKIOCGETBLOCKSIZE) +# define SECTOR_SIZE DKIOCGETBLOCKSIZE +#elif defined(DIOCGSECTORSIZE) +# define

Re: [Qemu-devel] [PATCH v5 0/5] Geometry and blocksize detection for backing devices.

2015-01-13 Thread Ekaterina Tumanova
On 01/02/2015 02:30 PM, Stefan Hajnoczi wrote: On Thu, Dec 18, 2014 at 12:17:59PM +0100, Ekaterina Tumanova wrote: Updates v4 -> v5: Minor Updates according the last review from Markus: 1. update commit message for patch 2 2. fix comment typos 3. fix check_for_dasd to return -1 instead

[Qemu-devel] [PATCH v5 4/5] block-backend: Add wrappers for blocksizes and geometry probing

2014-12-18 Thread Ekaterina Tumanova
Signed-off-by: Ekaterina Tumanova Reviewed-by: Markus Armbruster --- block/block-backend.c | 10 ++ include/sysemu/block-backend.h | 2 ++ 2 files changed, 12 insertions(+) diff --git a/block/block-backend.c b/block/block-backend.c index ef16d73..4b9ed85 100644 --- a/block

[Qemu-devel] [PATCH v5 2/5] raw-posix: Refactor logical block size detection.

2014-12-18 Thread Ekaterina Tumanova
1. Move block size detection into dedicated function. 2. Select exactly one IOCTL that detects blocksize, specific to the host OS. Signed-off-by: Ekaterina Tumanova Reviewed-by: Markus Armbruster --- block/raw-posix.c | 41 - 1 file changed, 24

[Qemu-devel] [PATCH v5 5/5] BlockConf: Call backend functions to detect geometry and blocksizes

2014-12-18 Thread Ekaterina Tumanova
12 for any backend but DASD). The blkconf_blocksizes call was added to all users of BlkConf. Signed-off-by: Ekaterina Tumanova Reviewed-by: Markus Armbruster --- hw/block/block.c | 15 +++ hw/block/hd-geometry.c| 10 +- hw/block/nvme.c | 1 + hw/bl

[Qemu-devel] [PATCH v5 1/5] block: add bdrv functions for geometry and blocksize

2014-12-18 Thread Ekaterina Tumanova
Add driver functions for geometry and blocksize detection Signed-off-by: Ekaterina Tumanova Reviewed-by: Thomas Huth Reviewed-by: Markus Armbruster --- block.c | 35 +++ include/block/block.h | 13 + include/block/block_int.h

[Qemu-devel] [PATCH v5 3/5] block: Add driver methods to probe blocksizes and geometry

2014-12-18 Thread Ekaterina Tumanova
at a local check_for_dasd function was introduced. It calls BIODASDINFO2 ioctl and returns its rc. Blocksizes detection function will probe sizes for DASD devices and set default for other devices. Signed-off-by: Ekaterina Tumanova Reviewed-by: Markus Armbruster --

[Qemu-devel] [PATCH v5 0/5] Geometry and blocksize detection for backing devices.

2014-12-18 Thread Ekaterina Tumanova
if it fails, fallback to the old logic. Ekaterina Tumanova (5): block: add bdrv functions for geometry and blocksize raw-posix: Refactor logical block size detection. block: Add driver methods to probe blocksizes and geometry block-backend: Add wrappers for blocksizes and geometry probing

[Qemu-devel] [PATCH v4 5/5] BlockConf: Call backend functions to detect geometry and blocksizes

2014-12-16 Thread Ekaterina Tumanova
12 for any backend but DASD). The blkconf_blocksizes call was added to all users of BlkConf. Signed-off-by: Ekaterina Tumanova --- hw/block/block.c | 15 +++ hw/block/hd-geometry.c| 10 +- hw/block/nvme.c | 1 + hw/block/virtio-blk.c | 1 + hw

[Qemu-devel] [PATCH v4 3/5] block: Add driver methods to probe blocksizes and geometry

2014-12-16 Thread Ekaterina Tumanova
at a local check_for_dasd function was introduced. It calls BIODASDINFO2 ioctl and returns its rc. Blocksizes detection function will probe sizes for DASD devices and set default for other devices. Signed-off-by: Ekaterina Tumanova --- block/raw-posix.c | 97 +

[Qemu-devel] [PATCH v4 4/5] block-backend: Add wrappers for blocksizes and geometry probing

2014-12-16 Thread Ekaterina Tumanova
Signed-off-by: Ekaterina Tumanova --- block/block-backend.c | 10 ++ include/sysemu/block-backend.h | 2 ++ 2 files changed, 12 insertions(+) diff --git a/block/block-backend.c b/block/block-backend.c index ef16d73..4b9ed85 100644 --- a/block/block-backend.c +++ b/block/block

[Qemu-devel] [PATCH v4 1/5] block: add bdrv functions for geometry and blocksize

2014-12-16 Thread Ekaterina Tumanova
Add driver functions for geometry and blocksize detection Signed-off-by: Ekaterina Tumanova Reviewed-by: Thomas Huth --- block.c | 34 ++ include/block/block.h | 13 + include/block/block_int.h | 15 +++ 3 files

[Qemu-devel] [PATCH v4 0/5] Geometry and blocksize detection for backing devices.

2014-12-16 Thread Ekaterina Tumanova
y blk_probe_backend. In order to allow this logic, blocksize properties were initialized with 0. (driver will return 512 if backing device probing didn't succeed or if driver method is not defined). 2. hd_geometry guess was changed to firstly try to retrieve values via blk_probe_geometry and if

[Qemu-devel] [PATCH v4 2/5] raw-posix: Factor block size detection out of raw_probe_alignment()

2014-12-16 Thread Ekaterina Tumanova
Put it in new probe_logical_blocksize(). Signed-off-by: Ekaterina Tumanova --- block/raw-posix.c | 41 - 1 file changed, 24 insertions(+), 17 deletions(-) diff --git a/block/raw-posix.c b/block/raw-posix.c index e51293a..38172ca 100644 --- a/block/raw

Re: [Qemu-devel] [PATCH v3 5/5] BlockConf: Call backend functions to detect geometry and blocksizes

2014-12-15 Thread Ekaterina Tumanova
On 12/15/2014 04:50 PM, Markus Armbruster wrote: Ekaterina Tumanova writes: geometry: hd_geometry_guess function autodetects the drive geometry. This patch adds a block backend call, that probes the backing device geometry. If the inner driver method is implemented and succeeds (currently

Re: [Qemu-devel] [PATCH v3 3/5] block: Add driver methods to probe blocksizes and geometry

2014-12-15 Thread Ekaterina Tumanova
On 12/15/2014 04:29 PM, Markus Armbruster wrote: Ekaterina Tumanova writes: This patch introduces driver methods of defining disk blocksizes (physical and logical) and hard drive geometry. The method is only implemented for "host_device". For "raw" devices driver calls

Re: [Qemu-devel] [PATCH v3 0/5] Geometry and blocksize detection for backing devices.

2014-12-12 Thread Ekaterina Tumanova
On 12/05/2014 08:56 PM, Ekaterina Tumanova wrote: This 3rd revision of the patch set. Proper geometry and blocksize information is vital for support of DASD/ECKD drives in Linux guests. Otherwise things will fail in certain cases. The existing geometry and blocksize qemu defaults have no sense

Re: [Qemu-devel] [PATCH v3 3/5] block: Add driver methods to probe blocksizes and geometry

2014-12-11 Thread Ekaterina Tumanova
On 12/10/2014 04:14 PM, Thomas Huth wrote: On Fri, 5 Dec 2014 18:56:19 +0100 Ekaterina Tumanova wrote: This patch introduces driver methods of defining disk blocksizes (physical and logical) and hard drive geometry. The method is only implemented for "host_device". For "raw&

[Qemu-devel] [PATCH v3 2/5] raw-posix: Factor block size detection out of raw_probe_alignment()

2014-12-05 Thread Ekaterina Tumanova
Put it in new probe_logical_blocksize(). Signed-off-by: Ekaterina Tumanova --- block/raw-posix.c | 44 +++- 1 file changed, 27 insertions(+), 17 deletions(-) diff --git a/block/raw-posix.c b/block/raw-posix.c index b1af77e..633d5bc 100644 --- a/block/raw

[Qemu-devel] [PATCH v3 4/5] block-backend: Add wrappers for blocksizes and geometry probing

2014-12-05 Thread Ekaterina Tumanova
Signed-off-by: Ekaterina Tumanova --- block/block-backend.c | 10 ++ include/sysemu/block-backend.h | 2 ++ 2 files changed, 12 insertions(+) diff --git a/block/block-backend.c b/block/block-backend.c index d0692b1..9cd97c6 100644 --- a/block/block-backend.c +++ b/block/block

[Qemu-devel] [PATCH v3 1/5] block: add bdrv functions for geometry and blocksize

2014-12-05 Thread Ekaterina Tumanova
Add driver functions for geometry and blocksize detection Signed-off-by: Ekaterina Tumanova --- block.c | 35 +++ include/block/block.h | 13 + include/block/block_int.h | 5 + 3 files changed, 53 insertions(+) diff --git a

[Qemu-devel] [PATCH v3 3/5] block: Add driver methods to probe blocksizes and geometry

2014-12-05 Thread Ekaterina Tumanova
DASD devices. In order to check that a local check_for_dasd function was introduced, which calls BIODASDINFO2 ioctl and returns its rc. Blocksizes detection fuction will probe sizes for DASD devices and set default for other devices. Signed-off-by: Ekaterina Tumanova --

[Qemu-devel] [PATCH v3 0/5] Geometry and blocksize detection for backing devices.

2014-12-05 Thread Ekaterina Tumanova
do that: remove hardcoding 512 in DEFINE_BLOCK_PROPERTIES. set defaults in blk_probe_blocksizes (now always succeeds) and call it only if property is 0. - fix cylinders calculation. - document blk_probe_geometry call as "currently only for DASD". - anything I forgot :) Ekaterina Tuman

[Qemu-devel] [PATCH v3 5/5] BlockConf: Call backend functions to detect geometry and blocksizes

2014-12-05 Thread Ekaterina Tumanova
12 for any backend but DASD). The blkconf_blocksizes call was added to all users of BlkConf. Signed-off-by: Ekaterina Tumanova --- hw/block/block.c | 18 ++ hw/block/hd-geometry.c| 12 hw/block/nvme.c | 1 + hw/block/virtio-blk.c | 1 + hw

Re: [Qemu-devel] [PATCH v2 2/6] geometry: Detect blocksize via ioctls in separate static functions

2014-11-28 Thread Ekaterina Tumanova
On 11/28/2014 03:52 PM, Markus Armbruster wrote: Ekaterina Tumanova writes: Suggest function comment /** * Return logical block size, or zero if we can't figure it out */ { -BDRVRawState *s = bs->opaque; -char *buf; -unsigned int sec

Re: [Qemu-devel] [PATCH v2 0/6] Geometry and blocksize support for backing devices

2014-11-28 Thread Ekaterina Tumanova
On 11/28/2014 01:35 PM, Stefan Hajnoczi wrote: On Wed, Nov 26, 2014 at 01:16:48PM +0300, Ekaterina Tumanova wrote: On 11/25/2014 04:01 PM, Stefan Hajnoczi wrote: On Wed, Nov 19, 2014 at 11:17:50AM +0100, Ekaterina Tumanova wrote: 3. Why does s390 need to customize hd_geometry_guess()? Since

Re: [Qemu-devel] [PATCH v2 2/6] geometry: Detect blocksize via ioctls in separate static functions

2014-11-28 Thread Ekaterina Tumanova
Suggest function comment /** * Return logical block size, or zero if we can't figure it out */ { -BDRVRawState *s = bs->opaque; -char *buf; -unsigned int sector_size; - -/* For /dev/sg devices the alignment is not really used. - With buffered I/O, we

Re: [Qemu-devel] [PATCH v2 5/6] geometry: Call backend function to detect geometry and blocksize

2014-11-28 Thread Ekaterina Tumanova
On 11/28/2014 01:10 PM, Markus Armbruster wrote: Ekaterina Tumanova writes: hd_geometry_guess function autodetects the drive geometry. This patch adds a block backend call, that probes the backing device geometry. If the inner driver method is implemented and succeeds (currently only DASDs

Re: [Qemu-devel] [PATCH v2 1/6] geometry: add bdrv functions for geometry and blocksize

2014-11-27 Thread Ekaterina Tumanova
On 11/27/2014 05:55 PM, Markus Armbruster wrote: I'm sorry for the delay. I got the flu and have difficulties thinking straight for longer than a few minutes. Ekaterina Tumanova writes: Add driver functions for geometry and blocksize detection Signed-off-by: Ekaterina Tum

Re: [Qemu-devel] [PATCH v2 0/6] Geometry and blocksize support for backing devices

2014-11-26 Thread Ekaterina Tumanova
On 11/25/2014 04:01 PM, Stefan Hajnoczi wrote: On Wed, Nov 19, 2014 at 11:17:50AM +0100, Ekaterina Tumanova wrote: Hi folks, I'm sorry for the recent spam. I messed up during code submission last time. So please ignore any previous notes you received from me and answer only to this t

Re: [Qemu-devel] [PATCH] geometry: fix i386 compilation

2014-11-21 Thread Ekaterina Tumanova
On 11/20/2014 07:18 PM, Kevin Wolf wrote: Am 19.11.2014 um 16:04 hat Cornelia Huck geschrieben: On Wed, 19 Nov 2014 14:40:07 + Peter Maydell wrote: On 19 November 2014 14:01, Ekaterina Tumanova wrote: Signed-off-by: Ekaterina Tumanova Could you give the compiler error/warning

[Qemu-devel] [PATCH] geometry: fix i386 compilation

2014-11-19 Thread Ekaterina Tumanova
Signed-off-by: Ekaterina Tumanova --- hw/block/hd-geometry.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/hw/block/hd-geometry.c b/hw/block/hd-geometry.c index b462225..905d2c6 100644 --- a/hw/block/hd-geometry.c +++ b/hw/block/hd-geometry.c @@ -147,7 +147,8 @@ void

[Qemu-devel] [PATCH v2 6/6] geometry: Target specific hook for s390x in geometry guessing

2014-11-19 Thread Ekaterina Tumanova
simply set in to NONE. Signed-off-by: Ekaterina Tumanova --- hw/block/Makefile.objs | 6 +- hw/block/hd-geometry.c | 36 +++- 2 files changed, 36 insertions(+), 6 deletions(-) diff --git a/hw/block/Makefile.objs b/hw/block/Makefile.objs index d4c3ab7..1f7da7a

[Qemu-devel] [PATCH v2 3/6] geometry: Add driver methods to probe blocksizes and geometry

2014-11-19 Thread Ekaterina Tumanova
der to check that a local CheckForDASD function was introduced, which calls BIODASDINFO2 ioctl and returns 0 only if it succeeds. Signed-off-by: Ekaterina Tumanova --- block/raw-posix.c | 65 +++ block/raw_bsd.c | 12 ++ 2 files changed, 77 in

[Qemu-devel] [PATCH v2 1/6] geometry: add bdrv functions for geometry and blocksize

2014-11-19 Thread Ekaterina Tumanova
Add driver functions for geometry and blocksize detection Signed-off-by: Ekaterina Tumanova --- block.c | 26 ++ include/block/block.h | 20 include/block/block_int.h | 3 +++ 3 files changed, 49 insertions(+) diff --git a

[Qemu-devel] [PATCH v2 5/6] geometry: Call backend function to detect geometry and blocksize

2014-11-19 Thread Ekaterina Tumanova
-by: Ekaterina Tumanova --- hw/block/block.c | 11 +++ hw/block/hd-geometry.c | 9 + hw/block/virtio-blk.c| 1 + include/hw/block/block.h | 1 + 4 files changed, 22 insertions(+) diff --git a/hw/block/block.c b/hw/block/block.c index a625773..f1d29bc 100644 --- a/hw

[Qemu-devel] [PATCH v2 2/6] geometry: Detect blocksize via ioctls in separate static functions

2014-11-19 Thread Ekaterina Tumanova
Move the IOCTL calls that detect logical blocksize from raw_probe_alignment into separate function (probe_logical_blocksize). Introduce function which detect physical blocksize via IOCTL (probe_physical_blocksize). Both functions will be used in the next patch. Signed-off-by: Ekaterina Tumanova

[Qemu-devel] [PATCH v2 4/6] geometry: Add block-backend wrappers for geometry probing

2014-11-19 Thread Ekaterina Tumanova
Signed-off-by: Ekaterina Tumanova --- block/block-backend.c | 10 ++ include/sysemu/block-backend.h | 2 ++ 2 files changed, 12 insertions(+) diff --git a/block/block-backend.c b/block/block-backend.c index d0692b1..6717301 100644 --- a/block/block-backend.c +++ b/block/block

[Qemu-devel] [PATCH v2 0/6] Geometry and blocksize support for backing devices

2014-11-19 Thread Ekaterina Tumanova
ng storage is a DASD by means of BIODASDINFO2 ioctl. Original patchset can be found here: http://lists.gnu.org/archive/html/qemu-devel/2014-07/msg03791.html Ekaterina Tumanova (6): geometry: add bdrv functions for geometry and blocksize geometry: Detect blocksize via ioctls in separate s

[Qemu-devel] Fwd: [PATCH v2 0/6] Geometry and blocksize support for backing devices

2014-11-18 Thread Ekaterina Tumanova
copying to mail list Forwarded Message Subject: [PATCH v2 0/6] Geometry and blocksize support for backing devices Date: Tue, 18 Nov 2014 17:09:55 +0100 From: Ekaterina Tumanova To: arm...@redhat.com, pbonz...@redhat.com, stefa...@redhat.com, kw...@redhat.com CC: borntrae

[Qemu-devel] Fwd: [PATCH v2 4/6] geometry: Add block-backend wrappers for geometry probing

2014-11-18 Thread Ekaterina Tumanova
copying to mail list Forwarded Message Subject: [PATCH v2 4/6] geometry: Add block-backend wrappers for geometry probing Date: Tue, 18 Nov 2014 17:09:59 +0100 From: Ekaterina Tumanova To: arm...@redhat.com, pbonz...@redhat.com, stefa...@redhat.com, kw...@redhat.com CC

[Qemu-devel] Fwd: [PATCH v2 6/6] geometry: Target specific hook for s390x in geometry guessing

2014-11-18 Thread Ekaterina Tumanova
copying to mail list Forwarded Message Subject: [PATCH v2 6/6] geometry: Target specific hook for s390x in geometry guessing Date: Tue, 18 Nov 2014 17:10:01 +0100 From: Ekaterina Tumanova To: arm...@redhat.com, pbonz...@redhat.com, stefa...@redhat.com, kw...@redhat.com CC

[Qemu-devel] Fwd: [PATCH v2 5/6] geometry: Call backend function to detect geometry and blocksize

2014-11-18 Thread Ekaterina Tumanova
copying to mail list Forwarded Message Subject: [PATCH v2 5/6] geometry: Call backend function to detect geometry and blocksize Date: Tue, 18 Nov 2014 17:10:00 +0100 From: Ekaterina Tumanova To: arm...@redhat.com, pbonz...@redhat.com, stefa...@redhat.com, kw...@redhat.com

[Qemu-devel] Fwd: [PATCH v2 3/6] geometry: Add driver methods to probe blocksizes and geometry

2014-11-18 Thread Ekaterina Tumanova
copying to mail list Forwarded Message Subject: [PATCH v2 3/6] geometry: Add driver methods to probe blocksizes and geometry Date: Tue, 18 Nov 2014 17:09:58 +0100 From: Ekaterina Tumanova To: arm...@redhat.com, pbonz...@redhat.com, stefa...@redhat.com, kw...@redhat.com CC

[Qemu-devel] Fwd: [PATCH v2 2/6] geometry: Detect blocksize via ioctls in separate static functions

2014-11-18 Thread Ekaterina Tumanova
copying to mail list Forwarded Message Subject: [PATCH v2 2/6] geometry: Detect blocksize via ioctls in separate static functions Date: Tue, 18 Nov 2014 17:09:57 +0100 From: Ekaterina Tumanova To: arm...@redhat.com, pbonz...@redhat.com, stefa...@redhat.com, kw

[Qemu-devel] Fwd: [PATCH v2 1/6] geometry: add bdrv functions for geometry and blocksize

2014-11-18 Thread Ekaterina Tumanova
copying to mail list Forwarded Message Subject: [PATCH v2 1/6] geometry: add bdrv functions for geometry and blocksize Date: Tue, 18 Nov 2014 17:09:56 +0100 From: Ekaterina Tumanova To: arm...@redhat.com, pbonz...@redhat.com, stefa...@redhat.com, kw...@redhat.com CC

Re: [Qemu-devel] Geometry and blocksize support for backing devices

2014-11-07 Thread Ekaterina Tumanova
On 11/07/2014 12:17 PM, Markus Armbruster wrote: Christian Borntraeger writes: Markus, Kevin, Stefan, here is a (somewhat late) followup of some KVM forum discussions regarding block size and geometry of pass-through block devices. Let's just do a quick wrap-up (as of my understanding) and a

Re: [Qemu-devel] [PATCH 4/4] blocksize: add blkconf_blocksize call to all block devices

2014-09-04 Thread Ekaterina Tumanova
On 09/03/2014 07:46 PM, Stefan Hajnoczi wrote: On Tue, Jul 29, 2014 at 02:27:19PM +0200, Ekaterina Tumanova wrote: This patch add the blkconf_blocksize call to all devices, which use DEFINE_BLOCK_PROPERTIES. If the underlying driver function fails, blkconf_blocksizes will set blocksizes to

[Qemu-devel] [PATCH 4/4] blocksize: add blkconf_blocksize call to all block devices

2014-07-29 Thread Ekaterina Tumanova
This patch add the blkconf_blocksize call to all devices, which use DEFINE_BLOCK_PROPERTIES. If the underlying driver function fails, blkconf_blocksizes will set blocksizes to default (512) value. Signed-off-by: Ekaterina Tumanova Reviewed-by: David Hildenbrand Acked-by: Cornelia Huck --- hw

[Qemu-devel] [PATCH 1/4] hd-geometry.c: Integrate HDIO_GETGEO in guessing for target-s390x

2014-07-29 Thread Ekaterina Tumanova
-l in the guest. Based on 2013 patch from Einar Lueck Signed-off-by: Ekaterina Tumanova Reviewed-by: David Hildenbrand Acked-by: Cornelia Huck --- hw/block/Makefile.objs | 6 +- hw/block/hd-geometry.c | 56 ++ 2 files changed, 61 insertions

[Qemu-devel] [PATCH 2/4] blocksize: support auto-sensing of blocksizes

2014-07-29 Thread Ekaterina Tumanova
driver. If this does not work 512 is used, so the default excecution logic is not changed. Based on 2013 patch from Einar Lueck Signed-off-by: Ekaterina Tumanova Reviewed-by: David Hildenbrand Acked-by: Cornelia Huck --- block.c | 12 hw/block/block.c

[Qemu-devel] [PATCH 0/4] Geometry and blocksize support for backing devices

2014-07-29 Thread Ekaterina Tumanova
for "raw" and "host_device" drivers. (also requested by the reviewers of the original patch) Ekaterina Tumanova (4): hd-geometry.c: Integrate HDIO_GETGEO in guessing for target-s390x blocksize: support auto-sensing of blocksizes blocksize: Add driver method to get the bl

[Qemu-devel] [PATCH 3/4] blocksize: Add driver method to get the blocksizes

2014-07-29 Thread Ekaterina Tumanova
raw_probe_alignment (now moved into separate function probe_logical_blocksize). For detecting the physical blocksize it uses BLKPBSZGET ioctl. For "raw" devices driver calls the child's method. Signed-off-by: Ekaterina Tumanova Reviewed-by: David Hildenbrand Acked-by: Corneli

[Qemu-devel] [PATCH v3 1/1] Define the architecture for compressed dump format.

2014-01-31 Thread Ekaterina Tumanova
Signed-off-by: Ekaterina Tumanova --- dump.c | 7 +-- target-i386/cpu.h | 2 ++ target-s390x/cpu.h | 1 + 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/dump.c b/dump.c index 8f64aab..8d85255 100644 --- a/dump.c +++ b/dump.c @@ -32,6 +32,9 @@ #ifdef

[Qemu-devel] [PATCH v3 0/1] Detect arch for dump compressed header.

2014-01-31 Thread Ekaterina Tumanova
True! Fixed. Tested. Can you please put it into push-queue? Thanks, Kate. Ekaterina Tumanova (1): Define the architecture for compressed dump format. dump.c | 7 +-- target-i386/cpu.h | 2 ++ target-s390x/cpu.h | 1 + 3 files changed, 8 insertions(+), 2 deletions

[Qemu-devel] [PATCH v2] Define guest architecture for the compressed dump header.

2014-01-31 Thread Ekaterina Tumanova
You're right about the warning. I removed it. I also added the cast for the destination argument, which caused a warning as well. I tested on s390 and i386 laptop. If you ok with the patch, can you push it on top of this series? Thank you, Regards, Kate. Ekaterina Tumanova (1): Defin

[Qemu-devel] [PATCH v2] Define the architecture for compressed dump format.

2014-01-31 Thread Ekaterina Tumanova
Signed-off-by: Ekaterina Tumanova --- dump.c | 7 +-- target-i386/cpu.h | 2 ++ target-s390x/cpu.h | 1 + 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/dump.c b/dump.c index 8f64aab..25503bc 100644 --- a/dump.c +++ b/dump.c @@ -32,6 +32,9 @@ #ifdef

Re: [Qemu-devel] [PATCH v8 08/13] dump: add API to write dump header

2014-01-30 Thread Ekaterina Tumanova
On 01/28/2014 10:22 AM, qiaonuohan wrote: the functions are used to write header of kdump-compressed format to vmcore. Header of kdump-compressed format includes: 1. common header: DiskDumpHeader32 / DiskDumpHeader64 2. sub header: KdumpSubHeader32 / KdumpSubHeader64 3. extra information: only el

[Qemu-devel] [PATCH] Define the architecture for compressed dump format.

2014-01-30 Thread Ekaterina Tumanova
If you apply this patch on top of your changes, your patches will work on s390x as well. --- dump.c | 8 ++-- target-i386/cpu.h | 2 ++ target-s390x/cpu.h | 1 + 3 files changed, 9 insertions(+), 2 deletions(-) diff --git a/dump.c b/dump.c index 8f64aab..12ad114 100644 --- a/dum

Re: [Qemu-devel] [PATCH v8 08/13] dump: add API to write dump header

2014-01-28 Thread Ekaterina Tumanova
On 01/28/2014 05:37 PM, Laszlo Ersek wrote: Hello Ekaterina, On 01/28/14 12:51, Ekaterina Tumanova wrote: On 01/28/2014 10:22 AM, qiaonuohan wrote: the functions are used to write header of kdump-compressed format to vmcore. Header of kdump-compressed format includes: 1. common header

Re: [Qemu-devel] [PATCH v8 08/13] dump: add API to write dump header

2014-01-28 Thread Ekaterina Tumanova
On 01/28/2014 10:22 AM, qiaonuohan wrote: the functions are used to write header of kdump-compressed format to vmcore. Header of kdump-compressed format includes: 1. common header: DiskDumpHeader32 / DiskDumpHeader64 2. sub header: KdumpSubHeader32 / KdumpSubHeader64 3. extra information: only el

Re: [Qemu-devel] [PATCH 12/13 v7] dump: make kdump-compressed format available for 'dump-guest-memory'

2014-01-23 Thread Ekaterina Tumanova
On 01/17/2014 11:46 AM, qiaonuohan wrote: Make monitor command 'dump-guest-memory' be able to dump in kdump-compressed format. The command's usage: dump [-p] protocol [begin] [length] [format] 'format' is used to specified the format of vmcore and can be: 1. 'elf': ELF format, without compre

Re: [Qemu-devel] [PATCH 08/13 v7] dump: add API to write dump header

2014-01-23 Thread Ekaterina Tumanova
On 01/17/2014 11:46 AM, qiaonuohan wrote: the functions are used to write header of kdump-compressed format to vmcore. Header of kdump-compressed format includes: 1. common header: DiskDumpHeader32 / DiskDumpHeader64 2. sub header: KdumpSubHeader32 / KdumpSubHeader64 3. extra information: only el

Re: [Qemu-devel] [PATCH 2/2] s390: dump guest memory implementation

2013-04-30 Thread Ekaterina Tumanova
On 04/30/2013 02:02 PM, Alexander Graf wrote: On 29.04.2013, at 13:39, Ekaterina Tumanova wrote: On 04/26/2013 09:12 PM, Alexander Graf wrote: On 23.04.2013, at 17:30, Jens Freimann wrote: Implement dump-guest-memory support for target s390x. dump-guest-memory QEMU monitor command didn&#

Re: [Qemu-devel] [PATCH 2/2] s390: dump guest memory implementation

2013-04-29 Thread Ekaterina Tumanova
dable dump. In order to implement this, the arch-specific part of dump-guest-memory was added: target-s390x/arch_dump.c contains the whole set of function for writing Elf note sections of all types for s390x. Signed-off-by: Ekaterina Tumanova Signed-off-by: Jens Freimann --- conf

Re: [Qemu-devel] [PATCH 1/2] Split out dump-guest-memory memory mapping code

2013-04-24 Thread Ekaterina Tumanova
-p is specified on a target that doesn't support it, we will pass an error to the calling code. Signed-off-by: Ekaterina Tumanova Signed-off-by: Jens Freimann --- +++ b/include/qapi/qmp/qerror.h @@ -249,4 +249,7 @@ void assert_no_error(Error *err); #define QERR_SOCKET_CREATE_F