Hello Zhao!
On Mon, 24 Jun 2024 13:12, Zhao Liu wrote:
Hi Manos,
Thanks for your patch. I have a few comments below:
diff --git a/meson.build b/meson.build
index 3533889852..2b305e745a 100644
--- a/meson.build
+++ b/meson.build
@@ -3876,6 +3876,62 @@ foreach target : target_dirs
On Thu, 20 Jun 2024 17:01, Richard Henderson
wrote:
On 6/19/24 13:13, Manos Pitsidianakis wrote:
+# FIXME: These are the latest stable versions, refine to actual minimum ones.
+msrv = {
+ 'rustc': '1.79.0',
+ 'cargo': '1.79.0',
+ 'bindgen': '0.69.4',
+}
A note for other rust newbies
On Thu, 20 Jun 2024 15:32, Alex Bennée wrote:
Manos Pitsidianakis writes:
Add mechanism to generate rust hw targets that depend on a custom
bindgen target for rust bindings to C.
This way bindings will be created before the rust crate is compiled.
The bindings will end up in BUILDDIR
On Thu, 20 Jun 2024 15:34, Paolo Bonzini wrote:
On Thu, Jun 20, 2024 at 1:10 PM Alex Bennée wrote:
> +# FIXME: These are the latest stable versions, refine to actual minimum ones.
> +msrv = {
> + 'rustc': '1.79.0',
> + 'cargo': '1.79.0',
> + 'bindgen': '0.69.4',
> +}
So for Debian
On Thu, 20 Jun 2024 16:41, Alex Bennée wrote:
+summary_info += {'Rust support': with_rust}
+if with_rust and get_option('with_rust_target_triple') != ''
+ summary_info += {'Rust target': get_option('with_rust_target_triple')}
+endif
I wonder if we should display the auto-probed
On Thu, 20 Jun 2024 16:21, Paolo Bonzini wrote:
On 6/19/24 22:13, Manos Pitsidianakis wrote:
Add options for Rust in meson_options.txt, meson.build, configure to
prepare for adding Rust code in the followup commits.
`rust` is a reserved meson name, so we have to use an alternative.
`with_rust
`info qom-tree` in the monitor and look for an
`x-pl011-rust` device.
Signed-off-by: Manos Pitsidianakis
---
MAINTAINERS| 7 +
meson.build| 4 +
rust/.cargo/config.toml| 2 +
rust/meson.build | 2 +
rust/pl011/.gitignore
. This
way meson sets up the dependency tree properly.
5. After compiling each rust crate with the cargo_wrapper.py script,
its static library artifact is linked as a `whole-archive` with the
final binary.
Signed-off-by: Manos Pitsidianakis
---
MAINTAINERS | 3 +
meson.build
Lureau from 2021.
https://patchew.org/QEMU/20210907121943.3498701-1-marcandre.lur...@redhat.com/
Signed-off-by: Marc-André Lureau
Signed-off-by: Manos Pitsidianakis
---
MAINTAINERS | 5 +
configure | 11 ++
meson.build | 11
Deploy the generated rustdocs for my personal rust qemu fork on gitlab.
The URL is:
https://rust-for-qemu-epilys-aebb06ca9f9adfe6584811c14ae44156501d935ba4.gitlab.io/pl011/index.html
Signed-off-by: Manos Pitsidianakis
---
.gitlab-ci.d/buildtest.yml | 64
Convenience patch for testing the rust device.
Signed-off-by: Manos Pitsidianakis
---
hw/arm/virt.c | 4
1 file changed, 4 insertions(+)
diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index 3c93c0c0a6..f33b58ae0d 100644
--- a/hw/arm/virt.c
+++ b/hw/arm/virt.c
@@ -912,7 +912,11 @@ static void
es can be found online at
https://gitlab.com/epilys/rust-for-qemu/-/tags
Tag/refs:
- rust-pl011-rfc-v3
- rust-pl011-rfc-v2
- rust-pl011-rfc-v1
Manos Pitsidianakis (5):
build-sys: Add rust feature option
rust: add bindgen step as a meson dependency
rust: add PL011 device model
DO NOT MERG
On Wed, 19 Jun 2024 06:31, Richard Henderson
wrote:
On 6/11/24 03:33, Manos Pitsidianakis wrote:
If `cargo` and `bindgen` is installed in your system, you should be able
to build qemu-system-aarch64 with configure flag --enable-rust and
launch an arm virt VM. One of the patches hardcodes
On Wed, 19 Jun 2024 19:52, Richard Henderson
wrote:
On 6/11/24 03:33, Manos Pitsidianakis wrote:
+++ b/scripts/cargo_wrapper.py
@@ -0,0 +1,211 @@
+#!/usr/bin/env python3
+# Copyright (c) 2020 Red Hat, Inc.
+# Copyright (c) 2023 Linaro Ltd.
+#
+# Authors:
+# Manos Pitsidianakis
+# Marc-André
n this
central place there without any risk to change the behavior of other
code.
Fixes: 9f6bcfd99f ("hw/virtio: move vm_running check to virtio_device_started")
Buglink: https://issues.redhat.com/browse/RHEL-40708
Signed-off-by: Thomas Huth
---
Reviewed-by: Manos Pitsidianakis
On Mon, 17 Jun 2024 17:32, Paolo Bonzini wrote:
On Mon, Jun 17, 2024 at 4:04 PM Manos Pitsidianakis
wrote:
I respectfully disagree and recommend taking another look at the code.
The device actually performs all logic in non-unsafe methods and is
typed instead of operating on raw integers
On Mon, 17 Jun 2024 14:32, Paolo Bonzini wrote:
Il lun 17 giu 2024, 10:59 Manos Pitsidianakis <
manos.pitsidiana...@linaro.org> ha scritto:
>qdev_define_type!(c"test-device", TestDevice);
>impl ObjectImpl for TestDevice {}
>impl DeviceImpl for TestDevice {}
On Fri, 14 Jun 2024 20:50, Paolo Bonzini wrote:
On Fri, Jun 14, 2024 at 9:04 AM Manos Pitsidianakis
wrote:
On Thu, 13 Jun 2024 23:57, Paolo Bonzini wrote:
>On Thu, Jun 13, 2024 at 11:16 AM Daniel P. Berrangé
wrote:
>> I guess there's a balance to be had somewhere on the spectru
On Thu, 13 Jun 2024 23:57, Paolo Bonzini wrote:
On Thu, Jun 13, 2024 at 11:16 AM Daniel P. Berrangé wrote:
I guess there's a balance to be had somewhere on the spectrum between doing
everything against the raw C binding, vs everything against a perfectly
idiomatic Rust API wrapping the C
On Thu, 13 Jun 2024 11:53, "Daniel P. Berrangé" wrote:
On Thu, Jun 13, 2024 at 11:41:38AM +0300, Manos Pitsidianakis wrote:
> > diff --git a/rust/rustfmt.toml b/rust/rustfmt.toml
> > new file mode 100644
> > index 00..ebecb99fe0
> > --- /dev/null
>
On Thu, 13 Jun 2024 10:56, Paolo Bonzini wrote:
Il gio 13 giu 2024, 09:13 Daniel P. Berrangé ha
scritto:
On Wed, Jun 12, 2024 at 11:27:04PM +0200, Paolo Bonzini wrote:
> Il mer 12 giu 2024, 22:58 Manos Pitsidianakis <
> manos.pitsidiana...@linaro.org> ha scritto:
>
> > I
Hello Zhao :)
On Thu, 13 Jun 2024 11:30, Zhao Liu wrote:
On Tue, Jun 11, 2024 at 01:33:32PM +0300, Manos Pitsidianakis wrote:
Date: Tue, 11 Jun 2024 13:33:32 +0300
From: Manos Pitsidianakis
Subject: [RFC PATCH v2 3/5] rust: add PL011 device model
X-Mailer: git-send-email 2.44.0
This commit
C-n and C-p are the default bindings for readline's next-history and
previous-history respectively. They have the same functionality as the
Down and Up arrow keys.
Signed-off-by: Manos Pitsidianakis
---
util/readline.c | 8
1 file changed, 8 insertions(+)
diff --git a/util/readline.c
Some commonly used readline shortcuts are missing from our
implementation. This series adds:
- Control-n next line, same as Down arrow key
- Control-p previous line, same as Up arrow key
- Control-u erase line starting from cursor
Manos Pitsidianakis (3):
util/readline.c:fix lints
Add support for the unix-line-discard readline action, which erases from
the cursor position up to the beginning of the line. The default
binding, C-u, was chosen.
This is useful to quickly erase command input while working on the
monitor interface.
Signed-off-by: Manos Pitsidianakis
---
util
.
Signed-off-by: Manos Pitsidianakis
---
util/readline.c | 15 +++
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/util/readline.c b/util/readline.c
index 494a3d924e..ded31b04b7 100644
--- a/util/readline.c
+++ b/util/readline.c
@@ -405,7 +405,7 @@ void
02 0x1 0x10
write 0x19 0x1 0x04
write 0x1c 0x1 0x01
write 0x100018 0x1 0x04
write 0x10001c 0x1 0x02
write 0x101003 0x1 0x01
write 0xe0007001 0x1 0x00
EOF
Reported-by: Zheyu Ma
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2359
Signed-off-by: Manos Pitsidianakis
---
Range-diff agai
On Wed, 12 Jun 2024 11:56, Alex Bennée wrote:
Manos Pitsidianakis writes:
On Tue, 11 Jun 2024 at 18:01, Philippe Mathieu-Daudé wrote:
On 11/6/24 14:23, Manos Pitsidianakis wrote:
> A fuzzer case discovered by Zheyu Ma causes an assert failure.
>
> Add a check before t
On Wed, 12 Jun 2024 12:46, Alex Bennée wrote:
Manos Pitsidianakis writes:
A fuzzer case discovered by Zheyu Ma causes an assert failure.
Add a check before the assert, and respond with an error before moving
on to the next queue element.
To reproduce the failure:
cat << EOF |
Good morning Daniel,
On Wed, 12 Jun 2024 11:37, "Daniel P. Berrangé" wrote:
On Tue, Jun 11, 2024 at 01:33:29PM +0300, Manos Pitsidianakis wrote:
.gitignore | 2 +
.gitlab-ci.d/buildtest.yml | 64 ++--
MAINTAINERS| 13 +
Good morning Paolo,
On Thu, 13 Jun 2024 00:27, Paolo Bonzini wrote:
Il mer 12 giu 2024, 22:58 Manos Pitsidianakis <
manos.pitsidiana...@linaro.org> ha scritto:
In any case, it is out of scope for this RFC. Introducing wrappers
would be a gradual process.
Sure, how would you feel
On Thu, 13 Jun 2024 06:26, Peng Fan wrote:
Hi All,
The following files are marked as GPL-3.0-or-later. Will these
Conflict with Qemu LICENSE?
Should we update the files to GPL-2.0?
./tests/tcg/aarch64/semicall.h:7: * SPDX-License-Identifier: GPL-3.0-or-later
On Wed, 12 Jun 2024 19:06, "Daniel P. Berrangé" wrote:
On Wed, Jun 12, 2024 at 05:14:56PM +0300, Manos Pitsidianakis wrote:
On Wed, 12 Jun 2024 15:29, Paolo Bonzini wrote:
> I think this is extremely useful to show where we could go in the task
> of creating more id
On Wed, 12 Jun 2024 15:29, Paolo Bonzini wrote:
I think this is extremely useful to show where we could go in the task
of creating more idiomatic bindings.
On Tue, Jun 11, 2024 at 12:34 PM Manos Pitsidianakis
wrote:
+fn main() {
+println!("cargo::rerun-if-env-changed=MESON_BUIL
On Wed, 12 Jun 2024 12:21, Alberto Garcia wrote:
On Wed 12 Jun 2024 09:01:01 AM +03, Manos Pitsidianakis wrote:
Hello Alberto,
Hello Manos!
> This is equivalent to using qemu-img to convert a file to qcow2 and
> then writing the result to stdout, with the difference that this
>
On Mon, 10 Jun 2024 17:47, Alberto Garcia wrote:
This tool converts a disk image to qcow2, writing the result directly
to stdout. This can be used for example to send the generated file
over the network.
This is equivalent to using qemu-img to convert a file to qcow2 and
then writing the
Hello Alberto,
On Mon, 10 Jun 2024 17:47, Alberto Garcia wrote:
This tool converts a disk image to qcow2, writing the result directly
to stdout. This can be used for example to send the generated file
over the network.
This is equivalent to using qemu-img to convert a file to qcow2 and
then
-by: Manos Pitsidianakis
| 11 +++-
hw/ppc/spapr_irq.c | 4 +-
23 files changed, 256 insertions(+), 254 deletions(-)
--
2.41.0
For the series:
Reviewed-by: Manos Pitsidianakis
On Tue, 11 Jun 2024 at 17:05, Stefan Hajnoczi wrote:
>
> On Mon, Jun 10, 2024 at 09:22:36PM +0300, Manos Pitsidianakis wrote:
> > Add options for Rust in meson_options.txt, meson.build, configure to
> > prepare for adding Rust code in the followup commits.
> >
> > `
On Tue, 11 Jun 2024 at 18:01, Philippe Mathieu-Daudé wrote:
>
> On 11/6/24 14:23, Manos Pitsidianakis wrote:
> > A fuzzer case discovered by Zheyu Ma causes an assert failure.
> >
> > Add a check before the assert, and respond with an error before moving
> >
Hello Antonio!
On Tue, 11 Jun 2024 15:45, Antonio Caggiano wrote:
Hi there :)
On 11/06/2024 12:58, Manos Pitsidianakis wrote:
On Tue, 11 Jun 2024 13:57, "Daniel P. Berrangé"
wrote:
On Mon, Jun 10, 2024 at 11:29:36PM +0300, Manos Pitsidianakis wrote:
On Mon, 10 Jun 2024 22:37
02 0x1 0x10
write 0x19 0x1 0x04
write 0x1c 0x1 0x01
write 0x100018 0x1 0x04
write 0x10001c 0x1 0x02
write 0x101003 0x1 0x01
write 0xe0007001 0x1 0x00
EOF
Reported-by: Zheyu Ma
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2359
Signed-off-by: Manos Pitsidianakis
---
hw/virtio/
On Tue, 11 Jun 2024 14:09, "Daniel P. Berrangé" wrote:
On Tue, Jun 11, 2024 at 01:58:10PM +0300, Manos Pitsidianakis wrote:
On Tue, 11 Jun 2024 13:57, "Daniel P. Berrangé" wrote:
> On Mon, Jun 10, 2024 at 11:29:36PM +0300, Manos Pitsidianakis wrote:
> > On Mon
On Tue, 11 Jun 2024 13:57, "Daniel P. Berrangé" wrote:
On Mon, Jun 10, 2024 at 11:29:36PM +0300, Manos Pitsidianakis wrote:
On Mon, 10 Jun 2024 22:37, Pierrick Bouvier wrote:
> Hello Manos,
>
> On 6/10/24 11:22, Manos Pitsidianakis wrote:
> > Hello everyone,
> &
On Tue, 11 Jun 2024 11:18, "Daniel P. Berrangé" wrote:
On Mon, Jun 10, 2024 at 09:22:35PM +0300, Manos Pitsidianakis wrote:
What are the issues with not using the compiler, rustc, directly?
-
[whataretheissueswith] Ba
On Tue, 11 Jun 2024 12:45, Zhao Liu wrote:
On Tue, Jun 11, 2024 at 09:22:44AM +0100, Daniel P. Berrangé wrote:
On Mon, Jun 10, 2024 at 09:22:35PM +0300, Manos Pitsidianakis wrote:
> Hello everyone,
>
> This is an early draft of my work on implementing a very simple device,
>
On Tue, 11 Jun 2024 11:22, "Daniel P. Berrangé" wrote:
On Mon, Jun 10, 2024 at 09:22:35PM +0300, Manos Pitsidianakis wrote:
Hello everyone,
This is an early draft of my work on implementing a very simple device,
in this case the ARM PL011 (which in C code resides in hw/ch
Convenience patch for testing the rust device.
Signed-off-by: Manos Pitsidianakis
---
hw/arm/virt.c | 4
1 file changed, 4 insertions(+)
diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index 3c93c0c0a6..f33b58ae0d 100644
--- a/hw/arm/virt.c
+++ b/hw/arm/virt.c
@@ -912,7 +912,11 @@ static void
. This
way meson sets up the dependency tree properly.
5. After compiling each rust crate with the cargo_wrapper.py script,
its static library artifact is linked as a `whole-archive` with the
final binary.
Signed-off-by: Manos Pitsidianakis
---
MAINTAINERS | 2 +
meson.build
`info qom-tree` in the monitor and look for an
`x-pl011-rust` device.
Signed-off-by: Manos Pitsidianakis
---
MAINTAINERS| 6 +
meson.build| 4 +
rust/meson.build | 2 +
rust/pl011/.cargo/config.toml | 2 +
rust/pl011/.gitignore
Deploy the generated rustdocs for my personal rust qemu fork on gitlab.
The URL is:
https://rust-for-qemu-epilys-aebb06ca9f9adfe6584811c14ae44156501d935ba4.gitlab.io/pl011/index.html
Signed-off-by: Manos Pitsidianakis
---
.gitlab-ci.d/buildtest.yml | 64
e library or we compile it
manually instead of linking it, we will have some junk in it.
--
Manos Pitsidianakis (5):
build-sys: Add rust feature option
rust: add bindgen step as a meson dependency
rust: add PL011 device model
DO NOT MERGE: add rustdoc build for gitlab pages
DO NOT MERGE: re
Lureau from 2021.
https://patchew.org/QEMU/20210907121943.3498701-1-marcandre.lur...@redhat.com/
Signed-off-by: Marc-André Lureau
Signed-off-by: Manos Pitsidianakis
---
.gitignore| 2 +
MAINTAINERS | 5 +
configure | 12
On Tue, 11 Jun 2024 at 09:11, Mark Cave-Ayland
wrote:
>
> On 11/06/2024 06:49, Markus Armbruster wrote:
>
> > Philippe Mathieu-Daudé writes:
> >
> >> Officialise the QMP command, use the existing
> >> hmp_info_human_readable_text() helper.
> >
> > I'm not sure "officialise" is a word :)
> >
> >
On Tue, 11 Jun 2024 00:38, Pierrick Bouvier wrote:
Maybe it could be better if build.rs file was *not* needed for new
devices/folders, and could be abstracted as a detail of the python
wrapper script instead of something that should be committed.
That'd mean you cannot work on the rust files
On Mon, 10 Jun 2024 22:37, Pierrick Bouvier wrote:
Hello Manos,
On 6/10/24 11:22, Manos Pitsidianakis wrote:
Hello everyone,
This is an early draft of my work on implementing a very simple device,
in this case the ARM PL011 (which in C code resides in hw/char/pl011.c
and is used in hw/arm
On Mon, 10 Jun 2024 22:59, Stefan Hajnoczi wrote:
What are the issues with not using the compiler, rustc, directly?
-
[whataretheissueswith] Back to [TOC]
1. Tooling
Mostly writing up the build-sys tooling to do so. Ideally
Signed-off-by: Manos Pitsidianakis
---
hw/arm/virt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index 3c93c0c0a6..153be0f42d 100644
--- a/hw/arm/virt.c
+++ b/hw/arm/virt.c
@@ -912,7 +912,7 @@ static void create_uart(const VirtMachineState
Signed-off-by: Manos Pitsidianakis
---
.gitlab-ci.d/buildtest.yml | 13 +++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml
index 1cd6519506..da882813b8 100644
--- a/.gitlab-ci.d/buildtest.yml
+++ b/.gitlab-ci.d
Signed-off-by: Manos Pitsidianakis
---
.gitlab-ci.d/buildtest.yml | 55 +-
1 file changed, 36 insertions(+), 19 deletions(-)
diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml
index 91c57efded..1cd6519506 100644
--- a/.gitlab-ci.d
will have some junk in it.
--
Manos Pitsidianakis (6):
build-sys: Add rust feature option
rust: add PL011 device model
DO NOT MERGE: add rustdoc build for gitlab pages
DO NOT MERGE: replace TYPE_PL011 with x-pl011-rust in arm virt machine
rust: add bindgen step as a meson dependency
DO NOT MERGE: u
Add options for Rust in meson_options.txt, meson.build, configure to
prepare for adding Rust code in the followup commits.
`rust` is a reserved meson name, so we have to use an alternative.
`with_rust` was chosen.
Signed-off-by: Manos Pitsidianakis
---
The cargo wrapper script hardcodes some
On Tue, 04 Jun 2024 16:49, "Daniel P. Berrangé" wrote:
The qmp_guest_{fstrim, get_fsinfo, get_disks} command impls in
commands-posix.c are surrounded by '#ifdef __linux__' so should
instead live in commands-linux.c
Signed-off-by: Daniel P. Berrangé
---
Reviewed-by: Manos Pit
On Tue, 04 Jun 2024 16:49, "Daniel P. Berrangé" wrote:
The qmp_guest_suspend_{disk,ram,hybrid} command impls in
commands-posix.c are surrounded by '#ifdef __linux__' so should
instead live in commands-linux.c
Signed-off-by: Daniel P. Berrangé
---
Reviewed-by: Manos Pitsidianak
On Tue, 04 Jun 2024 16:49, "Daniel P. Berrangé" wrote:
The qmp_guest_set_vcpus and qmp_guest_get_vcpus command impls in
commands-posix.c are surrounded by '#ifdef __linux__' so should
instead live in commands-linux.c
Signed-off-by: Daniel P. Berrangé
---
Reviewed-by: Manos Pit
On Tue, 04 Jun 2024 16:49, "Daniel P. Berrangé" wrote:
This command has never existed in tree, since it was renamed to
guest-get-memory-block-info before being merged.
Signed-off-by: Daniel P. Berrangé
---
Reviewed-by: Manos Pitsidianakis
qga/commands-posix.c | 2 +-
qga/comman
as currently QEMU will hang
libvirglrenderer fails to exec the render server. As the error isn't
back propagated we make sure we at least test we have a path to an
executable before tweaking the environment.
Signed-off-by: Alex Bennée
Cc: Manos Pitsidianakis
Cc: Dmitry Osipenko
Cc: Akihiko
On Tue, 28 May 2024 13:23, Will Gyda wrote:
Issue #2294: Machine microvm doesn't run under Xen accel for qemu-system-x86_64.
Solution: microvm is now not build if only Xen is available.
Signed-off-by: Will Gyda
I suggest rewording the commit title to something like
"i386: remove microvm
G_I440FX=y
> > > CONFIG_Q35=y
> > > -CONFIG_MICROVM=y
> > > +#CONFIG_MICROVM=n
> > > diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig
> > > index a6ee052f9a..f8ec8ebd7a 100644
> > > --- a/hw/i386/Kconfig
> > > +++ b/hw/i386/Kconfig
> &
Audio frontends
> -M: Gerd Hoffmann
> -S: Odd Fixes
> +S: Orphan
> F: hw/audio/
> F: include/hw/audio/
> F: tests/qtest/ac97-test.c
> @@ -2389,8 +2388,8 @@ F: hw/virtio/virtio-mem-pci.c
> F: include/hw/virtio/virtio-mem.h
>
> virtio-snd
> -M: Gerd Hoffmann
&g
p support for grants. */
+memory_region_init_ram(_grants, NULL, "xen.grants", block_len,
+ _fatal);
+memory_region_add_subregion(sysmem, XEN_GRANT_ADDR_OFF, _grants);
}
void arch_handle_ioreq(XenIOState *state, ioreq_t *req)
--
2.40.1
Reviewed-by: Manos Pitsidianakis
On Thu, 16 May 2024 18:48, "Edgar E. Iglesias" wrote:
From: "Edgar E. Iglesias"
Add a second mapcache for grant mappings. The mapcache for
grants needs to work with XC_PAGE_SIZE granularity since
we can't map larger ranges than what has been granted to us.
Like with foreign mappings
F: include/hw/usb.h
F: include/hw/usb/
USB (serial adapter)
-R: Gerd Hoffmann
M: Samuel Thibault
S: Maintained
F: hw/usb/dev-serial.c
--
2.45.0
Reviewed-by: Manos Pitsidianakis
rtio-gpu.h
@@ -2595,7 +2594,6 @@ F: include/hw/virtio/virtio-blk-common.h
vhost-user-gpu
M: Marc-André Lureau
-R: Gerd Hoffmann
S: Maintained
F: docs/interop/vhost-user-gpu.rst
F: contrib/vhost-user-gpu
--
2.45.0
Reviewed-by: Manos Pitsidianakis
@@ F: qapi/ui.json
F: docs/spice-port-fqdn.txt
Graphics
-M: Gerd Hoffmann
M: Marc-André Lureau
S: Odd Fixes
F: ui/
--
2.45.0
Reviewed-by: Manos Pitsidianakis
On Mon, 20 May 2024 00:27, Dmitry Osipenko
wrote:
From: Antonio Caggiano
Request Venus when initializing VirGL and if venus=true flag is set for
virtio-gpu-gl device.
Signed-off-by: Antonio Caggiano
Signed-off-by: Huang Rui
Signed-off-by: Dmitry Osipenko
---
hw/display/virtio-gpu-gl.c
VirtIOGPU *g);
void virtio_gpu_virgl_reset(VirtIOGPU *g);
int virtio_gpu_virgl_init(VirtIOGPU *g);
void virtio_gpu_virgl_deinit(VirtIOGPU *g);
-int virtio_gpu_virgl_get_num_capsets(VirtIOGPU *g);
+GArray *virtio_gpu_virgl_get_capsets(VirtIOGPU *g);
#endif
--
2.44.0
Reviewed-by: Manos Pitsidianakis
AINERS
> ...
> > @@ -2388,7 +2387,6 @@ F: hw/virtio/virtio-mem-pci.c
> > F: include/hw/virtio/virtio-mem.h
> >
> > virtio-snd
> > -M: Gerd Hoffmann
> > R: Manos Pitsidianakis
> > S: Supported
>
> I think the status should be downgraded to Orp
On Thu, 25 Apr 2024 at 13:24, Michael S. Tsirkin wrote:
>
> On Thu, Apr 25, 2024 at 01:04:31PM +0300, Manos Pitsidianakis wrote:
> > On Thu, 25 Apr 2024 at 10:49, Mark Cave-Ayland
> > wrote:
> > >
> > > On 25/04/2024 07:30, Manos Pitsidianakis wrote:
> &
On Thu, 25 Apr 2024 at 10:49, Mark Cave-Ayland
wrote:
>
> On 25/04/2024 07:30, Manos Pitsidianakis wrote:
>
> > On Wed, 24 Apr 2024 at 13:31, Mark Cave-Ayland
> > wrote:
> >>
> >> On 23/04/2024 12:05, Philippe Mathieu-Daudé wrote:
> >>
&
On Wed, 24 Apr 2024 at 13:31, Mark Cave-Ayland
wrote:
>
> On 23/04/2024 12:05, Philippe Mathieu-Daudé wrote:
>
> > On 23/4/24 11:18, Manos Pitsidianakis wrote:
> >> On Tue, 23 Apr 2024 at 11:47, Manos Pitsidianakis
> >> wrote:
> >>>
> >>>
On Tue, 23 Apr 2024 at 11:47, Manos Pitsidianakis
wrote:
>
> On Tue, 23 Apr 2024 at 00:11, Michael S. Tsirkin wrote:
> >
> > On Mon, Apr 22, 2024 at 11:07:21PM +0200, Philippe Mathieu-Daudé wrote:
> > > On 22/4/24 23:02, Michael S. Tsirkin wrote:
> > > > O
On Tue, 23 Apr 2024 at 00:11, Michael S. Tsirkin wrote:
>
> On Mon, Apr 22, 2024 at 11:07:21PM +0200, Philippe Mathieu-Daudé wrote:
> > On 22/4/24 23:02, Michael S. Tsirkin wrote:
> > > On Mon, Apr 22, 2024 at 04:20:56PM +0200, Philippe Mathieu-Daudé wrote:
> > > > Since VirtIO devices can change
: Philippe Mathieu-Daudé
---
Reviewed-by: Manos Pitsidianakis
Thanks for the explanation on v2 btw. virtio_is_big_endian()'s doc
should probably reflect it's not just about legacy devices (virtio sound
isn't legacy) but about target originating data streams too
On Mon, 22 Apr 2024 16:13, Philippe Mathieu-Daudé wrote:
Since VirtIO devices can change endianness at runtime,
we need to use the device endianness, not the target
one.
Hey Philippe, can you clarify what do you mean by they can change
endianness at runtime?
The target's one is used
Extract audio card removal logic out of the device unrealize callback so
that it can be re-used in follow up commits.
Signed-off-by: Manos Pitsidianakis
---
hw/audio/virtio-snd.c | 20 ++--
1 file changed, 14 insertions(+), 6 deletions(-)
diff --git a/hw/audio/virtio-snd.c b/hw
Extract audio card setup logic out of the device realize callback so
that it can be re-used in follow up commits.
Signed-off-by: Manos Pitsidianakis
---
hw/audio/virtio-snd.c | 72 ---
1 file changed, 41 insertions(+), 31 deletions(-)
diff --git a/hw
ERROR: AddressSanitizer: heap-buffer-overflow [..snip..] in
virtio_snd_handle_rx_xfer().
Closes #2296.
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2296
Reported-by: Zheyu Ma
Suggested-by: Zheyu Ma
Signed-off-by: Manos Pitsidianakis
---
hw/audio/virtio-snd.
Factor out virtio_snd_config value validation in a separate function, in
order to re-use it in follow up commits.
Signed-off-by: Manos Pitsidianakis
---
hw/audio/virtio-snd.c | 47 ++-
1 file changed, 29 insertions(+), 18 deletions(-)
diff --git a/hw
Changing the number of streams via virtio_snd_set_config() did not
re-configure the audio card, leaving it in an invalid state.
Reported in https://gitlab.com/qemu-project/qemu/-/issues/2296
Manos Pitsidianakis (4):
virtio-snd: add virtio_snd_is_config_valid()
virtio-snd: factor card setup
s/Resolved:/Resolves:/
Cc: qemu-triv...@nongnu.org
Signed-off-by: Manos Pitsidianakis
---
docs/devel/submitting-a-patch.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/devel/submitting-a-patch.rst
b/docs/devel/submitting-a-patch.rst
index c641d948f1..83e9092b8c
On Fri, 5 Apr 2024 at 14:07, Michael S. Tsirkin wrote:
>
> On Fri, Apr 05, 2024 at 01:54:46PM +0300, Manos Pitsidianakis wrote:
> > ping
>
> confused at this point.
> Do you mind sending a patchset with everything in the correct order?
> Tag it PATCH repost so peo
ping
On Sun, 24 Mar 2024 12:04, Manos Pitsidianakis
wrote:
This is a logic fix for the error handling in the TX/RX virt queue
handlers. A potential invalid address dereference was reported and fixed
by Zheyu Ma in <20240322110827.568412-1-zheyum...@gmail.com>. This patch
moves the i
-posix.c:372:9
#8 0x57cea3979385 in aio_dispatch_handlers qemu/util/aio-posix.c:414:20
#9 0x57cea3978eb1 in aio_dispatch qemu/util/aio-posix.c:424:5
#10 0x57cea3a1eede in aio_ctx_dispatch qemu/util/async.c:360:5
Signed-off-by: Zheyu Ma
Reviewed-by: Manos Pitsidianakis
---
Changes in v2
rns, so the queue must be empty at any other point of the device's
lifetime.
Signed-off-by: Manos Pitsidianakis
---
include/hw/audio/virtio-snd.h | 16 +++-
hw/audio/virtio-snd.c | 137 +++---
2 files changed, 77 insertions(+), 76 deletions(-)
diff --
ndling for invalid
transfers
From: Zheyu Ma
Date: Fri, 22 Mar 2024 12:08:27 +0100
Message-Id: <20240322110827.568412-1-zheyum...@gmail.com>
Manos Pitsidianakis (1):
virtio-snd: rewrite invalid tx/rx message handling
include/hw/audio/virtio-snd.h | 16 +++-
hw/audio/
think
the invalid queue should be moved to the device struct since it's not
stream specific.
Cc'ing qemu-stable because this bug is present in current versions.
Please make the same changes to virtio_snd_handle_rx_xfer() as well and
send a v2, cc'ing qemu-stable. With those changes you can add:
t; the case of the custom runners we also move the free floating variable
> to the runner template.
>
> Signed-off-by: Alex Bennée
>
> ---
> v2
> - make custom runners follow the legacy options
> ---
Reviewed-by: Manos Pitsidianakis
On Tue, 14 Nov 2023 18:31, Philippe Mathieu-Daudé wrote:
xen_arch_set_memory() is not arch-specific anymore. Being
called once, inline it in xen_set_memory().
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/xen/xen-hvm-common.h | 3 -
hw/xen/xen-hvm-common.c | 104
1 - 100 of 622 matches
Mail list logo
