Re: [Qemu-devel] [PATCH 2/2] qemu-io: Fix if scoping bug

2011-07-11 Thread Stefan Hajnoczi
On Mon, Jul 11, 2011 at 2:18 PM, Kevin Wolf wrote: > Am 11.07.2011 11:47, schrieb Stefan Hajnoczi: >> On Mon, Jul 11, 2011 at 6:25 AM, Devin Nakamura wrote: >>> diff --git a/qemu-io.c b/qemu-io.c >>> index e484f40..85cfe27 100644 >>> --- a/qemu-io.c >>> +++ b/qemu-io.c >>> @@ -449,7 +449,7 @@ sta

Re: [Qemu-devel] [PATCH 2/2] qemu-io: Fix if scoping bug

2011-07-11 Thread Kevin Wolf
Am 11.07.2011 11:47, schrieb Stefan Hajnoczi: > On Mon, Jul 11, 2011 at 6:25 AM, Devin Nakamura wrote: >> diff --git a/qemu-io.c b/qemu-io.c >> index e484f40..85cfe27 100644 >> --- a/qemu-io.c >> +++ b/qemu-io.c >> @@ -449,7 +449,7 @@ static int read_f(int argc, char **argv) >> return 0; >

Re: [Qemu-devel] [PATCH 2/2] qemu-io: Fix if scoping bug

2011-07-11 Thread Stefan Hajnoczi
On Mon, Jul 11, 2011 at 6:25 AM, Devin Nakamura wrote: > diff --git a/qemu-io.c b/qemu-io.c > index e484f40..85cfe27 100644 > --- a/qemu-io.c > +++ b/qemu-io.c > @@ -449,7 +449,7 @@ static int read_f(int argc, char **argv) >         return 0; >     } > > -    if (!pflag) > +    if (!pflag) { >    

[Qemu-devel] [PATCH 2/2] qemu-io: Fix if scoping bug

2011-07-10 Thread Devin Nakamura
Fix a bug caused by lack of braces in if statement Lack of braces means that if(count & 0x1ff) is never reached Conflicts: qemu-io.c Signed-off-by: Devin Nakamura --- qemu-io.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/qemu-io.c b/qemu-io.c index e484f4

Re: [Qemu-devel] [PATCH 2/2] qemu-io: Fix if scoping bug

2011-06-14 Thread Markus Armbruster
Devin Nakamura writes: > Fix a bug caused by lack of braces in if statement You describe the bug's cause. That's good. Please also describe the bug's effect, i.e. what exactly is broken for users. > > Signed-off-by: Devin Nakamura > --- > qemu-io.c |4 ++-- > 1 files changed, 2 insertio

[Qemu-devel] [PATCH 2/2] qemu-io: Fix if scoping bug

2011-06-10 Thread Devin Nakamura
Fix a bug caused by lack of braces in if statement Signed-off-by: Devin Nakamura --- qemu-io.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/qemu-io.c b/qemu-io.c index 53adb76..1c4f684 100644 --- a/qemu-io.c +++ b/qemu-io.c @@ -433,12 +433,12 @@ static int read_f(i