On Mon, 15 Aug 2016 16:03:04 +0200
Christian Borntraeger wrote:
> On 08/15/2016 04:00 PM, David Hildenbrand wrote:
> >
> > I'll wait a bit until sending out another series that fixes two minor style
> > problems.
> >
> > What about > 80 chars per line. Is it okay for
On 08/15/2016 04:00 PM, David Hildenbrand wrote:
>
> I'll wait a bit until sending out another series that fixes two minor style
> problems.
>
> What about > 80 chars per line. Is it okay for these definitions + function
> prototype or a no-go?
As long as we are < 90 I think its better than
I'll wait a bit until sending out another series that fixes two minor style
problems.
What about > 80 chars per line. Is it okay for these definitions + function
prototype or a no-go?
David
On Mon, 08/08 14:27, Eduardo Habkost wrote:
> On Mon, Aug 08, 2016 at 09:45:04AM -0700,
> no-re...@ec2-52-6-146-230.compute-1.amazonaws.com wrote:
> > Hi,
> >
> > Your series seems to have some coding style problems. See output below for
> > more information:
> [...]
>
> Does anybody know who
On Mon, Aug 08, 2016 at 09:45:04AM -0700,
no-re...@ec2-52-6-146-230.compute-1.amazonaws.com wrote:
> Hi,
>
> Your series seems to have some coding style problems. See output below for
> more information:
[...]
Does anybody know who owns this robot?
--
Eduardo
> On Mon, 8 Aug 2016 09:45:04 -0700 (PDT)
> no-re...@patchew.org wrote:
>
> something sensible, e.g. qemu-devel>
>
> > Checking PATCH 4/29: s390x/cpumodel: introduce CPU features...
> > WARNING: line over 80 characters
> > #65: FILE: target-s390x/cpu_features.c:27:
> > +FEAT_INIT("zarch",
On Mon, 8 Aug 2016 09:45:04 -0700 (PDT)
no-re...@patchew.org wrote:
> Checking PATCH 4/29: s390x/cpumodel: introduce CPU features...
> WARNING: line over 80 characters
> #65: FILE: target-s390x/cpu_features.c:27:
> +FEAT_INIT("zarch", S390_FEAT_TYPE_STFL, 1, "z/Architecture architectural
>
Hi,
Your series seems to have some coding style problems. See output below for
more information:
Message-id: 1470670378-53732-1-git-send-email-d...@linux.vnet.ibm.com
Type: series
Subject: [Qemu-devel] [Patch v2 00/29] s390x CPU models: exposing features
=== TEST SCRIPT BEGIN ===
#!/bin/bash
After another very helpful discussion with Eduardo and Jiri and the lates
review, these were the major changes:
- QOM interfaces: Only documentation changes
- Minor s390x specific implementation fixups
- Renamed some s390x features, sthyi added to the default + max models
Full list of changes can