Re: [Qemu-devel] virtio block device and sysfs

2010-06-30 Thread Markus Armbruster
Ryan Harper writes: > We've got a sysfs 'serial' attribute for virtio-blk devices upstream[1]. > I've got udev support for using this attribute to create disk/by-id (and > a fix for by-path) symlinks[2]. All that remains is to > re-spin/post the qemu virtio-blk serial patches[3] and get that in

[Qemu-devel] how to add one pcie device to qemu

2010-06-30 Thread Lisa Lei
Hi, I'm finding the solution of how to add one pcie device which emulated by systemc to qemu, such as net card. I noticed that you've been working on Q35 support for qemu, and the status of pcie port emulator is working on April, can it be used now? thanks.

Re: [Qemu-devel] VxWorks kernel for qemu emulating PowerPC?

2010-06-30 Thread hadi motamedi
> It is possible to boot a VxWorks image using the x86 system emulation. > You would have to create a floppy image and pass that in for your Thank you for your reply. Finally, I found a VxWorks kernel coming from one PowerQUICC embedded platform. Can you please let me know how can I make use of it

Re: [Qemu-devel] [PATCH] AppleSMC device emulation

2010-06-30 Thread Alexander Graf
On 29.06.2010, at 20:38, Blue Swirl wrote: > On Tue, Jun 29, 2010 at 2:35 PM, Alexander Graf wrote: >> Intel Macs have a chip called the "AppleSMC" which they use to control >> certain Apple specific parts of the hardware, like the keyboard background >> light. >> >> That chip is also used to s

[Qemu-devel] Re: Status update

2010-06-30 Thread Stefan Hajnoczi
On Tue, Jun 29, 2010 at 6:25 PM, Eduard - Gabriel Munteanu wrote: > On the other hand, we could just leave it alone for now. Changing > mappings during DMA is stupid anyway: I don't think the guest can > recover the results of DMA safely, even though it might be used on > transfers in progress you

[Qemu-devel] [PATCH] AppleSMC device emulation

2010-06-30 Thread Alexander Graf
Intel Macs have a chip called the "AppleSMC" which they use to control certain Apple specific parts of the hardware, like the keyboard background light. That chip is also used to store a key that Mac OS X uses to decrypt binaries. This patch adds emulation for that chip, so we're getting one step

[Qemu-devel] [Bug 599617] Re: qemu fail to parse command "-net none"

2010-06-30 Thread Thierry Carrez
** Changed in: qemu-kvm (Ubuntu) Importance: Undecided => Medium ** Changed in: qemu-kvm (Ubuntu) Status: New => Triaged -- qemu fail to parse command "-net none" https://bugs.launchpad.net/bugs/599617 You received this bug notification because you are a member of qemu- devel-ml, which

[Qemu-devel] Re: [PATCH 4/4] require #define NEED_GLOBAL_ENV for files that need the global register variable

2010-06-30 Thread Paolo Bonzini
>>> Wouldn't it be better to just put this in dyngen-exec.h ? >>> AFAICT there's a direct correlation between NEED_GLOBAL_ENV and #include >>> "exec.h". >> >> True, see cover letter in 0/4.  I was told to make each file request >> explicitly the global variable though.  So I'd have to leave the #if

[Qemu-devel] Re: [PATCH] device-assignment: Rework "name" of assigned pci device

2010-06-30 Thread Hidetoshi Seto
(2010/06/30 15:53), Markus Armbruster wrote: > Summary: upstream qemu commit b560a9ab broke -pcidevice and pci_add host > in two ways: > > * Use without options id and name is broken when option host contains > ':'. That's because id defaults to host. I recommend to fix it > incompatibly: do

Re: [Qemu-devel] Tracing: outstanding tasks

2010-06-30 Thread Prerna Saxena
On 06/26/2010 01:36 PM, Stefan Hajnoczi wrote: Here are the outstanding tasks for QEMU tracing, which Prerna and I have been working on. Tracing aids debugging, profiling, and observing execution via lightweight logging at key points in the code path. The current prototype is available from the

[Qemu-devel] [RFC][PATCH] PCI: fix pci_to_cpu_addr() issue

2010-06-30 Thread Huacai Chen
It seems like software may both use CPU address or PCI address to access a PCI device. For example, Bonito north bridge map PCI memory space at 0x1000 ~ 0x1C00. PMON code use 0x ~ 0x0C00, but Linux kernel code use 0x1000 ~ 0x1C00 to access devices. If set pci_mem_base

[Qemu-devel] [PATCH] virtio-9p: Avoid SEGV when log file couldn't be opened

2010-06-30 Thread Sripathi Kodi
While running in debug mode if 9P server is unable to open the log file it results in a SEGV deep down in glibc: Program received signal SIGSEGV, Segmentation fault. 0x008fca8c in fwrite () from /lib/libc.so.6 (gdb) bt #0 0x008fca8c in fwrite () from /lib/libc.so.6 #1 0x081eb87e in pprint_pdu (p

[Qemu-devel] Re: [PATCH 09/12] savevm: Survive hot-unplug of snapshot device

2010-06-30 Thread Markus Armbruster
Christoph Hellwig writes: > Looks good, > > Reviewed-by: Christoph Hellwig > > Of course specifying an explicit medium for snapshot, be that the > snapshot section of a qcow2 image or just a separate flat file and > managing that one explicitly would be even better. Indeed.

Re: [Qemu-devel] Re: [PATCH 08/12] block: Catch attempt to attach multiple devices to a blockdev

2010-06-30 Thread Markus Armbruster
Christoph Hellwig writes: >Markus Armbruster writes: > >> Christoph Hellwig writes: >> >>> On Fri, Jun 25, 2010 at 06:53:28PM +0200, Markus Armbruster wrote: For instance, -device scsi-disk,drive=foo -device scsi-disk,drive=foo happily creates two SCSI disks connected to the same bloc

[Qemu-devel] [Bug 494500] Re: QEMU 0.12.0 does not support KVM with Kernel < 2.6.29, bug in ./configure and kvm-all.c

2010-06-30 Thread Jes Sorensen
As pointed out repeatedly, this is _not_ a bug in QEMU Stop reopening the bug! ** Changed in: qemu Status: New => Invalid -- QEMU 0.12.0 does not support KVM with Kernel < 2.6.29, bug in ./configure and kvm-all.c https://bugs.launchpad.net/bugs/494500 You received this bug notification

Re: [Qemu-devel] Tracing: outstanding tasks

2010-06-30 Thread Stefan Hajnoczi
On Wed, Jun 30, 2010 at 11:20 AM, Prerna Saxena wrote: > On 06/26/2010 01:36 PM, Stefan Hajnoczi wrote: >> >> Here are the outstanding tasks for QEMU tracing, which Prerna and I have >> been working on.  Tracing aids debugging, profiling, and observing >> execution via lightweight logging at key p

Re: [Qemu-devel] Re: [PATCH 08/12] block: Catch attempt to attach multiple devices to a blockdev

2010-06-30 Thread Markus Armbruster
Kevin Wolf writes: > Am 28.06.2010 12:16, schrieb Christoph Hellwig: >> On Mon, Jun 28, 2010 at 10:24:49AM +0200, Kevin Wolf wrote: >> >>> Am 27.06.2010 11:36, schrieb Christoph Hellwig: On Sat, Jun 26, 2010 at 04:44:11PM +0200, Markus Armbruster wrote: [...] > -device usb-storage,drive=

[Qemu-devel] [PATCH 02/11] block migration: Fix test for read-only drive

2010-06-30 Thread Markus Armbruster
init_blk_migration_it() skips drives with type hint BDRV_TYPE_CDROM. The intention is to skip read-only drives. However, BDRV_TYPE_CDROM is only a hint. It is currently sufficent for read-only. But it's not necessary, and it may not remain sufficient. Use bdrv_is_read_only() instead. Signed-of

[Qemu-devel] [PATCH 10/11] ide: Reject readonly drives unless CD-ROM

2010-06-30 Thread Markus Armbruster
drive_init() doesn't permit option readonly for if=ide, but that's worthless: we get it via if=none and -device. Signed-off-by: Markus Armbruster --- hw/ide/core.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index a0eb1fa..73eae20 10

[Qemu-devel] [PATCH 03/11] raw-posix: Don't "try harder" for BDRV_TYPE_CDROM

2010-06-30 Thread Markus Armbruster
raw_pread_aligned() retries up to two times if the block device backs a virtual CD-ROM. This makes no sense. Whether retrying reads can correct read errors may depend on what we're reading, not on how the result gets used. Also clean up gratuitous use of goto. This reverts what's left of commit

[Qemu-devel] [PATCH 00/11] Still more block related fixes and cleanups

2010-06-30 Thread Markus Armbruster
I'm working on cleanly separating block device host and guest parts. I'd like to route all this work through Kevin's block tree. This is still just preliminaries. This patch series is based on v2 of my previous series. git://repo.or.cz/qemu/armbru.git tag block-fixes-2-v1: this series, based on t

[Qemu-devel] [PATCH 11/11] ide: Reject invalid CHS geometry

2010-06-30 Thread Markus Armbruster
drive_init() doesn't permit invalid CHS for if=ide, but that's worthless: we get it via if=none and -device. Signed-off-by: Markus Armbruster --- hw/ide/core.c | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index 73eae20..11edca

[Qemu-devel] [PATCH 08/11] ide: Replace IDEState members is_cdrom, is_cf by drive_kind

2010-06-30 Thread Markus Armbruster
The two aren't independent variables. Make that obvious. Signed-off-by: Markus Armbruster --- hw/ide/core.c | 40 hw/ide/internal.h |5 +++-- hw/ide/macio.c |2 +- hw/ide/microdrive.c |2 +- 4 files changed, 25 insertions(+), 2

[Qemu-devel] [PATCH 04/11] scsi: Reject unimplemented error actions

2010-06-30 Thread Markus Armbruster
drive_init() doesn't permit rerror for if=scsi, but that's worthless: we get it via if=none and -device. Moreover, scsi-generic doesn't support werror. Since drive_init() doesn't catch that, option werror was silently ignored even with if=scsi. Signed-off-by: Markus Armbruster --- hw/scsi-disk

[Qemu-devel] [PATCH 01/11] blockdev: Clean up how readonly persists across virtual media change

2010-06-30 Thread Markus Armbruster
Since commit cb4e5f8e, monitor command change makes the new media readonly iff the type hint is BDRV_TYPE_CDROM, i.e. the drive was created with media=cdrom. The intention is to avoid changing a block device's read-only-ness. However, BDRV_TYPE_CDROM is only a hint. It is currently sufficent for

[Qemu-devel] [PATCH 05/11] fdc: Reject unimplemented error actions

2010-06-30 Thread Markus Armbruster
drive_init() doesn't permit them for if=floppy, but that's worthless: we get them via if=none and -global. This can make device initialization fail. Since all callers of fdctrl_init_isa() ignore its value, change it to die instead of returning failure. Without this, some callers would ignore the

[Qemu-devel] [PATCH 06/11] qdev: Don't hw_error() in qdev_init_nofail()

2010-06-30 Thread Markus Armbruster
Some of the failures are internal errors, and hw_error() is okay then. But the common way to fail is bad user input, e.g. -global isa-fdc.driveA=foo where drive foo has an unsupported rerror value. exit(1) instead. Signed-off-by: Markus Armbruster --- hw/qdev.c |6 -- 1 files changed, 4

[Qemu-devel] [PATCH 09/11] ide: Make ide_init_drive() return success

2010-06-30 Thread Markus Armbruster
It still always succeeds. The next commits will add failures. Signed-off-by: Markus Armbruster --- hw/ide/core.c | 13 + hw/ide/internal.h |4 ++-- hw/ide/qdev.c |4 +++- 3 files changed, 14 insertions(+), 7 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c

[Qemu-devel] [PATCH 07/11] ide: Improve error messages

2010-06-30 Thread Markus Armbruster
Use error_report(), because it points to the error location. Reword "tried to assign twice" messages to make it clear that we're complaining about the unit property. Report invalid unit property instead of failing silently. Signed-off-by: Markus Armbruster --- hw/ide/qdev.c |9 + 1

[Qemu-devel] [Bug 494500] Re: QEMU 0.12.0 does not support KVM with Kernel < 2.6.29, bug in ./configure and kvm-all.c

2010-06-30 Thread rowa
@Jes Sorensen This is a bug in the script configure of qemu. So this is a bug in QEMU. ** Changed in: qemu Status: Invalid => New -- QEMU 0.12.0 does not support KVM with Kernel < 2.6.29, bug in ./configure and kvm-all.c https://bugs.launchpad.net/bugs/494500 You received this bug noti

Re: [Qemu-devel] Re: [PATCH 08/12] block: Catch attempt to attach multiple devices to a blockdev

2010-06-30 Thread Kevin Wolf
Am 30.06.2010 13:52, schrieb Markus Armbruster: > Kevin Wolf writes: > >> Am 28.06.2010 12:16, schrieb Christoph Hellwig: >>> On Mon, Jun 28, 2010 at 10:24:49AM +0200, Kevin Wolf wrote: >>> Am 27.06.2010 11:36, schrieb Christoph Hellwig: > On Sat, Jun 26, 2010 at 04:44:11PM +0200, Markus

[Qemu-devel] Re: Block live migration's use of type hint

2010-06-30 Thread Markus Armbruster
Markus Armbruster writes: > Liran Schour writes: > >> Markus Armbruster wrote on 28/06/2010 10:26:47: >> >>> From: Markus Armbruster >>> To: qemu-devel@nongnu.org >>> Cc: Liran Schour/Haifa/i...@ibmil >>> Date: 28/06/2010 10:26 >>> Subject: Block live migration's use of type hint >>> >>> Block

[Qemu-devel] [Bug 494500] Re: QEMU 0.12.0 does not support KVM with Kernel < 2.6.29, bug in ./configure and kvm-all.c

2010-06-30 Thread Iggy
Recent kvm-kmod's install headers, so the text is actually correct now. I'd say this bug can be closed now. -- QEMU 0.12.0 does not support KVM with Kernel < 2.6.29, bug in ./configure and kvm-all.c https://bugs.launchpad.net/bugs/494500 You received this bug notification because you are a memb

[Qemu-devel] [Bug 494500] Re: QEMU 0.12.0 does not support KVM with Kernel < 2.6.29, bug in ./configure and kvm-all.c

2010-06-30 Thread rowa
Does the _lastest_ kvm-kmod's install the right headers for the used kernel, for example kernel 2.6.28-11? As I wrote in this bug I had problems with a kernel 2.6.28-11 and the _latest_ version of kvm-kmod. It works only with the right (not the latest) version of kvm-kmod. I'll check it in some

[Qemu-devel] Re: [PATCH 09/12] savevm: Survive hot-unplug of snapshot device

2010-06-30 Thread Kevin Wolf
Am 25.06.2010 18:53, schrieb Markus Armbruster: > savevm.c keeps a pointer to the snapshot block device. If you manage > to get that device deleted, the pointer dangles, and the next snapshot > operation will crash & burn. Unplugging a guest device that uses it > does the trick: > > $ MALLOC

[Qemu-devel] Re: [RFC][PATCH] PCI: fix pci_to_cpu_addr() issue

2010-06-30 Thread Isaku Yamahata
Can you elaborate on how pci bus is mapped into local bus? Is there specification publicly available? Google didn't tell me. On Wed, Jun 30, 2010 at 06:39:53PM +0800, Huacai Chen wrote: > It seems like software may both use CPU address or PCI address to access a PCI > device. For example, Bonito

Re: [Qemu-devel] how to add one pcie device to qemu

2010-06-30 Thread Isaku Yamahata
On Wed, Jun 30, 2010 at 04:10:02PM +0800, Lisa Lei wrote: > Hi, > I'm finding the solution of how to add one pcie device which emulated by > systemc to qemu, such as net card. I noticed that you've been working on Q35 > support for qemu, and the status of pcie port emulator is working on Apri

[Qemu-devel] Re: [RFC][PATCH] PCI: fix pci_to_cpu_addr() issue

2010-06-30 Thread chen huacai
Maybe this is what you want, please look at Page 10. http://people.openrays.org/~comcat/godson/doc/godson2e.north.bridge.manual.pdf But it is written in Chinese, I'm sorry that I also don't have an English version. On Wed, Jun 30, 2010 at 9:38 PM, Isaku Yamahata wrote: > Can you elaborate on how

[Qemu-devel] [Bug 599958] Re: Timedrift problems with Win7 + qemu-kvm

2010-06-30 Thread Lucas Meneghel Rodrigues
Indeed -no-hpet made the tests pass. It's still uncertain to me whether this flag is supported across several branches of qemu-kvm, if it's supported in all branches I'm going to update the upstream kvm autotest config file. -- Timedrift problems with Win7 + qemu-kvm https://bugs.launchpad.net/bu

[Qemu-devel] [Bug 599958] Re: Timedrift problems with Win7: hpet missing time drift fixups

2010-06-30 Thread Anthony Liguori
-no-hpet works in every version of qemu/qemu-kvm that has included HPET support. RHEL disables HPET support by default unlike qemu and qemu- kvm. I've updated the bug priority and title to reflect what the issue is. We only support edge triggered interrupts with HPET which seems to be what most

[Qemu-devel] [PATCH v2 0/7] QMP: Introduce query-netdev

2010-06-30 Thread Miguel Di Ciurcio Filho
This series implement the previously discussed QMP command query-netdev. Regards, changelog from v1 - - Fixed wrong usage of qemu_free() with vc->info_dict, now using QDECREF() - Fixed QString leak in netdev_iter() changelog from last protocol spec ---

[Qemu-devel] [PATCH v2 2/7] QObject API: introduce qdict_to_qstring() function

2010-06-30 Thread Miguel Di Ciurcio Filho
This is a helper function that converts a QDict to a QString, using the format: key1=value1 SEP key2=value2 SEP key3=value3 Handy for debugging and formating the Monitor output. Signed-off-by: Miguel Di Ciurcio Filho --- qdict.c | 60 ++

[Qemu-devel] [PATCH v2 1/7] QMP: Introduce the documentation for query-netdev and info netdev

2010-06-30 Thread Miguel Di Ciurcio Filho
These commands show the information about active backend network devices. Signed-off-by: Miguel Di Ciurcio Filho --- qemu-monitor.hx | 100 +++ 1 files changed, 100 insertions(+), 0 deletions(-) diff --git a/qemu-monitor.hx b/qemu-monitor.hx

[Qemu-devel] [PATCH v2 3/7] net: Introduce VLANClientState->info_dict

2010-06-30 Thread Miguel Di Ciurcio Filho
There is no standard format when formatting VLANClientState.info_str, so it is difficult to extract information and transmit it over QMP. This patch adds info_dict, a QDict to better handle this information. Signed-off-by: Miguel Di Ciurcio Filho --- net.c |1 + net.h |1 + 2 files chan

[Qemu-devel] [PATCH v2 4/7] net: tap/tap-win32: introduce info_dict

2010-06-30 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho --- net/tap-win32.c |7 +++ net/tap.c | 22 +- 2 files changed, 28 insertions(+), 1 deletions(-) diff --git a/net/tap-win32.c b/net/tap-win32.c index 74348da..5e58702 100644 --- a/net/tap-win32.c +++ b/net/tap-win32.c @@

[Qemu-devel] [PATCH v2 7/7] monitor/net: introduce 'info netdev' with QMP support

2010-06-30 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho --- monitor.c |8 +++ net.c | 71 + net.h |2 + 3 files changed, 81 insertions(+), 0 deletions(-) diff --git a/monitor.c b/monitor.c index 170b269..b44768c 100644 --- a/monito

[Qemu-devel] [PATCH v2 5/7] net: vde: introduce info_dict

2010-06-30 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho --- net/vde.c | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/net/vde.c b/net/vde.c index 0b46fa6..a8a5b03 100644 --- a/net/vde.c +++ b/net/vde.c @@ -31,6 +31,9 @@ #include "qemu-char.h" #include "qemu-common.h" #inc

[Qemu-devel] [PATCH v2 6/7] net: slirp: introduce info_dict

2010-06-30 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho --- net/slirp.c | 42 +++--- 1 files changed, 39 insertions(+), 3 deletions(-) diff --git a/net/slirp.c b/net/slirp.c index b41c60a..9549711 100644 --- a/net/slirp.c +++ b/net/slirp.c @@ -32,6 +32,9 @@ #include "monito

[Qemu-devel] [PATCH][Tracing] Fix build errors for target i386-linux-user

2010-06-30 Thread Prerna Saxena
[PATCH 1/1] Move definitions of monitor command handlers (do_info_trace, do_info_all_trace_events) to monitor.c. This removes build errors for user targets such as i386-linux-user, which are not linked with monitor. The export of trace_buf and trace_idx is an unfortunate side effect, since thes

[Qemu-devel] [PATCH 1/3] blkdebug: Fix set_state_opts definition

2010-06-30 Thread Kevin Wolf
The list head was initialized to point to the wrong list, so all actions ended up being handled as inject-error even if they were set-state in fact. Signed-off-by: Kevin Wolf --- block/blkdebug.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/block/blkdebug.c b/block/b

[Qemu-devel] [PATCH 0/3] blkdebug: Fix config with multiple states

2010-06-30 Thread Kevin Wolf
Turns out that using more than one state doesn't really work well. I'm trying to reproduce a bug for which I need states, so now is the time to fix it. Kevin Wolf (3): blkdebug: Fix set_state_opts definition blkdebug: Free QemuOpts after having read the config blkdebug: Initialize state as 1

[Qemu-devel] [Bug 599958] Re: Timedrift problems with Win7: hpet missing time drift fixups

2010-06-30 Thread Lucas Meneghel Rodrigues
Sent patch http://patchwork.test.kernel.org/patch/2384/ to autotest and will update the autotest server to reflect that option. -- Timedrift problems with Win7: hpet missing time drift fixups https://bugs.launchpad.net/bugs/599958 You received this bug notification because you are a member of qem

[Qemu-devel] [PATCH 2/3] blkdebug: Free QemuOpts after having read the config

2010-06-30 Thread Kevin Wolf
Forgetting to free them means that the next instance inherits all rules and gets its own rules only additionally. Signed-off-by: Kevin Wolf --- block/blkdebug.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/block/blkdebug.c b/block/blkdebug.c index 4ec8ca6..b0847

[Qemu-devel] [PATCH 3/3] blkdebug: Initialize state as 1

2010-06-30 Thread Kevin Wolf
state = 0 in rules means that the rule is valid for any state. Therefore it's impossible to have a rule that works only in the initial state. This changes the initial state from 0 to 1 to make this possible. Signed-off-by: Kevin Wolf --- block/blkdebug.c |3 +++ 1 files changed, 3 insertions

[Qemu-devel] Re: [PATCH 09/12] savevm: Survive hot-unplug of snapshot device

2010-06-30 Thread Markus Armbruster
Kevin Wolf writes: > Am 25.06.2010 18:53, schrieb Markus Armbruster: >> savevm.c keeps a pointer to the snapshot block device. If you manage >> to get that device deleted, the pointer dangles, and the next snapshot >> operation will crash & burn. Unplugging a guest device that uses it >> does t

Re: [Qemu-devel] [PATCH] A bit optimization for tlb_set_page() (resend)

2010-06-30 Thread Aurelien Jarno
On Thu, May 06, 2010 at 02:36:59PM +0900, Jun Koi wrote: > This patch avoids handling write watchpoints on read-only memory access. > It also breaks the searching loop for watchpoint once the setup for > handling watchpoint later is done. > > Signed-off-by: Jun Koi Thanks, applied. > diff --git

Re: [Qemu-devel] [PATCH] usb-serial: Fail instead of crash when chardev is missing

2010-06-30 Thread Aurelien Jarno
On Fri, May 28, 2010 at 05:03:22PM +0200, Markus Armbruster wrote: > > Signed-off-by: Markus Armbruster > --- > hw/usb-serial.c |5 + > 1 files changed, 5 insertions(+), 0 deletions(-) Thanks, applied. > diff --git a/hw/usb-serial.c b/hw/usb-serial.c > index 5b2483a..c19580f 100644 > -

Re: [Qemu-devel] [PATCH] virtio-serial: Simplify virtio_serial_load()

2010-06-30 Thread Aurelien Jarno
On Mon, May 31, 2010 at 04:19:43PM +0200, Markus Armbruster wrote: > For all i, ports_map[i] is used in and only in the i-th iteration. > Replace the dynamic array by a scalar variable. > > Signed-off-by: Markus Armbruster > --- > hw/virtio-serial-bus.c | 12 +++- > 1 files changed, 3

Re: [Qemu-devel] [PATCH v2 00/12] refactor OMAP implementation

2010-06-30 Thread Aurelien Jarno
On Mon, May 31, 2010 at 11:54:12PM +0800, cmchao wrote: > The following changes since commit aa6f63fff62faf2fe9ffba5a789675d49293614d > Blue Swirl: > mc146818rtc: improve debugging > Add a separate flag for debugging coalesced interrupts. > > The patches almostly base on http://meeg

Re: [Qemu-devel] [PATCH][RESEND] usb-uhci: fix commit 8e65b7c04965c8355e4ce43211582b6b83054e3d for vmstate

2010-06-30 Thread Aurelien Jarno
On Tue, Jun 01, 2010 at 12:26:20PM +0800, TeLeMan wrote: > The commit 8e65b7c04965c8355e4ce43211582b6b83054e3d introduced > expire_time of UHCIState. But expire_time is not in vmstate, the > second uhci_frame_timer will not be fired immediately after loadvm. > > Signed-off-by: TeLeMan > --- > hw

Re: [Qemu-devel] [PATCH][RESEND] qdev-properties: Fix (u)intXX parsers

2010-06-30 Thread Aurelien Jarno
On Fri, Jun 18, 2010 at 06:27:03PM +0200, Kevin Wolf wrote: > scanf calls must not use PRI constants, they have probably the wrong size and > corrupt memory. We could replace them by SCN ones, but strtol is simpler than > scanf here anyway. While at it, also fix the parsers to reject garbage after

Re: [Qemu-devel] [PATCH 0/2 v5] Release usb devices on shutdown and usb_del

2010-06-30 Thread Aurelien Jarno
On Wed, Jun 16, 2010 at 03:15:03PM +0300, Shahar Havivi wrote: > v5: > Fix to Gerd Hoffmann comments on v4. > > Shahar Havivi (2): > Return usb device to host on usb_del command > Return usb device to host on exit > > usb-linux.c | 15 +++ > 1 files changed, 15 insertions(+), 0

Re: [Qemu-devel] [PATCH v2] x86: svm: Always clear event_inj on vmexit

2010-06-30 Thread Aurelien Jarno
On Wed, Jun 02, 2010 at 08:49:14AM +0200, Jan Kiszka wrote: > Erik van der Kouwe wrote: > > Hi, > > > >> We currently only clear SVM_EVTINJ_VALID after successful interrupt > >> delivery. This apparently does not match real hardware which clears the > >> whole event_inj field on every vmexit, incl

Re: [Qemu-devel] [PATCH] net: Fix VM start with '-net none'

2010-06-30 Thread Aurelien Jarno
On Tue, Jun 15, 2010 at 01:30:39PM +0530, Amit Shah wrote: > Commit 50e32ea8f31035877decc10f1075aa0e619e09cb changed the behaviour > for the return type of net_client_init() when a nic type with no init > method was specified. 'none' is one such nic type. Instead of returning > 0, which gets interp

Re: [Qemu-devel] [PATCH] QEMU: Update .gitignore

2010-06-30 Thread Aurelien Jarno
On Mon, Jun 21, 2010 at 06:14:17PM +0900, Hidetoshi Seto wrote: > (2010/06/21 17:19), Avi Kivity wrote: > > On 06/21/2010 08:24 AM, Hidetoshi Seto wrote: > >> I think some people have noticed that: > >> > >>> $ ./configure > >>> $ make > >>> $ git status > >>> # On branch master > >>> # Untracked f

[Qemu-devel] [PATCH] Add QMP/qmp-commands.txt to .gitignore

2010-06-30 Thread Hidetoshi Seto
QMP/qmp-commands.txt is a generated file. Signed-off-by: Hidetoshi Seto --- .gitignore |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/.gitignore b/.gitignore index ce66ed5..a32b7c4 100644 --- a/.gitignore +++ b/.gitignore @@ -28,6 +28,7 @@ qemu-img-cmds.texi qemu-img-c

[Qemu-devel] [PATCH] Add vapic.bin to .gitignore

2010-06-30 Thread Hidetoshi Seto
# This patch is for qemu-kvm.git The vapic.bin is a generated binary file. Signed-off-by: Hidetoshi Seto --- .gitignore |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/.gitignore b/.gitignore index ddc248b..26eba20 100644 --- a/.gitignore +++ b/.gitignore @@ -53,4 +53,5

[Qemu-devel] [PATCH] Makefile: add qemu-options.def to distclean

2010-06-30 Thread Hidetoshi Seto
Remove generated qemu-options.def at "make distclean". Signed-off-by: Hidetoshi Seto --- Makefile |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/Makefile b/Makefile index 221fbd8..560eac6 100644 --- a/Makefile +++ b/Makefile @@ -168,6 +168,7 @@ clean: distclean: clea

[Qemu-devel] [PATCH] Makefile: add fsdev/*.{o,d} to clean

2010-06-30 Thread Hidetoshi Seto
There were fsdev/qemu-fsdev.{o,d} not removed at "make clean". Signed-off-by: Hidetoshi Seto --- Makefile |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile b/Makefile index 560eac6..ce5f0e6 100644 --- a/Makefile +++ b/Makefile @@ -159,7 +159,7 @@ clean: # avoid

Re: [Qemu-devel] [PATCH] QEMU: Update .gitignore

2010-06-30 Thread Hidetoshi Seto
(2010/07/01 6:33), Aurelien Jarno wrote: > On Mon, Jun 21, 2010 at 06:14:17PM +0900, Hidetoshi Seto wrote: >> (2010/06/21 17:19), Avi Kivity wrote: >>> On 06/21/2010 08:24 AM, Hidetoshi Seto wrote: I think some people have noticed that: > $ ./configure > $ make > $ git status

[Qemu-devel] Re: [V9fs-developer] [PATCH] virtio-9p: getattr server implementation for 9P2000.L protocol.

2010-06-30 Thread Aneesh Kumar K. V
On Fri, 28 May 2010 16:08:43 +0530, Sripathi Kodi wrote: > From: M. Mohan Kumar > > SYNOPSIS > > size[4] Tgetattr tag[2] fid[4] > > size[4] Rgetattr tag[2] lstat[n] > >DESCRIPTION > > The getattr transaction inquires about the file identified by fid. > The reply w

[Qemu-devel] [Bug 595438] Re: KVM segmentation fault, using SCSI+writeback and linux 2.4 guest

2010-06-30 Thread Jes Sorensen
Could you try and run this in GDB and get the backtrace when it crashes? Just do: gdb /usr/bin/kvm (gdb) set args -M pc-0.12 -enable-kvm -m 256 -smp 1 -name spamsender -uuid b9cacd5e-08f7-41fd-78c8-89cec59af881 -chardev socket,id=monitor,path=/var/lib/libvirt/qemu/spamsender.monitor,server,nowai

Re: [Qemu-devel] [PATCH 2/3] blkdebug: Free QemuOpts after having read the config

2010-06-30 Thread Markus Armbruster
Kevin Wolf writes: > Forgetting to free them means that the next instance inherits all rules and > gets its own rules only additionally. I also found a use for freeing a complete QemuOptsList, here's my solution. The code that needs it isn't ready, yet. If you'd like to use it, I can push it t

Re: [Qemu-devel] [PATCH 0/3] blkdebug: Fix config with multiple states

2010-06-30 Thread Markus Armbruster
Kevin Wolf writes: > Turns out that using more than one state doesn't really work well. I'm trying > to reproduce a bug for which I need states, so now is the time to fix it. I'm not familiar with blkdebug, but these look like obvious bug fixes.