Re: [Qemu-devel] [PATCH v7 08/38] libqos: Track QTestState with QPCIBus

2017-09-12 Thread Thomas Huth
On 11.09.2017 19:19, Eric Blake wrote: > When initializing a QPCIBus, track which QTestState the bus is > associated with (so that a later patch can then explicitly use > that test state for all communication on the bus, rather than > blindly relying on global_qtest). Update the initialization > f

Re: [Qemu-devel] [RFC PATCH qemu 3/4] memory: Share flat views and dispatch trees between address spaces

2017-09-12 Thread Paolo Bonzini
On 12/09/2017 07:55, Alexey Kardashevskiy wrote: > On 12/09/17 01:30, Paolo Bonzini wrote: >> On 11/09/2017 14:08, Alexey Kardashevskiy wrote: Ok, this makes sense. Maybe it should be a flatview rather than an AddressSpaceDispatch (a FlatView is essentially a list of MemoryRegionSec

Re: [Qemu-devel] [PATCH v7 09/38] libqos: Track QTestState with QVirtioBus

2017-09-12 Thread Thomas Huth
On 11.09.2017 19:19, Eric Blake wrote: > When initializing a QVirtioDevice (which always has an associated > QVirtioBus), we want to track which QTestState to use for all > I/O processed through that bus and device. Copy the paradigm > used for QPCIBus, and track the test state at the bus level; t

Re: [Qemu-devel] [PATCH v7 10/38] libqos: Move/rename qpci_unplug_acpi_device_test() to pci.c

2017-09-12 Thread Thomas Huth
On 11.09.2017 19:19, Eric Blake wrote: > Commit 2f8b2767 originally added qpci_plug_device_test() and > qpci_unplug_acpi_device_test() as a pair, both in pci-pc.c. > Later, commit cf716b31 moved one half of the pair to pci.c > when adding PPC64 support. Keep the implementations of the > two functi

Re: [Qemu-devel] [PATCH v7 12/38] libqos: Use explicit QTestState for virtio operations

2017-09-12 Thread Thomas Huth
On 11.09.2017 19:19, Eric Blake wrote: > Now that QVirtioDevice and QVirtQueue point back to QVirtioBus, > we can reuse the explicit QTestState stored there rather than > relying on implicit global_qtest. We also have to pass QTestState > through a few functions that can't trace back through > QVi

Re: [Qemu-devel] [PATCH v1 0/6] QEMU: kvm: cleanup kvm_slot handling

2017-09-12 Thread Paolo Bonzini
On 11/09/2017 19:49, David Hildenbrand wrote: > We can heavily simplify the kvm_slot code. Flatview will make sure that we > don't have to deal with overlapping slots. E.g. when a memory section is > resized, we are first notified about the removal and then about the new > memory section. > > So b

Re: [Qemu-devel] qdev_get_machine() can return something non-NULL but not TYPE_MACHINE

2017-09-12 Thread Igor Mammedov
On Mon, 11 Sep 2017 14:33:03 +0100 Peter Maydell wrote: > On 11 September 2017 at 13:10, Igor Mammedov wrote: > > On Tue, 5 Sep 2017 10:08:01 +0100 > > Peter Maydell wrote: > > > >> On 4 September 2017 at 20:38, Igor Mammedov wrote: > >> > On Mon, 4 Sep 2017 17:36:59 +0100 > >> > Peter May

Re: [Qemu-devel] [PATCH] test-qga: add missing qemu-ga tool dependency

2017-09-12 Thread Paolo Bonzini
On 11/09/2017 23:01, Philippe Mathieu-Daudé wrote: > this fixes running 'make check-unit' without running 'make all' beforehand: > > $ make check-unit > ... > GTESTER tests/test-qga > ** > ERROR:tests/test-qga.c:73:fixture_setup: assertion failed (error == NULL): > Failed to execute child pro

Re: [Qemu-devel] Questions regarding emulated UART in VersatilePB board

2017-09-12 Thread Ramy Sameh
Hello Peter, Any suggestions regarding this topic ? On Sun, Sep 10, 2017 at 8:33 PM, Ramy Sameh wrote: > Thanks Peter. > > I have made a program to read a string from the UART, then write it again > to the UART. > I made a function to manipulate values in the pl011 registers (bit > flipping the

Re: [Qemu-devel] [PATCH v4 0/8] More warning reporting fixed

2017-09-12 Thread Paolo Bonzini
On 11/09/2017 21:52, Alistair Francis wrote: > This series expands on my previous series by converting more existing > prints to use warn_report() instead of error_report() or fprintf(). > > As discussed with Paolo and Markus this series combines libqemustub.a into > libqemuutil.a to avoid circula

Re: [Qemu-devel] [PATCH] i386/cpu/hyperv: support over 64 vcpus for windows guests

2017-09-12 Thread Paolo Bonzini
On 12/09/2017 03:41, Gonglei (Arei) wrote: > >> -Original Message- >> From: Eduardo Habkost [mailto:ehabk...@redhat.com] >> Sent: Tuesday, September 12, 2017 2:38 AM >> To: Gonglei (Arei) >> Cc: qemu-devel@nongnu.org; m...@redhat.com; pbonz...@redhat.com; >> r...@twiddle.net; mtosa...@redh

Re: [Qemu-devel] [PATCH v2 2/3] hmp: fix "dump-quest-memory" segfault (arm)

2017-09-12 Thread Laurent Vivier
On 11/09/2017 18:40, Peter Maydell wrote: > On 11 September 2017 at 15:45, Thomas Huth wrote: >> On 11.09.2017 16:39, Peter Maydell wrote: >>> On 11 September 2017 at 15:20, Laurent Vivier wrote: Commit fd5d23babf (hmp: fix "dump-quest-memory" segfault) fixes the problem for i386, do th

Re: [Qemu-devel] [PATCH] MAINTAINERS: Update git URLs for my trees

2017-09-12 Thread Paolo Bonzini
On 01/09/2017 17:47, Eduardo Habkost wrote: > On Fri, Sep 01, 2017 at 12:39:28PM -0300, Eduardo Habkost wrote: >> List the branches where I queue patches for Machine Core, NUMA, >> Memory Backends, and X86. Update the NUMA section to list the >> "numa-next" branch instead of "numa". >> >> Signed-o

Re: [Qemu-devel] [PATCH 0/2] hyperv: own protocol header instead of kernel's

2017-09-12 Thread Paolo Bonzini
On 31/08/2017 18:37, Roman Kagan wrote: > On Thu, Jul 13, 2017 at 11:15:20PM +0300, Roman Kagan wrote: >> Supersede kernel's header for Hyper-V protocol definitions with our own. >> The reason is that, since this is a third-party protocol and not a >> kernel API, the kernel folks are not happy expo

Re: [Qemu-devel] [PATCH] tcg/tci: do not use ldst label (never implemented)

2017-09-12 Thread Stefan Weil
Am 11.09.2017 um 20:24 schrieb Peter Maydell: > I've also turned on a tci compile check on my pre-merge tests. > (It doesn't pass "make check" for me, though...) thanks -- PMM "make check-qtest-ppc64" fails for me, too. Thomas, this seems to be again the well known timing problem in tests/prom-en

[Qemu-devel] [PATCH v7 RESEND] qga: Add support network interface statistics in guest-network-get-interfaces command

2017-09-12 Thread ZhiPeng Lu
we can get the network interface statistics inside a virtual machine by guest-network-get-interfaces command. it is very useful for us to monitor and analyze network traffic. Signed-off-by: ZhiPeng Lu --- v1->v2: - correct some spelling mistake and add the stats data to the guest-network-get

Re: [Qemu-devel] [PATCH v7 13/38] libqos: Use explicit QTestState for fw_cfg operations

2017-09-12 Thread Thomas Huth
On 11.09.2017 19:19, Eric Blake wrote: > Drop one more client of global_qtest by teaching all fw_cfg test > functionality (invoked through alloc-pc) to pass in an explicit > QTestState, adjusting all callers. In particular, fw_cfg-test > had to reorder things to create the test state prior to crea

[Qemu-devel] Suggested Wiki Update

2017-09-12 Thread Viktor Mihajlovski
Hi, the content of https://wiki.qemu.org/index.php/Features/S390xNetworkBoot is slightly outdated since proper DHCP based netboot support for s390x has been implemented by the series ending with commit 29d1221. As it is still desirable to provide some instructions on building network bootable ima

Re: [Qemu-devel] [PATCH v2 6/6] io: Reply to ping frames

2017-09-12 Thread Daniel P. Berrange
On Mon, Sep 11, 2017 at 12:04:15PM -0700, Brandon Carpenter wrote: > On Mon, Sep 11, 2017 at 10:10 AM, Daniel P. Berrange > wrote: > > It feels like this is still dangerous - the client simply has to > > interleave each "ping" with a 1 byte binary frame to get around this > > limit. We need to mak

Re: [Qemu-devel] [PATCH v2 6/6] io: Reply to ping frames

2017-09-12 Thread Daniel P. Berrange
On Mon, Sep 11, 2017 at 10:43:21AM -0700, Brandon Carpenter wrote: > On Mon, Sep 11, 2017 at 10:37 AM, Daniel P. Berrange > wrote: > > At the time qio_channel_websock_decode_header is run, 'encinput' is only > > guaranteed to contain enough data to decode the header. > > Because the PING opcode i

Re: [Qemu-devel] [PATCH v7 14/38] libqos: Use explicit QTestState for rtas operations

2017-09-12 Thread Thomas Huth
On 11.09.2017 19:19, Eric Blake wrote: > Drop one more client of global_qtest by teaching all rtas test > functionality to pass in an explicit QTestState, adjusting all > callers. > > Signed-off-by: Eric Blake > > --- > v7: catch a couple more operations, drop R-b > --- > tests/libqos/rtas.h

Re: [Qemu-devel] [PATCH v7 15/38] libqos: Use explicit QTestState for i2c operations

2017-09-12 Thread Thomas Huth
On 11.09.2017 19:19, Eric Blake wrote: > Drop one more client of global_qtest by teaching all i2c test > functionality to pass in an explicit QTestState, adjusting all > callers. > > Signed-off-by: Eric Blake > --- > tests/libqos/i2c.h | 7 -- > tests/ds1338-test.c | 6 ++--- > te

Re: [Qemu-devel] [PATCH] tcg/ppc: disable atomic write check on ppc32

2017-09-12 Thread Peter Maydell
On 12 September 2017 at 05:23, Richard Henderson wrote: > On 09/11/2017 02:37 PM, Peter Maydell wrote: >> On 11 September 2017 at 21:49, Philippe Mathieu-Daudé >> wrote: >>> this fixes building for ppc64 on ppc32 (changed in 5964fca8a12c): >>> >>> qemu/tcg/ppc/tcg-target.inc.c: In function 'tb

Re: [Qemu-devel] [PATCH v7 16/38] libqos: Use explicit QTestState for ahci operations

2017-09-12 Thread Thomas Huth
On 11.09.2017 19:20, Eric Blake wrote: > Drop one more client of global_qtest by teaching all ahci test > functionality to pass in an explicit QTestState. The state was > already available, so no callers had to be adjusted. > > Signed-off-by: Eric Blake Reviewed-by: Thomas Huth

Re: [Qemu-devel] qdev_get_machine() can return something non-NULL but not TYPE_MACHINE

2017-09-12 Thread Peter Maydell
On 12 September 2017 at 08:40, Igor Mammedov wrote: > On Mon, 11 Sep 2017 14:33:03 +0100 > Peter Maydell wrote: >> It's not possible in all cases to set a CPU property from the >> top level board code. In quite a lot of cases the CPU >> object is created by an SoC object which is in turn >> creat

Re: [Qemu-devel] Questions regarding emulated UART in VersatilePB board

2017-09-12 Thread Peter Maydell
On 12 September 2017 at 08:49, Ramy Sameh wrote: > Hello Peter, > > Any suggestions regarding this topic ? No, I think at this point you're into the stuff that you need to think about yourself, ie what exactly you want fault injection to do. PS: your emails would be easier to read if you followe

Re: [Qemu-devel] [PATCH] tcg/tci: do not use ldst label (never implemented)

2017-09-12 Thread Stefan Weil
Am 12.09.2017 um 10:52 schrieb Stefan Weil: > Am 11.09.2017 um 20:24 schrieb Peter Maydell: >> I've also turned on a tci compile check on my pre-merge tests. >> (It doesn't pass "make check" for me, though...) thanks -- PMM > > "make check-qtest-ppc64" fails for me, too. > > Thomas, this seems to

Re: [Qemu-devel] [PATCH v4 0/3] QEMU Backup Tool

2017-09-12 Thread Stefan Hajnoczi
On Fri, Sep 08, 2017 at 10:11:42PM +0530, Ishani Chugh wrote: > This patch series is intended to introduce QEMU Backup tool. > qemu-backup will be a command-line tool for performing full and > incremental disk backups on running VMs. It is intended as a > reference implementation for management sta

Re: [Qemu-devel] [PATCH v7 24/38] tests/acpi-utils: Drop dependence on global_qtest

2017-09-12 Thread Thomas Huth
On 11.09.2017 19:20, Eric Blake wrote: > As a general rule, we prefer avoiding implicit global state > because it makes code harder to safely copy and paste without > thinking about the global state. Adjust the helper code to > use explicit state instead, and update all callers. > > bios-tables-t

Re: [Qemu-devel] [PATCH v7 26/38] libqtest: Merge qtest_end() into qtest_quit()

2017-09-12 Thread Thomas Huth
On 11.09.2017 19:20, Eric Blake wrote: > Rather than have two similar shutdown functions, where one requires > the use of global_qtest in the header, it is better to have a single > shutdown function that still takes care of cleaning up global_qtest > if it is set. All callers are updated. > > Si

Re: [Qemu-devel] [PATCH for-2.10] qemu-options: Document the -drive locking parameter.

2017-09-12 Thread Richard W.M. Jones
On Wed, Sep 06, 2017 at 01:38:45PM +0200, Kevin Wolf wrote: > This command line fragment looks correct to me. For me, it seems to > work. I'm starting a first qemu in the background with default locking > options: > > $ x86_64-softmmu/qemu-system-x86_64 -hda /tmp/test.qcow2 > > And then start

Re: [Qemu-devel] loading bitmaps in invalidate_cache fails

2017-09-12 Thread Kevin Wolf
Am 11.09.2017 um 18:51 hat Vladimir Sementsov-Ogievskiy geschrieben: > Hi Kevin! > > I'm confused with relations of permissions and invalidation, can you please > help? > > Now dirty bitmaps are loaded in invalidate_cache. Here is a problem with > migration: > > 1. destination starts (inactive)

Re: [Qemu-devel] [RFC PATCH qemu 3/4] memory: Share flat views and dispatch trees between address spaces

2017-09-12 Thread Alexey Kardashevskiy
On 12/09/17 17:12, Paolo Bonzini wrote: > On 12/09/2017 07:55, Alexey Kardashevskiy wrote: >> On 12/09/17 01:30, Paolo Bonzini wrote: >>> On 11/09/2017 14:08, Alexey Kardashevskiy wrote: > Ok, this makes sense. Maybe it should be a flatview rather than an > AddressSpaceDispatch (a FlatView

Re: [Qemu-devel] qdev_get_machine() can return something non-NULL but not TYPE_MACHINE

2017-09-12 Thread Igor Mammedov
On Tue, 12 Sep 2017 10:11:32 +0100 Peter Maydell wrote: > On 12 September 2017 at 08:40, Igor Mammedov wrote: > > On Mon, 11 Sep 2017 14:33:03 +0100 > > Peter Maydell wrote: > >> It's not possible in all cases to set a CPU property from the > >> top level board code. In quite a lot of cases t

Re: [Qemu-devel] [PATCH v7 27/38] libqtest: Swap order of qtest_init() and qtest_start()

2017-09-12 Thread Thomas Huth
On 11.09.2017 19:20, Eric Blake wrote: > We already have another qtest_init() in the tree (namely, as part > of the device initialization of the qtest device at the top level > qtest.c), with a different signature; having two different > qtest_init() is confusing, so an upcoming patch will consolid

Re: [Qemu-devel] [PATCH 01/12] qemu-iotests: remove dead code

2017-09-12 Thread Kevin Wolf
Am 10.08.2017 um 00:43 hat Paolo Bonzini geschrieben: > > > - Original Message - > > From: "Eric Blake" > > To: "Paolo Bonzini" , qemu-devel@nongnu.org > > Cc: kw...@redhat.com, qemu-bl...@nongnu.org > > Sent: Thursday, August 10, 2017 12:18:54 AM > > Subject: Re: [Qemu-devel] [PATCH 01/

[Qemu-devel] [Bug 1135567] Re: QXL crashes a Windows 7 guest if host goes into screensaver

2017-09-12 Thread Philosophish
Hello, Obviously my hardware configuration and versions etc. have changed. Also, I have taken to not using screensavers in the virtual machines anymore i.e. disabled. BUT: I have set it up as similarly as possible and the crash/freeze/hang up with current versions of the drivers seems to be gone

Re: [Qemu-devel] [PATCH v7 28/38] libqtest: Add qtest_[v]startf()

2017-09-12 Thread Thomas Huth
On 11.09.2017 19:20, Eric Blake wrote: > We have several callers that were formatting the argument strings > themselves; consolidate this effort by adding new convenience > functions directly in libqtest, and update all call-sites that > can benefit from it. [...] > diff --git a/tests/libqtest.c b/

Re: [Qemu-devel] [PATCH v2 3/4] block: convert crypto driver to bdrv_co_preadv|pwritev

2017-09-12 Thread Daniel P. Berrange
On Thu, Aug 31, 2017 at 10:08:00AM -0500, Eric Blake wrote: > On 08/31/2017 06:05 AM, Daniel P. Berrange wrote: > > Make the crypto driver implement the bdrv_co_preadv|pwritev > > callbacks, and also use bdrv_co_preadv|pwritev for I/O > > with the protocol driver beneath. > > > > Signed-off-by: D

Re: [Qemu-devel] [PATCH v4] pci: Set err to errp directly rather than through error_propagate()

2017-09-12 Thread Stefan Hajnoczi
On Sat, Sep 09, 2017 at 02:22:26PM +0800, Mao Zhongyi wrote: > ioh3420_interrupts_init() pass error message to local_err, then > propagate it to errp by error_propagate(), which is not necessary. > So eliminate it and pass errp directly instead of local_err. > > Cc: "Michael S. Tsirkin" > Cc: Mar

Re: [Qemu-devel] question: qemu will crash when attach and detach a disk which configured qos for a while

2017-09-12 Thread Stefan Hajnoczi
On Mon, Sep 11, 2017 at 09:24:23AM +0800, WangJie (Captain) wrote: > Hi, I maybe find a bug about qemu-kvm(version:2.8.1.1) Can you reproduce the segfault with qemu.git/master? > *Segmentation fault info:* > Program received signal SIGSEGV, Segmentation fault. > 0x7f5469220607 in blk_has_pend

Re: [Qemu-devel] [PATCH] dump: do not dump non-existent guest memory

2017-09-12 Thread Marc-André Lureau
Hi Peter On Tue, Sep 12, 2017 at 5:33 AM, Peter Xu wrote: > On Mon, Sep 11, 2017 at 03:26:27PM +0200, Cornelia Huck wrote: >> It does not really make sense to dump memory that is not there. >> >> Moreover, that fixes a segmentation fault when calling dump-guest-memory >> with no filter for a mach

Re: [Qemu-devel] [PATCH 0/2] spapr_pci: some more cleanup

2017-09-12 Thread David Gibson
On Mon, Sep 11, 2017 at 12:13:56PM +0200, Greg Kurz wrote: > --- > > Greg Kurz (2): > spapr_pci: convert sprintf() to g_strdup_printf() > spapr_pci: don't create 64-bit MMIO window if we don't need to Applied to ppc-for-2.11. -- David Gibson| I'll have my music b

Re: [Qemu-devel] [PATCH 6/6] arm: drop intermadiate cpu_model -> cpu type parsing and use cpu type directly

2017-09-12 Thread Igor Mammedov
On Sat, 9 Sep 2017 17:30:14 -0300 Eduardo Habkost wrote: > On Tue, Sep 05, 2017 at 03:46:07PM -0700, Alistair Francis wrote: > > On Tue, Sep 5, 2017 at 3:12 PM, Eduardo Habkost > > wrote: > > > On Tue, Sep 05, 2017 at 02:47:52PM -0700, Alistair Francis wrote: > > >> On Tue, Sep 5, 2017 at 2

Re: [Qemu-devel] [PATCH 04/12] qemu-iotests: limit non-_PROG-suffixed variables to common.rc

2017-09-12 Thread Kevin Wolf
Am 09.08.2017 um 23:55 hat Paolo Bonzini geschrieben: > These are never used by "check", with one exception that does not need > $QEMU_OPTIONS. Keep them in common.rc, which will be soon included only > by the tests. > > Signed-off-by: Paolo Bonzini > diff --git a/tests/qemu-iotests/common b/te

Re: [Qemu-devel] Converting host virtual addresses to guest physical

2017-09-12 Thread Stefan Hajnoczi
On Thu, Sep 07, 2017 at 01:02:59PM +, Padmanabhan S N via Qemu-devel wrote: > I'm developing a new block backend driver. Since my Guest RAM is coming out > of shared memory (memory-backend-file,mem-path=/dev/shmem/foo), while > performing the IO I would like to pass QEMUIOVector buffers direc

Re: [Qemu-devel] [PATCH v7 29/38] libqtest: Merge qtest_init() into qtest_start()

2017-09-12 Thread Thomas Huth
On 11.09.2017 19:20, Eric Blake wrote: > Remove the trivial wrapper qtest_init(), and change qtest_start() > to no longer implicitly set global_qtest, to make it obvious in the > rest of the testsuite where we are still relying on global_qtest. > Everything now uses qtest_start() (and friends) and

Re: [Qemu-devel] [PATCH 07/12] qemu-iotests: disintegrate more parts of common.config

2017-09-12 Thread Kevin Wolf
Am 09.08.2017 um 23:55 hat Paolo Bonzini geschrieben: > Split "check" parts from tests part. > > For the directory setup, the actual computation of directories goes > in "check", while the sanity checks go in the tests. > > Signed-off-by: Paolo Bonzini Same comment as for patch 1, we may want t

Re: [Qemu-devel] [PATCH v7 30/38] qtest: Avoid passing raw strings through hmp()

2017-09-12 Thread Thomas Huth
On 11.09.2017 19:20, Eric Blake wrote: > hmp() passes its string argument through the sprintf() family; > with a proper attribute, gcc -Wformat warns us when we do something > dangerous like passing a non-constant format string. Fortunately, > all our strings were safe, but checking whether the st

Re: [Qemu-devel] [PATCH v3] spapr_cpu_core: cleaning up qdev_get_machine() calls

2017-09-12 Thread David Gibson
On Tue, Sep 12, 2017 at 08:51:21AM +0200, Greg Kurz wrote: > This patch removes the qdev_get_machine() calls that are made > in spapr_cpu_core.c in situations where we can get an existing > pointer for the MachineState by either passing it as an argument > to the function or by using other already

Re: [Qemu-devel] [PATCH v7 31/38] libqtest: Merge qtest_clock_*() with clock_*()

2017-09-12 Thread Thomas Huth
On 11.09.2017 19:20, Eric Blake wrote: > Maintaining two layers of libqtest APIs, one that takes an explicit > QTestState object, and the other that uses the implicit global_qtest, > is annoying. In the interest of getting rid of global implicit > state and having less code to maintain, merge: >

[Qemu-devel] [PATCH] scripts: let checkpatch.pl process an entire GIT branch

2017-09-12 Thread Daniel P. Berrange
Currently before submitting a series, devs should run checkpatch.pl across each patch to be submitted. This can be automated using a command such as: git rebase -i master -x 'git show | ./scripts/checkpatch.pl -' This is rather long winded to type, so this patch introduces a new flag '--branch'

Re: [Qemu-devel] [PATCH v7 32/38] libqtest: Merge qtest_irq*() with irq*()

2017-09-12 Thread Thomas Huth
On 11.09.2017 19:20, Eric Blake wrote: > Maintaining two layers of libqtest APIs, one that takes an explicit > QTestState object, and the other that uses the implicit global_qtest, > is annoying. In the interest of getting rid of global implicit > state and having less code to maintain, merge: >

Re: [Qemu-devel] Suggested Wiki Update

2017-09-12 Thread Christian Borntraeger
Looks good to me. I somehow lost my wiki password, so maybe Conny can do the update until this is fixed On 09/12/2017 10:57 AM, Viktor Mihajlovski wrote: > Hi, > > the content of https://wiki.qemu.org/index.php/Features/S390xNetworkBoot > is slightly outdated since proper DHCP based netboot s

Re: [Qemu-devel] [PATCH v7 33/38] libqtest: Merge qtest_{in, out}[bwl]() with {in, out}[bwl]()

2017-09-12 Thread Thomas Huth
On 11.09.2017 19:20, Eric Blake wrote: > Maintaining two layers of libqtest APIs, one that takes an explicit > QTestState object, and the other that uses the implicit global_qtest, > is annoying. In the interest of getting rid of global implicit > state and having less code to maintain, merge: >

Re: [Qemu-devel] [PATCH v4 15/21] s390x: print CPU definitions in sorted order

2017-09-12 Thread Christian Borntraeger
On 09/11/2017 05:21 PM, David Hildenbrand wrote: > Other architectures provide nicely sorted lists, let's do it similarly on > s390x. > > While at it, clean up the code we have to touch either way. > > Signed-off-by: David Hildenbrand looks much nicer now, with the most important ones (new ones

Re: [Qemu-devel] [PATCH 6/6] arm: drop intermadiate cpu_model -> cpu type parsing and use cpu type directly

2017-09-12 Thread Igor Mammedov
On Tue, 5 Sep 2017 19:12:26 -0300 Eduardo Habkost wrote: > On Tue, Sep 05, 2017 at 02:47:52PM -0700, Alistair Francis wrote: > > On Tue, Sep 5, 2017 at 2:31 PM, Eduardo Habkost > > wrote: > [...] > > >> diff --git a/hw/arm/stm32f205_soc.c b/hw/arm/stm32f205_soc.c > > >> index f61e735..1cd6374

Re: [Qemu-devel] [PATCH 6/6] arm: drop intermadiate cpu_model -> cpu type parsing and use cpu type directly

2017-09-12 Thread Igor Mammedov
On Tue, 5 Sep 2017 14:47:52 -0700 Alistair Francis wrote: > On Tue, Sep 5, 2017 at 2:31 PM, Eduardo Habkost wrote: > > On Mon, Sep 04, 2017 at 04:01:02PM +0200, Igor Mammedov wrote: > >> there are 2 use cases to deal with: > >> 1: fixed CPU models per board/soc > >> 2: boards with user con

Re: [Qemu-devel] Suggested Wiki Update

2017-09-12 Thread Cornelia Huck
On Tue, 12 Sep 2017 10:57:14 +0200 Viktor Mihajlovski wrote: > Hi, > > the content of https://wiki.qemu.org/index.php/Features/S390xNetworkBoot > is slightly outdated since proper DHCP based netboot support for s390x > has been implemented by the series ending with commit 29d1221. > > As it is

[Qemu-devel] question: I found a bug which will lead to qemu crash

2017-09-12 Thread WangJie (Captain)
Hi, Kevin. I found a bug about qemu-kvm(version 2.7.0-rc0 adn 2.8.1). but qemu 2.6.0 and current master is OK. So I git-bisect the master branch,and I found the patch you commited (block: Decouple throttling from BlockDriverState) lead the bug into qemu. The patch which lead the bug into qemu:

Re: [Qemu-devel] Suggested Wiki Update

2017-09-12 Thread Thomas Huth
On 12.09.2017 13:18, Cornelia Huck wrote: > On Tue, 12 Sep 2017 10:57:14 +0200 > Viktor Mihajlovski wrote: > >> Hi, >> >> the content of https://wiki.qemu.org/index.php/Features/S390xNetworkBoot >> is slightly outdated since proper DHCP based netboot support for s390x >> has been implemented by t

[Qemu-devel] [PATCH v3 0/7] Misc improvements to crypto block driver

2017-09-12 Thread Daniel P. Berrange
This is a followup to v1: https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg00781.html v2: https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg06464.html This collection of patches first improves the performance of the crypto block driver and then does various cleanups to improve

[Qemu-devel] [PATCH v3 3/7] block: fix data type casting for crypto payload offset

2017-09-12 Thread Daniel P. Berrange
The crypto APIs report the offset of the data payload as an uint64_t type, but the block driver is casting to size_t or ssize_t which will potentially truncate. Most of the block APIs use int64_t for offsets meanwhile, so even if using uint64_t in the crypto block driver we are still at risk of tr

[Qemu-devel] [PATCH v3 2/7] crypto: expose encryption sector size in APIs

2017-09-12 Thread Daniel P. Berrange
While current encryption schemes all have a fixed sector size of 512 bytes, this is not guaranteed to be the case in future. Expose the sector size in the APIs so the block layer can remove assumptions about fixed 512 byte sectors. Signed-off-by: Daniel P. Berrange --- crypto/block-luks.c|

[Qemu-devel] [PATCH v3 6/7] block: convert qcrypto_block_encrypt|decrypt to take bytes offset

2017-09-12 Thread Daniel P. Berrange
Instead of sector offset, take the bytes offset when encrypting or decrypting data. Signed-off-by: Daniel P. Berrange --- block/crypto.c | 12 block/qcow.c | 7 +-- block/qcow2-cluster.c | 8 +++- block/qcow2.c | 4 ++-- crypto/block-luks.c

[Qemu-devel] [PATCH v3 1/7] block: use 1 MB bounce buffers for crypto instead of 16KB

2017-09-12 Thread Daniel P. Berrange
Using 16KB bounce buffers creates a significant performance penalty for I/O to encrypted volumes on storage which high I/O latency (rotating rust & network drives), because it triggers lots of fairly small I/O operations. On tests with rotating rust, and cache=none|directsync, write speed increase

[Qemu-devel] [PATCH v3 5/7] block: convert crypto driver to bdrv_co_preadv|pwritev

2017-09-12 Thread Daniel P. Berrange
Make the crypto driver implement the bdrv_co_preadv|pwritev callbacks, and also use bdrv_co_preadv|pwritev for I/O with the protocol driver beneath. Signed-off-by: Daniel P. Berrange --- block/crypto.c | 104 +++-- 1 file changed, 56 insertions

[Qemu-devel] [PATCH v3 4/7] block: don't use constant 512 as sector size in crypto driver

2017-09-12 Thread Daniel P. Berrange
Use the qcrypto_block_get_sector_size() value in the block crypto driver instead of hardcoding 512 as the sector size. Signed-off-by: Daniel P. Berrange --- block/crypto.c | 34 ++ 1 file changed, 18 insertions(+), 16 deletions(-) diff --git a/block/crypto.c b/bl

[Qemu-devel] [PATCH v3 7/7] block: support passthrough of BDRV_REQ_FUA in crypto driver

2017-09-12 Thread Daniel P. Berrange
The BDRV_REQ_FUA flag can trivially be allowed in the crypt driver as a passthrough to the underlying block driver. Signed-off-by: Daniel P. Berrange --- block/crypto.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/block/crypto.c b/block/crypto.c index 1f77095336..d1

Re: [Qemu-devel] [PATCH] s390: set DHCP client architecure id for netboot

2017-09-12 Thread Cornelia Huck
On Mon, 11 Sep 2017 12:33:47 +0200 Viktor Mihajlovski wrote: > Setting the client architecture DHCP option to 0x001f (s390 Basic) [1] > allows the DHCP server to return a s390-specific bootfile if wanted. > DHCP servers not configured for the option (or not yet recognizing the > option value) wil

Re: [Qemu-devel] [PATCH for-2.10] qemu-options: Document the -drive locking parameter.

2017-09-12 Thread Kevin Wolf
Am 12.09.2017 um 11:45 hat Richard W.M. Jones geschrieben: > On Wed, Sep 06, 2017 at 01:38:45PM +0200, Kevin Wolf wrote: > > This command line fragment looks correct to me. For me, it seems to > > work. I'm starting a first qemu in the background with default locking > > options: > > > > $ x86

Re: [Qemu-devel] question: I found a bug which will lead to qemu crash

2017-09-12 Thread Kevin Wolf
Am 12.09.2017 um 13:17 hat WangJie (Captain) geschrieben: > Hi, Kevin. > > I found a bug about qemu-kvm(version 2.7.0-rc0 adn 2.8.1). but qemu 2.6.0 and > current master is OK. > So I git-bisect the master branch,and I found the patch you commited (block: > Decouple throttling from BlockDriverSt

Re: [Qemu-devel] [PATCH for-2.10] qemu-options: Document the -drive locking parameter.

2017-09-12 Thread Richard W.M. Jones
On Tue, Sep 12, 2017 at 01:32:05PM +0200, Kevin Wolf wrote: > Am 12.09.2017 um 11:45 hat Richard W.M. Jones geschrieben: > > On Wed, Sep 06, 2017 at 01:38:45PM +0200, Kevin Wolf wrote: > > > This command line fragment looks correct to me. For me, it seems to > > > work. I'm starting a first qemu in

Re: [Qemu-devel] [PATCH v2] Replace round_page() with TARGET_PAGE_ALIGN()

2017-09-12 Thread Thomas Huth
On 11.09.2017 22:16, Kamil Rytarowski wrote: > This change fixes conflict with the DragonFly BSD headers. > > Signed-off-by: Kamil Rytarowski > --- > hw/ppc/mac_newworld.c | 11 +++ > hw/ppc/mac_oldworld.c | 11 +++ > 2 files changed, 6 insertions(+), 16 deletions(-) > > diff --

Re: [Qemu-devel] Suggested Wiki Update

2017-09-12 Thread Viktor Mihajlovski
On 12.09.2017 13:25, Thomas Huth wrote: > On 12.09.2017 13:18, Cornelia Huck wrote: [...] >> >> Looks good. >> >> Can you perhaps add a sentence that the base support is available with >> 2.9 and netboot with 2.10? ('Overview' looks like a good place for >> that.) > > FWIW, I think it would also b

Re: [Qemu-devel] question: I found a bug which will lead to qemu crash

2017-09-12 Thread Alberto Garcia
On Tue 12 Sep 2017 01:17:38 PM CEST, WangJie (Captain) wrote: > Hi, Kevin. > > I found a bug about qemu-kvm(version 2.7.0-rc0 adn 2.8.1). but qemu 2.6.0 and > current master is OK. > So I git-bisect the master branch,and I found the patch you commited (block: > Decouple throttling from BlockDrive

Re: [Qemu-devel] [PATCH 6/6] arm: drop intermadiate cpu_model -> cpu type parsing and use cpu type directly

2017-09-12 Thread Eduardo Habkost
On Tue, Sep 12, 2017 at 12:22:14PM +0200, Igor Mammedov wrote: > On Sat, 9 Sep 2017 17:30:14 -0300 > Eduardo Habkost wrote: > > > On Tue, Sep 05, 2017 at 03:46:07PM -0700, Alistair Francis wrote: > > > On Tue, Sep 5, 2017 at 3:12 PM, Eduardo Habkost > > > wrote: > > > > On Tue, Sep 05, 2017 a

Re: [Qemu-devel] [PATCH 6/6] arm: drop intermadiate cpu_model -> cpu type parsing and use cpu type directly

2017-09-12 Thread Eduardo Habkost
On Tue, Sep 12, 2017 at 01:02:35PM +0200, Igor Mammedov wrote: > On Tue, 5 Sep 2017 14:47:52 -0700 > Alistair Francis wrote: > > > On Tue, Sep 5, 2017 at 2:31 PM, Eduardo Habkost wrote: > > > On Mon, Sep 04, 2017 at 04:01:02PM +0200, Igor Mammedov wrote: > > >> there are 2 use cases to deal wi

Re: [Qemu-devel] [PATCH v3 5/7] block: convert crypto driver to bdrv_co_preadv|pwritev

2017-09-12 Thread Daniel P. Berrange
On Tue, Sep 12, 2017 at 12:28:53PM +0100, Daniel P. Berrange wrote: > Make the crypto driver implement the bdrv_co_preadv|pwritev > callbacks, and also use bdrv_co_preadv|pwritev for I/O > with the protocol driver beneath. > > Signed-off-by: Daniel P. Berrange > --- > block/crypto.c | 104 > +++

Re: [Qemu-devel] [PATCH 6/6] arm: drop intermadiate cpu_model -> cpu type parsing and use cpu type directly

2017-09-12 Thread Igor Mammedov
On Tue, 5 Sep 2017 18:31:52 -0300 Eduardo Habkost wrote: > On Mon, Sep 04, 2017 at 04:01:02PM +0200, Igor Mammedov wrote: > > there are 2 use cases to deal with: > > 1: fixed CPU models per board/soc > > 2: boards with user configurable cpu_model and fallback to > > default cpu_model if

Re: [Qemu-devel] [Qemu-arm] [PATCH v2 3/3] tests/hmp: test "none" machine with memory

2017-09-12 Thread Philippe Mathieu-Daudé
On 09/11/2017 11:20 AM, Laurent Vivier wrote: and add a test case of dump-guest-memory without "[begin length]" parameters. Signed-off-by: Laurent Vivier --- tests/test-hmp.c | 5 + 1 file changed, 5 insertions(+) diff --git a/tests/test-hmp.c b/tests/test-hmp.c index 729c0339f7..90693c

Re: [Qemu-devel] [PATCH for-2.10] qemu-options: Document the -drive locking parameter.

2017-09-12 Thread Kevin Wolf
Am 12.09.2017 um 13:43 hat Richard W.M. Jones geschrieben: > On Tue, Sep 12, 2017 at 01:32:05PM +0200, Kevin Wolf wrote: > > Am 12.09.2017 um 11:45 hat Richard W.M. Jones geschrieben: > > > On Wed, Sep 06, 2017 at 01:38:45PM +0200, Kevin Wolf wrote: > > > > This command line fragment looks correct

Re: [Qemu-devel] [PATCH 01/27] glib-compat: move G_SOURCE_CONTINUE/REMOVE there

2017-09-12 Thread Philippe Mathieu-Daudé
On 08/23/2017 01:19 PM, Marc-André Lureau wrote: Signed-off-by: Marc-André Lureau Acked-by: Philippe Mathieu-Daudé --- include/glib-compat.h | 7 +++ contrib/vhost-user-scsi/vhost-user-scsi.c | 8 2 files changed, 7 insertions(+), 8 deletions(-) diff --

Re: [Qemu-devel] [PATCH 02/27] libvhost-user: drop dependency on glib

2017-09-12 Thread Philippe Mathieu-Daudé
Hi Marc-André, On 08/23/2017 01:19 PM, Marc-André Lureau wrote: libvhost-user is meant to be free of glib dependency. Make sure it is by droping qemu/osdep.h (which included glib.h) This fixes a bad malloc()/g_free() pair. Signed-off-by: Marc-André Lureau --- contrib/libvhost-user/libvhost-

Re: [Qemu-devel] [PATCH 04/12] qemu-iotests: limit non-_PROG-suffixed variables to common.rc

2017-09-12 Thread Paolo Bonzini
On 12/09/2017 12:31, Kevin Wolf wrote: > Hm, does this mean that instead of ./check failing when a binary is > missing, we try each test case now and each one fails with the same > error message? > > *tries it out* > > Okay, it's already broken today because the strings are never empty but > cont

Re: [Qemu-devel] [PATCH 07/12] qemu-iotests: disintegrate more parts of common.config

2017-09-12 Thread Paolo Bonzini
On 12/09/2017 12:40, Kevin Wolf wrote: > Am 09.08.2017 um 23:55 hat Paolo Bonzini geschrieben: >> Split "check" parts from tests part. >> >> For the directory setup, the actual computation of directories goes >> in "check", while the sanity checks go in the tests. >> >> Signed-off-by: Paolo Bonzini

[Qemu-devel] [PATCH v5 00/12] Convert over to use keycodemapdb

2017-09-12 Thread Daniel P. Berrange
An update of: v1: https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg02047.html v2: https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg02471.html v3: https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg02517.html v4: https://lists.gnu.org/archive/html/qemu-devel/2017-08/ms

[Qemu-devel] [PATCH v5 03/12] ui: convert key events to QKeyCodes immediately

2017-09-12 Thread Daniel P. Berrange
Always use QKeyCode in the InputKeyEvent struct, by converting key numbers to QKeyCode at the time the event is created. Signed-off-by: Daniel P. Berrange --- ui/input.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/ui/input.c b/ui/input.c index 3422d4a8ef..9914daf0b4

[Qemu-devel] [PATCH v5 01/12] ui: add keycodemapdb repository as a GIT submodule

2017-09-12 Thread Daniel P. Berrange
The https://gitlab.com/keycodemap/keycodemapdb/ repo contains a data file mapping between all the different scancode/keycode/keysym sets that are known, and a tool to auto-generate lookup tables for different combinations. It is used by GTK-VNC, SPICE-GTK and libvirt for mapping keys. Using it in

[Qemu-devel] [PATCH v5 12/12] display: convert XenInput keyboard to keycodemapdb

2017-09-12 Thread Daniel P. Berrange
Replace the scancode2linux table with an automatically generated table. In doing so, the XenFB keyboard handler is also converted to the modern InputEvent framework. Signed-off-by: Daniel P. Berrange --- hw/display/xenfb.c | 133 - 1 file chang

[Qemu-devel] [PATCH v5 07/12] input: convert the adb device to keycodemapdb

2017-09-12 Thread Daniel P. Berrange
Replace the qcode_to_adb_keycode table with automatically generated tables. Missing entries in qcode_to_adb_keycode now fixed: - Q_KEY_CODE_KP_COMMA -> 0x47 Signed-off-by: Daniel P. Berrange --- hw/input/adb.c | 124 +--- include/hw/input/adb-keys.h

[Qemu-devel] [PATCH v5 08/12] char: convert the escc device to keycodemapdb

2017-09-12 Thread Daniel P. Berrange
Replace the qcode_to_keycode table with automatically generated tables. Missing entries in qcode_to_keycode now fixed: - Q_KEY_CODE_KP_COMMA -> 0x2d Signed-off-by: Daniel P. Berrange --- hw/char/escc.c | 126 +++-- include/ui/input.h | 3 +

[Qemu-devel] [PATCH v5 04/12] ui: don't export qemu_input_event_new_key

2017-09-12 Thread Daniel P. Berrange
All public code should use qemu_input_event_send_key* functions instead of creating an event directly. Signed-off-by: Daniel P. Berrange --- include/ui/input.h | 1 - ui/input.c | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/include/ui/input.h b/include/ui/input.h

[Qemu-devel] [PATCH v5 10/12] ui: convert the SDL2 frontend to keycodemapdb

2017-09-12 Thread Daniel P. Berrange
The SDL2 scancodes are conveniently identical to the USB scancodes. Replace the sdl2_scancode_to_qcode table with an automatically generated table. Missing entries in sdl2_scancode_to_qcode now fixed: - 0x32 -> Q_KEY_CODE_BACKSLASH - 0x66 -> Q_KEY_CODE_POWER - 0x67 -> Q_KEY_CODE_KP_EQUALS

[Qemu-devel] [PATCH v5 05/12] input: convert virtio-input-hid device to keycodemapdb

2017-09-12 Thread Daniel P. Berrange
Replace the keymap_qcode table with automatically generated tables. Missing entries in keymap_qcode now fixed: Q_KEY_CODE_ASTERISK -> KEY_KPASTERISK Q_KEY_CODE_KP_MULTIPLY -> KEY_KPASTERISK Q_KEY_CODE_STOP -> KEY_STOP Q_KEY_CODE_AGAIN -> KEY_AGAIN Q_KEY_CODE_PROPS -> KEY_PROPS Q_KEY_C

[Qemu-devel] [PATCH v5 09/12] ui: convert cocoa frontend to keycodemapdb

2017-09-12 Thread Daniel P. Berrange
Replace the mac_to_qkeycode_map table with automatically generated table. Signed-off-by: Daniel P. Berrange --- include/ui/input.h | 3 + ui/Makefile.objs | 1 + ui/cocoa.m | 129 + ui/input-keymap-osx-to-q

[Qemu-devel] [PATCH v5 02/12] ui: convert common input code to keycodemapdb

2017-09-12 Thread Daniel P. Berrange
Replace the number_to_qcode, qcode_to_number and linux_to_qcode tables with automatically generated tables. Missing entries in linux_to_qcode now fixed: KEY_LINEFEED -> Q_KEY_CODE_LF KEY_KPEQUAL -> Q_KEY_CODE_KP_EQUALS KEY_COMPOSE -> Q_KEY_CODE_COMPOSE KEY_AGAIN -> Q_KEY_CODE_AGAIN KEY_

Re: [Qemu-devel] [PATCH v5 05/12] input: convert virtio-input-hid device to keycodemapdb

2017-09-12 Thread Daniel P. Berrange
On Tue, Sep 12, 2017 at 01:37:37PM +0100, Daniel P. Berrange wrote: > Replace the keymap_qcode table with automatically generated > tables. > > Missing entries in keymap_qcode now fixed: > > Q_KEY_CODE_ASTERISK -> KEY_KPASTERISK > Q_KEY_CODE_KP_MULTIPLY -> KEY_KPASTERISK > Q_KEY_CODE_STOP -

[Qemu-devel] [PATCH v5 06/12] input: convert ps2 device to keycodemapdb

2017-09-12 Thread Daniel P. Berrange
Replace the qcode_to_keycode_set1, qcode_to_keycode_set2, and qcode_to_keycode_set3 tables with automatically generated tables. Missing entries in qcode_to_keycode_set1 now fixed: - Q_KEY_CODE_SYSRQ -> 0x54 - Q_KEY_CODE_PRINT -> 0x54 (NB ignored due to special case) - Q_KEY_CODE_AGAIN -> 0xe00

Re: [Qemu-devel] [PATCH] i386/cpu/hyperv: support over 64 vcpus for windows guests

2017-09-12 Thread Gonglei (Arei)
> > On 12/09/2017 03:41, Gonglei (Arei) wrote: > > > >> -Original Message- > >> From: Eduardo Habkost [mailto:ehabk...@redhat.com] > >> Sent: Tuesday, September 12, 2017 2:38 AM > >> To: Gonglei (Arei) > >> Cc: qemu-devel@nongnu.org; m...@redhat.com; pbonz...@redhat.com; > >> r...@twiddle.

  1   2   3   4   >