re a few other things that can cause us to terminate
> - the TB in the middel of an IT block:
> + the TB in the middle of an IT block:
> - Exception generating instructions (bkpt, swi, undefined).
> - Page boundaries.
> -
Am 06.08.2012 15:11, schrieb Stefan Hajnoczi:
> On Mon, Aug 6, 2012 at 1:49 PM, Avi Kivity wrote:
>> The scsi passthrough handler falls through after completing a
>> request into the failure path, resulting in a use after free.
>>
>> Reprducible by running a guest with aio=native on a block device
Am 07.08.2012 14:19, schrieb Christian Borntraeger:
> From: Eugene Dvurechenski
>
> on s390 there is no usb support and the -usb option doesnt
> do anything.
> This patch fences all usb code for s390.
>
> Signed-off-by: Eugene Dvurechenski
> Signed-off-by: Christian Borntraeger
> ---
> config
Am 07.08.2012 15:03, schrieb Pavel Hrdina:
> Signed-off-by: Pavel Hrdina
This is in need of a more detailed commit message: What exactly is this
fixing? Or is this a preparation for a particular new command?
Andreas
> ---
> monitor.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a
Hi Jason,
Am 07.08.2012 18:01, schrieb Jason Baron:
> Hi,
>
> vmstate_ahci has its 'unmigratable' bit set. Gerd suggested that there was
> work
> in this area. Anybody know the status on it?
That was me working on it. I have a branch corresponding to an RFC I
sent around Christmas - issue being
Am 07.08.2012 21:26, schrieb Markus Armbruster:
> Very basic smoke test: start QEMU with -monitor stdio, quit immediately.
[...]
> Summary of results:
>
> * Bad unexplained
[...]
> qemu-system-ppc64 prep
> qemu: hardware error: Unknown device 'i82378' for bus 'PCI'
This is an untested con
Am 08.08.2012 00:02, schrieb Benjamin Herrenschmidt:
> On Fri, 2012-08-03 at 17:01 +0200, Andreas Färber wrote:
>>
>> I have posted a suggestion where CPU reset is triggered by "the
>> machine
>> as an abstract concept" (needs a bit of tweaking still, but the
&
Am 08.08.2012 14:39, schrieb Paolo Bonzini:
> Il 08/08/2012 14:22, Michael Tokarev ha scritto:
>> [...] should there be a call to object_unref()
>> somewhere?
>
> There should be a call to object_unparent() somewhere actually.
> We've been peppering the code with them for a few months now while
>
Am 08.08.2012 03:45, schrieb David Gibson:
> On Wed, Aug 08, 2012 at 12:32:39AM +0200, Andreas Färber wrote:
>> Am 08.08.2012 00:02, schrieb Benjamin Herrenschmidt:
>>> On Fri, 2012-08-03 at 17:01 +0200, Andreas Färber wrote:
>>>>
>>>> I have posted a
Am 31.01.2012 15:01, schrieb Mitsyanko Igor:
> On 01/31/2012 05:15 PM, Andreas Färber wrote:
>> Am 31.01.2012 00:53, schrieb Anthony Liguori:
>>> On 01/30/2012 05:41 PM, Andreas Färber wrote:
>>>> Am 30.01.2012 19:55, schrieb Juan Quintela:
>>>>> Pleas
Am 07.08.2012 18:20, schrieb Jason Baron:
> On Tue, Aug 07, 2012 at 06:13:25PM +0200, Andreas Färber wrote:
>> Hi Jason,
>>
>> Am 07.08.2012 18:01, schrieb Jason Baron:
>>> Hi,
>>>
>>> vmstate_ahci has its 'unmigratable' bit set. Gerd su
-off-by: Andreas Färber
Cc: Alexander Graf
Cc: Jason Baron
Cc: Kevin Wolf
Cc: Juan Quintela
Cc: Igor Mitsyanko
---
hw/ide/ahci.c | 46 +-
hw/ide/ahci.h | 12 +++-
hw/ide/ich.c | 11 ---
3 files changed, 64 insertions(+), 5
Am 09.08.2012 15:31, schrieb Markus Armbruster:
> Cc: Alexander Graf
> Cc: Andreas Färber
> Cc: qemu-...@nongnu.org
>
> Suppress default floppy drive for machines ref405ep, taihu, bamboo,
> mac99, g3beige, virtex-ml507.
>
> Suppress default CD-ROM drive for machines
Am 02.08.2012 10:30, schrieb Michael S. Tsirkin:
> On Thu, Aug 02, 2012 at 03:46:52AM +0200, Andreas Färber wrote:
>> Hello Anthony and Michael,
>>
>> Here's a fixed version of the series making pci_host a first-class QOM type.
>>
>> MAINTAINERS entries
r interface for this.
>
> Signed-off-by: Igor Mammedov
FWIW,
Reviewed-by: Andreas Färber
/-F
> ---
> target-i386/helper.c |7 +--
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/target-i386/helper.c b/target-i386/helper.c
> index 2cc8
Am 08.08.2012 13:28, schrieb Igor Mammedov:
> ping
FWIW it looks to me as if Jan's previous review comments regarding
debug_excp_helper have been addressed. So if someone could take a look
at patch 3/4 and ack that we don't need chaining of handlers, this
should be good to go for 1.2.
Andreas
>
Am 27.07.2012 19:00, schrieb Andreas Färber:
> Am 12.06.2012 10:24, schrieb Andreas Färber:
>> Am 29.05.2012 15:35, schrieb Stefano Stabellini:
>>> qemu_rearm_alarm_timer partially duplicates the code in
>>> qemu_next_alarm_deadline to figure out if it needs to rearm
ated directly by qemu rather than
> by executing a firmware image within the guest. When the platform's
> firmware to OS interface is sufficiently well specified, this saves
> time both in implementing the "firmware" and executing it.
>
> Signed-off-by: David Gibson
Rev
Am 09.08.2012 22:36, schrieb Peter Maydell:
> On 9 August 2012 21:01, Phil Staub wrote:
>> On 08/09/2012 12:57 PM, Blue Swirl wrote:
>>> On Tue, Aug 7, 2012 at 12:10 PM, Peter Maydell
>>> wrote:
For this purpose the usual approach is to follow up to the patch
mail saying "Ping" and givi
Am 10.08.2012 03:27, schrieb Peter A. G. Crosthwaite:
> A -kernel argument must be specified for this machine. Gaurd against no
> -kernel
"Guard"
> argument. Previously gave an unhelpful "bad address" error message.
>
> Signed-off-by: Peter A. G. Crosthwaite
Otherwise looks good - PMM, can yo
Am 10.08.2012 11:00, schrieb Peter Maydell:
> On 10 August 2012 09:48, Andreas Färber wrote:
>> Actually there were better patches for the same bug by Meador, including
>> git-style rather than SVN patches and adding a helper to initialize it
>> consistently at all call site
Am 10.08.2012 05:16, schrieb Peter A. G. Crosthwaite:
> From: Anthony Liguori
>
> The current implementation of Interfaces is poorly designed. Each interface
> that an object implements ends up being an object that's tracked by the
> implementing object. There's all sorts of gymnastics to deal
Am 10.08.2012 13:22, schrieb Igor Mammedov:
> Signed-off-by: Igor Mammedov
Acked-by: Andreas Färber
/-F
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
Am 10.08.2012 13:22, schrieb Igor Mammedov:
> Signed-off-by: Igor Mammedov
> ---
> qapi/qapi-visit-core.c | 11 +++
> qapi/qapi-visit-core.h | 2 ++
> qapi/string-input-visitor.c | 22 ++
> 3 files changed, 35 insertions(+)
>
> diff --git a/qapi/qapi-visit-
Hello Maciej,
Am 10.08.2012 15:15, schrieb Maciej W. Rozycki:
Actually there were better patches for the same bug by Meador, including
git-style rather than SVN patches and adding a helper to initialize it
consistently at all call sites.
>
> I find quilt patches easier to manage w
Am 02.08.2012 15:48, schrieb Peter Maydell:
> On 2 August 2012 02:16, Andreas Färber wrote:
>> +hw-obj-$(CONFIG_STELLARIS_ENET) += stellaris_enet.o
>
> Why just this stellaris device and not the others?
So, turns out there was an actual reason:
CClibhw64/hw/stellaris.o
I
Avoids some unnecessary dependencies on cpu.h and prepares for
a future armeb-softmmu where most machines would not be built.
Defer touching the SoC devices since most have implicit or explicit
dependencies on the CPU.
Signed-off-by: Andreas Färber
---
default-configs/arm-softmmu.mak | 18
Am 13.08.2012 14:11, schrieb Andreas Färber:
> Avoids some unnecessary dependencies on cpu.h and prepares for
> a future armeb-softmmu where most machines would not be built.
>
> Defer touching the SoC devices since most have implicit or explicit
> dependencies on the CPU.
>
Am 09.08.2012 17:09, schrieb Andreas Färber:
> Am 02.08.2012 10:30, schrieb Michael S. Tsirkin:
>> On Thu, Aug 02, 2012 at 03:46:52AM +0200, Andreas Färber wrote:
>>> Here's a fixed version of the series making pci_host a first-class QOM type.
>>>
>>>
Am 13.08.2012 15:14, schrieb Anthony Liguori:
> Andreas Färber writes:
>
>> diff --git a/hw/spapr_pci.c b/hw/spapr_pci.c
>> index df70cd2..8937030 100644
>> --- a/hw/spapr_pci.c
>> +++ b/hw/spapr_pci.c
>> @@ -36,16 +36,18 @@ static PCIDevi
Introduce type constant and cast macro. Don't access DeviceState
or PCIHostState indirectly through parent fields.
Signed-off-by: Andreas Färber
Acked-by: Michael S. Tsirkin
---
hw/alpha_typhoon.c | 20 +---
1 files changed, 13 insertions(+), 7 deletions(-)
diff --git
Adopt the QOM parent field name and enforce QOM-style access via casts.
Don't just typedef PCIHostState, either use it directly or embed it.
Signed-off-by: Andreas Färber
---
hw/alpha_typhoon.c |2 +-
hw/dec_pci.c |2 +-
hw/grackle_pci.c |2 +-
hw/gt64xxx.c |
Use PCIHostState and PCI_HOST_BRIDGE() where appropriate.
Signed-off-by: Andreas Färber
---
hw/alpha_typhoon.c |4 ++--
hw/bonito.c| 22 +++---
hw/dec_pci.c |4 ++--
hw/grackle_pci.c |6 +++---
hw/gt64xxx.c |4 ++--
hw/piix_pci.c
During the QOM migration they were amended with further info but this is
no longer the case. All static TypeInfos can be const these days.
Signed-off-by: Andreas Färber
Acked-by: Michael S. Tsirkin
---
hw/alpha_typhoon.c |2 +-
hw/bonito.c|4 ++--
hw/dec_pci.c |6
Introduce type constants and cast macros.
Avoid accessing parent fields directly.
Signed-off-by: Andreas Färber
Acked-by: Michael S. Tsirkin
---
hw/unin_pci.c | 133 ++---
1 files changed, 70 insertions(+), 63 deletions(-)
diff --git a/hw
From: Andreas Färber
The preceding commits fixed misuses of FROM_SYSBUS() that led people to
add a bogus busdev field. For qdev the field order was less relevant but
for QOM the PCIHostState field (including the SysBusDevice actually
initialized with a value) must be placed first within the
Introduce type constant and cast macro. Avoid accessing parent fields
directly.
Signed-off-by: Andreas Färber
Acked-by: Michael S. Tsirkin
---
hw/ppce500_pci.c | 16 +++-
1 files changed, 11 insertions(+), 5 deletions(-)
diff --git a/hw/ppce500_pci.c b/hw/ppce500_pci.c
index
Hej Edgar,
Am 13.08.2012 11:41, schrieb Edgar E. Iglesias:
> On Fri, Aug 10, 2012 at 01:16:09PM +1000, Peter A. G. Crosthwaite wrote:
>> The following changes since commit 3d1d9652978ac5a32a0beb4bdf6065ca39440d89:
>> Bruce Rogers (1):
>> handle device help before accelerator set up
>>
>>
o PCI_HOST_BRIDGE, suggested by mst.
* Split off const changes to clarify the name/parent changes.
* Split off cleanups per host bridge.
* Prepared and enforced QOM-style field access through explicit types.
v1 -> v2:
* Converted remaining PCI host bridges to new type.
Andreas Färbe
Introduce type constant. Introduce cast macro to drop dummy busdev field
used with FROM_SYSBUS() macro that would've broken SYS_BUS_DEVICE().
Avoid accessing DeviceState indirectly through PCIHostState.
Signed-off-by: Andreas Färber
Acked-by: Michael S. Tsirkin
---
hw/gt64xxx.c |
Introduce type constant. Introduce cast macro and drop dummy busdev
field used with FROM_SYSBUS() that would've broken SYS_BUS_DEVICE().
Avoid accessing parent fields directly.
Signed-off-by: Andreas Färber
Acked-by: Michael S. Tsirkin
---
hw/dec_pci.c | 21 +++-
Introduce type constant and cast macro. Avoid accessing parent fields
directly.
Also add missing space and braces.
Signed-off-by: Andreas Färber
Acked-by: Michael S. Tsirkin
---
hw/prep_pci.c | 17 -
1 files changed, 12 insertions(+), 5 deletions(-)
diff --git a/hw
Introduce type constant and cast macro. Avoid accessing its parent field
directly.
Signed-off-by: Andreas Färber
Acked-by: Michael S. Tsirkin
---
hw/ppc440_bamboo.c |3 ++-
hw/ppc4xx.h|2 ++
hw/ppc4xx_pci.c| 13 -
3 files changed, 12 insertions(+), 6 deletions
Introduce type constant. Introduce cast macro to drop bogus busdev field
that would've broken SYS_BUS_DEVICE(). Avoid accessing parent fields
directly.
Free the identifier phb as acronym for PCI_HOST_BRIDGE.
Signed-off-by: Andreas Färber
---
hw/spapr_pci.c |
Introduce type constant. Introduce cast macro to drop dummy busdev field
used with FROM_SYSBUS() that would've broken SYS_BUS_DEVICE().
Avoid accessing parent fields directly.
Drop no-op reset function.
Signed-off-by: Andreas Färber
Acked-by: Michael S. Tsirkin
---
hw/grackle_pci.c |
Introduce type constant. Avoid accessing DeviceState or SysBusDevice
indirectly through PCIHostState field.
Drop global state by passing BonitoState as opaque and adding the IRQs
and a pointer to PCIBonitoState to its state.
Signed-off-by: Andreas Färber
Acked-by: Michael S. Tsirkin
---
hw
Am 13.08.2012 12:27, schrieb Wenchao Xia:
> 于 2012-8-10 18:48, Paolo Bonzini 写道:
>> Il 09/08/2012 12:12, Wenchao Xia ha scritto:
>>> +assert(0 == set_option_parameter_int(param,
>>> +BLOCK_OPT_SIZE, o_cow->virt_size));
>>
>> Assertions should not have side ef
> a change introduced by this patch -- they were broken before; I've
> merely added a comment noting the fact and the workaround...
Reviewed-by: Andreas Färber
Looks okay as far as I can see. We should probably do the __APPLE__ ->
Darwin dance as a followup (ignoring the iOS, which can
Am 14.08.2012 16:13, schrieb Alejandro Martinez Ruiz:
> Signed-off-by: Alejandro Martinez Ruiz
> ---
> hw/usb/hcd-ehci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Andreas Färber
Patch looks like a sensible bugfix for 1.2, we most likely don't intend
Am 15.08.2012 11:58, schrieb Alexander Graf:
> From: Alexey Kardashevskiy
>
> The PCIHostState struct already contains SysBusDevice so
> the one in sPAPRPHBState has to go.
>
> Signed-off-by: Alexey Kardashevskiy
> Signed-off-by: Alexander Graf
As mentioned, this patch conflicts with my spapr
Hi,
Am 15.08.2012 08:33, schrieb Steven:
> I would like to trace the guest physical address of the load
> instructions from the guest. I thought the cpu_A0 is the memory
> address to be accessed. However, when I print out the value of cpu_A0,
> like
>
> static inline void gen_op_ld_v(int idx, TCG
Am 15.08.2012 14:30, schrieb Markus Armbruster:
> Alexander Graf writes:
>
>> On 09.08.2012, at 16:54, Markus Armbruster wrote:
>>
>>> Andreas Färber writes:
>>>
>>>> Am 09.08.2012 15:31, schrieb Markus Armbruster:
>>>>> diff --
y.
Signed-off-by: Hervé Poussineau
[AF: Use TYPE_PC87312 constant, add to ppc64-softmmu and to MAINTAINERS]
Signed-off-by: Andreas Färber
---
MAINTAINERS |1 +
default-configs/ppc-softmmu.mak |2 +
default-configs/ppc64-softmmu.mak |2 +
hw/
al device, empty char device" error by creating
char devs if absent, so that the 'prep' machine still works out of the box.
Andreas Färber (1):
prep: Include devices for ppc64 as well
Hervé Poussineau (2):
prep: Add pc87312 Super I/O emulation
prep: Use pc87312 device
From: Hervé Poussineau
This provides floppy and IDE controllers as well as serial and parallel
ports. However, dynamic configuration of devices is not yet supported.
Signed-off-by: Hervé Poussineau
[AF: QOM'ify, split out header, create CharDriverState if absent]
Signed-off-by: Andreas F
Allows running qemu-system-ppc64 -M prep for consistency.
Signed-off-by: Andreas Färber
Cc: Markus Armbruster
Cc: Alexander Graf
---
default-configs/ppc64-softmmu.mak |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/default-configs/ppc64-softmmu.mak
b/default
Am 11.08.2012 23:34, schrieb Peter Maydell:
> MacOSX 10.8 ("Mountain Lion") requires us to compile our one
> Objective-C source file with clang even if the rest of QEMU
> requires a real gcc, because the system headers we use make
> use of Apple's "Blocks" extension to C/ObjC, and mainline
> gcc do
Am 15.08.2012 16:31, schrieb Alexander Graf:
>
> On 15.08.2012, at 16:24, Andreas Färber wrote:
>
>> Since this only affects the PReP machine and has mostly been around for a
>> while,
>> I feel this is still acceptable for v1.2 at this late stage unless Alex
>
Hi,
Am 15.08.2012 16:22, schrieb anth...@codemonkey.ws:
> If there are existing patches and/or pull requests on the mailing list
> that you think should be in 1.2, please respond to the email with a
> pointer to the mail.
pci_host series v6 please:
http://www.mail-archive.com/qemu-devel@nongnu.or
about CharDriverState
> and friends.
>
> We can solve this for now by splitting out qdev.h along the same lines that we
> previously split the C file. Then cpu.h just needs to include qdev-core.h
>
> Signed-off-by: Anthony Liguori
> Signed-off-by: Anthony Liguori
Reviewed
Am 10.08.2012 19:00, schrieb Anthony Liguori:
> The line between linux-user and softmmu is not very well defined right now.
> linux-user really don't want to include devices and making CpuState a child of
> DeviceState would require pulling lots of stuff into linux-user.
>
> To solve this, we simp
Am 10.08.2012 19:00, schrieb Anthony Liguori:
> This is just a rebase of this series that I posted back in June.
>
> Andreas had a different approach involving a #define but I think doing a full
> split ends up being nicer. For instance, the recently added thread
> information
> is only relevant
Am 15.08.2012 16:55, schrieb Peter Maydell:
> On 15 August 2012 15:47, Andreas Färber wrote:
>> Am 11.08.2012 23:34, schrieb Peter Maydell:
>>> +# Default objcc to clang if available, otherwise use CC
>>> +if has clang; then
>>> + objcc=clang
>>
>&g
Am 15.08.2012 18:13, schrieb Igor Mammedov:
> Signed-off-by: Igor Mammedov
> --
> v2:
> * replaced _hz suffix for frequency visitor by _freq suffix
> suggested-by: Andreas Färber
> * fixed typo, spotted-by: Andreas Färber
> ---
> qapi/qapi-visit-core.c | 11
Am 15.08.2012 11:58, schrieb Alexander Graf:
> From: Alexey Kardashevskiy
>
> This patch implements MSI and MSI-X support for the pseries PCI host
> bridge. To do this it adds:
>
> * A "config_space_address to msi_table" map, since the MSI RTAS calls
> take a PCI config space address as an ide
y.
Signed-off-by: Hervé Poussineau
[AF: Use TYPE_PC87312 constant, add to ppc64-softmmu and to MAINTAINERS]
Signed-off-by: Andreas Färber
---
MAINTAINERS |1 +
default-configs/ppc-softmmu.mak |2 +
default-configs/ppc64-softmmu.mak |2 +
hw/
The following changes since commit 76b64a7aa84965ee9c7594058a43b00c2a14c72e:
win32: provide separate macros for weak decls and definitions (2012-08-15
13:26:03 -0500)
are available in the git repository at:
git://repo.or.cz/qemu/afaerber.git prep-up
Andreas Färber (1):
prep: Include de
Allows running qemu-system-ppc64 -M prep for consistency.
Reported-by: Markus Armbruster
Signed-off-by: Andreas Färber
Acked-by: Hervé Poussineau
---
default-configs/ppc64-softmmu.mak |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/default-configs/ppc64-softmmu.mak
From: Hervé Poussineau
This provides floppy and IDE controllers as well as serial and parallel
ports. However, dynamic configuration of devices is not yet supported.
Signed-off-by: Hervé Poussineau
[AF: QOM'ify, split out header, create CharDriverState if absent]
Signed-off-by: Andreas F
Am 15.08.2012 22:27, schrieb Andreas Färber:
> Hello Anthony,
>
> Please pull the PowerPC Reference Platform (PReP) queue into qemu.git master.
>
> With Alex' and Hervé's blessing this contains both fixes for runtime errors
> trying to use -M prep on qemu-system-ppc6
Am 16.08.2012 15:32, schrieb Stefan Hajnoczi:
> On Thu, Aug 16, 2012 at 03:12:21PM +0200, Stefan Weil wrote:
>> Macro XEN_HOST_PCI_RESOURCE_BUFFER_SIZE is only used locally,
>> so the change should be safe.
>>
>> Signed-off-by: Stefan Weil
>> ---
>> hw/xen-host-pci-device.c |6 +++---
>> 1 fi
Am 06.06.2012 23:11, schrieb Michael Tokarev:
> Commit 7b93fadf3a38d1ed65ea5536a52efc2772c6e3b8 "Add basic version
> of bridge helper" put the bridge helper executable into a fixed
> ${prefix}/libexec/ location, instead of using ${libexecdir} for
> this. At the same time, --libexecdir is being hap
Am 17.08.2012 15:35, schrieb Jim Meyering:
> Jim Meyering wrote:
>> From: Jim Meyering
>>
>> Without this, envlist_to_environ may silently fail to copy all
>> strings into the destination buffer, and both callers would leak
>> any env strings allocated after a failing strdup, because the
>> freein
Am 22.05.2012 12:16, schrieb Jim Meyering:
> From: Jim Meyering
>
>
> Signed-off-by: Jim Meyering
> ---
> envlist.c | 256
> +++---
> 1 file changed, 128 insertions(+), 128 deletions(-)
>
> diff --git a/envlist.c b/envlist.c
> index f23
Am 22.05.2012 12:16, schrieb Jim Meyering:
> From: Jim Meyering
>
> Without this, envlist_to_environ may silently fail to copy all
> strings into the destination buffer, and both callers would leak
> any env strings allocated after a failing strdup, because the
> freeing code stops at the first N
Am 17.08.2012 17:34, schrieb Jim Meyering:
> Andreas Färber wrote:
>
>> Am 17.08.2012 15:35, schrieb Jim Meyering:
>>> Jim Meyering wrote:
>>>> From: Jim Meyering
>>>>
>>>> Without this, envlist_to_environ may silently fail to copy all
&
nthony, do you want a prep PULL for this now? Otherwise explicitly:
Acked-by: Andreas Färber
Regards,
Andreas
> ---
> hw/i82378.c |1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/hw/i82378.c b/hw/i82378.c
> index 9b11d90..2123c14 100644
> --- a/h
Not being too familiar with the USB code I wonder if $subject was
supposed to say "and cancel"?
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
Am 17.08.2012 20:24, schrieb Jim Meyering:
> From: Jim Meyering
>
> Convert each TAB(width-4) to equivalent spaces.
> Put braces around each one-line if-body.
>
> Signed-off-by: Jim Meyering
Reviewed-by: Andreas Färber
Thanks,
Andreas
P.S. CC'ing linux-user folks.
entry = entry->ev_link.le_next, penv++) {
> +*penv = strdup(entry->ev_var);
> +if (*penv == NULL) {
> +char **e = env;
> +while (e <= penv) {
> +free(*e++);
> +}
> +free(env);
> +
Am 17.08.2012 19:53, schrieb Eduardo Habkost:
> It's nice to have a flexible system to maintain CPU models as data, but
> this is holding us from making improvements in the CPU code because it's
> not using the common infra-structure, and because the machine-type data
> is still inside C code.
>
>
Am 20.08.2012 04:18, schrieb Peter Crosthwaite:
> [...] Here's my code as it stands:
>
> Error *errp = NULL;
> object_property_set_link(OBJECT(dev), OBJECT(cpus[0]), "cpu0", &errp);
> assert_no_error(errp);
There's two pitfalls there, the needed object_property_add_link() that
you stumbled over a
Introduce type constant. Introduce cast macro to drop dummy busdev field
used with FROM_SYSBUS() that would've broken SYS_BUS_DEVICE().
Avoid accessing parent fields directly.
Drop no-op reset function.
Signed-off-by: Andreas Färber
Acked-by: Michael S. Tsirkin
---
hw/grackle_pci.c |
Introduce type constant. Introduce cast macro and drop dummy busdev
field used with FROM_SYSBUS() that would've broken SYS_BUS_DEVICE().
Avoid accessing parent fields directly.
Signed-off-by: Andreas Färber
Acked-by: Michael S. Tsirkin
---
hw/dec_pci.c | 21 +++-
Introduce type constant and cast macro. Avoid accessing parent fields
directly.
Also add missing space and braces.
Signed-off-by: Andreas Färber
Acked-by: Michael S. Tsirkin
---
hw/prep_pci.c | 17 -
1 files changed, 12 insertions(+), 5 deletions(-)
diff --git a/hw
Adopt the QOM parent field name and enforce QOM-style access via casts.
Don't just typedef PCIHostState, either use it directly or embed it.
Signed-off-by: Andreas Färber
---
hw/alpha_typhoon.c |2 +-
hw/dec_pci.c |2 +-
hw/grackle_pci.c |2 +-
hw/gt64xxx.c |
Introduce type constant. Avoid accessing DeviceState or SysBusDevice
indirectly through PCIHostState field.
Drop global state by passing BonitoState as opaque and adding the IRQs
and a pointer to PCIBonitoState to its state.
Signed-off-by: Andreas Färber
Acked-by: Michael S. Tsirkin
---
hw
Introduce type constant and cast macro. Don't access DeviceState
or PCIHostState indirectly through parent fields.
Signed-off-by: Andreas Färber
Acked-by: Michael S. Tsirkin
---
hw/alpha_typhoon.c | 20 +---
1 files changed, 13 insertions(+), 7 deletions(-)
diff --git
During the QOM migration they were amended with further info but this is
no longer the case. All static TypeInfos can be const these days.
Signed-off-by: Andreas Färber
Acked-by: Michael S. Tsirkin
---
hw/alpha_typhoon.c |2 +-
hw/bonito.c|4 ++--
hw/dec_pci.c |6
Introduce type constant. Introduce cast macro to drop dummy busdev field
used with FROM_SYSBUS() macro that would've broken SYS_BUS_DEVICE().
Avoid accessing DeviceState indirectly through PCIHostState.
Signed-off-by: Andreas Färber
Acked-by: Michael S. Tsirkin
---
hw/gt64xxx.c |
Introduce type constant and cast macro. Avoid accessing its parent field
directly.
Signed-off-by: Andreas Färber
Acked-by: Michael S. Tsirkin
---
hw/ppc440_bamboo.c |3 ++-
hw/ppc4xx.h|2 ++
hw/ppc4xx_pci.c| 13 -
3 files changed, 12 insertions(+), 6 deletions
r-upstream'
(0d16fdd732d1b211842fa96b7c90ddf9e6bde0e4), which removed busdev field
differently, moved some code around and added new occurrences of 'phb'.
Signed-off-by: Andreas Färber
---
hw/spapr.c |7 ++--
hw/spapr_pci.c | 90 +--
hw/
changes to clarify the name/parent changes.
* Split off cleanups per host bridge.
* Prepared and enforced QOM-style field access through explicit types.
v1 -> v2:
* Converted remaining PCI host bridges to new type.
Andreas Färber (14):
pci: Make host bridge TypeInfos const
alpha_typh
Introduce type constants and cast macros.
Avoid accessing parent fields directly.
Signed-off-by: Andreas Färber
Acked-by: Michael S. Tsirkin
---
hw/unin_pci.c | 133 ++---
1 files changed, 70 insertions(+), 63 deletions(-)
diff --git a/hw
From: Andreas Färber
The preceding commits fixed misuses of FROM_SYSBUS() that led people to
add a bogus busdev field. For qdev the field order was less relevant but
for QOM the PCIHostState field (including the SysBusDevice actually
initialized with a value) must be placed first within the
Introduce type constant and cast macro. Avoid accessing parent fields
directly.
Signed-off-by: Andreas Färber
Acked-by: Michael S. Tsirkin
---
hw/ppce500_pci.c | 16 +++-
1 files changed, 11 insertions(+), 5 deletions(-)
diff --git a/hw/ppce500_pci.c b/hw/ppce500_pci.c
index
Use PCIHostState and PCI_HOST_BRIDGE() where appropriate.
Signed-off-by: Andreas Färber
---
hw/alpha_typhoon.c |4 ++--
hw/bonito.c| 22 +++---
hw/dec_pci.c |4 ++--
hw/grackle_pci.c |6 +++---
hw/gt64xxx.c |4 ++--
hw/piix_pci.c
Am 21.08.2012 01:41, schrieb Meador Inge:
> While running in the usermode emulator all of the MIPS32r2 *required*
> RDHWR hardware registers should be accessible (the Linux kernel enables
> access to these same registers).
>
> Signed-off-by: Meador Inge
> ---
> target-mips/translate.c |7 +++
Am 21.08.2012 00:33, schrieb Alexander Graf:
> This updates the OpenBIOS binaries for PPC to svn revision 1063,
> fixing -M g3beige with large PCI memory users.
>
> Signed-off-by: Alexander Graf
> ---
> pc-bios/README |3 ++-
> pc-bios/openbios-ppc | Bin 729876 -> 750392 bytes
> 2 fi
Place it in alphabetical order and add new Devices section ppc4xx to
share file rules with 405 and virtex_ml507.
Signed-off-by: Andreas Färber
Cc: Alexander Graf
---
MAINTAINERS | 12
1 files changed, 12 insertions(+), 0 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index
1 - 100 of 10586 matches
Mail list logo
