Re: Review Request 29889: Recover Docker containers when mesos slave is in a container

2015-05-23 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29889/#review85080 --- Ship it! docs/configuration.md

Re: Review Request 34581: Added oversubscription.proto for QoS Controller and slave communication

2015-05-23 Thread Marco Massenzio
> On May 23, 2015, 3:35 p.m., Niklas Nielsen wrote: > > LGTM! > > > > Marco - mind taking a look at the comments and see if there are more things > > we need to discuss? done, thanks - Marco --- This is an automatically generated e-ma

Re: Review Request 34581: Added oversubscription.proto for QoS Controller and slave communication

2015-05-23 Thread Marco Massenzio
> On May 22, 2015, 8:50 p.m., Marco Massenzio wrote: > > include/mesos/slave/oversubscription.proto, line 34 > > > > > > please consider calling this `QosCorrectiveAction` > > (we require CamelCase for our types, in

Re: Review Request 34361: converted hard-coded strings to consts

2015-05-23 Thread Colin Williams
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34361/ --- (Updated May 23, 2015, 8:02 p.m.) Review request for mesos. Changes ---

Review Request 34633: Added QoS Controller test.

2015-05-23 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34633/ --- Review request for mesos. Repository: mesos Description --- Added new Qo

Review Request 34632: Added QoS Controller in slave

2015-05-23 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34632/ --- Review request for mesos. Repository: mesos Description --- Wired up QoS

Review Request 34631: Added QoS Controller.

2015-05-23 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34631/ --- Review request for mesos. Repository: mesos Description --- Added QoS Co

Re: Review Request 34581: Added oversubscription.proto for QoS Controller and slave communication

2015-05-23 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34581/#review85067 --- Ship it! LGTM! Marco - mind taking a look at the comments and see

Re: Review Request 13709: Fixed typos and added .gitignore

2015-05-23 Thread Michael Park
> On Aug. 22, 2013, 11:38 p.m., Ben Mahler wrote: > > I'm ok with adding these kinds of things to .gitignore. > > Marco Massenzio wrote: > I'm confused here - see comments to https://reviews.apache.org/r/33448 > > Also, what's the relationship with .gitignore-template? are we droppi

Re: Review Request 34375: Removed use of namespace aliases.

2015-05-23 Thread Michael Park
> On May 19, 2015, 2:02 a.m., Ben Mahler wrote: > > This might be a valid namespace alias use case that we hadn't considered, > > because there is no way to be able to write just `http::Response` > > otherwise, is there? > > > > Seems quite verbose to write process::http everywhere, and on the