Re: [Spacewalk-devel] [PATCH] SystemManagerTest: missing super.setUp() call added

2013-09-09 Thread Silvio Moioli
Sorry, I did not check Grant's latest commits. Please ignore this patch. Regards, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com

Re: [Spacewalk-devel] [PATCH] SUSE/AutoYaST Support

2011-03-11 Thread Uwe Gansert
on Friday 11 March 2011 Uwe Gansert wrote: Patch attached. btw, the attached patch replaced the old: 0001-added-support-for-SUSE-autoinstallation.patch Sorry if I confused you. I did not mention that in my previous mail -- ciao, Uwe Gansert Uwe Gansert SUSE LINUX Products GmbH, GF

Re: [Spacewalk-devel] [PATCH] avoid link-jars task when executing make-eclipse-project

2013-05-18 Thread Silvio Moioli
On 17 May, 2013, at 15:32, Grant Gainey ggai...@redhat.com wrote: Good idea! However, I'd like to not change the existing default behavior. What do think about the attached patch instead? It is perfectly OK to me, please merge it. Thank you very much, Silvio

[Spacewalk-devel] [PATCH] SystemManagerTest: missing super.setUp() call added

2013-09-09 Thread Silvio Moioli
See attached patch. Regards, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany From 8377a9ba5f349a661f49a7f0ad9c393f7745f0fc Mon Sep 17 00:00:00 2001 From: Silvio Moioli smoi...@suse.de Date: Thu, 5 Sep 2013 09:11:37 +0200 Subject: [PATCH] SystemManagerTest

[Spacewalk-devel] [PATCH] MonitoringManagerTest: missing super.setUp() call added

2013-09-09 Thread Silvio Moioli
See attached patch. Regards, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany From 5865f906d561acb613addd31fa7e6b9e4e05e8af Mon Sep 17 00:00:00 2001 From: Silvio Moioli smoi...@suse.de Date: Wed, 4 Sep 2013 11:58:10 +0200 Subject: [PATCH] MonitoringManagerTest

Re: [Spacewalk-devel] [PATCH] SUSE/AutoYaST Support

2011-03-10 Thread Uwe Gansert
on Thursday 10 March 2011 Jan Pazdziora wrote: By the way, do you guys use the Spacewalk nightly yum repos as a way of quickly checking what got to upstream, or do you use git only? we only use the git so far -- ciao, Uwe Gansert Uwe Gansert SUSE LINUX Products GmbH, GF: Markus Rex, HRB

Re: [Spacewalk-devel] [PATCH] avoid relying on types returned by Hibernate

2013-07-01 Thread Silvio Moioli
On 07/01/2013 01:12 PM, Tomas Lestach wrote: Could you point me to the appropriate bugzilla? I'd like to check the reproducer. Unfortunately our Bugzilla component is closed for outside view at the moment, and the bug only affected SUSE-specific code. If you need any further details, just let

Re: [Spacewalk-devel] [PATCH] Date/Time picker

2014-02-10 Thread Silvio Moioli
On 02/06/2014 11:12 AM, Duncan Mac-Vicar P. wrote: See attached patches. [...] On a slightly unrelated note, I have just noticed the current date picker allows incorrect dates to be picked, such as February 31. In the SSM errata scheduling page, among other things, such values cause a NPE.

Re: [Spacewalk-devel] [PATCH] Hide the 'delete note' link on creation of system notes

2011-03-01 Thread Johannes Renner
On 03/01/2011 02:29 PM, Jan Pazdziora wrote: By the way: will you be submitting the patch for the Has Signed Metadata feature as well? Yes, this one is also going to be submitted, but unfortunately I can't tell you exactly when. The problem is that this is currently not a single patch

Re: [Spacewalk-devel] [PATCH] change jabberd default password

2012-08-10 Thread Uwe Gansert
On 10.08.2012 14:25, Milan Zazrivec wrote: From jabberd's post install script: ah okay, our jabberd package has no post-script like that. Are you aware of any scenario when this wouldn't be happenning? Or to put my question differently -- what is the motivation behind this patch? I did

Re: [Spacewalk-devel] [PATCH] Proposal to remove filesystem dependencies from ConfigTest

2013-11-06 Thread Silvio Moioli
On 11/06/2013 04:23 PM, Tomas Lestach wrote: I am sorry, it took me so long to reply. No problem. Honestly, we do not really like the proposed patch, but on the other hand we didn't come with anything better. :-) Oh, I see :-) Anyway if you ever come up with a better idea I am always open

Re: [Spacewalk-devel] [PATCH] perl List port to new css/markup

2014-01-09 Thread Duncan Mac-Vicar P.
On 06/01/14 17:13, Michael Mraka wrote: I've reviewed your patch and found couple of issues: Attached patch with all mentioned issues corrected. It's a legacy code and I'm afraid no current spacewalk developer knows correct answer. Ok, I will need to check if this causes some list

Re: [Spacewalk-devel] [PATCH] Hide the 'delete note' link on creation of system notes

2011-03-01 Thread Jan Pazdziora
On Tue, Mar 01, 2011 at 11:26:57AM +0100, Johannes Renner wrote: From ea324e8b7b6907f24d010b7b4439bc1e00e8f8bf Mon Sep 17 00:00:00 2001 From: Johannes Renner jren...@suse.de Date: Thu, 17 Feb 2011 11:20:52 +0100 Subject: [PATCH] do not show delete link on creation of notes (bnc#672090) One

Re: [Spacewalk-devel] PATCH - Addesd cobbler import support for SUSE

2011-04-05 Thread Uwe Gansert
on Tuesday 05 April 2011 Cliff Perry wrote: Spacewalk uses upstream cobbler versions and does not keep a local copy/branch. As such, this patch, which to me looks to be all cobbler should be sent to cobbler-devel list. *ups* sorry, that was my actual intention. I wanted to send it to cobbler

Re: [Spacewalk-devel] [PATCH] some patches for monitoring on postgres and pylint findings

2011-11-28 Thread Miroslav Suchy
Dne 28.11.2011 17:33, Michael Calmer napsal(a): 0004-replace-synonyms-with-real-table-names-and-change-sy.patch From ab387975796b4b04a4ccab2cd600f01d0b69db2a Mon Sep 17 00:00:00 2001 From: Michael Calmerm...@suse.de Date: Mon, 28 Nov 2011 16:30:11 +0100 Subject: [PATCH 4/6] replace synonyms

Re: [Spacewalk-devel] Deployment of images built with SUSE Studio

2012-05-18 Thread Johannes Renner
On 05/18/2012 02:45 PM, Miroslav Suchy wrote: In patch 0001 - schema db - you are missing upgrades for table suseCredentialsType. And upgrades for table suseCredentials differs from clean install. Oh yeah, sorry, I forgot to revise the upgrade files. I can come up with another patch fixing

Re: [Spacewalk-devel] [PATCH] rhn.manager tests: do not assume an Org admin exists

2013-09-10 Thread Silvio Moioli
On 09/09/2013 09:34 PM, Grant Gainey wrote: I modified the patch somewhat - [...] Thanks for your contribution! I agree with your changes and confirm it works perfectly throughout our test suite as well. Thanks a lot for all review and commit work so far, we will be back with some more patches

Re: [Spacewalk-devel] ISE when changing user details on /rhn/users/UserDetails.do?uid=2

2013-10-17 Thread Johannes Renner
On 10/17/2013 04:17 PM, Tomáš Kašpárek wrote: Hello, I've merged contents of bootstrap-css branch with current Spacewalk master, built it and applied. I've noticed that changing user details as admin produces ISE. Sending you patch which fixes the problem Thank you very much

[Spacewalk-devel] [PATCH] Checkstyle 4.1 vs. 4.3

2012-03-30 Thread Johannes Renner
0bcacfc4bbc032c17263198f5bc8dde4ec000aef Mon Sep 17 00:00:00 2001 From: Johannes Renner jren...@suse.de Date: Fri, 30 Mar 2012 10:26:25 +0200 Subject: [PATCH] Add lib directory to checkstyle classpath --- java/spacewalk-java.spec |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

Re: [Spacewalk-devel] [PATCH] VirtualizationEntitlementsManagerTest fixes

2013-09-09 Thread Silvio Moioli
8b9f6060b5db94e49edb9fb804562a89bc188580 Mon Sep 17 00:00:00 2001 From: Silvio Moioli smoi...@suse.de Date: Mon, 9 Sep 2013 08:52:14 +0200 Subject: [PATCH 2/2] VirtualizationEntitlementsManagerTest: do not fail after rollback --- .../rhn/manager/system/test/VirtualizationEntitlementsManagerTest.java | 2 +- 1 file changed, 1

Re: [Spacewalk-devel] [PATCH] build spacewalk-koan on openSUSE

2011-04-15 Thread Michael Calmer
Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) From 31124cc61c32c66f71f1842e212349936cbfac14 Mon Sep 17 00:00:00 2001 From: Michael Calmer m...@suse.de Date: Fri, 15 Apr 2011 11:50:44 +0200 Subject: [PATCH 10/13] build spacewalk-koan on SUSE - BuildRequire rhn-client-tools to provide

Re: [Spacewalk-devel] [PATCH] build spacewalk-remote-utils on openSUSE

2011-04-15 Thread Michael Calmer
Hi, Am Freitag, 8. April 2011, 15:14:25 schrieb Michael Calmer: Hi, here is the patch to build spacewalk-remote-utils on openSUSE. 0012-build-spacewalk-remote-utils-on-SUSE.patch - adding only one little dir to the filelist of the specfile Attached is a new version of this patch. It now

Re: [Spacewalk-devel] [Patch] fix size of kernel_options field for autoinstallation

2012-04-25 Thread Uwe Gansert
On 25.04.2012 16:24, Tomas Lestach wrote: - I believe cobbler cannot handle more than 255 long kernel options I'm not aware of such a limit and a quick test showed that at least 320 chars work :) - the change is done on one place only , what about the other occurences, f.e.

Re: [Spacewalk-devel] Deployment of images built with SUSE Studio

2012-05-15 Thread Uwe Gansert
On 15.05.2012 13:25, Miroslav Suchy wrote: The Python code was revised by Uwe, see patch 0002 and 0003. print filePath ^^ This probably omitted from some debugging. you are right of course. That line slipped in accidently from a debugging session and can be removed. -- ciao, Uwe Gansert

Re: [Spacewalk-devel] [PATCH] Script contents not properly displayed

2012-08-14 Thread Johannes Renner
On 08/14/2012 03:36 PM, Stephen Herr wrote: Johannes, Could you ensure in /usr/share/pgsql/postgresql.conf that bytea_output = 'escape', and if not see if that corrects your problem? -Stephen Thanks, setting this option fixes the problem on the postgres 9.1 database we are using. We

Re: [Spacewalk-devel] [PATCH] Kickstartable channels should contain the anaconda package

2013-03-25 Thread Duncan Mac-Vicar P.
On 22/03/13 14:55, Michael Calmer wrote: Hi, please do not apply these patches. I found out, that it is not correct. It removes the channels at more places than needed. It would still be interesting to create a discussion around how to define a kickstartable channel. -- Duncan Mac-Vicar

Re: [Spacewalk-devel] [PATCH] SSH Push Feature Proposal

2013-04-30 Thread Duncan Mac-Vicar P.
On 24/04/13 14:38, Johannes Renner wrote: Can the logic you propose to be put to taskomatic be put to osa-dispatcher, to throttle the number of clients which get invited to rhn_check? Doesn't osad work by having the clients connect via XMPP _to_ the server? -- Duncan Mac-Vicar P. -

Re: [Spacewalk-devel] [PATCH] UpdateErrataCacheCommand: log an error when orgId is incorrect

2013-09-09 Thread Silvio Moioli
On 09/09/2013 10:03 AM, Tomas Lestach wrote: So, what is the motivation of this change? (The only scenario I can imagine is, that the errata cache event will be queued and its organization gets deleted before the background errata cache action gets executed.) I think that is exactly the

Re: [Spacewalk-devel] Patch proposal: try-wrapping XMLRPC serialization code

2013-10-02 Thread Silvio Moioli
On 10/01/2013 10:58 PM, Grant Gainey wrote: I decided there *had to* be a better way to do this - and I found one! Great! More Eyes would be great. Actually, Taskomatic classes were left out (probably overlooked). I added them in commit c29e22. Apart from that, changes look good and also

Re: [Spacewalk-devel] [PATCH] Adding a password strength meter to spacewalk

2014-01-07 Thread Johannes Renner
On 01/07/2014 10:54 AM, Michael Mraka wrote: Maximilian Meister wrote: % Hi everybody, % ... Hello Maximilian, Is the spacewalk-pwstrength.js a copy of jquery.pwstrength.bootstrap (i.e. third party stuff) or your own implementation of it? Currently it's basically a copy of third party

Re: [Spacewalk-devel] editarea and apache 2.4

2014-02-13 Thread Duncan Mac-Vicar P.
On 13/02/14 10:10, Michael Mraka wrote: Duncan Mac-Vicar P. wrote: Hello Duncan, Thanks for the patch. Currently we focus on Spacewalk 2.1 release so we will take a look on it after the release. Makes sense. I plan to push it for our release. If you see something totally wrong

Re: [Spacewalk-devel] [PATCH] Date/Time picker

2014-02-14 Thread Duncan Mac-Vicar P.
Thanks for the review and fixes!. Most of it looks good except for the self-closing tag as Silvio explained. There are other changes that I would like to understand: - The css part where you override some styles (and use !important, which basically means SUSE Manager can't override it again in

[Spacewalk-devel] [PATCH] Password with less than minlength characters accepted

2011-01-27 Thread Johannes Renner
in not being able to login anymore after sign out! Attached is a patch that fixes the problem. Greetings, Johannes Renner -- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) From 57bac09f19795e5fc4c21514da4ac20bef9cc79d Mon Sep 17 00:00:00 2001 From: Johannes Renner jren...@suse.de Date

[Spacewalk-devel] [PATCH] rhn-custom-info

2011-04-07 Thread Michael Calmer
: Markus Rex, HRB 16746 (AG Nürnberg) From c8c5bd99efdd0188464b1d9de2fd9f8ba6d6331a Mon Sep 17 00:00:00 2001 From: Michael Calmer m...@suse.de Date: Thu, 7 Apr 2011 12:00:52 +0200 Subject: [PATCH] fix rhn-custom-info - getServerURL() return now an array. Use the first value - sslCACert is now from type

[Spacewalk-devel] [PATCH] build rhn-custom-info on openSUSE

2011-04-08 Thread Michael Calmer
Mon Sep 17 00:00:00 2001 From: Michael Calmer m...@suse.de Date: Mon, 4 Apr 2011 16:13:39 +0200 Subject: [PATCH 08/17] build rhn-custom-info on SUSE - modify the specfile --- client/tools/rhncustominfo/rhn-custom-info.spec |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git

[Spacewalk-devel] [PATCH] build rhnpush on openSUSE

2011-04-08 Thread Michael Calmer
:00 2001 From: Michael Calmer m...@suse.de Date: Mon, 4 Apr 2011 16:26:21 +0200 Subject: [PATCH 09/17] build rhnpush on SUSE - modify the specfile --- client/tools/rhnpush/rhnpush.spec |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/client/tools/rhnpush/rhnpush.spec b

[Spacewalk-devel] [PATCH] build spacewalk-koan on openSUSE

2011-04-08 Thread Michael Calmer
Hi, here is the patch to build spacewalk-koan on openSUSE. 0011-build-spacewalk-koan-on-SUSE.patch: - modify the specfile - require virtualization packages It seems, that code of spacewalk-koan import modules from rhn-virtualization. So I added these requires to the specfile

[Spacewalk-devel] [PATCH] build spacewalk-remote-utils on openSUSE

2011-04-08 Thread Michael Calmer
be0b18e181d32a2d20a586f1f07304d73ee3ad01 Mon Sep 17 00:00:00 2001 From: Michael Calmer m...@suse.de Date: Tue, 5 Apr 2011 11:00:52 +0200 Subject: [PATCH 12/17] build spacewalk-remote-utils on SUSE - modify the specfile --- .../spacewalk-remote-utils.spec|1 + 1 files changed, 1

[Spacewalk-devel] [PATCH] Error message when successfully toggling user roles

2011-09-06 Thread Johannes Renner
9138ab493776b334005c8ab63f635284b913da6e Mon Sep 17 00:00:00 2001 From: Johannes Renner jren...@suse.de Date: Tue, 6 Sep 2011 10:03:55 +0200 Subject: [PATCH] Do not send error message in case of success --- .../frontend/action/multiorg/SatAdminAction.java |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff

[Spacewalk-devel] [PATCH] fix for wrong transaction name

2012-06-05 Thread Michael Calmer
HRB 16746 (AG Nürnberg) From 6a1fcba3370deb52c6e12c1cdc08b75c7a1b7ede Mon Sep 17 00:00:00 2001 From: Michael Calmer m...@suse.de Date: Tue, 5 Jun 2012 11:47:33 +0200 Subject: [PATCH] fix wrong transaction name in unsubscribe_channels --- backend/server/rhnChannel.py |2 +- 1 files changed, 1

[Spacewalk-devel] [PATCH] CVEs missing in the security patches listing (on Oracle 11)

2012-08-17 Thread Johannes Renner
dd9bf777412f470c7a8fee58408b495036f0d55b Mon Sep 17 00:00:00 2001 From: Johannes Renner jren...@suse.de Date: Fri, 17 Aug 2012 12:06:49 +0200 Subject: [PATCH] Fix missing CVEs in patches listing with Oracle 11 --- .../rhn/frontend/dto/SecurityErrataOverview.java |2 +- 1 files changed, 1 insertions(+), 1 deletions

Re: [Spacewalk-devel] [PATCH] Kickstartable channels should contain the anaconda package

2013-03-14 Thread Johannes Renner
Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer From acaadc6ee2a54f2e803f33ff5d401559b2e35359 Mon Sep 17 00:00:00 2001 From: Johannes Renner jren...@suse.de Date: Thu, 14 Mar 2013 17:52:15 +0100 Subject: [PATCH] Prevent from concurrent modification --- .../code

[Spacewalk-devel] [PATCH] Add missing string systems.details.virt.actions.scheduled

2013-04-16 Thread Johannes Renner
VirtualGuestsConfirmAction.java though, so the attached patch puts it back in place. Regards, Johannes -- SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer From d1a7f3acdecb7dbd988f0da5237c08d2cc2809f2 Mon Sep 17 00:00:00 2001 From: Johannes Renner jren...@suse.de Date: Tue

[Spacewalk-devel] [PATCH] avoid link-jars task when executing make-eclipse-project

2013-05-08 Thread Silvio Moioli
. because they are available, but in other locations). I attached a simple patch that removes the dependency. Regards, Silvio Moioli From 541498264598781c2c8656bf03abe63a8bc04277 Mon Sep 17 00:00:00 2001 From: Silvio Moioli smoi...@suse.de Date: Tue, 7 May 2013 09:50:52 +0200 Subject: [PATCH] Removed

[Spacewalk-devel] [PATCH] Fix indentation on user preferences page

2013-07-12 Thread Johannes Renner
. Thanks and regards, Johannes -- SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer From b687d7444374ca60fdc6a8387e70013e3acb8f12 Mon Sep 17 00:00:00 2001 From: Johannes Renner jren...@suse.de Date: Fri, 12 Jul 2013 11:33:30 +0200 Subject: [PATCH] Fix

[Spacewalk-devel] [PATCH] Fix ISE when UUID and host ID is null

2013-07-19 Thread Johannes Renner
16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer From 1e0f80e4b6f43ade890dd3dae2a71bb4544dff01 Mon Sep 17 00:00:00 2001 From: Johannes Renner jren...@suse.de Date: Fri, 19 Jul 2013 13:39:51 +0200 Subject: [PATCH] Fix ISE when UUID and host ID is null --- .../rhn/frontend/action

[Spacewalk-devel] [PATCH] Fix html not being escaped in package information

2013-08-05 Thread Johannes Renner
, Johannes -- SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer From 63be1b2d99b4a594e3cd198565ea5a13197aae87 Mon Sep 17 00:00:00 2001 From: Johannes Renner jren...@suse.de Date: Mon, 5 Aug 2013 15:42:53 +0200 Subject: [PATCH] Fix HTML not being escaped

[Spacewalk-devel] Patch: adapt LocalizationServiceTest to run on all JDKs

2013-08-14 Thread Silvio Moioli
: Silvio Moioli smoi...@suse.de Date: Wed, 14 Aug 2013 16:14:30 +0200 Subject: [PATCH] LocalizationServiceTest: run on JDKs without fix for bug 6609737 --- .../redhat/rhn/common/localization/test/LocalizationServiceTest.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[Spacewalk-devel] [PATCH] UserManagerTest: don't rely on hardcoded default time zone

2013-09-09 Thread Silvio Moioli
6b807ef7be31c1e4fc2a08a77cf8944a634234ee Mon Sep 17 00:00:00 2001 From: Silvio Moioli smoi...@suse.de Date: Thu, 5 Sep 2013 15:16:40 +0200 Subject: [PATCH] UserManagerTest: don't rely on hardcoded default time zone --- java/code/src/com/redhat/rhn/manager/user/test/UserManagerTest.java | 4 ++-- 1 file changed, 2 insertions

[Spacewalk-devel] [PATCH] ConfigureSatelliteCommandTest: do not rely on HashMap key ordering

2013-09-09 Thread Silvio Moioli
005e216a8cba6ace617750dfb09dc170fbd60ac9 Mon Sep 17 00:00:00 2001 From: Silvio Moioli smoi...@suse.de Date: Fri, 6 Sep 2013 08:23:06 +0200 Subject: [PATCH] ConfigureSatelliteCommandTest: do not rely on HashMap key ordering --- .../rhn/manager/satellite/test/ConfigureSatelliteCommandTest.java | 6 +++--- 1

[Spacewalk-devel] [PATCH] UpdateErrataCacheCommand: log an error when orgId is incorrect

2013-09-09 Thread Silvio Moioli
5, 90409 Nürnberg Germany From 5a061de30a4c26acb841a65cfe8314f712b9f967 Mon Sep 17 00:00:00 2001 From: Silvio Moioli smoi...@suse.de Date: Wed, 4 Sep 2013 13:34:31 +0200 Subject: [PATCH] UpdateErrataCacheCommand: log an error when orgId is incorrect --- .../redhat/rhn/manager/errata/cache

[Spacewalk-devel] [PATCH] MasterHandlerTest: handle getDefaultMaster exceptions

2013-09-12 Thread Silvio Moioli
SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany From 463c0da101a290bbee3449d6c77bfce415cad696 Mon Sep 17 00:00:00 2001 From: Silvio Moioli smoi...@suse.de Date: Mon, 9 Sep 2013 13:48:27 +0200 Subject: [PATCH 06/22] MasterHandlerTest: handle getDefaultMaster exceptions correctly

[Spacewalk-devel] [PATCH] SystemHandlerTest: do not rely on hardcoded sequence ids

2013-09-12 Thread Silvio Moioli
simply relaxed that condition accordingly. See attached patch. Regards, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany From ec1b4e81c7e82005293bb50623aa6bef8bdcc92c Mon Sep 17 00:00:00 2001 From: Silvio Moioli smoi...@suse.de Date: Wed, 11 Sep 2013 15:00:56 +0200

[Spacewalk-devel] [PATCH] DownloadActionTest: do not assume file to be downloaded exists

2013-09-12 Thread Silvio Moioli
See attached patch. Regards, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany From 67eef48cbd7a10d9451501ade7d6df9c01a6f430 Mon Sep 17 00:00:00 2001 From: Silvio Moioli smoi...@suse.de Date: Mon, 9 Sep 2013 08:25:23 +0200 Subject: [PATCH 04/22

[Spacewalk-devel] [PATCH] AuthFilterTest: mocked request object updated

2013-09-12 Thread Silvio Moioli
, 90409 Nürnberg Germany From 50ee6b949de7574f92ed87862ad35f8d6b4c7be5 Mon Sep 17 00:00:00 2001 From: Silvio Moioli smoi...@suse.de Date: Tue, 10 Sep 2013 16:53:47 +0200 Subject: [PATCH 12/22] AuthFilterTest: mocked request object updated --- .../src/com/redhat/rhn/frontend/servlets/test

[Spacewalk-devel] [PATCH] VirtualGuestsActionTest: do not rely on query string parameter ordering

2013-09-12 Thread Silvio Moioli
e029423a883b311509addc1cc25508640dae7ae5 Mon Sep 17 00:00:00 2001 From: Silvio Moioli smoi...@suse.de Date: Wed, 11 Sep 2013 13:55:09 +0200 Subject: [PATCH 16/22] VirtualGuestsActionTest: do not rely on query string parameter ordering --- .../action/systems/virtualization/test/VirtualGuestsActionTest.java | 2 +- 1 file

[Spacewalk-devel] [PATCH] ActivationKeyHandlerTest: expect correct exceptions

2013-09-12 Thread Silvio Moioli
17 00:00:00 2001 From: Silvio Moioli smoi...@suse.de Date: Tue, 10 Sep 2013 17:09:03 +0200 Subject: [PATCH 13/22] ActivationKeyHandlerTest: expect correct exceptions --- .../frontend/xmlrpc/activationkey/test/ActivationKeyHandlerTest.java | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions

[Spacewalk-devel] [PATCH] SystemEntitlementsSetupActionTest: do not assume Org has virtualization entitlement

2013-09-13 Thread Silvio Moioli
ae8640bdd4d15e16efdcb2fce7790fc676ab3f8a Mon Sep 17 00:00:00 2001 From: Silvio Moioli smoi...@suse.de Date: Tue, 10 Sep 2013 13:18:03 +0200 Subject: [PATCH 10/22] SystemEntitlementsSetupActionTest: do not assume Org has virtualization entitlement --- .../systems/entitlements/test/SystemEntitlementsSetupActionTest.java

[Spacewalk-devel] [PATCH] KickstartScriptActionTest: missing parameters added

2013-09-13 Thread Silvio Moioli
Moioli smoi...@suse.de Date: Fri, 6 Sep 2013 16:09:34 +0200 Subject: [PATCH 03/22] KickstartScriptActionTest: missing parameters added --- .../frontend/action/kickstart/test/KickstartScriptActionTest.java| 5 + 1 file changed, 5 insertions(+) diff --git a/java/code/src/com/redhat/rhn

[Spacewalk-devel] [PATCH] MethodsSetupActionTest: do not assume that method command exists

2013-09-13 Thread Silvio Moioli
See attached patch. Regards, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany From d49e62923f34a64e5c2caac619d751d9e6010ac4 Mon Sep 17 00:00:00 2001 From: Silvio Moioli smoi...@suse.de Date: Mon, 9 Sep 2013 10:56:06 +0200 Subject: [PATCH 05/22

Re: [Spacewalk-devel] [PATCH] Fix navigation for the default snippets page

2013-11-06 Thread Johannes Renner
: Jeff Hawn, Jennifer Guild, Felix Imendörffer From c3d4d35e6606e625eaf01719d41ef498741b8d2a Mon Sep 17 00:00:00 2001 From: Johannes Renner jren...@suse.de Date: Wed, 6 Nov 2013 10:04:12 +0100 Subject: [PATCH] Use kickstart icon on the snippets page --- java/code/webapp/WEB-INF/pages/kickstart

[Spacewalk-devel] [PATCH] License of spacewalk-branding needs to be changed

2013-11-21 Thread Johannes Renner
From 633c050f3a068aa8a52a217c5f6ea55cd15a3937 Mon Sep 17 00:00:00 2001 From: Johannes Renner jren...@suse.de Date: Thu, 21 Nov 2013 15:00:27 +0100 Subject: [PATCH] Fix the License of spacewalk-branding package --- branding/spacewalk-branding.spec | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[Spacewalk-devel] [PATCH] Fix NPE when uploading kickstart profile

2013-12-18 Thread Johannes Renner
Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer From dbe021e76741e7f8a503ad37021e78deeeb13c3f Mon Sep 17 00:00:00 2001 From: Johannes Renner jren...@suse.de Date: Wed, 18 Dec 2013 11:32:26 +0100 Subject: [PATCH] Fix NPE when uploading kickstart profile with virt type none --- .../frontend

[Spacewalk-devel] [PATCH] SUSE Studio API will stop working via unencrypted HTTP

2014-01-22 Thread Johannes Renner
Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer From f523f1d0188c4094888513026478435db169ce3c Mon Sep 17 00:00:00 2001 From: Johannes Renner jren...@suse.de Date: Wed, 22 Jan 2014 10:41:08 +0100 Subject: [PATCH] SUSE Studio API will stop working via unencrypted

Re: [Spacewalk-devel] devel repo: sync channels from dump

2015-10-26 Thread Silvio Moioli
<m...@suse.de> Date: Thu, 22 Oct 2015 11:54:22 +0200 Subject: [PATCH] ignore all not any longer supported entitlements --- backend/server/importlib/archImport.py | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/backend/server/importlib/archImport.py b/backe

Re: [Spacewalk-devel] [PATCH] Add missing string systems.details.virt.actions.scheduled

2013-04-16 Thread Jan Dobes
- Original Message - From: Johannes Renner jren...@suse.de To: spacewalk-devel@redhat.com Sent: Tuesday, April 16, 2013 3:13:16 PM Subject: [Spacewalk-devel] [PATCH] Add missing string systems.details.virt.actions.scheduled Hi, The string mentioned in subject was apparently removed

Re: [Spacewalk-devel] [PATCH] Fix ISE when UUID and host ID is null

2013-07-22 Thread Jan Dobes
- Original Message - From: Johannes Renner jren...@suse.de To: spacewalk-devel@redhat.com Sent: Friday, July 19, 2013 1:52:38 PM Subject: [Spacewalk-devel] [PATCH] Fix ISE when UUID and host ID is null Hello, I found an error navigating to: https://hostname/rhn/systems

Re: [Spacewalk-devel] [PATCH] Fix html not being escaped in package information

2013-08-06 Thread Tomas Lestach
Hello Johannes, I committed you patch as: https://git.fedorahosted.org/cgit/spacewalk.git/commit/?id=55405e0c57e34c35cd13a482cf95e867661c0829 Thank you! -- Tomas Lestach Red Hat Satellite Engineering, Red Hat - Original Message - From: Johannes Renner jren...@suse.de To: spacewalk

Re: [Spacewalk-devel] Patch: adapt LocalizationServiceTest to run on all JDKs

2013-08-15 Thread Tomas Lestach
Hello Silvio, I committed your patch as: https://git.fedorahosted.org/cgit/spacewalk.git/commit/?id=ec5abc7162569df9c4fc037a855905145a756d48 Thank you, -- Tomas Lestach Red Hat Satellite Engineering, Red Hat - Original Message - From: Silvio Moioli smoi...@suse.de To: spacewalk-devel

Re: [Spacewalk-devel] [PATCH] updateinfo to Errata import in?spacewalk-repo-sync

2011-03-11 Thread Michael Calmer
went much better. Yes, this is the version appended to advisory_name. Here is an example from openSUSE which shows the unique problem updates !--PATCHINFO id=898568de8313f62fc290e303946cfe11!-- update status=stable from=maint-co...@suse.de type=recommended version=1596 idflash

[Spacewalk-devel] [PATCH] small fix for spacewalk-backend

2011-04-08 Thread Michael Calmer
-- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) From 20cb8563e6e1359aae1b97109cdb8bb51f418b74 Mon Sep 17 00:00:00 2001 From: Michael Calmer m...@suse.de Date: Fri, 8 Apr 2011 10:33:32 +0200 Subject: [PATCH 15/17] remove duplicate

[Spacewalk-devel] [PATCH] fix virtual guest state indicator

2011-10-28 Thread Uwe Gansert
guests are stopped, so if you shutdown the last running virtual guest, the poller.py will exit early and will return an empty result to the Spacewalk server who thinks now that nothing has happened. I have attached a patch that removes that optimization as a suggestion for a fix. -- ciao, Uwe

[Spacewalk-devel] [Patch] fix size of kernel_options field for autoinstallation

2012-04-25 Thread Uwe Gansert
Hi, the field in the web UI for the kernel_options is limited to 64 characters. In practice that's not needed. The attached patch solves that by increasing it to 1024 -- ciao, Uwe Gansert SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer Home

[Spacewalk-devel] [PATCH] Fix the Java package of DeleteGroupAction class

2013-12-18 Thread Johannes Renner
8e0a0192c54255e50a760887e1349d55492ab813 Mon Sep 17 00:00:00 2001 From: Johannes Renner jren...@suse.de Date: Wed, 18 Dec 2013 14:57:00 +0100 Subject: [PATCH] Fix the java package of DeleteGroupAction class --- .../src/com/redhat/rhn/frontend/action/groups/DeleteGroupAction.java| 2 +- 1 file changed, 1 insertion

Re: [Spacewalk-devel] [PATCH] SUSE/AutoYaST Support

2011-03-10 Thread Uwe Gansert
52dc10f83aa3c5e3d27a9cb8dad5df15ac67b562 Mon Sep 17 00:00:00 2001 From: Uwe Gansert u...@suse.de Date: Tue, 18 Jan 2011 11:46:57 +0100 Subject: [PATCH 4/5] bnc#664915 rhnreg_ks --help failed if LANG = de_DE.UTF-8 --- client/rhel/rhn-client-tools/src/bin/rhnreg_ks.py |7 ++- 1 files changed, 6 insertions

Re: [Spacewalk-devel] [PATCH] 'es improve channel status display

2013-02-14 Thread Tomas Lestach
it in the channel details page, as the half status was already there. The patches are intended for review, but are not yet rebased against master. commit c523b18667ace8acd5dd835378e87d0be45f9473 Author: Duncan Mac-Vicar P dmacvi...@suse.de Date: Thu Jan 31 17:45:25 2013 +0100 Improve

Re: [Spacewalk-devel] [PATCH] Patch synchronization issue

2013-08-21 Thread Silvio Moioli
found a way how, please, let me know. In our case, the vendor simply changed a patch, adding packages. Custom channels/patches could also run in the same issue. Thanks, regards, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany

[Spacewalk-devel] [PATCH] Patch synchronization issue

2013-08-21 Thread Silvio Moioli
Hello, We recently stumbled upon an issue with patch synchronization, which turned out to be a bug in Hibernate handling of Package objects, which in turn was caused by a strange definition of hashCode() in that class. Steps to reproduce the problem and a proposed patch follow. Reproducing

Re: [Spacewalk-devel] [PATCH] Naming of cloned errata

2012-03-07 Thread Johannes Renner
, Jennifer Guild, Felix Imendörffer From 1397508621edc9e7a4804c3aee46a74a23421bb4 Mon Sep 17 00:00:00 2001 From: Michael Calmer m...@suse.de Date: Wed, 7 Mar 2012 11:13:43 +0100 Subject: [PATCH] Fix naming of cloned patches to not remove the first 3 chars --- web/modules/rhn/RHN/DB/ErrataEditor.pm

Re: [Spacewalk-devel] [PATCH] Show systems that need reboot because of an errata

2012-04-19 Thread Michael Calmer
, Jennifer Guild, Felix Imendörffer HRB 16746 (AG Nürnberg) From dfb7e3e922eee62b615ba1c1294560e85341dd78 Mon Sep 17 00:00:00 2001 From: Michael Calmer m...@suse.de Date: Thu, 19 Apr 2012 11:47:24 +0200 Subject: [PATCH] fix has_errata_with_keyword_applied_since_last_reboot query Fixes

[Spacewalk-devel] [PATCH] junit tests: do not rely on Cobbler

2013-09-12 Thread Silvio Moioli
0351959bb8c0398b1243fa045caa2eb580b8ad4a Mon Sep 17 00:00:00 2001 From: Silvio Moioli smoi...@suse.de Date: Wed, 11 Sep 2013 14:28:05 +0200 Subject: [PATCH 17/22] ActionManagerTest: do not rely on Cobbler, mock the connection --- java/code/src/com/redhat/rhn/manager/action/test/ActionManagerTest.java | 1 + 1

Re: [Spacewalk-devel] [PATCH] build rhncfg on openSUSE

2011-04-15 Thread Michael Calmer
-- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) From b31b81520f06693b299f962eb20bec4c4bd7d01a Mon Sep 17 00:00:00 2001 From: Michael Calmer m...@suse.de Date: Thu, 14 Apr 2011 18:13:25 +0200 Subject: [PATCH 05/13] build rhncfg build on SUSE - provide on SUSE

[Spacewalk-devel] [PATCH] Fix navigation for the default snippets page

2013-11-04 Thread Johannes Renner
6c53744d2759101d20f9603475fdcbf98c475a72 Mon Sep 17 00:00:00 2001 From: Johannes Renner jren...@suse.de Date: Mon, 4 Nov 2013 15:23:37 +0100 Subject: [PATCH] Fix navigation for the default snippets page --- java/code/webapp/WEB-INF/nav/sitenav-authenticated.xml | 1 + 1 file changed, 1 insertion(+) diff --git a/java/code/webapp/WEB

Re: [Spacewalk-devel] [PATCH] updateinfo to Errata import in spacewalk-repo-sync

2011-03-10 Thread Michael Calmer
Hi, Am Mittwoch, 9. März 2011, 11:29:45 schrieb Jan Pazdziora: On Mon, Mar 07, 2011 at 02:28:48PM +0100, Michael Calmer wrote: [...] when running git am, I get the following whitespace-related warnings. Could you please polish the patch to get rid of them? Sure, I will work on all the issues

Re: [Spacewalk-devel] [PATCH] SUSE/AutoYaST Support

2011-03-10 Thread Uwe Gansert
on Thursday 10 March 2011 Jan Pazdziora wrote: we hit the You are not authorized to access bug #674344. for bnc#674344 here. As the patch is trivial, I'm leaning towards dropping the bnc number from the commit message, so that you don't have to go through the trouble of creating

Re: [Spacewalk-devel] [PATCH] Synchronization to Software Profiles

2011-07-29 Thread Johannes Renner
On 07/29/2011 04:33 PM, Cliff Perry wrote: On 07/29/2011 09:55 AM, Johannes Renner wrote: Hello, I fixed a subtle bug in the spacewalk web UI that caused the scheduling of a system's synchronization to a software profile to not work anymore. The patch in the attachment should fix the problem

Re: [Spacewalk-devel] [PATCH] fix display of static snippets

2011-12-01 Thread Uwe Gansert
? patch attached -- ciao, Uwe Gansert SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer Home: http://www.suse.de/~ug - Blog: http://suse.gansert.net diff --git a/java/code/webapp/WEB-INF/pages/kickstart/cobbler/snippetview.jsp b/java/code/webapp/WEB

Re: [Spacewalk-devel] [PATCH] Fix query to determine available config channels in SSM

2011-12-06 Thread Johannes Renner
On 12/05/2011 06:53 PM, Michael Mraka wrote: Hi Johannes, although Tomas commited your patch neither original version nor yours are correct. a) Select from rhnSet was not restricted to user so it might interfere with other users SSM servers. b) Two servers in SSM and three channels

Re: [Spacewalk-devel] [PATCH] Bug about cloned channels and errata

2012-03-09 Thread Johannes Renner
for your servers, however they're not associated with any errata. For these cases errata_id is null. Regards, Tomas Well, in this case everything is probably fine as it is right now and we don't need to patch anything. Thanks, Johannes -- SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg

Re: [Spacewalk-devel] [PATCH] WebUI HTTP proxy validator doesn't check for special characters

2012-11-14 Thread Johannes Renner
, '.' and '-', but no whitespace or any special characters. See my attached patch. Greetings, Johannes Applied as: ebc61c00 I just needed to commit 2 checkstyle fixes. :-) Ah, sorry, I forgot to check (the style). Thanks for pushing the commits! -- SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg

Re: [Spacewalk-devel] [PATCH] Avoid a possible concurrency issue on RhnSet update

2013-09-05 Thread Silvio Moioli
ignoring them, yet accepting failures in this specific case. I will be back with a patch as soon as I have tested it. Thanks for the discussion by the way, as problems in this topic are traditionally difficult to handle! Regards, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409

Re: [Spacewalk-devel] [PATCH] build rhn-custom-info on openSUSE

2011-04-15 Thread Michael Calmer
:00:00 2001 From: Michael Calmer m...@suse.de Date: Fri, 15 Apr 2011 10:24:18 +0200 Subject: [PATCH 07/13] build rhn-custom-info on SUSE - require zypp-plugin-spacewalk - BuildRequire rhn-client-tools for the filelist check in OBS --- client/tools/rhncustominfo/rhn-custom-info.spec |7

Re: [Spacewalk-devel] [PATCH] build rhnpush on openSUSE

2011-04-15 Thread Michael Calmer
7377dc046ff4a1bb2ad4eb480e5f0ba8ff40ccb6 Mon Sep 17 00:00:00 2001 From: Michael Calmer m...@suse.de Date: Fri, 15 Apr 2011 10:30:07 +0200 Subject: [PATCH 08/13] build rhnpush on SUSE - BuildRequire rhn-client-tools to provide rhn directories for the filelist check in OBS --- client/tools/rhnpush/rhnpush.spec |4

Re: [Spacewalk-devel] Timezone problem with DB timestamps

2012-07-31 Thread Johannes Renner
57cc8bee7b5d77486671cff244551d12a95cdcb2 Mon Sep 17 00:00:00 2001 From: Johannes Renner jren...@suse.de Date: Tue, 31 Jul 2012 16:03:40 +0200 Subject: [PATCH] Fix wrong package build times in repository metadata --- .../com/redhat/rhn/frontend/dto/PackageDto.java| 12 +++- 1 files changed, 11 insertions(+), 1

[Spacewalk-devel] [PATCH] VirtualizationEntitlementsManagerTest fixes

2013-09-09 Thread Silvio Moioli
); assertTrue(!l.isEmpty()); assertEquals(1, l.size()); -- 1.8.1.4 From 7b7b2a28ed9bf4181e74d2768d981ce1a34f320d Mon Sep 17 00:00:00 2001 From: Silvio Moioli smoi...@suse.de Date: Thu, 5 Sep 2013 11:52:58 +0200 Subject: [PATCH 1/2] VirtualizationEntitlementsManagerTest: do

[Spacewalk-devel] [PATCH] Hide the 'delete note' link on creation of system notes

2011-03-01 Thread Johannes Renner
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hello, Attached is a small patch for the jsp page that is used for editing system notes. It hides the delete note link when a system note is currently being created. This is done by including the toolbar within the c:choose element. Clicking

[Spacewalk-devel] [PATCH] Do not show success message when passwords don't match

2011-03-28 Thread Johannes Renner
don't match. Greetings, Johannes -- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) From 5c07c2b9824ff125a0d5f66426b3fe996d94a213 Mon Sep 17 00:00:00 2001 From: Johannes Renner jren...@suse.de Date: Mon, 28 Mar 2011 13:45:25 +0200 Subject: [PATCH] Do not show success message when

[Spacewalk-devel] [PATCH] build rhncfg on openSUSE

2011-04-08 Thread Michael Calmer
: Michael Calmer m...@suse.de Date: Mon, 4 Apr 2011 15:53:50 +0200 Subject: [PATCH 07/17] build rhncfg on SUSE - modify specfile --- client/tools/rhncfg/rhncfg.spec | 12 +++- 1 files changed, 11 insertions(+), 1 deletions(-) diff --git a/client/tools/rhncfg/rhncfg.spec b/client/tools/rhncfg

Re: [Spacewalk-devel] [PATCH] build rhn-client-tools on openSUSE

2011-04-08 Thread Michael Calmer
-- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) From 4ea53dfc537e92fd870cd414fc901edb83f7d288 Mon Sep 17 00:00:00 2001 From: Michael Calmer m...@suse.de Date: Mon, 4 Apr 2011 11:12:04 +0200 Subject: [PATCH 02/17] enhance getOSVersionAndRelease to find SUSE

[Spacewalk-devel] [PATCH] parse V4 RSA/SHA gpg signature keyids correctly from RPM

2011-11-02 Thread Michael Calmer
, GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer HRB 16746 (AG Nürnberg) From c74ee56448aace7ed8be8ae2a00c8f27ed901622 Mon Sep 17 00:00:00 2001 From: Michael Calmer m...@suse.de Date: Wed, 26 Oct 2011 17:19:27 +0200 Subject: [PATCH] support V4 RSA signatures --- backend/common/rhn_rpm.py |4

  1   2   3   4   >